Re: [PATCH net-next v17 03/14] netdev: support binding dma-buf to netdevice

2024-08-06 Thread Markus Elfring
>> … >>> +++ b/include/net/devmem.h >>> @@ -0,0 +1,115 @@ >> … >>> +#ifndef _NET_DEVMEM_H >>> +#define _NET_DEVMEM_H >> … >> >> I suggest to omit leading underscores from such identifiers. >> https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier >> >

Re: [PATCH 1/9] drm/amdgpu: Use backlight power constants

2024-08-06 Thread Thomas Zimmermann
Hi Am 05.08.24 um 21:00 schrieb Deucher, Alexander: [Public] -Original Message- From: Thomas Zimmermann Sent: Wednesday, July 31, 2024 8:17 AM To: maarten.lankho...@linux.intel.com; mrip...@kernel.org; airl...@gmail.com; dan...@ffwll.ch Cc: amd-...@lists.freedesktop.org; dri-devel@lis

Re: [PATCH V2 00/10] AMD XDNA driver

2024-08-06 Thread Markus Elfring
… > Changes since v1: > - Remove some inline defines > - Minor changes based code review comments … How “good” does such a version description fit to previous patch review feedback (like the following)? https://lkml.org/lkml/2024/7/19/803 https://lore.kernel.org/linux-kernel/010a46ba-9dc4-e3e3-78

Re: [PATCH v2] drm/i915/hwmon: expose fan speed

2024-08-06 Thread Riana Tauro
Hi Raag On 7/30/2024 11:35 AM, Raag Jadav wrote: Add hwmon support for fan1_input attribute, which will expose fan speed in RPM. With this in place we can monitor fan speed using lm-sensors tool. $ sensors i915-pci-0300 Adapter: PCI adapter in0: 653.00 mV fan1:3833 RPM power1:

Re: [RFC PATCH 2/6] drm/cgroup: Add memory accounting DRM cgroup

2024-08-06 Thread Maxime Ripard
Hi Maarten, On Mon, Jul 01, 2024 at 11:25:12AM GMT, Maarten Lankhorst wrote: > Den 2024-06-28 kl. 16:04, skrev Maxime Ripard: > > On Thu, Jun 27, 2024 at 09:22:56PM GMT, Maarten Lankhorst wrote: > >> Den 2024-06-27 kl. 19:16, skrev Maxime Ripard: > >>> Hi, > >>> > >>> Thanks for working on this! >

Re: [PATCH v1] misc: fastrpc: Trigger a panic using BUG_ON in device release

2024-08-06 Thread Abhishek Singh
On 7/30/2024 12:46 PM, Greg KH wrote: > On Tue, Jul 30, 2024 at 12:39:45PM +0530, Abhishek Singh wrote: >> The user process on ARM closes the device node while closing the >> session, triggers a remote call to terminate the PD running on the >> DSP. If the DSP is in an unstable state and cannot p

Re: [PATCH v5 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

2024-08-06 Thread 胡俊光

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-08-06 Thread Thomas Hellström
Hi, Christian. On Thu, 2024-07-11 at 14:01 +0200, Christian König wrote: > Am 10.07.24 um 20:19 schrieb Matthew Brost: > > On Wed, Jul 10, 2024 at 02:42:58PM +0200, Christian König wrote: > > > That is something drivers really shouldn't mess with. > > > > > Thomas uses this in Xe to implement a s

Re: [PATCH v1] drm/xe/uapi: Bring back reset uevent

2024-08-06 Thread Aravind Iddamsetty
On 06/08/24 10:02, Raag Jadav wrote: This change  was originally sent by Himal, so may be you should keep his authorship. > From: Lucas De Marchi > > Bring back uevent for gt reset failure with better uapi naming. > With this in place we can receive failure event using udev. > > $ udevadm mo

[PATCH] drm/i915: Fix NULL ptr deref in intel_async_flip_check_uapi()

2024-08-06 Thread Ma Ke
intel_atomic_get_new_crtc_state can return NULL, unless crtc state wasn't obtained previously with intel_atomic_get_crtc_state. We should check it for NULLness here, just as in many other places, where we can't guarantee that intel_atomic_get_crtc_state was called. Cc: sta...@vger.kernel.org Fixes

Re: [PATCH v2 0/2] Fix mmap memory boundary calculation

2024-08-06 Thread Andi Shyti
Hi Greg, same question without the stable mailing list not to trigger the automatic reply. > Andi Shyti (2): > drm/i915/gem: Adjust vma offset for framebuffer mmap offset > drm/i915/gem: Fix Virtual Memory mapping boundaries calculation I have forgotten to actually Cc the stable mailing list

Re: [PATCH v5 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

2024-08-06 Thread AngeloGioacchino Del Regno
Il 06/08/24 10:29, CK Hu (胡俊光) ha scritto: Hi, Angelo: On Thu, 2024-07-25 at 11:46 +0200, AngeloGioacchino Del Regno wrote: Il 05/07/24 11:28, CK Hu (胡俊光) ha scritto: On Tue, 2024-06-11 at 08:54 +0200, AngeloGioacchino Del Regno wrote: Il 11/06/24 08:48, CK Hu (胡俊光) ha scritto: On Mon, 2024-

[PATCH] drm/etnaviv: Remove GFP_HIGHUSER in systems with 32 address limits

2024-08-06 Thread Xiaolei Wang
GFP_HIGHUSER is for userspace allocations that may be mapped to userspace,An example may be a hardware allocation that maps data directly into userspace but has no addressing limitations, this conflicts with GFP_DMA32,The kernel reports a BUG: kernel BUG at include/linux/gfp.h:139! Internal error:

[PATCH 1/2] drm/dp_mst: Slightly optimize drm_dp_mst_i2c_write() (1/2)

2024-08-06 Thread Christophe JAILLET
'txmsg' is memset()'ed in the for loop below, before usage. So we can save another initialization txmsg when it is allocated. Signed-off-by: Christophe JAILLET --- In case of interest, on x86_64, with allmodconfig, sizeof(*txmsg) is 768 bytes. --- drivers/gpu/drm/display/drm_dp_mst_topology.c |

[PATCH 2/2] drm/dp_mst: Slightly optimize drm_dp_mst_i2c_write() (2/2)

2024-08-06 Thread Christophe JAILLET
'msg' is only used with drm_dp_encode_sideband_req() which takes a "const struct drm_dp_sideband_msg_req_body *". So some initializations can be done only once outside of the for loop. Signed-off-by: Christophe JAILLET --- In case of interest, on x86_64, with allmodconfig, sizeof(*msg) is 420 by

Re: [PATCH v2 0/2] Fix mmap memory boundary calculation

2024-08-06 Thread Joonas Lahtinen
Quoting Andi Shyti (2024-08-06 12:46:07) > Hi Greg, > > same question without the stable mailing list not to trigger the > automatic reply. > > > Andi Shyti (2): > > drm/i915/gem: Adjust vma offset for framebuffer mmap offset > > drm/i915/gem: Fix Virtual Memory mapping boundaries calculation

Re: [PATCH 1/5] drm/mgag200: Add VGA-BMC output

2024-08-06 Thread Jocelyn Falempe
On 05/08/2024 15:05, Thomas Zimmermann wrote: Duplicate VGA output to VGA-BMC output and update all code for Matrox server chips. The new output represents a VGA output that has a BMC attached to it. No functional changes so far. Thanks for this work. Reviewed-by: Jocelyn Falempe Signed-of

Re: [PATCH 2/5] drm/mgag200: vga-bmc: Transparently handle BMC

2024-08-06 Thread Jocelyn Falempe
On 05/08/2024 15:05, Thomas Zimmermann wrote: The VGA-BMC connector selects the VGA output if a display has been attached to the physical connector. Otherwise it selects the BMC output. In any case, the connector status is set to 'detected', so that the userspace compositor displays to it. De

Re: [PATCH 3/5] drm/mgag200: vga-bmc: Control CRTC VIDRST flag from encoder

2024-08-06 Thread Jocelyn Falempe
On 05/08/2024 15:05, Thomas Zimmermann wrote: Control the VIDRST pin from the VGA-BMC encoder's atomic_check and remove the respective code from CRTC. Makes the VIDRST functionality fully composable. The VIDRST pin allows an external clock source to control the SYNC signals of the Matrox chip

Re: [PATCH 4/5] drm/mgag200: vga-bmc: Control BMC scanout from encoder

2024-08-06 Thread Jocelyn Falempe
On 05/08/2024 15:06, Thomas Zimmermann wrote: Move calls to stop and start BMC scanout from CRTC helpers to the VGA-BMC encoder's atomic_disable and atomic_enable. Makes the BMC scanout transparent to the CRTC. DRM's atomic helpers call an encoder's atomic_disable and atomic_enable helpers fo

Re: [PATCH 5/5] drm/mgag200: Remove BMC output

2024-08-06 Thread Jocelyn Falempe
On 05/08/2024 15:06, Thomas Zimmermann wrote: Mgag200's BMC connector tracks the status of an underlying physical connector and updates the BMC status accordingly. This functionality works around GNOME's settings app, which cannot handle multiple outputs on the same CRTC. The workaround is now o

Re: [PATCH] drm/etnaviv: Remove GFP_HIGHUSER in systems with 32 address limits

2024-08-06 Thread Lucas Stach
Hi Xiaolei, Am Dienstag, dem 06.08.2024 um 18:47 +0800 schrieb Xiaolei Wang: > GFP_HIGHUSER is for userspace allocations that may be mapped > to userspace,An example may be a hardware allocation that maps > data directly into userspace but has no addressing limitations, > this conflicts with GFP_D

Re: [PATCH net-next v17 03/14] netdev: support binding dma-buf to netdevice

2024-08-06 Thread Willem de Bruijn
Markus Elfring wrote: > >> … > >>> +++ b/include/net/devmem.h > >>> @@ -0,0 +1,115 @@ > >> … > >>> +#ifndef _NET_DEVMEM_H > >>> +#define _NET_DEVMEM_H > >> … > >> > >> I suggest to omit leading underscores from such identifiers. > >> https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+dec

Re: [PATCH v2] drm/atomic: allow no-op FB_ID updates for async flips

2024-08-06 Thread André Almeida
Em 31/07/2024 16:10, Simon Ser escreveu: User-space is allowed to submit any property in an async flip as long as the value doesn't change. However we missed one case: as things stand, the kernel rejects no-op FB_ID changes on non-primary planes. Fix this by changing the conditional and skipping

[PATCH 1/9] drm/ast: Move code for physical outputs into separate files

2024-08-06 Thread Thomas Zimmermann
Move the modesetting code for the various transmitter chips into their own source files before adding BMC support. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/Makefile | 4 +- drivers/gpu/drm/ast/ast_dp.c | 214 +- drivers/gpu/drm/ast/ast

[PATCH 2/9] drm/ast: astdp: Move locking into EDID helper

2024-08-06 Thread Thomas Zimmermann
The modeset mutex protects EDID retrival from concurrent modeset operations. Acquire the lock in ast_astdp_read_edid(). Prepares the code for conversion to struct drm_edid. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_dp.c | 24 ++-- 1 file changed, 10 inserti

[PATCH 3/9] drm/ast: astdp: Use struct drm_edid and helpers

2024-08-06 Thread Thomas Zimmermann
Convert ASTDP support to struct drm_edid and its helpers. Simplifies and modernizes the EDID handling. The driver reads 4 bytes at once, but the overall read length is now variable. Therefore update the EDID read loop to never return more than the requested bytes. The device does not seem to supp

[PATCH 6/9] drm/ast: dp501: Transparently handle BMC support

2024-08-06 Thread Thomas Zimmermann
Permanently set the connector status to 'connected'. Return BMC modes for connector if no display is attached to the physical DP connector. Otherwise use EDID modes as before. If the status of the physical connector changes, the driver still generates a hotplug event. DRM clients will then reconfi

[PATCH 8/9] drm/ast: vga: Transparently handle BMC support

2024-08-06 Thread Thomas Zimmermann
Permanently set the connector status to 'connected'. Return BMC modes for connector if no display is attached to the physical DP connector. Otherwise use EDID modes as before. If the status of the physical connector changes, the driver still generates a hotplug event. DRM clients will then reconfi

[PATCH 7/9] drm/ast: sil164: Transparently handle BMC support

2024-08-06 Thread Thomas Zimmermann
Permanently set the connector status to 'connected'. Return BMC modes for connector if no display is attached to the physical DP connector. Otherwise use EDID modes as before. If the status of the physical connector changes, the driver still generates a hotplug event. DRM clients will then reconfi

[PATCH 9/9] drm/ast: Remove BMC output

2024-08-06 Thread Thomas Zimmermann
Ast's BMC connector tracks the status of an underlying physical connector and updates the BMC status accordingly. This functionality works around GNOME's settings app, which cannot handle multiple outputs on the same CRTC. The workaround is now obsolete as all code for physical outputs handle BMC

[PATCH 0/9] drm/ast: Transparently handle BMC in outputs

2024-08-06 Thread Thomas Zimmermann
Add transparent BMC support to all outputs. If the user disconnects the physical display, each output will now return display modes for the BMC. Makes the BMC connector obsolete, so remove it. The benefit of the new approach is that is works with any userspace. Most userspace compositors have prob

[PATCH 4/9] drm/ast: astdp: Transparently handle BMC support

2024-08-06 Thread Thomas Zimmermann
Permanently set the connector status to 'connected'. Return BMC modes for connector if no display is attached to the physical DP connector. Otherwise use EDID modes as before. If the status of the physical connector changes, the driver still generates a hotplug event. DRM clients will then reconfi

[PATCH 5/9] drm/ast: dp501: Use struct drm_edid and helpers

2024-08-06 Thread Thomas Zimmermann
Convert DP501 support to struct drm_edid and its helpers. Simplifies and modernizes the EDID handling. The driver reads 4 bytes at once, but the overall read length is now variable. Therefore update the EDID read loop to never return more than the requested bytes. Signed-off-by: Thomas Zimmermann

Re: [RFC PATCH 2/6] drm/cgroup: Add memory accounting DRM cgroup

2024-08-06 Thread Daniel Vetter
On Mon, Jul 01, 2024 at 06:01:41PM +0100, Tvrtko Ursulin wrote: > > On 01/07/2024 10:25, Maarten Lankhorst wrote: > > Den 2024-06-28 kl. 16:04, skrev Maxime Ripard: > > > Hi, > > > > > > On Thu, Jun 27, 2024 at 09:22:56PM GMT, Maarten Lankhorst wrote: > > > > Den 2024-06-27 kl. 19:16, skrev Maxim

Re: [PATCH 0/2] drm/bridge: lt9611uxc: require DRM_BRIDGE_ATTACH_NO_CONNECTOR

2024-08-06 Thread Robert Foss
On Mon, 01 Jul 2024 21:19:51 +0300, Dmitry Baryshkov wrote: > There are no in-kernel DTs that use Lontium LT9611UXC bridge and still > require creation of the drm_connector by the bridge on attachment. > Drop support for !DRM_BRIDGE_ATTACH_NO_CONNECTOR by the driver. > > Applied, thanks! [1/2]

Re: [PATCH] drm/etnaviv: Remove GFP_HIGHUSER in systems with 32 address limits

2024-08-06 Thread wang xiaolei
On 8/6/24 11:23 PM, Lucas Stach wrote: CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. Hi Xiaolei, Am Dienstag, dem 06.08.2024 um 18:47 +0800 schrieb Xiaolei Wang: GFP_HIGHUSE

[PATCH 2/4] dt-bindings: display: panel-lvds: Add compatible for Jenson BL-JT60050-01A

2024-08-06 Thread Frieder Schrempf
From: Frieder Schrempf The Jenson BL-JT60050-01A is a 7" 1024x600 LVDS display. Signed-off-by: Frieder Schrempf --- Documentation/devicetree/bindings/display/panel/panel-lvds.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-lvds.y

[PATCH 0/3] drm/omap: Minor fixes

2024-08-06 Thread Tomi Valkeinen
insertions(+), 34 deletions(-) --- base-commit: 0c3836482481200ead7b416ca80c68a29cfdaabd change-id: 20240806-omapdrm-misc-fixes-2ea920193dde Best regards, -- Tomi Valkeinen

[PATCH 1/3] drm/omap: Fix possible NULL dereference

2024-08-06 Thread Tomi Valkeinen
smatch reports: drivers/gpu/drm/omapdrm/dss/base.c:176 omapdss_device_disconnect() error: we previously assumed 'src' could be null (see line 169) This code is mostly from a time when omapdrm had its own display device model. I can't honestly remember the details, and I don't think it's worth di

[PATCH 2/3] drm/omap: Hide sparse warnings

2024-08-06 Thread Tomi Valkeinen
sparse reports: drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:122:16: warning: incorrect type in argument 1 (different address spaces) drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:122:16:expected void const volatile [noderef] __iomem *addr drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:122:16:got unsig

[PATCH 3/3] drm/omap: Fix locking in omap_gem_new_dmabuf()

2024-08-06 Thread Tomi Valkeinen
omap_gem_new_dmabuf() creates the new gem object, and then takes and holds the omap_obj->lock for the rest of the function. This has two issues: - omap_gem_free_object(), which is called in the error paths, also takes the same lock, leading to deadlock - Even if the above wouldn't happen, in the

[PATCH 0/4] arm64: dts: imx8mm-kontron: Add HDMI and LVDS display support

2024-08-06 Thread Frieder Schrempf
From: Frieder Schrempf This add support for the display bridges (DSI->LVDS and DSI->HDMI) on the BL i.MX8MM and the 7" LVDS panel in a separate overlay. Only one of the interfaces (HDMI or LVDS) is supported at the same time. Enabling the LVDS overlay will disable the HDMI interface. * Patch 1

[PATCH RESEND v8 1/2] drm/atomic: Let drivers decide which planes to async flip

2024-08-06 Thread André Almeida
Currently, DRM atomic uAPI allows only primary planes to be flipped asynchronously. However, each driver might be able to perform async flips in other different plane types. To enable drivers to set their own restrictions on which type of plane they can or cannot flip, use the existing atomic_async

[PATCH RESEND v8 2/2] drm/amdgpu: Enable async flip on overlay planes

2024-08-06 Thread André Almeida
amdgpu can handle async flips on overlay planes, so allow it for atomic async checks. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pla

[PATCH RESEND v8 0/2] drm/atomic: Ease async flip restrictions

2024-08-06 Thread André Almeida
Hi, As per my previous patchsets, the goal of this work is to find a nice way to allow amdgpu to perform async page flips in the overlay plane as well, not only on the primary one. Currently, when using the atomic uAPI, this is the only type of plane allowed to do async flips, and every driver acc

[PATCH v3 1/2] drm/mipi-dsi: add more multi functions for better error handling

2024-08-06 Thread Tejas Vipin
Add more functions that can benefit from being multi style and mark older variants as deprecated to eventually convert all mipi_dsi functions to multi style. Acked-by: Maxime Ripard Signed-off-by: Tejas Vipin --- drivers/gpu/drm/drm_mipi_dsi.c | 194 + include/dr

[PATCH v3 0/2] add more multi functions to streamline error handling

2024-08-06 Thread Tejas Vipin
This series adds more multi style functions and uses them in the startek-kd070fhfid015 panel. Additionally it marks the older functions as deprecated. --- Changes in v3: - Removed mipi_dsi_dcs_get_display_brightness_multi - Unmarked mipi_dsi_dcs_get_display_brightness as deprecated Change

[PATCH v3 2/2] drm/panel: startek-kd070fhfid015: transition to mipi_dsi wrapped functions

2024-08-06 Thread Tejas Vipin
Use multi style wrapped functions for mipi_dsi in the startek-kd070fhfid015 panel. Signed-off-by: Tejas Vipin --- .../drm/panel/panel-startek-kd070fhfid015.c | 115 ++ 1 file changed, 35 insertions(+), 80 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-startek-kd070fhfid

Re: [RFC PATCH 2/6] drm/cgroup: Add memory accounting DRM cgroup

2024-08-06 Thread Maxime Ripard
On Tue, Aug 06, 2024 at 03:01:44PM GMT, Daniel Vetter wrote: > On Mon, Jul 01, 2024 at 06:01:41PM +0100, Tvrtko Ursulin wrote: > > > > On 01/07/2024 10:25, Maarten Lankhorst wrote: > > > Den 2024-06-28 kl. 16:04, skrev Maxime Ripard: > > > > Hi, > > > > > > > > On Thu, Jun 27, 2024 at 09:22:56PM

Re: [PATCH 4/9] ASoC: rcar_snd: use new of_graph functions

2024-08-06 Thread Mark Brown
On Tue, Aug 06, 2024 at 04:58:38AM +, Kuninori Morimoto wrote: > Now we can use new port related functions for port parsing. Use it. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH 5/9] ASoC: audio-graph-card: use new of_graph functions

2024-08-06 Thread Mark Brown
On Tue, Aug 06, 2024 at 04:58:42AM +, Kuninori Morimoto wrote: > Now we can use new port related functions for port parsing. Use it. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH 6/9] ASoC: audio-graph-card2: use new of_graph functions

2024-08-06 Thread Mark Brown
On Tue, Aug 06, 2024 at 04:58:46AM +, Kuninori Morimoto wrote: > Now we can use new port related functions for port parsing. Use it. Acked-by: Mark Brown signature.asc Description: PGP signature

[PATCH 1/2] drm/sched: memset() 'job' in drm_sched_job_init()

2024-08-06 Thread Philipp Stanner
drm_sched_job_init() has no control over how users allocate struct drm_sched_job. Unfortunately, the function can also not set some struct members such as job->sched. This could theoretically lead to UB by users dereferencing the struct's pointer members too early. It is easier to debug such issu

[PATCH 2/2] drm/sched: warn about drm_sched_job_init()'s partial init

2024-08-06 Thread Philipp Stanner
drm_sched_job_init()'s name suggests that after the function succeeded, parameter "job" will be fully initialized. This is not the case; some members are only later set, notably "job->sched" by drm_sched_job_arm(). Document that drm_sched_job_init() does not set all struct members. Document that

Re: [PATCH v4 1/2] dt-bindings: display: bridge: add TI TDP158

2024-08-06 Thread Rob Herring
On Tue, Jul 30, 2024 at 05:01:31PM +0200, Marc Gonzalez wrote: > TDP158 is an AC-coupled DVI / HDMI to TMDS level shifting Redriver. > It supports DVI 1.0, HDMI 1.4b and 2.0b. > It supports 4 TMDS channels, HPD, and a DDC interface. > It supports dual power supply rails (1.1V on VDD, 3.3V on VCC) >

Re: [PATCH 3/3] drm/omap: Fix locking in omap_gem_new_dmabuf()

2024-08-06 Thread Markus Elfring
… > +++ b/drivers/gpu/drm/omapdrm/omap_gem.c … > @@ -1418,21 +1416,17 @@ struct drm_gem_object *omap_gem_new_dmabuf(struct > drm_device *dev, size_t size, > pages = kcalloc(npages, sizeof(*pages), GFP_KERNEL); > if (!pages) { > omap_gem_free_object

Re: [RFC PATCH 2/6] drm/cgroup: Add memory accounting DRM cgroup

2024-08-06 Thread Daniel Vetter
On Tue, Aug 06, 2024 at 04:09:43PM +0200, Maxime Ripard wrote: > On Tue, Aug 06, 2024 at 03:01:44PM GMT, Daniel Vetter wrote: > > On Mon, Jul 01, 2024 at 06:01:41PM +0100, Tvrtko Ursulin wrote: > > > > > > On 01/07/2024 10:25, Maarten Lankhorst wrote: > > > > Den 2024-06-28 kl. 16:04, skrev Maxime

Re: [PATCH 2/4] dt-bindings: display: panel-lvds: Add compatible for Jenson BL-JT60050-01A

2024-08-06 Thread Conor Dooley
On Tue, Aug 06, 2024 at 03:33:00PM +0200, Frieder Schrempf wrote: > From: Frieder Schrempf > > The Jenson BL-JT60050-01A is a 7" 1024x600 LVDS display. > > Signed-off-by: Frieder Schrempf Acked-by: Conor Dooley Cheers, Conor. > --- > Documentation/devicetree/bindings/display/panel/panel-lv

Re: [PATCH 0/2] drm/virtio: introduce the HOST_PAGE_SIZE feature

2024-08-06 Thread Gurchetan Singh
On Mon, Aug 5, 2024 at 2:14 AM Sergio Lopez Pascual wrote: > Dmitry Osipenko writes: > > > On 7/23/24 14:49, Sergio Lopez wrote: > >> There's an incresing number of machines supporting multiple page sizes > >> and on these machines the host and a guest can be running, each one, > >> with a diffe

Re: [PATCH 0/2] drm/i915: Fix ttm small BAR placement handling

2024-08-06 Thread Andi Shyti
Hi David, thanks for the patches and thanks Justin for debugging the issue. I reviewed and merged it into drm-intel-gt-next. Thanks, Andi On Sun, Aug 04, 2024 at 05:18:46PM +0800, David Gow wrote: > From: David Gow > > As described in [1], there have been a couple of regressions in the TTM >

[PATCH 9/9] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2024-08-06 Thread Aditya Garg
From: Kerem Karabay The Touch Bars found on x86 Macs support two USB configurations: one where the device presents itself as a HID keyboard and can display predefined sets of keys, and one where the operating system has full control over what is displayed. This commit adds support for the display

[PATCH 4/9] HID: multitouch: support getting the tip state from HID_DG_TOUCH fields

2024-08-06 Thread Aditya Garg
From: Kerem Karabay This is necessary on Apple Touch Bars, where the tip state is contained in fields with the HID_DG_TOUCH usage. This feature is gated by a quirk in order to prevent breaking other devices, see commit c2ef8f21ea8f ("HID: multitouch: add support for trackpads"). Signed-off-by: K

[PATCH 5/9] HID: multitouch: take cls->maxcontacts into account for devices without a HID_DG_CONTACTMAX field too

2024-08-06 Thread Aditya Garg
From: Kerem Karabay This is needed for Apple Touch Bars, where no HID_DG_CONTACTMAX field is present and the maximum contact count is greater than the default. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 7 --- 1 file changed, 4 insertions(+)

[PATCH 3/9] HID: multitouch: support getting the contact ID from HID_DG_TRANSDUCER_INDEX fields

2024-08-06 Thread Aditya Garg
From: Kerem Karabay This is needed to support Apple Touch Bars, where the contact ID is contained in fields with the HID_DG_TRANSDUCER_INDEX usage. Signed-off-by: Kerem Karabay Co-developed-by: Aditya Garg Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 5 - 1 file changed,

[PATCH 0/9] Touch Bar support for T2 Macs

2024-08-06 Thread Aditya Garg
Hi Maintainers The Touch Bars found on x86 Macs support two USB configurations: one where the device presents itself as a HID keyboard and can display predefined sets of keys, and one where the operating system has full control over what is displayed. This patch series adds support for both the c

[PATCH 6/9] HID: multitouch: allow specifying if a device is direct in a class

2024-08-06 Thread Aditya Garg
From: Kerem Karabay Currently the driver determines the device type based on the application, but this value is not reliable on Apple Touch Bars, where the application is HID_DG_TOUCHPAD even though the devices are direct, so allow setting it in classes. Signed-off-by: Kerem Karabay Signed-off-

[PATCH 1/9] HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars

2024-08-06 Thread Aditya Garg
From: Kerem Karabay This commit adds a driver for the backlight of Apple Touch Bars on x86 Macs. Note that currently only T2 Macs are supported. This driver is based on previous work done by Ronald Tschalär . Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- MAINTAINERS

[PATCH 8/9] drm/format-helper: add helper for BGR888 to XRGB8888 conversion

2024-08-06 Thread Aditya Garg
From: Kerem Karabay Add XRGB emulation helper for devices that only support BGR888. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/gpu/drm/drm_format_helper.c | 54 + .../gpu/drm/tests/drm_format_helper_test.c| 81 +++ include

[PATCH 7/9] HID: multitouch: add device ID for Apple Touch Bars

2024-08-06 Thread Aditya Garg
From: Kerem Karabay Note that this is device ID is for T2 Macs. Testing on T1 Macs would be appreciated. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- drivers/hid/Kconfig | 1 + drivers/hid/hid-multitouch.c | 26 ++ 2 files changed, 23 insertion

[PATCH 2/9] HID: hid-appletb-kbd: add driver for the keyboard mode of Apple Touch Bars

2024-08-06 Thread Aditya Garg
From: Kerem Karabay The Touch Bars found on x86 Macs support two USB configurations: one where the device presents itself as a HID keyboard and can display predefined sets of keys, and one where the operating system has full control over what is displayed. This commit adds a driver for the displa

Re: [PATCH V2 00/10] AMD XDNA driver

2024-08-06 Thread Lizhi Hou
On 8/6/24 01:05, Markus Elfring wrote: … Changes since v1: - Remove some inline defines - Minor changes based code review comments … How “good” does such a version description fit to previous patch review feedback (like the following)? https://lkml.org/lkml/2024/7/19/803 https://lore.kernel

[PATCH v2] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-08-06 Thread Nikita Zhandarovich
Several cs track offsets (such as 'track->db_s_read_offset') either are initialized with or plainly take big enough values that, once shifted 8 bits left, may be hit with integer overflow if the resulting values end up going over u32 limit. Same goes for a few instances of 'surf.layer_size * mslic

Re: [PATCH v5 0/9] Improve the copy of task comm

2024-08-06 Thread Alejandro Colomar
Hi Linus, Serge let me know about this thread earlier today. On 2024-08-05, Linus Torvalds wrote: > On Mon, 5 Aug 2024 at 20:01, Yafang Shao wrote: > > > > One concern about removing the BUILD_BUG_ON() is that if we extend > > TASK_COMM_LEN to a larger size, such as 24, the caller with a > > ha

Re: [PATCH v2 1/2] drm/panel: jd9365da: Move the location of "exit sleep mode" and "set display on" commands

2024-08-06 Thread Doug Anderson
Hi, On Mon, Aug 5, 2024 at 8:40 PM Zhaoxiong Lv wrote: > > Move the "exit sleep mode" and "set display on" command from > enable() to init() function. > > As mentioned in the patch: > https://lore.kernel.org/all/20240624141926.5250-2-lvzhaoxi...@huaqin.corp-partner.google.com/ > > Our DSI host ha

Re: [PATCH v3 1/2] dt-bindings: display: panel: samsung,atna45dc02: Document ATNA45DC02

2024-08-06 Thread Doug Anderson
Hi, On Wed, Jul 31, 2024 at 4:39 PM Doug Anderson wrote: > > Hi, > > On Mon, Jul 29, 2024 at 1:57 PM Rob Clark wrote: > > > > From: Rob Clark > > > > The Samsung ATNA45DC02 panel is an AMOLED eDP panel, similar to the > > existing ATNA45AF01 and ATNA33XC20 panel but with a higher resolution. >

Re: [PATCH v9 0/6] drm/ci: Add support for GPU and display testing

2024-08-06 Thread Helen Koike
On 05/08/2024 10:11, Daniel Stone wrote: Hi Vignesh, On Tue, 30 Jul 2024 at 03:16, Vignesh Raman wrote: Some ARM SOCs have a separate display controller and GPU, each with different drivers. For mediatek mt8173, the GPU driver is powervr, and the display driver is mediatek. In the case of m

[PATCH 1/2] Revert "drm/amd/display: Don't register panel_power_savings on OLED panels"

2024-08-06 Thread Sebastian Wick
From: Sebastian Wick This reverts commit 76cb763e6ea62e838ccc8f7a1ea4246d690fccc9. Reverting the panel_power_savings sysfs. See next commit. Signed-off-by: Sebastian Wick --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 29 +++ 1 file changed, 4 insertions(+), 25 deletions(

[PATCH 2/2] Revert "drm/amd/display: add panel_power_savings sysfs entry to eDP connectors"

2024-08-06 Thread Sebastian Wick
From: Sebastian Wick This reverts commit 63d0b87213a0ba241b3fcfba3fe7b0aed0cd1cc5. The panel_power_savings sysfs entry can be used to change the displayed colorimetry which breaks color managed setups. The "do not break userspace" rule which was violated here is enough reason to revert this com

Re: [PATCH V2 00/10] AMD XDNA driver

2024-08-06 Thread Markus Elfring
>> https://lkml.org/lkml/2024/7/19/803 >> https://lore.kernel.org/linux-kernel/010a46ba-9dc4-e3e3-7894-b28b312c6...@amd.com/ >> [01/10] accel/amdxdna: Add a new driver for AMD AI Engine >> “guard looks cleaner. We will use it.” > We reconsidered this request Interesting … > and searched accel an

Re: [PATCH 0/2] drm/virtio: introduce the HOST_PAGE_SIZE feature

2024-08-06 Thread Rob Clark
On Tue, Aug 6, 2024 at 9:15 AM Gurchetan Singh wrote: > > > > On Mon, Aug 5, 2024 at 2:14 AM Sergio Lopez Pascual wrote: >> >> Dmitry Osipenko writes: >> >> > On 7/23/24 14:49, Sergio Lopez wrote: >> >> There's an incresing number of machines supporting multiple page sizes >> >> and on these mac

Re: [PATCH 2/9] drm/meson: vclk: drop hdmi system clock setup

2024-08-06 Thread Martin Blumenstingl
On Tue, Jul 30, 2024 at 2:50 PM Jerome Brunet wrote: > > Poking the HHI syscon is a way to setup clocks behind CCF's back. > Also, 2 drm code paths, the encoder and the hdmi-phy, are racing to do the > same setup of the HDMI system clock. > > This clock is used is used by the HDMI phy and should n

Re: [PATCH 3/9] drm/meson: dw-hdmi: use generic clock helpers

2024-08-06 Thread Martin Blumenstingl
On Tue, Jul 30, 2024 at 2:50 PM Jerome Brunet wrote: > > The Amlogic HDMI phy driver is not doing anything with the clocks > besides enabling on probe. CCF provides generic helpers to do that. > > Use the generic clock helpers rather than using a custom one to get and > enable clocks. > > Signed-o

Re: [PATCH 4/9] drm/meson: dw-hdmi: fix incorrect comment in suspend

2024-08-06 Thread Martin Blumenstingl
On Tue, Jul 30, 2024 at 2:50 PM Jerome Brunet wrote: > > Comment in suspend says TOP is put in suspend, but the register > poke following is actually de-asserting the reset, like in init. > > It is doing the opposite of what the comment says. > > Align the comment with what the code is doing for n

Re: [PATCH net-next v18 03/14] netdev: support binding dma-buf to netdevice

2024-08-06 Thread Jakub Kicinski
On Mon, 5 Aug 2024 21:25:16 + Mina Almasry wrote: > +/* Protected by rtnl_lock() */ > +static DEFINE_XARRAY_FLAGS(net_devmem_dmabuf_bindings, XA_FLAGS_ALLOC1); nit: global variable declarations before any code > +void net_devmem_unbind_dmabuf(struct net_devmem_dmabuf_binding *binding) > +{ >

Re: [PATCH net-next v18 05/14] page_pool: move dmaddr helpers to .c file

2024-08-06 Thread Jakub Kicinski
On Mon, 5 Aug 2024 21:25:18 + Mina Almasry wrote: > +dma_addr_t page_pool_get_dma_addr_netmem(netmem_ref netmem) > +{ > + struct page *page = netmem_to_page(netmem); > + > + dma_addr_t ret = page->dma_addr; > + > + if (PAGE_POOL_32BIT_ARCH_WITH_64BIT_DMA) > + ret <<= PA

Re: [PATCH net-next v18 04/14] netdev: netdevice devmem allocator

2024-08-06 Thread Jakub Kicinski
On Mon, 5 Aug 2024 21:25:17 + Mina Almasry wrote: > +struct net_iov * > +net_devmem_alloc_dmabuf(struct net_devmem_dmabuf_binding *binding) > +{ > + struct dmabuf_genpool_chunk_owner *owner; > + unsigned long dma_addr; > + struct net_iov *niov; > + ssize_t offset; > + ssize

Re: [PATCH 5/9] drm/meson: dw-hdmi: split resets out of hw init.

2024-08-06 Thread Martin Blumenstingl
Hi Jerome, On Tue, Jul 30, 2024 at 2:50 PM Jerome Brunet wrote: > > This prepares the migration to regmap usage. > > To properly setup regmap, the APB needs to be in working order. > This is easier handled if the resets are not mixed with hw init. > > More checks are required to determine if the

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-06 Thread Jakub Kicinski
On Mon, 5 Aug 2024 21:25:20 + Mina Almasry wrote: > + if (pool->p.queue) { > + /* We rely on rtnl_lock()ing to make sure netdev_rx_queue > + * configuration doesn't change while we're initializing the > + * page_pool. > + */ > +

Re: [PATCH 7/9] drm/meson: dw-hdmi: use matched data

2024-08-06 Thread Martin Blumenstingl
Hi Jerome, On Tue, Jul 30, 2024 at 2:50 PM Jerome Brunet wrote: [...] > + }, { > + .limit = 297000, > + .regs = gxbb_3g_regs, > + .reg_num = ARRAY_SIZE(gxbb_3g_regs) Just as a side-note: this looked odd when reading for the first time as I thought t

[PATCH v2 0/4] drm/msm/adreno: Add A615 GPU for SDM670 and Pixel 3a

2024-08-06 Thread Richard Acayan
This adds support for the speed-binned A615 GPU on SDM670. Changes since v1 (20240730013844.41951-6-mailingrad...@gmail.com): - add Acked-by tag (1/4) - add OPPs exclusive to some speed bins (3/4) - enable GMU by default (3/4) Richard Acayan (4): dt-bindings: display/msm/gmu: Add SDM670 compati

[PATCH v2 2/4] drm/msm/adreno: add a615 support

2024-08-06 Thread Richard Acayan
The Adreno A615 is used in SDM670. Add an entry to support it. Signed-off-by: Richard Acayan --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_cat

[PATCH v2 3/4] arm64: dts: qcom: sdm670: add gpu

2024-08-06 Thread Richard Acayan
The Snapdragon 670 has the Adreno A615 GPU. Add it along with its device tree dependencies. Signed-off-by: Richard Acayan --- arch/arm64/boot/dts/qcom/sdm670.dtsi | 180 +++ 1 file changed, 180 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm670.dtsi b/arch/arm64

[PATCH v2 4/4] arm64: dts: qcom: sdm670-google-sargo: enable gpu

2024-08-06 Thread Richard Acayan
Enable the A615 GPU and GMU for the Pixel 3a. It has zap firmware, so add that in as well. Signed-off-by: Richard Acayan --- arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts b/arch/arm6

[PATCH v2 1/4] dt-bindings: display/msm/gmu: Add SDM670 compatible

2024-08-06 Thread Richard Acayan
The Snapdragon 670 has a GMU. Add its compatible. Signed-off-by: Richard Acayan Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/de

[PATCH 00/12] Enable build system on macOS hosts

2024-08-06 Thread Daniel Gomez via B4 Relay
This patch set allows for building the Linux kernel for arm64 in macOS with LLVM. Patches are based on previous Nick's work and suggestions [1][2][3] to enable build system in macOS hosts. Since macOS does not provide some of the headers available in the GNU C Library (glibc), the patches include

[PATCH 02/12] kbuild: add header_install dependency to scripts

2024-08-06 Thread Daniel Gomez via B4 Relay
From: Daniel Gomez Export kernel headers necessary for the tools located in scripts/. This ensures kernel headers are generated before building scripts/selinux. Kernel headers required for building are: asm/types.h, asm/bitsperlong.h and asm/poix_types.h. Signed-off-by: Daniel Gomez --- Makef

[PATCH 09/12] include: add endian.h support

2024-08-06 Thread Daniel Gomez via B4 Relay
From: Daniel Gomez macOS hosts do not include endian.h header required for gen-hyper object. Add a copy of the include/endian.h from the GNU C Library (glibc), version glib-2.40 into include/endian and a copy of bits/ uintn-identity.h into include/endian/bits and update the gen-hyper Makefile to

[PATCH 04/12] drm/xe: xe_gen_wa_oob: fix program_invocation_short_name for macos

2024-08-06 Thread Daniel Gomez via B4 Relay
From: Daniel Gomez Use getprogname() [1] instead of program_invocation_short_name() [2] for macOS hosts. [1]: https://www.gnu.org/software/gnulib/manual/html_node/ program_005finvocation_005fshort_005fname.html [2]: https://developer.apple.com/library/archive/documentation/System/ Conceptual/Ma

[PATCH 03/12] file2alias: fix uuid_t definitions for macos

2024-08-06 Thread Daniel Gomez via B4 Relay
From: Daniel Gomez The uuid_t struct defined in sys/types.h on macOS hosts conflicts with the one defined in file2alias, resulting in the typedef redefinition error below. To resolve this conflict, redefine the uuid_t specifically for macOS hosts. Error: HOSTCC scripts/mod/file2alias.o script

  1   2   >