Em 31/07/2024 16:10, Simon Ser escreveu:
User-space is allowed to submit any property in an async flip as long as the value doesn't change. However we missed one case: as things stand, the kernel rejects no-op FB_ID changes on non-primary planes. Fix this by changing the conditional and skipping drm_atomic_check_prop_changes() only for FB_ID on the primary plane (instead of skipping for FB_ID on any plane).Fixes: 0e26cc72c71c ("drm: Refuse to async flip with atomic prop changes") Signed-off-by: Simon Ser <cont...@emersion.fr> Reviewed-by: André Almeida <andrealm...@igalia.com> Tested-by: Xaver Hugl <xaver.h...@kde.org> Cc: Alex Deucher <alexander.deuc...@amd.com> Cc: Christian König <christian.koe...@amd.com> Cc: Michel Dänzer <michel.daen...@mailbox.org> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> --- André, can you confirm that the R-b still holds?
Yes, it still holds
