Re: [PATCH 05/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller

2024-07-08 Thread Liu Ying
On 07/07/2024, Krzysztof Kozlowski wrote: > On 05/07/2024 11:09, Liu Ying wrote: >> i.MX8qxp Display Controller(DC) is comprised of three main components that >> include a blit engine for 2D graphics accelerations, display controller for >> display output processing, as well as a command sequencer.

Re: [PATCH 00/10] Add Freescale i.MX8qxp Display Controller support

2024-07-08 Thread Liu Ying
On 07/05/2024, Francesco Dolcini wrote: > Hello Liu, Hello Francesco, > > On Fri, Jul 05, 2024 at 05:09:22PM +0800, Liu Ying wrote: >> This patch series aims to add Freescale i.MX8qxp Display Controller support. > > I really appreciate your work here, I am looking forward for a better > support

Re: [09/10] drm/imx: Add i.MX8qxp Display Controller KMS

2024-07-08 Thread Markus Elfring
>> Under which circumstances would you become interested to apply a statement >> like “guard(spinlock_irqsave)(&crtc->dev->event_lock);”? > > I just follow the kerneldoc of drm_crtc_send_vblank_event() to > hold event lock like many other drivers do. Please take another look at software design pos

Re: [Linaro-mm-sig] Re: [PATCH 0/8] dma-buf: heaps: Support carved-out heaps and ECC related-flags

2024-07-08 Thread Christian König
Am 05.07.24 um 17:35 schrieb Daniel Vetter: Just figured I'll jump in on one detail here. On Fri, Jul 05, 2024 at 04:31:34PM +0200, Thierry Reding wrote: On Thu, Jul 04, 2024 at 02:24:49PM GMT, Maxime Ripard wrote: On Fri, Jun 28, 2024 at 04:42:35PM GMT, Thierry Reding wrote: On Fri, Jun 28,

Re: [PATCH] drm/format-helper: Add conversion from XRGB8888 to BGR888

2024-07-08 Thread Thomas Zimmermann
Hi Am 05.07.24 um 13:38 schrieb Aditya Garg: From: Kerem Karabay Add XRGB emulation helper for devices that only support BGR888. Nothing wrong with that, but it needs a caller. Do you have a driver that uses this routine? Best regards Thomas Signed-off-by: Kerem Karabay Signed-off

Re: [PATCH v2 5/5] drm/etnaviv: take current primitive into account when checking for hung GPU

2024-07-08 Thread Philipp Zabel
On Fr, 2024-07-05 at 22:00 +0200, Lucas Stach wrote: > Large draws can make the GPU appear to be stuck to the current hangcheck > logic as the FE address will not move until the draw is finished. However, > the FE has a debug register, which records the current primitive ID within > a draw. Using t

Re: [09/10] drm/imx: Add i.MX8qxp Display Controller KMS

2024-07-08 Thread Krzysztof Kozlowski
On 08/07/2024 09:09, Markus Elfring wrote: >>> Under which circumstances would you become interested to apply a statement >>> like “guard(spinlock_irqsave)(&crtc->dev->event_lock);”? >> >> I just follow the kerneldoc of drm_crtc_send_vblank_event() to >> hold event lock like many other drivers do.

Re: [PATCH] accel/ivpu: Add missing MODULE_FIRMWARE metadata

2024-07-08 Thread Jacek Lawrynowicz
Hi, thanks for the commit. On 05.07.2024 13:14, Alexander F. Lent wrote: > Modules that load firmware from various paths at runtime must declare > those paths at compile time, via the MODULE_FIRMWARE macro, so that the > firmware paths are included in the module's metadata. > > The accel/ivpu dri

Re: [PATCH v3 1/5] drm/panel: st7701: Rename macros

2024-07-08 Thread Neil Armstrong
On 06/07/2024 12:23, Hironori KIKUCHI wrote: Rename DSI_CMD* macros to ST7701_CMD*, and ST7701_DSI macro to ST7701_WRITE, because they do not belong to DSI. Signed-off-by: Hironori KIKUCHI --- drivers/gpu/drm/panel/panel-sitronix-st7701.c | 736 +- 1 file changed, 368 inserti

Re: [PATCH v3 2/5] drm/panel: st7701: Decouple DSI and DRM parts

2024-07-08 Thread Neil Armstrong
On 06/07/2024 12:23, Hironori KIKUCHI wrote: Split into a DSI-specific part and a DRM-specific part. Additionally, use devm_add_action_or_reset() to simplify the flow, and disable and unprepare the panel on cleanup. Signed-off-by: Hironori KIKUCHI --- drivers/gpu/drm/panel/panel-sitronix-st7

Re:Re: [PATCH] drm/rockchip: cdn-dp: Remove redundant workarounds for firmware loading

2024-07-08 Thread Andy Yan
Hi Dragan, At 2024-07-04 18:35:42, "Dragan Simic" wrote: >Hello Andy, > >On 2024-07-04 04:10, Andy Yan wrote: >> At 2024-07-04 07:32:02, "Dragan Simic" wrote: >>> After the additional firmware-related module information was >>> introduced by >>> the commit c0677e41a47f ("drm/rockchip: cdn-dp-co

Re: [PATCH] drm/format-helper: Add conversion from XRGB8888 to BGR888

2024-07-08 Thread Thomas Zimmermann
Hi Am 08.07.24 um 09:34 schrieb Aditya Garg: On 8 Jul 2024, at 1:00 PM, Thomas Zimmermann wrote: Hi Am 05.07.24 um 13:38 schrieb Aditya Garg: From: Kerem Karabay Add XRGB emulation helper for devices that only support BGR888. Nothing wrong with that, but it needs a caller. Do you ha

Re: [PATCH] drm/qxl: Pin buffer objects for internal mappings

2024-07-08 Thread Thomas Zimmermann
Hi, ping for a review. This is a bugfix for a serious problem. Best regards Thomas Am 02.07.24 um 16:20 schrieb Thomas Zimmermann: Add qxl_bo_pin_and_vmap() that pins and vmaps a buffer object in one step. Update callers of the regular qxl_bo_vmap(). Fixes a bug where qxl accesses an unpinned

[0/5] Introduce drm sharpening property

2024-07-08 Thread Nemesa Garg
Many a times images are blurred or upscaled content is also not as crisp as original rendered image. Traditional sharpening techniques often apply a uniform level of enhancement across entire image, which sometimes result in over-sharpening of some areas and potential loss of natural details. I

[1/5] drm: Introduce sharpness mode property

2024-07-08 Thread Nemesa Garg
Introduces the new crtc property "SHARPNESS_STRENGTH" that allows the user to set the intensity so as to get the sharpness effect. The value of this property can be set from 0-255. It is useful in scenario when the output is blurry and user want to sharpen the pixels. User can increase/decrease the

[v4 2/5] drm/i915/display: Compute the scaler filter coefficients

2024-07-08 Thread Nemesa Garg
The sharpness property requires the use of one of the scaler so need to set the sharpness scaler coefficient values. These values are based on experiments and vary for different tap value/win size. These values are normalized by taking the sum of all values and then dividing each value with a sum.

[3/5] drm/i915/display: Enable the second scaler for sharpness

2024-07-08 Thread Nemesa Garg
As only second scaler can be used for sharpness check if it is available and if panel fitting is also not enabled, the set the sharpness. Panel fitting will have the preference over sharpness property. v2: Added the panel fitting check before enabling sharpness Signed-off-by: Nemesa Garg --- dr

[4/5] drm/i915/display: Add registers and compute the strength

2024-07-08 Thread Nemesa Garg
Add new registers and related bits. Compute the strength value and tap value based on display mode. Signed-off-by: Nemesa Garg --- drivers/gpu/drm/i915/display/intel_display.c | 5 +- .../drm/i915/display/intel_display_types.h| 1 + .../drm/i915/display/intel_sharpen_filter.c | 105 ++

[5/5] drm/i915/display: Load the lut values and enable sharpness

2024-07-08 Thread Nemesa Garg
Load the lut values during pipe enable. v2: Add the display version check Signed-off-by: Nemesa Garg --- drivers/gpu/drm/i915/display/intel_crtc.c| 3 +++ drivers/gpu/drm/i915/display/intel_display.c | 6 ++ drivers/gpu/drm/i915/display/skl_scaler.c| 13 - 3 files chan

[PATCH] drm: renesas: rcar-du: rcar_lvds: Fix PM imbalance if RPM_ACTIVE

2024-07-08 Thread Biju Das
The pm_runtime_resume_and_get() returns 1 if RPM is active, in this case it won't call a put. This will result in PM imbalance as it treat this as an error and propagate this to caller and the caller never calls corresponding put(). Fix this issue by checking error condition only. Signed-off-by: B

[PATCH] drm: renesas: shmobile: shmo_drm_crtc: Fix PM imbalance if RPM_ACTIVE is true

2024-07-08 Thread Biju Das
The pm_runtime_resume_and_get() returns 1 if RPM is active, in this case it won't call a put. This will result in PM imbalance as it treat this as an error and propagate this to caller and the caller never calls corresponding put(). Fix this issue by checking error condition only. Signed-off-by: B

Re: [PATCH] drm/format-helper: Add conversion from XRGB8888 to BGR888

2024-07-08 Thread Thomas Zimmermann
Hi Am 08.07.24 um 10:10 schrieb Aditya Garg: Hi I see. Best would be to submit this patch together with the driver for review. Although it’s your take, but I really doubt whether the driver would make it upstream. It shall most likely be provided as a DKMS module. What's wrong with upstrea

Re: Time for drm-ci-next?

2024-07-08 Thread Daniel Vetter
On Fri, Jul 05, 2024 at 12:31:36PM -0700, Rob Clark wrote: > On Fri, Jul 5, 2024 at 3:36 AM Daniel Vetter wrote: > > > > On Thu, Jul 04, 2024 at 08:40:26AM -0700, Rob Clark wrote: > > > On Thu, Jul 4, 2024 at 7:08 AM Daniel Vetter > > > wrote: > > > > > > > > On Tue, Jul 02, 2024 at 05:32:39AM -

Re: [PATCH] drm: renesas: shmobile: shmo_drm_crtc: Fix PM imbalance if RPM_ACTIVE is true

2024-07-08 Thread Maxime Ripard
Hi, On Mon, Jul 08, 2024 at 09:27:09AM GMT, Biju Das wrote: > The pm_runtime_resume_and_get() returns 1 if RPM is active, in this > case it won't call a put. This will result in PM imbalance as it > treat this as an error and propagate this to caller and the caller > never calls corresponding put(

Re: [PATCH] drm/qxl: Pin buffer objects for internal mappings

2024-07-08 Thread Daniel Vetter
On Mon, Jul 08, 2024 at 10:09:44AM +0200, Thomas Zimmermann wrote: > Hi, > > ping for a review. This is a bugfix for a serious problem. I tried to look around whether there's any place where we could WARN_ON if we create a vmap but it's not pinned. But there's lots of places where we want the vma

RE: [PATCH] drm: renesas: shmobile: shmo_drm_crtc: Fix PM imbalance if RPM_ACTIVE is true

2024-07-08 Thread Biju Das
Hi Maxime, > -Original Message- > From: Maxime Ripard > Sent: Monday, July 8, 2024 9:54 AM > Subject: Re: [PATCH] drm: renesas: shmobile: shmo_drm_crtc: Fix PM imbalance > if RPM_ACTIVE is true > > Hi, > > On Mon, Jul 08, 2024 at 09:27:09AM GMT, Biju Das wrote: > > The pm_runtime_resum

Re: [PATCH] drm: renesas: rcar-du: rcar_lvds: Fix PM imbalance if RPM_ACTIVE

2024-07-08 Thread Geert Uytterhoeven
Hi Biju, On Mon, Jul 8, 2024 at 10:22 AM Biju Das wrote: > The pm_runtime_resume_and_get() returns 1 if RPM is active, in this > case it won't call a put. This will result in PM imbalance as it > treat this as an error and propagate this to caller and the caller > never calls corresponding put().

RE: [PATCH] drm: renesas: rcar-du: rcar_lvds: Fix PM imbalance if RPM_ACTIVE

2024-07-08 Thread Biju Das
Hi Geert, > -Original Message- > From: Geert Uytterhoeven > Sent: Monday, July 8, 2024 10:11 AM > Subject: Re: [PATCH] drm: renesas: rcar-du: rcar_lvds: Fix PM imbalance if > RPM_ACTIVE > > Hi Biju, > > On Mon, Jul 8, 2024 at 10:22 AM Biju Das wrote: > > The pm_runtime_resume_and_get

Re: [PATCH] drm: renesas: shmobile: shmo_drm_crtc: Fix PM imbalance if RPM_ACTIVE is true

2024-07-08 Thread Geert Uytterhoeven
Hi Biju, On Mon, Jul 8, 2024 at 11:00 AM Biju Das wrote: > > From: Maxime Ripard > > On Mon, Jul 08, 2024 at 09:27:09AM GMT, Biju Das wrote: > > > The pm_runtime_resume_and_get() returns 1 if RPM is active, in this > > > case it won't call a put. This will result in PM imbalance as it treat > >

RE: [PATCH] drm: renesas: shmobile: shmo_drm_crtc: Fix PM imbalance if RPM_ACTIVE is true

2024-07-08 Thread Biju Das
Hi Maxime, > -Original Message- > From: Biju Das > Sent: Monday, July 8, 2024 10:01 AM > Subject: RE: [PATCH] drm: renesas: shmobile: shmo_drm_crtc: Fix PM imbalance > if RPM_ACTIVE is true > > Hi Maxime, > > > -Original Message- > > From: Maxime Ripard > > Sent: Monday, July 8

[PATCH libdrm] modtest: print libdrm version

2024-07-08 Thread Andy Yan
From: Andy Yan Signed-off-by: Andy Yan --- meson.build | 1 + tests/modetest/modetest.c | 1 + 2 files changed, 2 insertions(+) diff --git a/meson.build b/meson.build index 8fd0a196..fab61e09 100644 --- a/meson.build +++ b/meson.build @@ -45,6 +45,7 @@ dep_threads = dependency('t

Re: [PATCH] drm/rockchip: cdn-dp: Remove redundant workarounds for firmware loading

2024-07-08 Thread Maxime Ripard
On Mon, Jul 08, 2024 at 03:46:16PM GMT, Andy Yan wrote: > > Hi Dragan, > At 2024-07-04 18:35:42, "Dragan Simic" wrote: > >Hello Andy, > > > >On 2024-07-04 04:10, Andy Yan wrote: > >> At 2024-07-04 07:32:02, "Dragan Simic" wrote: > >>> After the additional firmware-related module information was

Re: [PATCH v2] drm/msm: add msm8998 hdmi phy/pll support

2024-07-08 Thread Marc Gonzalez
On 05/07/2024 16:34, Dmitry Baryshkov wrote: > On Thu, Jul 04, 2024 at 06:45:36PM GMT, Marc Gonzalez wrote: > >> From: Arnaud Vrac >> >> Ported from the downstream driver. > > Please write some sensible commit message. Here's an attempt at expanding the commit message: """ This code adds suppo

Re: [PATCH v3 1/9] drm/tests: Stop using deprecated dev_private member on drm_framebuffer tests

2024-07-08 Thread Maxime Ripard
On Wed, 3 Jul 2024 14:22:20 -0300, Carlos Eduardo Gallo Filho wrote: > The dev_private member of drm_device is deprecated and its use should > be avoided. Stop using it by embedding the drm_device onto a mock struct. > > The new mock struct allows to share variables and even further mocks > over t

Re: [PATCH v3 2/9] drm/tests: Add parameters to the drm_test_framebuffer_create test

2024-07-08 Thread Maxime Ripard
On Wed, 3 Jul 2024 14:22:21 -0300, Carlos Eduardo Gallo Filho wrote: > Extend the existing test case to cover: > 1. Invalid flag atribute in the struct drm_mode_fb_cmd2. > 2. Pixel format which requires non-linear modifier with > DRM_FORMAT_MOD_LINEAR set. > 3. Buffer offset for inexistent plane >

Re: [PATCH v3 3/9] drm/tests: Replace strcpy to strscpy on drm_test_framebuffer_create test

2024-07-08 Thread Maxime Ripard
On Wed, 3 Jul 2024 14:22:22 -0300, Carlos Eduardo Gallo Filho wrote: > Replace the use of strcpy to strscpy on the test_to_desc of the > drm_test_framebuffer_create test for better security and reliability. > > Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 4/9] drm/tests: Add test case for drm_internal_framebuffer_create()

2024-07-08 Thread Maxime Ripard
On Wed, Jul 03, 2024 at 02:22:23PM GMT, Carlos Eduardo Gallo Filho wrote: > Introduce a test to cover the creation of framebuffer with > modifier on a device that doesn't support it. > > Signed-off-by: Carlos Eduardo Gallo Filho > --- > v2: > - Reorder kunit cases alphabetically. > v3: > - Re

Re: [PATCH v3 5/9] drm/tests: Add test for drm_framebuffer_check_src_coords()

2024-07-08 Thread Maxime Ripard
On Wed, 3 Jul 2024 14:22:24 -0300, Carlos Eduardo Gallo Filho wrote: > Add a parametrized test for the drm_framebuffer_check_src_coords function. > > Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 6/9] drm/tests: Add test for drm_framebuffer_cleanup()

2024-07-08 Thread Maxime Ripard
On Wed, 3 Jul 2024 14:22:25 -0300, Carlos Eduardo Gallo Filho wrote: > Add a single KUnit test case for the drm_framebuffer_cleanup function. > > Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 7/9] drm/tests: Add test for drm_framebuffer_lookup()

2024-07-08 Thread Maxime Ripard
On Wed, 3 Jul 2024 14:22:26 -0300, Carlos Eduardo Gallo Filho wrote: > Add two KUnit test cases for the drm_framebuffer_lookup function, one for > the base case, that tests if the lookup finds the correct framebuffer object > and another that tests the lookup for an inexistent framebuffer. > > Sig

Re: [PATCH v3 8/9] drm/tests: Add test for drm_framebuffer_init()

2024-07-08 Thread Maxime Ripard
On Wed, Jul 03, 2024 at 02:22:27PM GMT, Carlos Eduardo Gallo Filho wrote: > Add three KUnit test cases for the drm_framebuffer_init function: > > 1. Test if expected values are being set after drm_framebuffer_init() call. > 2. Try to init a framebuffer without setting its format. > 3. Try calling

Re: [PATCH v3 9/9] drm/tests: Add test for drm_framebuffer_free()

2024-07-08 Thread Maxime Ripard
On Wed, 3 Jul 2024 14:22:28 -0300, Carlos Eduardo Gallo Filho wrote: > Add a single KUnit test case for the drm_framebuffer_free function. > > Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH] drm/qxl: Pin buffer objects for internal mappings

2024-07-08 Thread Thomas Zimmermann
Hi Am 08.07.24 um 10:58 schrieb Daniel Vetter: On Mon, Jul 08, 2024 at 10:09:44AM +0200, Thomas Zimmermann wrote: Hi, ping for a review. This is a bugfix for a serious problem. I tried to look around whether there's any place where we could WARN_ON if we create a vmap but it's not pinned. But

Re: [PATCH] drm/qxl: Pin buffer objects for internal mappings

2024-07-08 Thread Dmitry Osipenko
On 7/2/24 17:20, Thomas Zimmermann wrote: > @@ -190,7 +190,13 @@ int qxl_bo_vmap(struct qxl_bo *bo, struct iosys_map *map) > if (r) > return r; > > + r = qxl_bo_pin_locked(bo); > + if (r) > + return r; Is qxl_bo_unreserve() missing here? > + > r = q

Re: Linux 6.10-rc1

2024-07-08 Thread Pavel Machek
Hi! > > Ok, so machine is ready to be thrown out of window, again. Trying to > > play 29C3 video should not make machine completely unusable ... as in > > keyboard looses keystrokes in terminal. > > Well, that at least sounds like you can bisect it with a very clear test-case? > > Even if you do

Re: [PATCH] drm/qxl: Pin buffer objects for internal mappings

2024-07-08 Thread Thomas Zimmermann
Hi Am 08.07.24 um 13:55 schrieb Dmitry Osipenko: On 7/2/24 17:20, Thomas Zimmermann wrote: @@ -190,7 +190,13 @@ int qxl_bo_vmap(struct qxl_bo *bo, struct iosys_map *map) if (r) return r; + r = qxl_bo_pin_locked(bo); + if (r) + return r; Is qxl_bo

Re: [PATCH v4 1/7] drm/mgag200: Use hexadecimal register indeces

2024-07-08 Thread Jocelyn Falempe
On 05/07/2024 13:47, Thomas Zimmermann wrote: In mgag200_set_mode_regs(), use hexadecimal indices for accessing registers. Aligns the code with the register indices in the Matrox programming manuals. Also convert to lower-case hexadecimal values. Thanks, it looks good to me. Reviewed-by: J

Re: [PATCH v4 2/7] drm/mgag200: Align register field names with documentation

2024-07-08 Thread Jocelyn Falempe
On 05/07/2024 13:47, Thomas Zimmermann wrote: In mgag200_set_mode_regs(), align variable names with the field names given in the Matrox programming manuals. Makes the code and docs grep- able. I confirm it's better when the code matches the documentation. Reviewed-by: Jocelyn Falempe Si

Re: [PATCH v4 3/7] drm/mgag200: Use adjusted mode values for CRTCs

2024-07-08 Thread Jocelyn Falempe
On 05/07/2024 13:47, Thomas Zimmermann wrote: Use the values with the crtc_ prefix from struct drm_display_mode to program hardware. The DRM core adjusted these values to the requirements of CRTC hardware. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Z

Re: [PATCH v4 4/7] drm/mgag200: Add dedicated variables for blanking fields

2024-07-08 Thread Jocelyn Falempe
On 05/07/2024 13:47, Thomas Zimmermann wrote: Represent fields for horizontal and vertical blanking with , , and . Aligns the code with the Matrox programming manuals. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag2

Re: [PATCH v5 1/5] drm/panel: boe-th101mb31ig002 : Make it compatible with other panel.

2024-07-08 Thread neil . armstrong
On 04/07/2024 09:29, Zhaoxiong Lv wrote: This driver currently only applies to one panel. Modify it to be compatible with other panels. Signed-off-by: Zhaoxiong Lv --- .../drm/panel/panel-boe-th101mb31ig002-28a.c | 40 +++ 1 file changed, 33 insertions(+), 7 deletions(-) di

Re: [PATCH V3] drm/bridge: adv7511: Fix Intermittent EDID failures

2024-07-08 Thread Adam Ford
On Sun, Jun 30, 2024 at 5:19 PM Adam Ford wrote: > > In the process of adding support for shared IRQ pins, a scenario > was accidentally created where adv7511_irq_process returned > prematurely causing the EDID to fail randomly. > > Since the interrupt handler is broken up into two main helper fun

Re: [PATCH v5 2/5] drm/panel: boe-th101mb31ig002: switch to devm_gpiod_get_optional() for reset_gpio

2024-07-08 Thread neil . armstrong
On 04/07/2024 09:29, Zhaoxiong Lv wrote: Switch the driver to use devm_gpiod_get_optional() on reset_gpio to avoid driver probe issues when reset line is not specified. Signed-off-by: Zhaoxiong Lv --- drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 2 +- 1 file changed, 1 insertion(+)

Re: [PATCH v5 3/5] drm/panel: boe-th101mb31ig002: use wrapped MIPI DCS functions

2024-07-08 Thread neil . armstrong
On 04/07/2024 09:29, Zhaoxiong Lv wrote: Remove conditional code and always use mipi_dsi_dcs_*multi() wrappers to simplify driver's init/enable/exit code. Convert the hex in init_code from UPPERCASE to lowercase. Signed-off-by: Zhaoxiong Lv --- .../drm/panel/panel-boe-th101mb31ig002-28a.c |

Re: [PATCH v5 5/5] drm/panel: :boe-th101mb31ig002: Support for starry-er88577 MIPI-DSI panel

2024-07-08 Thread neil . armstrong
On 04/07/2024 09:29, Zhaoxiong Lv wrote: The init_code of the starry-er88577 panel is very similar to the panel-boe-th101mb31ig002-28a.c driver, so we make it compatible with the panel-boe-th101mb31ig002-28a.c driver Signed-off-by: Zhaoxiong Lv --- Changes between V5 and V4: - 1. Compatible wi

Re: [PATCH v2 2/3] drm/panel: himax-hx8394: switch to devm_gpiod_get_optional() for reset_gpio

2024-07-08 Thread neil . armstrong
On 01/07/2024 10:58, Manikandan Muralidharan wrote: Switch the driver to use devm_gpiod_get_optional() on reset_gpio to avoid driver probe issues when reset line is not specified. Signed-off-by: Manikandan Muralidharan --- drivers/gpu/drm/panel/panel-himax-hx8394.c | 2 +- 1 file changed, 1

Re: [PATCH v2 3/3] drm/panel: himax-hx8394: Add Support for Microchip AC40T08A MIPI Display Panel

2024-07-08 Thread neil . armstrong
On 01/07/2024 10:58, Manikandan Muralidharan wrote: Add support for the Microchip AC40T08A MIPI Display panel. This panel uses a Himax HX8394 display controller and requires a vendor provided init sequence. The display resolution is 720x1280@60Hz with width and height of 76mm and 132mm respective

Re: [PATCH v4 6/7] drm/mgag200: Add vblank support

2024-07-08 Thread Jocelyn Falempe
On 05/07/2024 13:47, Thomas Zimmermann wrote: There's no VBLANK interrupt on Matrox chipsets. The workaround that is being used here and in other free Matrox drivers is to program to the value of and enable the VLINE interrupt. This triggers an interrupt at the time when VBLANK begins. VLIN

Re: [PATCH v4 7/7] drm/mgag200: Implement struct drm_crtc_funcs.get_vblank_timestamp

2024-07-08 Thread Jocelyn Falempe
On 05/07/2024 13:47, Thomas Zimmermann wrote: Implement struct drm_crtc_funcs.get_vblank_timestamp with the DRM helper drm_crtc_vblank_helper_get_vblank_timestamp() with its helper get_scanout_position. Read the scanout position from the MGAREG_VCOUNT register. Thanks, it looks good to me.

Re: [PATCH v2] drm/msm: add msm8998 hdmi phy/pll support

2024-07-08 Thread Dmitry Baryshkov
On Mon, 8 Jul 2024 at 14:07, Marc Gonzalez wrote: > > On 05/07/2024 16:34, Dmitry Baryshkov wrote: > > > On Thu, Jul 04, 2024 at 06:45:36PM GMT, Marc Gonzalez wrote: > > > >> From: Arnaud Vrac > >> > >> Ported from the downstream driver. > > > > Please write some sensible commit message. > > Here

Patch "drm/ttm: Always take the bo delayed cleanup path for imported bos" has been added to the 6.9-stable tree

2024-07-08 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/ttm: Always take the bo delayed cleanup path for imported bos to the 6.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patc

Re: [PATCH v4 6/7] drm/mgag200: Add vblank support

2024-07-08 Thread Thomas Zimmermann
Hi Jocelyn Am 08.07.24 um 14:46 schrieb Jocelyn Falempe: On 05/07/2024 13:47, Thomas Zimmermann wrote: There's no VBLANK interrupt on Matrox chipsets. The workaround that is being used here and in other free Matrox drivers is to program to the value of and enable the VLINE interrupt. This

Re: [PATCH V3] drm/bridge: adv7511: Fix Intermittent EDID failures

2024-07-08 Thread Dmitry Baryshkov
On Sun, 30 Jun 2024 17:19:31 -0500, Adam Ford wrote: > In the process of adding support for shared IRQ pins, a scenario > was accidentally created where adv7511_irq_process returned > prematurely causing the EDID to fail randomly. > > Since the interrupt handler is broken up into two main helper f

Re: [PATCH] drm/stm: Remove unnecessary .owner for lvds_platform_driver

2024-07-08 Thread Philippe CORNU
On 7/1/24 08:23, Jiapeng Chong wrote: Remove .owner field if calls are used which set it automatically. ./drivers/gpu/drm/stm/lvds.c:1213:3-8: No need to set .owner here. The core will do it. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9457 Signed-off-by

[PATCH] kselftests: dmabuf-heaps: Ensure the driver name is null-terminated

2024-07-08 Thread Zenghui Yu
Even if a vgem device is configured in, we will skip the import_vgem_fd() test almost every time. TAP version 13 1..11 # Testing heap: system # === # Testing allocation and importing: ok 1 # SKIP Could not open vgem -1 The problem is that we use the

Re: [PATCH 02/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller display engine

2024-07-08 Thread Krzysztof Kozlowski
On 08/07/2024 08:40, Liu Ying wrote: >>> + >>> + "^framegen@[0-9a-f]+$": >>> +type: object >>> +additionalProperties: true >>> + >>> +properties: >>> + compatible: >>> +const: fsl,imx8qxp-dc-framegen >>> + >>> + "^gammacor@[0-9a-f]+$": >> >> This looks like you are organi

Re: [PATCH 03/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller pixel engine

2024-07-08 Thread Krzysztof Kozlowski
On 08/07/2024 08:47, Liu Ying wrote: > On 07/07/2024, Krzysztof Kozlowski wrote: >> On 05/07/2024 11:09, Liu Ying wrote: >>> i.MX8qxp Display Controller pixel engine consists of all processing units >>> that operate in the AXI bus clock domain. Command sequencer and interrupt >>> controller of the

Re: [PATCH 04/10] dt-bindings: interrupt-controller: Add i.MX8qxp Display Controller interrupt controller

2024-07-08 Thread Krzysztof Kozlowski
On 08/07/2024 08:51, Liu Ying wrote: > On 07/07/2024, Krzysztof Kozlowski wrote: >> On 05/07/2024 11:09, Liu Ying wrote: >>> i.MX8qxp Display Controller has a built-in interrupt controller to support >>> Enable/Status/Preset/Clear interrupt bit. >>> >>> Signed-off-by: Liu Ying >>> --- >>> .../fsl

Re: [PATCH] drm/format-helper: Add conversion from XRGB8888 to BGR888

2024-07-08 Thread Aditya Garg
Hi > > I see. Best would be to submit this patch together with the driver for review. > Although it’s your take, but I really doubt whether the driver would make it upstream. It shall most likely be provided as a DKMS module. What should be the best case scenario then? > Best regards > Thomas

Re: [PATCH] drm/format-helper: Add conversion from XRGB8888 to BGR888

2024-07-08 Thread Aditya Garg
> On 8 Jul 2024, at 1:59 PM, Thomas Zimmermann wrote: > > Hi > >> Am 08.07.24 um 10:10 schrieb Aditya Garg: >> Hi >>> I see. Best would be to submit this patch together with the driver for >>> review. >>> >> Although it’s your take, but I really doubt whether the driver would make it >> up

Re: [PATCH] drm/format-helper: Add conversion from XRGB8888 to BGR888

2024-07-08 Thread Aditya Garg
> On 8 Jul 2024, at 1:00 PM, Thomas Zimmermann wrote: > > Hi > > Am 05.07.24 um 13:38 schrieb Aditya Garg: >> From: Kerem Karabay >> >> Add XRGB emulation helper for devices that only support BGR888. > > Nothing wrong with that, but it needs a caller. Do you have a driver that > uses t

[PATCH v2] drm/qxl: Pin buffer objects for internal mappings

2024-07-08 Thread Thomas Zimmermann
Add qxl_bo_pin_and_vmap() that pins and vmaps a buffer object in one step. Update callers of the regular qxl_bo_vmap(). Fixes a bug where qxl accesses an unpinned buffer object while it is being moved; such as with the monitor-description BO. An typical error is shown below. [4.303586] [drm:dr

Re: [PATCH v2] drm/qxl: Pin buffer objects for internal mappings

2024-07-08 Thread Dmitry Osipenko
On 7/8/24 17:21, Thomas Zimmermann wrote: > Add qxl_bo_pin_and_vmap() that pins and vmaps a buffer object in one > step. Update callers of the regular qxl_bo_vmap(). Fixes a bug where > qxl accesses an unpinned buffer object while it is being moved; such > as with the monitor-description BO. An typ

Re: [PATCH] drm/fbdev-dma: Fix framebuffer mode for big endian devices

2024-07-08 Thread Thomas Zimmermann
Hi, I've added a Fixes tag and merged the patch into drm-misc-next-fixes. Best regards Thomas Am 02.07.24 um 14:17 schrieb Thomas Huth: The drm_mode_legacy_fb_format() function only generates formats suitable for little endian devices. switch to drm_driver_legacy_fb_format() here instead to ta

Re: [PATCH 02/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller display engine

2024-07-08 Thread Maxime Ripard
On Mon, Jul 08, 2024 at 04:04:21PM GMT, Krzysztof Kozlowski wrote: > On 08/07/2024 08:40, Liu Ying wrote: > >>> + > >>> + "^framegen@[0-9a-f]+$": > >>> +type: object > >>> +additionalProperties: true > >>> + > >>> +properties: > >>> + compatible: > >>> +const: fsl,imx8qxp-

Re: [PATCH] MAINTAINERS: drm/sti: mark it as Odd Fixes

2024-07-08 Thread Maxime Ripard
On Fri, Jul 05, 2024 at 05:14:36PM GMT, Alain Volmat wrote: > Hi Krzysztof, Daniel, and Maxime, > > On Fri, Jul 05, 2024 at 03:41:26PM +0200, Daniel Vetter wrote: > > On Fri, Jul 05, 2024 at 01:33:38PM +0200, Krzysztof Kozlowski wrote: > > > On 05/07/2024 13:22, Maxime Ripard wrote: > > > > On Fri

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-08 Thread Maxime Ripard
On Mon, Jul 01, 2024 at 05:36:18PM GMT, Marc Gonzalez wrote: > On 01/07/2024 15:50, Maxime Ripard wrote: > > > On Thu, Jun 27, 2024 at 01:13:03PM GMT, Marc Gonzalez wrote: > > > >> TDP158 is an AC-coupled DVI / HDMI to TMDS level shifting Redriver. > >> It supports DVI 1.0, HDMI 1.4b and 2.0b. > >

[PATCH v4 1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis

2024-07-08 Thread Marek Vasut
Document default DP port preemphasis configurable via new DT property "toshiba,pre-emphasis". This is useful in case the DP link properties are known and starting link training from preemphasis setting of 0 dB is not useful. The preemphasis can be set separately for both DP lanes in range 0=0dB, 1=

[PATCH v4 2/2] drm/bridge: tc358767: Add configurable default preemphasis

2024-07-08 Thread Marek Vasut
Make the default DP port preemphasis configurable via new DT property "toshiba,pre-emphasis". This is useful in case the DP link properties are known and starting link training from preemphasis setting of 0 dB is not useful. The preemphasis can be set separately for both DP lanes in range 0=0dB, 1=

Re: [PATCH v7 8/8] drm/ttm: Balance ttm_resource_cursor_init() and ttm_resource_cursor_fini()

2024-07-08 Thread Matthew Brost
On Fri, Jul 05, 2024 at 05:32:06PM +0200, Thomas Hellström wrote: > Make the interface more symmetric by providing and using a > ttm_resource_cursor_init(). > > Signed-off-by: Thomas Hellström > --- > drivers/gpu/drm/ttm/ttm_bo.c | 3 ++- > drivers/gpu/drm/ttm/ttm_bo_util.c | 4 +++- >

Re: The TTM LRU-walk cherry-pick series

2024-07-08 Thread Matthew Brost
On Sun, Jul 07, 2024 at 05:49:16PM +0200, Thomas Hellström wrote: > Christian, Matthew, > > I think I addressed all review comments and a couple of anticipated > ones (s/long/s64/) in the swapout- and eviction patches. > > I'm heading off on vacation today, (4 weeks) so if something becomes > urg

Re: The TTM LRU-walk cherry-pick series

2024-07-08 Thread Christian König
Am 08.07.24 um 17:23 schrieb Matthew Brost: On Sun, Jul 07, 2024 at 05:49:16PM +0200, Thomas Hellström wrote: Christian, Matthew, I think I addressed all review comments and a couple of anticipated ones (s/long/s64/) in the swapout- and eviction patches. I'm heading off on vacation today, (4 w

Re: The TTM LRU-walk cherry-pick series

2024-07-08 Thread Matthew Brost
On Mon, Jul 08, 2024 at 05:29:30PM +0200, Christian König wrote: > Am 08.07.24 um 17:23 schrieb Matthew Brost: > > On Sun, Jul 07, 2024 at 05:49:16PM +0200, Thomas Hellström wrote: > > > Christian, Matthew, > > > > > > I think I addressed all review comments and a couple of anticipated > > > ones

Re: [PATCH v3 23/23] arm64: dts: qcom: starqltechn: add new features

2024-07-08 Thread Dzmitry Sankouski
вт, 18 июн. 2024 г. в 17:12, Konrad Dybcio : > > ... > > > gpio-reserved-ranges = <0 4>, <27 4>, <81 4>, <85 4>; > > Do you know what these are for? > > Konrad <85 4> is spi for fingerprint. <27 4> is spi for eSE(embedded Secure Element) The rest shouldn't be reserved. -- Best regards, Dz

Re: [PATCH] dt-bindings: display: bridge: ti,sn65dsi83: add burst-mode-disabled

2024-07-08 Thread Krzysztof Kozlowski
On 08/07/2024 17:18, stefano.radaell...@gmail.com wrote: > From: Stefano Radaelli > > It allows to disable Burst video mode > > Co-developed-by: Noah J. Rosa > Signed-off-by: Noah J. Rosa > Signed-off-by: Stefano Radaelli > --- > .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml

[Patch v2] drm/ttm: Allow direct reclaim to allocate local memory

2024-07-08 Thread Rajneesh Bhardwaj
Limiting the allocation of higher order pages to the closest NUMA node and enabling direct memory reclaim provides not only failsafe against situations when memory becomes too much fragmented and the allocator is not able to satisfy the request from the local node but falls back to remote pages (HU

Re: [PATCH] drm/bridge: ti-sn65dsi83: Add Non-Burst mode property

2024-07-08 Thread Krzysztof Kozlowski
On 08/07/2024 17:18, stefano.radaell...@gmail.com wrote: > From: Stefano Radaelli > > The video mode can be divided into two methods for sending packet data: > burst mode and non-burst mode. > In burst mode, pixel data is compressed to save time for the interface > to return to low power. > Non-b

Re: [PATCH v3 2/2] drm/bridge: tc358767: Add configurable default preemphasis

2024-07-08 Thread Marek Vasut
On 6/26/24 9:36 AM, Alexander Stein wrote: Hi, sorry for the late reply. @@ -2435,6 +2454,18 @@ static int tc_probe_bridge_endpoint(struct tc_data *tc) return -EINVAL; } mode |= BIT(endpoint.port); + if (endpoint.port != 2)

Re: [PATCH] dt-bindings: display: bridge: ti,sn65dsi83: add burst-mode-disabled

2024-07-08 Thread Marek Vasut
On 7/8/24 5:18 PM, stefano.radaell...@gmail.com wrote: From: Stefano Radaelli It allows to disable Burst video mode Why would you want to disable burst mode ? This is the energy efficient and recommended mode, why disable it ? Details please ?

Re: [PATCH v3 1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis

2024-07-08 Thread Marek Vasut
On 6/26/24 9:29 AM, Alexander Stein wrote: Hi, + oneOf: - required: - port@0 I get this warning: mx8mp-tqma8mpql-mba8mpxl.dtb: bridge@f: ports:port@2:endpoint: Unevaluated properties are not allowed ('toshiba,pre-emphasis' was unexpected) DT node looks like this:

Re: [PATCH v3 00/21] iommu: Refactoring domain allocation interface

2024-07-08 Thread Jason Gunthorpe
On Thu, Jul 04, 2024 at 03:18:56PM +0100, Will Deacon wrote: > On Mon, 10 Jun 2024 16:55:34 +0800, Lu Baolu wrote: > > The IOMMU subsystem has undergone some changes, including the removal > > of iommu_ops from the bus structure. Consequently, the existing domain > > allocation interface, which rel

Re: [PATCH v3 9/9] drm/tests: Add test for drm_framebuffer_free()

2024-07-08 Thread Carlos
Hi Maxime, thank you for the review! On 7/8/24 08:36, Maxime Ripard wrote: On Wed, 3 Jul 2024 14:22:28 -0300, Carlos Eduardo Gallo Filho wrote: Add a single KUnit test case for the drm_framebuffer_free function. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard Accordingly

Re: [PATCH] dt-bindings: display: bridge: ti,sn65dsi83: add burst-mode-disabled

2024-07-08 Thread Rob Herring (Arm)
On Mon, 08 Jul 2024 17:18:56 +0200, stefano.radaell...@gmail.com wrote: > From: Stefano Radaelli > > It allows to disable Burst video mode > > Co-developed-by: Noah J. Rosa > Signed-off-by: Noah J. Rosa > Signed-off-by: Stefano Radaelli > --- > .../devicetree/bindings/display/bridge/ti,sn6

Re: [PATCH] kselftests: dmabuf-heaps: Ensure the driver name is null-terminated

2024-07-08 Thread T.J. Mercier
On Mon, Jul 8, 2024 at 6:47 AM Zenghui Yu wrote: > > Even if a vgem device is configured in, we will skip the import_vgem_fd() > test almost every time. > > TAP version 13 > 1..11 > # Testing heap: system > # === > # Testing allocation and importing: >

[PATCH] drm/panel: sharp-lq101r1sx01: Fixed reversed "if" in remove

2024-07-08 Thread Douglas Anderson
Commit d7d473d8464e ("drm/panel: sharp-lq101r1sx01: Don't call disable at shutdown/remove") had a subtle bug. We should be calling sharp_panel_del() when the "sharp" variable is non-NULL, not when it's NULL. Fix. Fixes: d7d473d8464e ("drm/panel: sharp-lq101r1sx01: Don't call disable at shutdown/r

Re: [PATCH v3 23/23] arm64: dts: qcom: starqltechn: add new features

2024-07-08 Thread Konrad Dybcio
On 8.07.2024 5:54 PM, Dzmitry Sankouski wrote: > вт, 18 июн. 2024 г. в 17:12, Konrad Dybcio : >> >> > ... >> >>> gpio-reserved-ranges = <0 4>, <27 4>, <81 4>, <85 4>; >> >> Do you know what these are for? >> >> Konrad > > <85 4> is spi for fingerprint. > <27 4> is spi for eSE(embedded Secure

[PATCH] drm/bridge: ti-sn65dsi83: Add Non-Burst mode property

2024-07-08 Thread stefano . radaelli21
From: Stefano Radaelli The video mode can be divided into two methods for sending packet data: burst mode and non-burst mode. In burst mode, pixel data is compressed to save time for the interface to return to low power. Non-burst modes transmit pixel data in a stream controlled by sync pulses or

[PATCH] drm: Add documentation for struct drm_plane_size_hint members

2024-07-08 Thread Abhishek Tamboli
Add descriptions for 'width' and 'height' members in struct drm_plane_size_hint to improve clarity and documentation coverage. Signed-off-by: Abhishek Tamboli --- include/uapi/drm/drm_mode.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/

[PATCH] dt-bindings: display: bridge: ti, sn65dsi83: add burst-mode-disabled

2024-07-08 Thread stefano . radaelli21
From: Stefano Radaelli It allows to disable Burst video mode Co-developed-by: Noah J. Rosa Signed-off-by: Noah J. Rosa Signed-off-by: Stefano Radaelli --- .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devic

Re: Time for drm-ci-next?

2024-07-08 Thread Rob Clark
On Mon, Jul 8, 2024 at 1:52 AM Daniel Vetter wrote: > > On Fri, Jul 05, 2024 at 12:31:36PM -0700, Rob Clark wrote: > > On Fri, Jul 5, 2024 at 3:36 AM Daniel Vetter wrote: > > > > > > On Thu, Jul 04, 2024 at 08:40:26AM -0700, Rob Clark wrote: > > > > On Thu, Jul 4, 2024 at 7:08 AM Daniel Vetter

  1   2   >