Re: [PATCH v4 3/7] drm/mgag200: Use adjusted mode values for CRTCs

[Jocelyn Falempe]

On 05/07/2024 13:47, Thomas Zimmermann wrote:

Use the values with the crtc_ prefix from struct drm_display_mode to
program hardware. The DRM core adjusted these values to the requirements
of CRTC hardware.

Thanks, it looks good to me.

Reviewed-by: Jocelyn Falempe <jfale...@redhat.com>

Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
---
  drivers/gpu/drm/mgag200/mgag200_mode.c | 16 ++++++++--------
  1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c 
b/drivers/gpu/drm/mgag200/mgag200_mode.c
index 09e2a5b80403..ccad5bd5960d 100644
--- a/drivers/gpu/drm/mgag200/mgag200_mode.c
+++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
@@ -208,19 +208,19 @@ void mgag200_set_mode_regs(struct mga_device *mdev, const 
struct drm_display_mod
        unsigned int vdispend, vsyncstr, vsyncend, vtotal;
        u8 misc, crtcext1, crtcext2, crtcext5;

- hdispend = mode->hdisplay / 8 - 1;

-       hsyncstr = mode->hsync_start / 8 - 1;
-       hsyncend = mode->hsync_end / 8 - 1;
-       htotal = mode->htotal / 8 - 1;
+       hdispend = mode->crtc_hdisplay / 8 - 1;
+       hsyncstr = mode->crtc_hsync_start / 8 - 1;
+       hsyncend = mode->crtc_hsync_end / 8 - 1;
+       htotal = mode->crtc_htotal / 8 - 1;

/* Work around hardware quirk */

        if ((htotal & 0x07) == 0x06 || (htotal & 0x07) == 0x04)
                htotal++;

- vdispend = mode->vdisplay - 1;

-       vsyncstr = mode->vsync_start - 1;
-       vsyncend = mode->vsync_end - 1;
-       vtotal = mode->vtotal - 2;
+       vdispend = mode->crtc_vdisplay - 1;
+       vsyncstr = mode->crtc_vsync_start - 1;
+       vsyncend = mode->crtc_vsync_end - 1;
+       vtotal = mode->crtc_vtotal - 2;

misc = RREG8(MGA_MISC_IN);