[PATCH] drm/radeon: fix null pointer dereference in radeon_add_common_modes

2024-06-26 Thread Ma Ke
In radeon_add_common_modes(), the return value of drm_cvt_mode() is assigned to mode, which will lead to a possible NULL pointer dereference on failure of drm_cvt_mode(). Add a check to avoid npd. Signed-off-by: Ma Ke --- drivers/gpu/drm/radeon/radeon_connectors.c | 2 ++ 1 file changed, 2 inser

[PATCH] drm/client: fix null pointer dereference in drm_client_modeset_probe

2024-06-26 Thread Ma Ke
In drm_client_modeset_probe(), the return value of drm_mode_duplicate() is assigned to modeset->mode, which will lead to a possible NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Signed-off-by: Ma Ke --- drivers/gpu/drm/drm_client_modeset.c | 2 ++ 1 file

[PATCH] drm/nouveau/dispnv04: fix null pointer dereference in nv17_tv_get_ld_modes

2024-06-26 Thread Ma Ke
In nv17_tv_get_ld_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a possible NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Cc: sta...@vger.kernel.org Signed-off-by: Ma Ke --- drivers/gpu/drm/nouveau/dispnv04/tvnv1

[PATCH] drm/nouveau: fix null pointer dereference in nouveau_connector_get_modes

2024-06-26 Thread Ma Ke
In nouveau_connector_get_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a possible NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Signed-off-by: Ma Ke --- drivers/gpu/drm/nouveau/nouveau_connector.c | 2 ++ 1 file

[PATCH 1/2] dt-bindings: display: simple: Add AUO G104STN01 panel

2024-06-26 Thread Paul Gerber
Add AUO G104STN01 10.4" LCD-TFT LVDS panel compatible string. Signed-off-by: Paul Gerber --- Tested on TQ MBa8MPxL with TQMa8MPxL. .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/pan

[PATCH] drm/gma500: fix null pointer dereference in psb_intel_lvds_get_modes

2024-06-26 Thread Ma Ke
In psb_intel_lvds_get_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a possible NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Signed-off-by: Ma Ke --- drivers/gpu/drm/gma500/psb_intel_lvds.c | 2 ++ 1 file change

[PATCH 2/2] drm/panel: simple: Add AUO G104STN01 panel entry

2024-06-26 Thread Paul Gerber
Add support for the AUO G104STN01 10.4" (800x600) LCD-TFT panel. Signed-off-by: Paul Gerber --- Tested on TQ MBa8MPxL with TQMa8MPxL. drivers/gpu/drm/panel/panel-simple.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/dri

[PATCH] drm/nouveau/dispnv04: fix null pointer dereference in nv17_tv_get_hd_modes

2024-06-26 Thread Ma Ke
In nv17_tv_get_hd_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a possible NULL pointer dereference on failure of drm_mode_duplicate(). The same applies to drm_cvt_mode(). Add a check to avoid null pointer dereference. Cc: sta...@vger.kernel.org Signed-o

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-26 Thread Daniel Vetter
On Thu, May 09, 2024 at 05:41:18PM +0300, Oded Gabbay wrote: > On Thu, May 09, 2024 at 03:53:01PM +0200, Tomeu Vizoso wrote: > > Oded, Dave, > > > > Do you have an opinion on this? > > > > Thanks, > > > > Tomeu > Hi Tomeu, > > Sorry for not replying earlier, I was down with Covid (again...). >

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-26 Thread Daniel Vetter
On Mon, Jun 17, 2024 at 07:01:05PM +0200, Tomeu Vizoso wrote: > Hi Lucas, > > Do you have any idea on how not to break userspace if we expose a render node? So if you get a new chip with an incompatible 3d block, you already have that issue. And I hope etnaviv userspace can cope. Worst case you

Re: [PATCH v3 1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis

2024-06-26 Thread Alexander Stein
Hi Marek, Am Dienstag, 25. Juni 2024, 14:05:14 CEST schrieb Marek Vasut: > Document default DP port preemphasis configurable via new DT property > "toshiba,pre-emphasis". This is useful in case the DP link properties > are known and starting link training from preemphasis setting of 0 dB > is not

Re: (subset) [PATCH 0/2] arm64: dts: amlogic: add power domain to hdmitx

2024-06-26 Thread Neil Armstrong
Hi, On Tue, 25 Jun 2024 16:50:13 +0200, Jerome Brunet wrote: > This patchset add the bindings for the power domain of the HDMI Tx > on Amlogic SoC. > > This is a 1st step in cleaning HDMI Tx and its direct usage of HHI > register space. Eventually, this will help remove component usage from > the

Re: (subset) [PATCH 0/2] arm64: dts: amlogic: add power domain to hdmitx

2024-06-26 Thread Neil Armstrong
Hi, On Tue, 25 Jun 2024 16:50:13 +0200, Jerome Brunet wrote: > This patchset add the bindings for the power domain of the HDMI Tx > on Amlogic SoC. > > This is a 1st step in cleaning HDMI Tx and its direct usage of HHI > register space. Eventually, this will help remove component usage from > the

Re: Time for drm-ci-next?

2024-06-26 Thread Daniel Vetter
On Mon, Jun 24, 2024 at 10:25:25AM -0300, Helen Koike wrote: > > > On 24/06/2024 02:34, Vignesh Raman wrote: > > Hi, > > > > On 15/03/24 22:50, Rob Clark wrote: > > > On Fri, Mar 15, 2024 at 2:28 AM Jani Nikula > > > wrote: > > > > > > > > On Thu, 14 Mar 2024, Rob Clark wrote: > > > > > When

Re: [PATCH v3 2/2] drm/bridge: tc358767: Add configurable default preemphasis

2024-06-26 Thread Alexander Stein
Hi Marek, thanks for patch. Am Dienstag, 25. Juni 2024, 14:05:15 CEST schrieb Marek Vasut: > Make the default DP port preemphasis configurable via new DT property > "toshiba,pre-emphasis". This is useful in case the DP link properties > are known and starting link training from preemphasis settin

Re: [PATCH 1/2] dt-bindings: display: simple: Add AUO G104STN01 panel

2024-06-26 Thread Krzysztof Kozlowski
On 26/06/2024 06:36, Paul Gerber wrote: > Add AUO G104STN01 10.4" LCD-TFT LVDS panel compatible string. > > Signed-off-by: Paul Gerber Acked-by: Krzysztof Kozlowski --- This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you

Re: [PATCH 1/8] drm: bridge: dw_hdmi: Call poweron/poweroff from atomic enable/disable

2024-06-26 Thread Daniel Vetter
On Mon, Jun 24, 2024 at 02:19:36PM +0200, Jonas Karlman wrote: > Hi Neil, > > On 2024-06-24 11:56, neil.armstr...@linaro.org wrote: > > On 24/06/2024 11:41, Jonas Karlman wrote: > >> Hi Neil, > >> > >> On 2024-06-24 11:23, Neil Armstrong wrote: > >>> On 11/06/2024 17:50, Jonas Karlman wrote: > >>>

Re: [PATCH v1 1/3] dt-bindings: display/msm/gmu: Add Adreno X185 GMU

2024-06-26 Thread Akhil P Oommen
On Sun, Jun 23, 2024 at 02:40:14PM +0200, Krzysztof Kozlowski wrote: > On 23/06/2024 13:06, Akhil P Oommen wrote: > > Document Adreno X185 GMU in the dt-binding specification. > > > > Signed-off-by: Akhil P Oommen > > --- > > > > Documentation/devicetree/bindings/display/msm/gmu.yaml | 4 >

Re: [PATCH v1 2/3] drm/msm/adreno: Add support for X185 GPU

2024-06-26 Thread Akhil P Oommen
On Mon, Jun 24, 2024 at 12:21:30AM +0300, Dmitry Baryshkov wrote: > On Sun, Jun 23, 2024 at 04:36:29PM GMT, Akhil P Oommen wrote: > > Add support in drm/msm driver for the Adreno X185 gpu found in > > Snapdragon X1 Elite chipset. > > > > Signed-off-by: Akhil P Oommen > > --- > > > > drivers/gpu

[PATCH] drm/msm/adreno: fix a7xx gpu init

2024-06-26 Thread Neil Armstrong
&a5xx_gpulist, &a6xx_gpulist, - &a6xx_gpulist, + &a7xx_gpulist, }; static const struct adreno_info *adreno_info(uint32_t chip_id) --- base-commit: 62c97045b8f720c2eac807a5f38e26c9ed512371 change-id: 20240626-topic-sm8x50-upstream-fix-a7xx-gpu-init-9fca9746ba73 Best regards, -- Neil Armstrong

Re: [PATCH 1/6] drm/amdgpu: allow ioctls to opt-out of runtime pm

2024-06-26 Thread Daniel Vetter
On Tue, Jun 25, 2024 at 09:07:12AM +0200, Pierre-Eric Pelloux-Prayer wrote: > > Le 20/06/2024 à 15:36, Christian König a écrit : > > Am 20.06.24 um 15:06 schrieb Pierre-Eric Pelloux-Prayer: > > > Le 19/06/2024 à 11:26, Christian König a écrit : > > > > Am 18.06.24 um 17:23 schrieb Pierre-Eric Pell

Re: [PATCH] drm/ast: Inline drm_simple_encoder_init()

2024-06-26 Thread Daniel Vetter
On Tue, Jun 25, 2024 at 04:03:21PM +0200, Thomas Zimmermann wrote: > Hi > > Am 25.06.24 um 15:55 schrieb Jocelyn Falempe: > > > > > > On 25/06/2024 15:18, Thomas Zimmermann wrote: > > > The function drm_simple_encoder_init() is a trivial helper and > > > deprecated. Replace it with the regular c

Re: [PATCH v2 1/2] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-06-26 Thread Daniel Vetter
On Tue, Jun 25, 2024 at 08:54:41PM +0200, Konrad Dybcio wrote: > Memory barriers help ensure instruction ordering, NOT time and order > of actual write arrival at other observers (e.g. memory-mapped IP). > On architectures employing weak memory ordering, the latter can be a > giant pain point, and

Re: [PATCH] printk: Add a short description string to kmsg_dump()

2024-06-26 Thread Petr Mladek
On Tue 2024-06-25 14:39:29, Jocelyn Falempe wrote: > kmsg_dump doesn't forward the panic reason string to the kmsg_dumper > callback. > This patch adds a new parameter "const char *desc" to the kmsg_dumper > dump() callback, and update all drivers that are using it. > > To avoid updating all kmsg_

Re: [PATCH v2 1/2] drm: bridge: samsung-dsim: Initialize bridge on attach

2024-06-26 Thread Michael Walle
On Wed Jun 26, 2024 at 5:21 AM CEST, Marek Vasut wrote: > Thank you for testing and keeping up with this. I will wait for more > feedback if there is any (Frieder? Lucas? Michael?). If there are no > objections, then I can merge it in a week or two ? I'll try to use your approach on the tc358775

Re: [PATCH v5 2/9] scatterlist: Add a flag for the restricted memory

2024-06-26 Thread 林睿祥

Re: [PATCH net-next v14 03/13] netdev: support binding dma-buf to netdevice

2024-06-26 Thread Daniel Vetter
On Tue, Jun 25, 2024 at 07:53:51PM +, Mina Almasry wrote: > Add a netdev_dmabuf_binding struct which represents the > dma-buf-to-netdevice binding. The netlink API will bind the dma-buf to > rx queues on the netdevice. On the binding, the dma_buf_attach > & dma_buf_map_attachment will occur. Th

[ANNOUNCE] libdrm 2.4.122

2024-06-26 Thread Simon Ser
Enrico Weigelt, metux IT consult (6): OpenBSD: fix FTBS on misspelled and missing variables fix FTBS on FreeBSD (or non-Linux in general) freedreno: fix FTBS on non-Linux platforms (unused header) etnaviv: fix FTBS on undefined linux/* headers on non-Linux platforms. c

Re: [PATCH v1 2/3] drm/msm/adreno: Add support for X185 GPU

2024-06-26 Thread Akhil P Oommen
On Mon, Jun 24, 2024 at 03:53:48PM +0200, Konrad Dybcio wrote: > > > On 6/23/24 13:06, Akhil P Oommen wrote: > > Add support in drm/msm driver for the Adreno X185 gpu found in > > Snapdragon X1 Elite chipset. > > > > Signed-off-by: Akhil P Oommen > > --- > > > > drivers/gpu/drm/msm/adreno/a6

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-26 Thread Lucas Stach
Am Mittwoch, dem 26.06.2024 um 09:28 +0200 schrieb Daniel Vetter: > On Mon, Jun 17, 2024 at 07:01:05PM +0200, Tomeu Vizoso wrote: > > Hi Lucas, > > > > Do you have any idea on how not to break userspace if we expose a render > > node? > > So if you get a new chip with an incompatible 3d block, y

Re: [PATCH v6 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC

2024-06-26 Thread Alexandre Mergnat
On 25/06/2024 15:44, Krzysztof Kozlowski wrote: On 25/06/2024 11:23, Alexandre Mergnat wrote: On 21/06/2024 17:00, Krzysztof Kozlowski wrote: On 19/06/2024 16:46, Alexandre Mergnat wrote: Add the audio codec sub-device. This sub-device is used to set the optional voltage values according

Re: Time for drm-ci-next?

2024-06-26 Thread Dmitry Baryshkov
On Wed, Jun 26, 2024 at 09:32:44AM GMT, Daniel Vetter wrote: > On Mon, Jun 24, 2024 at 10:25:25AM -0300, Helen Koike wrote: > > > > > > On 24/06/2024 02:34, Vignesh Raman wrote: > > > Hi, > > > > > > On 15/03/24 22:50, Rob Clark wrote: > > > > Basically, I often find myself needing to merge CI p

[PATCH 2/2] drm/panic: Restrict graphical logo handling to built-in

2024-06-26 Thread Geert Uytterhoeven
When CONFIG_DRM_PANIC=y, but CONFIG_DRM=m: ld: drivers/gpu/drm/drm_panic.o: in function `drm_panic_setup_logo': drivers/gpu/drm/drm_panic.c:99: multiple definition of `init_module'; drivers/gpu/drm/drm_drv.o:drivers/gpu/drm/drm_drv.c:1079: first defined here Fix this by restricting the g

[PATCH 0/2] drm/panic: Miscellaneous fixes

2024-06-26 Thread Geert Uytterhoeven
Hi all, Here are two more fixes for the DRM panic code. Thanks for your comments! Geert Uytterhoeven (2): drm/panic: Do not select DRM_KMS_HELPER drm/panic: Restrict graphical logo handling to built-in drivers/gpu/drm/Kconfig | 1 - drivers/gpu/drm/drm_panic.c | 3 +-- 2 files

[PATCH 1/2] drm/panic: Do not select DRM_KMS_HELPER

2024-06-26 Thread Geert Uytterhoeven
DRM core code cannot call into DRM helper code, as this would lead to circular references in the modular case. Hence drop the selection of DRM_KMS_HELPER. It was unused anyway, as v10 switched from using the DRM format helpers to its own color format conversion, cfr. commit 9544309775c334c9 ("drm

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-26 Thread Dmitry Baryshkov
On Wed, Jun 26, 2024 at 09:26:40AM GMT, Daniel Vetter wrote: > On Thu, May 09, 2024 at 05:41:18PM +0300, Oded Gabbay wrote: > > On Thu, May 09, 2024 at 03:53:01PM +0200, Tomeu Vizoso wrote: > > > Oded, Dave, > > > > > > Do you have an opinion on this? > > > > > > Thanks, > > > > > > Tomeu > > Hi

Re: [PATCH] drm/msm/adreno: fix a7xx gpu init

2024-06-26 Thread Dmitry Baryshkov
On Wed, Jun 26, 2024 at 09:53:16AM GMT, Neil Armstrong wrote: > The gpulist has twice the a6xx gpulist, replace the second one > with the a7xx gpulist. > > Solves: > msm_dpu ae01000.display-controller: Unknown GPU revision: 7.3.0.1 > msm_dpu ae01000.display-controller: Unknown GPU revision: 67.5.1

[PATCH RESEND] drm: bridge: dw-mipi-dsi: Allow sync-pulses to override the burst vid-mode

2024-06-26 Thread Heiko Stuebner
From: Heiko Stuebner The state right now is that if the panel has the burst-mode flag it will take precedence over the sync-pulses mode. While sync-pulses are only relevant for the video-mode, the burst-mode flag affects both the video-mode as well as the calculated lane_mbps. Looking at driver

[PATCH 0/3] Fix mst daisy chain light up issue after resume

2024-06-26 Thread Wayne Lin
Under DP mst daisy chain configuration, unplug one chained monitor during suspend and then resume, observe left connected monitor not light up. After analyzing, seems it's due to changing dpcd DP_MSTM_CTRL value after LT during reume. We used to defer handling UP request by disabling DP_UP_REQ_EN

[PATCH 1/3] drm/dp_mst: Fix all mstb marked as not probed after suspend/resume

2024-06-26 Thread Wayne Lin
[Why] After supend/resume, with topology unchanged, observe that link_address_sent of all mstb are marked as false even the topology probing is done without any error. It is caused by wrongly also include "ret == 0" case as a probing failure case. [How] Remove inappropriate checking conditions.

[PATCH 2/3] drm/dp_mst: Skip CSN if topology probing is not done yet

2024-06-26 Thread Wayne Lin
[Why] During resume, observe that we receive CSN event before we start topology probing. Handling CSN at this moment based on uncertain topology is unnecessary. [How] Add checking condition in drm_dp_mst_handle_up_req() to skip handling CSN if the topology is yet to be probed. Cc: Lyude Paul Cc:

[PATCH 3/3] drm/amd/display: Solve mst monitors blank out problem after resume

2024-06-26 Thread Wayne Lin
[Why] In dm resume, we firstly restore dc state and do the mst resume for topology probing thereafter. If we change dpcd DP_MSTM_CTRL value after LT in mst reume, it will cause light up problem on the hub. [How] Revert the commit 202dc359adda ("drm/amd/display: Defer handling mst up request in res

Re: [PATCH] drm/mipi-dsi: Fix devm unregister & detach

2024-06-26 Thread Maxime Ripard
Hi, On Wed, Jun 19, 2024 at 12:07:48PM GMT, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > When a bridge driver uses devm_mipi_dsi_device_register_full() or > devm_mipi_dsi_attach(), the resource management is moved to devres, > which releases the resource automatically when the bridge driver

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-26 Thread Maxime Ripard
On Tue, Jun 18, 2024 at 02:05:50PM GMT, Neil Armstrong wrote: > On 18/06/2024 13:13, Conor Dooley wrote: > > On Tue, Jun 18, 2024 at 11:04:09AM +0200, Maxime Ripard wrote: > > > Hi Conor, > > > > > > Sorry, I missed the news of you becoming a DT maintainer, so most of my > > > previous points are

Re: [PATCH] drm/ast: Inline drm_simple_encoder_init()

2024-06-26 Thread Thomas Zimmermann
Hi Am 26.06.24 um 06:34 schrieb Dmitry Baryshkov: On Tue, Jun 25, 2024 at 03:18:09PM GMT, Thomas Zimmermann wrote: The function drm_simple_encoder_init() is a trivial helper and deprecated. Replace it with the regular call to drm_encoder_init(). Resolves the dependency on drm_simple_kms_helper.

Re: [PATCH 3/3] drm/panel: add lincoln lcd197 support

2024-06-26 Thread Jerome Brunet
On Wed 26 Jun 2024 at 07:41, Dmitry Baryshkov wrote: > On Tue, Jun 25, 2024 at 04:25:50PM GMT, Jerome Brunet wrote: >> Add support for the Lincoln LCD197 1080x1920 DSI panel. >> >> Signed-off-by: Jerome Brunet >> --- >> drivers/gpu/drm/panel/Kconfig| 11 + >> drivers/gpu/drm/

Re: [PATCH] drm/bridge: display-connector: Fix atomic_get_input_bus_fmt hook

2024-06-26 Thread Aradhya Bhatia
On 25/06/24 19:46, Neil Armstrong wrote: > On 25/06/2024 11:50, Aradhya Bhatia wrote: >> The display-connector acts as a pass-through bridge. To truly reflect >> that, this bridge should accept the same input format, as it expects to >> output. That in turn should be the same as what the precedi

Re: [PATCH] drm/ast: Inline drm_simple_encoder_init()

2024-06-26 Thread Dmitry Baryshkov
On Wed, Jun 26, 2024 at 11:01:11AM GMT, Thomas Zimmermann wrote: > Hi > > Am 26.06.24 um 06:34 schrieb Dmitry Baryshkov: > > On Tue, Jun 25, 2024 at 03:18:09PM GMT, Thomas Zimmermann wrote: > > > The function drm_simple_encoder_init() is a trivial helper and > > > deprecated. Replace it with the r

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-26 Thread Ryan Walklin
Hi Maxime, On Wed, 26 Jun 2024, at 8:56 PM, Maxime Ripard wrote: > We're getting fairly late into the release cycle and I'd like to get it > fixed before the release. Can you send a patch to address it please? Sure, happy to. So to confirm add 'anbernic' to the vendor binding list and 'anbernic

Re: [PATCH 3/3] drm/panel: add lincoln lcd197 support

2024-06-26 Thread Neil Armstrong
On 26/06/2024 11:02, Jerome Brunet wrote: On Wed 26 Jun 2024 at 07:41, Dmitry Baryshkov wrote: On Tue, Jun 25, 2024 at 04:25:50PM GMT, Jerome Brunet wrote: Add support for the Lincoln LCD197 1080x1920 DSI panel. Signed-off-by: Jerome Brunet --- drivers/gpu/drm/panel/Kconfig

Re: [PATCH v6 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC

2024-06-26 Thread Krzysztof Kozlowski
On 26/06/2024 10:30, Alexandre Mergnat wrote: > > > On 25/06/2024 15:44, Krzysztof Kozlowski wrote: >> On 25/06/2024 11:23, Alexandre Mergnat wrote: >>> >>> >>> On 21/06/2024 17:00, Krzysztof Kozlowski wrote: On 19/06/2024 16:46, Alexandre Mergnat wrote: > Add the audio codec sub-device.

Re: [PATCH v6 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC

2024-06-26 Thread Krzysztof Kozlowski
On 21/06/2024 17:00, Krzysztof Kozlowski wrote: >> + >> + audio-codec: >> +type: object > > Still not much improved. You do not have any resources there, so these > should go to the parent node. Just to clarify: comment is about audio-codec. I meant what's inside audio-codec. "Parent node" -

Re: [PATCH 3/3] drm/panel: add lincoln lcd197 support

2024-06-26 Thread Dmitry Baryshkov
On Wed, Jun 26, 2024 at 11:02:25AM GMT, Jerome Brunet wrote: > On Wed 26 Jun 2024 at 07:41, Dmitry Baryshkov > wrote: > > > On Tue, Jun 25, 2024 at 04:25:50PM GMT, Jerome Brunet wrote: > >> Add support for the Lincoln LCD197 1080x1920 DSI panel. > >> > >> Signed-off-by: Jerome Brunet > >> ---

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-26 Thread Neil Armstrong
On 26/06/2024 11:10, Ryan Walklin wrote: Hi Maxime, On Wed, 26 Jun 2024, at 8:56 PM, Maxime Ripard wrote: We're getting fairly late into the release cycle and I'd like to get it fixed before the release. Can you send a patch to address it please? Sure, happy to. So to confirm add 'anbernic'

Re: [PATCH] drm/ast: Inline drm_simple_encoder_init()

2024-06-26 Thread Thomas Zimmermann
Hi Am 26.06.24 um 11:10 schrieb Dmitry Baryshkov: On Wed, Jun 26, 2024 at 11:01:11AM GMT, Thomas Zimmermann wrote: Hi Am 26.06.24 um 06:34 schrieb Dmitry Baryshkov: On Tue, Jun 25, 2024 at 03:18:09PM GMT, Thomas Zimmermann wrote: The function drm_simple_encoder_init() is a trivial helper and

Re: [PATCH] drm/ast: Inline drm_simple_encoder_init()

2024-06-26 Thread Dmitry Baryshkov
On Wed, 26 Jun 2024 at 12:19, Thomas Zimmermann wrote: > > Hi > > Am 26.06.24 um 11:10 schrieb Dmitry Baryshkov: > > On Wed, Jun 26, 2024 at 11:01:11AM GMT, Thomas Zimmermann wrote: > >> Hi > >> > >> Am 26.06.24 um 06:34 schrieb Dmitry Baryshkov: > >>> On Tue, Jun 25, 2024 at 03:18:09PM GMT, Thoma

Re: [PATCH] drm/ast: Inline drm_simple_encoder_init()

2024-06-26 Thread Thomas Zimmermann
Hi Am 26.06.24 um 11:19 schrieb Dmitry Baryshkov: On Wed, 26 Jun 2024 at 12:19, Thomas Zimmermann wrote: Hi Am 26.06.24 um 11:10 schrieb Dmitry Baryshkov: On Wed, Jun 26, 2024 at 11:01:11AM GMT, Thomas Zimmermann wrote: Hi Am 26.06.24 um 06:34 schrieb Dmitry Baryshkov: On Tue, Jun 25, 202

Re: [PATCH v1 2/3] drm/msm/adreno: Add support for X185 GPU

2024-06-26 Thread Konrad Dybcio
On 26.06.2024 10:24 AM, Akhil P Oommen wrote: > On Mon, Jun 24, 2024 at 03:53:48PM +0200, Konrad Dybcio wrote: >> >> >> On 6/23/24 13:06, Akhil P Oommen wrote: >>> Add support in drm/msm driver for the Adreno X185 gpu found in >>> Snapdragon X1 Elite chipset. >>> >>> Signed-off-by: Akhil P Oommen

Re: [PATCH] drm/msm/adreno: fix a7xx gpu init

2024-06-26 Thread Konrad Dybcio
On 26.06.2024 9:53 AM, Neil Armstrong wrote: > The gpulist has twice the a6xx gpulist, replace the second one > with the a7xx gpulist. > > Solves: > msm_dpu ae01000.display-controller: Unknown GPU revision: 7.3.0.1 > msm_dpu ae01000.display-controller: Unknown GPU revision: 67.5.10.1 > msm_dpu ae0

Re: [PATCH 7/7] arm64: dts: qcom: add OnePlus 8T (kebab)

2024-06-26 Thread Konrad Dybcio
On 24.06.2024 3:30 AM, Caleb Connolly wrote: > Initial support for USB, UFS, touchscreen, panel, wifi, and bluetooth. > > Co-developed-by: Frieder Hannenheim > Signed-off-by: Frieder Hannenheim > Signed-off-by: Caleb Connolly > --- [...] > +&adsp { > + status = "okay"; > + firmware-na

Re: [PATCH] drm/nouveau: fix null pointer dereference in nouveau_connector_get_modes

2024-06-26 Thread Jani Nikula
On Wed, 26 Jun 2024, Ma Ke wrote: > In nouveau_connector_get_modes(), the return value of drm_mode_duplicate() > is assigned to mode, which will lead to a possible NULL pointer > dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. > > Signed-off-by: Ma Ke > --- > drivers/gp

Re: [PATCH] drm/gma500: fix null pointer dereference in psb_intel_lvds_get_modes

2024-06-26 Thread Jani Nikula
On Wed, 26 Jun 2024, Ma Ke wrote: > In psb_intel_lvds_get_modes(), the return value of drm_mode_duplicate() is > assigned to mode, which will lead to a possible NULL pointer dereference > on failure of drm_mode_duplicate(). Add a check to avoid npd. > > Signed-off-by: Ma Ke > --- > drivers/gpu/d

Re: [PATCH] drm/mipi-dsi: Fix devm unregister & detach

2024-06-26 Thread Tomi Valkeinen
On 26/06/2024 11:49, Maxime Ripard wrote: Hi, On Wed, Jun 19, 2024 at 12:07:48PM GMT, Tomi Valkeinen wrote: From: Tomi Valkeinen When a bridge driver uses devm_mipi_dsi_device_register_full() or devm_mipi_dsi_attach(), the resource management is moved to devres, which releases the resource au

Re: [PATCH v4 01/11] drm/bridge: cdns-dsi: Fix OF node pointer

2024-06-26 Thread Tomi Valkeinen
Hi, On 22/06/2024 14:09, Aradhya Bhatia wrote: Fix the OF node pointer passed to the of_drm_find_bridge() call to find the next bridge in the display chain. To find the next bridge in the pipeline, we need to pass "np" - the OF node pointer of the next entity in the devicetree chain. Passing "o

Re: [PATCH v4 02/11] drm/bridge: cdns-dsi: Move to devm_drm_of_get_bridge()

2024-06-26 Thread Tomi Valkeinen
On 22/06/2024 14:09, Aradhya Bhatia wrote: Instead of manually finding the next bridge/panel, and maintaining the panel-bridge (in-case the next entity is a panel), switch to using the automatically managing devm_drm_of_get_bridge() API. Drop the drm_panel support completely from the driver whil

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-26 Thread Omer Shpigelman
On 6/23/24 17:46, Andrew Lunn wrote: >>> But what about when the system is under memory pressure? You say it >>> allocates memory. What happens if those allocations fail. Does >>> changing the MTU take me from a working system to a dead system? It is >>> good practice to not kill a working system u

Re: [PATCH] drm/gma500: fix null pointer dereference in psb_intel_lvds_get_modes

2024-06-26 Thread Markus Elfring
> In psb_intel_lvds_get_modes(), the return value of drm_mode_duplicate() is > assigned to mode, which will lead to a possible NULL pointer dereference > on failure of drm_mode_duplicate(). Add a check to avoid npd. 1. Can a wording approach (like the following) be a better change description?

Re: [PATCH v4 03/11] drm/bridge: cdns-dsi: Fix Phy _init() and _exit()

2024-06-26 Thread Tomi Valkeinen
Hi, On 22/06/2024 14:09, Aradhya Bhatia wrote: Initialize the Phy during the cdns-dsi _resume(), and de-initialize it during the _suspend(). Also power-off the Phy from bridge_disable. Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework") Signed-off-by: Aradhya Bhatia --- drive

Re: [PATCH v4 04/11] drm/bridge: cdns-dsi: Fix the link and phy init order

2024-06-26 Thread Tomi Valkeinen
On 22/06/2024 14:09, Aradhya Bhatia wrote: The order of init of DSI link and DSI phy is wrong. The DSI link needs to be configured before the DSI phy is getting configured. Otherwise, the D-Phy is unable to lock in on the incoming PLL Reference clock[0]. Fix the order of inits. [0]: See section

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-26 Thread Daniel Stone
Hi, On Wed, 26 Jun 2024 at 09:28, Lucas Stach wrote: > Mesa doesn't cope right now. Mostly because of the renderonly thing > where we magically need to match render devices to otherwise render > incapable KMS devices. The way this matching works is that the > renderonly code tries to open a scree

Re: [PATCH v4 05/11] drm/bridge: cdns-dsi: Fix the clock variable for mode_valid()

2024-06-26 Thread Tomi Valkeinen
On 22/06/2024 14:09, Aradhya Bhatia wrote: Allow the D-Phy config checks to use mode->clock instead of mode->crtc_clock during mode_valid checks, like everywhere else in the driver. Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework") Signed-off-by: Aradhya Bhatia --- drivers/gp

Re: [PATCH v5 2/9] scatterlist: Add a flag for the restricted memory

2024-06-26 Thread Christian König
Am 26.06.24 um 10:05 schrieb Jason-JH Lin (林睿祥): > > > In the step 3), we need to verify the dma-buf is allocated from > > "restricted_mtk_cma", but there is no way to pass the secure flag > > or > > private data from userspace to the import interface in DRM driver. > > Why do you need to v

Re: [PATCH v4 06/11] drm/bridge: cdns-dsi: Wait for Clk and Data Lanes to be ready

2024-06-26 Thread Tomi Valkeinen
On 22/06/2024 14:09, Aradhya Bhatia wrote: Once the DSI Link and DSI Phy are initialized, the code needs to wait for Clk and Data Lanes to be ready, before continuing configuration. This is in accordance with the DSI Start-up procedure, found in the Technical Reference Manual of Texas Instrument'

Re: [PATCH v5 1/5] drm/panel: jd9365da: Modify the method of sending commands

2024-06-26 Thread zhaoxiong lv
On Wed, Jun 26, 2024 at 1:49 AM Jessica Zhang wrote: > > > > On 6/25/2024 5:13 AM, zhaoxiong lv wrote: > > On Tue, Jun 25, 2024 at 7:41 AM Jessica Zhang > > wrote: > >> > >> > >> > >> On 6/24/2024 7:19 AM, Zhaoxiong Lv wrote: > >>> Currently, the init_code of the jd9365da driver is placed > >>>

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-26 Thread Ryan Walklin
On Wed, 26 Jun 2024, at 9:16 PM, Neil Armstrong wrote: > Well anbernic is not the wl-355608-a8 panel manufaturer, so as Maxime > is suggesting to use the > name of the device where the panel is found like > anbernic,rg353v-panel-v2 as submitted > in > https://lore.kernel.org/all/20230426143213.4

Re: [PATCH v4 07/11] drm/bridge: cdns-dsi: Reset the DCS write FIFO

2024-06-26 Thread Tomi Valkeinen
On 22/06/2024 14:09, Aradhya Bhatia wrote: If any normal DCS write command has already been transmitted prior to transmitting any Zero-Parameter DCS command, then it is necessary to clear the TX FIFO by resetting it. Otherwise, the FIFO points to another location, and the DCS command transmits un

Re: [PATCH v4 08/11] drm/mipi-dsi: Add helper to find input format

2024-06-26 Thread Tomi Valkeinen
On 22/06/2024 14:09, Aradhya Bhatia wrote: Add a helper API that can be used by the DSI hosts to find the required input bus format for the given output dsi pixel format. Reviewed-by: Dmitry Baryshkov Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/drm_mipi_dsi.c | 37 +

Re: [PATCH v4 09/11] drm/bridge: cdns-dsi: Support atomic bridge APIs

2024-06-26 Thread Tomi Valkeinen
On 22/06/2024 14:09, Aradhya Bhatia wrote: Change the existing (and deprecated) bridge hooks, to the bridge atomic APIs. Add drm helpers for duplicate_state, destroy_state, and bridge_reset bridge hooks. Further add support for the input format negotiation hook. Reviewed-by: Dmitry Baryshkov

Re: [PATCH net-next v14 11/13] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags

2024-06-26 Thread Nikolay Aleksandrov
On 25/06/2024 22:53, Mina Almasry wrote: Add an interface for the user to notify the kernel that it is done reading the devmem dmabuf frags returned as cmsg. The kernel will drop the reference on the frags to make them available for reuse. Signed-off-by: Willem de Bruijn Signed-off-by: Kaiyuan

[PATCH 0/3] Correct WL-355608-A8 panel compatible

2024-06-26 Thread Ryan Walklin
The previous patch adding support for this panel [1] referred to previously by its serial number only. As discussed after the patch was committed, the preference is to use the integrating device vendor and name in this circumstance. This series corrects the panel compatible to reflect the vendo

[PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel

2024-06-26 Thread Ryan Walklin
The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown OEM used in a number of handheld gaming devices made by Anbernic. Previously committed using the OEM serial without a vendor prefix, however the preference is to use the integrating device vendor and name where the OEM is unkno

[PATCH 2/3] drm: panel: nv3052c: Correct WL-355608-A8 panel compatible

2024-06-26 Thread Ryan Walklin
As per the previous dt-binding commit, update the WL-355608-A8 panel compatible to reflect the the integrating device vendor and name. Signed-off-by: Ryan Walklin --- drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/d

[PATCH 3/3] dt-bindings: display: panel: correct Anbernic RG35XX panel example

2024-06-26 Thread Ryan Walklin
make dt_bindings_check reports that sck-gpios and num-chipselects are required for spi nodes, therefore add these to the example. Signed-off-by: Ryan Walklin --- .../bindings/display/panel/anbernic,rg35xx-panel.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/d

Re: [PATCH v4 10/11] drm/atomic-helper: Re-order bridge chain pre-enable and post-disable

2024-06-26 Thread Tomi Valkeinen
On 22/06/2024 14:09, Aradhya Bhatia wrote: Move the bridge pre_enable call before crtc enable, and the bridge post_disable call after the crtc disable. The sequence of enable after this patch will look like: bridge[n]_pre_enable ... bridge[1]_pre_enable crtc_ena

Re: [PATCH] drm/nouveau: fix null pointer dereference in nouveau_connector_get_modes

2024-06-26 Thread Markus Elfring
> In nouveau_connector_get_modes(), the return value of drm_mode_duplicate() > is assigned to mode, which will lead to a possible NULL pointer > dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. 1. Can a wording approach (like the following) be a better change description?

Re: [PATCH v4 11/11] drm/bridge: cdns-dsi: Use pre_enable/post_disable to enable/disable

2024-06-26 Thread Tomi Valkeinen
On 22/06/2024 14:09, Aradhya Bhatia wrote: The cdns-dsi controller requires that it be turned on completely before the input DPI's source has begun streaming[0]. Not having that, allows for a small window before cdns-dsi enable and after cdns-dsi disable where the previous entity (in this case ti

Re: [PATCH v2 06/17] backlight: ipaq-micro-backlight: Use backlight power constants

2024-06-26 Thread Linus Walleij
On Mon, Jun 24, 2024 at 5:20 PM Thomas Zimmermann wrote: > Replace FB_BLANK_ constants with their counterparts from the > backlight subsystem. The values are identical, so there's no > change in functionality. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Linus Walleij Yours, Linus Wallei

Re: [PATCH v2 05/17] backlight: gpio-backlight: Use backlight power constants

2024-06-26 Thread Linus Walleij
On Mon, Jun 24, 2024 at 5:20 PM Thomas Zimmermann wrote: > Replace FB_BLANK_ constants with their counterparts from the > backlight subsystem. The values are identical, so there's no > change in functionality. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Linus Walleij Yours, Linus Wallei

Re: [PATCH] drm/radeon: fix null pointer dereference in radeon_add_common_modes

2024-06-26 Thread Markus Elfring
> In radeon_add_common_modes(), the return value of drm_cvt_mode() is > assigned to mode, which will lead to a possible NULL pointer dereference > on failure of drm_cvt_mode(). Add a check to avoid npd. 1. Can a wording approach (like the following) be a better change description? A null point

[PATCH] drm/msm/adreno: fix a743 and a740 cx mem init

2024-06-26 Thread Neil Armstrong
g = true; } return 0; --- base-commit: 62c97045b8f720c2eac807a5f38e26c9ed512371 change-id: 20240626-topic-sm8x50-upstream-fix-a730-a730-gpu-raytracing-init-46ac3f4cdd29 Best regards, -- Neil Armstrong

Re: [PATCH] drm/msm/adreno: fix a743 and a740 cx mem init

2024-06-26 Thread Connor Abbott
On Wed, Jun 26, 2024 at 1:04 PM Neil Armstrong wrote: > > Disable the call to qcom_scm_gpu_init_regs() for a730 and a740 > after init failures on the HDK8550 and HDK8450 platforms: > msm_dpu ae01000.display-controller: failed to load adreno gpu > msm_dpu ae01000.display-controller: failed to bind

Re: [PATCH] drm/qxl: fix null pointer dereference in qxl_add_mode

2024-06-26 Thread Markus Elfring
> In qxl_add_mode(), the return value of drm_cvt_mode() is assigned to mode, > which will lead to a possible NULL pointer dereference on failure of > drm_cvt_mode(). Add a check to avoid npd. 1. Can a wording approach (like the following) be a better change description? A null pointer is store

Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel

2024-06-26 Thread Neil Armstrong
On 26/06/2024 13:17, Ryan Walklin wrote: The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown OEM used in a number of handheld gaming devices made by Anbernic. Previously committed using the OEM serial without a vendor prefix, however the preference is to use the integrating de

Re: [PATCH] drm/panel: sitronix-st7703: transition to mipi_dsi wrapped functions

2024-06-26 Thread Guido Günther
Hi, On Wed, Jun 26, 2024 at 10:22:41AM +0530, Tejas Vipin wrote: > Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: > Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe > ("drm/mipi-dsi: wrap more functions for streamline handling") for > sitronix-st7703 based panels.

Re: [PATCH] drm/panel: sitronix-st7703: transition to mipi_dsi wrapped functions

2024-06-26 Thread Ondřej Jirman
Hi Guido, On Wed, Jun 26, 2024 at 02:25:16PM GMT, Guido Günther wrote: > [...] > > - ret = ctx->desc->init_sequence(ctx); > > - if (ret < 0) { > > - dev_err(ctx->dev, "Panel init sequence failed: %d\n", ret); > > - return ret; > > - } > > + ctx->desc->init_sequence(&dsi

Re: [PATCH] drm/panel: sitronix-st7703: transition to mipi_dsi wrapped functions

2024-06-26 Thread Tejas Vipin
Hi, On 6/26/24 5:55 PM, Guido Günther wrote: > Hi, > On Wed, Jun 26, 2024 at 10:22:41AM +0530, Tejas Vipin wrote: >> Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: >> Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe >> ("drm/mipi-dsi: wrap more functions for stream

Re: [PATCH] drm/mediatek: Fix bit depth overwritten for mtk_ovl_set bit_depth()

2024-06-26 Thread Chun-Kuang Hu
Hi, Jason: Jason-JH.Lin 於 2024年6月24日 週一 下午5:57寫道: > > Refine the value and mask define of bit depth for mtk_ovl_set bit_depth(). > Use cmdq_pkt_write_mask() instead of cmdq_pkt_write() to avoid bit depth > settings being overwritten. Applied to mediatek-drm-next [1], thanks. [1] https://git.ke

Re: [PATCH] drm/panel: sitronix-st7703: transition to mipi_dsi wrapped functions

2024-06-26 Thread Guido Günther
Hi, On Wed, Jun 26, 2024 at 06:23:51PM +0530, Tejas Vipin wrote: > Hi, > > On 6/26/24 5:55 PM, Guido Günther wrote: > > Hi, > > On Wed, Jun 26, 2024 at 10:22:41AM +0530, Tejas Vipin wrote: > >> Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: > >> Introduce mipi_dsi_*_write_seq_mult

Re: [PATCH v4 10/11] drm/atomic-helper: Re-order bridge chain pre-enable and post-disable

2024-06-26 Thread Maxime Ripard
On Wed, Jun 26, 2024 at 02:28:57PM GMT, Tomi Valkeinen wrote: > On 22/06/2024 14:09, Aradhya Bhatia wrote: > > Move the bridge pre_enable call before crtc enable, and the bridge > > post_disable call after the crtc disable. > > > > The sequence of enable after this patch will look like: > > > >

Re: [PATCH v4 03/11] drm/bridge: cdns-dsi: Fix Phy _init() and _exit()

2024-06-26 Thread Aradhya Bhatia
Hi Tomi, Thanks for reviewing the patches! On 26/06/24 15:55, Tomi Valkeinen wrote: > Hi, > > On 22/06/2024 14:09, Aradhya Bhatia wrote: >> Initialize the Phy during the cdns-dsi _resume(), and de-initialize it >> during the _suspend(). >> >> Also power-off the Phy from bridge_disable. >> >> Fix

  1   2   3   >