Re: Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT

2024-02-09 Thread Jani Nikula
On Thu, 08 Feb 2024, Lucas De Marchi wrote: > On Thu, Feb 08, 2024 at 09:04:45PM +0100, Andi Shyti wrote: >>Hi Lucas, >> >>looks good, just one idea... >> >>... >> >>> +#define BIT_U8(b) ((u8)(BIT_INPUT_CHECK(u8, b) + BIT(b))) >>> +#define BIT_U16(b) ((u16)(BIT_INPUT_CHECK(u16, b)

Re: [PATCH i-g-t] benchmarks: Add VKMS benchmark

2024-02-09 Thread Pekka Paalanen
On Thu, 8 Feb 2024 16:38:31 -0300 Arthur Grillo wrote: > On 08/02/24 06:50, Pekka Paalanen wrote: > > On Wed, 07 Feb 2024 17:17:15 -0300 > > Arthur Grillo wrote: > > > >> Create a benchmark for the VKMS driver. Use a KMS layout with deliberate > >> odd sizes to try to avoid alignment accident

Re: [PATCH i-g-t v2] benchmarks: Add VKMS benchmark

2024-02-09 Thread Pekka Paalanen
On Thu, 08 Feb 2024 17:04:52 -0300 Arthur Grillo wrote: > Create a benchmark for the VKMS driver. Use a KMS layout with deliberate > odd sizes to try to avoid alignment accidents and run it for FRAME_COUNT > frames flipping framebuffers in each plane. > > This benchmark was suggested by Pekka Pa

Re: [PATCH i-g-t v2] benchmarks: Add VKMS benchmark

2024-02-09 Thread Kamil Konieczny
Hi Arthur, On 2024-02-08 at 17:04:52 -0300, Arthur Grillo wrote: > Create a benchmark for the VKMS driver. Use a KMS layout with deliberate > odd sizes to try to avoid alignment accidents and run it for FRAME_COUNT > frames flipping framebuffers in each plane. > > This benchmark was suggested by P

Re: [PATCH v2] drm/i915: Add GuC submission interface version query

2024-02-09 Thread Tvrtko Ursulin
On 08/02/2024 17:55, Souza, Jose wrote: On Thu, 2024-02-08 at 07:19 -0800, José Roberto de Souza wrote: On Thu, 2024-02-08 at 14:59 +, Tvrtko Ursulin wrote: On 08/02/2024 14:30, Souza, Jose wrote: On Thu, 2024-02-08 at 08:25 +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add a new

Re: [PATCH v3 00/39] drm/bridge: switch to struct drm_edid

2024-02-09 Thread Jani Nikula
On Thu, 25 Jan 2024, Neil Armstrong wrote: > Thanks, but now some patches subjects are wrong: > s/drm_bridge_read_edid/drm_bridge_edid_read/s Fixed while applying. > With that fixed please add: > Reviewed-by: Neil Armstrong Many thanks, pushed the lot to drm-misc-next. BR, Jani. -- Jani Ni

Re: [PATCH RESEND 1/1] drm/panel: st7703: Fix Panel Initialization for Anbernic RG353V-V2

2024-02-09 Thread Guido Günther
Hi Ao, this doesn't say why that was changed but your cover letter has that information: > After correcting these parameters by referencing the > device tree in JELOS (which uses the BSP kernel for RK3566), the panel > started to work properly. Can you add that to the commit message and maybe ad

Re: [PATCH v2 2/2] fbcon: Defer console takeover for splash screens to first switch

2024-02-09 Thread Daniel Vetter
On Thu, Feb 08, 2024 at 09:16:50AM +0800, Daniel van Vugt wrote: > On 8/2/24 04:21, Mario Limonciello wrote: > > On 2/7/2024 03:51, Daniel Vetter wrote: > >> On Wed, Feb 07, 2024 at 10:03:10AM +0800, Daniel van Vugt wrote: > >>> On 6/2/24 23:41, Mario Limonciello wrote: > On 2/6/2024 08:21, Da

Re: [PATCH 3/3] drm/amdgpu: wire up the can_remove() callback

2024-02-09 Thread Daniel Vetter
On Tue, Feb 06, 2024 at 07:42:49PM +0100, Christian König wrote: > Am 06.02.24 um 15:29 schrieb Daniel Vetter: > > On Fri, Feb 02, 2024 at 03:40:03PM -0800, Greg Kroah-Hartman wrote: > > > On Fri, Feb 02, 2024 at 05:25:56PM -0500, Hamza Mahfooz wrote: > > > > Removing an amdgpu device that still ha

Re: Re: [etnaviv-next v13 7/7] drm/etnaviv: Add support for vivante GPU cores attached via PCI(e)

2024-02-09 Thread Daniel Vetter
On Thu, Feb 08, 2024 at 04:27:02PM +0100, Maxime Ripard wrote: > On Wed, Feb 07, 2024 at 10:35:49AM +0100, Daniel Vetter wrote: > > On Wed, Feb 07, 2024 at 01:27:59AM +0800, Sui Jingfeng wrote: > > > The component helper functions are the glue, which is used to bind > > > multiple > > > GPU cores

Re: [PATCH v4 1/3] drm: Add drm_get_acpi_edid() helper

2024-02-09 Thread Daniel Vetter
On Thu, Feb 08, 2024 at 11:57:11AM +0200, Jani Nikula wrote: > On Wed, 07 Feb 2024, Mario Limonciello wrote: > > Some manufacturers have intentionally put an EDID that differs from > > the EDID on the internal panel on laptops. Drivers can call this > > helper to attempt to fetch the EDID from th

Re: Re: [PATCH 00/10] drm: drm debug and error logging improvements

2024-02-09 Thread Jani Nikula
On Thu, 01 Feb 2024, Maxime Ripard wrote: > On Thu, Feb 01, 2024 at 02:51:13PM +0200, Jani Nikula wrote: >> On Tue, 16 Jan 2024, Jani Nikula wrote: >> > This is resend and more patches on top of [1]. I don't think I've >> > changed anything since then. >> >> Hi drm-misc maintainers - >> >> I've

Re: Re: [PATCH 09/10] drm/xe: switch from drm_debug_printer() to device specific drm_dbg_printer()

2024-02-09 Thread Jani Nikula
On Thu, 01 Feb 2024, Lucas De Marchi wrote: > Do you plan to also merge the last patch where you remove > drm_debug_printer()? Any conflict to be solved in the merge commit? > > This is just a question to know what's the plan, not preferring > something else. I looked into it, didn't see any con

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-09 Thread Arunpravin Paneer Selvam
On 2/8/2024 7:47 PM, Matthew Auld wrote: On 08/02/2024 13:47, Arunpravin Paneer Selvam wrote: Hi Matthew, On 2/8/2024 7:00 PM, Matthew Auld wrote: On 07/02/2024 17:44, Arunpravin Paneer Selvam wrote: Few users have observed display corruption when they boot the machine to KDE Plasma or pla

[PATCH] drm/amd/display: Fix && vs || typos

2024-02-09 Thread Dan Carpenter
These ANDs should be ORs or it will lead to a NULL dereference. Fixes: fb5a3d037082 ("drm/amd/display: Add NULL test for 'timing generator' in 'dcn21_set_pipe()'") Fixes: 886571d217d7 ("drm/amd/display: Fix 'panel_cntl' could be null in 'dcn21_set_backlight_level()'") Signed-off-by: Dan Carpente

Re: [PATCH v3 1/3] bits: introduce fixed-type genmasks

2024-02-09 Thread Andy Shevchenko
On Thu, Feb 08, 2024 at 08:48:59PM +0100, Andi Shyti wrote: > On Wed, Feb 07, 2024 at 11:45:19PM -0800, Lucas De Marchi wrote: ... > > Signed-off-by: Yury Norov > > Signed-off-by: Lucas De Marchi > > Acked-by: Jani Nikula > > Lucas' SoB should be at the bottom here. In any case, nice patch:

[PATCH] drm/tests: mm: Convert to drm_dbg_printer

2024-02-09 Thread Michał Winiarski
Fix one of the tests in drm_mm that was not converted prior to drm_debug_printer removal, causing tests build failure. Fixes: e154c4fc7bf2d ("drm: remove drm_debug_printer in favor of drm_dbg_printer") Signed-off-by: Michał Winiarski --- drivers/gpu/drm/tests/drm_mm_test.c | 2 +- 1 file change

RE: [PATCH] drm/amd/display: Fix && vs || typos

2024-02-09 Thread Koo, Anthony
[AMD Official Use Only - General] Reviewed-by: Anthony Koo Looks good, my mistake for not noticing this! Thanks, Anthony -Original Message- From: Dan Carpenter Sent: Friday, February 9, 2024 8:03 AM To: SHANMUGAM, SRINIVASAN Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodri

Re: [PATCH v3 1/4] dt-bindings: display: bridge: add sam9x75-lvds compatible

2024-02-09 Thread Dharma.B
On 08/02/24 2:31 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 07/02/2024 11:27, Dharma Balasubiramani wrote: >> Add the 'sam9x75-lvds' compatible binding, which describes the Low Voltage >> Differential Signal

Re: [PATCH v3 1/4] dt-bindings: display: bridge: add sam9x75-lvds compatible

2024-02-09 Thread Dharma.B
Hi Conor, On 07/02/24 9:22 pm, Conor Dooley wrote: > $subject: dt-bindings: display: bridge: add sam9x75-lvds compatible > > If there's a respin for some reason, please update the subject to match > what the commit is actually doing (adding a whole binding). Absolutely, I'll make the adjustment

Re: [PATCH] drm/tests: mm: Convert to drm_dbg_printer

2024-02-09 Thread Michal Wajdeczko
On 09.02.2024 15:08, Michał Winiarski wrote: > Fix one of the tests in drm_mm that was not converted prior to > drm_debug_printer removal, causing tests build failure. > > Fixes: e154c4fc7bf2d ("drm: remove drm_debug_printer in favor of > drm_dbg_printer") > Signed-off-by: Michał Winiarski R

Re: [PATCH] drm/tests: mm: Convert to drm_dbg_printer

2024-02-09 Thread Intel
On 2/9/24 15:08, Michał Winiarski wrote: Fix one of the tests in drm_mm that was not converted prior to drm_debug_printer removal, causing tests build failure. Fixes: e154c4fc7bf2d ("drm: remove drm_debug_printer in favor of drm_dbg_printer") Signed-off-by: Michał Winiarski --- drivers/gpu

Re: [PATCH v2 0/3] backlight: mp3309c: Allow to use on non-OF platforms

2024-02-09 Thread Andy Shevchenko
On Fri, Feb 09, 2024 at 07:50:52AM +, Lee Jones wrote: > On Thu, 08 Feb 2024, Andy Shevchenko wrote: > > On Thu, Feb 08, 2024 at 06:14:55PM +, Lee Jones wrote: > > > On Thu, 08 Feb 2024, Andy Shevchenko wrote: > > > > On Thu, Feb 08, 2024 at 05:39:46PM +, Lee Jones wrote: > > > > > On T

Re: [PATCH v3 1/4] dt-bindings: display: bridge: add sam9x75-lvds compatible

2024-02-09 Thread Dharma.B
On 09/02/24 7:50 pm, Dharma B wrote: > On 08/02/24 2:31 pm, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know >> the content is safe >> >> On 07/02/2024 11:27, Dharma Balasubiramani wrote: >>> Add the 'sam9x75-lvds' compatible binding, which descr

Re: [PATCH] drm/tests: mm: Convert to drm_dbg_printer

2024-02-09 Thread Jani Nikula
On Fri, 09 Feb 2024, Michał Winiarski wrote: > Fix one of the tests in drm_mm that was not converted prior to > drm_debug_printer removal, causing tests build failure. My bad, thanks for fixing this. Reviewed-by: Jani Nikula For one thing, I must not have git grep'd for new drm_debug_printer()

Re: [PATCH v16 3/5] drm: renesas: Add RZ/G2L DU Support

2024-02-09 Thread Maxime Ripard
On Mon, Jan 22, 2024 at 04:42:55PM +, Biju Das wrote: > +static const struct drm_gem_object_funcs rzg2l_du_gem_funcs = { > + .free = drm_gem_dma_object_free, > + .print_info = drm_gem_dma_object_print_info, > + .get_sg_table = drm_gem_dma_object_get_sg_table, > + .vmap = drm_gem

[PATCH v4 0/4] LVDS Controller Support for SAM9X75 SoC

2024-02-09 Thread Dharma Balasubiramani
This patch series introduces LVDS controller support for the SAM9X75 SoC. The LVDS controller is designed to work with Microchip's sam9x7 series System-on-Chip (SoC) devices, providing Low Voltage Differential Signaling capabilities. Patch series Changelog: - Include configs: at91: Enable LVDS ser

[PATCH v4 2/4] drm/bridge: add lvds controller support for sam9x7

2024-02-09 Thread Dharma Balasubiramani
Add a new LVDS controller driver for sam9x7 which does the following: - Prepares and enables the LVDS Peripheral clock - Defines its connector type as DRM_MODE_CONNECTOR_LVDS and adds itself to the global bridge list. - Identifies its output endpoint as panel and adds it to the encoder display pipe

[PATCH v4 1/4] dt-bindings: display: bridge: add sam9x75-lvds binding

2024-02-09 Thread Dharma Balasubiramani
Add the 'sam9x75-lvds' compatible binding, which describes the Low Voltage Differential Signaling (LVDS) Controller found on some Microchip's sam9x7 series System-on-Chip (SoC) devices. This binding will be used to define the properties and configuration for the LVDS Controller in DT. Signed-off-b

[PATCH v4 3/4] MAINTAINERS: add SAM9X7 SoC's LVDS controller

2024-02-09 Thread Dharma Balasubiramani
Add the newly added LVDS controller for the SAM9X7 SoC to the existing MAINTAINERS entry. Signed-off-by: Dharma Balasubiramani Reviewed-by: Neil Armstrong Acked-by: Nicolas Ferre --- Changelog v3 ->v4 - No changes. v2 -> v3 - Move the entry before "MICROCHIP SAMA5D2-COMPATIBLE ADC DRIVER". v1 -

[PATCH v4 4/4] ARM: configs: at91: Enable LVDS serializer support

2024-02-09 Thread Dharma Balasubiramani
Enable LVDS serializer support for display pipeline. Signed-off-by: Dharma Balasubiramani Acked-by: Hari Prasath Gujulan Elango Acked-by: Nicolas Ferre --- Changelog v3 -> v4 - No Changes. v2 -> v3 - No Changes. --- arch/arm/configs/at91_dt_defconfig | 1 + 1 file changed, 1 insertion(+) diff

Re: Re: Re: [etnaviv-next v13 7/7] drm/etnaviv: Add support for vivante GPU cores attached via PCI(e)

2024-02-09 Thread Maxime Ripard
On Fri, Feb 09, 2024 at 12:02:48PM +0100, Daniel Vetter wrote: > On Thu, Feb 08, 2024 at 04:27:02PM +0100, Maxime Ripard wrote: > > On Wed, Feb 07, 2024 at 10:35:49AM +0100, Daniel Vetter wrote: > > > On Wed, Feb 07, 2024 at 01:27:59AM +0800, Sui Jingfeng wrote: > > > > The component helper functio

[PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-09 Thread Arunpravin Paneer Selvam
Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the problem that whenever alloc_range() couldn't find the required memory blocks the function was returning SUCCESS in some of the corner cases. The right approach would be if

RE: [PATCH 1/1] fbdev/hyperv_fb: Fix logic error for Gen2 VMs in hvfb_getmem()

2024-02-09 Thread Michael Kelley
From: Thomas Zimmermann Sent: Thursday, February 1, 2024 12:17 AM > > Hi > > Am 01.02.24 um 07:00 schrieb mhkelle...@gmail.com: > > From: Michael Kelley > > > > A recent commit removing the use of screen_info introduced a logic > > error. The error causes hvfb_getmem() to always return -ENOMEM

[PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-09 Thread Arunpravin Paneer Selvam
Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the problem that whenever alloc_range() couldn't find the required memory blocks the function was returning SUCCESS in some of the corner cases. The right approach would be if

Re: [PATCH v4 1/3] drm: Add drm_get_acpi_edid() helper

2024-02-09 Thread Mario Limonciello
On 2/9/2024 05:07, Daniel Vetter wrote: On Thu, Feb 08, 2024 at 11:57:11AM +0200, Jani Nikula wrote: On Wed, 07 Feb 2024, Mario Limonciello wrote: Some manufacturers have intentionally put an EDID that differs from the EDID on the internal panel on laptops. Drivers can call this helper to att

dri-devel@lists.freedesktop.org

2024-02-09 Thread Maxime Ripard
On Thu, Feb 01, 2024 at 02:22:16AM +, Keith Zhao wrote: > > > > > > -Original Message- > > > From: Maxime Ripard > > > Sent: 2024年1月31日 21:24 > > > To: Keith Zhao > > > Cc: devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org; > > > linux-ker...@vger.kernel.org; linux-

Re: [PATCH v2] accel/ivpu: Fix DevTLB errors on suspend/resume and recovery

2024-02-09 Thread Jeffrey Hugo
On 2/7/2024 3:24 AM, Jacek Lawrynowicz wrote: Issue IP reset before shutdown in order to complete all upstream requests to the SOC. Without this DevTLB is complaining about incomplete transactions and NPU cannot resume from suspend. This problem is only happening on recent IFWI releases. IP rese

Re: Re: RE: Re: [PATCH 0/4] Fixing live video input in ZynqMP DPSUB

2024-02-09 Thread Maxime Ripard
On Sun, Feb 04, 2024 at 11:56:18AM +0200, Laurent Pinchart wrote: > On Thu, Feb 01, 2024 at 06:01:01PM +0100, Maxime Ripard wrote: > > On Fri, Jan 26, 2024 at 11:18:30PM +, Klymenko, Anatoliy wrote: > > > On Friday, January 26, 2024 4:26 AM, Maxime Ripard wrote: > > > > On Wed, Jan 17, 2024 at

Re: [PATCH 1/1] fbdev/hyperv_fb: Fix logic error for Gen2 VMs in hvfb_getmem()

2024-02-09 Thread Helge Deller
On 2/9/24 16:23, Michael Kelley wrote: From: Thomas Zimmermann Sent: Thursday, February 1, 2024 12:17 AM Hi Am 01.02.24 um 07:00 schrieb mhkelle...@gmail.com: From: Michael Kelley A recent commit removing the use of screen_info introduced a logic error. The error causes hvfb_getmem() to a

Re: [PATCH v4 05/14] drm/panthor: Add GEM logical block

2024-02-09 Thread Steven Price
On 22/01/2024 16:30, Boris Brezillon wrote: > Anything relating to GEM object management is placed here. Nothing > particularly interesting here, given the implementation is based on > drm_gem_shmem_object, which is doing most of the work. > > v4: > - Force kernel BOs to be GPU mapped > - Make pan

Re: [PATCH v3 1/4] dt-bindings: display: bridge: add sam9x75-lvds compatible

2024-02-09 Thread Krzysztof Kozlowski
On 09/02/2024 16:02, dharm...@microchip.com wrote: > On 09/02/24 7:50 pm, Dharma B wrote: >> On 08/02/24 2:31 pm, Krzysztof Kozlowski wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know >>> the content is safe >>> >>> On 07/02/2024 11:27, Dharma Balasubiramani wrote:

[PATCH][next] drm/i915/gvt: remove redundant assignment to pointer map

2024-02-09 Thread Colin Ian King
The pointer map is being initialized with a value that is never read, it is being re-assigned later on in a for-loop. The initialization is redundant and can be removed. Cleans up clang scan build warning: drivers/gpu/drm/i915/gvt/interrupt.c:346:28: warning: Value stored to 'map' during its initi

Re: [PATCH v3 1/4] dt-bindings: display: bridge: add sam9x75-lvds compatible

2024-02-09 Thread Krzysztof Kozlowski
On 09/02/2024 17:05, Krzysztof Kozlowski wrote: > On 09/02/2024 16:02, dharm...@microchip.com wrote: >> On 09/02/24 7:50 pm, Dharma B wrote: >>> On 08/02/24 2:31 pm, Krzysztof Kozlowski wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Re: [etnaviv-next v13 7/7] drm/etnaviv: Add support for vivante GPU cores attached via PCI(e)

2024-02-09 Thread Sui Jingfeng
Hi, On 2024/2/9 23:15, Maxime Ripard wrote: On Fri, Feb 09, 2024 at 12:02:48PM +0100, Daniel Vetter wrote: On Thu, Feb 08, 2024 at 04:27:02PM +0100, Maxime Ripard wrote: On Wed, Feb 07, 2024 at 10:35:49AM +0100, Daniel Vetter wrote: On Wed, Feb 07, 2024 at 01:27:59AM +0800, Sui Jingfeng wrote

[PULL] drm-misc-next

2024-02-09 Thread Thomas Zimmermann
Hi Dave and Sima, here's the PR for drm-misc-next for this week. There's nothing that stands out: plenty of fixes, the usual round of newly supported panel and bridge devices, and some changes to the internal interfaces. Best regards Thomas drm-misc-next-2024-02-08: drm-misc-next for v6.9: UAPI

Re: [PATCH 2/3] bits: Introduce fixed-type BIT

2024-02-09 Thread Yury Norov
On Tue, Jan 23, 2024 at 09:02:04PM -0800, Lucas De Marchi wrote: > Implement fixed-type BIT() to help drivers add stricter checks, like was > done for GENMASK. > > Signed-off-by: Lucas De Marchi Reviewed-by: Yury Norov > --- > include/linux/bits.h | 9 + > 1 file changed, 9 insertions

Re: [PATCH v4 07/14] drm/panthor: Add the MMU/VM logical block

2024-02-09 Thread Steven Price
On 22/01/2024 16:30, Boris Brezillon wrote: > MMU and VM management is related and placed in the same source file. > > Page table updates are delegated to the io-pgtable-arm driver that's in > the iommu subsystem. > > The VM management logic is based on drm_gpuva_mgr, and is assuming the > VA spa

Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT

2024-02-09 Thread Yury Norov
On Wed, Feb 07, 2024 at 11:45:20PM -0800, Lucas De Marchi wrote: > Implement fixed-type BIT() to help drivers add stricter checks, like was > done for GENMASK. > > Signed-off-by: Lucas De Marchi > Acked-by: Jani Nikula So I get v1 from Jan.23 in my mailbox, and this one is v3. Did I miss a v2?

[PATCH] drm: document userspace expectations around the Colorspace connector property

2024-02-09 Thread Xaver Hugl
Signed-off-by: Xaver Hugl --- drivers/gpu/drm/drm_connector.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index b0516505f7ae..01e13984629b 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_conne

Re: [PATCH] drm/amd/display: Fix && vs || typos

2024-02-09 Thread Hamza Mahfooz
On 2/9/24 08:02, Dan Carpenter wrote: These ANDs should be ORs or it will lead to a NULL dereference. Fixes: fb5a3d037082 ("drm/amd/display: Add NULL test for 'timing generator' in 'dcn21_set_pipe()'") Fixes: 886571d217d7 ("drm/amd/display: Fix 'panel_cntl' could be null in 'dcn21_set_backligh

Re: [PATCH i-g-t] benchmarks: Add VKMS benchmark

2024-02-09 Thread Arthur Grillo
On 09/02/24 05:32, Pekka Paalanen wrote: > On Thu, 8 Feb 2024 16:38:31 -0300 > Arthur Grillo wrote: > >> On 08/02/24 06:50, Pekka Paalanen wrote: >>> On Wed, 07 Feb 2024 17:17:15 -0300 >>> Arthur Grillo wrote: >>> Create a benchmark for the VKMS driver. Use a KMS layout with deliberat

Re: [PATCH] nouveau: offload fence uevents work to workqueue

2024-02-09 Thread Danilo Krummrich
On 2/6/24 15:03, Daniel Vetter wrote: On Mon, Feb 05, 2024 at 11:00:04PM +0100, Danilo Krummrich wrote: On 2/5/24 22:08, Dave Airlie wrote: On Tue, 6 Feb 2024 at 02:22, Danilo Krummrich wrote: On 1/29/24 02:50, Dave Airlie wrote: From: Dave Airlie This should break the deadlock between th

Re: [PATCH v4] drm/ci: add tests on vkms

2024-02-09 Thread Helen Koike
On 01/02/2024 03:53, Vignesh Raman wrote: Add job that runs igt on top of vkms. Signed-off-by: Vignesh Raman Acked-by: Jessica Zhang Tested-by: Jessica Zhang Acked-by: Maxime Ripard Signed-off-by: Helen Koike --- v2: - do not mv modules to /lib/modules in the job definition, leave it to

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-09 Thread Daniel Vetter
On Fri, Feb 09, 2024 at 08:56:24PM +0530, Arunpravin Paneer Selvam wrote: > Few users have observed display corruption when they boot > the machine to KDE Plasma or playing games. We have root > caused the problem that whenever alloc_range() couldn't > find the required memory blocks the function w

Re: [PATCH] drm/radeon/ni: Fix wrong firmware size logging in ni_init_microcode()

2024-02-09 Thread Alex Deucher
Applied. Thanks! On Tue, Feb 6, 2024 at 11:48 AM Nikita Zhandarovich wrote: > > Clean up a typo in pr_err() erroneously printing NI MC 'rdev->mc_fw->size' > during SMC firmware load. Log 'rdev->smc_fw->size' instead. > > Found by Linux Verification Center (linuxtesting.org) with static > analysi

Re: [PATCH] drm/amd/display: fix NULL checks for adev->dm.dc in amdgpu_dm_fini()

2024-02-09 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Feb 6, 2024 at 11:51 AM Nikita Zhandarovich wrote: > > Since 'adev->dm.dc' in amdgpu_dm_fini() might turn out to be NULL > before the call to dc_enable_dmub_notifications(), check > beforehand to ensure there will not be a possible NULL-ptr-deref > there. > > Also,

Re: [PATCH v3 3/9] drm/ci: mediatek: Add job to test panfrost and powervr GPU driver

2024-02-09 Thread Helen Koike
On 30/01/2024 12:03, Vignesh Raman wrote: For mediatek mt8173, the GPU driver is powervr and for mediatek mt8183, the GPU driver is panfrost. So add support in drm-ci to test panfrost and powervr GPU driver for mediatek SOCs and update xfails. Powervr driver was merged in linux kernel, but the

Re: [PATCH v3 1/9] drm/ci: arm64.config: Enable CONFIG_DRM_ANALOGIX_ANX7625

2024-02-09 Thread Helen Koike
On 30/01/2024 12:03, Vignesh Raman wrote: Enable CONFIG_DRM_ANALOGIX_ANX7625 in the arm64 defconfig to get display driver probed on the mt8183-kukui-jacuzzi-juniper machine. arch/arm64/configs/defconfig has CONFIG_DRM_ANALOGIX_ANX7625=m, but drm-ci don't have initrd with modules, so add CONFI

Re: [PATCH v4 5/5] drm/msm/dpu: drop dpu_encoder_phys_ops::atomic_check()

2024-02-09 Thread Paloma Arellano
On 2/8/2024 7:20 AM, Dmitry Baryshkov wrote: Writeback was the last user of dpu_encoder_phys_ops's atomic_check() callback. As the code was moved to the dpu_writeback.c, the callback becomes unused. Drop it now. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov Tested-by: Paloma

Re: [PATCH v4 4/5] drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c

2024-02-09 Thread Paloma Arellano
On 2/8/2024 7:20 AM, Dmitry Baryshkov wrote: dpu_encoder_phys_wb is the only user of encoder's atomic_check callback. Move corresponding checks to drm_writeback_connector's implementation and drop the dpu_encoder_phys_wb_atomic_check() function. Signed-off-by: Dmitry Baryshkov Tested-by: P

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-09 Thread Arunpravin Paneer Selvam
Hi Daniel, On 2/9/2024 11:34 PM, Daniel Vetter wrote: On Fri, Feb 09, 2024 at 08:56:24PM +0530, Arunpravin Paneer Selvam wrote: Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the problem that whenever alloc_range() could

Re: [PATCH v4 2/5] drm/msm/dpu: split _dpu_encoder_resource_control_helper()

2024-02-09 Thread Paloma Arellano
On 2/8/2024 7:20 AM, Dmitry Baryshkov wrote: Follow the _dpu_encoder_irq_control() change and split the _dpu_encoder_resource_control_helper() into enable and disable parts. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov Tested-by: Paloma Arellano

Re: [PATCH v4 3/5] drm/msm/dpu: drop dpu_encoder_phys_ops.atomic_mode_set

2024-02-09 Thread Paloma Arellano
On 2/8/2024 7:20 AM, Dmitry Baryshkov wrote: The atomic_mode_set() callback only sets the phys_enc's IRQ data. As the INTF and WB are statically allocated to each encoder/phys_enc, drop the atomic_mode_set callback and set the IRQs during encoder init. For the CMD panel usecase some of IRQ ind

Re: [PATCH v4 1/5] drm/msm/dpu: split irq_control into irq_enable and _disable

2024-02-09 Thread Paloma Arellano
On 2/8/2024 7:20 AM, Dmitry Baryshkov wrote: The single helper for both enable and disable cases is too complicated, especially if we start adding more code to these helpers. Split it into irq_enable and irq_disable cases. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov Tested-b

Re: [PATCH v4 1/4] drm/msm/mdss: generate MDSS data for MDP5 platforms

2024-02-09 Thread Abhinav Kumar
On 2/8/2024 7:01 AM, Dmitry Baryshkov wrote: Older (mdp5) platforms do not use per-SoC compatible strings. Instead they use a single compat entry 'qcom,mdss'. To facilitate migrating these platforms to the DPU driver provide a way to generate the MDSS / UBWC data at runtime, when the DPU drive

Re: [PATCH v4 2/4] drm/msm/dpu: support binding to the mdp5 devices

2024-02-09 Thread Abhinav Kumar
On 2/8/2024 7:01 AM, Dmitry Baryshkov wrote: Existing MDP5 devices have slightly different bindings. The main register region is called `mdp_phys' instead of `mdp'. Also vbif register regions are a part of the parent, MDSS device. Add support for handling this binding differences. Signed-off-

Re: [git pull] drm fixes for 6.8-rc4

2024-02-09 Thread pr-tracker-bot
The pull request you sent on Fri, 9 Feb 2024 14:28:39 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2024-02-09 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c76b766ec50d3d43e2dacea53a733b285f4b730d Thank you! -- Deet-doot-dot, I am a bot. https://ko

Re: [PATCH] nouveau: offload fence uevents work to workqueue

2024-02-09 Thread Daniel Vetter
On Fri, Feb 09, 2024 at 06:41:32PM +0100, Danilo Krummrich wrote: > On 2/6/24 15:03, Daniel Vetter wrote: > > On Mon, Feb 05, 2024 at 11:00:04PM +0100, Danilo Krummrich wrote: > > > On 2/5/24 22:08, Dave Airlie wrote: > > > > On Tue, 6 Feb 2024 at 02:22, Danilo Krummrich wrote: > > > > > > > > >

Re: [PATCH v4 1/3] drm: Add drm_get_acpi_edid() helper

2024-02-09 Thread Daniel Vetter
On Fri, Feb 09, 2024 at 09:34:13AM -0600, Mario Limonciello wrote: > On 2/9/2024 05:07, Daniel Vetter wrote: > > On Thu, Feb 08, 2024 at 11:57:11AM +0200, Jani Nikula wrote: > > > On Wed, 07 Feb 2024, Mario Limonciello wrote: > > > > Some manufacturers have intentionally put an EDID that differs f

Re: [PATCH v4 2/4] drm/msm/dpu: support binding to the mdp5 devices

2024-02-09 Thread Dmitry Baryshkov
On Fri, 9 Feb 2024 at 20:44, Abhinav Kumar wrote: > > > > On 2/8/2024 7:01 AM, Dmitry Baryshkov wrote: > > Existing MDP5 devices have slightly different bindings. The main > > register region is called `mdp_phys' instead of `mdp'. Also vbif > > register regions are a part of the parent, MDSS devic

[PATCH i-g-t v3] benchmarks: Add VKMS benchmark

2024-02-09 Thread Arthur Grillo
Create a benchmark for the VKMS driver. Use a KMS layout with deliberate odd sizes to try to avoid alignment accidents and run it for FRAME_COUNT frames flipping framebuffers in each plane. This benchmark was suggested by Pekka Paalanen to better analyse possible performance regression on the Virt

Re: [PATCH 1/2] drm/nouveau: don't fini scheduler if not initialized

2024-02-09 Thread Dave Airlie
On Fri, 2 Feb 2024 at 10:06, Danilo Krummrich wrote: > > nouveau_abi16_ioctl_channel_alloc() and nouveau_cli_init() simply call > their corresponding *_fini() counterpart. This can lead to > nouveau_sched_fini() being called without struct nouveau_sched ever > being initialized in the first place.

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-09 Thread Daniel Vetter
On Sat, Feb 10, 2024 at 12:06:58AM +0530, Arunpravin Paneer Selvam wrote: > Hi Daniel, > > On 2/9/2024 11:34 PM, Daniel Vetter wrote: > > On Fri, Feb 09, 2024 at 08:56:24PM +0530, Arunpravin Paneer Selvam wrote: > > > Few users have observed display corruption when they boot > > > the machine to K

Re: [PATCH RESEND 2/5] drm/msm/dpu: finalise global state object

2024-02-09 Thread Abhinav Kumar
On 12/2/2023 4:05 PM, Dmitry Baryshkov wrote: Add calls to finalise global state object and corresponding lock. Fixes: de3916c70a24 ("drm/msm/dpu: Track resources in global state") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 1 file changed, 8

Re: [PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions

2024-02-09 Thread Thomas Zimmermann
Hi Am 09.02.24 um 06:15 schrieb Michael Ellerman: Thomas Zimmermann writes: Am 07.02.24 um 17:13 schrieb Randy Dunlap: When VIDEO is not set, there is a build error. Fix that by selecting VIDEO for PS3_PS3AV. ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined! Fixes:

Re: Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-09 Thread Sebastian Wick
On Fri, Feb 02, 2024 at 04:49:04PM +0100, Maxime Ripard wrote: > Hi Sebastian, > > On Mon, Jan 15, 2024 at 03:33:08PM +0100, Sebastian Wick wrote: > > > /** > > > * DOC: HDMI connector properties > > > * > > > + * Broadcast RGB > > > + * Indicates the RGB Quantization Range (Full vs Limi

Re: Re: Re: Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-09 Thread Sebastian Wick
On Mon, Feb 05, 2024 at 10:39:38AM +0100, Maxime Ripard wrote: > On Fri, Feb 02, 2024 at 06:37:52PM +0200, Ville Syrjälä wrote: > > On Fri, Feb 02, 2024 at 04:59:30PM +0100, Maxime Ripard wrote: > > > On Fri, Feb 02, 2024 at 05:40:47PM +0200, Ville Syrjälä wrote: > > > > On Fri, Feb 02, 2024 at 02:

Re: [PATCH] drm: document userspace expectations around the Colorspace connector property

2024-02-09 Thread Sebastian Wick
On Fri, Feb 09, 2024 at 05:53:07PM +0100, Xaver Hugl wrote: > Signed-off-by: Xaver Hugl > --- > drivers/gpu/drm/drm_connector.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index b0516505f7ae..01e13984629b 10

Re: [PATCH 4/8] arm64: dts: qcom: msm8976: Add MDSS nodes

2024-02-09 Thread Konrad Dybcio
On 21.01.2024 20:41, Adam Skladowski wrote: > Add MDSS nodes to support displays on MSM8976 SoC. > > Signed-off-by: Adam Skladowski > --- > arch/arm64/boot/dts/qcom/msm8976.dtsi | 268 +- > 1 file changed, 264 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boo

Re: [PATCH 6/8] arm64: dts: qcom: msm8976: Add Adreno GPU

2024-02-09 Thread Konrad Dybcio
On 21.01.2024 20:41, Adam Skladowski wrote: > Add Adreno GPU node. > > Signed-off-by: Adam Skladowski > --- > arch/arm64/boot/dts/qcom/msm8976.dtsi | 66 +++ > 1 file changed, 66 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi > b/arch/arm64/boot/dt

Re: [PATCH RESEND 1/1] drm/panel: st7703: Fix Panel Initialization for Anbernic RG353V-V2

2024-02-09 Thread Chris Morgan
On Fri, Feb 09, 2024 at 11:08:22AM +0100, Guido Günther wrote: > Hi Ao, > > this doesn't say why that was changed but your cover letter > has that information: > > > After correcting these parameters by referencing the > > device tree in JELOS (which uses the BSP kernel for RK3566), the panel > >

Re: [PATCH 8/8] arm64: dts: qcom: msm8976: Add WCNSS node

2024-02-09 Thread Konrad Dybcio
On 21.01.2024 20:41, Adam Skladowski wrote: > Add node describing wireless connectivity subsystem. > > Signed-off-by: Adam Skladowski > --- > arch/arm64/boot/dts/qcom/msm8976.dtsi | 96 +++ > 1 file changed, 96 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8

Re: [PATCH RESEND 1/1] drm/panel: st7703: Fix Panel Initialization for Anbernic RG353V-V2

2024-02-09 Thread Ao Zhong
Hello Chris Morgan, Guido Günther, I will post a v2 patch. I will supplement the commit information and attach the reference links I used when modifying the init sequence. Ao Zhong Am Fr., 9. Feb. 2024 um 22:35 Uhr schrieb Chris Morgan : > > On Fri, Feb 09, 2024 at 11:08:22AM +0100, Guido Günthe

[pull] amdgpu, amdkfd, radeon drm-next-6.9

2024-02-09 Thread Alex Deucher
Hi Dave, Sima, New stuff for 6.9. The following changes since commit d7643fe6fb76edb1f2f1497bf5e8b8f4774b5129: drm/amd/display: Avoid enum conversion warning (2024-01-15 18:35:07 -0500) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-nex

Re: [PATCH RESEND 3/5] drm/msm/dpu: drop global_state_lock

2024-02-09 Thread Abhinav Kumar
On 12/2/2023 4:05 PM, Dmitry Baryshkov wrote: Since the commit b962a12050a3 ("drm/atomic: integrate modeset lock with private objects") the DRM framework no longer requires the external lock for private objects. Drop the lock, letting the DRM to manage private object locking. Signed-off-by: D

Re: [PATCH RESEND 4/5] drm/msm/mdp5: migrate SMP dumping to using atomic_print_state

2024-02-09 Thread Abhinav Kumar
On 12/2/2023 4:05 PM, Dmitry Baryshkov wrote: The Shared Memory Pool (SMP) state is a part of the MDP5's private object state. Use existing infrastructure, atomic_print_state() callback, to dump SMP state (which also makes it included into debugfs/dri/N/state). This allows us to drop the custo

[PATCH v2] drm/panel: st7703: Fix Panel Initialization for Anbernic RG353V-V2

2024-02-09 Thread Ao Zhong
This patch addresses an issue with the Anbernic RG353V-V2 panel initialization that was caused by incorrect parameter. The correct initialization sequence was derived by referencing the JELOS (Just Enough Linux OS) BSP kernel's device tree for the V2 panel, which is identified by the ID "38 21". Th

Re: [PATCH RESEND 5/5] drm/msm/mdp5: drop global_state_lock

2024-02-09 Thread Abhinav Kumar
On 12/2/2023 4:05 PM, Dmitry Baryshkov wrote: Since the commit b962a12050a3 ("drm/atomic: integrate modeset lock with private objects") the DRM framework no longer requires the external lock for private objects. Drop the lock, letting the DRM to manage private object locking. Signed-off-by: D

Re: [PATCH 2/3] drm/panel: add samsung s6e3fa7 panel driver

2024-02-09 Thread Richard Acayan
On Thu, Feb 08, 2024 at 05:34:57PM -0800, Jessica Zhang wrote: > On 2/8/2024 4:16 PM, Richard Acayan wrote: >> The S6E3FA7 display controller is enabled in every Pixel 3a (non-XL) >> variant. Add the driver for it, generated by >> linux-mdss-dsi-panel-driver-generator. >> >> There are other panels

[PATCH v3] drm/panel: st7703: Fix Panel Initialization for Anbernic RG353V-V2

2024-02-09 Thread Ao Zhong
This patch addresses an issue with the Anbernic RG353V-V2 panel initialization that was caused by incorrect parameter. The correct initialization sequence was derived by referencing the JELOS (Just Enough Linux OS) BSP kernel's device tree for the V2 panel, which is identified by the ID "38 21". Th

[PATCH v2 01/19] drm/msm/dpu: allow certain formats for CDM for DP

2024-02-09 Thread Paloma Arellano
CDM block supports formats other than H1V2 for DP. Since we are now adding support for CDM over DP, relax the checks to allow all other formats for DP other than H1V2. Changes in v2: - Add fixes tag - Move patch to top of series Fixes: 0afac0ba6024 ("drm/msm/dpu: add dpu_hw_cdm ab

[PATCH v2 09/19] drm/msm/dpu: move widebus logic to its own API

2024-02-09 Thread Paloma Arellano
Widebus enablement is decided by the interfaces based on their specific checks and that already happens with DSI/DP specific helpers. Let's invoke these helpers from dpu_encoder_is_widebus_enabled() to make it cleaner overall. Signed-off-by: Paloma Arellano Reviewed-by: Dmitry Baryshkov --- dri

[PATCH v2 05/19] drm/msm/dpu: move dpu_encoder_helper_phys_setup_cdm to dpu_encoder

2024-02-09 Thread Paloma Arellano
Move dpu_encoder_helper_phys_setup_cdm to dpu_encoder in preparation for implementing YUV420 over DP, which requires CDM compatibility. Changes in v2: - Slightly change the wording of the commit text to make clear that YUV over DP requires CDM Signed-off-by: Paloma Arellano Rev

[PATCH v2 06/19] drm/msm/dp: rename wide_bus_en to wide_bus_supported

2024-02-09 Thread Paloma Arellano
Rename wide_bus_en to wide_bus_supported in dp_display_private to correctly establish that the parameter is referencing if wide bus is supported instead of enabled. Signed-off-by: Paloma Arellano Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 42 ++--

[PATCH v2 11/19] drm/msm/dp: change clock related programming for YUV420 over DP

2024-02-09 Thread Paloma Arellano
Change all relevant DP controller related programming for YUV420 cases. Namely, change the pixel clock math to consider YUV420 and modify the MVID programming to consider YUV420. Changes in v2: - Move configuration control progamming to a different commit - Slight code simplificati

[PATCH v2 08/19] drm/msm/dp: check if VSC SDP is supported in DP programming

2024-02-09 Thread Paloma Arellano
In the DP driver, check if VSC SDP is supported and propagate this value to dp_panel. In dp_display's dp_mode, the out_fmt_is_yuv_420 parameter must also utilize this value since YUV420 is only allowed when VSC SDP is supported. Changes in v2: - Move DP programming when VSC SDP is supporte

[PATCH v2 04/19] drm/msm/dpu: allow dpu_encoder_helper_phys_setup_cdm to work for DP

2024-02-09 Thread Paloma Arellano
Generalize dpu_encoder_helper_phys_setup_cdm to be compatible with DP. Changes in v2: - Minor formatting changes - Move the modification of the dimesions for CDM setup to a new patch Signed-off-by: Paloma Arellano --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 4

[PATCH v2 12/19] drm/msm/dp: move parity calculation to dp_utils

2024-02-09 Thread Paloma Arellano
Parity calculation is necessary for VSC SDP implementation. Therefore create new files dp_utils.c and dp_utils.h and move the parity calculating functions here. This ensures that they are usable by SDP programming in both dp_catalog.c and dp_audio.c Changes in v2: - Create new files dp_uti

[PATCH v2 15/19] drm/msm/dp: enable SDP and SDE periph flush update

2024-02-09 Thread Paloma Arellano
DP controller can be setup to operate in either SDP update flush mode or peripheral flush mode based on the DP controller hardware version. Starting in DP v1.2, the hardware documents require the use of peripheral flush mode for SDP packets such as PPS OR VSC SDP packets. In-line with this guidan

  1   2   >