[AMD Official Use Only - General]
Reviewed-by: Anthony Koo <anthony....@amd.com>
Looks good, my mistake for not noticing this!
Thanks,
Anthony
-----Original Message-----
From: Dan Carpenter <dan.carpen...@linaro.org>
Sent: Friday, February 9, 2024 8:03 AM
To: SHANMUGAM, SRINIVASAN <srinivasan.shanmu...@amd.com>
Cc: Wentland, Harry <harry.wentl...@amd.com>; Li, Sun peng (Leo)
<sunpeng...@amd.com>; Siqueira, Rodrigo <rodrigo.sique...@amd.com>; Deucher,
Alexander <alexander.deuc...@amd.com>; Koenig, Christian
<christian.koe...@amd.com>; Pan, Xinhui <xinhui....@amd.com>; David Airlie
<airl...@gmail.com>; Daniel Vetter <dan...@ffwll.ch>; Kazlauskas, Nicholas
<nicholas.kazlaus...@amd.com>; Koo, Anthony <anthony....@amd.com>; Pavic, Josip
<josip.pa...@amd.com>; Huang, Leon <leon.hua...@amd.com>; Adhuri, Mounika
<mounika.adh...@amd.com>; Huang, Lewis <lewis.hu...@amd.com>;
amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org;
linux-ker...@vger.kernel.org; kernel-janit...@vger.kernel.org
Subject: [PATCH] drm/amd/display: Fix && vs || typos
These ANDs should be ORs or it will lead to a NULL dereference.
Fixes: fb5a3d037082 ("drm/amd/display: Add NULL test for 'timing generator' in
'dcn21_set_pipe()'")
Fixes: 886571d217d7 ("drm/amd/display: Fix 'panel_cntl' could be null in
'dcn21_set_backlight_level()'")
Signed-off-by: Dan Carpenter <dan.carpen...@linaro.org>
---
drivers/gpu/drm/amd/display/dc/hwss/dcn21/dcn21_hwseq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn21/dcn21_hwseq.c
b/drivers/gpu/drm/amd/display/dc/hwss/dcn21/dcn21_hwseq.c
index 5c7f380a84f9..7252f5f781f0 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn21/dcn21_hwseq.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn21/dcn21_hwseq.c
@@ -211,7 +211,7 @@ void dcn21_set_pipe(struct pipe_ctx *pipe_ctx)
struct dmcu *dmcu = pipe_ctx->stream->ctx->dc->res_pool->dmcu;
uint32_t otg_inst;
- if (!abm && !tg && !panel_cntl)
+ if (!abm || !tg || !panel_cntl)
return;
otg_inst = tg->inst;
@@ -245,7 +245,7 @@ bool dcn21_set_backlight_level(struct pipe_ctx *pipe_ctx,
struct panel_cntl *panel_cntl = pipe_ctx->stream->link->panel_cntl;
uint32_t otg_inst;
- if (!abm && !tg && !panel_cntl)
+ if (!abm || !tg || !panel_cntl)
return false;
otg_inst = tg->inst;
--
2.43.0
