Re: [PATCH 2/5] dt-bindings: display/msm: Document the DPU for X1E80100

2024-01-30 Thread Krzysztof Kozlowski
On 29/01/2024 14:18, Abel Vesa wrote: > Document the DPU for Qualcomm X1E80100 platform in the SM8650 schema, as > they are similar. > > Signed-off-by: Abel Vesa > --- > Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [PATCH 1/5] dt-bindings: display/msm: document MDSS on X1E80100

2024-01-30 Thread Krzysztof Kozlowski
On 29/01/2024 14:18, Abel Vesa wrote: > Document the MDSS hardware found on the Qualcomm X1E80100 platform. > > Signed-off-by: Abel Vesa > --- Please document dependencies, including the ones not in the tree this is targeting. You have build failures, so that deserves some note. > .../bindings

Re: [PATCH] drm/xe: Fix a build error

2024-01-30 Thread Thomas Hellström
Hi, Oak On 1/29/24 21:29, Zeng, Oak wrote: Hi Thomas, My patch was based on drm-tip because I found drm-tip is broken Yes, but drm-tip is rebuilt and force-pushed every time any of the merged branches adds a new commit, so any commit needs to land in any of the included branches, an

Re: [PATCH v19 09/30] drm/shmem-helper: Add and use lockless drm_gem_shmem_get_pages()

2024-01-30 Thread Daniel Vetter
On Fri, Jan 26, 2024 at 07:43:29PM +0300, Dmitry Osipenko wrote: > On 1/26/24 13:18, Boris Brezillon wrote: > > On Thu, 25 Jan 2024 18:24:04 +0100 > > Daniel Vetter wrote: > > > >> On Fri, Jan 05, 2024 at 09:46:03PM +0300, Dmitry Osipenko wrote: > >>> Add lockless drm_gem_shmem_get_pages() helper

[Bug 218435] New: UBSAN: array-index-out-of-bounds in radeon_atombios.c:2620:43

2024-01-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218435 Bug ID: 218435 Summary: UBSAN: array-index-out-of-bounds in radeon_atombios.c:2620:43 Product: Drivers Version: 2.5 Hardware: All OS: Linux Stat

[Bug 218435] UBSAN: array-index-out-of-bounds in radeon_atombios.c:2620:43

2024-01-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218435 --- Comment #1 from Sergey Belyashov (sergey.belyas...@gmail.com) --- Created attachment 305790 --> https://bugzilla.kernel.org/attachment.cgi?id=305790&action=edit dmesg output -- You may reply to this email to add a comment. You are receivi

Re: [PATCH v19 22/30] drm/shmem-helper: Add common memory shrinker

2024-01-30 Thread Daniel Vetter
On Thu, Jan 25, 2024 at 10:07:03AM +0100, Boris Brezillon wrote: > On Fri, 5 Jan 2024 21:46:16 +0300 > Dmitry Osipenko wrote: > > > * > > * This function Increases the use count and allocates the backing pages if > > * use-count equals to zero. > > + * > > + * Note that this function doesn

Re: Making drm_gpuvm work across gpu devices

2024-01-30 Thread Christian König
Am 30.01.24 um 01:21 schrieb Zeng, Oak: The example you used to prove that KFD is a design failure, is against *any* design which utilize system allocator and hmm. The way that one proxy process running on host to handle many guest processes, doesn’t fit into the concept of “share address spa

Re: Making drm_gpuvm work across gpu devices

2024-01-30 Thread Thomas Hellström
Hi, Oak, On 1/30/24 01:21, Zeng, Oak wrote: The example you used to prove that KFD is a design failure, is against *any* design which utilize system allocator and hmm. The way that one proxy process running on host to handle many guest processes, doesn’t fit into the concept of “share addres

Re: [PATCH RFC 0/4] Support for Simulated Panels

2024-01-30 Thread Daniel Vetter
On Mon, Jan 29, 2024 at 11:05:12AM -0800, Abhinav Kumar wrote: > > > Hi Maxime > > On 1/26/2024 4:45 AM, Maxime Ripard wrote: > > On Wed, Jan 17, 2024 at 09:36:20AM -0800, Abhinav Kumar wrote: > > > Hi Jani and Maxime > > > > > > On 1/17/2024 2:16 AM, Jani Nikula wrote: > > > > On Wed, 17 Jan 2

Re: [Linaro-mm-sig] Re: [PATCH v5 1/6] dma-buf: Add dma_buf_{begin,end}_access()

2024-01-30 Thread Daniel Vetter
On Fri, Jan 26, 2024 at 05:42:50PM +0100, Christian König wrote: > Am 25.01.24 um 19:01 schrieb Daniel Vetter: > > On Thu, Jan 25, 2024 at 04:00:16PM +0100, Christian König wrote: > > > Am 24.01.24 um 11:58 schrieb Paul Cercueil: > > > > [SNIP] > > > > > > The problem was then that dma_buf_unmap_at

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

2024-01-30 Thread Dario Binacchi
Hi Michael, On Mon, Jan 29, 2024 at 5:06 PM Michael Walle wrote: > > >> Just FYI this conflictted pretty heavily with drm-misc-next changes in > >> the same area, someone should check drm-tip has the correct > >> resolution, I'm not really sure what is definitely should be. > > > > FWIW, this loo

Re: [Linaro-mm-sig] Re: [PATCH v5 1/6] dma-buf: Add dma_buf_{begin,end}_access()

2024-01-30 Thread Christian König
Am 30.01.24 um 10:01 schrieb Daniel Vetter: On Fri, Jan 26, 2024 at 05:42:50PM +0100, Christian König wrote: [SNIP] Well I think we should have some solution, but I'm not sure if it should be part of DMA-buf. Essentially a DMA-buf exports the buffers as he uses it and the importer (or the DMA-b

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

2024-01-30 Thread Michael Walle
Hi Dario, >> Just FYI this conflictted pretty heavily with drm-misc-next changes in >> the same area, someone should check drm-tip has the correct >> resolution, I'm not really sure what is definitely should be. > > FWIW, this looks rather messy now. The drm-tip doesn't build. > > There was a ne

[PATCH] drm/amdgpu: Clear the hotplug interrupt ack bit before hpd initialization

2024-01-30 Thread Qiang Ma
Problem: The computer in the bios initialization process, unplug the HDMI display, wait until the system up, plug in the HDMI display, did not enter the hotplug interrupt function, the display is not bright. Fix: After the above problem occurs, and the hpd ack interrupt bit is 1, the interrupt sho

[PATCH] drm/amdgpu: Clear the hotplug interrupt ack bit before hpd initialization

2024-01-30 Thread Qiang Ma
Problem: The computer in the bios initialization process, unplug the HDMI display, wait until the system up, plug in the HDMI display, did not enter the hotplug interrupt function, the display is not bright. Fix: After the above problem occurs, and the hpd ack interrupt bit is 1, the interrupt sho

Re: [Linaro-mm-sig] Re: [PATCH v5 1/6] dma-buf: Add dma_buf_{begin,end}_access()

2024-01-30 Thread Paul Cercueil
Hi Christian, (Your email software is configured for HTML btw) Le mardi 30 janvier 2024 à 10:23 +0100, Christian König a écrit : >  Am 30.01.24 um 10:01 schrieb Daniel Vetter: >   > >   > > On Fri, Jan 26, 2024 at 05:42:50PM +0100, Christian König wrote: > >   > > > [SNIP] > > > Well I think we

Re: [PATCH v19 22/30] drm/shmem-helper: Add common memory shrinker

2024-01-30 Thread Dmitry Osipenko
On 1/30/24 11:39, Daniel Vetter wrote: > On Thu, Jan 25, 2024 at 10:07:03AM +0100, Boris Brezillon wrote: >> On Fri, 5 Jan 2024 21:46:16 +0300 >> Dmitry Osipenko wrote: >> >>> * >>> * This function Increases the use count and allocates the backing pages if >>> * use-count equals to zero. >>

Re: [PATCH v19 09/30] drm/shmem-helper: Add and use lockless drm_gem_shmem_get_pages()

2024-01-30 Thread Dmitry Osipenko
On 1/30/24 11:34, Daniel Vetter wrote: > On Fri, Jan 26, 2024 at 07:43:29PM +0300, Dmitry Osipenko wrote: >> On 1/26/24 13:18, Boris Brezillon wrote: >>> On Thu, 25 Jan 2024 18:24:04 +0100 >>> Daniel Vetter wrote: >>> On Fri, Jan 05, 2024 at 09:46:03PM +0300, Dmitry Osipenko wrote: > Add

[PATCH 01/23] drm/format-helper: Add struct drm_pixmap

2024-01-30 Thread Thomas Zimmermann
Add struct drm_pixmap to wrap the source parameters for all drawing operations. This consists of the format, the clipping rectangle, the line pitch and source data buffers. Also add a helper that creates a pixmap from a framebuffer. Existing code uses struct drm_framebuffer for drawing. Converting

[PATCH 02/23] drm/format-helper: Use struct drm_pixmap for drm_fb_memcpy()

2024-01-30 Thread Thomas Zimmermann
Store the source-buffer parameters of drm_fb_memcpy() in struct drm_pixmap. Update the function's interface and all of its callers. Callers of drm_fb_memcpy() initialize the pixmap's instance from a pre-existing instance of struct drm_framebuffer. There's potential to simplify some of that code in

[PATCH 04/23] drm/format-helper: Use struct drm_pixmap internally

2024-01-30 Thread Thomas Zimmermann
Implement drm_fb_xfrm() with struct drm_pixmap and adapt all callers. The internal instances if struct drm_pixmap will eventually be pushed into external callers of the format-helper interface. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 76 +---

[PATCH 07/23] drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_rgb565()

2024-01-30 Thread Thomas Zimmermann
Store the source-buffer parameters of drm_fb_xrgb_to_rgb565() in struct drm_pixmap. Update the function's interface and all of its callers. Callers of drm_fb_xrgb_to_rgb565() initialize the pixmap's instance from a pre-existing instance of struct drm_framebuffer. There's potential to simpl

[PATCH 13/23] drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_abgr8888()

2024-01-30 Thread Thomas Zimmermann
Store the source-buffer parameters of drm_fb_xrgb_to_abgr() in struct drm_pixmap. Update the function's interface and all of its callers. Callers of drm_fb_xrgb_to_abgr() initialize the pixmap's instance from a pre-existing instance of struct drm_framebuffer. There's potential to s

[PATCH 10/23] drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_rgba5551()

2024-01-30 Thread Thomas Zimmermann
Store the source-buffer parameters of drm_fb_xrgb_to_rgba5551() in struct drm_pixmap. Update the function's interface and all of its callers. Callers of drm_fb_xrgb_to_rgba5551() initialize the pixmap's instance from a pre-existing instance of struct drm_framebuffer. There's potential to s

[PATCH 00/23] [RFC] drm/format-helper: Introduce drm_pixmap, font support and filling

2024-01-30 Thread Thomas Zimmermann
This RFC patchset implements various features required for DRM panic handling [1] and should (for now) be seen in that context. Most of all, the patchset replaces struct drm_framebuffer with struct drm_pixmap in the format-conversion helpers. DRM pixmap represents a source of pixel data for the bl

[PATCH 05/23] drm/format-helper: Use struct drm_pixmap for drm_fb_swab()

2024-01-30 Thread Thomas Zimmermann
Store the source-buffer parameters of drm_fb_swab() in struct drm_pixmap. Update the function's interface and all of its callers. Callers of drm_fb_swab() initialize the pixmap's instance from a pre-existing instance of struct drm_framebuffer. There's potential to simplify some of that code in a l

[PATCH 12/23] drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_argb8888()

2024-01-30 Thread Thomas Zimmermann
Store the source-buffer parameters of drm_fb_xrgb_to_argb() in struct drm_pixmap. Update the function's interface and all of its callers. Callers of drm_fb_xrgb_to_argb() initialize the pixmap's instance from a pre-existing instance of struct drm_framebuffer. There's potential to s

[PATCH 17/23] drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_gray8()

2024-01-30 Thread Thomas Zimmermann
Store the source-buffer parameters of drm_fb_xrgb_to_gray8() in struct drm_pixmap. Update the function's interface and all of its callers. Callers of drm_fb_xrgb_to_gray8() initialize the pixmap's instance from a pre-existing instance of struct drm_framebuffer. There's potential to simplif

[PATCH 18/23] drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_mono()

2024-01-30 Thread Thomas Zimmermann
Store the source-buffer parameters of drm_fb_xrgb_to_mono() in struct drm_pixmap. Update the function's interface and all of its callers. Callers of drm_fb_xrgb_to_mono() initialize the pixmap's instance from a pre-existing instance of struct drm_framebuffer. There's potential to simplify

[PATCH 08/23] drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_xrgb1555()

2024-01-30 Thread Thomas Zimmermann
Store the source-buffer parameters of drm_fb_xrgb_to_xrgb1555() in struct drm_pixmap. Update the function's interface and all of its callers. Callers of drm_fb_xrgb_to_xrgb1555() initialize the pixmap's instance from a pre-existing instance of struct drm_framebuffer. There's potential to s

[PATCH 20/23] [DO NOT MERGE] drm/format-helper: Add font-support for DRM pixmap

2024-01-30 Thread Thomas Zimmermann
Add support for blitting characters. An instance of struct font_desc stores the the character shapes. The blitting source pixmap contains a reference to a character's glyph, which can then be blitted to the destination. drm_pixmap_init_from_font_desc() sets up the pixmap. struct drm_pixmap; d

[PATCH 09/23] drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_argb1555()

2024-01-30 Thread Thomas Zimmermann
Store the source-buffer parameters of drm_fb_xrgb_to_argb1555() in struct drm_pixmap. Update the function's interface and all of its callers. Callers of drm_fb_xrgb_to_argb1555() initialize the pixmap's instance from a pre-existing instance of struct drm_framebuffer. There's potential to s

[PATCH 15/23] drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_xrgb2101010()

2024-01-30 Thread Thomas Zimmermann
Store the source-buffer parameters of drm_fb_xrgb_to_xrgb2101010() in struct drm_pixmap. Update the function's interface and all of its callers. Callers of drm_fb_xrgb_to_xrgb2101010() initialize the pixmap's instance from a pre-existing instance of struct drm_framebuffer. There's potentia

[PATCH 23/23] [DO NOT MERGE] drm/format-helper: Add drm_fb_fill() to fill screen with color

2024-01-30 Thread Thomas Zimmermann
Add drm_fb_fill(), which fills areas with a single static color, and implement support for XRGB888 and RGB565. There's common infrastructure code to move over the destination area and a per-line draw function for each color format. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_

[PATCH 14/23] drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_xbgr8888()

2024-01-30 Thread Thomas Zimmermann
Store the source-buffer parameters of drm_fb_xrgb_to_xbgr() in struct drm_pixmap. Update the function's interface and all of its callers. Callers of drm_fb_xrgb_to_xbgr() initialize the pixmap's instance from a pre-existing instance of struct drm_framebuffer. There's potential to s

[PATCH 11/23] drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_rgb888()

2024-01-30 Thread Thomas Zimmermann
Store the source-buffer parameters of drm_fb_xrgb_to_rgb888() in struct drm_pixmap. Update the function's interface and all of its callers. Callers of drm_fb_xrgb_to_rgb888() initialize the pixmap's instance from a pre-existing instance of struct drm_framebuffer. There's potential to simpl

[PATCH 16/23] drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_argb2101010()

2024-01-30 Thread Thomas Zimmermann
Store the source-buffer parameters of drm_fb_xrgb_to_argb2101010() in struct drm_pixmap. Update the function's interface and all of its callers. Callers of drm_fb_xrgb_to_argb2101010() initialize the pixmap's instance from a pre-existing instance of struct drm_framebuffer. There's potentia

[PATCH 21/23] [DO NOT MERGE] drm/format-helper: Add color palette

2024-01-30 Thread Thomas Zimmermann
Add a color palette to struct drm_format_conv_state. The palette points to an array of struct drm_color_lut. It allows to blit from an index color formats to a component-based destination. The palette exists independently from the source pixmap and is thus stored struct drm_format_conv_state inste

[PATCH 06/23] drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_rgb332()

2024-01-30 Thread Thomas Zimmermann
Store the source-buffer parameters of drm_fb_xrgb_to_rgb332() in struct drm_pixmap. Update the function's interface and all of its callers. Callers of drm_fb_xrgb_to_rgb332() initialize the pixmap's instance from a pre-existing instance of struct drm_framebuffer. There's potential to simpl

[PATCH 22/23] [DO NOT MERGE] drm/format-helper: Support blitting from C1 to XRGB8888

2024-01-30 Thread Thomas Zimmermann
Implemented for drawing fonts, the C1-to-XRGB blitting code writes single bits into an XRGB-based buffer. The color is read from the given palette. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 39 + include/drm/drm_format_helper.h

[PATCH 03/23] drm/format-helper: Streamline drm_fb_xfrm() implementations

2024-01-30 Thread Thomas Zimmermann
Make the implementations of drm_fb_xfrm() independent from struct framebuffer and rename several variables. Done to simplify further cleanups; no functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 66 ++--- 1 file changed, 33 in

[PATCH 19/23] drm/format-helper: Use struct drm_pixmap for drm_fb_blit()

2024-01-30 Thread Thomas Zimmermann
Store the source-buffer parameters of drm_fb_blit() in struct drm_pixmap. Update the function's interface and all of its callers. Callers of drm_fb_blit() initialize the pixmap's instance from a pre-existing instance of struct drm_framebuffer. There's potential to simplify some of that code in a l

Re: [PATCH v19 09/30] drm/shmem-helper: Add and use lockless drm_gem_shmem_get_pages()

2024-01-30 Thread Boris Brezillon
On Tue, 30 Jan 2024 09:34:29 +0100 Daniel Vetter wrote: > On Fri, Jan 26, 2024 at 07:43:29PM +0300, Dmitry Osipenko wrote: > > On 1/26/24 13:18, Boris Brezillon wrote: > > > On Thu, 25 Jan 2024 18:24:04 +0100 > > > Daniel Vetter wrote: > > > > > >> On Fri, Jan 05, 2024 at 09:46:03PM +0300,

Re: [PATCH 2/8] video: Provide screen_info_get_pci_dev() to find screen_info's PCI device

2024-01-30 Thread Thomas Zimmermann
Hi Am 29.01.24 um 12:04 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Add screen_info_get_pci_dev() to find the PCI device of an instance of screen_info. Does nothing on systems without PCI bus. Signed-off-by: Thomas Zimmermann --- [...] +struct pci_dev *screen_info_pci_de

Re: [PATCH 03/10] drm/print: add drm_dbg_printer() for drm device specific printer

2024-01-30 Thread Luca Coelho
On Tue, 2024-01-16 at 15:07 +0200, Jani Nikula wrote: > We've lacked a device specific debug printer. Add one. Take category > into account too. > > __builtin_return_address(0) is inaccurate here, so don't use it. If > necessary, we can later pass __func__ to drm_dbg_printer() by wrapping > it ins

Re: [PATCH 04/10] drm/dp_mst: switch from drm_debug_printer() to device specific drm_dbg_printer()

2024-01-30 Thread Luca Coelho
On Tue, 2024-01-16 at 15:07 +0200, Jani Nikula wrote: > Prefer the device specific debug printer. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/display/drm_dp_mst_topology.c | 23 +++ > 1 file changed, 14 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/di

Re: [PATCH 05/10] drm/mode: switch from drm_debug_printer() to device specific drm_dbg_printer()

2024-01-30 Thread Luca Coelho
On Tue, 2024-01-16 at 15:07 +0200, Jani Nikula wrote: > Prefer the device specific debug printer. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_mode_config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_mode_config.c > b/drivers/gpu/

Re: [PATCH 2/8] video: Provide screen_info_get_pci_dev() to find screen_info's PCI device

2024-01-30 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi > > Am 29.01.24 um 12:04 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: >> >>> Add screen_info_get_pci_dev() to find the PCI device of an instance >>> of screen_info. Does nothing on systems without PCI bus. >>> >>> Signed-off-by: Thomas Zimmermann

Re: [PATCH 06/10] drm/dp: switch drm_dp_vsc_sdp_log() to struct drm_printer

2024-01-30 Thread Luca Coelho
On Tue, 2024-01-16 at 15:07 +0200, Jani Nikula wrote: > Use the existing drm printer infrastructure instead of local macros. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/display/drm_dp_helper.c | 17 +--- > .../drm/i915/display/intel_crtc_state_dump.c | 5 ++-- > driver

Re: [PATCH 07/10] drm/i915: switch from drm_debug_printer() to device specific drm_dbg_printer()

2024-01-30 Thread Luca Coelho
On Tue, 2024-01-16 at 15:07 +0200, Jani Nikula wrote: > Prefer the device specific debug printer. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_display_driver.c | 3 ++- > drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c| 3 ++- > drivers/gpu/drm/i915/gt/intel_res

Re: [PATCH 08/10] drm/i915: use drm_printf() with the drm_err_printer intead of pr_err()

2024-01-30 Thread Luca Coelho
On Tue, 2024-01-16 at 15:07 +0200, Jani Nikula wrote: > There's already a related drm_printer. Use it to preserve the context > instead of a separate pr_err(). > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c | 6 +++--- > drivers/gpu/drm/i915/selftests/

Re: [PATCH 09/10] drm/xe: switch from drm_debug_printer() to device specific drm_dbg_printer()

2024-01-30 Thread Luca Coelho
On Tue, 2024-01-16 at 15:07 +0200, Jani Nikula wrote: > Prefer the device specific debug printer. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/xe/xe_gt.c | 2 +- > drivers/gpu/drm/xe/xe_gt_topology.c | 4 +++- > drivers/gpu/drm/xe/xe_reg_sr.c | 2 +- > 3 files changed, 5

Re: [PATCH 10/10] drm: remove drm_debug_printer in favor of drm_dbg_printer

2024-01-30 Thread Luca Coelho
On Tue, 2024-01-16 at 15:07 +0200, Jani Nikula wrote: > Convert the remaining drm_debug_printer users over to drm_dbg_printer, > as it can handle the cases without struct drm_device pointer, and also > provides drm debug category and prefix support. Remove drm_debug_printer > altogether. > > Signe

Re: [Linaro-mm-sig] Re: [PATCH v5 1/6] dma-buf: Add dma_buf_{begin,end}_access()

2024-01-30 Thread Daniel Vetter
On Tue, Jan 30, 2024 at 10:23:03AM +0100, Christian König wrote: > Am 30.01.24 um 10:01 schrieb Daniel Vetter: > > On Fri, Jan 26, 2024 at 05:42:50PM +0100, Christian König wrote: > > > [SNIP] > > > Well I think we should have some solution, but I'm not sure if it should > > > be > > > part of DMA

Re: [PATCH 02/10] drm/print: move enum drm_debug_category etc. earlier in drm_print.h

2024-01-30 Thread Luca Coelho
On Tue, 2024-01-16 at 15:07 +0200, Jani Nikula wrote: > Avoid forward declarations in subsequent changes, but separate this > movement to an independent change. > > Signed-off-by: Jani Nikula > --- > include/drm/drm_print.h | 190 > 1 file changed, 95 ins

Re: [PATCH 01/10] drm/print: make drm_err_printer() device specific by using drm_err()

2024-01-30 Thread Luca Coelho
On Tue, 2024-01-16 at 15:07 +0200, Jani Nikula wrote: > With few users for drm_err_printer(), it's still feasible to convert it > to be device specific. Use drm_err() under the hood. > > While at it, make the prefix optional. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_print.c

Re: [Linaro-mm-sig] Re: [PATCH v5 1/6] dma-buf: Add dma_buf_{begin,end}_access()

2024-01-30 Thread Daniel Vetter
On Tue, Jan 30, 2024 at 10:48:23AM +0100, Paul Cercueil wrote: > Le mardi 30 janvier 2024 à 10:23 +0100, Christian König a écrit : > >  I would say we start with the DMA-API by getting away from sg_tables > > to something cleaner and state oriented.  > > FYI I am already adding a 'dma_vec' object

Re: [PATCH v3 3/3] drm/amdgpu: Implement check_async_props for planes

2024-01-30 Thread Daniel Vetter
On Sun, Jan 28, 2024 at 06:25:15PM -0300, André Almeida wrote: > AMD GPUs can do async flips with changes on more properties than just > the FB ID, so implement a custom check_async_props for AMD planes. > > Allow amdgpu to do async flips with overlay planes as well. > > Signed-off-by: André Alme

[drm-misc:drm-misc-next 1/3] ps3av.c:undefined reference to `video_get_options'

2024-01-30 Thread kernel test robot
/archive/20240130/202401301825.pvnlzurt-...@intel.com/config) compiler: powerpc64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240130/202401301825.pvnlzurt-...@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new

Re: [PATCH v3 3/3] drm/amdgpu: Implement check_async_props for planes

2024-01-30 Thread Simon Ser
> Do we really need this much flexibility, especially for the first driver > adding the first few additional properties? AFAIU we'd like to allow more props as well, e.g. cursor position…

Re: [PATCH v2 1/1] drm/virtio: Implement device_attach

2024-01-30 Thread Daniel Vetter
On Mon, Jan 29, 2024 at 06:31:19PM +0800, Julia Zhang wrote: > As vram objects don't have backing pages and thus can't implement > drm_gem_object_funcs.get_sg_table callback. This removes drm dma-buf > callbacks in virtgpu_gem_map_dma_buf()/virtgpu_gem_unmap_dma_buf() > and implement virtgpu specif

Re: Implement per-key keyboard backlight as auxdisplay?

2024-01-30 Thread Werner Sembach
Hi Hans, Am 29.01.24 um 14:24 schrieb Hans de Goede: Hi Werner, On 1/19/24 17:04, Werner Sembach wrote: Am 19.01.24 um 09:44 schrieb Hans de Goede: So my proposal would be an ioctl interface (ioctl only no r/w) using /dev/rgbkbd0 /dev/rgbkdb1, etc. registered as a misc chardev. For per ke

Re: [PATCH v2 1/1] drm/virtio: Implement device_attach

2024-01-30 Thread Daniel Vetter
On Tue, Jan 30, 2024 at 12:10:31PM +0100, Daniel Vetter wrote: > On Mon, Jan 29, 2024 at 06:31:19PM +0800, Julia Zhang wrote: > > As vram objects don't have backing pages and thus can't implement > > drm_gem_object_funcs.get_sg_table callback. This removes drm dma-buf > > callbacks in virtgpu_gem_m

Re: [PATCH v7 1/9] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill

2024-01-30 Thread Thomas Zimmermann
Hi Am 23.01.24 um 15:56 schrieb Jocelyn Falempe: On 23/01/2024 13:56, Thomas Zimmermann wrote: Hi, FYI for points 1 and 2, I'm typing up a patchset that introduces drm_pixmap for the source buffer. I'll post it when I have something ready. Thanks, I didn't have time to look into this yet

[PATCH v5 0/2] Small runtime PM API changes

2024-01-30 Thread Sakari Ailus
Hi folks, Here's a small but a different set of patches for making two relatively minor changes to runtime PM API. I restarted version numbering as this is meaningfully different from the previous set. pm_runtime_get_if_active() loses its second argument as it only made sense to have ign_usage_co

[PATCH v5 1/2] PM: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-30 Thread Sakari Ailus
There are two ways to opportunistically increment a device's runtime PM usage count, calling either pm_runtime_get_if_active() or pm_runtime_get_if_in_use(). The former has an argument to tell whether to ignore the usage count or not, and the latter simply calls the former with ign_usage_count set

Flaky tests for amdgpu

2024-01-30 Thread Vignesh Raman
Hi Maintainers, There are some flaky tests reported for amdgpu driver testing in drm-ci. # Board Name: hp-11A-G6-EE-grunt # IGT Version: 1.28-gb0cc8160e # Linux Version: 6.7.0-rc3 Pipeline url: https://gitlab.freedesktop.org/vigneshraman/linux/-/jobs/54373774 # Reported by deqp-runner amdgpu/a

[PATCH v6 0/4] usb: gadget: functionfs: DMABUF import interface

2024-01-30 Thread Paul Cercueil
Hi, This is the v6 of my patchset that adds a new DMABUF import interface to FunctionFS. Given that the cache coherency issue that has been discussed after my v5 is a tangential problem and not directly related to this new interface, I decided to drop the dma_buf_begin/end_access() functions for

[PATCH v6 1/4] usb: gadget: Support already-mapped DMA SGs

2024-01-30 Thread Paul Cercueil
Add a new 'sg_was_mapped' field to the struct usb_request. This field can be used to indicate that the scatterlist associated to the USB transfer has already been mapped into the DMA space, and it does not have to be done internally. Signed-off-by: Paul Cercueil --- drivers/usb/gadget/udc/core.c

[PATCH v6 2/4] usb: gadget: functionfs: Factorize wait-for-endpoint code

2024-01-30 Thread Paul Cercueil
This exact same code was duplicated in two different places. Signed-off-by: Paul Cercueil --- drivers/usb/gadget/function/f_fs.c | 48 +- 1 file changed, 27 insertions(+), 21 deletions(-) diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/

[PATCH v6 3/4] usb: gadget: functionfs: Add DMABUF import interface

2024-01-30 Thread Paul Cercueil
This patch introduces three new ioctls. They all should be called on a data endpoint (ie. not ep0). They are: - FUNCTIONFS_DMABUF_ATTACH, which takes the file descriptor of a DMABUF object to attach to the endpoint. - FUNCTIONFS_DMABUF_DETACH, which takes the file descriptor of the DMABUF to

[PATCH v6 4/4] Documentation: usb: Document FunctionFS DMABUF API

2024-01-30 Thread Paul Cercueil
Add documentation for the three ioctls used to attach or detach externally-created DMABUFs, and to request transfers from/to previously attached DMABUFs. Signed-off-by: Paul Cercueil --- v3: New patch --- Documentation/usb/functionfs.rst | 36 1 file changed, 36

Re: [PATCH 5/8] firmware/sysfb: Create firmware device only for enabled PCI devices

2024-01-30 Thread Thomas Zimmermann
Hi Am 29.01.24 um 12:36 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Test if the firmware framebuffer's parent PCI device, if any, has been enabled. If not, the firmware framebuffer is most likely not working. Hence, do not create a device for the firmware framebuffer on disabl

Re: [Linaro-mm-sig] Re: [PATCH v5 1/6] dma-buf: Add dma_buf_{begin,end}_access()

2024-01-30 Thread Christian König
Am 30.01.24 um 11:40 schrieb Daniel Vetter: On Tue, Jan 30, 2024 at 10:48:23AM +0100, Paul Cercueil wrote: Le mardi 30 janvier 2024 à 10:23 +0100, Christian König a écrit :  I would say we start with the DMA-API by getting away from sg_tables to something cleaner and state oriented. FYI I am

Re: [PATCH 1/8] video: Add helpers for decoding screen_info

2024-01-30 Thread Thomas Zimmermann
Hi Am 29.01.24 um 11:41 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, The plain values as stored in struct screen_info need to be decoded before being used. Add helpers that decode the type of video output and the framebuffer I/O aperture. Old or non-x86 systems

Re: [PATCH v2 1/1] drm/virtio: Implement device_attach

2024-01-30 Thread Christian König
Am 30.01.24 um 12:16 schrieb Daniel Vetter: On Tue, Jan 30, 2024 at 12:10:31PM +0100, Daniel Vetter wrote: On Mon, Jan 29, 2024 at 06:31:19PM +0800, Julia Zhang wrote: As vram objects don't have backing pages and thus can't implement drm_gem_object_funcs.get_sg_table callback. This removes drm

Re: [PATCH] drm/xe: Fix a build error

2024-01-30 Thread Christian König
Am 29.01.24 um 21:25 schrieb Thomas Hellström: Hi, On 1/29/24 17:48, Christian König wrote: Am 27.01.24 um 16:53 schrieb Oak Zeng: This fixes a build failure on drm-tip. This issue was introduced during merge of "drm/ttm: replace busy placement with flags v6". For some reason, the xe_bo.c part

Re: [PATCH] drm/xe: Fix a build error

2024-01-30 Thread Thomas Hellström
On 1/30/24 15:31, Christian König wrote: Am 29.01.24 um 21:25 schrieb Thomas Hellström: Hi, On 1/29/24 17:48, Christian König wrote: Am 27.01.24 um 16:53 schrieb Oak Zeng: This fixes a build failure on drm-tip. This issue was introduced during merge of "drm/ttm: replace busy placement with

Re: [GIT PULL] Enable -Wstringop-overflow globally

2024-01-30 Thread Thomas Hellström
Hi, On 1/27/24 20:53, Gustavo A. R. Silva wrote: On 1/27/24 09:11, David Laight wrote: From: Linus Torvalds Sent: 26 January 2024 22:36 On Fri, 26 Jan 2024 at 14:24, Kees Cook wrote: I think xe has some other weird problems too. This may be related (under allocating): ../drivers/gpu/d

[PATCH v1 1/6] dt-bindings: display: rockchip: rockchip,dw-hdmi: deprecate port property

2024-01-30 Thread Johan Jonker
The hdmi-connector nodes are now functional and the new way to model hdmi nodes with, so deprecate the port property and make port@0 and port@1 a requirement. Also update example. Signed-off-by: Johan Jonker --- .../display/rockchip/rockchip,dw-hdmi.yaml| 27 --- 1 file chang

[PATCH v1 2/6] dt-bindings: display: rockchip,dw-hdmi: add power-domains property

2024-01-30 Thread Johan Jonker
Most Rockchip hdmi nodes are part of a power domain. Add a power-domains property. Fix example. Signed-off-by: Johan Jonker --- .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings

[PATCH v1 3/6] ARM: dts: rockchip: fix rk3288 hdmi ports node

2024-01-30 Thread Johan Jonker
Fix rk3288 hdmi ports node so that it matches the rockchip,dw-hdmi.yaml binding. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rockchip/rk3288.dtsi | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/rockchip/rk3288.dtsi b/arch/arm/boot/

[PATCH v1 4/6] ARM: dts: rockchip: fix rk322x hdmi ports node

2024-01-30 Thread Johan Jonker
Fix rk322x hdmi ports node so that it matches the rockchip,dw-hdmi.yaml binding. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rockchip/rk322x.dtsi | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/rockchip/rk322x.dtsi b/arch/arm/boot/

[PATCH v1 5/6] arm64: dts: rockchip: fix rk3328 hdmi ports node

2024-01-30 Thread Johan Jonker
Fix rk3328 hdmi ports node so that it matches the rockchip,dw-hdmi.yaml binding. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot

[PATCH v1 6/6] arm64: dts: rockchip: fix rk3399 hdmi ports node

2024-01-30 Thread Johan Jonker
Fix rk3399 hdmi ports node so that it matches the rockchip,dw-hdmi.yaml binding. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/

[PATCH v3 0/9] drm/ci: Add support for GPU and display testing

2024-01-30 Thread Vignesh Raman
Some ARM SOCs have a separate display controller and GPU, each with different drivers. For mediatek mt8173, the GPU driver is powervr, and the display driver is mediatek. In the case of mediatek mt8183, the GPU driver is panfrost, and the display driver is mediatek. With rockchip rk3288/rk3399, the

[PATCH v3 3/9] drm/ci: mediatek: Add job to test panfrost and powervr GPU driver

2024-01-30 Thread Vignesh Raman
For mediatek mt8173, the GPU driver is powervr and for mediatek mt8183, the GPU driver is panfrost. So add support in drm-ci to test panfrost and powervr GPU driver for mediatek SOCs and update xfails. Powervr driver was merged in linux kernel, but there's no mediatek support yet. So disable the mt

[PATCH v3 4/9] drm/ci: meson: Rename exisitng job

2024-01-30 Thread Vignesh Raman
For Amlogic Meson SOC the display driver is meson. Currently, in drm-ci for meson, only the display driver is tested. So rename the meson job to indicate that display driver is tested. Rename the name of xfail files for meson (g12b), to include information about the tested driver and update xfails

[PATCH v3 5/9] drm/ci: meson: Add job to test panfrost GPU driver

2024-01-30 Thread Vignesh Raman
For amlogic meson SOC the GPU driver is panfrost. So add support in drm-ci to test panfrost driver for amlogic meson SOC and update xfails. Skip KMS tests for panfrost driver since it is not a not a KMS driver. Signed-off-by: Vignesh Raman --- v2: - Add panfrost GPU jobs for amlogic meson SOC

[PATCH v3 1/9] drm/ci: arm64.config: Enable CONFIG_DRM_ANALOGIX_ANX7625

2024-01-30 Thread Vignesh Raman
Enable CONFIG_DRM_ANALOGIX_ANX7625 in the arm64 defconfig to get display driver probed on the mt8183-kukui-jacuzzi-juniper machine. arch/arm64/configs/defconfig has CONFIG_DRM_ANALOGIX_ANX7625=m, but drm-ci don't have initrd with modules, so add CONFIG_DRM_ANALOGIX_ANX7625=y in CI arm64 config. S

[PATCH v3 7/9] drm/ci: rockchip: Add job to test panfrost GPU driver

2024-01-30 Thread Vignesh Raman
For rockchip rk3288 and rk3399, the GPU driver is panfrost. So add support in drm-ci to test panfrost driver for rockchip SOC and update xfails. Skip KMS tests for panfrost driver since it is not a not a KMS driver. Signed-off-by: Vignesh Raman --- v2: - Add panfrost GPU jobs for rockchip SOC

[PATCH v3 2/9] drm/ci: mediatek: Rename exisitng job

2024-01-30 Thread Vignesh Raman
For mediatek mt8173 and mt8183, the display driver is mediatek. Currently, in drm-ci for mediatek, only the display driver is tested. So rename the mediatek job to indicate that display driver is tested. Rename the name of xfail files for mediatek (mt8173 and mt8183), to include information about t

[PATCH v3 6/9] drm/ci: rockchip: Rename existing job

2024-01-30 Thread Vignesh Raman
For rockchip rk3288 and rk3399, the display driver is rockchip. Currently, in drm-ci for rockchip, only the display driver is tested. So rename the rockchip job to indicate that display driver is tested. Rename the name of xfail files for rockchip (rk3288 and rk3399), to include information about

[PATCH v3 8/9] drm/ci: uprev mesa version

2024-01-30 Thread Vignesh Raman
zlib.net is not allowing tarball download anymore and results in below error in kernel+rootfs_arm32 container build, urllib.error.HTTPError: HTTP Error 403: Forbidden urllib.error.HTTPError: HTTP Error 415: Unsupported Media Type Uprev mesa which includes a fix for this issue. https://gitlab.freed

[PATCH v3 9/9] drm/ci: uprev IGT and update testlist

2024-01-30 Thread Vignesh Raman
Uprev IGT and add amd, v3d, vc4 and vgem specific tests to testlist. Have testlist.txt per driver and include a base testlist so that the driver specific tests will run only on those hardware. Signed-off-by: Vignesh Raman --- v3: - New patch in series to uprev IGT and update testlist. --- dr

Re: [drm-drm-misc:drm-misc-next] dt-bindings: nt35510: document 'port' property

2024-01-30 Thread Rob Herring
On Sat, Jan 27, 2024 at 04:28:08PM +0100, Dario Binacchi wrote: > Allow 'port' property (coming from panel-common.yaml) to be used in DTS: > > st/stm32f769-disco-mb1166-reva09.dtb: panel@0: 'port' does not match any of > the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Dario Binacchi > Cc: Al

Re: [PATCH v4 0/3] Convert Microchip's HLCDC Text based DT bindings to JSON schema

2024-01-30 Thread Conor Dooley
On Tue, Jan 30, 2024 at 06:42:04AM +, dharm...@microchip.com wrote: > Hi Conor, > > On 24/01/24 10:10 pm, Conor Dooley wrote: > > On Wed, Jan 24, 2024 at 03:30:16PM +0530, Dharma Balasubiramani wrote: > >> Converted the text bindings to YAML and validated them individually using > >> followin

Re: [PATCH V2 2/2] phy: freescale: add Samsung HDMI PHY

2024-01-30 Thread Vinod Koul
Hi Adam, On 06-01-24, 16:19, Adam Ford wrote: > From: Lucas Stach > > This adds the driver for the Samsung HDMI PHY found on the > i.MX8MP SoC. > > Signed-off-by: Lucas Stach > Signed-off-by: Adam Ford > --- > V2: Fixed some whitespace found from checkpatch > Change error handling when

[PATCH 0/6 V3] fdinfo shared stats

2024-01-30 Thread Alex Deucher
We had a request to add shared buffer stats to fdinfo for amdgpu and while implementing that, Christian mentioned that just looking at the GEM handle count doesn't take into account buffers shared with other subsystems like V4L or RDMA. Those subsystems don't use GEM, so it doesn't really matter f

  1   2   >