[PATCH v7 0/6] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios (v7)

2023-12-12 Thread Vivek Kasireddy
The first two patches were previously reviewed but not yet merged. These ones need to be merged first as the fourth patch depends on the changes introduced in them and they also fix bugs seen in very specific scenarios (running Qemu with hugetlb=on, blob=true and rebooting guest VM). The third pat

[PATCH v7 4/6] udmabuf: Convert udmabuf driver to use folios

2023-12-12 Thread Vivek Kasireddy
This is mainly a preparatory patch to use memfd_pin_folios() API for pinning folios. Using folios instead of pages makes sense as the udmabuf driver needs to handle both shmem and hugetlb cases. However, the function vmap_udmabuf() still needs a list of pages; so, we collect all the head pages into

[PATCH v7 1/6] udmabuf: Use vmf_insert_pfn and VM_PFNMAP for handling mmap

2023-12-12 Thread Vivek Kasireddy
Add VM_PFNMAP to vm_flags in the mmap handler to ensure that the mappings would be managed without using struct page. And, in the vm_fault handler, use vmf_insert_pfn to share the page's pfn to userspace instead of directly sharing the page (via struct page *). Cc: David Hildenbrand Cc: Daniel V

[PATCH v7 3/6] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios (v7)

2023-12-12 Thread Vivek Kasireddy
For drivers that would like to longterm-pin the folios associated with a memfd, the memfd_pin_folios() API provides an option to not only pin the folios via FOLL_PIN but also to check and migrate them if they reside in movable zone or CMA block. This API currently works with memfds but it should wo

[PATCH v7 2/6] udmabuf: Add back support for mapping hugetlb pages (v6)

2023-12-12 Thread Vivek Kasireddy
A user or admin can configure a VMM (Qemu) Guest's memory to be backed by hugetlb pages for various reasons. However, a Guest OS would still allocate (and pin) buffers that are backed by regular 4k sized pages. In order to map these buffers and create dma-bufs for them on the Host, we first need to

[PATCH v7 5/6] udmabuf: Pin the pages using memfd_pin_folios() API (v5)

2023-12-12 Thread Vivek Kasireddy
Using memfd_pin_folios() will ensure that the pages are pinned correctly using FOLL_PIN. And, this also ensures that we don't accidentally break features such as memory hotunplug as it would not allow pinning pages in the movable zone. Using this new API also simplifies the code as we no longer ha

[PATCH v7 6/6] selftests/dma-buf/udmabuf: Add tests to verify data after page migration

2023-12-12 Thread Vivek Kasireddy
Since the memfd pages associated with a udmabuf may be migrated as part of udmabuf create, we need to verify the data coherency after successful migration. The new tests added in this patch try to do just that using 4k sized pages and also 2 MB sized huge pages for the memfd. Successful completion

Re: [net-next v1 02/16] net: page_pool: create hooks for custom page providers

2023-12-12 Thread Ilias Apalodimas
Hi Mina, Apologies for not participating in the party earlier. On Fri, 8 Dec 2023 at 02:52, Mina Almasry wrote: > > From: Jakub Kicinski > > The page providers which try to reuse the same pages will > need to hold onto the ref, even if page gets released from > the pool - as in releasing the pa

Re: [Intel-gfx] [drm-intel:drm-intel-gt-next] [drm/i915] [confidence: ] 9bb66c179f: assertion_failure

2023-12-12 Thread Oliver Sang
hi, Jani, On Fri, Dec 08, 2023 at 11:59:43AM +0200, Jani Nikula wrote: > On Thu, 07 Dec 2023, kernel test robot wrote: > > Hello, > > > > kernel test robot noticed "assertion_failure" on: > > > > commit: 9bb66c179f50e61df20ba13c9b34ca17d00b05fb ("drm/i915: Reserve some > > kernel space per vm")

Re: [net-next v1 01/16] net: page_pool: factor out releasing DMA from releasing the page

2023-12-12 Thread Ilias Apalodimas
On Fri, 8 Dec 2023 at 02:52, Mina Almasry wrote: > > From: Jakub Kicinski > > Releasing the DMA mapping will be useful for other types > of pages, so factor it out. Make sure compiler inlines it, > to avoid any regressions. > > Signed-off-by: Jakub Kicinski > Signed-off-by: Mina Almasry > > ---

Re: [PATCH 1/2] drm/bridge: samsung-dsim: Set P divider based on min/max of fin pll

2023-12-12 Thread Frieder Schrempf
Hi Adam, On 12.12.23 04:32, Adam Ford wrote: > The P divider should be set based on the min and max values of > the fin pll which may vary between different platforms. > These ranges are defined per platform, but hard-coded values > were used instead which resulted in a smaller range available > o

[PATCH v8 1/6] pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()

2023-12-12 Thread Sean Young
In order to introduce a pwm api which can be used from atomic context, we will need two functions for applying pwm changes: int pwm_apply_might_sleep(struct pwm *, struct pwm_state *); int pwm_apply_atomic(struct pwm *, struct pwm_state *); This commit just deals with renaming pwm

Re: [PATCH v2 0/7] IOMMU related FW parsing cleanup

2023-12-12 Thread Joerg Roedel
On Thu, Dec 07, 2023 at 02:03:07PM -0400, Jason Gunthorpe wrote: > Jason Gunthorpe (7): > iommu: Remove struct iommu_ops *iommu from arch_setup_dma_ops() > iommmu/of: Do not return struct iommu_ops from of_iommu_configure() > iommu/of: Use -ENODEV consistently in of_iommu_configure() > iomm

Re: [PATCH v3 07/15] drm/msm/dpu: add dpu_hw_cdm abstraction for CDM block

2023-12-12 Thread Dmitry Baryshkov
On Tue, 12 Dec 2023 at 02:23, Abhinav Kumar wrote: > > CDM block comes with its own set of registers and operations > which can be done. In-line with other hardware blocks, this > change adds the dpu_hw_cdm abstraction for the CDM block. > > changes in v3: > - fix commit text from sub-blk

Re: [PATCH v2 1/8] dt-bindings: display: msm: dp: declare compatible string for sm8150

2023-12-12 Thread Krzysztof Kozlowski
On 11/12/2023 16:44, Dmitry Baryshkov wrote: > Add compatible string for the DisplayPort controller found on the > Qualcomm SM8150 platform. > > Signed-off-by: Dmitry Baryshkov > --- DT list... Best regards, Krzysztof

Re: [PATCH v2 1/8] dt-bindings: display: msm: dp: declare compatible string for sm8150

2023-12-12 Thread Dmitry Baryshkov
On Tue, 12 Dec 2023 at 12:09, Krzysztof Kozlowski wrote: > > On 11/12/2023 16:44, Dmitry Baryshkov wrote: > > Add compatible string for the DisplayPort controller found on the > > Qualcomm SM8150 platform. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > DT list... Yes... -- With best wishe

Re: [PATCH 1/2] drm/bridge: samsung-dsim: Set P divider based on min/max of fin pll

2023-12-12 Thread Adam Ford
c team, the one customer should be take into account is the Table 13-40 DPHY PLL Parameters and the Note above." adam [1] - https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/drivers/gpu/drm/imx/sec_mipi_pll_1432x.h#L38C1-L47C1 [2] - https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/gpu/drm/bridge/samsung-dsim.c?h=next-20231212&id=54f1a83c72250b182fa7722b0c5f6eb5e769598d > > Thanks > Frieder > > > > > for (_p = p_min; _p <= p_max; ++_p) { > > for (_s = 0; _s <= 5; ++_s) { >

Re: [PATCH 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2023-12-12 Thread Adam Ford
On Mon, Dec 11, 2023 at 9:33 PM Adam Ford wrote: > > When using video sync pulses, the HFP, HBP, and HSA are divided between > the available lanes if there is more than one lane. For certain > timings and lane configurations, the HFP may not be evenly divisible. > If the HFP is rounded down, it e

Re: [RFC] drm/i915: Allow dmabuf mmap forwarding

2023-12-12 Thread Tvrtko Ursulin
On 25/09/2023 14:16, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Allow mmap forwarding for imported buffers in order to allow minigbm mmap to work on aperture-less platforms such as Meteorlake. So far i915 did not allow mmap on imported buffers but from minigbm perspective that worked because

Re: [net-next v1 09/16] page_pool: device memory support

2023-12-12 Thread Yunsheng Lin
On 2023/12/12 2:14, Mina Almasry wrote: > On Mon, Dec 11, 2023 at 3:51 AM Yunsheng Lin wrote: >> >> On 2023/12/11 12:04, Mina Almasry wrote: >>> On Sun, Dec 10, 2023 at 6:26 PM Mina Almasry wrote: On Sun, Dec 10, 2023 at 6:04 PM Yunsheng Lin wrote: > > On 2023/12/9 0:05,

Re: [PATCH v5 18/44] drm/vc4: hdmi: Create destroy state implementation

2023-12-12 Thread Dave Stevenson
On Thu, 7 Dec 2023 at 15:50, Maxime Ripard wrote: > > Even though we were rolling our own custom state for the vc4 HDMI > controller driver, we were still using the generic helper to destroy > that state. > > It was mostly working since the underlying state is the first member of > our state so th

Re: [PATCH v8 1/6] pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()

2023-12-12 Thread Uwe Kleine-König
On Tue, Dec 12, 2023 at 08:34:00AM +, Sean Young wrote: > In order to introduce a pwm api which can be used from atomic context, > we will need two functions for applying pwm changes: > > int pwm_apply_might_sleep(struct pwm *, struct pwm_state *); > int pwm_apply_atomic(struct pwm

Re: [PATCH v7 3/6] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios (v7)

2023-12-12 Thread David Hildenbrand
On 12.12.23 08:38, Vivek Kasireddy wrote: For drivers that would like to longterm-pin the folios associated with a memfd, the memfd_pin_folios() API provides an option to not only pin the folios via FOLL_PIN but also to check and migrate them if they reside in movable zone or CMA block. This API

Re: [PATCH v7 0/6] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios (v7)

2023-12-12 Thread David Hildenbrand
On 12.12.23 08:37, Vivek Kasireddy wrote: The first two patches were previously reviewed but not yet merged. These ones need to be merged first as the fourth patch depends on the changes introduced in them and they also fix bugs seen in very specific scenarios (running Qemu with hugetlb=on, blob=

[PATCH v4 08/17] drm/mediatek: Support alpha blending in display driver

2023-12-12 Thread Hsiao Chien Sung
Support alpha blending by adding correct blend mode and alpha property in plane initialization. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/dr

[PATCH v4 11/17] drm/mediatek: Turn off the layers with zero width or height

2023-12-12 Thread Hsiao Chien Sung
We found that IGT (Intel GPU Tool) will try to commit layers with zero width or height and lead to undefined behaviors in hardware. Disable the layers in such situations. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 2 +- drivers/gpu/drm/mediatek/mtk_ethd

[PATCH v4 00/17] Support IGT in display driver

2023-12-12 Thread Hsiao Chien Sung
This series is based on mediatek-drm-next. This series adds support for running IGT (Intel GPU Tool) tests with MediaTek display driver. The following changes will be applied: 1. Add a new API for creating GCE thread loop to retrieve CRCs from the hardware component 2. Support hardware CRC cal

[PATCH v4 04/17] drm/mediatek: Add OVL compatible name for MT8195

2023-12-12 Thread Hsiao Chien Sung
Add OVL compatible name for MT8195. Without this commit, DRM won't work after modifying the device tree. Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b

[PATCH v4 07/17] drm/mediatek: Support alpha blending in Mixer

2023-12-12 Thread Hsiao Chien Sung
Support premultiply and coverage alpha blending in Mixer. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ethdr.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_ethdr.c b/drivers/gpu/drm/mediatek/mtk_

[PATCH v4 10/17] drm/mediatek: Support more color formats in OVL

2023-12-12 Thread Hsiao Chien Sung
Support more color formats in Overlay. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c index 7e217142d0c4..a3f1630a

[PATCH v4 05/17] drm/mediatek: Set DRM mode configs accordingly

2023-12-12 Thread Hsiao Chien Sung
Set DRM mode configs limitation accroding to the hardware capabilities. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 28 ++ drivers/gpu/drm/mediatek/mtk_drm_drv.h | 1 + 2 files changed, 21 insertions(+), 8 deletions(-) diff --git a/drive

[PATCH v4 14/17] drm/mediatek: Support CRC in OVL adaptor

2023-12-12 Thread Hsiao Chien Sung
We choose Mixer as CRC generator in OVL adaptor since its frame done event will trigger vblanks, we can know when is safe to retrieve CRC of the frame. In OVL adaptor, there's no image procession after Mixer, unlike the OVL in VDOSYS0, Mixer's CRC will include all the effects that are applied to t

[PATCH v4 06/17] drm/mediatek: Support alpha blending in OVL

2023-12-12 Thread Hsiao Chien Sung
Support premultiply and coverage alpha blending in Overlay. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 73 + 1 file changed, 51 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/media

[PATCH v4 12/17] drm/mediatek: Support CRC in display driver

2023-12-12 Thread Hsiao Chien Sung
Register CRC related function pointers to support CRC retrieval. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 239 drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 39 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 3 + 3 files change

[PATCH v4 16/17] drm/mediatek: Fix errors when reporting rotation capability

2023-12-12 Thread Hsiao Chien Sung
Create rotation property according to the hardware capability. Since currently OVL of all chips support same rotation, no need to define it in the driver data. Fixes: 84d805753983 ("drm/mediatek: Support reflect-y plane rotation") Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chi

[PATCH v4 09/17] drm/mediatek: Support CSC in OVL

2023-12-12 Thread Hsiao Chien Sung
Support Color Transform Control (CSC) in Overlay to do Y2R or R2R conversion. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 121 +++- 1 file changed, 118 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/dri

[PATCH v4 02/17] soc: mediatek: Disable 9-bit alpha in ETHDR

2023-12-12 Thread Hsiao Chien Sung
ETHDR 9-bit alpha should be disabled by default, otherwise alpha blending will not work. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/soc/mediatek/mtk-mmsys.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/s

[PATCH v4 01/17] soc: mediatek: Add register definitions for GCE

2023-12-12 Thread Hsiao Chien Sung
Add register definitions for GCE so users can use them as a buffer to store data. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- include/linux/soc/mediatek/mtk-cmdq.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/linux/soc/mediatek/mtk-cmd

[PATCH v4 17/17] drm/mediatek: Add comments for the structures

2023-12-12 Thread Hsiao Chien Sung
Add comments for the structures to improve readability. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 21 +- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 22 -- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 32 + dr

[PATCH v4 13/17] drm/mediatek: Support CRC in OVL

2023-12-12 Thread Hsiao Chien Sung
We choose OVL as the CRC generator from other hardware components that are also capable of calculating CRCs, since its frame done event triggers vblanks, it can be used as a signal to know when is safe to retrieve CRC of the frame. Please note that position of the hardware component that is chosen

[PATCH v4 03/17] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188

2023-12-12 Thread Hsiao Chien Sung
Modify rules for both MT8195 and MT8188. Hardware capabilities include color formats and AFBC are changed since MT8195, stop using the settings of MT8183. Acked-by: Rob Herring Signed-off-by: Hsiao Chien Sung --- .../bindings/display/mediatek/mediatek,ovl.yaml | 12 +--- 1 file cha

[PATCH v4 15/17] drm/mediatek: Add missing plane settings when async update

2023-12-12 Thread Hsiao Chien Sung
Fix an issue that plane coordinate was not saved when calling async update. Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update") Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_plane

Re: [net-next v1 08/16] memory-provider: dmabuf devmem memory provider

2023-12-12 Thread Jason Gunthorpe
On Thu, Dec 07, 2023 at 04:52:39PM -0800, Mina Almasry wrote: > +static inline struct page_pool_iov *page_to_page_pool_iov(struct page *page) > +{ > + if (page_is_page_pool_iov(page)) > + return (struct page_pool_iov *)((unsigned long)page & ~PP_IOV); > + > + DEBUG_NET_WARN_ON_

Re: [PATCH] fbdev: hgafb: fix kernel-doc comments

2023-12-12 Thread Helge Deller
On 12/6/23 00:14, Randy Dunlap wrote: Fix kernel-doc warnings found when using "W=1". hgafb.c:370: warning: No description found for return value of 'hgafb_open' hgafb.c:384: warning: No description found for return value of 'hgafb_release' hgafb.c:406: warning: No description found for return v

Re: [PATCH v7 3/6] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios (v7)

2023-12-12 Thread kernel test robot
Hi Vivek, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Vivek-Kasireddy/udmabuf-Use-vmf_insert_pfn-and-VM_PFNMAP-for-handling-mmap/20231212-160312 base: https://git.kernel.org/pub

[PATCH 1/2] drm/edid: replace __attribute__((packed)) with __packed

2023-12-12 Thread Jani Nikula
__packed is preferred over __attribute__((packed)). Signed-off-by: Jani Nikula --- include/drm/drm_edid.h | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h index 518d1b8106c7..54cc6f04a708 100644

[PATCH 2/2] drm/ioc32: replace __attribute__((packed)) with __packed

2023-12-12 Thread Jani Nikula
__packed is preferred over __attribute__((packed)). Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_ioc32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_ioc32.c b/drivers/gpu/drm/drm_ioc32.c index 129e2b91dbfe..e6b5b06de148 100644 --- a/drivers/g

Re: [PATCH 1/2] fbdev: Remove support for Carillo Ranch driver

2023-12-12 Thread Helge Deller
On 12/8/23 23:47, Matthew Wilcox (Oracle) wrote: As far as anybody can tell, this product never shipped. If it did, it shipped in 2007 and nobody has access to one any more. Remove the fbdev driver and the backlight driver. Signed-off-by: Matthew Wilcox (Oracle) --- drivers/video/backlight/

Re: [PATCH v4 05/17] drm/mediatek: Set DRM mode configs accordingly

2023-12-12 Thread AngeloGioacchino Del Regno
Il 12/12/23 13:19, Hsiao Chien Sung ha scritto: Set DRM mode configs limitation accroding to the hardware capabilities. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 28 ++ drivers/gpu/drm/mediatek/mtk_drm_drv.h | 1 + 2 files changed,

Re: [PATCH v4 11/17] drm/mediatek: Turn off the layers with zero width or height

2023-12-12 Thread AngeloGioacchino Del Regno
Il 12/12/23 13:19, Hsiao Chien Sung ha scritto: We found that IGT (Intel GPU Tool) will try to commit layers with zero width or height and lead to undefined behaviors in hardware. Disable the layers in such situations. Signed-off-by: Hsiao Chien Sung This commit needs a Fixes tag. Please add

Re: [PATCH v4 03/17] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188

2023-12-12 Thread AngeloGioacchino Del Regno
Il 12/12/23 13:19, Hsiao Chien Sung ha scritto: Modify rules for both MT8195 and MT8188. Hardware capabilities include color formats and AFBC are changed since MT8195, stop using the settings of MT8183. Acked-by: Rob Herring Signed-off-by: Hsiao Chien Sung Reviewed-by: AngeloGioacchino Del R

Re: [PATCH v4 04/17] drm/mediatek: Add OVL compatible name for MT8195

2023-12-12 Thread AngeloGioacchino Del Regno
Il 12/12/23 13:19, Hsiao Chien Sung ha scritto: Add OVL compatible name for MT8195. Without this commit, DRM won't work after modifying the device tree. Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v4 17/17] drm/mediatek: Add comments for the structures

2023-12-12 Thread AngeloGioacchino Del Regno
Il 12/12/23 13:19, Hsiao Chien Sung ha scritto: Add comments for the structures to improve readability. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 21 +- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 22 -- drivers/gpu/drm/media

[PATCH] drm/amd: include drm/drm_edid.h only where needed

2023-12-12 Thread Jani Nikula
Including drm_edid.h from amdgpu_mode.h causes the rebuild of literally hundreds of files when drm_edid.h is modified, while there are only a handful of files that actually need to include drm_edid.h. Signed-off-by: Jani Nikula --- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h| 2

[PATCH] drm/radeon: include drm/drm_edid.h only where needed

2023-12-12 Thread Jani Nikula
Including drm_edid.h from radeon_mode.h causes the rebuild of more than a hundred files when drm_edid.h is modified, while there are only a handful of files that actually need to include drm_edid.h. Signed-off-by: Jani Nikula --- drivers/gpu/drm/radeon/atombios_encoders.c | 1 + drivers/gpu/drm/

[PATCH] drm/nouveau: include drm/drm_edid.h only where needed

2023-12-12 Thread Jani Nikula
Including drm_edid.h from nouveau_connector.h causes the rebuild of 15 files when drm_edid.h is modified, while there are only a few files that actually need to include drm_edid.h. Signed-off-by: Jani Nikula --- drivers/gpu/drm/nouveau/dispnv50/head.c | 1 + drivers/gpu/drm/nouveau/nouveau_c

Re: [RFC] drm/i915: Allow dmabuf mmap forwarding

2023-12-12 Thread Christian König
Hi Tvrtko, Thanks for pointing this mail out once more, I've totally missed it. Am 12.12.23 um 11:37 schrieb Tvrtko Ursulin: On 25/09/2023 14:16, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Allow mmap forwarding for imported buffers in order to allow minigbm mmap to work on aperture-less p

[PATCH] fbdev/clcd: Delete the old CLCD driver

2023-12-12 Thread Linus Walleij
We have managed to ascertain that all users of the old FBDEV code that are out of tree are now gone. The new DRM driver can be found in drivers/gpu/drm/pl111/. The remaining out of tree user was the ARM FVP emulation platform, running Android. Thanks to changes in Android versions 13 and 14, Andr

[PATCH] drm/tegra: include drm/drm_edid.h only where needed

2023-12-12 Thread Jani Nikula
Reduce the need for rebuilds when drm_edid.h is modified by including it only where needed. Signed-off-by: Jani Nikula --- drivers/gpu/drm/tegra/drm.h| 2 +- drivers/gpu/drm/tegra/output.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/drm.h b/driv

[PATCH] drm/hisilicon: include drm/drm_edid.h only where needed

2023-12-12 Thread Jani Nikula
Reduce the need for rebuilds when drm_edid.h is modified by including it only where needed. Signed-off-by: Jani Nikula --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 1 - drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [net-next v1 08/16] memory-provider: dmabuf devmem memory provider

2023-12-12 Thread Mina Almasry
On Tue, Dec 12, 2023 at 4:25 AM Jason Gunthorpe wrote: > > On Thu, Dec 07, 2023 at 04:52:39PM -0800, Mina Almasry wrote: > > > +static inline struct page_pool_iov *page_to_page_pool_iov(struct page > > *page) > > +{ > > + if (page_is_page_pool_iov(page)) > > + return (struct page_

Re: [net-next v1 09/16] page_pool: device memory support

2023-12-12 Thread Mina Almasry
On Tue, Dec 12, 2023 at 3:17 AM Yunsheng Lin wrote: > > On 2023/12/12 2:14, Mina Almasry wrote: > > On Mon, Dec 11, 2023 at 3:51 AM Yunsheng Lin wrote: > >> > >> On 2023/12/11 12:04, Mina Almasry wrote: > >>> On Sun, Dec 10, 2023 at 6:26 PM Mina Almasry > >>> wrote: > > On Sun, Dec 10

[PATCH] ASoC: hdmi-codec: drop drm/drm_edid.h include

2023-12-12 Thread Jani Nikula
hdmi-codec.h does not appear to need drm/drm_edid.h for anything. Remove it. Signed-off-by: Jani Nikula --- I'm pretty sure I haven't compiled everything that might implicitly depend on the include. However, the right thing to do is to include drm_edid.h where needed, not from somewhat random i

Re: [net-next v1 08/16] memory-provider: dmabuf devmem memory provider

2023-12-12 Thread Jason Gunthorpe
On Tue, Dec 12, 2023 at 06:26:51AM -0800, Mina Almasry wrote: > On Tue, Dec 12, 2023 at 4:25 AM Jason Gunthorpe wrote: > > > > On Thu, Dec 07, 2023 at 04:52:39PM -0800, Mina Almasry wrote: > > > > > +static inline struct page_pool_iov *page_to_page_pool_iov(struct page > > > *page) > > > +{ > > >

Re: [PATCH] drm/radeon: include drm/drm_edid.h only where needed

2023-12-12 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Dec 12, 2023 at 9:10 AM Jani Nikula wrote: > > Including drm_edid.h from radeon_mode.h causes the rebuild of more than > a hundred files when drm_edid.h is modified, while there are only a > handful of files that actually need to include drm_edid.h. > > Signed-off-

Re: [PATCH] fbdev/clcd: Delete the old CLCD driver

2023-12-12 Thread Helge Deller
On 12/12/23 15:18, Linus Walleij wrote: We have managed to ascertain that all users of the old FBDEV code that are out of tree are now gone. The new DRM driver can be found in drivers/gpu/drm/pl111/. The remaining out of tree user was the ARM FVP emulation platform, running Android. Thanks to c

Re: [net-next v1 02/16] net: page_pool: create hooks for custom page providers

2023-12-12 Thread Mina Almasry
On Tue, Dec 12, 2023 at 12:07 AM Ilias Apalodimas wrote: > > Hi Mina, > > Apologies for not participating in the party earlier. > No worries, thanks for looking. > On Fri, 8 Dec 2023 at 02:52, Mina Almasry wrote: > > > > From: Jakub Kicinski > > > > The page providers which try to reuse the sa

Re: [PATCH] drm/amd: include drm/drm_edid.h only where needed

2023-12-12 Thread Alex Deucher
Applied with some minor fixups for our -next tree. Thanks! Alex On Tue, Dec 12, 2023 at 9:10 AM Jani Nikula wrote: > > Including drm_edid.h from amdgpu_mode.h causes the rebuild of literally > hundreds of files when drm_edid.h is modified, while there are only a > handful of files that actually

[PATCH] drm/edid: prefer forward declarations over includes in drm_edid.h

2023-12-12 Thread Jani Nikula
There's no need to include either linux/hdmi.h or drm/drm_mode.h. They can be removed by using forward declarations. While at it, group the forward declarations together, and remove the unnecessary ones. Signed-off-by: Jani Nikula --- include/drm/drm_edid.h | 12 +--- 1 file changed, 5

Re: Radeon regression in 6.6 kernel

2023-12-12 Thread Alex Deucher
On Mon, Dec 11, 2023 at 7:28 PM Phillip Susi wrote: > > Phillip Susi writes: > > > And it works, but 6.7-rc5 does not, even though it includes that patch. > > Here's the syslog from the attempt. I'll start bisecting again. > > I checked out the patch that got merged upstream and it also fails.

Re: [net-next v1 08/16] memory-provider: dmabuf devmem memory provider

2023-12-12 Thread Mina Almasry
On Tue, Dec 12, 2023 at 6:39 AM Jason Gunthorpe wrote: > > On Tue, Dec 12, 2023 at 06:26:51AM -0800, Mina Almasry wrote: > > On Tue, Dec 12, 2023 at 4:25 AM Jason Gunthorpe wrote: > > > > > > On Thu, Dec 07, 2023 at 04:52:39PM -0800, Mina Almasry wrote: > > > > > > > +static inline struct page_po

Re: [net-next v1 08/16] memory-provider: dmabuf devmem memory provider

2023-12-12 Thread Jason Gunthorpe
On Tue, Dec 12, 2023 at 06:58:17AM -0800, Mina Almasry wrote: > Jason, we set the LSB on page_pool_iov pointers before casting it to > struct page pointers. The resulting pointers are not useable as page > pointers at all. I understand that, the second ask is about maintainability of the mm by us

Re: [PATCH v8 1/6] pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()

2023-12-12 Thread Guenter Roeck
On 12/12/23 03:41, Uwe Kleine-König wrote: On Tue, Dec 12, 2023 at 08:34:00AM +, Sean Young wrote: In order to introduce a pwm api which can be used from atomic context, we will need two functions for applying pwm changes: int pwm_apply_might_sleep(struct pwm *, struct pwm_state *);

Re: [PATCH v8 1/6] pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()

2023-12-12 Thread Mark Brown
On Tue, Dec 12, 2023 at 07:22:18AM -0800, Guenter Roeck wrote: > On 12/12/23 03:41, Uwe Kleine-König wrote: > > Several affected maintainers already acked, so I guess it's fine to take > > this via the pwm tree. An Ack from the remaining maintainers would be > > very welcome, an alternative would

Re: [PATCH v7 3/6] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios (v7)

2023-12-12 Thread kernel test robot
Hi Vivek, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Vivek-Kasireddy/udmabuf-Use-vmf_insert_pfn-and-VM_PFNMAP-for-handling-mmap/20231212-160312 base: https://git.kernel.org/pub

[PATCH] drm/ci: uprev mesa version: fix kdl commit fetch

2023-12-12 Thread Vignesh Raman
build-kdl.sh was doing a `clone --depth 1` of the default branch, then checking out a commit that might not be the latest of that branch, resulting in container build error. https://gitlab.freedesktop.org/mesa/mesa/-/commit/5efa4d56 fixes kdl commit fetch issue. Uprev mesa in drm-ci to fix this.

Re: [PATCH v3 0/7] dma-buf: heaps: Add secure heap

2023-12-12 Thread Simon Ser
Is there a chance to pick a better name than "secure" here? "Secure" is super overloaded, it's not clear at all what it means from just the name. Something like "restricted" would be an improvement.

Re: [PATCH 2/3] dt-bindings: lcdif: Decouple imx8mq from imx6sx

2023-12-12 Thread Conor Dooley
On Mon, Dec 11, 2023 at 05:41:37PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > On i.MX6SX, the LCDIF has an associated power domain. > > i.MX8MQ does not have an LCDIF power domain, so allow passing only > "fsl,imx8mq-lcdif" as compatible string to fix the following > dt-schema warning

[PATCH v8 0/2] Resolve suspend-resume racing with GuC destroy-context-worker

2023-12-12 Thread Alan Previn
This series is the result of debugging issues root caused to races between the GuC's destroyed_worker_func being triggered vs repeating suspend-resume cycles with concurrent delayed fence signals for engine-freeing. The reproduction steps require that an app is launched right before the start of t

[PATCH v8 2/2] drm/i915/guc: Close deregister-context race against CT-loss

2023-12-12 Thread Alan Previn
If we are at the end of suspend or very early in resume its possible an async fence signal (via rcu_call) is triggered to free_engines which could lead us to the execution of the context destruction worker (after a prior worker flush). Thus, when suspending, insert rcu_barriers at the start of i91

[PATCH v8 1/2] drm/i915/guc: Flush context destruction worker at suspend

2023-12-12 Thread Alan Previn
When suspending, flush the context-guc-id deregistration worker at the final stages of intel_gt_suspend_late when we finally call gt_sanitize that eventually leads down to __uc_sanitize so that the deregistration worker doesn't fire off later as we reset the GuC microcontroller. Signed-off-by: Ala

Re: [PATCH v2 05/16] drm/msm/dpu: add cdm blocks to sc7280 dpu_hw_catalog

2023-12-12 Thread Dmitry Baryshkov
Hi Abhinav, On Tue, 12 Dec 2023 at 08:49, Dmitry Baryshkov wrote: > > On Mon, 11 Dec 2023 at 23:48, Abhinav Kumar wrote: > > > > > > > > On 12/11/2023 1:42 PM, Dmitry Baryshkov wrote: > > > On Mon, 11 Dec 2023 at 23:32, Abhinav Kumar > > > wrote: > > >> > > >> > > >> > > >> On 12/11/2023 1:31

Re: [PATCH v3 01/15] drm/msm/dpu: add formats check for writeback encoder

2023-12-12 Thread Abhinav Kumar
On 12/11/2023 10:40 PM, Dmitry Baryshkov wrote: On Tue, 12 Dec 2023 at 02:23, Abhinav Kumar wrote: In preparation for adding more formats to dpu writeback add format validation to it to fail any unsupported formats. changes in v3: - rebase on top of msm-next - replace drm

Re: [PATCH v3 00/12] RB1/QCM2290 features

2023-12-12 Thread Will Deacon
On Wed, 29 Nov 2023 15:43:57 +0100, Konrad Dybcio wrote: > This series brings: > - interconnect plumbing > - display setup > > for QCM2290/QRB2210 and > > - CAN bus controller > - HDMI display > - wifi fw variant name > > [...] Applied SMMU update to will (for-joerg/arm-smmu/updates), thanks!

[PATCH 2/5] drm/meson: Simplify usage of clk_rate_exclusive_get()

2023-12-12 Thread Uwe Kleine-König
clk_rate_exclusive_get() returns 0 unconditionally. So remove error handling. This prepares making clk_rate_exclusive_get() return void. Signed-off-by: Uwe Kleine-König --- Hello, btw, the driver fails to call clk_rate_exclusive_put() in the error paths of dw_mipi_dsi_phy_init(). Best regards U

[PATCH 5/5] clk: Make clk_rate_exclusive_get() return void

2023-12-12 Thread Uwe Kleine-König
The function currently returns 0 unconditionally. This isn't very useful and makes users create dead code error paths. So let this function return no value. All users were adapted before to ignore the returned value. Also fix a few typos in the kernel doc comment for clk_rate_exclusive_get(). Sig

[PATCH 0/5] clk: Make clk_rate_exclusive_get() return void

2023-12-12 Thread Uwe Kleine-König
Hello, clk_rate_exclusive_get() returns zero unconditionally. Most users "know" that and don't check the return value. This series fixes the four users that do error checking on the returned value and then makes function return void. Given that the changes to the drivers are simple and so merge c

Re: [PATCH 3/3] drm/amd/display: Support DRM_AMD_DC_FP on RISC-V

2023-12-12 Thread Josh Poimboeuf
On Mon, Dec 11, 2023 at 11:12:42PM -0800, Christoph Hellwig wrote: > On Thu, Dec 07, 2023 at 10:49:53PM -0600, Samuel Holland wrote: > > Actually tracking all possibly-FPU-tainted functions and their call sites is > > probably possible, but a much larger task. > > I think objtool should be able to

Re: [PATCH v3 07/15] drm/msm/dpu: add dpu_hw_cdm abstraction for CDM block

2023-12-12 Thread Abhinav Kumar
On 12/12/2023 1:40 AM, Dmitry Baryshkov wrote: On Tue, 12 Dec 2023 at 02:23, Abhinav Kumar wrote: CDM block comes with its own set of registers and operations which can be done. In-line with other hardware blocks, this change adds the dpu_hw_cdm abstraction for the CDM block. changes in v3

[PATCH] dt-bindings: panel-simple-dsi: move LG 5" HD TFT LCD panel into DSI yaml

2023-12-12 Thread David Heidelberg
Originally was in the panel-simple, but belongs to panel-simple-dsi. See arch/arm/boot/dts/nvidia/tegra114-roth.dts for more details. Fixes: ``` arch/arm/boot/dts/tegra114-roth.dt.yaml: panel@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: Documentation/devicet

Re: [PATCH 1/3] drm/mxsfb: Add an entry for "fsl,imx8mq-lcdif"

2023-12-12 Thread Lucas Stach
Hi Fabio, Am Montag, dem 11.12.2023 um 17:41 -0300 schrieb Fabio Estevam: > From: Fabio Estevam > > On i.MX6SX, the LCDIF has an associated power domain. > > However, i.MX8MQ does not have an LCDIF power domain. > > imx8mq.dtsi has the following compatible string: > > compatible = "fsl,imx8mq

Re: [PATCH 1/3] drm/mxsfb: Add an entry for "fsl,imx8mq-lcdif"

2023-12-12 Thread Fabio Estevam
Hi Lucas, On Tue, Dec 12, 2023 at 3:19 PM Lucas Stach wrote: > I don't really like this series. While we don't make any strong > guarantees in this way, it breaks booting older kernels with a new DT. I thought we needed only to guarantee that old DTs still run with newer kernels, not the other

Re: [PATCH] ASoC: hdmi-codec: drop drm/drm_edid.h include

2023-12-12 Thread kernel test robot
Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on tiwai-sound/for-next] [also build test ERROR on tiwai-sound/for-linus linus/master v6.7-rc5 next-20231212] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

Re: [net-next v1 14/16] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags

2023-12-12 Thread Simon Horman
On Thu, Dec 07, 2023 at 04:52:45PM -0800, Mina Almasry wrote: > Add an interface for the user to notify the kernel that it is done > reading the devmem dmabuf frags returned as cmsg. The kernel will > drop the reference on the frags to make them available for re-use. > > Signed-off-by: Willem de B

Re: [net-next v1 15/16] net: add devmem TCP documentation

2023-12-12 Thread Simon Horman
On Thu, Dec 07, 2023 at 04:52:46PM -0800, Mina Almasry wrote: > Signed-off-by: Mina Almasry > --- > Documentation/networking/devmem.rst | 270 > 1 file changed, 270 insertions(+) > create mode 100644 Documentation/networking/devmem.rst > > diff --git a/Documentation

Re: [PATCH] dt-bindings: panel-simple-dsi: move LG 5" HD TFT LCD panel into DSI yaml

2023-12-12 Thread Jessica Zhang
On 12/12/2023 9:53 AM, David Heidelberg wrote: Originally was in the panel-simple, but belongs to panel-simple-dsi. See arch/arm/boot/dts/nvidia/tegra114-roth.dts for more details. Fixes: ``` arch/arm/boot/dts/tegra114-roth.dt.yaml: panel@0: 'reg' does not match any of the regexes: 'pinctrl

[PATCH] fbdev/simplefb: change loglevel when the power domains cannot be parsed

2023-12-12 Thread Brian Masney
When the power domains cannot be parsed, the message is incorrectly logged as an info message. Let's change this to an error since an error is returned. Fixes: 92a511a568e4 ("fbdev/simplefb: Add support for generic power-domains") Signed-off-by: Brian Masney --- drivers/video/fbdev/simplefb.c |

Re: [PATCH 00/31] Fix and improve Rockchip RK3128 support

2023-12-12 Thread Heiko Stuebner
Hi Alex, Am Dienstag, 29. August 2023, 19:16:16 CET schrieb Alex Bee: > this series fixes some issues I found when testing my "new" RK3128 board > with the mainline kernel and adds some core functionality like SMP bringup, > usb and networking. before I discard this thread, is everything from her

[PATCH v2] dt-bindings: panel-simple-dsi: move LG 5" HD TFT LCD panel into DSI yaml

2023-12-12 Thread David Heidelberg
Originally was in the panel-simple, but belongs to panel-simple-dsi. See arch/arm/boot/dts/nvidia/tegra114-roth.dts for more details. Resolves the following warning: ``` arch/arm/boot/dts/tegra114-roth.dt.yaml: panel@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+' From schem

Re: [PATCH] dt-bindings: panel-simple-dsi: move LG 5" HD TFT LCD panel into DSI yaml

2023-12-12 Thread David Heidelberg
Good catch, thank you! Sent v2. David On 12/12/2023 20:41, Jessica Zhang wrote: On 12/12/2023 9:53 AM, David Heidelberg wrote: Originally was in the panel-simple, but belongs to panel-simple-dsi. See arch/arm/boot/dts/nvidia/tegra114-roth.dts for more details. Fixes: ``` arch/arm/boot/dts/

  1   2   >