Re: [PATCH 3/3] drm/panel-edp: Choose correct preferred mode

2023-11-06 Thread Maxime Ripard
Hi, On Wed, Nov 01, 2023 at 02:20:11PM -0700, Hsin-Yi Wang wrote: > If a non generic edp-panel is under aux-bus, the mode read from edid would > still be selected as preferred and results in multiple preferred modes, > which is ambiguous. > > If a hard-coded mode is present, unset the preferred b

Re: [PATCH v8 6/6] drm/i915/panelreplay: Debugfs support for panel replay

2023-11-06 Thread Hogander, Jouni
Hello Animesh, Thank you for the changes. Now the patch is much shorter, cleaner and easier to review. See my inline comments below. On Sat, 2023-11-04 at 02:30 +0530, Animesh Manna wrote: > Add debugfs support which will print source and sink status > per connector basis. Existing i915_psr_statu

Re: [PATCH 3/3] drm/panel-edp: Choose correct preferred mode

2023-11-06 Thread Maxime Ripard
On Thu, Nov 02, 2023 at 07:33:48AM -0700, Doug Anderson wrote: > Hi, > > On Wed, Nov 1, 2023 at 11:31 PM Dmitry Baryshkov > wrote: > > > > On Wed, 1 Nov 2023 at 23:26, Hsin-Yi Wang wrote: > > > > > > If a non generic edp-panel is under aux-bus, the mode read from edid would > > > still be select

Re: [PATCH v2 3/4] drm/modes: Add a function to clear preferred modes

2023-11-06 Thread Maxime Ripard
On Fri, Nov 03, 2023 at 09:02:33AM -0700, Doug Anderson wrote: > Hi, > > On Thu, Nov 2, 2023 at 3:13 PM Hsin-Yi Wang wrote: > > > > Add a function to clear the preferred bit of a connector's existing modes. > > This is useful for edp panel to unset the preferred modes read from edid > > if the pa

Re: [PATCH v1] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-06 Thread Bagas Sanjaya
On Sun, Nov 05, 2023 at 09:26:26PM -0800, Randy Dunlap wrote: > > > On 11/5/23 21:15, Bagas Sanjaya wrote: > > On Sun, Nov 05, 2023 at 04:00:44PM -0500, Hunter Chasens wrote: > >> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c > >> b/drivers/gpu/drm/amd/pm/amdgpu_pm.c > >> index 517b9fb4624c..7

[PATCH] drm/i915/display: Fix phys_base to be relative not absolute

2023-11-06 Thread Paz Zcharya
Fix the value of variable `phys_base` to be the relative offset in stolen memory, and not the absolute offset of the GSM. Currently, the value of `phys_base` is set to "Surface Base Address," which in the case of Meter Lake is 0xfc00_. This causes the function `i915_gem_object_create_region_at

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-06 Thread Christian König
Am 03.11.23 um 16:34 schrieb Danilo Krummrich: [SNIP] Especially we most likely don't want the VM to live longer than the application which originally used it. If you make the GPUVM an independent object you actually open up driver abuse for the lifetime of this. Right, we don't want that.

[PATCH] drm/i915/vma: Fix potential UAF on multi-tile platforms

2023-11-06 Thread Janusz Krzysztofik
Object debugging tools were sporadically reporting illegal attempts to free a still active i915 VMA object from when parking a GPU tile believed to be idle. [161.359441] ODEBUG: free active (active state 0) object: 88811643b958 object type: i915_active hint: __i915_vma_active+0x0/0x50 [i915]

Re: [RESEND PATCH] drm/qxl: prevent memory leak

2023-11-06 Thread Maxime Ripard
On Tue, 01 Aug 2023 10:53:09 +0800, Zongmin Zhou wrote: > The allocated memory for qdev->dumb_heads should be released > in qxl_destroy_monitors_object before qxl suspend. > otherwise,qxl_create_monitors_object will be called to > reallocate memory for qdev->dumb_heads after qxl resume, > it will c

Re: [PATCH] drm/qxl: prevent memory leak

2023-11-06 Thread Maxime Ripard
Hi, On Wed, Nov 01, 2023 at 12:58:17PM +1000, Dave Airlie wrote: > On Wed, 22 Mar 2023 at 19:04, Zongmin Zhou wrote: > > > > The allocated memory for qdev->dumb_heads should be released > > in qxl_destroy_monitors_object before qxl suspend. > > otherwise,qxl_create_monitors_object will be called

Re: [PATCH] drm/i915/vma: Fix potential UAF on multi-tile platforms

2023-11-06 Thread Jani Nikula
On Mon, 06 Nov 2023, Janusz Krzysztofik wrote: > Object debugging tools were sporadically reporting illegal attempts to > free a still active i915 VMA object from when parking a GPU tile believed > to be idle. > > [161.359441] ODEBUG: free active (active state 0) object: 88811643b958 > objec

Re: [PATCH v2] drm/i915: Fix potential spectre vulnerability

2023-11-06 Thread Andi Shyti
Hi Kunwu, On Fri, Nov 03, 2023 at 10:32:57AM +0800, Kunwu Chan wrote: > Fix smatch warning: > drivers/gpu/drm/i915/gem/i915_gem_context.c:847 set_proto_ctx_sseu() > warn: potential spectre issue 'pc->user_engines' [r] (local cap) > > Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to ha

Re: [PULL] drm-misc-next

2023-11-06 Thread Thomas Hellström
Hi, David. On 11/3/23 17:37, David Edelsohn wrote: Dual-license drm_gpuvm to GPL-2.0 OR MIT. diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c index 02ce6baacdad..08c088319652 100644 --- a/drivers/gpu/drm/drm_gpuvm.c

[PATCH i-g-t 0/2] lib/kunit: Execute test cases synchronously

2023-11-06 Thread Janusz Krzysztofik
Load KUnit modules in a way that only one selected test case is executed per each IGT dynamic sub-subtest. Janusz Krzysztofik (2): lib/kunit: Split out reusable part of test case list gathering lib/kunit: Execute test cases synchronously lib/igt_kmod.c | 262 +

[PATCH i-g-t 1/2] lib/kunit: Split out reusable part of test case list gathering

2023-11-06 Thread Janusz Krzysztofik
We are going to make use of kunit test case filtering feature, now also available to modular builds. That means we will no longer need to load a kunit test module in background and parse its all test cases KTAP output in parallel, only wait for the module to load with a filter for a specific test

[PATCH i-g-t 2/2] lib/kunit: Execute test cases synchronously

2023-11-06 Thread Janusz Krzysztofik
Up to now we've been loading a KUnit test module in background and parsing in parallel its KTAP output with results from all the module's test cases. However, recent KUnit implementation is capable of executing only those test cases that match a user filter specified on test module load. Stop load

Re: [PATCH v1] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-06 Thread Jani Nikula
On Mon, 06 Nov 2023, Bagas Sanjaya wrote: > On Sun, Nov 05, 2023 at 09:26:26PM -0800, Randy Dunlap wrote: >> >> >> On 11/5/23 21:15, Bagas Sanjaya wrote: >> > On Sun, Nov 05, 2023 at 04:00:44PM -0500, Hunter Chasens wrote: >> >> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c >> >> b/drivers/gp

Re: [PATCH v2] drm/i915: Fix potential spectre vulnerability

2023-11-06 Thread Tvrtko Ursulin
On 06/11/2023 09:57, Andi Shyti wrote: Hi Kunwu, On Fri, Nov 03, 2023 at 10:32:57AM +0800, Kunwu Chan wrote: Fix smatch warning: drivers/gpu/drm/i915/gem/i915_gem_context.c:847 set_proto_ctx_sseu() warn: potential spectre issue 'pc->user_engines' [r] (local cap) Fixes: d4433c7600f7 ("drm/i91

Re: [PULL] drm-misc-next

2023-11-06 Thread Maxime Ripard
On Mon, Nov 06, 2023 at 11:01:51AM +0100, Thomas Hellström wrote: > Hi, David. > > On 11/3/23 17:37, David Edelsohn wrote: > > Dual-license drm_gpuvm to GPL-2.0 OR MIT. > > diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c > > index 02ce6baacdad..08c088319652 100644 --- > > a/

Re: [PATCH] drm/i915/vma: Fix potential UAF on multi-tile platforms

2023-11-06 Thread Janusz Krzysztofik
Hi Jani, Thanks for looking at this. On Monday, 6 November 2023 10:53:11 CET Jani Nikula wrote: > On Mon, 06 Nov 2023, Janusz Krzysztofik wrote: > > Object debugging tools were sporadically reporting illegal attempts to > > free a still active i915 VMA object from when parking a GPU tile believ

Re: [PATCH v1] docs: gpu: rfc: i915_scheduler.rst remove unused directives for namespacing

2023-11-06 Thread Jani Nikula
On Mon, 06 Nov 2023, Bagas Sanjaya wrote: > On Sat, Nov 04, 2023 at 09:47:08AM -0400, Hunter Chasens wrote: >> diff --git a/Documentation/gpu/rfc/i915_scheduler.rst >> b/Documentation/gpu/rfc/i915_scheduler.rst >> index c237ebc024cd..23ba7006929b 100644 >> --- a/Documentation/gpu/rfc/i915_schedul

Re: [PATCH] drm/atomic-helper: Call stall_checks() before allocate drm_crtc_commit

2023-11-06 Thread Maxime Ripard
Hi, On Mon, Nov 06, 2023 at 03:37:42PM +0800, oushixiong wrote: > From: Shixiong Ou > > Calling stall_checks() before allocating drm_crtc_commit not after that. > > Signed-off-by: Shixiong Ou Generally speaking, we need much more context than that. What bug did you encounter that makes you s

Re: [PULL] drm-misc-next

2023-11-06 Thread Thomas Hellström
Hi, On 11/6/23 11:20, Maxime Ripard wrote: On Mon, Nov 06, 2023 at 11:01:51AM +0100, Thomas Hellström wrote: Hi, David. On 11/3/23 17:37, David Edelsohn wrote: Dual-license drm_gpuvm to GPL-2.0 OR MIT. diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c index 02ce6baacdad..

Re: (subset) [Intel-gfx] [PATCH 1/7] drm: Do not round to megabytes for greater than 1MiB sizes in fdinfo stats

2023-11-06 Thread Maxime Ripard
On Wed, 27 Sep 2023 14:38:37 +0100, Tvrtko Ursulin wrote: > It is better not to lose precision and not revert to 1 MiB size > granularity for every size greater than 1 MiB. > > Sizes in KiB should not be so troublesome to read (and in fact machine > parsing is I expect the norm here), they align w

Re: [PATCH] drm/mgag200: Flush the cache to improve latency

2023-11-06 Thread Jocelyn Falempe
On 23/10/2023 10:30, Jocelyn Falempe wrote: On 20/10/2023 14:06, Thomas Zimmermann wrote: (cc'ing lkml for feedback) Hi Jocelyn Am 19.10.23 um 15:55 schrieb Jocelyn Falempe: We found a regression in v5.10 on real-time server, using the rt-kernel and the mgag200 driver. It's some really specia

Re: [PULL] drm-misc-next

2023-11-06 Thread Thomas Hellström
On 11/6/23 11:37, Thomas Hellström wrote: Hi, On 11/6/23 11:20, Maxime Ripard wrote: On Mon, Nov 06, 2023 at 11:01:51AM +0100, Thomas Hellström wrote: Hi, David. On 11/3/23 17:37, David Edelsohn wrote: Dual-license drm_gpuvm to GPL-2.0 OR MIT. diff --git a/drivers/gpu/drm/drm_gpuvm.c b/dri

Re: [PULL] drm-misc-next

2023-11-06 Thread Maxime Ripard
On Mon, Nov 06, 2023 at 11:37:34AM +0100, Thomas Hellström wrote: > On 11/6/23 11:20, Maxime Ripard wrote: > > On Mon, Nov 06, 2023 at 11:01:51AM +0100, Thomas Hellström wrote: > > > Hi, David. > > > > > > On 11/3/23 17:37, David Edelsohn wrote: > > > > Dual-license drm_gpuvm to GPL-2.0 OR MIT. >

Re: [PATCH 3/3] drm/panel-edp: Choose correct preferred mode

2023-11-06 Thread Jani Nikula
On Mon, 06 Nov 2023, Maxime Ripard wrote: > On Thu, Nov 02, 2023 at 07:33:48AM -0700, Doug Anderson wrote: >> Hi, >> >> On Wed, Nov 1, 2023 at 11:31 PM Dmitry Baryshkov >> wrote: >> > >> > On Wed, 1 Nov 2023 at 23:26, Hsin-Yi Wang wrote: >> > > >> > > If a non generic edp-panel is under aux-bus

Re: [PATCH] drivers: gpu: Fix warning using plain integer as NULL

2023-11-06 Thread Jani Nikula
On Fri, 03 Nov 2023, Abhinav Singh wrote: > sparse static analysis tools generate a warning with this message > "Using plain integer as NULL pointer". In this case this warning is > being shown because we are trying to intialize a pointer to NULL using > integer value 0. > > Signed-off-by: Abhinav

Re: [PATCH v1] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-06 Thread Lazar, Lijo
On 11/6/2023 2:30 AM, Hunter Chasens wrote: Resolves Sphinx unexpected indentation warning when compiling documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds a literal block to keep vertical formatting of the example power state list. Signed-off-by: Hunter Chasens Than

[PATCH] drm/gpuvm: Fix deprecated license identifier

2023-11-06 Thread Thomas Hellström
"GPL-2.0-only" in the license header was incorrectly changed to the now deprecated "GPL-2.0". Fix. Cc: Maxime Ripard Cc: Danilo Krummrich Reported-by: David Edelsohn Closes: https://lore.kernel.org/dri-devel/5lfrhdpkwhpgzipgngojs3tyqfqbesifzu5nf4l5q3nhfdhcf2@25nmiq7tfrew/T/#m5c356d68815711eea3

Re: [PATCH 04/10] drm/tidss: Move reset to the end of dispc_init()

2023-11-06 Thread Tomi Valkeinen
On 06/11/2023 00:54, Laurent Pinchart wrote: On Thu, Nov 02, 2023 at 08:40:10AM +0200, Tomi Valkeinen wrote: On 01/11/2023 15:57, Laurent Pinchart wrote: On Wed, Nov 01, 2023 at 11:17:41AM +0200, Tomi Valkeinen wrote: We do a DSS reset in the middle of the dispc_init(). While that happens to w

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-06 Thread Danilo Krummrich
On Mon, Nov 06, 2023 at 10:14:29AM +0100, Christian König wrote: > Am 03.11.23 um 16:34 schrieb Danilo Krummrich: > [SNIP] > > > > > > Especially we most likely don't want the VM to live longer than the > > > application which originally used it. If you make the GPUVM an > > > independent object y

Re: [PATCH v2 1/9] drm/nouveau: Switch from pci_is_thunderbolt_attached() to dev_is_removable()

2023-11-06 Thread Ilpo Järvinen
On Fri, 3 Nov 2023, Mario Limonciello wrote: > pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to > using dev_is_removable() to be able to detect USB4 devices as well. Please extend this with more details. I had to lookup the TBT change to be able to make any guess why you

Re: [PATCH v2 2/9] drm/radeon: Switch from pci_is_thunderbolt_attached() to dev_is_removable()

2023-11-06 Thread Ilpo Järvinen
On Fri, 3 Nov 2023, Mario Limonciello wrote: > pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to > using dev_is_removable() to be able to detect USB4 devices as well. Same here as with 1/9. -- i. > Signed-off-by: Mario Limonciello > --- > drivers/gpu/drm/radeon/radeo

Re: [PATCH v2 3/9] PCI: Drop pci_is_thunderbolt_attached()

2023-11-06 Thread Ilpo Järvinen
On Fri, 3 Nov 2023, Mario Limonciello wrote: > All callers have switched to dev_is_removable() for detecting > hotpluggable PCIe devices. > > Signed-off-by: Mario Limonciello > --- > include/linux/pci.h | 22 -- > 1 file changed, 22 deletions(-) > > diff --git a/include/lin

Re: [PATCH 0/5] Some drm scheduler internal renames

2023-11-06 Thread Tvrtko Ursulin
On 05/11/2023 01:51, Luben Tuikov wrote: On 2023-11-02 06:55, Tvrtko Ursulin wrote: From: Tvrtko Ursulin I found some of the naming a bit incosistent and unclear so just a small attempt to clarify and tidy some of them. See what people think if my first stab improves things or not. Cc: Lube

Re: [PATCH] drm/i915/vma: Fix potential UAF on multi-tile platforms

2023-11-06 Thread Jani Nikula
On Mon, 06 Nov 2023, Janusz Krzysztofik wrote: > Hi Jani, > > Thanks for looking at this. > > On Monday, 6 November 2023 10:53:11 CET Jani Nikula wrote: >> On Mon, 06 Nov 2023, Janusz Krzysztofik > wrote: >> > Object debugging tools were sporadically reporting illegal attempts to >> > free a st

Re: [PATCH v2 5/9] PCI: pciehp: Move check for is_thunderbolt into a quirk

2023-11-06 Thread Ilpo Järvinen
On Fri, 3 Nov 2023, Mario Limonciello wrote: > commit 493fb50e958c ("PCI: pciehp: Assume NoCompl+ for Thunderbolt > ports") added a check into pciehp code to explicitly set NoCompl+ > for all Intel Thunderbolt controllers, including those that don't > need it. > > This overloaded the purpose of t

Re: [PATCH v2 8/9] PCI: Exclude PCIe ports used for tunneling in pcie_bandwidth_available()

2023-11-06 Thread Ilpo Järvinen
On Fri, 3 Nov 2023, Mario Limonciello wrote: > The USB4 spec specifies that PCIe ports that are used for tunneling > PCIe traffic over USB4 fabric will be hardcoded to advertise 2.5GT/s and > behave as a PCIe Gen1 device. The actual performance of these ports is > controlled by the fabric implemen

Re: [PATCH] drm/sched: Eliminate drm_sched_run_job_queue_if_ready()

2023-11-06 Thread Tvrtko Ursulin
On 04/11/2023 00:25, Luben Tuikov wrote: Hi Tvrtko, On 2023-11-03 06:39, Tvrtko Ursulin wrote: On 02/11/2023 22:46, Luben Tuikov wrote: Eliminate drm_sched_run_job_queue_if_ready() and instead just call drm_sched_run_job_queue() in drm_sched_free_job_work(). The problem is that the former f

Re: [PATCH] drm/bridge: tc358767: Support input format negotiation hook

2023-11-06 Thread Sam Ravnborg
Hi Aradhya, On Tue, Oct 31, 2023 at 12:58:46AM +0530, Aradhya Bhatia wrote: > With new connector model, tc358767 will not create the connector, when > DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and display-controller driver will > rely on format negotiation to setup the encoder format. > > Add the mis

RE: [PATCH v7 1/6] drm/panelreplay: dpcd register definition for panelreplay

2023-11-06 Thread Manna, Animesh
> -Original Message- > From: Nikula, Jani > Sent: Friday, November 3, 2023 2:55 PM > To: Manna, Animesh ; intel- > g...@lists.freedesktop.org; Maxime Ripard ; Thomas > Zimmermann ; Maarten Lankhorst > > Cc: dri-devel@lists.freedesktop.org; Manna, Animesh > ; Hogander, Jouni > ; Murthy,

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-06 Thread Christian König
Am 06.11.23 um 13:16 schrieb Danilo Krummrich: [SNIP] This reference count just prevents that the VM is freed as long as other ressources are attached to it that carry a VM pointer, such as mappings and VM_BOs. The motivation for that are VM_BOs. For mappings it's indeed a bit paranoid, but it do

[PATCH 4.14 33/48] fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2023-11-06 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Arnd Bergmann [ Upstream commit c1a8d1d0edb71dec15c9649cb56866c71c1ecd9e ] ioremap_uc() is only meaningful on old x86-32 systems with the PAT extension, and on ia64 with its slightly unconvent

[PATCH] accel/ivpu: Fix compilation with CONFIG_PM=n

2023-11-06 Thread Jacek Lawrynowicz
Use pm_runtime_status_suspended() instead of dev->power.runtime_status field that is not available without PM. Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_ipc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/accel/ivpu/ivpu_ipc.c b/drivers/accel/

[PATCH 4.19 47/61] fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2023-11-06 Thread Greg Kroah-Hartman
4.19-stable review patch. If anyone has any objections, please let me know. -- From: Arnd Bergmann [ Upstream commit c1a8d1d0edb71dec15c9649cb56866c71c1ecd9e ] ioremap_uc() is only meaningful on old x86-32 systems with the PAT extension, and on ia64 with its slightly unconvent

[PATCH 6.1 10/62] fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2023-11-06 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Arnd Bergmann [ Upstream commit c1a8d1d0edb71dec15c9649cb56866c71c1ecd9e ] ioremap_uc() is only meaningful on old x86-32 systems with the PAT extension, and on ia64 with its slightly unconventi

[PATCH 6.5 18/88] fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2023-11-06 Thread Greg Kroah-Hartman
6.5-stable review patch. If anyone has any objections, please let me know. -- From: Arnd Bergmann [ Upstream commit c1a8d1d0edb71dec15c9649cb56866c71c1ecd9e ] ioremap_uc() is only meaningful on old x86-32 systems with the PAT extension, and on ia64 with its slightly unconventi

Re: [PATCH] drm/gpuvm: Fix deprecated license identifier

2023-11-06 Thread Maxime Ripard
On Mon, 6 Nov 2023 12:48:27 +0100, Thomas Hellström wrote: > "GPL-2.0-only" in the license header was incorrectly changed to the > now deprecated "GPL-2.0". Fix. > > Cc: Maxime Ripard > Cc: Danilo Krummrich > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

[PATCH 5.4 55/74] fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2023-11-06 Thread Greg Kroah-Hartman
5.4-stable review patch. If anyone has any objections, please let me know. -- From: Arnd Bergmann [ Upstream commit c1a8d1d0edb71dec15c9649cb56866c71c1ecd9e ] ioremap_uc() is only meaningful on old x86-32 systems with the PAT extension, and on ia64 with its slightly unconventi

Re: [PATCH] drm/gpuvm: Fix deprecated license identifier

2023-11-06 Thread Danilo Krummrich
On Mon, Nov 06, 2023 at 12:48:27PM +0100, Thomas Hellström wrote: > "GPL-2.0-only" in the license header was incorrectly changed to the > now deprecated "GPL-2.0". Fix. > > Cc: Maxime Ripard > Cc: Danilo Krummrich > Reported-by: David Edelsohn > Closes: > https://lore.kernel.org/dri-devel/5lfr

回复: [PATCH] drm/atomic-helper: Call stall_checks() before allocate drm_crtc_commit

2023-11-06 Thread oushixiong
Hi, I think it will cause memory leaks if too many nonblock commit works return -EBUSY. You can try to send large number of nonblock commits by drmModeAtomicCommit(). -邮件原件- 发件人: Maxime Ripard 发送时间: 2023年11月6日 18:33 收件人: oushixiong 抄送: Maarten Lankhorst ; Thomas Zimmermann ; David Air

[PATCH 5.15 082/128] fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2023-11-06 Thread Greg Kroah-Hartman
5.15-stable review patch. If anyone has any objections, please let me know. -- From: Arnd Bergmann [ Upstream commit c1a8d1d0edb71dec15c9649cb56866c71c1ecd9e ] ioremap_uc() is only meaningful on old x86-32 systems with the PAT extension, and on ia64 with its slightly unconvent

Re: [PATCH v7 1/6] drm/panelreplay: dpcd register definition for panelreplay

2023-11-06 Thread Maxime Ripard
On Mon, Nov 06, 2023 at 01:01:19PM +, Manna, Animesh wrote: > > > > -Original Message- > > From: Nikula, Jani > > Sent: Friday, November 3, 2023 2:55 PM > > To: Manna, Animesh ; intel- > > g...@lists.freedesktop.org; Maxime Ripard ; Thomas > > Zimmermann ; Maarten Lankhorst > > > >

Re: [PATCH v3 0/2] drm/v3d: Expose GPU usage stats

2023-11-06 Thread Maira Canal
Hi, I've just applied this patchset to drm-misc/drm-misc-next. Thanks Melissa and Chema for reviewing it! Best Regards, - Maíra On 9/5/23 18:06, Maíra Canal wrote: This patchset exposes GPU usages stats both globally and per-file descriptor. The first patch exposes the accumulated amount of

[PATCH 5.10 66/95] fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2023-11-06 Thread Greg Kroah-Hartman
5.10-stable review patch. If anyone has any objections, please let me know. -- From: Arnd Bergmann [ Upstream commit c1a8d1d0edb71dec15c9649cb56866c71c1ecd9e ] ioremap_uc() is only meaningful on old x86-32 systems with the PAT extension, and on ia64 with its slightly unconvent

Re: [PATCH 3/6] drm/amdgpu: Flush VM updates for split bindings eagerly.

2023-11-06 Thread Christian König
Am 06.11.23 um 08:56 schrieb Tatsuyuki Ishi: On Oct 31, 2023, at 23:07, Christian König wrote: Am 31.10.23 um 14:59 schrieb Bas Nieuwenhuizen: On Tue, Oct 31, 2023 at 2:57 PM Christian König wrote: Am 31.10.23 um 14:40 schrieb Tatsuyuki Ishi: > The current amdgpu_gem_va_update

[PATCH] MAINTAINERS: Add Maira to V3D maintainers

2023-11-06 Thread Maíra Canal
I've been contributing to V3D with improvements, reviews, testing and debugging. Therefore, add myself as a co-maintainer of the V3D driver. Signed-off-by: Maíra Canal --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f13e476ed803..3213563756cb 1

Re: [PATCH v2 2/3] drm/amdgpu: Add flag to disable implicit sync for GEM operations.

2023-11-06 Thread Christian König
 Am 02.11.23 um 15:04 schrieb Tatsuyuki Ishi: In Vulkan, it is the application's responsibility to perform adequate synchronization before a sparse unmap, replace or BO destroy operation. Until now, the kernel applied the same rule as implicitly-synchronized APIs like OpenGL, which with per-VM BO

Re: [RFC PATCH] drm/test: add a test suite for GEM objects backed by shmem

2023-11-06 Thread Maxime Ripard
On Mon, Oct 30, 2023 at 11:58:20AM +0100, Marco Pagani wrote: > On 2023-10-25 10:43, Maxime Ripard wrote: > > On Tue, Oct 24, 2023 at 07:14:25PM +0200, Marco Pagani wrote: > +static void drm_gem_shmem_test_obj_create_private(struct kunit *test) > +{ > +struct fake_dev *fdev =

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-06 Thread Jaak Ristioja
On 06.11.23 04:15, Huacai Chen wrote: Hi, Jaak and Evan, On Mon, Nov 6, 2023 at 12:28 AM Jaak Ristioja wrote: On 05.11.23 14:40, Huacai Chen wrote: Hi, Evan, On Sat, Nov 4, 2023 at 10:50 AM Evan Preston wrote: Hi Huacai, On 2023-11-03 Fri 02:36pm, Huacai Chen wrote: Hi, Evan, On Fri,

Re: [RFC] drm/tests: annotate intentional stack trace in drm_test_rect_calc_hscale()

2023-11-06 Thread mripard
Hi, On Wed, Nov 01, 2023 at 12:08:00PM +0300, Dan Carpenter wrote: > Let me add Richard to the CC list. See lore for more details. > https://lore.kernel.org/all/CA+G9fYuA643RHHpPnz9Ww7rr3zV5a0y=7_uFcybBSL=qp_s...@mail.gmail.com/ > > On Tue, Oct 31, 2023 at 09:57:48PM +0530, Naresh Kamboju wrote:

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-06 Thread Danilo Krummrich
On Mon, Nov 06, 2023 at 02:05:13PM +0100, Christian König wrote: > Am 06.11.23 um 13:16 schrieb Danilo Krummrich: > > [SNIP] > > This reference count just prevents that the VM is freed as long as other > > ressources are attached to it that carry a VM pointer, such as mappings and > > VM_BOs. The m

Re: [PATCH] drm/panel: nt35510: fix typo

2023-11-06 Thread Linus Walleij
On Mon, Oct 23, 2023 at 11:06 AM Dario Binacchi wrote: > Replace 'HFP' with 'HBP'. > > Fixes: 899f24ed8d3a ("drm/panel: Add driver for Novatek NT35510-based panels") > Signed-off-by: Dario Binacchi Patch applied! Yours, Linus Walleij

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-06 Thread Huacai Chen
On Mon, Nov 6, 2023 at 9:49 PM Jaak Ristioja wrote: > > On 06.11.23 04:15, Huacai Chen wrote: > > Hi, Jaak and Evan, > > > > On Mon, Nov 6, 2023 at 12:28 AM Jaak Ristioja wrote: > >> > >> On 05.11.23 14:40, Huacai Chen wrote: > >>> Hi, Evan, > >>> > >>> On Sat, Nov 4, 2023 at 10:50 AM Evan Presto

Re: [PATCH RFC v3 12/37] drm/connector: hdmi: Create Infoframe DebugFS entries

2023-11-06 Thread Maxime Ripard
Hi Hans, On Fri, Nov 03, 2023 at 10:05:18AM +0100, Hans Verkuil wrote: > Hi Maxime, > > Thank you for posting v3, this time it runs fine on my RPi 4, thank you for > fixing that. > > I'll start working on a conformity checker for this. Awesome :) > > +static int create_hdmi_infoframe_files(str

Re: [PATCH v8 04/20] drm/imagination/uapi: Add PowerVR driver UAPI

2023-11-06 Thread Faith Ekstrand
On Tue, 2023-10-31 at 15:12 +, Sarah Walker wrote: > Add the UAPI implementation for the PowerVR driver. > > Changes from v7: > - Remove prefixes from DRM_PVR_BO_* flags > - Improve struct drm_pvr_ioctl_create_hwrt_dataset_args documentation > - Remove references to static area carveouts > - C

Re: [PATCH RFC v3 12/37] drm/connector: hdmi: Create Infoframe DebugFS entries

2023-11-06 Thread Hans Verkuil
On 06/11/2023 15:44, Maxime Ripard wrote: > Hi Hans, > > On Fri, Nov 03, 2023 at 10:05:18AM +0100, Hans Verkuil wrote: >> Hi Maxime, >> >> Thank you for posting v3, this time it runs fine on my RPi 4, thank you for >> fixing that. >> >> I'll start working on a conformity checker for this. > > Awe

Re: [PULL] drm-misc-next

2023-11-06 Thread David Edelsohn
On Mon, Nov 6, 2023 at 5:55 AM Maxime Ripard wrote: > On Mon, Nov 06, 2023 at 11:37:34AM +0100, Thomas Hellström wrote: > > On 11/6/23 11:20, Maxime Ripard wrote: > > > On Mon, Nov 06, 2023 at 11:01:51AM +0100, Thomas Hellström wrote: > > > > Hi, David. > > > > > > > > On 11/3/23 17:37, David Ede

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-06 Thread Christian König
Am 06.11.23 um 15:11 schrieb Danilo Krummrich: On Mon, Nov 06, 2023 at 02:05:13PM +0100, Christian König wrote: Am 06.11.23 um 13:16 schrieb Danilo Krummrich: [SNIP] This reference count just prevents that the VM is freed as long as other ressources are attached to it that carry a VM pointer, s

Re: [PATCH] drivers: gpu: Fix warning using plain integer as NULL

2023-11-06 Thread Abhinav Singh
On 11/6/23 16:53, Jani Nikula wrote: On Fri, 03 Nov 2023, Abhinav Singh wrote: sparse static analysis tools generate a warning with this message "Using plain integer as NULL pointer". In this case this warning is being shown because we are trying to intialize a pointer to NULL using integer val

Re: 6.7/regression/KASAN: null-ptr-deref in amdgpu_ras_reset_error_count+0x2d6

2023-11-06 Thread Alex Deucher
On Mon, Nov 6, 2023 at 10:22 AM Mikhail Gavrilov wrote: > > Hi, > another release cycle, and another regression. > After another kernel update in Fedora Rawhide GPU not > entering in graphic mode on my laptop ASUS ROG Strix G15 Advantage > Edition G513QY-HQ007. > And in kernel log appears this bug

Re: 回复: [PATCH] drm/atomic-helper: Call stall_checks() before allocate drm_crtc_commit

2023-11-06 Thread 'Maxime Ripard'
Hi, On Mon, Nov 06, 2023 at 09:26:15PM +0800, oushixi...@kylinos.cn wrote: > I think it will cause memory leaks if too many nonblock commit works return > -EBUSY. Do you *think* or are you sure? If you are sure, then please write down everything I mentioned earlier in the commit log and resend t

Re: [PATCH v3 2/6] dt-bindings: display/msm: Add reg bus and rotator interconnects

2023-11-06 Thread Neil Armstrong
Hi, On 28/09/2023 13:35, Dmitry Baryshkov wrote: From: Konrad Dybcio Apart from the already handled data bus (MAS_MDP_Pn<->DDR), there are other connection paths: - a path that connects rotator block to the DDR. - a path that needs to be handled to ensure MDSS register access functions prop

Re: [PATCH v2 2/3] drm/amdgpu: Add flag to disable implicit sync for GEM operations.

2023-11-06 Thread Tatsuyuki Ishi
> On Nov 6, 2023, at 22:44, Christian König wrote: > > Am 02.11.23 um 15:04 schrieb Tatsuyuki Ishi: >> In Vulkan, it is the application's responsibility to perform adequate >> synchronization before a sparse unmap, replace or BO destroy operation. >> Until now, the kernel applied the same rule a

Re: [RFC PATCH 01/10] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-11-06 Thread Harry Wentland
On 2023-10-20 06:36, Pekka Paalanen wrote: > On Thu, 19 Oct 2023 10:56:40 -0400 > Harry Wentland wrote: > >> On 2023-10-10 12:13, Melissa Wen wrote: >>> O 09/08, Harry Wentland wrote: Signed-off-by: Harry Wentland > > ... > >>> Also, with this new plane API in place, I understand that w

Re: [PATCH 3/3] drm/panel-edp: Choose correct preferred mode

2023-11-06 Thread Doug Anderson
Hi, On Mon, Nov 6, 2023 at 12:06 AM Maxime Ripard wrote: > > On Thu, Nov 02, 2023 at 07:33:48AM -0700, Doug Anderson wrote: > > Hi, > > > > On Wed, Nov 1, 2023 at 11:31 PM Dmitry Baryshkov > > wrote: > > > > > > On Wed, 1 Nov 2023 at 23:26, Hsin-Yi Wang wrote: > > > > > > > > If a non generic e

Re: [RFC PATCH 01/10] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-11-06 Thread Harry Wentland
On 2023-10-20 06:17, Pekka Paalanen wrote: > On Thu, 19 Oct 2023 10:56:29 -0400 > Harry Wentland wrote: > >> On 2023-09-13 07:29, Pekka Paalanen wrote: >>> On Fri, 8 Sep 2023 11:02:26 -0400 >>> Harry Wentland wrote: >>> Signed-off-by: Harry Wentland > > ... > +COLOR_PIPELINE P

Re: [PATCH] drivers: gpu: Fix warning using plain integer as NULL

2023-11-06 Thread Jani Nikula
On Mon, 06 Nov 2023, Abhinav Singh wrote: > On 11/6/23 16:53, Jani Nikula wrote: >> On Fri, 03 Nov 2023, Abhinav Singh wrote: >>> sparse static analysis tools generate a warning with this message >>> "Using plain integer as NULL pointer". In this case this warning is >>> being shown because we ar

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-06 Thread Danilo Krummrich
On Mon, Nov 06, 2023 at 04:10:50PM +0100, Christian König wrote: > Am 06.11.23 um 15:11 schrieb Danilo Krummrich: > > On Mon, Nov 06, 2023 at 02:05:13PM +0100, Christian König wrote: > > > Am 06.11.23 um 13:16 schrieb Danilo Krummrich: > > > > [SNIP] > > > > This reference count just prevents that

Re: [PATCH v2 3/9] PCI: Drop pci_is_thunderbolt_attached()

2023-11-06 Thread Mario Limonciello
On 11/6/2023 06:33, Ilpo Järvinen wrote: On Fri, 3 Nov 2023, Mario Limonciello wrote: All callers have switched to dev_is_removable() for detecting hotpluggable PCIe devices. Signed-off-by: Mario Limonciello --- include/linux/pci.h | 22 -- 1 file changed, 22 deletions(

Re: [PATCH drm-misc-next v3] drm/sched: implement dynamic job-flow control

2023-11-06 Thread Danilo Krummrich
On Fri, Nov 03, 2023 at 09:15:25AM +0100, Christian König wrote: Am 02.11.23 um 19:03 schrieb Danilo Krummrich: > On Thu, Nov 02, 2023 at 11:07:32AM +0100, Christian König wrote: > > Hi Danilo, > > > > Am 31.10.23 um 16:01 schrieb Danilo Krummrich: > > > On Tue, Oct 31, 2023 at 02:20:50PM +0100

Re: [PATCH v2 1/9] drm/nouveau: Switch from pci_is_thunderbolt_attached() to dev_is_removable()

2023-11-06 Thread Mika Westerberg
On Mon, Nov 06, 2023 at 02:25:24PM +0200, Ilpo Järvinen wrote: > On Fri, 3 Nov 2023, Mario Limonciello wrote: > > > pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to > > using dev_is_removable() to be able to detect USB4 devices as well. > > Please extend this with more de

Re: [PATCH v2 1/9] drm/nouveau: Switch from pci_is_thunderbolt_attached() to dev_is_removable()

2023-11-06 Thread Mario Limonciello
On 11/6/2023 10:47, Mika Westerberg wrote: On Mon, Nov 06, 2023 at 02:25:24PM +0200, Ilpo Järvinen wrote: On Fri, 3 Nov 2023, Mario Limonciello wrote: pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to using dev_is_removable() to be able to detect USB4 devices as well.

Re: [PATCH v2 5/9] PCI: pciehp: Move check for is_thunderbolt into a quirk

2023-11-06 Thread Mario Limonciello
On 11/6/2023 06:41, Ilpo Järvinen wrote: On Fri, 3 Nov 2023, Mario Limonciello wrote: commit 493fb50e958c ("PCI: pciehp: Assume NoCompl+ for Thunderbolt ports") added a check into pciehp code to explicitly set NoCompl+ for all Intel Thunderbolt controllers, including those that don't need it.

Re: [PATCH v2 8/9] PCI: Exclude PCIe ports used for tunneling in pcie_bandwidth_available()

2023-11-06 Thread Mario Limonciello
On 11/6/2023 06:52, Ilpo Järvinen wrote: On Fri, 3 Nov 2023, Mario Limonciello wrote: The USB4 spec specifies that PCIe ports that are used for tunneling PCIe traffic over USB4 fabric will be hardcoded to advertise 2.5GT/s and behave as a PCIe Gen1 device. The actual performance of these ports

Re: [PATCH v2 6/9] PCI: Rename is_thunderbolt to is_tunneled

2023-11-06 Thread Mario Limonciello
On 11/5/2023 11:39, Lukas Wunner wrote: On Fri, Nov 03, 2023 at 02:07:55PM -0500, Mario Limonciello wrote: The `is_thunderbolt` bit has been used to indicate that a PCIe device contained the Intel VSEC which is used by various parts of the kernel to change behavior. To later allow usage with USB

Re: [PATCH 0/3] drm/ci: Add support for SM8250 Gitlab Runner

2023-11-06 Thread Jessica Zhang
On 11/4/2023 6:02 AM, Helen Koike wrote: Hi Jessica, On 10/10/2023 19:25, Jessica Zhang wrote: Recently, we've registered a Gitlab runner for a Qualcomm RB5 device that will be hosted and maintained in Qualcomm labs. This series will add a corresponding CI job for testing SM8250 devices a

Re: [PATCH 5/8] drm/loongson: Using vbios for the LS7A2000 output initialization

2023-11-06 Thread kernel test robot
Hi Sui, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.6 next-20231106] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH v2 1/3] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages (v2)

2023-11-06 Thread Jason Gunthorpe
On Sun, Nov 05, 2023 at 10:15:39PM -0800, Vivek Kasireddy wrote: > For drivers that would like to longterm-pin the pages associated > with a file, the pin_user_pages_fd() API provides an option to > not only pin the pages via FOLL_PIN but also to check and migrate > them if they reside in movable z

Re: [PATCH] drm/panel: starry-2081101qfh032011-53g: Fine tune the panel power sequence

2023-11-06 Thread Jessica Zhang
On 11/3/2023 11:55 PM, Zhengqiao Xia wrote: Hi Jessica , Fixes: 6069b66cd962 ("drm/panel: support for STARRY 2081101QFH032011-53G MIPI-DSI panel") I'm not very familiar with this upstream process, Where should I add these? You can add the Fixes tag before the signed-off-by. For example

Re: [PATCH v2 8/9] PCI: Exclude PCIe ports used for tunneling in pcie_bandwidth_available()

2023-11-06 Thread Lukas Wunner
On Fri, Nov 03, 2023 at 02:07:57PM -0500, Mario Limonciello wrote: > The USB4 spec specifies that PCIe ports that are used for tunneling > PCIe traffic over USB4 fabric will be hardcoded to advertise 2.5GT/s and > behave as a PCIe Gen1 device. The actual performance of these ports is > controlled b

Re: [PATCH] drivers: gpu: Fix warning using plain integer as NULL

2023-11-06 Thread Abhinav Singh
On 11/6/23 22:10, Jani Nikula wrote: On Mon, 06 Nov 2023, Abhinav Singh wrote: On 11/6/23 16:53, Jani Nikula wrote: On Fri, 03 Nov 2023, Abhinav Singh wrote: sparse static analysis tools generate a warning with this message "Using plain integer as NULL pointer". In this case this warning is

Re: [PATCH v2 6/9] PCI: Rename is_thunderbolt to is_tunneled

2023-11-06 Thread Lukas Wunner
On Mon, Nov 06, 2023 at 10:59:13AM -0600, Mario Limonciello wrote: > On 11/5/2023 11:39, Lukas Wunner wrote: > > On Fri, Nov 03, 2023 at 02:07:55PM -0500, Mario Limonciello wrote: > > > The `is_thunderbolt` bit has been used to indicate that a PCIe device > > > contained the Intel VSEC which is use

Re: [PATCH v1] docs: gpu: rfc: i915_scheduler.rst remove unused directives for namespacing

2023-11-06 Thread Hunter Chasens
When running `make htmldocs` the following warnings are given. ``` Documentation/gpu/rfc/i915_scheduler.rst:138: WARNING: Unknown directive type "c:namespace-push". .. c:namespace-push:: rfc Documentation/gpu/rfc/i915_scheduler.rst:143: WARNING: Unknown directive type "c:namespace-pop". .. c:nam

Re: [PATCH] drm/amd/display: avoid variable reinitialization

2023-11-06 Thread Alex Deucher
Applied. Thanks! On Tue, Oct 24, 2023 at 2:11 PM Bragatheswaran Manickavel wrote: > > The member variable enable_hpo_pg_support is already initialized > and hence the reinitialization instruction can be removed. Issue > identified using the doubleinit.cocci Coccinelle semantic patch script. > >

Re: [PATCH] drm/msm/dpu: correct clk bit for WB2 block

2023-11-06 Thread Abhinav Kumar
Sorry for the delay in getting back on this. There was quite a bit of history digging I had to do myself to give a certain response. On 10/9/2023 10:11 AM, Dmitry Baryshkov wrote: On sc7280 there are two clk bits for WB2: control and status. While programming the VBIF params of WB, the driver

Re: [PATCH] accel/ivpu: Fix compilation with CONFIG_PM=n

2023-11-06 Thread Jeffrey Hugo
On 11/6/2023 6:08 AM, Jacek Lawrynowicz wrote: Use pm_runtime_status_suspended() instead of dev->power.runtime_status field that is not available without PM. Signed-off-by: Jacek Lawrynowicz --- Reviewed-by: Jeffrey Hugo

Re: [PATCH v2 8/9] PCI: Exclude PCIe ports used for tunneling in pcie_bandwidth_available()

2023-11-06 Thread Mario Limonciello
On 11/6/2023 12:10, Lukas Wunner wrote: On Fri, Nov 03, 2023 at 02:07:57PM -0500, Mario Limonciello wrote: The USB4 spec specifies that PCIe ports that are used for tunneling PCIe traffic over USB4 fabric will be hardcoded to advertise 2.5GT/s and behave as a PCIe Gen1 device. The actual perform

  1   2   3   >