Hi Sui,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on linus/master v6.6 next-20231106]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    
https://github.com/intel-lab-lkp/linux/commits/Sui-Jingfeng/drm-loongson-Introduce-a-minimal-support-for-Loongson-VBIOS/20231030-034730
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    
https://lore.kernel.org/r/20231029194607.379459-6-suijingfeng%40loongson.cn
patch subject: [PATCH 5/8] drm/loongson: Using vbios for the LS7A2000 output 
initialization
config: x86_64-randconfig-122-20231102 
(https://download.01.org/0day-ci/archive/20231107/202311070048.l62vvvhe-...@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): 
(https://download.01.org/0day-ci/archive/20231107/202311070048.l62vvvhe-...@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <l...@intel.com>
| Closes: 
https://lore.kernel.org/oe-kbuild-all/202311070048.l62vvvhe-...@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/loongson/lsdc_output_7a2000.c:567:31: sparse: sparse: symbol 
>> 'ls7a2000_query_output_configuration' was not declared. Should it be static?

vim +/ls7a2000_query_output_configuration +567 
drivers/gpu/drm/loongson/lsdc_output_7a2000.c

   559  
   560  /*
   561   * For LS7A2000, the built-in VGA encoder is transparent. If there are
   562   * external encoder exist, then the internal HDMI encoder MUST be 
enabled
   563   * and initialized. As the internal HDMI encoder is always connected, so
   564   * only the transmitters which take HDMI signal (such as HDMI to eDP, 
HDMI
   565   * to LVDS, etc) are usable with.
   566   */
 > 567  const struct lsdc_output_desc *
   568  ls7a2000_query_output_configuration(struct drm_device *ddev, unsigned 
int pipe)
   569  {
   570          enum loongson_vbios_encoder_name encoder_name = 0;
   571          bool ret;
   572  
   573          ret = loongson_vbios_query_encoder_info(ddev, pipe, NULL,
   574                                                  &encoder_name, NULL);
   575          if (!ret)
   576                  goto bailout;
   577  
   578          if (pipe == 0) {
   579                  switch (encoder_name) {
   580                  case ENCODER_CHIP_INTERNAL_HDMI:
   581                          return &ls7a2000_hdmi_pipe0;
   582  
   583                  /*
   584                   * For LS7A2000, the built-in VGA encoder is 
transparent.
   585                   */
   586                  case ENCODER_CHIP_INTERNAL_VGA:
   587                          return &ls7a2000_vga_pipe0;
   588  
   589                  /*
   590                   * External display bridge exists, the internal HDMI 
encoder
   591                   * MUST be enabled and initialized. Please add a drm 
bridge
   592                   * driver, and attach to this encoder.
   593                   */
   594                  default:
   595                          return &ls7a2000_hdmi_pipe0;
   596                  }
   597          }
   598  
   599          if (pipe == 1) {
   600                  switch (encoder_name) {
   601                  case ENCODER_CHIP_INTERNAL_HDMI:
   602                          return &ls7a2000_hdmi_pipe1;
   603  
   604                  /*
   605                   * External display bridge exists, the internal HDMI 
encoder
   606                   * MUST be enabled and initialized. Please add a drm 
bridge
   607                   * driver, and attach it to this encoder.
   608                   */
   609                  default:
   610                          return &ls7a2000_hdmi_pipe1;
   611                  }
   612          }
   613  
   614  bailout:
   615          if (pipe == 0)
   616                  return &ls7a2000_vga_pipe0;
   617  
   618          if (pipe == 1)
   619                  return &ls7a2000_hdmi_pipe1;
   620  
   621          return NULL;
   622  }
   623  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Reply via email to