Re: [PATCH drm-misc-next v4] drm/sched: implement dynamic job-flow control

2023-10-31 Thread kernel test robot
Hi Danilo, kernel test robot noticed the following build errors: [auto build test ERROR on b2139fb5051554a7f297e4ad584ef1bc26c76d5d] url: https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-sched-implement-dynamic-job-flow-control/20231031-082915 base

[PATCH 0/4] accel/ivpu: Use GEM shmem

2023-10-31 Thread Stanislaw Gruszka
Use GEM shmem for buffer management code; Previously sent as RFC: https://lore.kernel.org/dri-devel/20230901164842.178654-1-stanislaw.grus...@linux.intel.com/ Compared to RFC only changelog's were improved. Jacek Lawrynowicz (4): accel/ivpu: Allocate vpu_addr in gem->open() callback accel/iv

[PATCH 1/4] accel/ivpu: Allocate vpu_addr in gem->open() callback

2023-10-31 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz Use gem->open() callback to simplify the code and prepare for gem_shmem conversion. It is called during handle creation for a gem object, during prime import and in BO_CREATE ioctl. Hence can be used for vpu_addr allocation. On the way remove unused bo->user_ptr field. Si

[PATCH 2/4] accel/ivpu: Fix locking in ivpu_bo_remove_all_bos_from_context()

2023-10-31 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz ivpu_bo_remove_all_bos_from_context() could race with ivpu_bo_free() when prime buffer was closed after vpu device was closed. Move the bo_list from context to vdev and use a dedicated lock to sync it. This list is not modified when BO is added/removed from a context. Al

[PATCH 3/4] accel/ivpu: Remove support for uncached buffers

2023-10-31 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz Usages of DRM_IVPU_BO_UNCACHED should be replaced by DRM_IVPU_BO_WC. There is no functional benefit from DRM_IVPU_BO_UNCACHED if these buffers are never mapped to host VM. This allows to cut the buffer handling code in the kernel driver by half. Usage of DRM_IVPU_BO_UNCA

[PATCH 4/4] accel/ivpu: Use GEM shmem helper for all buffers

2023-10-31 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz Use struct drm_gem_shmem_object as a base for struct ivpu_bo. This cuts by 50% the buffer management code. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/Kconfig| 2 +- drivers/accel/ivpu/ivpu_d

Re: [PATCH v8 16/16] dt-bindings: display: mediatek: padding: add compatible for MT8195

2023-10-31 Thread 何宗原
On Mon, 2023-10-30 at 18:00 +0800, Moudy Ho wrote: > Add a compatible string for the PADDING block in MediaTek MT8195 that > is controlled by MDP3. > > Signed-off-by: Moudy Ho > --- > .../bindings/display/mediatek/mediatek,padding.yaml | 4 > +++- > 1 file changed, 3 insertions(+), 1 d

[PATCH v3 4/4] drm/v3d: add brcm,2712-v3d as a compatible V3D device

2023-10-31 Thread Iago Toral Quiroga
This is required to get the V3D module to load with Raspberry Pi 5. Signed-off-by: Iago Toral Quiroga Reviewed-by: Stefan Wahren Reviewed-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3

[PATCH v3 3/4] dt-bindings: gpu: v3d: Add BCM2712's compatible

2023-10-31 Thread Iago Toral Quiroga
BCM2712, Raspberry Pi 5's SoC, contains a V3D core. So add its specific compatible to the bindings. Signed-off-by: Iago Toral Quiroga Reviewed-by: Maíra Canal --- Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree

[PATCH v3 1/4] drm/v3d: update UAPI to match user-space for V3D 7.x

2023-10-31 Thread Iago Toral Quiroga
V3D 7.x takes a new parameter to configure TFU jobs that needs to be provided by user space. Signed-off-by: Iago Toral Quiroga Reviewed-by: Maíra Canal --- v2: added s-o-b, fixed typo in commit message (Maíra Canal) include/uapi/drm/v3d_drm.h | 5 + 1 file changed, 5 insertions(+) diff --

[PATCH v3 0/4] V3D module changes for Pi5

2023-10-31 Thread Iago Toral Quiroga
This series includes patches to update the V3D kernel module that drives the VideoCore VI GPU in Raspberry Pi 4 to also support the Video Core VII iteration present in Raspberry Pi 5. The first patch in the series adds a small uAPI update required for TFU jobs, the second patch addresses the bulk

[PATCH v3 2/4] drm/v3d: fix up register addresses for V3D 7.x

2023-10-31 Thread Iago Toral Quiroga
This patch updates a number of register addresses that have been changed in Raspberry Pi 5 (V3D 7.1) and updates the code to use the corresponding registers and addresses based on the actual V3D version. Signed-off-by: Iago Toral Quiroga Reviewed-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_debu

Re: [PATCH v8 16/16] dt-bindings: display: mediatek: padding: add compatible for MT8195

2023-10-31 Thread 何宗原
On Mon, 2023-10-30 at 14:26 -0500, Rob Herring wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > On Mon, 30 Oct 2023 18:00:22 +0800, Moudy Ho wrote: > > Add a compatible string for the PADDING block in MediaT

Re: [PATCH v6 06/10] drm/msm/dpu: deduplicate some (most) of SSPP sub-blocks

2023-10-31 Thread Dmitry Baryshkov
On Mon, 30 Oct 2023 at 21:52, Abhinav Kumar wrote: > > > > On 10/6/2023 6:14 AM, Dmitry Baryshkov wrote: > > As we have dropped the variadic parts of SSPP sub-blocks declarations, > > deduplicate them now, reducing memory cruft. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > .../msm/disp/d

Re: [PATCH v6 09/10] drm/msm/dpu: merge DPU_SSPP_SCALER_QSEED3, QSEED3LITE, QSEED4

2023-10-31 Thread Dmitry Baryshkov
On Mon, 30 Oct 2023 at 22:24, Abhinav Kumar wrote: > > > > On 10/6/2023 6:14 AM, Dmitry Baryshkov wrote: > > Three different features, DPU_SSPP_SCALER_QSEED3, QSEED3LITE and QSEED4 > > are all related to different versions of the same HW scaling block. > > Corresponding driver parts use scaler_blk

Re: [PATCH] drm/msm/dpu: Add missing safe_lut_tbl in sc8280xp catalog

2023-10-31 Thread Manivannan Sadhasivam
On Mon, Oct 30, 2023 at 04:23:20PM -0700, Bjorn Andersson wrote: > During USB transfers on the SC8280XP __arm_smmu_tlb_sync() is seen to > typically take 1-2ms to complete. As expected this results in poor > performance, something that has been mitigated by proposing running the > iommu in non-stri

[PATCH v9 04/16] dt-bindings: media: mediatek: mdp3: add compatible for MT8195 RSZ

2023-10-31 Thread Moudy Ho
MT8195 RSZ inherited from MT8183, add the corresponding compatible name to it. Signed-off-by: Moudy Ho Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski --- .../devicetree/bindings/media/mediatek,mdp3-rsz.yaml| 6 +- 1 file changed, 5 insertions(+), 1 deletion(

[PATCH v9 02/16] dt-bindings: media: mediatek: mdp3: merge the indentical RDMA under display

2023-10-31 Thread Moudy Ho
To simplify maintenance and avoid branches, the identical component should be merged and placed in the path belonging to the MDP (from display/* to media/*). In addition, currently only MDP utilizes RDMA through CMDQ, and the necessary properties for "mediatek,gce-events", and "mboxes" have been s

[PATCH v9 03/16] dt-bindings: media: mediatek: mdp3: add config for MT8195 RDMA

2023-10-31 Thread Moudy Ho
Added the configuration for MT8195 RDMA. In comparison to MT8183, it no longer shares SRAM with RSZ, and there are now preconfigured 5 mbox. Signed-off-by: Moudy Ho Reviewed-by: AngeloGioacchino Del Regno --- .../bindings/media/mediatek,mdp3-rdma.yaml| 21 +++ 1 file change

[PATCH v9 08/16] dt-bindings: media: mediatek: mdp3: add component STITCH for MT8195

2023-10-31 Thread Moudy Ho
Add the fundamental hardware configuration of component STITCH, which is controlled by MDP3 on MT8195. Signed-off-by: Moudy Ho Reviewed-by: Krzysztof Kozlowski --- .../bindings/media/mediatek,mdp3-stitch.yaml | 61 +++ 1 file changed, 61 insertions(+) create mode 100644 Docum

[PATCH v9 16/16] dt-bindings: display: mediatek: padding: add compatible for MT8195

2023-10-31 Thread Moudy Ho
Add a compatible string for the PADDING block in MediaTek MT8195 that is controlled by MDP3. Signed-off-by: Moudy Ho --- .../bindings/display/mediatek/mediatek,padding.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display

[PATCH v9 11/16] dt-bindings: display: mediatek: aal: add compatible for MT8195

2023-10-31 Thread Moudy Ho
Add a compatible string for the AAL block in MediaTek MT8195 that is controlled by MDP3. Signed-off-by: Moudy Ho Acked-by: Conor Dooley Reviewed-by: AngeloGioacchino Del Regno --- .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 1 + 1 file changed, 1 insertion(+) diff --gi

[PATCH v9 10/16] dt-bindings: media: mediatek: mdp3: add component TDSHP for MT8195

2023-10-31 Thread Moudy Ho
Add the fundamental hardware configuration of component TDSHP, which is controlled by MDP3 on MT8195. Signed-off-by: Moudy Ho Reviewed-by: Krzysztof Kozlowski --- .../bindings/media/mediatek,mdp3-tdshp.yaml | 61 +++ 1 file changed, 61 insertions(+) create mode 100644 Docume

[PATCH v9 12/16] dt-bindings: display: mediatek: color: add compatible for MT8195

2023-10-31 Thread Moudy Ho
Add a compatible string for the COLOR block in MediaTek MT8195 that is controlled by MDP3. Signed-off-by: Moudy Ho Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/mediatek/mediatek,color.yaml | 1 + 1 file changed, 1 insertion(+)

[PATCH v9 13/16] dt-bindings: display: mediatek: merge: add compatible for MT8195

2023-10-31 Thread Moudy Ho
Add a compatible string for the MERGE block in MediaTek MT8195 that is controlled by MDP3. Signed-off-by: Moudy Ho Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/mediatek/mediatek,merge.yaml | 1 + 1 file changed, 1 insertion(+)

[PATCH v9 15/16] dt-bindings: display: mediatek: split: add compatible for MT8195

2023-10-31 Thread Moudy Ho
Add compatible string and GCE property for MT8195 SPLIT, of which is operated by MDP3. Signed-off-by: Moudy Ho Reviewed-by: Krzysztof Kozlowski Reviewed-by: AngeloGioacchino Del Regno --- .../display/mediatek/mediatek,split.yaml | 27 +++ 1 file changed, 27 insertions(+)

[PATCH v9 01/16] dt-bindings: media: mediatek: mdp3: correct RDMA and WROT node with generic names

2023-10-31 Thread Moudy Ho
The DMA-related nodes RDMA/WROT in MDP3 should be changed to generic names. In addition, fix improper space indent in example. Fixes: 4ad7b39623ab ("media: dt-binding: mediatek: add bindings for MediaTek MDP3 components") Signed-off-by: Moudy Ho Acked-by: Rob Herring Reviewed-by: AngeloGioacchi

[PATCH v9 09/16] dt-bindings: media: mediatek: mdp3: add component TCC for MT8195

2023-10-31 Thread Moudy Ho
Add the fundamental hardware configuration of component TCC, which is controlled by MDP3 on MT8195. Signed-off-by: Moudy Ho Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Krzysztof Kozlowski --- .../bindings/media/mediatek,mdp3-tcc.yaml | 62 +++ 1 file changed, 62 i

[PATCH v9 00/16] introduce more MDP3 components in MT8195

2023-10-31 Thread Moudy Ho
Changes since v8: - Rebase on linux-next. - Dependent dtsi files: https://patchwork.kernel.org/project/linux-mediatek/list/?series=797543 - Depends on: Message ID = 20231024130048.14749-9-shawn.s...@mediatek.com - Following Rob's suggestion, the number of 'clocks' and 'mboxes' items are restr

[PATCH v9 05/16] dt-bindings: media: mediatek: mdp3: add compatible for MT8195 WROT

2023-10-31 Thread Moudy Ho
MT8195 WROT inherited from MT8183, add the corresponding compatible name to it. Signed-off-by: Moudy Ho Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski --- .../devicetree/bindings/media/mediatek,mdp3-wrot.yaml | 6 +- 1 file changed, 5 insertions(+), 1 deletion

[PATCH v9 14/16] dt-bindings: display: mediatek: ovl: add compatible for MT8195

2023-10-31 Thread Moudy Ho
Add a compatible string for the OVL block in MediaTek MT8195 that is controlled by MDP3. Signed-off-by: Moudy Ho Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/mediatek/mediatek,ovl.yaml | 1 + 1 file changed, 1 insertion(+) di

[PATCH v9 06/16] dt-bindings: media: mediatek: mdp3: add component FG for MT8195

2023-10-31 Thread Moudy Ho
Add the fundamental hardware configuration of component FG, which is controlled by MDP3 on MT8195. Signed-off-by: Moudy Ho Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Krzysztof Kozlowski --- .../bindings/media/mediatek,mdp3-fg.yaml | 61 +++ 1 file changed, 61 in

[PATCH v9 07/16] dt-bindings: media: mediatek: mdp3: add component HDR for MT8195

2023-10-31 Thread Moudy Ho
Add the fundamental hardware configuration of component HDR, which is controlled by MDP3 on MT8195. Signed-off-by: Moudy Ho Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Krzysztof Kozlowski --- .../bindings/media/mediatek,mdp3-hdr.yaml | 61 +++ 1 file changed, 61 i

Re: [PATCH drm-misc-next v4] drm/sched: implement dynamic job-flow control

2023-10-31 Thread kernel test robot
Hi Danilo, kernel test robot noticed the following build errors: [auto build test ERROR on b2139fb5051554a7f297e4ad584ef1bc26c76d5d] url: https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-sched-implement-dynamic-job-flow-control/20231031-082915 base

Re: [PATCH v8 16/16] dt-bindings: display: mediatek: padding: add compatible for MT8195

2023-10-31 Thread 何宗原
On Tue, 2023-10-31 at 15:43 +0800, moudy ho wrote: > On Mon, 2023-10-30 at 14:26 -0500, Rob Herring wrote: > > > > External email : Please do not click links or open attachments > > until > > you have verified the sender or the content. > > > > On Mon, 30 Oct 2023 18:00:22 +0800, Moudy Ho w

Re: [PATCH 1/4] drm/panfrost: Implement ability to turn on/off GPU clocks in suspend

2023-10-31 Thread AngeloGioacchino Del Regno
Il 30/10/23 15:57, Steven Price ha scritto: On 30/10/2023 13:22, AngeloGioacchino Del Regno wrote: Currently, the GPU is being internally powered off for runtime suspend and turned back on for runtime resume through commands sent to it, but note that the GPU doesn't need to be clocked during the

Re: [PATCH 3/4] drm/panfrost: Implement ability to turn on/off regulators in suspend

2023-10-31 Thread AngeloGioacchino Del Regno
Il 30/10/23 15:57, Steven Price ha scritto: On 30/10/2023 13:22, AngeloGioacchino Del Regno wrote: Some platforms/SoCs can power off the GPU entirely by completely cutting off power, greatly enhancing battery time during system suspend: add a new pm_feature GPU_PM_VREG_OFF to allow turning off t

Re: [Intel-gfx] [PATCH 1/4] drm: Fix color LUT rounding

2023-10-31 Thread Jani Nikula
On Fri, 13 Oct 2023, Ville Syrjala wrote: > entrirely. But perhaps a better idea would be to follow the > OpenGL int<->float conversion rules, in which case we get > the following results: Do you have a pointer to the rules handy, I couldn't find it. :( Might also add the reference to the commit

Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

2023-10-31 Thread Geert Uytterhoeven
Hi Javier, On Fri, Oct 27, 2023 at 11:33 AM Javier Martinez Canillas wrote: > Jocelyn Falempe writes: > > On 21/10/2023 00:52, Javier Martinez Canillas wrote: > >> Avoid a possible uninitialized use of the crtc_state variable in function > >> ssd132x_primary_plane_atomic_check() and avoid the fo

Re: [PATCH drm-misc-next v7 1/7] drm/gpuvm: convert WARN() to drm_WARN() variants

2023-10-31 Thread Thomas Hellström
On Mon, 2023-10-23 at 22:16 +0200, Danilo Krummrich wrote: > Use drm_WARN() and drm_WARN_ON() variants to indicate drivers the > context the failing VM resides in. > > Signed-off-by: Danilo Krummrich > --- >  drivers/gpu/drm/drm_gpuvm.c    | 32 ++-- > -- >  drivers/gpu

Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

2023-10-31 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: Hello Geert, > Hi Javier, > > On Fri, Oct 27, 2023 at 11:33 AM Javier Martinez Canillas > wrote: >> Jocelyn Falempe writes: >> > On 21/10/2023 00:52, Javier Martinez Canillas wrote: >> >> Avoid a possible uninitialized use of the crtc_state variable in function >> >>

[PATCH v2 0/6] drm/edid: split out drm_eld.[ch], add some SAD helpers

2023-10-31 Thread Jani Nikula
v2 of https://patchwork.freedesktop.org/series/123384/ Jani Nikula (6): drm/edid: split out drm_eld.h from drm_edid.h drm/eld: replace uint8_t with u8 drm/edid: include drm_eld.h only where required drm/edid: use a temp variable for sads to drop one level of dereferences drm/edid: ad

[PATCH v2 1/6] drm/edid: split out drm_eld.h from drm_edid.h

2023-10-31 Thread Jani Nikula
The drm_edid.[ch] files are starting to be a bit crowded, and with plans to add more ELD related functionality, it's perhaps cleanest to split the ELD code out to a header of its own. Include drm_eld.h from drm_edid.h for starters, and leave it to follow-up work to only include drm_eld.h where nee

[PATCH v2 3/6] drm/edid: include drm_eld.h only where required

2023-10-31 Thread Jani Nikula
Reduce the dependencies on drm_eld.h. Some files might be able to drop the dependency on drm_edid.h too with the direct inclusion of drm_eld.h. Cc: Mitul Golani Reviewed-by: Mitul Golani Signed-off-by: Jani Nikula --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c| 1 + drivers/gpu/drm/

[PATCH v2 5/6] drm/edid: add helpers to get/set struct cea_sad from/to 3-byte sad

2023-10-31 Thread Jani Nikula
Add helpers to pack/unpack SADs. Both ways and non-static, as follow-up work needs them. v2: Add include to get the declarations Cc: Mitul Golani Reviewed-by: Mitul Golani Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 34 +- drivers/gpu/drm/dr

[PATCH v2 6/6] drm/eld: add helpers to modify the SADs of an ELD

2023-10-31 Thread Jani Nikula
Occasionally it's necessary for drivers to modify the SADs of an ELD, but it's not so cool to have drivers poke at the ELD buffer directly. Using the helpers to translate between 3-byte SAD and struct cea_sad, add ELD helpers to get/set the SADs from/to an ELD. v2: s/i/sad_index/ (Mitul) Cc: Mit

[PATCH v2 2/6] drm/eld: replace uint8_t with u8

2023-10-31 Thread Jani Nikula
Unify on kernel types. Cc: Mitul Golani Reviewed-by: Chaitanya Kumar Borah Reviewed-by: Mitul Golani Signed-off-by: Jani Nikula --- include/drm/drm_eld.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/drm/drm_eld.h b/include/drm/drm_eld.h index 9bde

[PATCH v2 4/6] drm/edid: use a temp variable for sads to drop one level of dereferences

2023-10-31 Thread Jani Nikula
Use a temporary variable struct cea_sad *, instead of using struct cea_sad ** directly with the double dereferences. It's arguably easier on the eyes, and drops a set of parenthesis too. Cc: Mitul Golani Reviewed-by: Mitul Golani Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 16 +

RE: [PATCH v2 6/6] drm/eld: add helpers to modify the SADs of an ELD

2023-10-31 Thread Golani, Mitulkumar Ajitkumar
> -Original Message- > From: Nikula, Jani > Sent: Tuesday, October 31, 2023 3:47 PM > To: dri-devel@lists.freedesktop.org > Cc: intel-...@lists.freedesktop.org; Golani, Mitulkumar Ajitkumar > ; Nikula, Jani > > Subject: [PATCH v2 6/6] drm/eld: add helpers to modify the SADs of an ELD >

Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

2023-10-31 Thread Geert Uytterhoeven
Hi Javier, On Tue, Oct 31, 2023 at 11:11 AM Javier Martinez Canillas wrote: > Geert Uytterhoeven writes: > > On Fri, Oct 27, 2023 at 11:33 AM Javier Martinez Canillas > > wrote: > >> Jocelyn Falempe writes: > >> > On 21/10/2023 00:52, Javier Martinez Canillas wrote: > >> >> Avoid a possible un

Re: [PATCH drm-misc-next v7 4/7] drm/gpuvm: add an abstraction for a VM / BO combination

2023-10-31 Thread Thomas Hellström
On Mon, 2023-10-23 at 22:16 +0200, Danilo Krummrich wrote: > Add an abstraction layer between the drm_gpuva mappings of a > particular > drm_gem_object and this GEM object itself. The abstraction represents > a > combination of a drm_gem_object and drm_gpuvm. The drm_gem_object > holds > a list of

Re: [PATCH 1/4] drm/panfrost: Implement ability to turn on/off GPU clocks in suspend

2023-10-31 Thread AngeloGioacchino Del Regno
Il 31/10/23 09:59, AngeloGioacchino Del Regno ha scritto: Il 30/10/23 15:57, Steven Price ha scritto: On 30/10/2023 13:22, AngeloGioacchino Del Regno wrote: Currently, the GPU is being internally powered off for runtime suspend and turned back on for runtime resume through commands sent to it,

Re: [PATCH] drm/bridge: tc358767: Support input format negotiation hook

2023-10-31 Thread Tomi Valkeinen
Hi Jan, On 31/10/2023 08:24, Jan Kiszka wrote: On 30.10.23 20:28, Aradhya Bhatia wrote: With new connector model, tc358767 will not create the connector, when DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and display-controller driver will rely on format negotiation to setup the encoder format. Add th

Re: [PATCH v3] drm/i915: Flush WC GGTT only on required platforms

2023-10-31 Thread Nirmoy Das
This is now merged to gt-next Thanks, Nirmoy On 10/18/2023 4:04 PM, Nirmoy Das wrote: On 10/18/2023 3:00 PM, Andi Shyti wrote: Hi Nirmoy, gen8_ggtt_invalidate() is only needed for limited set of platforms where GGTT is mapped as WC. This was added as way to fix WC based GGTT in commit 0

Re: [PATCH drm-misc-next v4] drm/sched: implement dynamic job-flow control

2023-10-31 Thread Christian König
Am 31.10.23 um 01:26 schrieb Danilo Krummrich: Currently, job flow control is implemented simply by limiting the number of jobs in flight. Therefore, a scheduler is initialized with a credit limit that corresponds to the number of jobs which can be sent to the hardware. This implies that for

Re: [PATCH v3 06/15] phy: qualcomm: add MSM8974 HDMI PHY support

2023-10-31 Thread Konrad Dybcio
On 28.09.2023 13:16, Dmitry Baryshkov wrote: > Add support for HDMI PHY on Qualcomm MSM8974 / APQ8074 platforms. > > Signed-off-by: Dmitry Baryshkov > --- I only have a few style comments (and timers-howto.txt fixes) [...] > +#define HDMI_8974_VCO_MAX_FREQ 18UL > +#define HDMI_8974_VCO_

Re: [PATCH v3 07/15] phy: qualcomm: add MSM8x60 HDMI PHY support

2023-10-31 Thread Konrad Dybcio
On 28.09.2023 13:16, Dmitry Baryshkov wrote: > Add support for HDMI PHY on Qualcomm MSM8x60 / APQ8060 platforms. > > Signed-off-by: Dmitry Baryshkov > --- Do you have the PLL working locally? Would it make sense to ship them both? Konrad

Re: [PATCH drm-misc-next v7 4/7] drm/gpuvm: add an abstraction for a VM / BO combination

2023-10-31 Thread Thomas Hellström
On Mon, 2023-10-23 at 22:16 +0200, Danilo Krummrich wrote: > Add an abstraction layer between the drm_gpuva mappings of a > particular > drm_gem_object and this GEM object itself. The abstraction represents > a > combination of a drm_gem_object and drm_gpuvm. The drm_gem_object > holds > a list of

Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

2023-10-31 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: > Hi Javier, [...] >> >> Pushed to drm-misc (drm-misc-next). Thanks! >> > >> > Looks like you introduced an unintended >> > >> > (cherry picked from commit 9e4db199e66d427c50458f4d72734cc4f0b92948) >> > >> > ? >> > >> >> No, that's intended. It's added by the `dim

Re: [PATCH drm-misc-next v7 5/7] drm/gpuvm: track/lock/validate external/evicted objects

2023-10-31 Thread Thomas Hellström
On Mon, 2023-10-23 at 22:16 +0200, Danilo Krummrich wrote: > Currently the DRM GPUVM offers common infrastructure to track GPU VA > allocations and mappings, generically connect GPU VA mappings to > their > backing buffers and perform more complex mapping operations on the > GPU VA > space. > > Ho

Re: [PATCH drm-misc-next v7 4/7] drm/gpuvm: add an abstraction for a VM / BO combination

2023-10-31 Thread Jani Nikula
On Tue, 31 Oct 2023, Thomas Hellström wrote: > On Mon, 2023-10-23 at 22:16 +0200, Danilo Krummrich wrote: >> + * Returns: a pointer to the &drm_gpuvm_bo on success, NULL on > > Still needs s/Returns:/Return:/g FWIW, both work to accommodate the variance across the kernel, although I think only th

Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

2023-10-31 Thread Maxime Ripard
On Tue, Oct 31, 2023 at 12:27:05PM +0100, Javier Martinez Canillas wrote: > Geert Uytterhoeven writes: > > > Hi Javier, > > [...] > > >> >> Pushed to drm-misc (drm-misc-next). Thanks! > >> > > >> > Looks like you introduced an unintended > >> > > >> > (cherry picked from commit 9e4db199e66d

Re: exynos-mixer 14450000.mixer: [drm:exynos_drm_register_dma] *ERROR* Device 14450000.mixer lacks support for IOMMU

2023-10-31 Thread Marek Szyprowski
Hi, On 31.10.2023 00:03, Mario Marietto wrote: > We are a team of linux enthusiasts who are trying to boot Xen on a > Samsung XE303C12 Chromebook aka "snow" following the suggestions in > the slide show presentation here: > https://www.slideshare.net/xen_com_mgr/xpds16-porting-xen-on-arm-to-a-n

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-31 Thread Huacai Chen
Hi, Jaak and Evan, On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen wrote: > > On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja wrote: > > > > On 26.10.23 03:58, Huacai Chen wrote: > > > Hi, Jaak, > > > > > > On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja wrote: > > >> > > >> On 25.10.23 16:23, Huacai C

Re: [PATCH] drm/bridge: tc358767: Support input format negotiation hook

2023-10-31 Thread Jan Kiszka
On 31.10.23 11:53, Tomi Valkeinen wrote: > Hi Jan, > > On 31/10/2023 08:24, Jan Kiszka wrote: >> On 30.10.23 20:28, Aradhya Bhatia wrote: >>> With new connector model, tc358767 will not create the connector, when >>> DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and display-controller driver will >>> rely

Re: [PATCH drm-misc-next v4] drm/sched: implement dynamic job-flow control

2023-10-31 Thread Danilo Krummrich
On 10/31/23 12:13, Christian König wrote: Am 31.10.23 um 01:26 schrieb Danilo Krummrich: Currently, job flow control is implemented simply by limiting the number of jobs in flight. Therefore, a scheduler is initialized with a credit limit that corresponds to the number of jobs which can be sen

Re: [PATCH] drm/amd/display: remove redundant check

2023-10-31 Thread Greg KH
On Tue, Oct 31, 2023 at 01:42:17PM +0200, José Pekkarinen wrote: > On 2023-10-31 07:48, Greg KH wrote: > > On Mon, Oct 30, 2023 at 07:17:48PM +0200, José Pekkarinen wrote: > > > This patch addresses the following warning spotted by > > > using coccinelle where the case checked does the same > > > t

Re: [PATCH] drm/msm/dpu: Add missing safe_lut_tbl in sc8280xp catalog

2023-10-31 Thread Johan Hovold
On Mon, Oct 30, 2023 at 04:23:20PM -0700, Bjorn Andersson wrote: > During USB transfers on the SC8280XP __arm_smmu_tlb_sync() is seen to > typically take 1-2ms to complete. As expected this results in poor > performance, something that has been mitigated by proposing running the > iommu in non-stri

Re: [PATCH drm-misc-next v7 0/7] [RFC] DRM GPUVM features

2023-10-31 Thread Boris Brezillon
On Mon, 23 Oct 2023 22:16:46 +0200 Danilo Krummrich wrote: > Currently GPUVM offers common infrastructure to track GPU VA allocations > and mappings, generically connect GPU VA mappings to their backing > buffers and perform more complex mapping operations on the GPU VA space. > > However, there

Re: [PATCH] drm/msm/dpu: Add missing safe_lut_tbl in sc8280xp catalog

2023-10-31 Thread Rob Clark
On Tue, Oct 31, 2023 at 1:19 AM Manivannan Sadhasivam wrote: > > On Mon, Oct 30, 2023 at 04:23:20PM -0700, Bjorn Andersson wrote: > > During USB transfers on the SC8280XP __arm_smmu_tlb_sync() is seen to > > typically take 1-2ms to complete. As expected this results in poor > > performance, someth

Re: [PATCH] drm/msm/dpu: Add missing safe_lut_tbl in sc8280xp catalog

2023-10-31 Thread Rob Clark
On Tue, Oct 31, 2023 at 5:35 AM Johan Hovold wrote: > > On Mon, Oct 30, 2023 at 04:23:20PM -0700, Bjorn Andersson wrote: > > During USB transfers on the SC8280XP __arm_smmu_tlb_sync() is seen to > > typically take 1-2ms to complete. As expected this results in poor > > performance, something that

Re: [PATCH v5 0/4] Improve test coverage of TTM

2023-10-31 Thread Karolina Stolarek
Hi Christian, On 17.10.2023 14:10, Christian König wrote: Am 17.10.23 um 14:06 schrieb Karolina Stolarek: >> Oh! Could you at least take a look at ttm_bo_reserve_deadlock and/or interrupted subtests? I'm not 100% sure if my solution is right. Than this will have to wait till next week when I

Re: [PATCH] drm/amd/display: remove redundant check

2023-10-31 Thread José Pekkarinen
On 2023-10-31 07:48, Greg KH wrote: On Mon, Oct 30, 2023 at 07:17:48PM +0200, José Pekkarinen wrote: This patch addresses the following warning spotted by using coccinelle where the case checked does the same than the else case. drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.

[PATCH 1/2] drm/i915: Remove incomplete PVC plumbing

2023-10-31 Thread Tvrtko Ursulin
From: Tvrtko Ursulin PVC support will not be coming to i915 so get rid of its partial enablement and reduce the driver maintenance burden. Signed-off-by: Tvrtko Ursulin Reviewed-by: Andi Shyti Reviewed-by: Andrzej Hajda --- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 +- drivers/gpu/

[PATCH 2/2] drm/i915: Remove xehpsdv support

2023-10-31 Thread Tvrtko Ursulin
From: Tvrtko Ursulin XeHP SDV was a pre-production hardware used to bring up PVC and was not generally available and has since been decided will be supported in the new xe driver and not i915. v2: * Correct historical fact SDV was for PVC, not ATS. (John) Signed-off-by: Tvrtko Ursulin Cc: Joh

Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

2023-10-31 Thread Geert Uytterhoeven
Hi Maxime, On Tue, Oct 31, 2023 at 12:53 PM Maxime Ripard wrote: > On Tue, Oct 31, 2023 at 12:27:05PM +0100, Javier Martinez Canillas wrote: > > Geert Uytterhoeven writes: > > >> >> Pushed to drm-misc (drm-misc-next). Thanks! > > >> > > > >> > Looks like you introduced an unintended > > >> > > >

Re: [REGRESSION] rx7600 stopped working after "1cfb4d612127 drm/amdgpu: put MQDs in VRAM"

2023-10-31 Thread Christian König
Hi Alexey, trying to answer some of the questions since Alex is currently on vacation. Am 30.10.23 um 17:01 schrieb Alexey Klimov: Hi Alex, On Thu, 26 Oct 2023 at 19:53, Alex Deucher wrote: On Thu, Oct 26, 2023 at 1:33 PM Alexey Klimov wrote: #regzbot introduced: 1cfb4d612127 #regzbot titl

Re: [PATCH] drm/bridge: tc358767: Support input format negotiation hook

2023-10-31 Thread Tomi Valkeinen
On 31/10/2023 14:18, Jan Kiszka wrote: On 31.10.23 11:53, Tomi Valkeinen wrote: Hi Jan, On 31/10/2023 08:24, Jan Kiszka wrote: On 30.10.23 20:28, Aradhya Bhatia wrote: With new connector model, tc358767 will not create the connector, when DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and display-cont

Re: [PATCH] drm/amd/display: remove redundant check

2023-10-31 Thread José Pekkarinen
On 2023-10-31 14:20, Greg KH wrote: On Tue, Oct 31, 2023 at 01:42:17PM +0200, José Pekkarinen wrote: On 2023-10-31 07:48, Greg KH wrote: > On Mon, Oct 30, 2023 at 07:17:48PM +0200, José Pekkarinen wrote: > > This patch addresses the following warning spotted by > > using coccinelle where the cas

Re: [PATCH 1/4] drm/panfrost: Implement ability to turn on/off GPU clocks in suspend

2023-10-31 Thread AngeloGioacchino Del Regno
Il 31/10/23 04:18, Chen-Yu Tsai ha scritto: On Mon, Oct 30, 2023 at 9:23 PM AngeloGioacchino Del Regno wrote: Currently, the GPU is being internally powered off for runtime suspend and turned back on for runtime resume through commands sent to it, but note that the GPU doesn't need to be clock

Re: [PATCH drm-misc-next v3] drm/sched: implement dynamic job-flow control

2023-10-31 Thread Christian König
Hi Danilo, sorry for splitting up the mail thread. I had to fetch this mail from my spam folder for some reason. Am 30.10.23 um 18:56 schrieb Danilo Krummrich: Hi Christian, [SNIP] And yes, we can live with the overhead of making jobs slightly bigger than they actually are, thus potentially

[PATCH 0/2] drm/bridge: tc358767: Fix DRM_BRIDGE_ATTACH_NO_CONNECTOR case

2023-10-31 Thread Tomi Valkeinen
discovery drivers/gpu/drm/bridge/tc358767.c | 32 1 file changed, 32 insertions(+) --- base-commit: 79d94360d50fcd487edcfe118a47a2881534923f change-id: 20231031-tc358767-58e3ebdf95f0 Best regards, -- Tomi Valkeinen

[PATCH 2/2] drm/bridge: tc358767: Fix link properties discovery

2023-10-31 Thread Tomi Valkeinen
When a display controller driver uses DRM_BRIDGE_ATTACH_NO_CONNECTOR, tc358767 will behave properly and skip the creation of the connector. However, tc_get_display_props(), which is used to find out about the DP monitor and link, is only called from two places: .atomic_enable() and tc_connector_ge

[PATCH 1/2] drm/bridge: tc358767: Support input format negotiation hook

2023-10-31 Thread Tomi Valkeinen
From: Aradhya Bhatia With new connector model, tc358767 will not create the connector, when DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and display-controller driver will rely on format negotiation to setup the encoder format. Add the missing input-format negotiation hook in the drm_bridge_funcs to co

Re: [PATCH v3 07/15] phy: qualcomm: add MSM8x60 HDMI PHY support

2023-10-31 Thread Dmitry Baryshkov
On Tue, 31 Oct 2023 at 13:17, Konrad Dybcio wrote: > > On 28.09.2023 13:16, Dmitry Baryshkov wrote: > > Add support for HDMI PHY on Qualcomm MSM8x60 / APQ8060 platforms. > > > > Signed-off-by: Dmitry Baryshkov > > --- > Do you have the PLL working locally? Would it make sense to ship them both?

Re: [PATCH] drm/sched: Convert the GPU scheduler to variable number of run-queues

2023-10-31 Thread Danilo Krummrich
On 10/26/23 19:25, Luben Tuikov wrote: On 2023-10-26 12:39, Danilo Krummrich wrote: On 10/23/23 05:22, Luben Tuikov wrote: The GPU scheduler has now a variable number of run-queues, which are set up at drm_sched_init() time. This way, each driver announces how many run-queues it requires (sup

[PATCH 0/6] drm/amdgpu: Add flag to disable implicit sync for GEM operations.

2023-10-31 Thread Tatsuyuki Ishi
In Vulkan, it is the application's responsibility to perform adequate synchronization before a sparse unmap, replace or BO destroy operation. This adds an option to AMDGPU_VA_OPs to disable redundant implicit sync that happens on sparse unmap or replace operations. This has seen a significant impr

[PATCH 2/6] drm/amdgpu: Separate eviction from VM status.

2023-10-31 Thread Tatsuyuki Ishi
In short, eviction never really belonged to the vm_status state machine. Even when evicted, the BO could belong to either the moved or done state. The "evicted" state needed to handle both cases, causing greater confusion. Additionally, there were inconsistencies in the definition of an evicted BO

[PATCH 1/6] drm/amdgpu: Don't implicit sync PRT maps.

2023-10-31 Thread Tatsuyuki Ishi
These are considered map operations rather than unmap, and there is no point of doing implicit synchronization here. Signed-off-by: Tatsuyuki Ishi --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

[PATCH 6/6] drm/amdgpu: Bump amdgpu driver version.

2023-10-31 Thread Tatsuyuki Ishi
For detection of the new explicit sync functionality without having to try the ioctl. Signed-off-by: Tatsuyuki Ishi --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amd

[PATCH 5/6] drm/amdgpu: Add flag to disable implicit sync for GEM operations.

2023-10-31 Thread Tatsuyuki Ishi
In Vulkan, it is the application's responsibility to perform adequate synchronization before a sparse unmap, replace or BO destroy operation. Until now, the kernel applied the same rule as implicitly-synchronized APIs like OpenGL, which with per-VM BOs made page table updates stall the queue comple

[PATCH 4/6] drm/amdgpu: Remove redundant state change after validation.

2023-10-31 Thread Tatsuyuki Ishi
All the state changes are handled in the TTM move callback; doing it again here just leads to more confusion. The table update remains here because it needs to be done exactly once, while doing it in the move callback will result it getting triggered twice, once by the actual BO and once by the sh

[PATCH 3/6] drm/amdgpu: Flush VM updates for split bindings eagerly.

2023-10-31 Thread Tatsuyuki Ishi
The current amdgpu_gem_va_update_vm only tries to perform updates for the BO specified in the GEM ioctl; however, when a binding is split, the adjacent bindings also need to be updated. Such updates currently ends up getting deferred until next submission which causes stalls. Introduce a new state

Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

2023-10-31 Thread Maxime Ripard
On Tue, Oct 31, 2023 at 02:00:06PM +0100, Geert Uytterhoeven wrote: > Hi Maxime, > > On Tue, Oct 31, 2023 at 12:53 PM Maxime Ripard wrote: > > On Tue, Oct 31, 2023 at 12:27:05PM +0100, Javier Martinez Canillas wrote: > > > Geert Uytterhoeven writes: > > > >> >> Pushed to drm-misc (drm-misc-next)

Re: [PATCH 2/6] drm/amdgpu: Separate eviction from VM status.

2023-10-31 Thread Christian König
Am 31.10.23 um 14:40 schrieb Tatsuyuki Ishi: In short, eviction never really belonged to the vm_status state machine. I strongly disagree to that. Even when evicted, the BO could belong to either the moved or done state. The "evicted" state needed to handle both cases, causing greater confusi

Re: [PATCH 3/6] drm/amdgpu: Flush VM updates for split bindings eagerly.

2023-10-31 Thread Christian König
Am 31.10.23 um 14:40 schrieb Tatsuyuki Ishi: The current amdgpu_gem_va_update_vm only tries to perform updates for the BO specified in the GEM ioctl; however, when a binding is split, the adjacent bindings also need to be updated. Such updates currently ends up getting deferred until next submiss

Re: [PATCH 3/6] drm/amdgpu: Flush VM updates for split bindings eagerly.

2023-10-31 Thread Bas Nieuwenhuizen
On Tue, Oct 31, 2023 at 2:57 PM Christian König wrote: > Am 31.10.23 um 14:40 schrieb Tatsuyuki Ishi: > > The current amdgpu_gem_va_update_vm only tries to perform updates for the > > BO specified in the GEM ioctl; however, when a binding is split, the > > adjacent bindings also need to be update

Re: [PATCH 4/6] drm/amdgpu: Remove redundant state change after validation.

2023-10-31 Thread Christian König
Am 31.10.23 um 14:40 schrieb Tatsuyuki Ishi: All the state changes are handled in the TTM move callback; doing it again here just leads to more confusion. The state move here is because we need to track which PDs/PTs are already validated and which have new locations reflected in the PDEs. W

Re: [PATCH v6 06/10] drm/msm/dpu: deduplicate some (most) of SSPP sub-blocks

2023-10-31 Thread Abhinav Kumar
On 10/31/2023 1:16 AM, Dmitry Baryshkov wrote: On Mon, 30 Oct 2023 at 21:52, Abhinav Kumar wrote: On 10/6/2023 6:14 AM, Dmitry Baryshkov wrote: As we have dropped the variadic parts of SSPP sub-blocks declarations, deduplicate them now, reducing memory cruft. Signed-off-by: Dmitry Barys

Re: [PATCH 3/6] drm/amdgpu: Flush VM updates for split bindings eagerly.

2023-10-31 Thread Christian König
Am 31.10.23 um 14:59 schrieb Bas Nieuwenhuizen: On Tue, Oct 31, 2023 at 2:57 PM Christian König wrote: Am 31.10.23 um 14:40 schrieb Tatsuyuki Ishi: > The current amdgpu_gem_va_update_vm only tries to perform updates for the > BO specified in the GEM ioctl; however, when a bi

  1   2   3   >