Re: [PATCH] drm/i915: Flush WC GGTT only on required platforms

2023-10-16 Thread Nirmoy Das
On 10/13/2023 6:15 PM, Daniel Vetter wrote: On Fri, Oct 13, 2023 at 02:28:21PM +0200, Nirmoy Das wrote: Hi Ville, On 10/13/2023 12:50 PM, Ville Syrjälä wrote: On Fri, Oct 13, 2023 at 12:31:40PM +0200, Nirmoy Das wrote: gen8_ggtt_invalidate() is only needed for limitted set of platforms wher

Re: [PATCH] drm/tidss: Power up attached PM domains on probe

2023-10-16 Thread Devarsh Thakkar
Hi Maxime, On 12/10/23 18:10, Maxime Ripard wrote: > Hi, > > On Thu, Oct 12, 2023 at 05:10:06PM +0530, Devarsh Thakkar wrote: >> On 09/10/23 13:20, Devarsh Thakkar wrote: >>> Some SoC's such as AM62P have dedicated power domains >>> for OLDI which need to be powered on separetely along >>> with d

Re: [PATCH v2] drm/i915: Flush WC GGTT only on required platforms

2023-10-16 Thread Nirmoy Das
Hi Andi, On 10/14/2023 10:51 AM, Andi Shyti wrote: Hi Nirmoy, On Fri, Oct 13, 2023 at 03:44:39PM +0200, Nirmoy Das wrote: gen8_ggtt_invalidate() is only needed for limited set of platforms where GGTT is mapped as WC otherwise this can cause unwanted side-effects on XE_HP platforms where GFX_FL

[Bug 218015] New: amdgpu powerplay: Spontaneous changes to power_dpm_force_performance_level

2023-10-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218015 Bug ID: 218015 Summary: amdgpu powerplay: Spontaneous changes to power_dpm_force_performance_level Product: Drivers Version: 2.5 Kernel Version: 6.1.57 Hardware: All

Re: [PATCH v11 06/16] drm/mediatek: gamma: Use bitfield macros

2023-10-16 Thread AngeloGioacchino Del Regno
Il 13/10/23 06:00, CK Hu (胡俊光) ha scritto: Hi, Angelo: On Thu, 2023-10-12 at 11:57 +0200, AngeloGioacchino Del Regno wrote: Make the code more robust and improve readability by using bitfield macros instead of open coding bit operations. While at it, also add a definition for LUT_BITS_DEFAULT.

[Bug 218015] amdgpu powerplay: Spontaneous changes to power_dpm_force_performance_level

2023-10-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218015 --- Comment #1 from Roman Žilka (roman.zi...@gmail.com) --- Created attachment 305225 --> https://bugzilla.kernel.org/attachment.cgi?id=305225&action=edit config-6.1.57 -- You may reply to this email to add a comment. You are receiving this m

[Bug 218015] amdgpu powerplay: Spontaneous changes to power_dpm_force_performance_level

2023-10-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218015 --- Comment #2 from Roman Žilka (roman.zi...@gmail.com) --- Created attachment 305226 --> https://bugzilla.kernel.org/attachment.cgi?id=305226&action=edit lspci -vv -- You may reply to this email to add a comment. You are receiving this mail

Re: [PATCH v7 15/16] dt-bindings: display: mediatek: split: add compatible for MT8195

2023-10-16 Thread AngeloGioacchino Del Regno
Il 13/10/23 08:52, Krzysztof Kozlowski ha scritto: On 12/10/2023 10:40, Moudy Ho wrote: Add compatible string and GCE property for MT8195 SPLIT, of which is operated by MDP3. Signed-off-by: Moudy Ho +allOf: + - if: + properties: +compatible: + contains: +

Re: [Intel-gfx] [PATCH] drm/i915/gem: Allow users to disable waitboost

2023-10-16 Thread Tvrtko Ursulin
On 13/10/2023 21:51, Rodrigo Vivi wrote: On Thu, Sep 28, 2023 at 01:48:34PM +0100, Tvrtko Ursulin wrote: On 27/09/2023 20:34, Belgaumkar, Vinay wrote: On 9/21/2023 3:41 AM, Tvrtko Ursulin wrote: On 20/09/2023 22:56, Vinay Belgaumkar wrote: Provide a bit to disable waitboost while waiting

Re: [PATCH] drm/bridge: adv7511: fix crash on irq during probe

2023-10-16 Thread Laurent Pinchart
Hello Alvin, On Sat, Oct 14, 2023 at 08:46:12PM +0200, Alvin Šipraga wrote: > From: Mads Bligaard Nielsen > > Moved IRQ registration down to end of adv7511_probe(). > > If an IRQ already is pending during adv7511_probe > (before adv7511_cec_init) then cec_received_msg_ts > could crash using uni

Re: [PATCH] drm: bridge: adv7511: get edid in hpd_work to update CEC phys address

2023-10-16 Thread Laurent Pinchart
Hi Alvin, Thank you for the patch. CC'ing Hans Verkuil, to review the CEC side. On Sat, Oct 14, 2023 at 09:43:01PM +0200, Alvin Šipraga wrote: > From: Alvin Šipraga > > The adv7511 driver is solely responsible for setting the physical > address of its CEC adapter. To do this, it must read the

Re: [PATCH v10 1/7] drm: bridge: Cadence: Creat mhdp helper driver

2023-10-16 Thread Alexander Stein
Hi Sandor, Am Montag, 16. Oktober 2023, 05:05:54 CEST schrieb Sandor Yu: > Hi Alexander, > > Thanks your comments, > > > Hi Sandor, > > > > thanks for the updated series. > > > > Am Freitag, 13. Oktober 2023, 05:24:20 CEST schrieb Sandor Yu: > > > MHDP8546 mailbox access functions will be shar

Re: [PATCH 3/5] drm/panel: st7703: Add Powkiddy RGB30 Panel Support

2023-10-16 Thread Guido Günther
Hi Chris, On Fri, Oct 13, 2023 at 01:39:16PM -0500, Chris Morgan wrote: > From: Chris Morgan > > The Powkiddy RGB30 4 inch panel is a 4 inch 720x720 DSI panel used in > the Powkiddy RGB30 handheld gaming device. Add support for it. > > TODO: The panel seems to not resume properly from suspend. I

[Bug 218015] amdgpu powerplay: Spontaneous changes to power_dpm_force_performance_level

2023-10-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218015 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

Re: [PATCH] drm/bridge: adv7511: fix crash on irq during probe

2023-10-16 Thread Alvin Šipraga
Hi Laurent, Thanks for the quick review! On Mon, Oct 16, 2023 at 11:14:44AM +0300, Laurent Pinchart wrote: > Hello Alvin, > > On Sat, Oct 14, 2023 at 08:46:12PM +0200, Alvin Šipraga wrote: > > From: Mads Bligaard Nielsen > > > > Moved IRQ registration down to end of adv7511_probe(). > > > > I

Re: [PATCH] drm: bridge: adv7511: get edid in hpd_work to update CEC phys address

2023-10-16 Thread Alvin Šipraga
Hi Laurent, On Mon, Oct 16, 2023 at 11:17:49AM +0300, Laurent Pinchart wrote: > Hi Alvin, > > Thank you for the patch. > > CC'ing Hans Verkuil, to review the CEC side. > > On Sat, Oct 14, 2023 at 09:43:01PM +0200, Alvin Šipraga wrote: > > From: Alvin Šipraga > > > > The adv7511 driver is sole

[PATCH v5 0/4] Improve test coverage of TTM

2023-10-16 Thread Karolina Stolarek
Add tests for building blocks of the TTM subsystem, such as ttm_resource, ttm_resource_manager, ttm_tt and ttm_buffer_object. This series covers basic functions such as initialization, allocation and clean-up of each struct. Testing of ttm_buffer_object also includes locking and unlocking the objec

[PATCH v5 1/4] drm/ttm/tests: Add tests for ttm_resource and ttm_sys_man

2023-10-16 Thread Karolina Stolarek
Test initialization of ttm_resource using different memory domains. Add tests for a system memory manager and functions that can be tested without a fully-featured resource manager. Update ttm_bo_kunit_init() to initialize BO's kref and a genuine GEM drm object. Export ttm_resource_alloc for test p

[PATCH v5 3/4] drm/ttm/tests: Add tests for ttm_bo functions

2023-10-16 Thread Karolina Stolarek
Test reservation and release of TTM buffer objects. Add tests to check pin and unpin operations. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/Makefile| 1 + drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 619 ++ drivers/gpu/drm/ttm/tests/ttm_kunit

[PATCH v5 2/4] drm/ttm/tests: Add tests for ttm_tt

2023-10-16 Thread Karolina Stolarek
Test initialization, creation and destruction of ttm_tt instances. Export ttm_tt_destroy and ttm_tt_create symbols for testing purposes. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/Makefile| 1 + drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 20 ++ drivers/gpu

[PATCH v5 4/4] drm/ttm/tests: Fix argument in ttm_tt_kunit_init()

2023-10-16 Thread Karolina Stolarek
Remove a leftover definition of page order and pass an empty flag value in ttm_pool_pre_populated(). Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_pool_test.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/tests/ttm_pool_test.c b/d

Re: [PATCH v2 5/8] drm: adv7511: Add reg_cec_offset variable to struct adv7511_chip_info

2023-10-16 Thread Robert Foss
On Wed, Aug 30, 2023 at 4:24 PM Biju Das wrote: > > The ADV7533 and ADV7535 have an offset(0x70) for the CEC register map > compared to ADV7511. Add the reg_cec_offset variable to struct > adv7511_chip_info to handle this difference and drop the reg_cec_offset > variable from struct adv7511. > > T

Re: [PATCH v2 8/8] drm: adv7511: Add hpd_override_enable variable to struct adv7511_chip_info

2023-10-16 Thread Robert Foss
On Wed, Aug 30, 2023 at 4:25 PM Biju Das wrote: > > As per spec, it is allowed to pulse the HPD signal to indicate that the > EDID information has changed. Some monitors do this when they wake up > from standby or are enabled. When the HPD goes low the adv7511 is > reset and the outputs are disabl

Re: [PATCH v2 7/8] drm: adv7511: Add link_config variable to struct adv7511_chip_info

2023-10-16 Thread Robert Foss
On Wed, Aug 30, 2023 at 4:25 PM Biju Das wrote: > > The ADV7511 needs link configuration whereas ADV75{33,35} does not need > it. Add a variable link_config to struct adv7511_chip_info to handle > this difference. > > Signed-off-by: Biju Das > Reviewed-by: Laurent Pinchart > --- > v1->v2: > * A

Re: [PATCH v2 6/8] drm: adv7511: Add has_dsi variable to struct adv7511_chip_info

2023-10-16 Thread Robert Foss
On Wed, Aug 30, 2023 at 4:24 PM Biju Das wrote: > > The ADV7533 and ADV7535 have DSI support. Add a variable has_dsi to > struct adv7511_chip_info for handling configuration related to DSI. > > Signed-off-by: Biju Das > --- > v1->v2: > * Replaced variable type from unsigned->bool. > * Restored

Re: [PATCH v2 4/8] drm: adv7511: Add supply_names and num_supplies variables to struct adv7511_chip_info

2023-10-16 Thread Robert Foss
On Wed, Aug 30, 2023 at 4:24 PM Biju Das wrote: > > The ADV7511 has 5 power supplies compared to 7 that of ADV75{33,35}. Add > supply_names and num_supplies variables to struct adv7511_chip_info to > handle this difference. > > Signed-off-by: Biju Das > Reviewed-by: Laurent Pinchart > --- > v1->

Re: [PATCH v2 3/8] drm: adv7511: Add max_lane_freq_khz variable to struct adv7511_chip_info

2023-10-16 Thread Robert Foss
On Wed, Aug 30, 2023 at 4:24 PM Biju Das wrote: > > The ADV7533 supports a maximum lane clock of 800MHz whereas it is 891MHz > for ADV7535. Add max_lane_freq_khz variable to struct adv7511_chip_info to > handle this difference. > > While at it, drop the unused local variable max_lane_freq. > > Sig

Re: [PATCH v2 2/8] drm: adv7511: Add max_mode_clock_khz variable to struct adv7511_chip_info

2023-10-16 Thread Robert Foss
On Wed, Aug 30, 2023 at 4:24 PM Biju Das wrote: > > The ADV7533 supports a maximum pixel clock of 80MHz whereas it is 148.5MHz > for ADV7535. Add max_mode_clock_khz variable to struct adv7511_chip_info to > handle this difference. > > Signed-off-by: Biju Das > Reviewed-by: Adam Ford > Tested-by:

Re: [PATCH v2 1/8] drm: adv7511: Add struct adv7511_chip_info and use i2c_get_match_data()

2023-10-16 Thread Robert Foss
On Wed, Aug 30, 2023 at 4:24 PM Biju Das wrote: > > Add struct adv7511_chip_info to handle hw differences between various > chips rather checking against the 'type' variable in various places. > Replace 'adv->type'->'info->type' by moving variable 'type' from > struct adv7511 to struct adv7511_chi

Re: [PATCH v2 0/8] ADV7511 driver enhancements

2023-10-16 Thread Robert Foss
On Wed, 30 Aug 2023 15:23:50 +0100, Biju Das wrote: > This patch series aims to improve ADV7511 driver by adding > feature bits and data instead of comparing enum adv7511_type for > various hardware differences between ADV7511, ADV7533 and ADV7535. > > This patch series tested with[1] on RZ/G2L SM

RE: [EXT] Re: [PATCH v10 1/7] drm: bridge: Cadence: Creat mhdp helper driver

2023-10-16 Thread Sandor Yu
Hi Alexander, > > Hi Sandor, > > Am Montag, 16. Oktober 2023, 05:05:54 CEST schrieb Sandor Yu: > > Hi Alexander, > > > > Thanks your comments, > > > > > Hi Sandor, > > > > > > thanks for the updated series. > > > > > > Am Freitag, 13. Oktober 2023, 05:24:20 CEST schrieb Sandor Yu: > > > > MHDP8546

RE: [PATCH v2 0/8] ADV7511 driver enhancements

2023-10-16 Thread Biju Das
> Subject: Re: [PATCH v2 0/8] ADV7511 driver enhancements > > On Wed, 30 Aug 2023 15:23:50 +0100, Biju Das wrote: > > This patch series aims to improve ADV7511 driver by adding feature > > bits and data instead of comparing enum adv7511_type for various > > hardware differences between ADV7511, AD

Re: [PATCH v3 RESEND 4/9] drm/bridge: synopsys: dw-mipi-dsi: Add mode fixup support

2023-10-16 Thread Robert Foss
On Mon, Aug 21, 2023 at 5:37 AM Liu Ying wrote: > > Vendor drivers may need to fixup mode due to pixel clock tree limitation, > so introduce the ->mode_fixup() callcack to struct dw_mipi_dsi_plat_data > and call it at atomic check stage if available. > > Signed-off-by: Liu Ying > --- > v1->v3: >

Re: [PATCH v3 RESEND 3/9] drm/bridge: synopsys: dw-mipi-dsi: Force input bus flags

2023-10-16 Thread Robert Foss
On Mon, Aug 21, 2023 at 5:37 AM Liu Ying wrote: > > The DATAEN_ACTIVE_LOW bit in DSI_DPI_CFG_POL register is set to zero, > so set the DRM_BUS_FLAG_DE_HIGH flag in input_bus_cfg.flags. It appears > that the DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE flag also makes sense, so > set it in input_bus_cfg.fl

Re: [PATCH v3 RESEND 2/9] drm/bridge: synopsys: dw-mipi-dsi: Add input bus format negotiation support

2023-10-16 Thread Robert Foss
On Mon, Aug 21, 2023 at 5:37 AM Liu Ying wrote: > > Introduce ->get_input_bus_fmts() callback to struct dw_mipi_dsi_plat_data > so that vendor drivers can implement specific methods to get input bus > formats for Synopsys DW MIPI DSI. > > While at it, implement a generic callback for ->atomic_get_

Re: [PATCH v3 RESEND 1/9] drm/bridge: synopsys: dw-mipi-dsi: Add dw_mipi_dsi_get_bridge() helper

2023-10-16 Thread Robert Foss
On Mon, Aug 21, 2023 at 5:37 AM Liu Ying wrote: > > Add dw_mipi_dsi_get_bridge() helper so that it can be used by vendor > drivers which implement vendor specific extensions to Synopsys DW MIPI DSI. > > Signed-off-by: Liu Ying > --- > v1->v3: > * No change. > > drivers/gpu/drm/bridge/synopsys/dw

Re: [PATCH v3 RESEND 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-10-16 Thread Robert Foss
On Mon, Aug 21, 2023 at 5:38 AM Liu Ying wrote: > > Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host > controller and a Synopsys Designware MIPI DPHY. Some configurations > and extensions to them are controlled by i.MX93 media blk-ctrl. > > Add a DRM bridge for i.MX93 MIPI DSI by u

RE: [PATCH v2 5/8] drm: adv7511: Add reg_cec_offset variable to struct adv7511_chip_info

2023-10-16 Thread Biju Das
Hi Robert Foss, Thanks for the feedback. > Subject: Re: [PATCH v2 5/8] drm: adv7511: Add reg_cec_offset variable to > struct adv7511_chip_info > > On Wed, Aug 30, 2023 at 4:24 PM Biju Das > wrote: > > > > The ADV7533 and ADV7535 have an offset(0x70) for the CEC register map > > compared to ADV7

Re: [PATCH v3 RESEND 0/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-10-16 Thread Robert Foss
On Mon, 21 Aug 2023 11:39:59 +0800, Liu Ying wrote: > This series aims to add MIPI DSI support for Freescale i.MX93 SoC. > > There is a Synopsys DesignWare MIPI DSI host controller and a Synopsys > Designware MIPI DPHY embedded in i.MX93. Some configurations and > extensions to them are controlle

Re: [PATCH] drm/bridge: lt9611uxc: fix the race in the error path

2023-10-16 Thread Robert Foss
On Thu, 12 Oct 2023 01:00:02 +0300, Dmitry Baryshkov wrote: > If DSI host attachment fails, the LT9611UXC driver will remove the > bridge without ensuring that there is no outstanding HPD work being > done. In rare cases this can result in the warnings regarding the mutex > being incorrect. Fix thi

[GIT PULL v2] drm: renesas: shmobile: Atomic conversion + DT support (was: Re: [PATCH v4 00/41] drm: renesas: shmobile: Atomic conversion + DT support)

2023-10-16 Thread Geert Uytterhoeven
Hi David, Daniel, The following changes since commit 389af786f92ecdff35883551d54bf4e507ffcccb: Merge tag 'drm-intel-next-2023-09-29' of git://anongit.freedesktop.org/drm/drm-intel into drm-next (2023-10-04 13:55:19 +1000) are available in the Git repository at: git://git.kernel.org/

Re: [PATCH v5 6/7] drm/ssd130x: Fix atomic_check for disabled planes

2023-10-16 Thread Thomas Zimmermann
Hi Am 13.10.23 um 19:16 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, The plane's atomic_check returns -EINVAL if the CRTC has not been set. This is the case for disabled planes, for which atomic_check should return 0. For disabled planes, it also omits the mandat

[PATCH v8 01/23] dt-bindings: display: mediatek: ethdr: Add compatible for MT8188

2023-10-16 Thread Hsiao Chien Sung
Add compatible name for MediaTek MT8188 ETHDR. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- .../bindings/display/mediatek/mediatek,ethdr.yaml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

[PATCH v8 16/23] drm/mediatek: Start/Stop components with function pointers

2023-10-16 Thread Hsiao Chien Sung
By registering component related functions to the pointers, we can easily manage them within a for-loop and simplify the logic of component start/stop process. Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 20 +-- 1 file c

[PATCH v8 05/23] dt-bindings: arm: mediatek: Add compatible for MT8188

2023-10-16 Thread Hsiao Chien Sung
Add compatible name for MediaTek MT8188 VDOSYS1. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Signed-off-by: Hsiao Chien Sung --- .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicet

[PATCH v8 20/23] drm/mediatek: Remove the redundant driver data for DPI

2023-10-16 Thread Hsiao Chien Sung
DPI input is in 1T2P mode on both MT8195 and MT8188. Remove the redundant driver data to align the settings, or the screen will glitch. Fixes: 2847cd7e6403 ("drm/mediatek: Add mt8188 dpi compatibles and platform data") Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/med

[PATCH v8 02/23] dt-bindings: display: mediatek: mdp-rdma: Add compatible for MT8188

2023-10-16 Thread Hsiao Chien Sung
Add compatible name for MediaTek MT8188 MDP-RDMA. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- .../bindings/display/mediatek/mediatek,mdp-rdma.yaml| 6 +- 1 file changed, 5 insertions(+), 1 deletion(-

[PATCH v8 19/23] drm/mediatek: Return error if MDP RDMA failed to enable the clock

2023-10-16 Thread Hsiao Chien Sung
Return the result of clk_prepare_enable() instead of always returns 0. Fixes: f8946e2b6bb2 ("drm/mediatek: Add display MDP RDMA support for MT8195") Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_mdp_rdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletio

[PATCH v8 11/23] drm/mediatek: Rename OVL_ADAPTOR_TYPE_RDMA

2023-10-16 Thread Hsiao Chien Sung
Rename OVL_ADAPTOR_TYPE_RDMA to OVL_ADAPTOR_TYPE_MDP_RDMA to align the naming rule of mtk_ovl_adaptor_comp_id. Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 22 +-- 1 file changed, 11 insertions(+), 11 deletions(-) diff -

[PATCH v8 00/23] Add display driver for MT8188 VDOSYS1

2023-10-16 Thread Hsiao Chien Sung
This series is based on mediatek-drm-next. Changes in v8: - Power on/off the components with .power_on() and .power_off() - Remove mtk_padding_config() - Remove Reviewed-by tags in "drm/mediatek: Add Padding to OVL adaptor" because of the modifications. Changes in v7: - Start/Stop the component

[PATCH v8 14/23] drm/mediatek: Add component ID to component match structure

2023-10-16 Thread Hsiao Chien Sung
Add component ID to component match structure so we can configure them with a for-loop. The main reason we do such code refactoring is that there is a new hardware component called "Padding" since MT8188, while MT8195 doesn't have this module, we can't use the original logic to manage the componen

[PATCH v8 06/23] dt-bindings: reset: mt8188: Add VDOSYS reset control bits

2023-10-16 Thread Hsiao Chien Sung
Add MT8188 VDOSYS0 and VDOSYS1 reset control bits. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Signed-off-by: Hsiao Chien Sung --- include/dt-bindings/reset/mt8188-resets.h | 75 +++ 1 file changed, 75 insertions(+) diff --git a/include/dt-bindin

[PATCH v8 23/23] drm/mediatek: Support MT8188 VDOSYS1 in display driver

2023-10-16 Thread Hsiao Chien Sung
- The mmsys_dev_num in MT8188 VDOSYS0 was set to 1 since VDOSYS1 was not available before. Increase it to support VDOSYS1 in display driver. - Add compatible name for MT8188 VDOSYS1 (shares the same driver data with MT8195 VDOSYS1) Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu

[PATCH v8 03/23] dt-bindings: display: mediatek: merge: Add compatible for MT8188

2023-10-16 Thread Hsiao Chien Sung
Add compatible name for MediaTek MT8188 MERGE. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- .../devicetree/bindings/display/mediatek/mediatek,merge.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/D

[PATCH v8 12/23] drm/mediatek: Refine device table of OVL adaptor

2023-10-16 Thread Hsiao Chien Sung
- Adjust indentation to align with other files - Sort device table in alphabetical order - Add sentinel to device table Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-)

[PATCH v8 09/23] soc: mediatek: Support reset bit mapping in mmsys driver

2023-10-16 Thread Hsiao Chien Sung
- Reset ID must starts from 0 and be consecutive, but the reset bits in our hardware design is not continuous, some bits are left unused, we need a map to solve the problem - Use old style 1-to-1 mapping if .rst_tb is not defined Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao C

[PATCH v8 07/23] soc: mediatek: Support MT8188 VDOSYS1 in mtk-mmsys

2023-10-16 Thread Hsiao Chien Sung
- Add register definitions for MT8188 - Add VDOSYS1 routing table - Update MUTEX definitions accordingly - Set VSYNC length from 0x40 (default) to 1 since ETHDR is bypassed Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/soc/mediatek/mt8188-mmsys.h | 126 +++

[PATCH v8 08/23] soc: mediatek: Support MT8188 VDOSYS1 Padding in mtk-mmsys

2023-10-16 Thread Hsiao Chien Sung
- Add Padding components - Add Mutex module definitions for Padding Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/soc/mediatek/mtk-mutex.c | 16 include/linux/soc/mediatek/mtk-mmsys.h | 8 2 files changed, 24 insertions(+)

[PATCH v8 18/23] drm/mediatek: Add Padding to OVL adaptor

2023-10-16 Thread Hsiao Chien Sung
Add MT8188 Padding to OVL adaptor to probe the driver. Signed-off-by: Hsiao Chien Sung --- .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 26 +++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c b/drivers/gpu/drm/mediatek/mtk_disp_o

[PATCH v8 13/23] drm/mediatek: Sort OVL adaptor components

2023-10-16 Thread Hsiao Chien Sung
Sort OVL adaptor components' names in alphabetical order. Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c| 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c

[PATCH v8 21/23] drm/mediatek: Fix underrun in VDO1 when switches off the layer

2023-10-16 Thread Hsiao Chien Sung
Do not reset Merge while using CMDQ because reset API doesn't wait for frame done event as CMDQ does and could lead to underrun when the layer is switching off. Fixes: aaf94f7c3ae6 ("drm/mediatek: Add display merge async reset control") Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediat

[PATCH v8 10/23] soc: mediatek: Add MT8188 VDOSYS reset bit map

2023-10-16 Thread Hsiao Chien Sung
Add MT8188 reset bit map for VDOSYS0 and VDOSYS1. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/soc/mediatek/mt8188-mmsys.h | 84 + drivers/soc/mediatek/mtk-mmsys.c| 7 ++- 2 files changed, 90 insertions(+), 1 deletion(-)

[PATCH v8 22/23] drm/mediatek: Power on devices in OVL adaptor when atomic enable

2023-10-16 Thread Hsiao Chien Sung
Different from OVL, OVL adaptor is a pseudo device so we didn't define it in the device tree, consequently, pm_runtime_resume_and_get() called by .atomic_enable() powers on no device in OVL adaptor and leads to power outage in the corresponding IOMMU. To resolve the issue, we implement a function

[PATCH v8 15/23] drm/mediatek: Manage component's clock with function pointers

2023-10-16 Thread Hsiao Chien Sung
By registering component related functions to the pointers, we can easily manage them within a for-loop and simplify the logic of clock control significantly. Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 111 +++--- 1 file ch

[PATCH v8 04/23] dt-bindings: display: mediatek: padding: Add MT8188

2023-10-16 Thread Hsiao Chien Sung
Padding is a new hardware module on MediaTek MT8188, add dt-bindings for it. Reviewed-by: Krzysztof Kozlowski Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- .../display/mediatek/mediatek,padding.yaml| 81 +++ 1 file changed, 81 insertions(+) create mode 100644 Doc

[PATCH v8 17/23] drm/mediatek: Support MT8188 Padding in display driver

2023-10-16 Thread Hsiao Chien Sung
Padding is a new display module on MT8188, it provides ability to add pixels to width and height of a layer with specified colors. Due to hardware design, Mixer in VDOSYS1 requires width of a layer to be 2-pixel-align, or 4-pixel-align when ETHDR is enabled, we need Padding to deal with odd width.

Re: [PATCH v7 04/23] dt-bindings: display: mediatek: padding: Add MT8188

2023-10-16 Thread Daniel Stone
Hi Shawn, On Mon, 16 Oct 2023 at 06:23, Shawn Sung (宋孝謙) wrote: > On Fri, 2023-10-13 at 17:26 +0100, Daniel Stone wrote: > > If I understand the driver correctly, padding is automatically > > applied > > to compensate for unaligned dimensions. The first/last rows/columns > > of > > the overlay ar

Re: [PATCH v4 1/4] drm/format-helper: Export line conversion helper for drm_panic

2023-10-16 Thread Thomas Zimmermann
Hi Am 03.10.23 um 16:22 schrieb Jocelyn Falempe: drm_panic will need the low-level drm_fb__line functions. It seems like premature optimization to not use drm_fb_blit(); especially since drm_panic is not performance critical. Also add drm_fb_r1_to_xrgb to render the fonts. I thin

Re: [PATCH v4 1/4] drm/format-helper: Export line conversion helper for drm_panic

2023-10-16 Thread Thomas Zimmermann
Hi Am 16.10.23 um 12:47 schrieb Thomas Zimmermann: Hi Am 03.10.23 um 16:22 schrieb Jocelyn Falempe: drm_panic will need the low-level drm_fb__line functions. It seems like premature optimization to not use drm_fb_blit(); especially since drm_panic is not performance critical. We shoul

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread André Almeida
Hi Michel, On 8/17/23 12:37, Michel Dänzer wrote: On 8/15/23 20:57, André Almeida wrote: From: Pekka Paalanen Specify how the atomic state is maintained between userspace and kernel, plus the special case for async flips. Signed-off-by: Pekka Paalanen Signed-off-by: André Almeida [...]

Re: [PATCH drm-misc-next v6 4/6] drm/gpuvm: track/lock/validate external/evicted objects

2023-10-16 Thread Thomas Hellström
On 10/13/23 15:37, Thomas Hellström wrote: Hi, On Mon, 2023-10-09 at 01:32 +0200, Danilo Krummrich wrote: Currently the DRM GPUVM offers common infrastructure to track GPU VA allocations and mappings, generically connect GPU VA mappings to their backing buffers and perform more complex mappin

Re: Implement per-key keyboard backlight as auxdisplay?

2023-10-16 Thread Miguel Ojeda
On Fri, Oct 13, 2023 at 9:56 PM Pavel Machek wrote: > > So... a bit of rationale. The keyboard does not really fit into the > LED subsystem; LEDs are expected to be independent ("hdd led") and not > a matrix of them. Makes sense. > We do see various strange displays these days -- they commonly h

Re: [PATCH] drm/ttm: Drain workqueue before sys manager release

2023-10-16 Thread Christian König
Am 13.10.23 um 16:34 schrieb Karolina Stolarek: In rare cases, a delayed destruction of a BO with a system resource could stay in the workqueue until drain_workqueue() is called in ttm_device_fini(). An attempt to free a resource from an already released manager results in NULL pointer dereferenc

[PATCH] fbdev: omapfb: fix some error codes

2023-10-16 Thread Dan Carpenter
Return negative -ENXIO instead of positive ENXIO. Signed-off-by: Dan Carpenter --- No fixes tag because the caller doesn't check for errors. drivers/video/fbdev/omap/omapfb_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/d

Re: [PATCH] drm/ttm: Drain workqueue before sys manager release

2023-10-16 Thread Karolina Stolarek
On 16.10.2023 13:03, Christian König wrote: Am 13.10.23 um 16:34 schrieb Karolina Stolarek: In rare cases, a delayed destruction of a BO with a system resource could stay in the workqueue until drain_workqueue() is called in ttm_device_fini(). An attempt to free a resource from an already releas

Re: [PATCH v10 4/7] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2023-10-16 Thread Krzysztof Kozlowski
On 13/10/2023 05:24, Sandor Yu wrote: > Add a new DRM DisplayPort and HDMI bridge driver for Candence MHDP8501 > used in i.MX8MQ SOC. MHDP8501 could support HDMI or DisplayPort > standards according embedded Firmware running in the uCPU. ... > + > +static struct platform_driver cdns_mhdp8501_driv

[PATCH] drm/ttm: Reorder sys manager cleanup step

2023-10-16 Thread Karolina Stolarek
With the current cleanup flow, we could trigger a NULL pointer dereference if there is a delayed destruction of a BO with a system resource that gets executed on drain_workqueue() call, as we attempt to free a resource using an already released resource manager. Remove the device from the device l

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread Pekka Paalanen
On Mon, 16 Oct 2023 12:52:32 +0200 André Almeida wrote: > Hi Michel, > > On 8/17/23 12:37, Michel Dänzer wrote: > > On 8/15/23 20:57, André Almeida wrote: > >> From: Pekka Paalanen > >> > >> Specify how the atomic state is maintained between userspace and > >> kernel, plus the special case fo

Re: [PATCH 1/5] dt-bindings: vendor-prefixes: document Powkiddy

2023-10-16 Thread Krzysztof Kozlowski
On 13/10/2023 20:39, Chris Morgan wrote: > From: Chris Morgan > > Document Powkiddy (https://powkiddy.com/). > > Signed-off-by: Chris Morgan > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] drm/ttm: Reorder sys manager cleanup step

2023-10-16 Thread Christian König
Am 16.10.23 um 14:15 schrieb Karolina Stolarek: With the current cleanup flow, we could trigger a NULL pointer dereference if there is a delayed destruction of a BO with a system resource that gets executed on drain_workqueue() call, as we attempt to free a resource using an already released reso

Re: [PATCH 2/5] dt-bindings: panel: Add Powkiddy RGB30 panel compatible

2023-10-16 Thread Krzysztof Kozlowski
On 13/10/2023 20:39, Chris Morgan wrote: > From: Chris Morgan > > The Powkiddy RGB30 panel is a 4 inch 720x720 MIPI-DSI LCD panel. It > appears to be based on the ST7703 LCD controller (this is assumed from > the init sequence similarity between this and other displays). Powkiddy > would not shar

Re: [PATCH 4/5] dt-bindings: arm64: rockchip: add Powkiddy RGB30

2023-10-16 Thread Krzysztof Kozlowski
On 13/10/2023 20:39, Chris Morgan wrote: > From: Chris Morgan > > The Powkiddy RGB30 is a portable handheld console from Powkiddy which > uses the Rockchip RK3566 SoC. > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v5 0/4] Improve test coverage of TTM

2023-10-16 Thread Somalapuram, Amaranath
On 10/16/2023 2:22 PM, Karolina Stolarek wrote: Add tests for building blocks of the TTM subsystem, such as ttm_resource, ttm_resource_manager, ttm_tt and ttm_buffer_object. This series covers basic functions such as initialization, allocation and clean-up of each struct. Testing of ttm_buffer_

Re: BUG: KASAN: slab-use-after-free in drm_connector_cleanup

2023-10-16 Thread Dan Carpenter
If I had to guess, I'd say it's an issue in the vc4_mock driver. It's crashing somewhere in Subtest: drm_vc4_test_pv_muxing. regards, dan carpenter On Fri, Oct 13, 2023 at 11:44:32PM +0530, Naresh Kamboju wrote: > Following kasan bug was noticed on arm64 bcm2711-rpi-4-b device running > Linux ne

[Bug 218015] amdgpu powerplay: Spontaneous changes to power_dpm_force_performance_level

2023-10-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218015 --- Comment #4 from Alex Deucher (alexdeuc...@gmail.com) --- UMDs (e.g., mesa) can change the power profile as well. E.g., if they want to capture an SQ trace, etc. It's likely that is the cause. -- You may reply to this email to add a comment

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread André Almeida
Hi Pekka, On 10/16/23 14:18, Pekka Paalanen wrote: On Mon, 16 Oct 2023 12:52:32 +0200 André Almeida wrote: Hi Michel, On 8/17/23 12:37, Michel Dänzer wrote: On 8/15/23 20:57, André Almeida wrote: From: Pekka Paalanen Specify how the atomic state is maintained between userspace and kernel

Re: (subset) [PATCH v2 0/4] Some cleanup of vop2 driver

2023-10-16 Thread Heiko Stuebner
On Fri, 13 Oct 2023 20:20:01 +0800, Andy Yan wrote: > From: Andy Yan > > This is a preparation for the upcoming support for rk3588 vop. > Patch 1 remove unused struct > Patch 2 remove NR_LAYERS macro to support more layers on rk3588 > Patch 3 are plane format fix > Patch 4 is a format rename > >

Re: [PATCH] drm/rockchip: Fix type promotion bug in rockchip_gem_iommu_map()

2023-10-16 Thread Heiko Stuebner
On Wed, 11 Oct 2023 11:01:48 +0300, Dan Carpenter wrote: > The "ret" variable is declared as ssize_t and it can hold negative error > codes but the "rk_obj->base.size" variable is type size_t. This means > that when we compare them, they are both type promoted to size_t and the > negative error co

[PATCH 1/2] drm: extract closefb logic in separate function

2023-10-16 Thread Simon Ser
drm_mode_rmfb performs two operations: drop the FB from the file_priv->fbs list, and make sure the FB is no longer used on a plane. In the next commit an IOCTL which only does so former will be introduced, so let's split it into a separate function. No functional change, only refactoring. Signed

[PATCH 2/2] drm: introduce CLOSEFB IOCTL

2023-10-16 Thread Simon Ser
This new IOCTL allows callers to close a framebuffer without disabling planes or CRTCs. This takes inspiration from Rob Clark's unref_fb IOCTL [1] and DRM_MODE_FB_PERSIST [2]. User-space patch for wlroots available at [3]. IGT test available at [4]. [1]: https://lore.kernel.org/dri-devel/2017050

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread Pekka Paalanen
On Mon, 16 Oct 2023 15:42:16 +0200 André Almeida wrote: > Hi Pekka, > > On 10/16/23 14:18, Pekka Paalanen wrote: > > On Mon, 16 Oct 2023 12:52:32 +0200 > > André Almeida wrote: > > > >> Hi Michel, > >> > >> On 8/17/23 12:37, Michel Dänzer wrote: > >>> On 8/15/23 20:57, André Almeida wrote:

[PATCH 6.5 123/191] drm/tiny: correctly print `struct resource *` on error

2023-10-16 Thread Greg Kroah-Hartman
6.5-stable review patch. If anyone has any objections, please let me know. -- From: Joey Gouly commit c1165df2be2fffe3adeeaa68f4ee4325108c5e4e upstream. The `res` variable is already a `struct resource *`, don't take the address of it. Fixes incorrect output: simple

Re: [PATCH v5 6/7] drm/sched: Add drm_sched_start_timeout_unlocked helper

2023-10-16 Thread Matthew Brost
On Fri, Oct 13, 2023 at 10:52:22PM -0400, Luben Tuikov wrote: > On 2023-10-11 19:58, Matthew Brost wrote: > > Also add a lockdep assert to drm_sched_start_timeout. > > > > Signed-off-by: Matthew Brost > > Reviewed-by: Luben Tuikov > > I don't remember sending a Reviewed-by email to this patch.

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread André Almeida
On 10/16/23 16:52, Pekka Paalanen wrote: On Mon, 16 Oct 2023 15:42:16 +0200 André Almeida wrote: Hi Pekka, On 10/16/23 14:18, Pekka Paalanen wrote: On Mon, 16 Oct 2023 12:52:32 +0200 André Almeida wrote: Hi Michel, On 8/17/23 12:37, Michel Dänzer wrote: On 8/15/23 20:57, André Almei

Re: [PATCH v1] dynamic_debug: add support for logs destination

2023-10-16 Thread Steven Rostedt
On Thu, 12 Oct 2023 11:53:52 +0200 Daniel Vetter wrote: > > You said that turning the kernel ring buffer contents into strings is a > > very heavy operation, so it is not possible to push this scope > > separation to userspace, right? > > I think it's the kernel that does the formatting, but h

Re: [PATCH v5 4/7] drm/sched: Add DRM_SCHED_POLICY_SINGLE_ENTITY scheduling policy

2023-10-16 Thread Matthew Brost
On Fri, Oct 13, 2023 at 10:06:18PM -0400, Luben Tuikov wrote: > On 2023-10-11 19:58, Matthew Brost wrote: > > DRM_SCHED_POLICY_SINGLE_ENTITY creates a 1 to 1 relationship between > > scheduler and entity. No priorities or run queue used in this mode. > > Intended for devices with firmware scheduler

Re: [PATCH v5 7/7] drm/sched: Add helper to queue TDR immediately for current and future jobs

2023-10-16 Thread Matthew Brost
On Fri, Oct 13, 2023 at 11:04:47PM -0400, Luben Tuikov wrote: > On 2023-10-11 19:58, Matthew Brost wrote: > > Add helper to queue TDR immediately for current and future jobs. This is > > used in Xe, a new Intel GPU driver, to trigger a TDR to cleanup a > > drm_scheduler that encounter errors. > >

[PATCH v1] dt-bindings: backlight: add brightness-levels related common properties

2023-10-16 Thread Flavio Suligoi
Both files pwm-backlight.yaml and led-backlight.yaml contain properties in common with each other, regarding the brightness levels: - brightness-levels - default-brightness-level These properties can then be moved to backlight/common.yaml. Signed-off-by: Flavio Suligoi --- .../bindings/leds/ba

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread Ville Syrjälä
On Mon, Oct 16, 2023 at 05:52:22PM +0300, Pekka Paalanen wrote: > On Mon, 16 Oct 2023 15:42:16 +0200 > André Almeida wrote: > > > Hi Pekka, > > > > On 10/16/23 14:18, Pekka Paalanen wrote: > > > On Mon, 16 Oct 2023 12:52:32 +0200 > > > André Almeida wrote: > > > > > >> Hi Michel, > > >> > > >

Re: [PATCH v5 4/7] drm/sched: Add DRM_SCHED_POLICY_SINGLE_ENTITY scheduling policy

2023-10-16 Thread Luben Tuikov
On 2023-10-16 11:00, Matthew Brost wrote: > On Fri, Oct 13, 2023 at 10:06:18PM -0400, Luben Tuikov wrote: >> On 2023-10-11 19:58, Matthew Brost wrote: >>> DRM_SCHED_POLICY_SINGLE_ENTITY creates a 1 to 1 relationship between >>> scheduler and entity. No priorities or run queue used in this mode. >>>

  1   2   >