Re: [RFC PATCH 1/3] drm/msm/dpu: add support for MSM8953

2023-10-06 Thread Dmitry Baryshkov
On 29/09/2023 23:52, Luca Weiss wrote: On Samstag, 23. September 2023 23:49:10 CEST Dmitry Baryshkov wrote: Experimental support for MSM8953, which has MDP5 v1.16. It looks like trimmed down version of MSM8996. Less SSPP, LM and PP blocks. No DSC, etc. Hi Dmitry, As written on IRC, on sdm632

[RFC PATCH v2 0/3] drm/msm/dpu: convert even more MDP5 platforms

2023-10-06 Thread Dmitry Baryshkov
Extend DPU driver with experimental support for even more MDP5 platforms: MSM8937, MSM8917, MSM8953. As with other MDP5 devices, one has to pass `msm.prefer_mdp5=false` kernel param to test DPU driver insead of using MDP5. Note, Luca Weiss has reported timeout issues with CMD panels. This is not

[RFC PATCH v2 2/3] drm/msm/dpu: add support for MSM8937

2023-10-06 Thread Dmitry Baryshkov
Experimental support for MSM8937, which has MDP5 v1.14. It looks like trimmed down version of MSM8996. Less SSPP, LM and PP blocks. No DSC, etc. Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_1_14_msm8937.h | 213 ++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c

[RFC PATCH v2 1/3] drm/msm/dpu: add support for MSM8953

2023-10-06 Thread Dmitry Baryshkov
Experimental support for MSM8953, which has MDP5 v1.16. It looks like trimmed down version of MSM8996. Less SSPP, LM and PP blocks. No DSC, etc. Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_1_16_msm8953.h | 221 ++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c

[RFC PATCH v2 3/3] drm/msm/dpu: add support for MSM8917

2023-10-06 Thread Dmitry Baryshkov
Experimental support for MSM8917, which has MDP5 v1.15. It looks like trimmed down version of MSM8937. Even fewer PP, LM and no DSI1. Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_1_15_msm8917.h | 190 ++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 1 +

Re: [RFT PATCH v2 09/12] drm/exynos: Call drm_atomic_helper_shutdown() at shutdown/unbind time

2023-10-06 Thread Doug Anderson
Hi, On Thu, Oct 5, 2023 at 7:20 PM Inki Dae wrote: > > Thanks for testing. :) > > Acked-by : Inki Dae Inki: does that mean you'd like this to go through drm-misc? I'm happy to do that, but there are no dependencies here so this could easily go through your tree. > 2023년 9월 22일 (금) 오후 3:00, Ma

[PATCH] accel/habanalabs: make hl_class constant

2023-10-06 Thread Greg Kroah-Hartman
Now that the driver core allows for struct class to be in read-only memory, we should make all 'class' structures declared at build time placing them into read-only memory, instead of having to be dynamically allocated at runtime. This requires some passing of const struct class * around in the co

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-06 Thread Maxime Ripard
Hi Jocelyn, On Thu, Oct 05, 2023 at 11:16:15AM +0200, Jocelyn Falempe wrote: > On 05/10/2023 10:18, Maxime Ripard wrote: > > Hi, > > > > On Tue, Oct 03, 2023 at 04:22:45PM +0200, Jocelyn Falempe wrote: > > > diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h > > > index 89e2706cac56..e538

Re: [PATCH] video: fbdev: arkfb: fix possible object reference leak

2023-10-06 Thread Ondrej Zary
On Friday 06 October 2023, Helge Deller wrote: > On 10/5/23 09:01, Zhang Shurong wrote: > > Add missing pci_disable_device() in error path in ark_pci_probe(). > > Do you have this hardware and tested your patch? > I'm sure there is a reason, why "pci_disable_device()" was commented > out in the or

Re: [PATCH v4 0/7] drm: Reuse temporary memory for format conversion

2023-10-06 Thread Maxime Ripard
Hi, On Thu, Oct 05, 2023 at 11:04:20AM +0200, Thomas Zimmermann wrote: > DRM's format-conversion helpers require temporary memory. Pass the > buffer from the caller and keep it allocated over several calls. Allow > the caller to preallocate the buffer memory. I'm sorry... but why? Why do you need

[PATCH] drm/i915/guc: Update 'recommended' version to 70.12.1 for DG2/ADL-S/ADL-P/MTL

2023-10-06 Thread John . C . Harrison
From: John Harrison The latest GuC has new features and new workarounds that we wish to enable. So let the universe know that it is useful to update their firmware. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 8 1 file changed, 4 insertions(+), 4 deleti

Re: [PATCH] drm/crtc: do not release uninitialized connector reference

2023-10-06 Thread Fedor Pchelkin
On 23/07/21 01:15PM, Fedor Pchelkin wrote: > Inside drm_mode_setcrtc() connector_set is allocated using kmalloc_array() > so its values are uninitialized. When filling this array with actual > pointers to drm connector objects, an error caused with invalid ioctl > request data may occur leading us

Re: [PATCH v2 5/6] drm/msm/dpu: Add hw revision 4.1 (SDM670)

2023-10-06 Thread Dmitry Baryshkov
On 03/10/2023 04:21, Richard Acayan wrote: The Snapdragon 670 uses similar clocks (with one frequency added) to the Snapdragon 845 but reports DPU revision 4.1. Add support for this DPU with configuration from the Pixel 3a downstream kernel. Since revision 4.0 is SDM845, reuse some configuration

[PATCH v2 4/5] drm/bridge: samsung-dsim: adjust porches by rounding up

2023-10-06 Thread Michael Tretter
Rounding the porches up instead of down fixes the samsung-dsim at some more resolutions and refresh rates: The following resolutions are working with rounded-up porches, but don't work when the porches are rounded down: 1920x1080-59.94 1920x1080-30.00 1920x1080-29.97 1920x1080-25.00 1680x1050-59.

[PATCH v2 2/5] drm/bridge: samsung-dsim: reread ref clock before configuring PLL

2023-10-06 Thread Michael Tretter
The PLL reference clock may change at runtime when its parent clock changes. For example, this may happen on the i.MX8M Nano if the reference clock is a child of the Video PLL. If the pixel clock changes, this may propagate to the Video PLL and as a side effect change the reference clock. Thus, rea

[PATCH v2 3/5] drm/bridge: samsung-dsim: update PLL reference clock

2023-10-06 Thread Michael Tretter
The PLL requires a clock frequency in a certain platform-dependent range after the pre-divider. The reference clock for the PLL may change due to changes to it's parent clock. Thus, the frequency may be out of range or unsuited for generating the high speed clock for MIPI DSI. Try to keep the pre-

[PATCH v2 5/5] drm/bridge: samsung-dsim: calculate porches in Hz

2023-10-06 Thread Michael Tretter
Calculating the byte_clk in kHz is imprecise for a hs_clock of 55687500 Hz, which may be used with a pixel clock of 74.25 MHz with mode 1920x1080-30. Fix the calculation by using HZ instead of kHZ. This requires to change the type to u64 to prevent overflows of the integer type. Reviewed-by: Ada

[PATCH v2 1/5] drm/bridge: samsung-dsim: add more mipi-dsi device debug information

2023-10-06 Thread Michael Tretter
From: Marco Felsch Since the MIPI configuration can be changed on demand it is very useful to print more MIPI settings during the MIPI device attach step. Signed-off-by: Marco Felsch Reviewed-by: Adam Ford #imx8mm-beacon Tested-by: Adam Ford #imx8mm-beacon Reviewed-by: Inki Dae Acked-by: I

[PATCH v2 0/5] drm/bridge: samsung-dsim: fix various modes with ADV7535 bridge

2023-10-06 Thread Michael Tretter
I tested the i.MX8M Nano EVK with the NXP supplied MIPI-DSI adapter, which uses an ADV7535 MIPI-DSI to HDMI converter. I found that a few modes were working, but in many modes my monitor stayed dark. This series fixes the Samsung DSIM bridge driver to bring up a few more modes: The driver read th

Re: [PATCH v4 02/10] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-10-06 Thread Matthew Brost
On Fri, Oct 06, 2023 at 08:59:15AM +0100, Tvrtko Ursulin wrote: > > On 05/10/2023 05:13, Luben Tuikov wrote: > > On 2023-10-04 23:33, Matthew Brost wrote: > > > On Tue, Sep 26, 2023 at 11:32:10PM -0400, Luben Tuikov wrote: > > > > Hi, > > > > > > > > On 2023-09-19 01:01, Matthew Brost wrote: > >

Re: [git pull] drm fixes for 6.6-rc5

2023-10-06 Thread pr-tracker-bot
The pull request you sent on Fri, 6 Oct 2023 14:58:38 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-10-06 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4940c1543b4381a4895072489b4de7b6145694f5 Thank you! -- Deet-doot-dot, I am a bot. https://ko

Re: [PATCH] accel/ivpu: Don't enter d0i3 during FLR

2023-10-06 Thread Jeffrey Hugo
On 10/3/2023 12:42 AM, Stanislaw Gruszka wrote: From: Jacek Lawrynowicz Fix a bug on some platforms where FLR causes complete system hang when CPU is low power states (C8 or above). Why does FLR cause a complete system hang? Why does avoiding d0i3 fix the issue? Feels like there could be a

[PATCH] accel/qaic: Enable 1 MSI fallback mode

2023-10-06 Thread Jeffrey Hugo
From: Carl Vanderlip Several virtualization use-cases either don't support 32 MultiMSIs (Xen/VMware) or have significant drawbacks to their use (KVM's vIOMMU, which is required to support 32 MSI, needs to allocate an alternate system memory space for each device using vIOMMU (e.g. 8GB VM mem and

Re: [PATCH 1/3] drm/i915: Remove early/pre-production Haswell code

2023-10-06 Thread Zanoni, Paulo R
On Fri, 2023-10-06 at 09:31 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > It is not our policy to keep pre-production hardware support for this long > so I guess this one was just forgotten. Wouldn't it make sense to also remove the PCI IDs if they never made it to the real production

Re: [PATCH v2 0/5] drm/bridge: samsung-dsim: fix various modes with ADV7535 bridge

2023-10-06 Thread Marek Szyprowski
On 06.10.2023 17:07, Michael Tretter wrote: > I tested the i.MX8M Nano EVK with the NXP supplied MIPI-DSI adapter, > which uses an ADV7535 MIPI-DSI to HDMI converter. I found that a few > modes were working, but in many modes my monitor stayed dark. > > This series fixes the Samsung DSIM bridge dri

Re: [RFC PATCH 1/3] drm/msm/dpu: add support for MSM8953

2023-10-06 Thread Luca Weiss
On Freitag, 6. Oktober 2023 15:38:51 CEST Dmitry Baryshkov wrote: > On 29/09/2023 23:52, Luca Weiss wrote: > > On Samstag, 23. September 2023 23:49:10 CEST Dmitry Baryshkov wrote: > >> Experimental support for MSM8953, which has MDP5 v1.16. It looks like > >> trimmed down version of MSM8996. Less S

[PATCH 2/2] accel/qaic: Support MHI QAIC_TIMESYNC channel

2023-10-06 Thread Jeffrey Hugo
From: Pranjal Ramajor Asha Kanojiya Use QAIC_TIMESYNC MHI channel to send UTC time to device in SBL environment. Remove support for QAIC_TIMESYNC MHI channel in AMSS environment as it is not used in that environment. Signed-off-by: Pranjal Ramajor Asha Kanojiya Reviewed-by: Jeffrey Hugo Review

[PATCH 1/2] accel/qaic: Add support for periodic timesync

2023-10-06 Thread Jeffrey Hugo
From: Ajit Pal Singh Device and Host have a time synchronization mechanism that happens once during boot when device is in SBL mode. After that, in mission-mode there is no timesync. In an experiment after continuous operation, device time drifted w.r.t. host by approximately 3 seconds per day. T

[PATCH 0/2] accel/qaic: Add support for host/device timesync

2023-10-06 Thread Jeffrey Hugo
AIC100 supports a timesync mechanism that allows AIC100 to timestamp device logs with a host based time. This becomes useful for putting host logs in a unified timeline with device logs for debugging and performance profiling. The mechanism consists of a boot-time initialization and a runtime perod

Re: [PATCH v5 5/7] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-10-06 Thread Kuogee Hsieh
On 10/6/2023 4:56 AM, Dmitry Baryshkov wrote: On 04/10/2023 19:26, Kuogee Hsieh wrote: Currently DP driver is executed independent of PM runtime framework. This leads msm eDP panel can not being detected by edp_panel driver during generic_edp_panel_probe() due to AUX DPCD read failed at edp p

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-06 Thread Noralf Trønnes
On 10/6/23 16:35, Maxime Ripard wrote: > Hi Jocelyn, > > On Thu, Oct 05, 2023 at 11:16:15AM +0200, Jocelyn Falempe wrote: >> On 05/10/2023 10:18, Maxime Ripard wrote: >>> Hi, >>> >>> On Tue, Oct 03, 2023 at 04:22:45PM +0200, Jocelyn Falempe wrote: diff --git a/include/drm/drm_drv.h b/inclu

Re: [RFC PATCH 1/3] drm/msm/dpu: add support for MSM8953

2023-10-06 Thread Dmitry Baryshkov
On Fri, 6 Oct 2023 at 19:26, Luca Weiss wrote: > > On Freitag, 6. Oktober 2023 15:38:51 CEST Dmitry Baryshkov wrote: > > On 29/09/2023 23:52, Luca Weiss wrote: > > > On Samstag, 23. September 2023 23:49:10 CEST Dmitry Baryshkov wrote: > > >> Experimental support for MSM8953, which has MDP5 v1.16.

[PATCH] drm/ci: Default to UART for logging

2023-10-06 Thread Rob Clark
From: Rob Clark ssh logging is the default for mesa, as it is generally more reliable. But if there are kernel issues, especially at boot, UART logging is infinitely more useful. Signed-off-by: Rob Clark --- drivers/gpu/drm/ci/gitlab-ci.yml | 6 ++ 1 file changed, 6 insertions(+) diff --g

Re: [PATCH v5 5/7] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-10-06 Thread Dmitry Baryshkov
On Wed, 4 Oct 2023 at 19:27, Kuogee Hsieh wrote: > > Currently DP driver is executed independent of PM runtime framework. > This leads msm eDP panel can not being detected by edp_panel driver during > generic_edp_panel_probe() due to AUX DPCD read failed at edp panel driver. > Incorporate PM runti

Re: [PATCH v5 5/7] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-10-06 Thread Dmitry Baryshkov
On 06/10/2023 19:42, Kuogee Hsieh wrote: On 10/6/2023 4:56 AM, Dmitry Baryshkov wrote: On 04/10/2023 19:26, Kuogee Hsieh wrote: Currently DP driver is executed independent of PM runtime framework. This leads msm eDP panel can not being detected by edp_panel driver during generic_edp_panel_pro

Re: [PATCH v3] drm/dp_mst: Fix NULL deref in get_mst_branch_device_by_guid_helper()

2023-10-06 Thread Manasi Navare
Thanks Lukasz for the patch, looks like it is reviewed by. @dan...@ffwll.ch or @airl...@gmail.com , could any of you ack this as well, so I can go ahead and push this to drm-misc-fixes branch? Regards Manasi On Thu, Oct 5, 2023 at 6:35 AM Lukasz Majczak wrote: > wt., 26 wrz 2023 o 16:01 Rado

Re: [PATCH v1 1/3] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages

2023-10-06 Thread Jason Gunthorpe
On Fri, Oct 06, 2023 at 10:03:33AM +0200, David Hildenbrand wrote: > > + * > > + * Returns number of pages pinned. This would be equal to the number of > > + * pages requested. > > + * If nr_pages is 0 or negative, returns 0. If no pages were pinned, > > returns > > + * -errno. > > + */ > > +long

Re: [PATCH] drm/atomic: Perform blocking commits on workqueue

2023-10-06 Thread Ray Strode
Hi, On Fri, Oct 6, 2023 at 3:12 AM Christian König wrote: > When the operation busy waits then that *should* get accounted to the > CPU time of the current process. When the operation sleeps and waits for > some interrupt for example it should not get accounted. > What you suggest is to put the p

Re: [PATCH v7] Documentation/gpu: Add a VM_BIND async document

2023-10-06 Thread Thomas Hellström
On 9/12/23 20:33, Zanoni, Paulo R wrote: On Mon, 2023-09-11 at 14:47 +0200, Thomas Hellström wrote: Add a motivation for and description of asynchronous VM_BIND operation v2: - Fix typos (Nirmoy Das) - Improve the description of a memory fence (Oak Zeng) - Add a reference to the document in t

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Remove early/pre-production Haswell code

2023-10-06 Thread Andrzej Hajda
On 06.10.2023 10:31, Tvrtko Ursulin wrote: From: Tvrtko Ursulin It is not our policy to keep pre-production hardware support for this long so I guess this one was just forgotten. Signed-off-by: Tvrtko Ursulin Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/i915_dri

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Remove incomplete PVC plumbing

2023-10-06 Thread Andrzej Hajda
On 06.10.2023 10:31, Tvrtko Ursulin wrote: From: Tvrtko Ursulin PVC support will not be coming to i915 so get rid of its partial enablement and reduce the driver maintenance burden. Signed-off-by: Tvrtko Ursulin --- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 +- drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Remove xehpsdv support

2023-10-06 Thread Andrzej Hajda
On 06.10.2023 10:31, Tvrtko Ursulin wrote: From: Tvrtko Ursulin XeHP SDV was a pre-production hardware used to bring up ATS and was not generally available. Since latter was since explicitly added, there is no need to keep the code for the former around. Signed-off-by: Tvrtko Ursulin --- dr

[PATCH] drm/i915/guc: Annotate struct ct_incoming_msg with __counted_by

2023-10-06 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions). A

Re: [PATCH v2] drm/etnaviv: refactor deprecated strncpy

2023-10-06 Thread Kees Cook
On Mon, Sep 18, 2023 at 01:34:08PM +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > We should prefer more robust and less ambiguous string interfaces. > > A suitable replacement is `strscpy_pad` due to the fact that it > guarantees NUL-te

Re: [Intel-gfx] [PATCH] drm/i915/guc: Update 'recommended' version to 70.12.1 for DG2/ADL-S/ADL-P/MTL

2023-10-06 Thread Andi Shyti
Hi John, > The latest GuC has new features and new workarounds that we wish to > enable. So let the universe know that it is useful to update their > firmware. > > Signed-off-by: John Harrison Reviewed-by: Andi Shyti Andi

[PATCH 1/2] fbdev/uvesafb: Remove uvesafb_exec() prototype from include/video/uvesafb.h

2023-10-06 Thread Jorge Maidana
uvesafb_exec() is a static function defined and called only in drivers/video/fbdev/uvesafb.c, remove the prototype from include/video/uvesafb.h. Fixes the warning: ./include/video/uvesafb.h:112:12: warning: 'uvesafb_exec' declared 'static' but never defined [-Wunused-function] when including '' i

[PATCH 2/2] fbdev/uvesafb: Call cn_del_callback() at the end of uvesafb_exit()

2023-10-06 Thread Jorge Maidana
Delete the v86d netlink only after all the VBE tasks have been completed. Fixes initial state restore on module unload: uvesafb: VBE state restore call failed (eax=0x4f04, err=-19) Signed-off-by: Jorge Maidana --- drivers/video/fbdev/uvesafb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH v5 5/7] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-10-06 Thread Kuogee Hsieh
On 10/6/2023 11:04 AM, Dmitry Baryshkov wrote: On 06/10/2023 19:42, Kuogee Hsieh wrote: On 10/6/2023 4:56 AM, Dmitry Baryshkov wrote: On 04/10/2023 19:26, Kuogee Hsieh wrote: Currently DP driver is executed independent of PM runtime framework. This leads msm eDP panel can not being detected

Re: [PATCH] drm/i915/guc: Annotate struct ct_incoming_msg with __counted_by

2023-10-06 Thread Gustavo A. R. Silva
On 10/6/23 22:17, Kees Cook wrote: Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE

Re: [PATCH] drm/atomic-helper: relax unregistered connector check

2023-10-06 Thread Ville Syrjälä
On Thu, Oct 05, 2023 at 01:16:32PM +, Simon Ser wrote: > The driver might pull connectors which weren't submitted by > user-space into the atomic state. For instance, > intel_dp_mst_atomic_master_trans_check() pulls in connectors > sharing the same DP-MST stream. However, if the connector is >

Re: [PATCH v5 5/7] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-10-06 Thread Dmitry Baryshkov
On Fri, 6 Oct 2023 at 23:44, Kuogee Hsieh wrote: > > > On 10/6/2023 11:04 AM, Dmitry Baryshkov wrote: > > On 06/10/2023 19:42, Kuogee Hsieh wrote: > >> > >> On 10/6/2023 4:56 AM, Dmitry Baryshkov wrote: > >>> On 04/10/2023 19:26, Kuogee Hsieh wrote: > Currently DP driver is executed independe

Re: [PATCH] drm/i915/guc: Annotate struct ct_incoming_msg with __counted_by

2023-10-06 Thread Andi Shyti
Hi Kees, On Fri, Oct 06, 2023 at 01:17:45PM -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for > array

[PATCH v6 1/7] drm/msm/dp: tie dp_display_irq_handler() with dp driver

2023-10-06 Thread Kuogee Hsieh
Currently the dp_display_request_irq() is executed at msm_dp_modeset_init() which ties irq registering to the DPU device's life cycle, while depending on resources that are released as the DP device is torn down. Move register DP driver irq handler to dp_display_probe() to have dp_display_irq_handl

[PATCH v6 0/7] incorporate pm runtime framework and eDP clean up

2023-10-06 Thread Kuogee Hsieh
The purpose of this patch series is to incorporate pm runtime framework into MSM eDP/DP driver so that eDP panel can be detected by DRM eDP panel driver during system probe time. During incorporating procedure, original customized pm realted fucntions, such as dp_pm_prepare(), dp_pm_suspend(), dp_p

[PATCH v6 2/7] drm/msm/dp: rename is_connected with link_ready

2023-10-06 Thread Kuogee Hsieh
The is_connected flag is set to true after DP mainlink successfully finishes link training to enter into ST_MAINLINK_READY state rather than being set after the DP dongle is connected. Rename the is_connected flag with link_ready flag to match the state of DP driver's state machine. Changes in v5:

[PATCH v6 6/7] drm/msm/dp: delete EV_HPD_INIT_SETUP

2023-10-06 Thread Kuogee Hsieh
EV_HPD_INIT_SETUP flag is used to trigger the initialization of external DP host controller. Since external DP host controller initialization had been incorporated into pm_runtime_resume(), this flag became obsolete. msm_dp_irq_postinstall() which triggers EV_HPD_INIT_SETUP event is obsoleted accor

[PATCH v6 5/7] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-10-06 Thread Kuogee Hsieh
Currently DP driver is executed independent of PM runtime framework. This leads msm eDP panel can not being detected by edp_panel driver during generic_edp_panel_probe() due to AUX DPCD read failed at edp panel driver. Incorporate PM runtime framework into DP driver so that host controller's power

[PATCH v6 4/7] drm/msm/dp: move parser->parse() and dp_power_client_init() to probe

2023-10-06 Thread Kuogee Hsieh
Original both parser->parse() and dp_power_client_init() are done at dp_display_bind() since eDP population is done at binding time. In the preparation of having eDP population done at probe() time, move both function from dp_display_bind() to dp_display_probe(). Changes in v6: -- move dp_power_cl

[PATCH v6 3/7] drm/msm/dp: use drm_bridge_hpd_notify() to report HPD status changes

2023-10-06 Thread Kuogee Hsieh
Currently DP driver use drm_helper_hpd_irq_event(), bypassing drm bridge framework, to report HPD status changes to user space frame work. Replace it with drm_bridge_hpd_notify() since DP driver is part of drm bridge. Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm

[PATCH v6 7/7] drm/msm/dp: move of_dp_aux_populate_bus() to eDP probe()

2023-10-06 Thread Kuogee Hsieh
Currently eDP population is done at msm_dp_modeset_init() which happen at binding time. Move eDP population to be done at display probe time so that probe deferral cases can be handled effectively. wait_for_hpd_asserted callback is added during drm_dp_aux_init() to ensure eDP's HPD is up before pro

Re: [PATCH v6 5/7] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-10-06 Thread Dmitry Baryshkov
On 07/10/2023 00:38, Kuogee Hsieh wrote: Currently DP driver is executed independent of PM runtime framework. This leads msm eDP panel can not being detected by edp_panel driver during generic_edp_panel_probe() due to AUX DPCD read failed at edp panel driver. Incorporate PM runtime framework into

Re: [-next 0/5] Add the pci_is_vga() helper and use it

2023-10-06 Thread Bjorn Helgaas
On Wed, Aug 30, 2023 at 07:15:27PM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > The PCI code and ID assignment specification defined four types of > display controllers for the display base class(03h), and the devices > with 0x00h sub-class code are VGA devices. VGA devices with programmin

Re: [PATCH 1/3] drm/i915/guc: Support new and improved engine busyness

2023-10-06 Thread John Harrison
On 10/3/2023 13:58, Umesh Nerlige Ramappa wrote: On Fri, Sep 22, 2023 at 03:25:08PM -0700, john.c.harri...@intel.com wrote: From: John Harrison The GuC has been extended to support a much more friendly engine busyness interface. So partition the old interface into a 'busy_v1' space and add 'bu

[PATCH v7 0/7] incorporate pm runtime framework and eDP clean up

2023-10-06 Thread Kuogee Hsieh
The purpose of this patch series is to incorporate pm runtime framework into MSM eDP/DP driver so that eDP panel can be detected by DRM eDP panel driver during system probe time. During incorporating procedure, original customized pm realted fucntions, such as dp_pm_prepare(), dp_pm_suspend(), dp_p

[PATCH v7 6/7] drm/msm/dp: delete EV_HPD_INIT_SETUP

2023-10-06 Thread Kuogee Hsieh
EV_HPD_INIT_SETUP flag is used to trigger the initialization of external DP host controller. Since external DP host controller initialization had been incorporated into pm_runtime_resume(), this flag became obsolete. msm_dp_irq_postinstall() which triggers EV_HPD_INIT_SETUP event is obsoleted accor

[PATCH v7 4/7] drm/msm/dp: move parser->parse() and dp_power_client_init() to probe

2023-10-06 Thread Kuogee Hsieh
Original both parser->parse() and dp_power_client_init() are done at dp_display_bind() since eDP population is done at binding time. In the preparation of having eDP population done at probe() time, move both function from dp_display_bind() to dp_display_probe(). Changes in v6: -- move dp_power_cl

[PATCH v7 7/7] drm/msm/dp: move of_dp_aux_populate_bus() to eDP probe()

2023-10-06 Thread Kuogee Hsieh
Currently eDP population is done at msm_dp_modeset_init() which happen at binding time. Move eDP population to be done at display probe time so that probe deferral cases can be handled effectively. wait_for_hpd_asserted callback is added during drm_dp_aux_init() to ensure eDP's HPD is up before pro

[PATCH v7 5/7] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-10-06 Thread Kuogee Hsieh
Currently DP driver is executed independent of PM runtime framework. This leads msm eDP panel can not being detected by edp_panel driver during generic_edp_panel_probe() due to AUX DPCD read failed at edp panel driver. Incorporate PM runtime framework into DP driver so that host controller's power

[PATCH v7 3/7] drm/msm/dp: use drm_bridge_hpd_notify() to report HPD status changes

2023-10-06 Thread Kuogee Hsieh
Currently DP driver use drm_helper_hpd_irq_event(), bypassing drm bridge framework, to report HPD status changes to user space frame work. Replace it with drm_bridge_hpd_notify() since DP driver is part of drm bridge. Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm

[PATCH v7 1/7] drm/msm/dp: tie dp_display_irq_handler() with dp driver

2023-10-06 Thread Kuogee Hsieh
Currently the dp_display_request_irq() is executed at msm_dp_modeset_init() which ties irq registering to the DPU device's life cycle, while depending on resources that are released as the DP device is torn down. Move register DP driver irq handler to dp_display_probe() to have dp_display_irq_handl

[PATCH v7 2/7] drm/msm/dp: rename is_connected with link_ready

2023-10-06 Thread Kuogee Hsieh
The is_connected flag is set to true after DP mainlink successfully finishes link training to enter into ST_MAINLINK_READY state rather than being set after the DP dongle is connected. Rename the is_connected flag with link_ready flag to match the state of DP driver's state machine. Changes in v5:

Re: [PATCH] drm/msm/dp: support setting the DP subconnector type

2023-10-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-09-03 15:24:32) > Read the downstream port info and set the subconnector type accordingly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Intel-xe] [PATCH v4 02/10] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-10-06 Thread Matthew Brost
On Fri, Oct 06, 2023 at 03:14:04PM +, Matthew Brost wrote: > On Fri, Oct 06, 2023 at 08:59:15AM +0100, Tvrtko Ursulin wrote: > > > > On 05/10/2023 05:13, Luben Tuikov wrote: > > > On 2023-10-04 23:33, Matthew Brost wrote: > > > > On Tue, Sep 26, 2023 at 11:32:10PM -0400, Luben Tuikov wrote: >

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Enable Wa_16019325821

2023-10-06 Thread Belgaumkar, Vinay
On 9/15/2023 2:55 PM, john.c.harri...@intel.com wrote: From: John Harrison Some platforms require holding RCS context switches until CCS is idle (the reverse w/a of Wa_14014475959). Some platforms require both versions. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/gen8_engine_

Re: [Intel-gfx] [PATCH 3/4] drm/i915/guc: Add support for w/a KLVs

2023-10-06 Thread Belgaumkar, Vinay
On 9/15/2023 2:55 PM, john.c.harri...@intel.com wrote: From: John Harrison To prevent running out of bits, new w/a enable flags are being added via a KLV system instead of a 32 bit flags word. Signed-off-by: John Harrison --- .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h | 1 + drivers/

[PATCH] drm/nouveau: exec: fix ioctl kernel-doc warning

2023-10-06 Thread Randy Dunlap
include/uapi/drm/nouveau_drm.h:49: warning: Cannot understand * @NOUVEAU_GETPARAM_EXEC_PUSH_MAX on line 49 - I thought it was a doc line Fixes: d59e75eef52d ("drm/nouveau: exec: report max pushs through getparam") Signed-off-by: Randy Dunlap Cc: Dave Airlie Cc: Danilo Krummrich Cc: Karol Her

Re: [PATCH] drm/i2c/ch7006: fix a possible null pointer dereference

2023-10-06 Thread kernel test robot
Hi Ma, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.6-rc4 next-20231006] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH] drm/panel: fix a possible null pointer dereference

2023-10-06 Thread Ma Ke
In versatile_panel_get_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Signed-off-by: Ma Ke --- drivers/gpu/drm/panel/panel-arm-versatile.c | 2 ++ 1 file changed, 2

[PATCH] drm/panel/panel-tpo-tpg110: fix a possible null pointer dereference

2023-10-06 Thread Ma Ke
In radeon_fp_native_mode(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Signed-off-by: Ma Ke --- drivers/gpu/drm/panel/panel-tpo-tpg110.c | 2 ++ 1 file changed, 2 insert

[PATCH] drm/nouveau/dispnv04: fix a possible null pointer dereference

2023-10-06 Thread Ma Ke
In nv17_tv_get_ld_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Signed-off-by: Ma Ke --- drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 2 ++ 1 file changed, 2 insert

[PATCH] drm/i2c/ch7006: fix a possible null pointer dereference

2023-10-06 Thread Ma Ke
In ch7006_encoder_get_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Signed-off-by: Ma Ke --- drivers/gpu/drm/i2c/ch7006_drv.c | 6 -- 1 file changed, 4 inserti

[v1 0/2] Break out as separate driver from boe-tv101wum-nl6 panel driver

2023-10-06 Thread Cong Yang
Linus series proposed to break out ili9882t as separate driver, but he didn't have time for that extensive rework of the driver. As discussed by Linus and Doug [1], keep macro using the "struct panel_init_cmd" until we get some resolution about the binary size issue. [1]: https://lore.kernel.org

[v1 1/2] drm/panel: ili9882t: Break out as separate driver

2023-10-06 Thread Cong Yang
From: Linus Walleij The Starry ILI9882t-based panel should never have been part of the boe tv101wum driver, it is clearly based on the Ilitek ILI9882t display controller and if you look at the custom command sequences for the panel these clearly contain the signature Ilitek page switch (0xff) com

[v1 2/2] drm/panel: ili9882t: Avoid blurred screen from fast sleep

2023-10-06 Thread Cong Yang
At present, we have found that there may be a problem of blurred screen during fast sleep/resume. The direct cause of the blurred screen is that the IC does not receive 0x28/0x10. Because of the particularity of the IC, before the panel enters sleep hid must stop scanning, i2c_hid_core_suspend befo

[PATCH v2] drm/panel: boe-tv101wum-nl6: Completely pull GPW to VGL before TP term

2023-10-06 Thread Ruihai Zhou
The sta_himax83102 panel sometimes shows abnormally flickering horizontal lines. The front gate output will precharge the X point of the next pole circuit before TP(TouchPanel Enable) term starts, and wait until the end of the TP term to resume the CLK. For this reason, the X point must be maintain

Re: [PATCH] drm: exynos: dsi: Convert to platform remove callback returning void

2023-10-06 Thread Neil Armstrong
Hi, On Tue, 19 Sep 2023 12:39:39 +0200, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitti

Re: [PATCH v5 2/2] drm/mediatek: Fix iommu fault during crtc enabling

2023-10-06 Thread 胡俊光

Re: [PATCH] drm/atomic: Perform blocking commits on workqueue

2023-10-06 Thread Christian König
Am 05.10.23 um 23:04 schrieb Ray Strode: Hi, On Thu, Oct 5, 2023 at 5:57 AM Daniel Vetter wrote: So imo the trouble with this is that we suddenly start to make realtime/cpu usage guarantees in the atomic ioctl. That's a _huge_ uapi change, because even limited to the case of !ALLOW_MODESET we

Re: [PATCH v11 4/9] drm/mediatek: Add encoder_index interface for mtk_ddp_comp_funcs

2023-10-06 Thread 胡俊光

Re: [PATCH] drm/drv: propagate errors from drm_modeset_register_all()

2023-10-06 Thread Neil Armstrong
On 21/05/2023 19:34, Dmitry Baryshkov wrote: In case the drm_modeset_register_all() function fails, its error code will be ignored. Instead make the drm_dev_register() bail out in case of such an error. Fixes: 79190ea2658a ("drm: Add callbacks for late registering") Signed-off-by: Dmitry Baryshk

Re: [PATCH v11 5/9] drm/mediatek: Add connector dynamic selection capability

2023-10-06 Thread 胡俊光

Re: [PATCH 1/3] drm/encoder: register per-encoder debugfs dir

2023-10-06 Thread Neil Armstrong
On 04/09/2023 03:53, Dmitry Baryshkov wrote: Each of connectors and CRTCs used by the DRM device provides debugfs directory, which is used by several standard debugfs files and can further be extended by the driver. Add such generic debugfs directories for encoder. Signed-off-by: Dmitry Baryshko

Re: [PATCH 2/3] drm/bridge: migrate bridge_chains to per-encoder file

2023-10-06 Thread Neil Armstrong
Hi, On 04/09/2023 03:53, Dmitry Baryshkov wrote: Instead of having a single file with all bridge chains, list bridges under a corresponding per-encoder debugfs directory. Example of the listing: $ cat /sys/kernel/debug/dri/0/encoder-0/bridges bridge[0]: dsi_mgr_bridge_funcs type: [0] U

[PATCH v7 02/23] dt-bindings: display: mediatek: mdp-rdma: Add compatible for MT8188

2023-10-06 Thread Hsiao Chien Sung
Add compatible name for MediaTek MT8188 MDP-RDMA. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- .../bindings/display/mediatek/mediatek,mdp-rdma.yaml| 6 +- 1 file changed, 5 insertions(+), 1 deletion(-

[PATCH v7 01/23] dt-bindings: display: mediatek: ethdr: Add compatible for MT8188

2023-10-06 Thread Hsiao Chien Sung
Add compatible name for MediaTek MT8188 ETHDR. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- .../bindings/display/mediatek/mediatek,ethdr.yaml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

[PATCH v7 12/23] drm/mediatek: Refine device table of OVL adaptor

2023-10-06 Thread Hsiao Chien Sung
- Adjust indentation to align with other files - Sort device table in alphabetical order - Add sentinel to device table Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-)

[PATCH v7 04/23] dt-bindings: display: mediatek: padding: Add MT8188

2023-10-06 Thread Hsiao Chien Sung
Padding is a new hardware module on MediaTek MT8188, add dt-bindings for it. Reviewed-by: Krzysztof Kozlowski Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- .../display/mediatek/mediatek,padding.yaml| 81 +++ 1 file changed, 81 insertions(+) create mode 100644 Doc

[PATCH v7 19/23] drm/mediatek: Return error if MDP RDMA failed to enable the clock

2023-10-06 Thread Hsiao Chien Sung
Return the result of clk_prepare_enable() instead of always returns 0. Fixes: f8946e2b6bb2 ("drm/mediatek: Add display MDP RDMA support for MT8195") Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_mdp_rdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/

[PATCH v7 06/23] dt-bindings: reset: mt8188: Add VDOSYS reset control bits

2023-10-06 Thread Hsiao Chien Sung
Add MT8188 VDOSYS0 and VDOSYS1 reset control bits. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Signed-off-by: Hsiao Chien Sung --- include/dt-bindings/reset/mt8188-resets.h | 75 +++ 1 file changed, 75 insertions(+) diff --git a/include/dt-bindin

[PATCH v7 07/23] soc: mediatek: Support MT8188 VDOSYS1 in mtk-mmsys

2023-10-06 Thread Hsiao Chien Sung
- Add register definitions for MT8188 - Add VDOSYS1 routing table - Update MUTEX definitions accordingly - Set VSYNC length from 0x40 (default) to 1 since ETHDR is bypassed Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/soc/mediatek/mt8188-mmsys.h | 126 +++

  1   2   >