Re: [Nouveau] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-06 Thread Thomas Zimmermann
Hi Am 06.09.23 um 04:14 schrieb suijingfeng: Hi, On 2023/9/5 23:05, Thomas Zimmermann wrote: However, on modern Linux systems the primary display does not really exist. No, it do exist.  X server need to know which one is the primary GPU. The '*' character at the of (4@0:0:0) PCI device is

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

2023-09-06 Thread Thomas Hellström
Hi, Danilo, Thanks for taking a look. Comments inline. On 9/5/23 21:50, Danilo Krummrich wrote: On Wed, Aug 16, 2023 at 11:15:47AM +0200, Thomas Hellström wrote: Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The docu

Re: [Nouveau] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-06 Thread Thomas Zimmermann
Hi Am 06.09.23 um 04:34 schrieb suijingfeng: On 2023/9/5 23:05, Thomas Zimmermann wrote: Hi Am 05.09.23 um 15:30 schrieb suijingfeng: Hi, On 2023/9/5 18:45, Thomas Zimmermann wrote: Hi Am 04.09.23 um 21:57 schrieb Sui Jingfeng: From: Sui Jingfeng On a machine with multiple GPUs, a Lin

Re: [PATCH] lockdep: Fix static memory detection even more

2023-09-06 Thread Helge Deller
* Guenter Roeck : > On 9/3/23 14:11, Helge Deller wrote: > > * Guenter Roeck : > > > Hi, > > > > > > On Sat, Aug 12, 2023 at 05:48:52PM +0200, Helge Deller wrote: > > > > On the parisc architecture, lockdep reports for all static objects which > > > > are in the __initdata section (e.g. "setup_don

Re: [PATCH v3 2/8] drm/panfrost: Enable cycle counter register upon job submission

2023-09-06 Thread Boris Brezillon
On Tue, 5 Sep 2023 19:45:18 +0100 Adrián Larumbe wrote: > In a future development, we will want to keep track of the number of GPU > cycles spent on a given job. That means we should enable it only when the > GPU has work to do, and switch it off whenever it is idle to avoid power > waste. > >

Re: [PATCH v3 3/8] drm/panfrost: Enable debugfs toggling of cycle counter register

2023-09-06 Thread Boris Brezillon
On Tue, 5 Sep 2023 19:45:19 +0100 Adrián Larumbe wrote: > Allow user space to decide whether the cycle counting register should be > enabled. The main goal is letting tools like nvtop or IGT's gputop access > this information in debug builds to obtain engine utilisation numbers. Given you add a

Re: [PATCH] MAINTAINERS: Add Jessica as a reviewer for drm/panel

2023-09-06 Thread Neil Armstrong
Hi, On Thu, 31 Aug 2023 15:57:36 -0700, Jessica Zhang wrote: > As I participate more actively in the drm/panel subsystem, I would > like to get notified about new changes in this area. > > Since I have contributed and continue to contribute to drm/panel, > add myself as a reviewer for the DRM pan

Re: [PATCH v3 4/8] drm/panfrost: Add fdinfo support GPU load metrics

2023-09-06 Thread Boris Brezillon
On Tue, 5 Sep 2023 19:45:20 +0100 Adrián Larumbe wrote: > The drm-stats fdinfo tags made available to user space are drm-engine, > drm-cycles, drm-max-freq and drm-curfreq, one per job slot. > > This deviates from standard practice in other DRM drivers, where a single > set of key:value pairs i

Re: [Nouveau] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-06 Thread Thomas Zimmermann
Hi Am 06.09.23 um 05:08 schrieb suijingfeng: Hi, On 2023/9/5 23:05, Thomas Zimmermann wrote: However, on modern Linux systems the primary display does not really exist. 'Primary' is the device that is available via VGA, VESA or EFI. I may miss the point, what do you means by choose the wor

Re: [PATCH v3 2/8] drm/panfrost: Enable cycle counter register upon job submission

2023-09-06 Thread Boris Brezillon
On Tue, 5 Sep 2023 19:45:18 +0100 Adrián Larumbe wrote: > diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c > b/drivers/gpu/drm/panfrost/panfrost_job.c > index 033f5e684707..8b1bf6ac48f8 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_job.c > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c >

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

2023-09-06 Thread Danilo Krummrich
On 9/6/23 09:06, Thomas Hellström wrote: Hi, Danilo, Thanks for taking a look. Comments inline. On 9/5/23 21:50, Danilo Krummrich wrote: On Wed, Aug 16, 2023 at 11:15:47AM +0200, Thomas Hellström wrote: Add the first version of the VM_BIND locking document which is intended to be part of the

Re: [PATCH v3 7/8] drm/panfrost: Implement generic DRM object RSS reporting function

2023-09-06 Thread Boris Brezillon
On Tue, 5 Sep 2023 19:45:23 +0100 Adrián Larumbe wrote: > BO's RSS is updated every time new pages are allocated on demand and mapped > for the object at GPU page fault's IRQ handler, but only for heap buffers. > The reason this is unnecessary for non-heap buffers is that they are mapped > onto

Re: [Nouveau] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-06 Thread Thomas Zimmermann
Hi Am 05.09.23 um 17:59 schrieb suijingfeng: [...] FYI: per-driver modeset parameters are deprecated and not to be used. Please don't promote them. Well, please wait, I want to explain. drm/nouveau already promote it a little bit. Despite no code of conduct or specification guiding how th

Re: [PATCH v3 8/8] drm/drm-file: Show finer-grained BO sizes in drm_show_memory_stats

2023-09-06 Thread Boris Brezillon
On Tue, 5 Sep 2023 19:45:24 +0100 Adrián Larumbe wrote: > The current implementation will try to pick the highest available size > display unit as soon as the BO size exceeds that of the previous > multiplier. > > By selecting a higher threshold, we could show more accurate size numbers. > > S

Re: [PATCH] lockdep: Fix static memory detection even more

2023-09-06 Thread Guenter Roeck
On 9/6/23 00:18, Helge Deller wrote: * Guenter Roeck : On 9/3/23 14:11, Helge Deller wrote: * Guenter Roeck : Hi, On Sat, Aug 12, 2023 at 05:48:52PM +0200, Helge Deller wrote: On the parisc architecture, lockdep reports for all static objects which are in the __initdata section (e.g. "setup_

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

2023-09-06 Thread Thomas Hellström
On 9/6/23 10:00, Danilo Krummrich wrote: On 9/6/23 09:06, Thomas Hellström wrote: Hi, Danilo, Thanks for taking a look. Comments inline. On 9/5/23 21:50, Danilo Krummrich wrote: On Wed, Aug 16, 2023 at 11:15:47AM +0200, Thomas Hellström wrote: Add the first version of the VM_BIND locking do

Re: [PATCH 3/3] drm/drm_exec: Work around a WW mutex lockdep oddity

2023-09-06 Thread Christian König
Am 05.09.23 um 16:29 schrieb Thomas Hellström: Hi, Christian On 9/5/23 15:14, Christian König wrote: Am 05.09.23 um 10:58 schrieb Thomas Hellström: If *any* object of a certain WW mutex class is locked, lockdep will consider *all* mutexes of that class as locked. Also the lock allocation tra

Re: [RFT PATCH 03/15] drm/ingenic: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-06 Thread Maxime Ripard
On Tue, Sep 05, 2023 at 01:16:08PM -0700, Doug Anderson wrote: > > > --- > > > This commit is only compile-time tested. > > > > > > NOTE: this patch touches a lot more than other similar patches since > > > the bind() function is long and we want to make sure that we unset > > > the > > > drvdata i

Re: [Intel-gfx] [PATCH v5 3/6] drm/i915/panelreplay: Initializaton and compute config for panel replay

2023-09-06 Thread Dan Carpenter
://lore.kernel.org/r/20230905073551.958368-4-animesh.manna%40intel.com patch subject: [Intel-gfx] [PATCH v5 3/6] drm/i915/panelreplay: Initializaton and compute config for panel replay config: i386-randconfig-141-20230906 (https://download.01.org/0day-ci/archive/20230906/202309060644.uwp5zw4i

Re: [Nouveau] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-06 Thread suijingfeng
Hi, On 2023/9/6 14:45, Christian König wrote: Am 05.09.23 um 15:30 schrieb suijingfeng: Hi, On 2023/9/5 18:45, Thomas Zimmermann wrote: Hi Am 04.09.23 um 21:57 schrieb Sui Jingfeng: From: Sui Jingfeng On a machine with multiple GPUs, a Linux user has no control over which one is primar

Re: [RFC][PATCH 0/2] drm/panic: Add a drm panic handler

2023-09-06 Thread Thomas Zimmermann
Hi Jocelyn Am 05.09.23 um 16:46 schrieb Jocelyn Falempe: On 04/09/2023 16:29, Thomas Zimmermann wrote: Hi Jocelyn, thanks for moving this effort forward. It's much appreciated. I looked through the patches and tried the patchset on my test machine. Thanks for taking the time to review and t

Re: [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-09-06 Thread Andi Shyti
Hi John, > > > > > > static void guc_cancel_busyness_worker(struct intel_guc *guc) > > > > > > { > > > > > > - cancel_delayed_work_sync(&guc->timestamp.work); > > > > > > + /* > > > > > > +* When intel_gt_reset was called, task will hold a lock. > > > > > > +* To cacel delayed

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Drop force_probe requirement

2023-09-06 Thread Andi Shyti
Hi Radhakrishna, On Tue, Sep 05, 2023 at 12:36:24PM -0700, Radhakrishna Sripada wrote: > Meteorlake has been very usable for a while now, all of uapi changes > related to fundamental platform usage have been finalized and all > required firmware blobs are available. Recent CI results have also > b

Re: [RFC][PATCH 0/2] drm/panic: Add a drm panic handler

2023-09-06 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Jocelyn and Thomas, > Hi Jocelyn > > Am 05.09.23 um 16:46 schrieb Jocelyn Falempe: [...] >> >> I'm a bit reluctant to re-use the fbdev code, for a few reasons: >>  * I want drm_panic to work if CONFIG_FB and CONFIG_DRM_FBDEV_EMULATION >> are not set. > > The

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Drop force_probe requirement

2023-09-06 Thread Andi Shyti
> > Meteorlake has been very usable for a while now, all of uapi changes > > related to fundamental platform usage have been finalized and all > > required firmware blobs are available. Recent CI results have also > > been healthy, so we're ready to drop the force_probe requirement and > > enable t

Re: [PATCH 0/5] drm/bridge: samsung-dsim: fix various modes with ADV7535 bridge

2023-09-06 Thread Frieder Schrempf
On 04.09.23 16:02, Frieder Schrempf wrote: > Hi Michael, > > On 28.08.23 17:59, Michael Tretter wrote: >> I tested the i.MX8M Nano EVK with the NXP supplied MIPI-DSI adapter, >> which uses an ADV7535 MIPI-DSI to HDMI converter. I found that a few >> modes were working, but in many modes my monitor

Re: [Nouveau] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-06 Thread Christian König
Am 06.09.23 um 11:08 schrieb suijingfeng: Well, welcome to correct me if I'm wrong. You seem to have some very basic misunderstandings here. The term framebuffer describes some VRAM memory used for scanout. This framebuffer is exposed to userspace through some framebuffer driver, on UEFI pla

[Bug 217876] New: RIP: 0010:calculate_phy_pix_clks+0xd1/0xe0 [amdgpu]

2023-09-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217876 Bug ID: 217876 Summary: RIP: 0010:calculate_phy_pix_clks+0xd1/0xe0 [amdgpu] Product: Drivers Version: 2.5 Hardware: AMD OS: Linux Status: NEW Severity: bl

[PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the comment in rzg2l_mipi_dsi_start_video()

2023-09-06 Thread Biju Das
Add missing space in the comment in rzg2l_mipi_dsi_start_video(). Reported-by: Pavel Machek Closes: https://lore.kernel.org/all/zpg7sthdn4lbl...@duo.ucw.cz/ Signed-off-by: Biju Das --- This issue is noticed while backporting this driver to 6.1.y-cip [1]. [1] https://lore.kernel.org/all/2023090

Re: [PATCH 1/7] fbdev/au1200fb: Do not display boot-up logo

2023-09-06 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > The fbcon module takes care of displaying the logo, if any. Remove > the code form au1200fb. If we want to display the logo without fbcon, > we should implement this in the fbdev core code. > Agreed. I see that this code has been since the driver was added in 2006, I

Re: [Nouveau] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-06 Thread suijingfeng
Hi, On 2023/9/6 16:05, Thomas Zimmermann wrote: Hi Am 05.09.23 um 17:59 schrieb suijingfeng: [...] FYI: per-driver modeset parameters are deprecated and not to be used. Please don't promote them. Well, please wait, I want to explain. drm/nouveau already promote it a little bit. Despite

[PATCH v2 0/3] drm/drm_exec, drm/tests: Fix / WA for uaf and lock alloc tracking

2023-09-06 Thread Thomas Hellström
While trying to replicate a weird drm_exec lock alloc tracking warning using the drm_exec kunit test, the warning was shadowed by a UAF warning from KASAN due to a bug in the drm kunit helpers. Patch 1 fixes that drm kunit UAF. Patch 2 introduces a drm_exec kunit subtest that shows the weird lock

[PATCH v2 1/3] drm/tests: helpers: Avoid a driver uaf

2023-09-06 Thread Thomas Hellström
when using __drm_kunit_helper_alloc_drm_device() the driver may be dereferenced by device-managed resources up until the device is freed, which is typically later than the kunit-managed resource code frees it. Fix this by simply make the driver device-managed as well. v2: - Update commit message,

[PATCH v2 3/3] drm/drm_exec: Work around a WW mutex lockdep oddity

2023-09-06 Thread Thomas Hellström
If *any* object of a certain WW mutex class is locked, lockdep will consider *all* mutexes of that class as locked. Also the lock allocation tracking code will apparently register only the address of the first mutex of a given class locked in a sequence. This has the odd consequence that if that fi

[PATCH v2 2/3] drm/tests/drm_exec: Add a test for object freeing within drm_exec_fini()

2023-09-06 Thread Thomas Hellström
Check that object freeing from within drm_exec_fini() works as expected and doesn't generate any warnings. Cc: Christian König Cc: dri-devel@lists.freedesktop.org Signed-off-by: Thomas Hellström --- drivers/gpu/drm/tests/drm_exec_test.c | 47 +++ 1 file changed, 47 inser

Re: [PATCH 2/7] fbdev/mmp/mmpfb: Do not display boot-up logo

2023-09-06 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > The fbcon module takes care of displaying the logo, if any. Remove > the code form mmpfb. If we want to display the logo without fbcon, s/form/from > we should implement this in the fbdev core code. > The commit message says the same than patch #1 but the driver wil

[PATCH v6 02/20] drm/gpuva_mgr: Helper to get range of unmap from a remap op.

2023-09-06 Thread Sarah Walker
From: Donald Robson Signed-off-by: Donald Robson --- include/drm/drm_gpuva_mgr.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/include/drm/drm_gpuva_mgr.h b/include/drm/drm_gpuva_mgr.h index ed8d50200cc3..be7b3a6d7e67 100644 --- a/include/drm/drm_gpuva_mgr.h +

[PATCH v6 00/20] Imagination Technologies PowerVR DRM driver

2023-09-06 Thread Sarah Walker
This patch series adds the initial DRM driver for Imagination Technologies PowerVR GPUs, starting with those based on our Rogue architecture. It's worth pointing out that this is a new driver, written from the ground up, rather than a refactored version of our existing downstream driver (pvrsrvkm)

[PATCH v6 01/20] sizes.h: Add entries between 32G and 64T

2023-09-06 Thread Sarah Walker
From: Matt Coster Signed-off-by: Matt Coster Reviewed-by: Linus Walleij --- include/linux/sizes.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/sizes.h b/include/linux/sizes.h index 84aa448d8bb3..c3a00b967d18 100644 --- a/include/linux/sizes.h +++ b/include/linux/s

Re: [PATCH 0/5] drm/bridge: samsung-dsim: fix various modes with ADV7535 bridge

2023-09-06 Thread Michael Tretter
Hi Frieder, On Wed, 06 Sep 2023 11:31:45 +0200, Frieder Schrempf wrote: > On 04.09.23 16:02, Frieder Schrempf wrote: > > On 28.08.23 17:59, Michael Tretter wrote: > >> I tested the i.MX8M Nano EVK with the NXP supplied MIPI-DSI adapter, > >> which uses an ADV7535 MIPI-DSI to HDMI converter. I foun

[PATCH v6 05/20] drm/imagination: Add skeleton PowerVR driver

2023-09-06 Thread Sarah Walker
This adds the basic skeleton of the driver. The driver registers itself with DRM on probe. Ioctl handlers are currently implemented as stubs. Changes since v5: - Update compatible string & description to match marketing name - Checkpatch fixes in to/from_pvr_device/file macros Changes since v3: -

[PATCH v6 03/20] dt-bindings: gpu: Add Imagination Technologies PowerVR/IMG GPU

2023-09-06 Thread Sarah Walker
Add the device tree binding documentation for the IMG AXE GPU used in TI AM62 SoCs. Co-developed-by: Frank Binns Signed-off-by: Frank Binns Signed-off-by: Sarah Walker --- Changes since v5: - Update compatible string & description to match marketing name - Remove unnecessary clock-names definit

[PATCH v6 06/20] drm/imagination: Get GPU resources

2023-09-06 Thread Sarah Walker
Acquire clock and register resources, and enable/map as appropriate. Changes since v3: - Remove regulator resource (not used on supported platform) - Use devm helpers - Use devm_clk_get_optional() for optional clocks - Don't prepare clocks on resource acquisition - Drop pvr_device_clk_core_get_fre

[PATCH v6 10/20] drm/imagination: Add GPU ID parsing and firmware loading

2023-09-06 Thread Sarah Walker
Read the GPU ID register at probe time and select the correct features/quirks/enhancements. Use the GPU ID to form the firmware file name and load the firmware. The features/quirks/enhancements arrays are currently hardcoded in the driver for the supported GPUs. We are looking at moving this infor

[PATCH v6 12/20] drm/imagination: Implement power management

2023-09-06 Thread Sarah Walker
Add power management to the driver, using runtime pm. The power off sequence depends on firmware commands which are not implemented in this patch. Changes since v5: - Use RUNTIME_PM_OPS() to declare PM callbacks - Add Kconfig dependency on CONFIG_PM Changes since v4: - Suspend runtime PM before u

[PATCH v6 14/20] drm/imagination: Implement MIPS firmware processor and MMU support

2023-09-06 Thread Sarah Walker
Add support for the MIPS firmware processor, used in the Series AXE GPU. The MIPS firmware processor uses a separate MMU to the rest of the GPU, so this patch adds support for that as well. Changes since v5: - Use alloc_page() when allocating MIPS pagetable Changes since v3: - Get regs resource (

[PATCH v6 15/20] drm/imagination: Implement free list and HWRT create and destroy ioctls

2023-09-06 Thread Sarah Walker
Implement ioctls to create and destroy free lists and HWRT datasets. Free lists are used for GPU-side memory allocation during geometry processing. HWRT datasets are the FW-side structures representing render targets. Changes since v4: - Remove use of drm_gem_shmem_get_pages() Changes since v3: -

[PATCH v6 08/20] drm/imagination: Add firmware and MMU related headers

2023-09-06 Thread Sarah Walker
Changes since v5: - Split up header commit due to size Signed-off-by: Sarah Walker --- .../drm/imagination/pvr_rogue_heap_config.h | 113 ++ drivers/gpu/drm/imagination/pvr_rogue_meta.h | 356 ++ drivers/gpu/drm/imagination/pvr_rogue_mips.h | 335 .../drm

[PATCH v6 20/20] drm/imagination: Add driver documentation

2023-09-06 Thread Sarah Walker
Add documentation for the UAPI. Changes since v5: - Remove obsolete VM documentation Co-developed-by: Matt Coster Signed-off-by: Matt Coster Co-developed-by: Donald Robson Signed-off-by: Donald Robson Signed-off-by: Sarah Walker Reviewed-by: Maxime Ripard --- Documentation/gpu/drivers.rst

[PATCH v6 04/20] drm/imagination/uapi: Add PowerVR driver UAPI

2023-09-06 Thread Sarah Walker
Add the UAPI implementation for the PowerVR driver. Changes from v4: - Remove CREATE_ZEROED flag for BO creation (all buffers are now zeroed) Co-developed-by: Frank Binns Signed-off-by: Frank Binns Co-developed-by: Boris Brezillon Signed-off-by: Boris Brezillon Co-developed-by: Matt Coster S

[PATCH v6 16/20] drm/imagination: Implement context creation/destruction ioctls

2023-09-06 Thread Sarah Walker
Implement ioctls for the creation and destruction of contexts. Contexts are used for job submission and each is associated with a particular job type. Changes since v5: - Fix context release in final error path in pvr_context_create() Changes since v3: - Use drm_dev_{enter,exit} Co-developed-by:

[PATCH v6 19/20] drm/imagination: Add firmware trace to debugfs

2023-09-06 Thread Sarah Walker
Firmware trace is exposed at /sys/debug/dri//pvr_fw/trace_0. Trace is enabled via the group mask at /sys/debug/dri//pvr_params/fw_trace_mask. Changes since v3: - Use drm_dev_{enter,exit} Co-developed-by: Matt Coster Signed-off-by: Matt Coster Signed-off-by: Sarah Walker --- drivers/gpu/drm/im

[PATCH v6 18/20] drm/imagination: Add firmware trace header

2023-09-06 Thread Sarah Walker
Changes since v5: - Split up header commit due to size Signed-off-by: Sarah Walker --- .../gpu/drm/imagination/pvr_rogue_fwif_sf.h | 1648 + 1 file changed, 1648 insertions(+) create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_fwif_sf.h diff --git a/drivers/gpu/drm/imag

[PATCH v6 13/20] drm/imagination: Implement firmware infrastructure and META FW support

2023-09-06 Thread Sarah Walker
The infrastructure includes parsing of the firmware image, initialising FW-side structures, handling the kernel and firmware command ringbuffers and starting & stopping the firmware processor. This patch also adds the necessary support code for the META firmware processor. Changes since v5: - Add

[PATCH v6 17/20] drm/imagination: Implement job submission and scheduling

2023-09-06 Thread Sarah Walker
Implement job submission ioctl. Job scheduling is implemented using drm_sched. Jobs are submitted in a stream format. This is intended to allow the UAPI data format to be independent of the actual FWIF structures in use, which vary depending on the GPU in use. The stream formats are documented at

Re: [PATCH 3/7] fbdev/core: Fix style of code for boot-up logo

2023-09-06 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Fix a number of warnings from checkpatch.pl in this code before > moving it into a separate file. This includes > > * Prefer 'unsigned int' to bare use of 'unsigned' > * space required after that ',' (ctx:VxV) > * space prohibited after that open parenthesis '(' >

Re: [PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the comment in rzg2l_mipi_dsi_start_video()

2023-09-06 Thread Geert Uytterhoeven
On Wed, Sep 6, 2023 at 11:44 AM Biju Das wrote: > Add missing space in the comment in rzg2l_mipi_dsi_start_video(). > > Reported-by: Pavel Machek > Closes: https://lore.kernel.org/all/zpg7sthdn4lbl...@duo.ucw.cz/ > Signed-off-by: Biju Das Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [Intel-gfx] [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-09-06 Thread Jani Nikula
On Wed, 06 Sep 2023, Andi Shyti wrote: >> > I was actually thinking why not leave things as they are and just >> > disable lockdep from CI. This doesn't look like a relevant report >> > to me. >> > >> > Andi >> Disable lockdep? The whole of lockdep? We absolutely do not want to disable >> an extr

Re: [Intel-xe] [PATCH 2/3] drm/tests/drm_exec: Add a test for object freeing within drm_exec_fini()

2023-09-06 Thread Maxime Ripard
On Tue, Sep 05, 2023 at 03:42:58PM +0200, Thomas Hellström wrote: > Hi, Maxime > > On 9/5/23 15:16, Maxime Ripard wrote: > > On Tue, Sep 05, 2023 at 02:32:38PM +0200, Thomas Hellström wrote: > > > Hi, > > > > > > On 9/5/23 14:05, Maxime Ripard wrote: > > > > Hi, > > > > > > > > On Tue, Sep 05, 2

Re: [Intel-xe] [PATCH 1/3] drm/kunit: Avoid a driver uaf

2023-09-06 Thread Maxime Ripard
On Tue, Sep 05, 2023 at 02:43:00PM +0200, Thomas Hellström wrote: > Hi maxime, > > On 9/5/23 14:06, Maxime Ripard wrote: > > On Tue, Sep 05, 2023 at 10:58:30AM +0200, Thomas Hellström wrote: > > > when using __drm_kunit_helper_alloc_drm_device() the driver may be > > > dereferenced by device-manag

Re: [PATCH 4/7] fbdev/core: Move logo functions into separate source file

2023-09-06 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Move the fbdev function for displaying boot-up logos into their > own file fb_logo.c. The file can later be build depending on the > state of CONFIG_LOGO. No functional changes. > > Signed-off-by: Thomas Zimmermann > --- > drivers/video/fbdev/core/Makefile | 1

Re: [PATCH 5/7] fbdev/core: Build fb_logo iff CONFIG_LOGO has been selected

2023-09-06 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Only build fb_logo.c if CONFIG_LOGO has been selected. Otherwise > provide empty implementations of the contained interfaces and avoid > using the exported variables. > > Signed-off-by: Thomas Zimmermann Ah! You are doing in this patch exactly what I mentioned in my

Re: [PATCH 6/7] fbdev/core: Remove empty internal helpers from fb_logo.c

2023-09-06 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Remove the two empty helpers for the case the CONFIG_FB_LOGO_EXTRA > has not been set. They are internal functions and only called once. > Providing empty replacements seems like overkill. Instead protect > the call sites with a test for CONFIG_FB_LOGO_EXTRA. > > Signe

Re: [PATCH 7/7] fbdev/core: Clean up include statements in fbmem.c

2023-09-06 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Remove all unnecessary include statements from fbmem.c. Most of > them were for functionality that has meanwhile been moved into > other files. > > Signed-off-by: Thomas Zimmermann > --- Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas

Re: [Nouveau] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-06 Thread Sui Jingfeng
Hi, On 2023/9/6 14:45, Christian König wrote: Firmware framebuffer device already get killed by the drm_aperture_remove_conflicting_pci_framebuffers() function (or its siblings). So, this series is definitely not to interact with the firmware framebuffer (or more intelligent framebuffer drivers

Re: [Intel-gfx] [PATCH v2 09/22] drm/dp_mst: Fix fractional bpp scaling in drm_dp_calc_pbn_mode()

2023-09-06 Thread Ville Syrjälä
On Mon, Sep 04, 2023 at 01:22:27PM +0300, Imre Deak wrote: > On Mon, Sep 04, 2023 at 05:53:11AM +0300, Ville Syrjälä wrote: > > On Thu, Aug 24, 2023 at 11:05:04AM +0300, Imre Deak wrote: > > > For fractional bpp values passed to the function in a .4 fixed point > > > format, the fractional part is

Re: [Nouveau] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-06 Thread Christian König
Am 06.09.23 um 12:31 schrieb Sui Jingfeng: Hi, On 2023/9/6 14:45, Christian König wrote: Firmware framebuffer device already get killed by the drm_aperture_remove_conflicting_pci_framebuffers() function (or its siblings). So, this series is definitely not to interact with the firmware framebuf

Re: [PATCH v2 02/15] drm/panthor: Add uAPI

2023-09-06 Thread Steven Price
On 04/09/2023 17:25, Robin Murphy wrote: > On 2023-09-04 17:16, Boris Brezillon wrote: >> On Mon, 4 Sep 2023 16:22:19 +0100 >> Steven Price wrote: >> >>> On 04/09/2023 10:26, Boris Brezillon wrote: On Mon, 4 Sep 2023 08:42:08 +0100 Steven Price wrote:    > On 01/09/2023 17:10,

Re: [PATCH v16 20/20] drm/panfrost: Switch to generic memory shrinker

2023-09-06 Thread Steven Price
On 05/09/2023 09:08, Boris Brezillon wrote: > On Mon, 4 Sep 2023 14:20:24 +0100 > Steven Price wrote: > >> On 03/09/2023 18:07, Dmitry Osipenko wrote: >>> Replace Panfrost's custom memory shrinker with a common drm-shmem >>> memory shrinker. >>> >>> Tested-by: Steven Price # Firefly-RK3288 >>

Re: [Intel-gfx] [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-09-06 Thread Daniel Vetter
On Wed, Sep 06, 2023 at 01:04:06PM +0300, Jani Nikula wrote: > On Wed, 06 Sep 2023, Andi Shyti wrote: > > It's the developer's responsibility to test its code with > > debug_lockdep and fix all the potential deadlocks and ignore the > > false ones. > > No. Manual validation of lockdep reports is

Re: [Nouveau] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-06 Thread Thomas Zimmermann
Hi Am 06.09.23 um 11:48 schrieb suijingfeng: [...] There's 'nomodeset', which disables all native drivers. It's useful for debugging or as a quick-fix if the graphics driver breaks. If you want to disable a specific driver, please use one of the options for blacklisting. Yeah, the 'nomode

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

2023-09-06 Thread Boris Brezillon
On Wed, 6 Sep 2023 10:32:24 +0200 Thomas Hellström wrote: > +Introducing external (or shared) buffer objects > +=== > + > +Since shared buffer objects may be shared by multiple gpu_vm's they > +can't share their reservation obj

Re: [Intel-gfx] [PATCH v2 09/22] drm/dp_mst: Fix fractional bpp scaling in drm_dp_calc_pbn_mode()

2023-09-06 Thread Imre Deak
On Wed, Sep 06, 2023 at 01:45:51PM +0300, Ville Syrjälä wrote: > On Mon, Sep 04, 2023 at 01:22:27PM +0300, Imre Deak wrote: > > On Mon, Sep 04, 2023 at 05:53:11AM +0300, Ville Syrjälä wrote: > > > On Thu, Aug 24, 2023 at 11:05:04AM +0300, Imre Deak wrote: > > > > For fractional bpp values passed to

Re: [PATCH v6 02/20] drm/gpuva_mgr: Helper to get range of unmap from a remap op.

2023-09-06 Thread Maxime Ripard
Hi Sarah, On Wed, Sep 06, 2023 at 10:55:24AM +0100, Sarah Walker wrote: > From: Donald Robson > > Signed-off-by: Donald Robson Sorry, this applied to your previous versions too but I only caught it right now. When you submit a patch on someone else's behalf, you need to add your Signed-off-by.

Re: [PATCH v6 03/20] dt-bindings: gpu: Add Imagination Technologies PowerVR/IMG GPU

2023-09-06 Thread Maxime Ripard
On Wed, 6 Sep 2023 10:55:25 +0100, Sarah Walker wrote: > Add the device tree binding documentation for the IMG AXE GPU used in > TI AM62 SoCs. > > Co-developed-by: Frank Binns > Signed-off-by: Frank Binns > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v6 03/20] dt-bindings: gpu: Add Imagination Technologies PowerVR/IMG GPU

2023-09-06 Thread Maxime Ripard
On Wed, 6 Sep 2023 10:55:25 +0100, Sarah Walker wrote: > Add the device tree binding documentation for the IMG AXE GPU used in > TI AM62 SoCs. > > Co-developed-by: Frank Binns > Signed-off-by: Frank Binns > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

[syzbot] [dri?] WARNING in drm_syncobj_array_find

2023-09-06 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:0468be89b3fa Merge tag 'iommu-updates-v6.6' of git://git.k.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=13571367a8 kernel config: https://syzkaller.appspot.com/x/.config?x=39744401c57166fc das

Re: [PATCH v6 09/20] drm/imagination: Add FWIF headers

2023-09-06 Thread Maxime Ripard
On Wed, 6 Sep 2023 10:55:31 +0100, Sarah Walker wrote: > Changes since v5: > - Split up header commit due to size > - Add BRN 71242 to device info > > Changes since v4: > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v6 02/20] drm/gpuva_mgr: Helper to get range of unmap from a remap op.

2023-09-06 Thread Sarah Walker
On Wed, 2023-09-06 at 13:35 +0200, Maxime Ripard wrote: > Hi Sarah, > > On Wed, Sep 06, 2023 at 10:55:24AM +0100, Sarah Walker wrote: > > From: Donald Robson > > > > Signed-off-by: Donald Robson > > Sorry, this applied to your previous versions too but I only caught it > right now. When you su

Re: [PATCH v1 v1 4/7] drm/fourcc: Add drm/vs tiled modifiers

2023-09-06 Thread Thomas Zimmermann
Hi Am 01.08.23 um 12:10 schrieb Keith Zhao: These are mainly used internally in vs-drm, I'm not sure if the new modifiers can be used with the existing ones. If there is a problem, I will improve it further. Signed-off-by: Keith Zhao --- include/uapi/drm/drm_fourcc.h | 27 +++

Re: [PATCH v6 07/20] drm/imagination: Add GPU register headers

2023-09-06 Thread Maxime Ripard
On Wed, 6 Sep 2023 10:55:29 +0100, Sarah Walker wrote: > Changes since v5: > - Split up header commit due to size > > Signed-off-by: Sarah Walker Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-06 Thread Maxime Ripard
On Fri, Sep 01, 2023 at 02:08:11PM +0200, Geert Uytterhoeven wrote: > Hi Maxime, > > On Fri, Sep 1, 2023 at 2:00 PM Maxime Ripard wrote: > > On Fri, Sep 01, 2023 at 10:36:17AM +0200, Geert Uytterhoeven wrote: > > > On Fri, Sep 1, 2023 at 10:22 AM Maxime Ripard wrote: > > > > On Wed, Aug 30, 2023

Re: [PATCH v6 08/20] drm/imagination: Add firmware and MMU related headers

2023-09-06 Thread Maxime Ripard
On Wed, 6 Sep 2023 10:55:30 +0100, Sarah Walker wrote: > Changes since v5: > - Split up header commit due to size > > Signed-off-by: Sarah Walker Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

2023-09-06 Thread Thomas Hellström
Hi, Boris On 9/6/23 13:09, Boris Brezillon wrote: On Wed, 6 Sep 2023 10:32:24 +0200 Thomas Hellström wrote: +Introducing external (or shared) buffer objects +=== + +Since shared buffer objects may be shared by multiple gpu_vm's they +can't share th

Re: [PATCH] Remove the parameter not described warning

2023-09-06 Thread Sumit Semwal
Hello Vinayak, On Mon, 21 Aug 2023 at 20:56, Vinayak Hegde wrote: > > Signed-off-by: Vinayak Hegde Thank you for your patch. Could you please make the git commit message a bit more descriptive? Please describe how did you find this warning, atleast. > --- > include/uapi/linux/sync_file.h | 2

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-06 Thread Javier Martinez Canillas
Maxime Ripard writes: > On Fri, Sep 01, 2023 at 02:08:11PM +0200, Geert Uytterhoeven wrote: >> Hi Maxime, >> >> On Fri, Sep 1, 2023 at 2:00 PM Maxime Ripard wrote: >> > On Fri, Sep 01, 2023 at 10:36:17AM +0200, Geert Uytterhoeven wrote: >> > > On Fri, Sep 1, 2023 at 10:22 AM Maxime Ripard wrot

Re: [PATCH v2 02/15] drm/panthor: Add uAPI

2023-09-06 Thread Ketil Johnsen
On 8/9/23 18:53, Boris Brezillon wrote: +enum drm_panthor_sync_op_flags { + /** @DRM_PANTHOR_SYNC_OP_HANDLE_TYPE_MASK: Synchronization handle type mask. */ + DRM_PANTHOR_SYNC_OP_HANDLE_TYPE_MASK = 0xff, + + /** @DRM_PANTHOR_SYNC_OP_HANDLE_TYPE_SYNCOBJ: Synchronization object

Re: [PATCH v2 12/15] drm/panthor: Add the driver frontend block

2023-09-06 Thread Ketil Johnsen
On 8/9/23 18:53, Boris Brezillon wrote: +static int panthor_ioctl_vm_create(struct drm_device *ddev, void *data, + struct drm_file *file) +{ + struct panthor_device *ptdev = container_of(ddev, struct panthor_device, base); + u32 va_bits = GPU_MMU_FEAT

Re: [RFC PATCH v1 01/12] Revert "drm/sysfs: Link DRM connectors to corresponding Type-C connectors"

2023-09-06 Thread Heikki Krogerus
On Tue, Sep 05, 2023 at 01:56:59PM +0300, Dmitry Baryshkov wrote: > Hi Heikki, > > On Tue, 5 Sept 2023 at 11:50, Heikki Krogerus > wrote: > > > > Hi Dmitry, > > > > On Mon, Sep 04, 2023 at 12:41:39AM +0300, Dmitry Baryshkov wrote: > > > The kdev->fwnode pointer is never set in drm_sysfs_connector

Re: [RFC PATCH v1 01/12] Revert "drm/sysfs: Link DRM connectors to corresponding Type-C connectors"

2023-09-06 Thread Dmitry Baryshkov
On Wed, 6 Sept 2023 at 15:44, Heikki Krogerus wrote: > > On Tue, Sep 05, 2023 at 01:56:59PM +0300, Dmitry Baryshkov wrote: > > Hi Heikki, > > > > On Tue, 5 Sept 2023 at 11:50, Heikki Krogerus > > wrote: > > > > > > Hi Dmitry, > > > > > > On Mon, Sep 04, 2023 at 12:41:39AM +0300, Dmitry Baryshkov

Re: [RFC PATCH v1 01/12] Revert "drm/sysfs: Link DRM connectors to corresponding Type-C connectors"

2023-09-06 Thread Laurent Pinchart
On Wed, Sep 06, 2023 at 03:48:35PM +0300, Dmitry Baryshkov wrote: > On Wed, 6 Sept 2023 at 15:44, Heikki Krogerus wrote: > > On Tue, Sep 05, 2023 at 01:56:59PM +0300, Dmitry Baryshkov wrote: > > > On Tue, 5 Sept 2023 at 11:50, Heikki Krogerus wrote: > > > > On Mon, Sep 04, 2023 at 12:41:39AM +0300,

Re: [PATCH v2 2/7] drm: ci: Force db410c to host mode

2023-09-06 Thread Helen Koike
Hi! On 04/09/2023 13:15, Vignesh Raman wrote: Force db410c to host mode to fix network issue which results in failure to mount root fs via NFS. See https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/cb72a629b8c15c80a54dda510743cefd1c4b65b8 Use fdtoverlay command to merge base device tree wit

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

2023-09-06 Thread Boris Brezillon
On Wed, 6 Sep 2023 13:57:03 +0200 Thomas Hellström wrote: > Hi, Boris > > On 9/6/23 13:09, Boris Brezillon wrote: > > On Wed, 6 Sep 2023 10:32:24 +0200 > > Thomas Hellström wrote: > > > > > >> +Introducing external (or shared) buffer objects > >> +=

Re: [PATCH v2 12/15] drm/panthor: Add the driver frontend block

2023-09-06 Thread Boris Brezillon
On Wed, 6 Sep 2023 14:38:15 +0200 Ketil Johnsen wrote: > On 8/9/23 18:53, Boris Brezillon wrote: > > +static int panthor_ioctl_vm_create(struct drm_device *ddev, void *data, > > + struct drm_file *file) > > +{ > > + struct panthor_device *ptdev = container_of(ddev,

Re: [PATCH v2 2/7] drm: ci: Force db410c to host mode

2023-09-06 Thread Maxime Ripard
On Wed, Sep 06, 2023 at 09:55:40AM -0300, Helen Koike wrote: > Hi! > > On 04/09/2023 13:15, Vignesh Raman wrote: > > Force db410c to host mode to fix network issue which results in failure > > to mount root fs via NFS. > > See > > https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/cb72a629b8c15

Re: [PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the comment in rzg2l_mipi_dsi_start_video()

2023-09-06 Thread Laurent Pinchart
Hi Biju, Thank you for the patch. On Wed, Sep 06, 2023 at 10:43:46AM +0100, Biju Das wrote: > Add missing space in the comment in rzg2l_mipi_dsi_start_video(). > > Reported-by: Pavel Machek > Closes: https://lore.kernel.org/all/zpg7sthdn4lbl...@duo.ucw.cz/ > Signed-off-by: Biju Das Reviewed-b

Re: [RFC PATCH v1 01/12] Revert "drm/sysfs: Link DRM connectors to corresponding Type-C connectors"

2023-09-06 Thread Heikki Krogerus
On Wed, Sep 06, 2023 at 03:48:35PM +0300, Dmitry Baryshkov wrote: > On Wed, 6 Sept 2023 at 15:44, Heikki Krogerus > wrote: > > > > On Tue, Sep 05, 2023 at 01:56:59PM +0300, Dmitry Baryshkov wrote: > > > Hi Heikki, > > > > > > On Tue, 5 Sept 2023 at 11:50, Heikki Krogerus > > > wrote: > > > > > >

[Bug 217872] RIP: 0010:amdgpu_vm_pde_update [amdgpu]

2023-09-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217872 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [PATCH v1 v1 5/7] drm/vs: Register DRM device

2023-09-06 Thread Thomas Zimmermann
Hi Am 01.08.23 um 12:10 schrieb Keith Zhao: Implement drm device registration interface Signed-off-by: Keith Zhao --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/verisilicon/Kconfig | 25 ++ drivers/gpu/drm/veri

[Bug 217876] RIP: 0010:calculate_phy_pix_clks+0xd1/0xe0 [amdgpu]

2023-09-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217876 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

  1   2   3   >