On 8/9/23 18:53, Boris Brezillon wrote:
+enum drm_panthor_sync_op_flags {
+ /** @DRM_PANTHOR_SYNC_OP_HANDLE_TYPE_MASK: Synchronization handle type
mask. */
+ DRM_PANTHOR_SYNC_OP_HANDLE_TYPE_MASK = 0xff,
+
+ /** @DRM_PANTHOR_SYNC_OP_HANDLE_TYPE_SYNCOBJ: Synchronization object
type. */
+ DRM_PANTHOR_SYNC_OP_HANDLE_TYPE_SYNCOBJ = 0,
+
+ /**
+ * @DRM_PANTHOR_SYNC_OP_HANDLE_TYPE_TIMELINE_SYNCOBJ: Timeline
synchronization
+ * object type.
+ */
+ DRM_PANTHOR_SYNC_OP_HANDLE_TYPE_TIMELINE_SYNCOBJ = 1,
+
+ /** @DRM_PANTHOR_SYNC_OP_WAIT: Wait operation. */
+ DRM_PANTHOR_SYNC_OP_WAIT = 0 << 31,
+
+ /** @DRM_PANTHOR_SYNC_OP_SIGNAL: Signal operation. */
+ DRM_PANTHOR_SYNC_OP_SIGNAL = 1 << 31,
+};
We get an issue with --pedantic here:
warning: enumerator value for 'DRM_PANTHOR_SYNC_OP_SIGNAL' is not an
integer constant expression [-Wpedantic]
Would be god to get rid of this, so user space can include this header
without disabling pedantic. Either we can stop using the top most bit or
a cast value like "(int)(1U << 31)"
+ /**
+ * @DRM_PANTHOR_VM_BIND_OP_TYPE_MASK: Mask used to determine the type
of operation.
+ */
+ DRM_PANTHOR_VM_BIND_OP_TYPE_MASK = 0xf << 28,
Same issue for this member. Either not use the top most bit or cast
value like "(int)(0xfU << 28)" avoids the pedantic warning.
--
Regards,
Ketil Johnsen
