Re: [drm-misc:drm-misc-next 2/3] drivers/gpu/drm/loongson/lsdc_plane.c:199 lsdc_cursor_plane_atomic_async_check() warn: variable dereferenced before check 'state' (see line 180)

2023-07-10 Thread suijingfeng
: 8d1077cf2e43b15fefd76ebec2b71541eb27ef2c commit: f39db26c54281da6a785259498ca74b5e470476f [2/3] drm: Add kms driver for loongson display controller config: i386-randconfig-m021-20230710 (https://download.01.org/0day-ci/archive/20230710/202307100423.rv7d05uq-...@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14

Re: [PATCH] fbdev: imxfb: Convert to devm_platform_ioremap_resource()

2023-07-10 Thread Geert Uytterhoeven
Hi Yangtao, On Tue, Jul 4, 2023 at 11:38 AM Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Thanks for your patch, which is now commit c1cd7a7a231a26c6 ("fbdev: imxfb: Convert to devm_platform_ioremap_resource()") in fbdev/for-next > ---

Re: [drm-misc:drm-misc-next 2/3] drivers/gpu/drm/loongson/lsdc_plane.c:199 lsdc_cursor_plane_atomic_async_check() warn: variable dereferenced before check 'state' (see line 180)

2023-07-10 Thread Thomas Zimmermann
ommit: f39db26c54281da6a785259498ca74b5e470476f [2/3] drm: Add kms driver for loongson display controller config: i386-randconfig-m021-20230710 (https://download.01.org/0day-ci/archive/20230710/202307100423.rv7d05uq-...@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://downlo

Re: [drm-misc:drm-misc-next 2/3] drivers/gpu/drm/loongson/lsdc_plane.c:199 lsdc_cursor_plane_atomic_async_check() warn: variable dereferenced before check 'state' (see line 180)

2023-07-10 Thread suijingfeng
-20230710 (https://download.01.org/0day-ci/archive/20230710/202307100423.rv7d05uq-...@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230710/202307100423.rv7d05uq-...@intel.com/reproduce) If you fix the issue in a separate patch

Re: [PATCH 4/4] vgacon, arch/*: remove unused screen_info definitions

2023-07-10 Thread Max Filippov
On Fri, Jul 7, 2023 at 2:56 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > A number of architectures either kept the screen_info definition for > historical purposes as it used to be required by the generic VT code, or > they copied it from another architecture in order to build the VGA > co

[PATCH] dc_dmub_srv: Use max()/min() function for better coding conventions

2023-07-10 Thread Yang Rong
It is advisable to utilize the max() function in the dc_dmub_srv.c file, as it conforms better to programming conventions. Signed-off-by: Yang Rong --- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) mode change 100644 => 100755 drivers/

Fwd: [PATCH] drm/nouveau/i2c: do not use assignment in if condition

2023-07-10 Thread sunran001
Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busnv04.c | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 =>

[PATCH] drm/nouveau/i2c: do not use assignment in if condition

2023-07-10 Thread sunran001
Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busnv04.c | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 =>

[PATCH] drm/nouveau/nvkm: do not use assignment in if condition

2023-07-10 Thread sunran001
Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/g

[PATCH] drm/nouveau/i2c: do not use assignment in if condition

2023-07-10 Thread sunran001
Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busnv04.c | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 1

[PATCH] drm/nouveau/i2c: do not use assignment in if condition

2023-07-10 Thread sunran001
Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH] drm/nouveau/i2c: do not use assignment in if condition

2023-07-10 Thread sunran001
Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/pad.c | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 10064

[PATCH] drm/nouveau/pci: ERROR: "foo * bar" should be "foo *bar"

2023-07-10 Thread sunran001
Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/pci/gk104.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pci/gk104.c b/drivers/gpu/drm/nouveau/nvkm/subdev/pci/gk104.c index 6be87ecffc89..bc51987c5f5f 100644 --- a/drivers

[PATCH] drm/nouveau/iccsense:

2023-07-10 Thread sunran001
Fixed error: 'do not use assignment in if condition' This patch fixes error: 'do not use assignment in if condition' in drm/nouveau/iccsense Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/driv

[PATCH] drm/nouveau/i2c: do not use assignment in if condition

2023-07-10 Thread sunran001
Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/aux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu

[PATCH] drm/nouveau/nvkm: do not use assignment in if condition

2023-07-10 Thread sunran001
Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by:Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu

Re: [PATCH] fbdev: imxfb: Convert to devm_platform_ioremap_resource()

2023-07-10 Thread Yangtao Li
Hi Geert, On 2023/7/10 15:10, Geert Uytterhoeven wrote: [你通常不会收到来自 ge...@linux-m68k.org 的电子邮件。请访问 https://aka.ms/LearnAboutSenderIdentification,以了解这一点为什么很重要] Hi Yangtao, On Tue, Jul 4, 2023 at 11:38 AM Yangtao Li wrote: Use devm_platform_ioremap_resource() to simplify code. Signed-off-by:

Re: [drm-misc:drm-misc-next 2/3] drivers/gpu/drm/loongson/lsdc_plane.c:199 lsdc_cursor_plane_atomic_async_check() warn: variable dereferenced before check 'state' (see line 180)

2023-07-10 Thread Dan Carpenter
On Mon, Jul 10, 2023 at 03:02:05PM +0800, suijingfeng wrote: > Hi, > > > Thanks for testing, > > What do you means about tell me this? > > I means that would you like to help fixing this warning? > > Or otherwise, I will fix this someday. > These are automated emails from the kbuild (zero da

RE: [EXT] Re: [PATCH v6 4/8] phy: Add HDMI configuration options

2023-07-10 Thread Sandor Yu
Hi Dmitry, Thanks for your comments, > -Original Message- > From: Dmitry Baryshkov > Sent: 2023年6月25日 2:02 > To: Sandor Yu ; andrzej.ha...@intel.com; > neil.armstr...@linaro.org; robert.f...@linaro.org; > laurent.pinch...@ideasonboard.com; jo...@kwiboo.se; > jernej.skra...@gmail.com; air

RE: [EXT] Re: [PATCH v6 4/8] phy: Add HDMI configuration options

2023-07-10 Thread Sandor Yu
Hi Vinod, Thanks for your comments, > -Original Message- > From: Vinod Koul > Sent: 2023年6月21日 19:22 > To: Sandor Yu > Cc: andrzej.ha...@intel.com; neil.armstr...@linaro.org; > robert.f...@linaro.org; laurent.pinch...@ideasonboard.com; > jo...@kwiboo.se; jernej.skra...@gmail.com; airl..

RE: [EXT] Re: [PATCH v6 7/8] phy: freescale: Add DisplayPort PHY driver for i.MX8MQ

2023-07-10 Thread Sandor Yu
Hi Vinod, Thanks for your comments, > -Original Message- > From: Vinod Koul > Sent: 2023年6月21日 19:24 > To: Sandor Yu > Cc: andrzej.ha...@intel.com; neil.armstr...@linaro.org; > robert.f...@linaro.org; laurent.pinch...@ideasonboard.com; > jo...@kwiboo.se; jernej.skra...@gmail.com; airl..

RE: [EXT] Re: [PATCH v6 8/8] phy: freescale: Add HDMI PHY driver for i.MX8MQ

2023-07-10 Thread Sandor Yu
Hi Vinod, Thanks for your comments, > -Original Message- > From: Vinod Koul > Sent: 2023年6月21日 19:58 > To: Sandor Yu > Cc: andrzej.ha...@intel.com; neil.armstr...@linaro.org; > robert.f...@linaro.org; laurent.pinch...@ideasonboard.com; > jo...@kwiboo.se; jernej.skra...@gmail.com; airl..

Re: [EXT] Re: [PATCH v6 4/8] phy: Add HDMI configuration options

2023-07-10 Thread Dmitry Baryshkov
On Mon, 10 Jul 2023 at 10:28, Sandor Yu wrote: > > Hi Dmitry, > > Thanks for your comments, > > > -Original Message- > > From: Dmitry Baryshkov > > Sent: 2023年6月25日 2:02 > > To: Sandor Yu ; andrzej.ha...@intel.com; > > neil.armstr...@linaro.org; robert.f...@linaro.org; > > laurent.pinch..

Re: [PATCH v2 3/3] ARM: dts: exynos/i9100: Fix LCD screen's physical size

2023-07-10 Thread Paul Cercueil
Hi Krzysztof, Le lundi 10 juillet 2023 à 08:59 +0200, Krzysztof Kozlowski a écrit : > On 08/07/2023 10:40, Paul Cercueil wrote: > > The previous values were completely bogus, and resulted in the > > computed > > DPI ratio being much lower than reality, causing applications and > > UIs to > > misbe

Re: [drm-misc:drm-misc-next 2/3] drivers/gpu/drm/loongson/lsdc_plane.c:199 lsdc_cursor_plane_atomic_async_check() warn: variable dereferenced before check 'state' (see line 180)

2023-07-10 Thread suijingfeng
er for loongson display controller config: i386-randconfig-m021-20230710 (https://download.01.org/0day-ci/archive/20230710/202307100423.rv7d05uq-...@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230710/202307100423.rv7d05u

Re: [PATCH v4 0/9] MediaTek DisplayPort: support eDP and aux-bus

2023-07-10 Thread AngeloGioacchino Del Regno
Il 07/07/23 10:23, Chen-Yu Tsai ha scritto: On Thu, Jul 6, 2023 at 8:30 PM AngeloGioacchino Del Regno wrote: Changes in v4: - Set data lanes to idle to prevent stalls if bootloader didn't properly close the eDP port - Now using the .done_probing() callback for AUX bus to prevent pr

[PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

2023-07-10 Thread sunran001
Fix nine occurrences of the checkpatch.pl error: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/atom.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c in

Re: [PATCH] fbdev: imxfb: Convert to devm_platform_ioremap_resource()

2023-07-10 Thread Geert Uytterhoeven
Hi Yangtao, On Mon, Jul 10, 2023 at 9:25 AM Yangtao Li wrote: > On 2023/7/10 15:10, Geert Uytterhoeven wrote: > > [你通常不会收到来自 ge...@linux-m68k.org 的电子邮件。请访问 > > https://aka.ms/LearnAboutSenderIdentification,以了解这一点为什么很重要] > > On Tue, Jul 4, 2023 at 11:38 AM Yangtao Li wrote: > >> Use devm_platfor

RE: [EXT] Re: [PATCH v6 4/8] phy: Add HDMI configuration options

2023-07-10 Thread Sandor Yu
> -Original Message- > From: Dmitry Baryshkov > Sent: 2023年7月10日 15:30 > To: Sandor Yu > Cc: andrzej.ha...@intel.com; neil.armstr...@linaro.org; > robert.f...@linaro.org; laurent.pinch...@ideasonboard.com; > jo...@kwiboo.se; jernej.skra...@gmail.com; airl...@gmail.com; > dan...@ffwll.ch

[syzbot] [dri?] KASAN: slab-use-after-free Read in drm_atomic_helper_wait_for_vblanks

2023-07-10 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:03275585cabd afs: Fix accidental truncation when storing d.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=16db258ca8 kernel config: https://syzkaller.appspot.com/x/.config?x=d576750da57ebbb5 das

Re: [EXT] Re: [PATCH v6 4/8] phy: Add HDMI configuration options

2023-07-10 Thread Dmitry Baryshkov
On 10/07/2023 10:28, Sandor Yu wrote: Hi Dmitry, Thanks for your comments, From: Dmitry Baryshkov On 15/06/2023 04:38, Sandor Yu wrote: Allow HDMI PHYs to be configured through the generic functions through a custom structure added to the generic union. The parameters added here are based o

Re: [PATCH v2 3/3] ARM: dts: exynos/i9100: Fix LCD screen's physical size

2023-07-10 Thread Krzysztof Kozlowski
On 10/07/2023 09:35, Paul Cercueil wrote: > Hi Krzysztof, > > Le lundi 10 juillet 2023 à 08:59 +0200, Krzysztof Kozlowski a écrit : >> On 08/07/2023 10:40, Paul Cercueil wrote: >>> The previous values were completely bogus, and resulted in the >>> computed >>> DPI ratio being much lower than reali

Re: [PATCH 1/1] drm/bridge: Fix handling of bridges with pre_enable_prev_first flag

2023-07-10 Thread Frieder Schrempf
On 07.07.23 21:00, Vladimir Lypak wrote: > [Sie erhalten nicht häufig E-Mails von vladimir.ly...@gmail.com. Weitere > Informationen, warum dies wichtig ist, finden Sie unter > https://aka.ms/LearnAboutSenderIdentification ] > > In function drm_atomic_bridge_chain_post_disable handling of > pre_e

[PATCH 00/11] drm: kunit: Switch to kunit actions

2023-07-10 Thread Maxime Ripard
changed, 162 insertions(+), 101 deletions(-) --- base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 change-id: 20230710-kms-kunit-actions-rework-5d163762c93b Best regards, -- Maxime Ripard

[PATCH 01/11] drm/tests: helpers: Switch to kunit actions

2023-07-10 Thread Maxime Ripard
Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_kunit_helpers.c | 32 +++ 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c index 4df47071dc88..38211fea9ae6 1

[PATCH 02/11] drm/tests: client-modeset: Remove call to drm_kunit_helper_free_device()

2023-07-10 Thread Maxime Ripard
Calling drm_kunit_helper_free_device() to clean up the resources allocated by drm_kunit_helper_alloc_device() is now optional and not needed in most cases. Remove it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_client_modeset_test.c | 8 1 file changed, 8 deletions(-) d

[PATCH 03/11] drm/tests: modes: Remove call to drm_kunit_helper_free_device()

2023-07-10 Thread Maxime Ripard
Calling drm_kunit_helper_free_device() to clean up the resources allocated by drm_kunit_helper_alloc_device() is now optional and not needed in most cases. Remove it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_modes_test.c | 8 1 file changed, 8 deletions(-) diff --git

[PATCH 04/11] drm/tests: probe-helper: Remove call to drm_kunit_helper_free_device()

2023-07-10 Thread Maxime Ripard
Calling drm_kunit_helper_free_device() to clean up the resources allocated by drm_kunit_helper_alloc_device() is now optional and not needed in most cases. Remove it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_probe_helper_test.c | 8 1 file changed, 8 deletions(-) dif

[PATCH 05/11] drm/tests: helpers: Create an helper to allocate a locking ctx

2023-07-10 Thread Maxime Ripard
As we get more and more tests, the locking context initialisation creates more and more boilerplate, both at creation and destruction. Let's create a helper that will allocate, initialise a context, and register kunit actions to clean up once the test is done. Signed-off-by: Maxime Ripard --- d

[PATCH 06/11] drm/tests: helpers: Create an helper to allocate an atomic state

2023-07-10 Thread Maxime Ripard
As we gain more tests, boilerplate to allocate an atomic state and free it starts to be there more and more as well. In order to reduce the allocation boilerplate, we can create an helper to create that atomic state, and call an action when the test is done. This will also clean up the exit path.

[PATCH 07/11] drm/vc4: tests: pv-muxing: Remove call to drm_kunit_helper_free_device()

2023-07-10 Thread Maxime Ripard
Calling drm_kunit_helper_free_device() to clean up the resources allocated by drm_kunit_helper_alloc_device() is now optional and not needed in most cases. Remove it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/tests/vc4_test_pv_muxing.c | 4 1 file changed, 4 deletions(-) diff -

[PATCH 08/11] drm/vc4: tests: mock: Use a kunit action to unregister DRM device

2023-07-10 Thread Maxime Ripard
The *_mock_device functions allocate a DRM device that needs to be released using drm_dev_unregister. Now that we have a kunit release action API, we can switch to it and don't require any kind of garbage collection from the caller. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/tests/vc4

[PATCH 10/11] drm/vc4: tests: Switch to atomic state allocation helper

2023-07-10 Thread Maxime Ripard
Now that we have a helper that takes care of an atomic state allocation and cleanup, we can migrate to it to simplify our tests. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/tests/vc4_test_pv_muxing.c | 55 -- 1 file changed, 8 insertions(+), 47 deletions(-) diff

[PATCH 09/11] drm/vc4: tests: pv-muxing: Switch to managed locking init

2023-07-10 Thread Maxime Ripard
The new helper to init the locking context allows to remove some boilerplate. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/tests/vc4_test_pv_muxing.c | 42 -- 1 file changed, 19 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/vc4/tests/vc4_test_pv_mux

[PATCH 11/11] drm/vc4: tests: pv-muxing: Document test scenario

2023-07-10 Thread Maxime Ripard
We've had a couple of tests that weren't really obvious, nor did they document what they were supposed to test. Document that to make it hopefully more obvious. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/tests/vc4_test_pv_muxing.c | 22 ++ 1 file changed, 22 inserti

[PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"

2023-07-10 Thread sunran001
Fix four occurrences of the checkpatch.pl error: ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/radeon_test.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_test.c b/drivers/gpu/drm/radeon/radeon_

Re: [PATCH v2 3/3] ARM: dts: exynos/i9100: Fix LCD screen's physical size

2023-07-10 Thread Paul Cercueil
Le lundi 10 juillet 2023 à 09:45 +0200, Krzysztof Kozlowski a écrit : > On 10/07/2023 09:35, Paul Cercueil wrote: > > Hi Krzysztof, > > > > Le lundi 10 juillet 2023 à 08:59 +0200, Krzysztof Kozlowski a > > écrit : > > > On 08/07/2023 10:40, Paul Cercueil wrote: > > > > The previous values were com

[PATCH] fbdev/hyperv_fb: Include

2023-07-10 Thread Thomas Zimmermann
Include to get the global screen_info state. Fixes the following errors: >> drivers/video/fbdev/hyperv_fb.c:1033:10: error: use of undeclared identifier >> 'screen_info' 1033 | base = screen_info.lfb_base; |^ drivers/video/fbdev/hyperv_fb.c

RE: [EXT] Re: [PATCH v6 4/8] phy: Add HDMI configuration options

2023-07-10 Thread Sandor Yu
> -Original Message- > From: Dmitry Baryshkov > Sent: 2023年7月10日 15:44 > To: Sandor Yu ; andrzej.ha...@intel.com; > neil.armstr...@linaro.org; robert.f...@linaro.org; > laurent.pinch...@ideasonboard.com; jo...@kwiboo.se; > jernej.skra...@gmail.com; airl...@gmail.com; dan...@ffwll.ch; > r

Re: [EXT] Re: [PATCH v6 4/8] phy: Add HDMI configuration options

2023-07-10 Thread Dmitry Baryshkov
On Mon, 10 Jul 2023 at 11:01, Sandor Yu wrote: > > > > > -Original Message- > > From: Dmitry Baryshkov > > Sent: 2023年7月10日 15:44 > > To: Sandor Yu ; andrzej.ha...@intel.com; > > neil.armstr...@linaro.org; robert.f...@linaro.org; > > laurent.pinch...@ideasonboard.com; jo...@kwiboo.se; > >

Re: [PATCH v2 1/2] drm/mediatek: Fix iommu fault by swapping FBs after updating plane state

2023-07-10 Thread AngeloGioacchino Del Regno
Il 09/07/23 18:26, Jason-JH.Lin ha scritto: According to the comment in drm_atomic_helper_async_commit(), we should make sure FBs have been swapped, so that cleanups in the new_state performs a cleanup in the old FB. So we should move swapping FBs after calling mtk_plane_update_new_state(), to a

Re: [PATCH v2 2/2] drm/mediatek: Fix iommu fault during crtc enabling

2023-07-10 Thread AngeloGioacchino Del Regno
Il 09/07/23 18:26, Jason-JH.Lin ha scritto: OVL layer should not be enabled before crtc is enabled. The plane_state of drm_atomic_state is not sync to the plane_state stored in mtk_crtc during crtc enabling, so just set all planes to disabled. Please add the relevant Fixes tag and resend. Tha

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

2023-07-10 Thread Jocelyn Falempe
On 07/07/2023 09:30, Thomas Zimmermann wrote: Hi Am 06.07.23 um 18:37 schrieb Jocelyn Falempe: [...] You could out-comment the VGA code in the ast driver for testing. Oh, Thanks for the idea, I will try that. The result is that I get a black screen on the remote BMC. So maybe adding a re

RE: [EXT] Re: [PATCH v6 4/8] phy: Add HDMI configuration options

2023-07-10 Thread Sandor Yu
> > > On Mon, 10 Jul 2023 at 11:01, Sandor Yu wrote: > > > > > > > > > -Original Message- > > > From: Dmitry Baryshkov > > > Sent: 2023年7月10日 15:44 > > > To: Sandor Yu ; andrzej.ha...@intel.com; > > > neil.armstr...@linaro.org; robert.f...@linaro.org; > > > laurent.pinch...@ideasonboar

Re: [PATCH v2] drm/ast: report connection status on Display Port.

2023-07-10 Thread Jocelyn Falempe
On 06/07/2023 15:03, Linux regression tracking (Thorsten Leemhuis) wrote: On 06.07.23 11:58, Jocelyn Falempe wrote: Aspeed always report the display port as "connected", because it doesn't set a .detect callback. Fix this by providing the proper detect callback for astdp and dp501. This also fi

Re: [PATCH v4 2/8] drm/atomic: Add support for mouse hotspots

2023-07-10 Thread Pekka Paalanen
On Fri, 7 Jul 2023 13:54:21 -0700 Michael Banack wrote: > On 7/7/23 01:38, Pekka Paalanen wrote: ... > >>> The question of which input device corresponds to which cursor plane > >>> might be good to answer too. I presume the VM runner is configured to > >>> expose exactly one of eac

Re: [PATCH v2] drm/ast: report connection status on Display Port.

2023-07-10 Thread Linux regression tracking (Thorsten Leemhuis)
On 10.07.23 10:12, Jocelyn Falempe wrote: > On 06/07/2023 15:03, Linux regression tracking (Thorsten Leemhuis) wrote: >> On 06.07.23 11:58, Jocelyn Falempe wrote: >>> Aspeed always report the display port as "connected", because it >>> doesn't set a .detect callback. >>> Fix this by providing the p

[PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"

2023-07-10 Thread sunran001
Fix four occurrences of the checkpatch.pl error: ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/radeon_atombios.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon

Re: [PATCH v5 6/6] drm/doc: Define KMS atomic state set

2023-07-10 Thread Pekka Paalanen
On Fri, 7 Jul 2023 19:40:59 -0300 André Almeida wrote: > From: Pekka Paalanen > > Specify how the atomic state is maintained between userspace and > kernel, plus the special case for async flips. > > Signed-off-by: Pekka Paalanen > Signed-off-by: André Almeida > --- > v4: total rework by Pe

[PATCH V6 0/9] Enable Wifi RFI interference mitigation feature support

2023-07-10 Thread Evan Quan
Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate possible RFI interference producers can advertise th

[PATCH V6 1/9] drivers core: Add support for Wifi band RF mitigations

2023-07-10 Thread Evan Quan
Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate this, AMD has introduced a mechanism that devices can

[PATCH V6 2/9] driver core: add ACPI based WBRF mechanism introduced by AMD

2023-07-10 Thread Evan Quan
AMD has introduced an ACPI based mechanism to support WBRF for some platforms with AMD dGPU + WLAN. This needs support from BIOS equipped with necessary AML implementations and dGPU firmwares. For those systems without the ACPI mechanism and developing solutions, user can use the generic WBRF solu

[PATCH V6 3/9] cfg80211: expose nl80211_chan_width_to_mhz for wide sharing

2023-07-10 Thread Evan Quan
The newly added WBRF feature needs this interface for channel width calculation. Signed-off-by: Evan Quan --- include/net/cfg80211.h | 8 net/wireless/chan.c| 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h index

[PATCH V6 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-07-10 Thread Evan Quan
To support AMD's WBRF interference mitigation mechanism, Wifi adapters utilized in the system must register the frequencies in use(or unregister those frequencies no longer used) via the dedicated APCI calls. So that, other drivers responding to the frequencies can take proper actions to mitigate p

[PATCH V6 5/9] drm/amd/pm: update driver_if and ppsmc headers for coming wbrf feature

2023-07-10 Thread Evan Quan
Add those data structures to support Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_0.h | 14 +- .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_7.h | 14 +- .../amd/pm/swsmu/inc/pmfw

[PATCH V6 6/9] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-07-10 Thread Evan Quan
With WBRF feature supported, as a driver responding to the frequencies, amdgpu driver is able to do shadow pstate switching to mitigate possible interference(between its (G-)DDR memory clocks and local radio module frequency bands used by Wifi 6/6e/7). Signed-off-by: Evan Quan Reviewed-by: Mario

[PATCH V6 7/9] drm/amd/pm: add flood detection for wbrf events

2023-07-10 Thread Evan Quan
To protect PMFW from being overloaded. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 31 +++ drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 7 + 2 files changed, 32 insertions(+), 6 deletions(-) diff --git a/dr

[PATCH V6 8/9] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0

2023-07-10 Thread Evan Quan
Fulfill the SMU13.0.0 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 3 + drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 3 +- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 3 + .../gpu/d

[PATCH V6 9/9] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.7

2023-07-10 Thread Evan Quan
Fulfill the SMU13.0.7 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 59 +++ 1 file changed, 59 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c

Re: [PATCH] fbdev/hyperv_fb: Include

2023-07-10 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Include to get the global screen_info state. > Fixes the following errors: > >>> drivers/video/fbdev/hyperv_fb.c:1033:10: error: use of undeclared >>> identifier 'screen_info' > 1033 | base = screen_info.lfb_base; > |

Re: [PATCH v2] drm/ast: report connection status on Display Port.

2023-07-10 Thread Jocelyn Falempe
On 10/07/2023 08:57, Thomas Zimmermann wrote: Hi Jocelyn Am 06.07.23 um 11:58 schrieb Jocelyn Falempe: Aspeed always report the display port as "connected", because it doesn't set a .detect callback. Fix this by providing the proper detect callback for astdp and dp501. This also fixes the foll

Re: [PATCH v5] drm/vkms: Add support to 1D gamma LUT

2023-07-10 Thread Pekka Paalanen
On Sat, 8 Jul 2023 22:38:35 -0300 Arthur Grillo wrote: > Support a 1D gamma LUT with interpolation for each color channel on the > VKMS driver. Add a check for the LUT length by creating > vkms_atomic_check(). > > Enable VKMS to run the test igt@kms_plane@pixel-format. > > Tested with: > igt@k

Re: [PATCH 1/5] dt-bindings: display: msm: dp-controller: document SM8250 compatible

2023-07-10 Thread Krzysztof Kozlowski
On 09/07/2023 06:19, Dmitry Baryshkov wrote: > It looks like DP controlled on SM8250 is the same as DP controller on > SM8350. Use the SM8350 compatible as fallback for SM8250. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

[PATCH v2] drm/bridge: anx7625: Drop device lock before drm_helper_hpd_irq_event()

2023-07-10 Thread Chen-Yu Tsai
The device lock is used to serialize the low level power sequencing operations. Since drm_helper_hpd_irq_event() could end up calling .atomic_enable, which also calls power sequencing functions through runtime PM, this results in a real deadlock. This was observed on an MT8192-based Chromebook's ex

[PATCH] drm/radeon: ERROR: that open brace { should be on the previous line

2023-07-10 Thread sunran001
Fix eleven occurrences of the checkpatch.pl error: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/rv770.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/radeon/rv770.c b/dri

Re: [PATCH] drm/nouveau/iccsense:

2023-07-10 Thread Bagas Sanjaya
On Mon, Jul 10, 2023 at 03:06:47PM +0800, sunran...@208suo.com wrote: > Fixed error: 'do not use assignment in if condition' > > This patch fixes error: 'do not use assignment in if condition' > in drm/nouveau/iccsense I guess this is checkpatch fix, right? > > Signed-off-by: Ran Sun > --- >

[PATCH] drm/client: Send hotplug event after registering a client

2023-07-10 Thread Thomas Zimmermann
Generate a hotplug event after registering a client to allow the client to configure its display. Remove the hotplug calls from the existing clients for fbdev emulation. This change fixes a concurrency bug between registering a client and receiving events from the DRM core. The bug is present in th

[PATCH RESEND] drm/bridge: anx7625: Use common macros for DP power sequencing commands

2023-07-10 Thread Chen-Yu Tsai
The DRM DP code has macros for the DP power sequencing commands. Use them in the anx7625 driver instead of raw numbers. Fixes: 548b512e144f ("drm/bridge: anx7625: send DPCD command to downstream") Fixes: 27f26359de9b ("drm/bridge: anx7625: Set downstream sink into normal status") Signed-off-by: C

[PATCH] drm/bridge: anx7625: Use common macros for HDCP capabilities

2023-07-10 Thread Chen-Yu Tsai
The DRM DP code has macros for the DP HDCP capabilities. Use them in the anx7625 driver instead of raw numbers. Fixes: cd1637c7e480 ("drm/bridge: anx7625: add HDCP support") Suggested-by: Nícolas F. R. A. Prado Signed-off-by: Chen-Yu Tsai --- drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++--

Re: [Intel-gfx] [PATCH] drm/i915: Fix one wrong caching mode enum usage

2023-07-10 Thread Tvrtko Ursulin
On 07/07/2023 14:23, Upadhyay, Tejas wrote: -Original Message- From: Intel-gfx On Behalf Of Tvrtko Ursulin Sent: Friday, July 7, 2023 6:25 PM To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: [Intel-gfx] [PATCH] drm/i915: Fix one wrong caching mode enum u

Re: [Intel-gfx] [PATCH] drm/i915: Remove dead code from gen8_pte_encode

2023-07-10 Thread Tvrtko Ursulin
On 07/07/2023 15:17, Rodrigo Vivi wrote: On Fri, Jul 07, 2023 at 01:46:44PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level") added a dedicated gen12_pte_encode but forgot to remove the Gen12 specific bit from gen8_pte_e

Re: [PATCH v2 2/2] drm/mediatek: Fix iommu fault during crtc enabling

2023-07-10 Thread 林睿祥

[PATCH v3 0/2] Fix OVL iommu fault in cursor plane

2023-07-10 Thread Jason-JH . Lin
Fix some IGT tests fail at iommu fault in OVL cursor plane. Jason-JH.Lin (2): drm/mediatek: Fix iommu fault by swapping FBs after updating plane state drm/mediatek: Fix iommu fault during crtc enabling drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +++ drivers/gpu/drm/mediatek/mtk_drm_pla

[PATCH v3 1/2] drm/mediatek: Fix iommu fault by swapping FBs after updating plane state

2023-07-10 Thread Jason-JH . Lin
According to the comment in drm_atomic_helper_async_commit(), we should make sure FBs have been swapped, so that cleanups in the new_state performs a cleanup in the old FB. So we should move swapping FBs after calling mtk_plane_update_new_state(), to avoid using the old FB which could be freed. F

[PATCH v3 2/2] drm/mediatek: Fix iommu fault during crtc enabling

2023-07-10 Thread Jason-JH . Lin
OVL layer should not be enabled before crtc is enabled. The plane_state of drm_atomic_state is not sync to the plane_state stored in mtk_crtc during crtc enabling, so just set all planes to disabled. Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Signed-off-by: Jason

Re: [PATCH] drm/i915: Remove dead code from gen8_pte_encode

2023-07-10 Thread Andi Shyti
Hi Tvrtko, > Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level") > added a dedicated gen12_pte_encode but forgot to remove the Gen12 specific > bit from gen8_pte_encode. > > Signed-off-by: Tvrtko Ursulin > Fixes: 9275277d5324 ("drm/i915: use pat_index instead of cache_level")

Re: [PATCH v3] drm/bridge: tc358767: Use devm_clk_get_enabled() helper

2023-07-10 Thread Robert Foss
On Sat, 8 Jul 2023 08:05:35 +0200, Christophe JAILLET wrote: > The devm_clk_get_enabled() helper: >- calls devm_clk_get() >- calls clk_prepare_enable() and registers what is needed in order to > call clk_disable_unprepare() when needed, as a managed resource. > > This simplifies the c

Re: [PATCH] fbdev: imxfb: Convert to devm_platform_ioremap_resource()

2023-07-10 Thread Helge Deller
On 7/10/23 09:41, Geert Uytterhoeven wrote: Hi Yangtao, On Mon, Jul 10, 2023 at 9:25 AM Yangtao Li wrote: On 2023/7/10 15:10, Geert Uytterhoeven wrote: [你通常不会收到来自 ge...@linux-m68k.org 的电子邮件。请访问 https://aka.ms/LearnAboutSenderIdentification,以了解这一点为什么很重要] On Tue, Jul 4, 2023 at 11:38 AM Yangta

Re: [PATCH] drm/client: Send hotplug event after registering a client

2023-07-10 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Generate a hotplug event after registering a client to allow the > client to configure its display. Remove the hotplug calls from the > existing clients for fbdev emulation. This change fixes a concurrency > bug between registering a client and receiving

Re: [PATCH] drm/client: Send hotplug event after registering a client

2023-07-10 Thread Thomas Zimmermann
Hi Am 10.07.23 um 11:52 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Generate a hotplug event after registering a client to allow the client to configure its display. Remove the hotplug calls from the existing clients for fbdev emulation. This change fixes a conc

[PATCH] drm/nouveau/iccsense: do not use assignment in if condition

2023-07-10 Thread sunran001
checkpatch.pl does not like assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/

[PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"

2023-07-10 Thread sunran001
Fix five occurrences of the checkpatch.pl error: ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/radeon_kms.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeon/radeon

Re: [PATCH v3 2/2] drm/mediatek: Fix iommu fault during crtc enabling

2023-07-10 Thread AngeloGioacchino Del Regno
Il 10/07/23 11:32, Jason-JH.Lin ha scritto: OVL layer should not be enabled before crtc is enabled. The plane_state of drm_atomic_state is not sync to the plane_state stored in mtk_crtc during crtc enabling, so just set all planes to disabled. Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver f

[PATCH] drm/loongson: Fix two warnings because of passing wrong type

2023-07-10 Thread Sui Jingfeng
When accessing I/O memory, we should pass '__iomem *' type instead of 'void *' simply, otherwise sparse tests will complain. After applied this patch, the following two sparse warnings got fixed. 1) drivers/gpu/drm/loongson/lsdc_benchmark.c:27:35: sparse: expected void volatile [noderef] __

[PATCH] drm/loongson: Remove a useless check in cursor_plane_atomic_async_check()

2023-07-10 Thread Sui Jingfeng
Because smatch warnings: drivers/gpu/drm/loongson/lsdc_plane.c:199 lsdc_cursor_plane_atomic_async_check() warn: variable dereferenced before check 'state' (see line 180) vim +/state +199 drivers/gpu/drm/loongson/lsdc_plane.c 174 static int lsdc_cursor_plane_atomic_async_check(struct drm_pl

Re: [PATCH] drm/loongson: Fix two warnings because of passing wrong type

2023-07-10 Thread Jani Nikula
On Mon, 10 Jul 2023, Sui Jingfeng wrote: > When accessing I/O memory, we should pass '__iomem *' type instead of > 'void *' simply, otherwise sparse tests will complain. After applied > this patch, the following two sparse warnings got fixed. Usually the commit message should explain why it's oka

Re: [PATCH RESEND] drm/bridge: anx7625: Use common macros for DP power sequencing commands

2023-07-10 Thread Jani Nikula
On Mon, 10 Jul 2023, Chen-Yu Tsai wrote: > The DRM DP code has macros for the DP power sequencing commands. Use > them in the anx7625 driver instead of raw numbers. > > Fixes: 548b512e144f ("drm/bridge: anx7625: send DPCD command to downstream") > Fixes: 27f26359de9b ("drm/bridge: anx7625: Set dow

Re: [Intel-gfx] [PATCH v3] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-07-10 Thread Andi Shyti
Hi, On Thu, Jun 15, 2023 at 02:15:42PM -0700, Zhanjun Dong wrote: > This attempts to avoid circular locking dependency between flush delayed work > and intel_gt_reset. > Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync > version for reset path, it is safe as the worker

Re: [PATCH] drm/loongson: Fix two warnings because of passing wrong type

2023-07-10 Thread Thomas Zimmermann
Hi Am 10.07.23 um 12:09 schrieb Sui Jingfeng: When accessing I/O memory, we should pass '__iomem *' type instead of 'void *' simply, otherwise sparse tests will complain. After applied this patch, the following two sparse warnings got fixed. 1) drivers/gpu/drm/loongson/lsdc_benchmark.c:27:35:

Re: [PATCH] drm/loongson: Remove a useless check in cursor_plane_atomic_async_check()

2023-07-10 Thread Thomas Zimmermann
Am 10.07.23 um 12:24 schrieb Sui Jingfeng: Because smatch warnings: drivers/gpu/drm/loongson/lsdc_plane.c:199 lsdc_cursor_plane_atomic_async_check() warn: variable dereferenced before check 'state' (see line 180) vim +/state +199 drivers/gpu/drm/loongson/lsdc_plane.c 174 static int ls

  1   2   3   >