Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-29 Thread Pekka Paalanen
On Wed, 28 Jun 2023 09:40:21 -0700 Jessica Zhang wrote: > On 6/28/2023 12:34 AM, Pekka Paalanen wrote: > > On Tue, 27 Jun 2023 15:10:19 -0700 > > Abhinav Kumar wrote: > > > >> On 6/27/2023 2:59 PM, Dmitry Baryshkov wrote: > >>> On 28/06/2023 00:27, Jessica Zhang wrote: > > > >>>

Re: [RFC v2 0/3] Introduce KUnit tests for TTM subsystem

2023-06-29 Thread Christian König
Sorry for the delayed response, AMD had some mail server issues and I simply missed this through the web access interface. Going to take a look at this now, Christian. Am 27.06.23 um 10:32 schrieb Karolina Stolarek: This series introduces KUnit[1] tests for TTM (Translation Table Manager) subs

Re: [RFC v2 0/3] Introduce KUnit tests for TTM subsystem

2023-06-29 Thread Karolina Stolarek
On 29.06.2023 09:39, Christian König wrote: Sorry for the delayed response, AMD had some mail server issues and I simply missed this through the web access interface. No worries, that gave me an opportunity to fix my series :) All the best, Karolina Going to take a look at this now, Christi

Re: [RFC v2 1/3] drm/ttm: Introduce KUnit tests

2023-06-29 Thread Christian König
Am 27.06.23 um 10:32 schrieb Karolina Stolarek: Add the initial version of unit tests for ttm_device struct, together with helper functions. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/Kconfig | 15 + drivers/gpu/drm/ttm/Makefile | 1 + d

Re: [PATCH v4 2/8] drm/atomic: Add support for mouse hotspots

2023-06-29 Thread Pekka Paalanen
On Wed, 28 Jun 2023 19:54:49 + Zack Rusin wrote: > On Wed, 2023-06-28 at 10:54 +0300, Pekka Paalanen wrote: > > On Wed, 28 Jun 2023 10:41:06 +0300 > > Pekka Paalanen wrote: > > > > > On Wed, 28 Jun 2023 01:21:27 -0400 > > > Zack Rusin wrote: > > > > > > > From: Zack Rusin > > > > >

Re: [PATCH v4 2/8] drm/atomic: Add support for mouse hotspots

2023-06-29 Thread Pekka Paalanen
On Wed, 28 Jun 2023 16:26:37 + Zack Rusin wrote: > On Wed, 2023-06-28 at 14:15 +, Simon Ser wrote: > > I think we should drop the CRTC_X/CRTC_Y properties for hotspot-aware cursor > > planes. > > The drivers aren't going to do anything with these, and exposing them to > > user- > > space

Re: [PATCH 6/6] drm/amdgpu: use the new drm_exec object for CS v2

2023-06-29 Thread Tatsuyuki Ishi
On 6/28/23 19:44, Christian König wrote: @@ -958,18 +904,57 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p, e->user_invalidated = userpage_invalidated; } - r = ttm_eu_reserve_buffers(&p->ticket, &p->validated, true, - &d

Re: [PATCH 4/6] drm/amdgpu: use drm_exec for GEM and CSA handling

2023-06-29 Thread Tatsuyuki Ishi
On 6/28/23 19:44, Christian König wrote: diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c index 74055cba3dc9..6811fc866494 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c @@ -728,36 +723,37 @@ int a

Re: [PATCH v2] drm/edid: Add quirk for OSVR HDK 2.0

2023-06-29 Thread Jani Nikula
On Tue, 20 Jun 2023, Ralph Campbell wrote: > The OSVR virtual reality headset HDK 2.0 uses a different EDID > vendor and device identifier than the HDK 1.1 - 1.4 headsets. > Add the HDK 2.0 vendor and device identifier to the quirks table so > that window managers do not try to display the desktop

Re: [PATCH 2/4] regulator: Introduce Qualcomm REFGEN regulator driver

2023-06-29 Thread Konrad Dybcio
On 28.06.2023 21:28, Mark Brown wrote: > On Wed, Jun 28, 2023 at 06:29:46PM +0200, Konrad Dybcio wrote: > >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * Copyright (c) 2017, 2019-2020, The Linux Foundation. All rights reserved. >> + * Copyright (c) 2023, Linaro Limited >> + */ > > Plea

Re: [RFC v2 2/3] drm/ttm/tests: Add tests for ttm_device

2023-06-29 Thread Christian König
Am 27.06.23 um 10:32 schrieb Karolina Stolarek: Test initialization and cleanup of the ttm_device struct, including some error paths. Verify the creation of page pools if use_dma_alloc param is true. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_device_test.c | 159 +++

Re: [RFC v2 3/3] drm/ttm/tests: Add tests for ttm_pool

2023-06-29 Thread Christian König
Am 27.06.23 um 10:32 schrieb Karolina Stolarek: Add KUnit tests that exercise page allocation using page pools and freeing pages, either by returning them to the pool or freeing them. Add a basic test for ttm_pool cleanup. Introduce helpers to create a dummy ttm_buffer_object. Signed-off-by:

Re: [PATCH] drm/arm/komeda: Remove component framework and add a simple encoder

2023-06-29 Thread Liviu Dudau
Hi Faiz, Thanks for the patch and for addressing what was at some moment on my "nice to improve / cleanup" list. Sorry for the delay in responding, I had to revive the bits of an old setup to be able to test this properly, with 2 encoders attached. On Wed, Jun 21, 2023 at 02:11:16PM +0530, Faiz A

[PULL] drm-intel-next-fixes

2023-06-29 Thread Tvrtko Ursulin
Hi Dave, Daniel, A weekly collection of fixes for the drm-next/6.5 merge window. Mostly small display fixups, one for GuC/SLPC and one header file tidy. Regards, Tvrtko drm-intel-next-fixes-2023-06-29: - Allow DC states along with PW2 only for PWB functionality [adlp+] (Imre Deak) - Fix SSC se

Re: [RFC v2 1/3] drm/ttm: Introduce KUnit tests

2023-06-29 Thread Karolina Stolarek
Hi Christian, Thanks a lot for taking a look at my patches. On 29.06.2023 09:50, Christian König wrote: Am 27.06.23 um 10:32 schrieb Karolina Stolarek: Add the initial version of unit tests for ttm_device struct, together with helper functions. Signed-off-by: Karolina Stolarek ---   drivers/

Re: [RFC v2 2/3] drm/ttm/tests: Add tests for ttm_device

2023-06-29 Thread Karolina Stolarek
On 29.06.2023 11:14, Christian König wrote: Am 27.06.23 um 10:32 schrieb Karolina Stolarek: Test initialization and cleanup of the ttm_device struct, including some error paths. Verify the creation of page pools if use_dma_alloc param is true. Signed-off-by: Karolina Stolarek ---   drivers/g

Re: [RFC v2 3/3] drm/ttm/tests: Add tests for ttm_pool

2023-06-29 Thread Karolina Stolarek
On 29.06.2023 11:17, Christian König wrote: Am 27.06.23 um 10:32 schrieb Karolina Stolarek: Add KUnit tests that exercise page allocation using page pools and freeing pages, either by returning them to the pool or freeing them. Add a basic test for ttm_pool cleanup. Introduce helpers to create

Re: [PATCH 2/4] regulator: Introduce Qualcomm REFGEN regulator driver

2023-06-29 Thread Konrad Dybcio
On 29.06.2023 10:43, Konrad Dybcio wrote: > On 28.06.2023 21:28, Mark Brown wrote: >> On Wed, Jun 28, 2023 at 06:29:46PM +0200, Konrad Dybcio wrote: >> >>> +// SPDX-License-Identifier: GPL-2.0-only >>> +/* >>> + * Copyright (c) 2017, 2019-2020, The Linux Foundation. All rights >>> reserved. >>> +

Re: [PATCH v2 01/15] drm/msm/dsi: Drop unused regulators from QCM2290 14nm DSI PHY config

2023-06-29 Thread Dmitry Baryshkov
On 27/06/2023 23:14, Marijn Suijten wrote: The regulator setup was likely copied from other SoCs by mistake. Just like SM6125 the DSI PHY on this platform is not getting power from a regulator but from the MX power domain. Fixes: 572e9fd6d14a ("drm/msm/dsi: Add phy configuration for QCM2290") S

Re: [PATCH v2 05/15] dt-bindings: display/msm: dsi-controller-main: Document SM6125

2023-06-29 Thread Dmitry Baryshkov
On 27/06/2023 23:14, Marijn Suijten wrote: Document general compatibility of the DSI controller on SM6125. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Marijn Suijten --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+) Revi

Re: [PATCH v2 08/15] drm/msm/dpu: Add SM6125 support

2023-06-29 Thread Dmitry Baryshkov
On 27/06/2023 23:14, Marijn Suijten wrote: Add definitions for the display hardware used on the Qualcomm SM6125 platform. Signed-off-by: Marijn Suijten --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_5_4_sm6125.h | 230 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 6

Re: [PATCH v2 09/15] drm/msm/mdss: Add SM6125 support

2023-06-29 Thread Dmitry Baryshkov
On 27/06/2023 23:14, Marijn Suijten wrote: SM6125 has an UBWC 3.0 decoder but only an UBWC 1.0 encoder. Signed-off-by: Marijn Suijten --- drivers/gpu/drm/msm/msm_mdss.c | 8 1 file changed, 8 insertions(+) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v2 10/15] dt-bindings: msm: dsi-phy-14nm: Document SM6125 variant

2023-06-29 Thread Dmitry Baryshkov
On 27/06/2023 23:14, Marijn Suijten wrote: Document availability of the 14nm DSI PHY on SM6125. Note that this compatible uses the SoC-suffix variant, intead of postfixing an arbitrary number without the sm/sdm portion. The PHY is not powered by a vcca regulator like on most SoCs, but by the MX

Re: [PATCH v2 11/15] drm/msm/dsi: Reuse QCM2290 14nm DSI PHY configuration for SM6125

2023-06-29 Thread Dmitry Baryshkov
On 27/06/2023 23:14, Marijn Suijten wrote: SM6125 features only a single PHY (despite a secondary PHY PLL source being available to the disp_cc_mdss_pclk0_clk_src clock), and downstream sources for this "trinket" SoC do not define the typical "vcca" regulator to be available nor used. This, incl

Re: [PATCH v2 12/15] arm64: dts: qcom: sm6125: Switch fixed xo_board clock to RPM XO clock

2023-06-29 Thread Dmitry Baryshkov
On 27/06/2023 23:14, Marijn Suijten wrote: We have a working RPM XO clock; no other driver except rpmcc should be parenting directly to the fixed-factor xo_board clock nor should it be reachable by that global name. Remove the name to that effect, so that every clock relation is explicitly defin

Re: [PATCH v2 13/15] arm64: dts: qcom: sm6125: Add dispcc node

2023-06-29 Thread Dmitry Baryshkov
On 27/06/2023 23:14, Marijn Suijten wrote: Enable and configure the dispcc node on SM6125 for consumption by MDSS later on. Signed-off-by: Marijn Suijten --- arch/arm64/boot/dts/qcom/sm6125.dtsi | 25 + 1 file changed, 25 insertions(+) diff --git a/arch/arm64/boot/dt

Re: [PATCH v2 14/15] arm64: dts: qcom: sm6125: Add display hardware nodes

2023-06-29 Thread Dmitry Baryshkov
On 27/06/2023 23:14, Marijn Suijten wrote: Add the DT nodes that describe the MDSS hardware on SM6125, containing one MDP (display controller) together with a single DSI and DSI PHY. No DisplayPort support is added for now. Signed-off-by: Marijn Suijten --- arch/arm64/boot/dts/qcom/sm6125.dt

[PULL] drm-misc-next-fixes

2023-06-29 Thread Thomas Zimmermann
Hi Dave and Daniel, only one trivial bugfix this week. Best regards Thomas drm-misc-next-fixes-2023-06-29: Short summary of fixes pull: * fbdev: Fix module infos on sparc The following changes since commit cf683e8870bd4be0fd6b98639286700a35088660: fbdev: Use /* */ comment in initializer mac

Re: [RFC] drm/i915: Refactor PAT/cache handling

2023-06-29 Thread Tvrtko Ursulin
On 29/06/2023 06:39, Yang, Fei wrote: > From: Tvrtko Ursulin > > Informal commit message for now. > > I got a bit impatient and curious to see if the idea we discussed would > work so sketched something out. I think it is what I was describing back > then.. Oops, you beat me on this, s

Re: [PATCH v2 12/15] arm64: dts: qcom: sm6125: Switch fixed xo_board clock to RPM XO clock

2023-06-29 Thread Marijn Suijten
On 2023-06-29 13:55:28, Dmitry Baryshkov wrote: > On 27/06/2023 23:14, Marijn Suijten wrote: > > We have a working RPM XO clock; no other driver except rpmcc should be > > parenting directly to the fixed-factor xo_board clock nor should it be > > reachable by that global name. Remove the name to t

Re: [PATCH v2 13/15] arm64: dts: qcom: sm6125: Add dispcc node

2023-06-29 Thread Marijn Suijten
On 2023-06-29 13:56:25, Dmitry Baryshkov wrote: > On 27/06/2023 23:14, Marijn Suijten wrote: > > Enable and configure the dispcc node on SM6125 for consumption by MDSS > > later on. > > > > Signed-off-by: Marijn Suijten > > --- > > arch/arm64/boot/dts/qcom/sm6125.dtsi | 25 +

[PATCH 00/12] arch,fbdev: Move screen_info into arch/

2023-06-29 Thread Thomas Zimmermann
The variables screen_info and edid_info provide information about the system's screen, and possibly EDID data of the connected display. Both are defined and set by architecture code. But both variables are declared in non-arch header files. Dependencies are at bease loosely tracked. To resolve this

[PATCH 01/12] efi: Do not include from EFI header

2023-06-29 Thread Thomas Zimmermann
The header file does not need anything from . Declare struct screen_info and remove the include statements. Update a number of source files that require struct screen_info's definition. Signed-off-by: Thomas Zimmermann Cc: Ard Biesheuvel Cc: Russell King Cc: Catalin Marinas Cc: Will Deacon -

[PATCH 11/12] fbdev/core: Protect edid_info with CONFIG_ARCH_HAS_EDID_INFO

2023-06-29 Thread Thomas Zimmermann
Guard usage of edid_info with CONFIG_ARCH_HAS_EDID_INFO instead of CONFIG_X86. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Daniel Vetter Cc: Helge Deller Cc: Randy Dunlap --- drivers/video/fbdev/core/fbmon.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 07/12] arch/x86: Declare edid_info in

2023-06-29 Thread Thomas Zimmermann
The global variable edid_info contains the firmware's EDID information as an extension to the regular screen_info on x86. Therefore move it to . Add the Kconfig token ARCH_HAS_EDID_INFO to guard against access on architectures that don't provide edid_info. Select it on x86. Signed-off-by: Thomas

[PATCH 03/12] sysfb: Do not include from sysfb header

2023-06-29 Thread Thomas Zimmermann
The header file does not need anything from . Declare struct screen_info and remove the include statements. Signed-off-by: Thomas Zimmermann Cc: Ard Biesheuvel Cc: Hans de Goede Cc: Javier Martinez Canillas --- include/linux/sysfb.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) di

[PATCH 08/12] drivers/firmware: Remove trailing whitespaces

2023-06-29 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/firmware/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index b59e3041fd627..0432737bbb8b4 100644 --- a/drivers/firmware/Kconfig

[PATCH 09/12] drivers: Add dependencies on CONFIG_ARCH_HAS_SCREEN_INFO

2023-06-29 Thread Thomas Zimmermann
Various files within drivers/ depend on the declaration of the screen_info variable. Add this information to Kconfig. In the case of the dummy console, the dependency exists only on ARM. Ignore it on !ARM platforms. Signed-off-by: Thomas Zimmermann Cc: Ard Biesheuvel Cc: Maarten Lankhorst Cc:

[PATCH 05/12] arch: Remove trailing whitespaces

2023-06-29 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Yoshinori Sato Cc: Rich Felker Cc: John Paul Adrian Glaubitz Cc: Andrew Morton Cc: Geert Uytterhoeven Cc: Arnd Bergmann Cc: "Kirill A. Shutemov" Cc: Anshuman Khandual Cc: Niklas Schnelle Cc: Zi Yan Cc: "Mike R

[PATCH 04/12] staging/sm750fb: Do not include

2023-06-29 Thread Thomas Zimmermann
The sm750fb driver does not need anything from . Remove the include statements. Signed-off-by: Thomas Zimmermann Cc: Sudip Mukherjee Cc: Teddy Wang --- drivers/staging/sm750fb/sm750.c| 1 - drivers/staging/sm750fb/sm750_accel.c | 1 - drivers/staging/sm750fb/sm750_cursor.c | 1 - driv

[PATCH 02/12] fbdev/sm712fb: Do not include

2023-06-29 Thread Thomas Zimmermann
Sm712fb's dependency on is artificial in that it only uses struct screen_info for its internals. Replace the use of struct screen_info with a custom data structure and remove the include of . Signed-off-by: Thomas Zimmermann Cc: Sudip Mukherjee Cc: Teddy Wang Cc: Helge Deller --- drivers/vid

[PATCH 06/12] arch: Declare screen_info in

2023-06-29 Thread Thomas Zimmermann
The variable screen_info does not exist on all architectures. Declare it in . All architectures that do declare it will provide it via . Add the Kconfig token ARCH_HAS_SCREEN_INFO to guard against access on architectures that don't provide screen_info. Signed-off-by: Thomas Zimmermann Cc: Richar

[PATCH 12/12] fbdev/core: Define empty fb_firmware_edid() in

2023-06-29 Thread Thomas Zimmermann
Move the empty declaration of fb_firmware_edid() to . Follow common style and avoid the overhead of exporting the symbol. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Daniel Vetter Cc: Helge Deller Cc: Randy Dunlap --- drivers/video/fbdev/core/fbmon.c | 7 +-- include/linu

[PATCH 10/12] fbdev/core: Use fb_is_primary_device() in fb_firmware_edid()

2023-06-29 Thread Thomas Zimmermann
Detect the primary VGA device with fb_is_primary_device() in the implementation of fb_firmware_edid(). Remove the existing code. Adapt the function to receive an instance of struct fb_info and update all callers. Signed-off-by: Thomas Zimmermann Cc: Daniel Vetter Cc: Helge Deller Cc: Antonino

Re: [PATCH v2 13/15] arm64: dts: qcom: sm6125: Add dispcc node

2023-06-29 Thread Dmitry Baryshkov
On Thu, 29 Jun 2023 at 15:14, Marijn Suijten wrote: > > On 2023-06-29 13:56:25, Dmitry Baryshkov wrote: > > On 27/06/2023 23:14, Marijn Suijten wrote: > > > Enable and configure the dispcc node on SM6125 for consumption by MDSS > > > later on. > > > > > > Signed-off-by: Marijn Suijten > > > --- >

Re: [PATCH v2 12/15] arm64: dts: qcom: sm6125: Switch fixed xo_board clock to RPM XO clock

2023-06-29 Thread Dmitry Baryshkov
On Thu, 29 Jun 2023 at 15:09, Marijn Suijten wrote: > > On 2023-06-29 13:55:28, Dmitry Baryshkov wrote: > > On 27/06/2023 23:14, Marijn Suijten wrote: > > > We have a working RPM XO clock; no other driver except rpmcc should be > > > parenting directly to the fixed-factor xo_board clock nor should

Re: [PATCH 07/12] arch/x86: Declare edid_info in

2023-06-29 Thread Arnd Bergmann
On Thu, Jun 29, 2023, at 13:45, Thomas Zimmermann wrote: > The global variable edid_info contains the firmware's EDID information > as an extension to the regular screen_info on x86. Therefore move it to > . > > Add the Kconfig token ARCH_HAS_EDID_INFO to guard against access on > architectures tha

Re: [PATCH 07/12] arch/x86: Declare edid_info in

2023-06-29 Thread Thomas Zimmermann
Hi Am 29.06.23 um 14:35 schrieb Arnd Bergmann: On Thu, Jun 29, 2023, at 13:45, Thomas Zimmermann wrote: The global variable edid_info contains the firmware's EDID information as an extension to the regular screen_info on x86. Therefore move it to . Add the Kconfig token ARCH_HAS_EDID_INFO to g

Re: [PATCH 06/12] arch: Declare screen_info in

2023-06-29 Thread Arnd Bergmann
On Thu, Jun 29, 2023, at 13:45, Thomas Zimmermann wrote: > diff --git a/include/asm-generic/screen_info.h > b/include/asm-generic/screen_info.h > new file mode 100644 > index 0..6fd0e50fabfcd > --- /dev/null > +++ b/include/asm-generic/screen_info.h > @@ -0,0 +1,12 @@ > +/* SPDX-Licen

Re: [PATCH 06/12] arch: Declare screen_info in

2023-06-29 Thread WANG Xuerui
On 2023/6/29 19:45, Thomas Zimmermann wrote: The variable screen_info does not exist on all architectures. Declare it in . All architectures that do declare it will provide it via . Add the Kconfig token ARCH_HAS_SCREEN_INFO to guard against access on architectures that don't provide screen_info

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-29 Thread André Almeida
Em 27/06/2023 18:17, André Almeida escreveu: Em 27/06/2023 14:47, Christian König escreveu: Am 27.06.23 um 15:23 schrieb André Almeida: Create a section that specifies how to deal with DRM device resets for kernel and userspace drivers. Acked-by: Pekka Paalanen Signed-off-by: André Almeida

Re: [PATCH 06/12] arch: Declare screen_info in

2023-06-29 Thread Thomas Zimmermann
Hi Am 29.06.23 um 15:03 schrieb Arnd Bergmann: On Thu, Jun 29, 2023, at 13:45, Thomas Zimmermann wrote: diff --git a/include/asm-generic/screen_info.h b/include/asm-generic/screen_info.h new file mode 100644 index 0..6fd0e50fabfcd --- /dev/null +++ b/include/asm-generic/screen_info

Re: [PATCH 07/12] arch/x86: Declare edid_info in

2023-06-29 Thread Arnd Bergmann
On Thu, Jun 29, 2023, at 15:01, Thomas Zimmermann wrote: > Am 29.06.23 um 14:35 schrieb Arnd Bergmann: >> On Thu, Jun 29, 2023, at 13:45, Thomas Zimmermann wrote: >>> The global variable edid_info contains the firmware's EDID information >>> as an extension to the regular screen_info on x86. Theref

Re: [PATCH 00/12] arch,fbdev: Move screen_info into arch/

2023-06-29 Thread Arnd Bergmann
On Thu, Jun 29, 2023, at 13:45, Thomas Zimmermann wrote: > The variables screen_info and edid_info provide information about > the system's screen, and possibly EDID data of the connected display. > Both are defined and set by architecture code. But both variables are > declared in non-arch header

Re: [PATCH 6/6] drm/amdgpu: use the new drm_exec object for CS v2

2023-06-29 Thread Christian König
Am 29.06.23 um 10:20 schrieb Tatsuyuki Ishi: On 6/28/23 19:44, Christian König wrote: @@ -958,18 +904,57 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,   e->user_invalidated = userpage_invalidated;   }   -    r = ttm_eu_reserve_buffers(&p->ticket, &p->validated, t

Re: [PATCH 00/12] arch,fbdev: Move screen_info into arch/

2023-06-29 Thread Thomas Zimmermann
Hi Am 29.06.23 um 15:31 schrieb Arnd Bergmann: On Thu, Jun 29, 2023, at 13:45, Thomas Zimmermann wrote: The variables screen_info and edid_info provide information about the system's screen, and possibly EDID data of the connected display. Both are defined and set by architecture code. But both

[PATCH v2] drm/i915: Refactor PAT/cache handling

2023-06-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Informal commit message for now. I got a bit impatient and curious to see if the idea we discussed would work so sketched something out. I think it is what I was describing back then.. So high level idea is to teach the driver what caching modes are hidden behind PAT indice

Re: Why does kgd2kfd_interrupt() have to schedule work on a specific CPU?

2023-06-29 Thread Philip Yang
This was to fix application long event wait latency, when app shader generates lots of event interrupts in short period, the scheduled work no chance to execute on the same CPU core, this causes event cannot post/return to app thread which are waiting the event. To s

Re: [PATCH 00/12] arch,fbdev: Move screen_info into arch/

2023-06-29 Thread Arnd Bergmann
On Thu, Jun 29, 2023, at 15:31, Arnd Bergmann wrote: > On Thu, Jun 29, 2023, at 13:45, Thomas Zimmermann wrote: >> >> Future directions: with the patchset in place, it will become possible >> to provide screen_info and edid_info only if there are users. Some >> architectures do this by testing for

Re: [PATCH v7 6/8] PCI/VGA: Introduce is_boot_device function callback to vga_client_register

2023-06-29 Thread Sui Jingfeng
Hi, Humble ping ! Please share some bandwidth to help reviewing this series, OK ? As this series is useful for all architecture, I have tested on my X86, mips and LoongArch computer. Questions and comments is also welcome. If no one response within three days, I'm going to send a update

Re: [PATCH 00/12] arch,fbdev: Move screen_info into arch/

2023-06-29 Thread Arnd Bergmann
On Thu, Jun 29, 2023, at 16:15, Thomas Zimmermann wrote: > Am 29.06.23 um 15:31 schrieb Arnd Bergmann: >> On Thu, Jun 29, 2023, at 13:45, Thomas Zimmermann wrote: >>> Future directions: with the patchset in place, it will become possible >>> to provide screen_info and edid_info only if there are us

RE: [PATCH v2 0/3] Checksum Region with new CRTC properties

2023-06-29 Thread Liu, HaoPing (Alan)
[AMD Official Use Only - General] Dear DRM development community, I also developed an IGT for testing this checksum_region feature. Please check it at: https://patchwork.freedesktop.org/series/120017/ Thank you and welcome any feedback. Best Regards, Alan -Original Message- From: Alan L

Re: [PATCH v2 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-29 Thread Rob Herring
On Tue, 27 Jun 2023 22:14:18 +0200, Marijn Suijten wrote: > The "gcc_disp_gpll0_div_clk_src" clock is consumed by the driver, will > be passed from DT, and should be required by the bindings. > > Fixes: 8397c9c0c26b ("dt-bindings: clock: add QCOM SM6125 display clock > bindings") > Signed-off-b

Re: [PATCH v7 6/8] PCI/VGA: Introduce is_boot_device function callback to vga_client_register

2023-06-29 Thread Bjorn Helgaas
On Thu, Jun 22, 2023 at 01:08:15PM +0800, Sui Jingfeng wrote: > Hi, > > > A nouveau developer(Lyude) from redhat send me a R-B, > > Thanks for the developers of nouveau project. > > > Please allow me add a link[1] here. > > > [1] > https://lore.kernel.org/all/0afadc69f99a36bc9d03ecf54ff2585

Re: [PATCH v2 06/15] dt-bindings: display/msm: sc7180-dpu: Describe SM6125

2023-06-29 Thread Rob Herring
On Tue, 27 Jun 2023 22:14:21 +0200, Marijn Suijten wrote: > SM6125 is identical to SM6375 except that while downstream also defines > a throttle clock, its presence results in timeouts whereas SM6375 > requires it to not observe any timeouts. This is represented by > reducing the clock array len

Re: [PATCH 1/4] dt-bindings: regulator: Describe Qualcomm REFGEN regulator

2023-06-29 Thread Rob Herring
On Wed, Jun 28, 2023 at 06:29:45PM +0200, Konrad Dybcio wrote: > Modern Qualcomm SoCs have a REFGEN (reference voltage generator) > regulator, providing reference voltage to on-chip IP, like PHYs. > It's controlled through MMIO and we can toggle it or read its state back. > > Describe it. > > Sig

Re: [PATCH 3/4] dt-bindings: display/msm: dsi-controller-main: Allow refgen-supply

2023-06-29 Thread Rob Herring
On Wed, 28 Jun 2023 18:29:47 +0200, Konrad Dybcio wrote: > DSI host needs REFGEN to be enabled (if it's present on a given platform). > Allow consuming it. > > Signed-off-by: Konrad Dybcio > --- > .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 4 > > 1 file chang

Re: [PATCH v3] drm/xe/guc: Fix h2g_write usage of GUC_CTB_MSG_MAX_LEN

2023-06-29 Thread Teres Alexis, Alan Previn
On Wed, 2023-06-28 at 21:44 +, Brost, Matthew wrote: > On Wed, Jun 28, 2023 at 11:17:18AM -0700, Alan Previn wrote: > > In the ABI header, GUC_CTB_MSG_MIN_LEN is '1' because > > GUC_CTB_HDR_LEN is 1. This aligns with H2G/G2H CTB specification > > where all command formats are defined in units o

Re: [PATCH v7 6/8] PCI/VGA: Introduce is_boot_device function callback to vga_client_register

2023-06-29 Thread Sui Jingfeng
Hi, On 2023/6/29 23:54, Bjorn Helgaas wrote: On Thu, Jun 22, 2023 at 01:08:15PM +0800, Sui Jingfeng wrote: Hi, A nouveau developer(Lyude) from redhat send me a R-B, Thanks for the developers of nouveau project. Please allow me add a link[1] here. [1] https://lore.kernel.org/all/0afadc69

[PATCH] drm/i915/quirk: Add quirk for devices that cannot be dimmed

2023-06-29 Thread Allen Ballway
Cybernet T10C cannot be dimmed without the backlight strobing. Create a new quirk to lock the minimum brightness to the highest supported value. This aligns the device with its behavior on Windows, which will not lower the brightness below maximum. Signed-off-by: Allen Ballway --- V2 -> V3: Fix t

Re: [Freedreno] [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-29 Thread Abhinav Kumar
On 6/22/2023 4:37 PM, Abhinav Kumar wrote: On 6/22/2023 4:14 PM, Dmitry Baryshkov wrote: On 23/06/2023 01:37, Abhinav Kumar wrote: On 6/21/2023 4:46 PM, Dmitry Baryshkov wrote: On 22/06/2023 02:01, Abhinav Kumar wrote: On 6/21/2023 9:36 AM, Dmitry Baryshkov wrote: On 21/06/2023 18:1

Re: [GIT PULL] fbdev fixes for v6.5-rc1

2023-06-29 Thread pr-tracker-bot
The pull request you sent on Tue, 27 Jun 2023 08:17:50 +0200: > http://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git > tags/fbdev-for-6.5-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/675285ad819293844018aa8096ba9a6d7c77b90b Thank you! -- Deet

Re: [Freedreno] [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-29 Thread Jessica Zhang
On 6/29/2023 10:26 AM, Abhinav Kumar wrote: On 6/22/2023 4:37 PM, Abhinav Kumar wrote: On 6/22/2023 4:14 PM, Dmitry Baryshkov wrote: On 23/06/2023 01:37, Abhinav Kumar wrote: On 6/21/2023 4:46 PM, Dmitry Baryshkov wrote: On 22/06/2023 02:01, Abhinav Kumar wrote: On 6/21/2023 9:36

RE: [PATCH v7 6/8] PCI/VGA: Introduce is_boot_device function callback to vga_client_register

2023-06-29 Thread Limonciello, Mario
[Public] > -Original Message- > From: 15330273...@189.cn <15330273...@189.cn> > Sent: Thursday, June 29, 2023 12:00 PM > To: Bjorn Helgaas ; Sui Jingfeng > > Cc: Bjorn Helgaas ; linux-fb...@vger.kernel.org; > Cornelia Huck ; Karol Herbst ; > nouv...@lists.freedesktop.org; Joonas Lahtinen

Re: [git pull] drm for 6.5-rc1

2023-06-29 Thread pr-tracker-bot
The pull request you sent on Thu, 29 Jun 2023 11:28:02 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2023-06-29 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/1b722407a13b7f8658d2e26917791f32805980a2 Thank you! -- Deet-doot-dot, I am a bot. https://ko

Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-29 Thread Jessica Zhang
On 6/27/2023 3:10 PM, Abhinav Kumar wrote: On 6/27/2023 2:59 PM, Dmitry Baryshkov wrote: On 28/06/2023 00:27, Jessica Zhang wrote: On 6/27/2023 12:58 AM, Pekka Paalanen wrote: On Mon, 26 Jun 2023 16:02:50 -0700 Jessica Zhang wrote: On 11/7/2022 11:37 AM, Ville Syrjälä wrote: On Fri,

Re: [Freedreno] [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-29 Thread Jessica Zhang
On 6/29/2023 12:29 AM, Pekka Paalanen wrote: On Wed, 28 Jun 2023 09:40:21 -0700 Jessica Zhang wrote: On 6/28/2023 12:34 AM, Pekka Paalanen wrote: On Tue, 27 Jun 2023 15:10:19 -0700 Abhinav Kumar wrote: On 6/27/2023 2:59 PM, Dmitry Baryshkov wrote: On 28/06/2023 00:27, Jessica Zhang

[PATCH AUTOSEL 6.3 12/17] drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2

2023-06-29 Thread Sasha Levin
From: Jeff Layton [ Upstream commit 54d217406afe250d7a768783baaa79a035f21d38 ] I've been experiencing some intermittent crashes down in the display driver code. The symptoms are ususally a line like this in dmesg: amdgpu :30:00.0: [drm] Failed to create MST payload for port 6d3

[PATCH AUTOSEL 6.1 09/12] drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2

2023-06-29 Thread Sasha Levin
From: Jeff Layton [ Upstream commit 54d217406afe250d7a768783baaa79a035f21d38 ] I've been experiencing some intermittent crashes down in the display driver code. The symptoms are ususally a line like this in dmesg: amdgpu :30:00.0: [drm] Failed to create MST payload for port 6d3

Re: [PATCH v2 12/15] arm64: dts: qcom: sm6125: Switch fixed xo_board clock to RPM XO clock

2023-06-29 Thread Konrad Dybcio
On 29.06.2023 14:26, Dmitry Baryshkov wrote: > On Thu, 29 Jun 2023 at 15:09, Marijn Suijten > wrote: >> >> On 2023-06-29 13:55:28, Dmitry Baryshkov wrote: >>> On 27/06/2023 23:14, Marijn Suijten wrote: We have a working RPM XO clock; no other driver except rpmcc should be parenting direc

[PATCH v2 2/3] drm/msm/dpu: use dpu core's major version to enable data compress

2023-06-29 Thread Abhinav Kumar
Instead of using a feature bit to decide whether to enable data compress or not for DSC use-cases, use dpu core's major version instead. This will avoid defining feature bits for every bit level details of registers. Also, rename the intf's enable_compression() op to program_datapath() and allow i

[PATCH v2 3/3] drm/msm/dpu: drop DPU_INTF_DATA_COMPRESS from dpu catalog

2023-06-29 Thread Abhinav Kumar
Now that all usages of DPU_INTF_DATA_COMPRESS have been replaced with the dpu core's major revision lets drop DPU_INTF_DATA_COMPRESS from the catalog completely. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h

[PATCH v2 1/3] drm/msm/dpu: re-introduce dpu core revision to the catalog

2023-06-29 Thread Abhinav Kumar
With [1] dpu core revision was dropped in favor of using the compatible string from the device tree to select the dpu catalog being used in the device. This approach works well however also necessitates adding catalog entries for small register level details as dpu capabilities and/or features blo

[PATCH v3 2/3] drm/msm/dpu: use dpu core's major version to enable data compress

2023-06-29 Thread Abhinav Kumar
Instead of using a feature bit to decide whether to enable data compress or not for DSC use-cases, use dpu core's major version instead. This will avoid defining feature bits for every bit level details of registers. Also, rename the intf's enable_compression() op to program_datapath() and allow i

[PATCH v3 1/3] drm/msm/dpu: re-introduce dpu core revision to the catalog

2023-06-29 Thread Abhinav Kumar
With [1] dpu core revision was dropped in favor of using the compatible string from the device tree to select the dpu catalog being used in the device. This approach works well however also necessitates adding catalog entries for small register level details as dpu capabilities and/or features blo

[PATCH v3 3/3] drm/msm/dpu: drop DPU_INTF_DATA_COMPRESS from dpu catalog

2023-06-29 Thread Abhinav Kumar
Now that all usages of DPU_INTF_DATA_COMPRESS have been replaced with the dpu core's major revision lets drop DPU_INTF_DATA_COMPRESS from the catalog completely. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h

Re: [PATCH v2 13/15] arm64: dts: qcom: sm6125: Add dispcc node

2023-06-29 Thread Konrad Dybcio
On 29.06.2023 14:24, Dmitry Baryshkov wrote: > On Thu, 29 Jun 2023 at 15:14, Marijn Suijten > wrote: >> >> On 2023-06-29 13:56:25, Dmitry Baryshkov wrote: >>> On 27/06/2023 23:14, Marijn Suijten wrote: Enable and configure the dispcc node on SM6125 for consumption by MDSS later on.

[PATCH v2 0/4] Qualcomm REFGEN regulator

2023-06-29 Thread Konrad Dybcio
Recent Qualcomm SoCs have a REFGEN (reference voltage generator) regulator responsible for providing a reference voltage to some on-SoC IPs (like DSI or PHYs). It can be turned off when unused to save power. This series introduces the driver for it and lets the DSI driver consume it. Signed-off-b

[PATCH v2 1/4] dt-bindings: regulator: Describe Qualcomm REFGEN regulator

2023-06-29 Thread Konrad Dybcio
Modern Qualcomm SoCs have a REFGEN (reference voltage generator) regulator, providing reference voltage to on-chip IP, like PHYs. It's controlled through MMIO and we can toggle it or read its state back. Describe it. Signed-off-by: Konrad Dybcio --- .../regulator/qcom,sdm845-refgen-regulator.ya

[PATCH v2 3/4] dt-bindings: display/msm: dsi-controller-main: Allow refgen-supply

2023-06-29 Thread Konrad Dybcio
DSI host needs REFGEN to be enabled (if it's present on a given platform). Allow consuming it. Acked-by: Rob Herring Signed-off-by: Konrad Dybcio --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devi

[PATCH v2 4/4] drm/msm/dsi: Hook up refgen regulator

2023-06-29 Thread Konrad Dybcio
Consume the refgen supply on configurations that may use it. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c index 8a5fb6df7210..1f98ff74ceb0 100644 ---

[PATCH v2 2/4] regulator: Introduce Qualcomm REFGEN regulator driver

2023-06-29 Thread Konrad Dybcio
Modern Qualcomm SoCs have a REFGEN (reference voltage generator) regulator, providing reference voltage to on-chip IP, like PHYs. Add a driver to support toggling that regulator. Signed-off-by: Konrad Dybcio --- drivers/regulator/Kconfig | 10 ++ drivers/regulator/Makefile

[PATCH v3] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-06-29 Thread Alan Previn
On MTL, if the GSC Proxy init flows haven't completed, submissions to the GSC engine will fail. Those init flows are dependent on the mei's gsc_proxy component that is loaded in parallel with i915 and a worker that could potentially start after i915 driver init is done. That said, all subsytems th

Re: [PATCH v2 2/4] regulator: Introduce Qualcomm REFGEN regulator driver

2023-06-29 Thread Konrad Dybcio
On 29.06.2023 22:35, Konrad Dybcio wrote: > Modern Qualcomm SoCs have a REFGEN (reference voltage generator) > regulator, providing reference voltage to on-chip IP, like PHYs. > > Add a driver to support toggling that regulator. > > Signed-off-by: Konrad Dybcio > --- Ugh. Missed the 'const' here

[PATCH v3] drm/xe/guc: Fix h2g_write usage of GUC_CTB_MSG_MAX_LEN

2023-06-29 Thread Alan Previn
In the ABI header, GUC_CTB_MSG_MIN_LEN is '1' because GUC_CTB_HDR_LEN is 1. This aligns with H2G/G2H CTB specification where all command formats are defined in units of dwords so that '1' is a dword. Accordingly, GUC_CTB_MSG_MAX_LEN is 256-1 (i.e. 255 dwords). However, h2g_write was incorrectly ass

ttm_bo and multiple backing store segments

2023-06-29 Thread Welty, Brian
Hi Christian / Thomas, Wanted to ask if you have explored or thought about adding support in TTM such that a ttm_bo could have more than one underlying backing store segment (that is, to have a tree of ttm_resources)? We are considering to support such BOs for Intel Xe driver. Some of the b

Re: [Intel-gfx] [PATCH v3] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-06-29 Thread Tvrtko Ursulin
On 29/06/2023 21:42, Alan Previn wrote: On MTL, if the GSC Proxy init flows haven't completed, submissions to the GSC engine will fail. Those init flows are dependent on the mei's gsc_proxy component that is loaded in parallel with i915 and a worker that could potentially start after i915 drive

[PATCH drm-next v6 00/13] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI

2023-06-29 Thread Danilo Krummrich
This patch series provides a new UAPI for the Nouveau driver in order to support Vulkan features, such as sparse bindings and sparse residency. Furthermore, with the DRM GPUVA manager it provides a new DRM core feature to keep track of GPU virtual address (VA) mappings in a more generic way. The

[PATCH drm-next v6 01/13] drm: execution context for GEM buffers v5

2023-06-29 Thread Danilo Krummrich
From: Christian König This adds the infrastructure for an execution context for GEM buffers which is similar to the existing TTMs execbuf util and intended to replace it in the long term. The basic functionality is that we abstracts the necessary loop to lock many different GEM buffers with auto

[PATCH drm-next v6 02/13] drm: manager to keep track of GPUs VA mappings

2023-06-29 Thread Danilo Krummrich
Add infrastructure to keep track of GPU virtual address (VA) mappings with a decicated VA space manager implementation. New UAPIs, motivated by Vulkan sparse memory bindings graphics drivers start implementing, allow userspace applications to request multiple and arbitrary GPU VA mappings of buffe

  1   2   >