next: clang: x86_64: /intel_display.c:6012:3: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]

2023-05-24 Thread Naresh Kamboju
Linux next-20230523 and next-20230524 the x86_64 and i386 builds failed with clang. Reported-by: Linux Kernel Functional Testing make --silent --keep-going \ --jobs=8 O=/home/tuxbuild/.cache/tuxmake/builds/1/build ARCH=x86_64 \ SRCARCH=x86 CROSS_COMPILE=x86_64-linux-gnu- \ 'HOSTCC=sc

Re: [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-24 Thread Conor Dooley
On Wed, May 24, 2023 at 07:51:07AM +0100, Conor Dooley wrote: > Hey Justin, > On Tue, May 23, 2023 at 04:27:12PM -0700, Justin Chen wrote: > > On Tue, May 23, 2023 at 3:55 PM Conor Dooley wrote: > > > On Tue, May 23, 2023 at 02:53:43PM -0700, Justin Chen wrote: > > > > > > > + compatible: > > > >

[v2 0/4] Support Starry-himax83102-j02 and Starry-ili9882t TDDI MIPI-DSI panel

2023-05-24 Thread Cong Yang
Compare V1:Add compatible for Starry himax83102-j02 and Starry-ili9882t in dt-bindings. Cong Yang (4): drm/panel: Support for Starry-himax83102-j02 TDDI MIPI-DSI panel dt-bindings: display: panel: Add compatible for Starry himax83102-j02 drm/panel: Support for Starry-ili9882t TDDI MIPI-DSI p

[v2 1/4] drm/panel: Support for Starry-himax83102-j02 TDDI MIPI-DSI panel

2023-05-24 Thread Cong Yang
The Starry-himax83102-j02 is a 10.51" WUXGA TFT panel. which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. From the datasheet[1], MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high, so increase lp11_before_reset flag. [1]: https://github.com/HimaxSoftware/D

[v2 2/4] dt-bindings: display: panel: Add compatible for Starry himax83102-j02

2023-05-24 Thread Cong Yang
The STARRY himax83102-j02 is a 10.51" WUXGA TFT LCD panel, which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. Hence, we add a new compatible with panel specific config. Signed-off-by: Cong Yang --- .../devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml | 2 ++ 1 file

[v2 3/4] drm/panel: Support for Starry-ili9882t TDDI MIPI-DSI panel

2023-05-24 Thread Cong Yang
The Starry-ili9882 is a 10.51" WUXGA TFT panel. which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. From the datasheet,MIPI need to keep the LP11 state before the lcm_reset pin is pulled high. So add lp11_before_reset flag. Signed-off-by: Cong Yang --- .../gpu/drm/panel/panel-b

[v2 4/4] dt-bindings: display: panel: Add compatible for Starry ili9882t

2023-05-24 Thread Cong Yang
The STARRY ili9882t is a 10.51" WUXGA TFT LCD panel, which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. Hence, we add a new compatible with panel specific config. Signed-off-by: Cong Yang --- .../devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml | 2 ++ 1 file change

[PATCH 0/5] accel/ivpu: Add debugfs support

2023-05-24 Thread Stanislaw Gruszka
Add debugfs support for ivpu driver, most importantly firmware loging and tracing. Andrzej Kacprowski (1): accel/ivpu: Print firmware name and version Krystian Pradzynski (1): accel/ivpu: Add fw_name file to debugfs Stanislaw Gruszka (3): accel/ivpu: Initial debugfs support accel/ivpu: A

[PATCH 1/5] accel/ivpu: Initial debugfs support

2023-05-24 Thread Stanislaw Gruszka
Add initial debugfs support. Provide below functionality: - print buffer objects - print latest boot mode - trigger vpu engine reset Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/Makefile | 1 + drivers/accel/ivpu/ivpu_debugfs.c | 74 +++ drivers/acc

[PATCH 2/5] accel/ivpu: Add firmware tracing support

2023-05-24 Thread Stanislaw Gruszka
Add support for firmware tracing and logging via debugfs. Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/Makefile | 3 +- drivers/accel/ivpu/ivpu_debugfs.c | 169 ++ drivers/accel/ivpu/ivpu_fw.c | 52 - drivers/accel/ivpu/ivpu_fw.h

[PATCH 3/5] accel/ivpu: Add debugfs files for testing device reset

2023-05-24 Thread Stanislaw Gruszka
Add new debugfs files to validate device recovery functionality. Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_debugfs.c | 41 +++ drivers/accel/ivpu/ivpu_pm.c | 1 + drivers/accel/ivpu/ivpu_pm.h | 1 + 3 files changed, 43 insertions(+) dif

[PATCH 4/5] accel/ivpu: Print firmware name and version

2023-05-24 Thread Stanislaw Gruszka
From: Andrzej Kacprowski Firmware file name and version are very important for debugging customer issues - print them as INFO level message instead of DEBUG message that is turned off by default. Signed-off-by: Andrzej Kacprowski Reviewed-by: Stanislaw Gruszka Signed-off-by: Stanislaw Gruszka

[PATCH 5/5] accel/ivpu: Add fw_name file to debugfs

2023-05-24 Thread Stanislaw Gruszka
From: Krystian Pradzynski Add information about currently used firmware, makes test automation of different firmware images easier. Signed-off-by: Krystian Pradzynski Reviewed-by: Stanislaw Gruszka Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_debugfs.c | 10 ++ 1 file

Re: [PATCH 0/5] accel/ivpu: Add debugfs support

2023-05-24 Thread Oded Gabbay
On Wed, May 24, 2023 at 10:49 AM Stanislaw Gruszka wrote: > > Add debugfs support for ivpu driver, most importantly firmware loging > and tracing. Hi, Without looking at the code I have 2 comments/questions: 1. Please add an ABI documentation in Documentation/ABI/testing/ or Documentation/ABI/sta

Re: [PATCH] drm/msm/dp: add module parameter for PSR

2023-05-24 Thread Dmitry Baryshkov
On 24/05/2023 09:59, Johan Hovold wrote: On Tue, May 23, 2023 at 12:23:04PM -0700, Abhinav Kumar wrote: On 5/23/2023 8:24 AM, Johan Hovold wrote: On Fri, May 12, 2023 at 09:13:04PM +0300, Dmitry Baryshkov wrote: On 28/04/2023 02:28, Abhinav Kumar wrote: On sc7280 where eDP is the primary disp

Re: [PATCH v2 RESEND 4/7] swiotlb: Dynamically allocated bounce buffers

2023-05-24 Thread Catalin Marinas
On Wed, May 17, 2023 at 01:27:48PM +0200, Petr Tesařík wrote: > On Wed, 17 May 2023 08:35:10 +0200 > Petr Tesařík wrote: > > Anyway, my greatest objection to allocating additional swiotlb chunks is > > that _all_ of them must be searched to determine that the physical > > address does _not_ belong

[Linux-kernel-mentorship] [PATCH] drm/amdgpu: remove excess parameter description in amdgpu_device.c

2023-05-24 Thread Ziqi Zhao
This patch is part of the Linux Kernel Bug Fixing Summer screening tasks. By removing the extra description, several documentation compilation warnings such as the following have been fixed: > ./drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:758: warning: Excess function > parameter 'pcie_index' desc

Re: [RESEND PATCH v3] mtd: rawnand: macronix: OTP access for MX30LFxG18AC

2023-05-24 Thread Arseniy Krasnov
On 22.05.2023 17:14, Miquel Raynal wrote: > Hi Arseniy, > > avkras...@sberdevices.ru wrote on Mon, 15 May 2023 12:49:50 +0300: > >> Hello @Miquel! >> >> Sorry, but who could review this patch? :) IIUC this logic is very hw >> specific and we need >> someone who knows it well? I tested this pa

[PATCH v4] mtd: rawnand: macronix: OTP access for MX30LFxG18AC

2023-05-24 Thread Arseniy Krasnov
This adds support for OTP area access on MX30LFxG18AC chip series. Signed-off-by: Arseniy Krasnov --- v1 -> v2: * Add slab.h include due to kernel test robot error. v2 -> v3: * Use 'uint64_t' as input argument for 'do_div()' instead of 'unsigned long' due to kernel test robot error.

Re: [RESEND PATCH v3] mtd: rawnand: macronix: OTP access for MX30LFxG18AC

2023-05-24 Thread liao jaime
Hi Miquel > > Hi Arseniy, > > avkras...@sberdevices.ru wrote on Mon, 15 May 2023 12:49:50 +0300: > > > Hello @Miquel! > > > > Sorry, but who could review this patch? :) IIUC this logic is very hw > > specific and we need > > someone who knows it well? I tested this patch on our devices (with alre

Re: [PATCH 0/7] Add a DRM driver to support AI Processing Unit (APU)

2023-05-24 Thread Kevin Hilman
Jeffrey Hugo writes: > On 5/17/2023 8:52 AM, Alexandre Bailon wrote: >> This adds a DRM driver that implements communication between the CPU and an >> APU. The driver target embedded device that usually run inference using some >> prebuilt models. The goal is to provide common infrastructure that

[PATCH v2] drm/nouveau: don't detect DSM for non-NVIDIA device

2023-05-24 Thread Ratchanan Srirattanamet
The call site of nouveau_dsm_pci_probe() uses single set of output variables for all invocations. So, we must not write anything to them unless it's an NVIDIA device. Otherwise, if we are called with another device after the NVIDIA device, we'll clober the result of the NVIDIA device. For example,

Re: [PATCH] MAINTAINERS: Add Carl/Pranjal as QAIC reviewers

2023-05-24 Thread Pranjal Ramajor Asha Kanojiya
On 5/23/2023 9:44 PM, Jeffrey Hugo wrote: Carl and Pranjal have been reviewing the QAIC patches. List them as reviewers so that they are copied on all developments which will make it easier for them to continue reviewing QAIC patches. Signed-off-by: Jeffrey Hugo --- MAINTAINERS | 2 ++ 1

Re: [PATCH] MAINTAINERS: Add Carl/Pranjal as QAIC reviewers

2023-05-24 Thread Carl Vanderlip
On 5/23/2023 9:14 AM, Jeffrey Hugo wrote: Carl and Pranjal have been reviewing the QAIC patches. List them as reviewers so that they are copied on all developments which will make it easier for them to continue reviewing QAIC patches. Signed-off-by: Jeffrey Hugo --- MAINTAINERS | 2 ++ 1

Re: [RESEND PATCH v3] mtd: rawnand: macronix: OTP access for MX30LFxG18AC

2023-05-24 Thread Arseniy Krasnov
On 24.05.2023 09:33, liao jaime wrote: > Hi Miquel > >> >> Hi Arseniy, >> >> avkras...@sberdevices.ru wrote on Mon, 15 May 2023 12:49:50 +0300: >> >>> Hello @Miquel! >>> >>> Sorry, but who could review this patch? :) IIUC this logic is very hw >>> specific and we need >>> someone who knows it

Re: [PATCH 06/36] drm/amd/display: add CRTC driver-specific property for gamma TF

2023-05-24 Thread Pekka Paalanen
On Tue, 23 May 2023 21:14:50 -0100 Melissa Wen wrote: > Hook up driver-specific atomic operations for managing AMD color > properties and create AMD driver-specific color management properties > and attach them according to HW capabilities defined by `struct > dc_color_caps`. Add enumerated trans

Re: [PATCH 0/5] accel/ivpu: Add debugfs support

2023-05-24 Thread Stanislaw Gruszka
Hi On Wed, May 24, 2023 at 10:55:08AM +0300, Oded Gabbay wrote: > On Wed, May 24, 2023 at 10:49 AM Stanislaw Gruszka > wrote: > > > > Add debugfs support for ivpu driver, most importantly firmware loging > > and tracing. > Hi, > Without looking at the code I have 2 comments/questions: > > 1. Ple

[PATCH v3 0/3] phy: mtk-mipi-csi: add driver for CSI phy

2023-05-24 Thread Julien Stephan
Adding a new driver for the MIPI CSI CD-PHY module v 0.5 embedded in some Mediatek soc, such as the MT8365 This driver was adapted from https://patchwork.kernel.org/project/linux-mediatek/cover/20200708104023.3225-1-louis@mediatek.com/ v1 can be found here: https://lore.kernel.org/all/20230

[PATCH v3 1/3] dt-bindings: phy: add PHY_TYPE_CDPHY definition

2023-05-24 Thread Julien Stephan
Add definition for CDPHY phy type that can be configured in either D-PHY mode or C-PHY mode Signed-off-by: Julien Stephan --- include/dt-bindings/phy/phy.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/dt-bindings/phy/phy.h b/include/dt-bindings/phy/phy.h index 6b901b342348..a19d85

[PATCH v3 2/3] dt-bindings: phy: add mediatek MIPI CD-PHY module v0.5

2023-05-24 Thread Julien Stephan
From: Florian Sylvestre This adds the bindings, for the MIPI CD-PHY module v0.5 embedded in some Mediatek soc, such as the mt8365 Signed-off-by: Florian Sylvestre Signed-off-by: Julien Stephan --- .../bindings/phy/mediatek,mt8365-csi-rx.yaml | 67 +++ MAINTAINERS

[PATCH v3 3/3] phy: mtk-mipi-csi: add driver for CSI phy

2023-05-24 Thread Julien Stephan
From: Phi-bang Nguyen This is a new driver that supports the MIPI CSI CD-PHY version 0.5 The number of PHYs depend on the SoC. Each PHY can support D-PHY only or CD-PHY configuration. The driver supports only D-PHY mode, so CD-PHY compatible PHY are configured in D-PHY mode. Signed-off-by: Loui

[PATCH v2] drm/panel: samsung-s6d7aa0: use pointer for drm_mode in panel desc struct

2023-05-24 Thread Artur Weber
Fixes compilation issues with older GCC versions and Clang after changes introduced in commit 6810bb390282 ("drm/panel: Add Samsung S6D7AA0 panel controller driver"). Tested with GCC 13.1.1, GCC 6.4.0 and Clang 16.0.3. Fixes the following errors with Clang: drivers/gpu/drm/panel/panel-samsung-s

[Bug 201957] amdgpu: ring gfx timeout

2023-05-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 --- Comment #87 from Stuart Foster (smf-li...@virginmedia.com) --- Is it worth the effort of bisecting this as it seems to be on a lot of kernel versions ? thanks -- You may reply to this email to add a comment. You are receiving this mail bec

[PATCH 1/2] drm/amd/display: clean up some inconsistent indenting

2023-05-24 Thread Jiapeng Chong
No functional modification involved. drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/dcn314_fpu.c:269 dcn314_update_bw_bounding_box_fpu() warn: inconsistent indenting. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5305 Signed-off-by: Jiapeng Chong --- dri

[PATCH 2/2] drm/amd/display: clean up some inconsistent indenting

2023-05-24 Thread Jiapeng Chong
No functional modification involved. drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn321/dcn321_fpu.c:556 dcn321_update_bw_bounding_box_fpu() warn: inconsistent indenting. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5304 Signed-off-by: Jiapeng Chong --- ...

Re: [Intel-gfx] [PATCH 1/2] drm/i915/pmu: Turn off the timer to sample frequencies when GT is parked

2023-05-24 Thread Andrzej Hajda
On 23.05.2023 17:19, Ashutosh Dixit wrote: pmu_needs_timer() keeps the timer running even when GT is parked, ostensibly to sample requested/actual frequencies. However frequency_sample() has the following: /* Report 0/0 (actual/requested) frequency while parked. */ if (!intel_gt_

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Make PMU sample array two-dimensional

2023-05-24 Thread Andrzej Hajda
On 23.05.2023 17:19, Ashutosh Dixit wrote: No functional changes but we can remove some unsightly index computation and read/write functions if we convert the PMU sample array from a one-dimensional to a two-dimensional array. Suggested-by: Tvrtko Ursulin Signed-off-by: Ashutosh Dixit Review

Re: [PATCH net-next v4 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-05-24 Thread Simon Horman
On Tue, May 23, 2023 at 02:53:44PM -0700, Justin Chen wrote: > Add support for the Broadcom ASP 2.0 Ethernet controller which is first > introduced with 72165. This controller features two distinct Ethernet > ports that can be independently operated. > > This patch supports: > > - Wake-on-LAN usi

[PATCH v4 01/13] fbdev: Add Kconfig options to select different fb_ops helpers

2023-05-24 Thread Thomas Zimmermann
Many fbdev drivers use the same set of fb_ops helpers. Add Kconfig options to select them at once. This will help with making DRM's fbdev emulation code more modular, but can also be used to simplify fbdev's driver configs. v3: * fix select statement (Jingfeng) Signed-off-by: Thomas Zimme

[PATCH v4 05/13] drm/gma500: Use regular fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Gma500 does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirel

[PATCH v4 02/13] fbdev: Add initializer macros for struct fb_ops

2023-05-24 Thread Thomas Zimmermann
For framebuffers in I/O and system memory, add macros that set struct fb_ops to the respective callback functions. For deferred I/O, add macros that generate callback functions with damage handling. Add initializer macros that set struct fb_ops to the generated callbacks. These macros can remove

[PATCH v4 06/13] drm/radeon: Use regular fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Radeon does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirel

[PATCH v4 00/13] drm/fbdev: Remove DRM's helpers for fbdev I/O

2023-05-24 Thread Thomas Zimmermann
DRM provides a number of wrappers around fbdev cfb_() sys_(), fb_io_() and fb_sys_() helpers. The DRM functions don't provide any additional functionality for most DRM drivers. So remove them and call the fbdev I/O helpers directly. The DRM fbdev I/O wrappers were originally added because does no

[PATCH v4 03/13] drm/armada: Use regular fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Armada does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirel

[PATCH v4 09/13] drm/omapdrm: Use regular fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Omapdrm does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entire

[PATCH v4 11/13] drm/fb-helper: Export helpers for marking damage areas

2023-05-24 Thread Thomas Zimmermann
Export drm_fb_helper_damage() and drm_fb_helper_damage_range(), which handle damage areas for fbdev emulation. This is a temporary export that allows to move the DRM I/O helpers for fbdev into drivers. Only fbdev-generic and i915 need them. Both will be updated to implement damage handling by thems

[PATCH v4 04/13] drm/exynos: Use regular fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Exynos does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirel

[PATCH v4 08/13] drm/msm: Use regular fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Msm does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirely.

[PATCH v4 12/13] drm/fbdev-generic: Implement dedicated fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Implement dedicated fbdev helpers for framebuffer I/O instead of using DRM's helpers. Use an fbdev generator macro for deferred I/O to create the callbacks. Fbdev-generic was the only caller of the DRM helpers, so remove them from the helper module. v4: * generate deferred-I/O helpers

[PATCH v4 07/13] drm/fbdev-dma: Use regular fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Fbdev-dma does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions enti

[PATCH v4 13/13] drm/i915: Implement dedicated fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Implement dedicated fbdev helpers for framebuffer I/O instead of using DRM's helpers. Use an fbdev generator macro for deferred I/O to create the fbdev callbacks. i915 was the only caller of the DRM helpers, so remove them from the helper module. i915's fbdev emulation is still incomplete as it do

[PATCH v4 10/13] drm/tegra: Use regular fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Tegra does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirely

Re: [PATCH net-next v4 6/6] MAINTAINERS: ASP 2.0 Ethernet driver maintainers

2023-05-24 Thread Simon Horman
On Tue, May 23, 2023 at 02:53:47PM -0700, Justin Chen wrote: > Add maintainers entry for ASP 2.0 Ethernet driver. > > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen Reviewed-by: Simon Horman

Re: [PATCH net-next v4 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0

2023-05-24 Thread Simon Horman
On Tue, May 23, 2023 at 02:53:42PM -0700, Justin Chen wrote: > The ASP 2.0 Ethernet controller uses a brcm unimac. > > Acked-by: Conor Dooley > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen Reviewed-by: Simon Horman

Re: [PATCH net-next v4 4/6] net: phy: mdio-bcm-unimac: Add asp v2.0 support

2023-05-24 Thread Simon Horman
On Tue, May 23, 2023 at 02:53:45PM -0700, Justin Chen wrote: > Add mdio compat string for ASP 2.0 ethernet driver. > > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen > Reviewed-by: Andrew Lunn Reviewed-by: Simon Horman

Re: [PATCH net-next v4 5/6] net: phy: bcm7xxx: Add EPHY entry for 74165

2023-05-24 Thread Simon Horman
On Tue, May 23, 2023 at 02:53:46PM -0700, Justin Chen wrote: > From: Florian Fainelli > > 74165 is a 16nm process SoC with a 10/100 integrated Ethernet PHY, > utilize the recently defined 16nm EPHY macro to configure that PHY. > > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen >

[PATCH v1 1/4] drm/mediatek: dsi: Use GENMASK() for register mask definitions

2023-05-24 Thread AngeloGioacchino Del Regno
Change magic numerical masks with usage of the GENMASK() macro to improve readability. This commit brings no functional changes. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dsi.c | 46 -- 1 file changed, 24 insertions(+), 22 deletions(

[PATCH v1 4/4] drm/mediatek: dsi: Replace open-coded instance of HZ_PER_MHZ

2023-05-24 Thread AngeloGioacchino Del Regno
In mtk_dsi_phy_timconfig(), we're dividing the `data_rate` variable, expressed in Hz to retrieve a value in MHz: instead of open-coding, use the HZ_PER_MHZ definition, available in linux/units.h. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dsi.c | 3 ++- 1 file ch

[PATCH v1 0/4] MediaTek DRM - DSI driver cleanups

2023-05-24 Thread AngeloGioacchino Del Regno
This series performs some cleanups for mtk_dsi, enhancing human readability, using kernel provided macros where possible and also reducing code size. Tested on MT8173 and MT8192 Chromebooks (using a DSI<->DP bridge) and on MT6795 Sony Xperia M5 (DSI video mode panel). Please note: This series dep

[PATCH v1 3/4] drm/mediatek: dsi: Use bitfield macros where useful

2023-05-24 Thread AngeloGioacchino Del Regno
Instead of open coding bitshifting for various register fields, use the bitfield macro FIELD_PREP(): this allows to enhance the human readability, decrease likeliness of mistakes (and register field overflowing) and also to simplify the code. The latter is especially seen in mtk_dsi_rxtx_control(),

[PATCH v1 2/4] drm/mediatek: dsi: Cleanup functions mtk_dsi_ps_control{_vact}()

2023-05-24 Thread AngeloGioacchino Del Regno
Function mtk_dsi_ps_control() is a subset of mtk_dsi_ps_control_vact(): merge the two in one mtk_dsi_ps_control() function by adding one function parameter `config_vact` which, when true, writes the VACT related registers. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/m

Re: [PATCH v2] drm/panel: samsung-s6d7aa0: use pointer for drm_mode in panel desc struct

2023-05-24 Thread Neil Armstrong
On 24/05/2023 10:43, Artur Weber wrote: Fixes compilation issues with older GCC versions and Clang after changes introduced in commit 6810bb390282 ("drm/panel: Add Samsung S6D7AA0 panel controller driver"). Tested with GCC 13.1.1, GCC 6.4.0 and Clang 16.0.3. Fixes the following errors with Clang

Re: [PATCH v3 2/3] dt-bindings: phy: add mediatek MIPI CD-PHY module v0.5

2023-05-24 Thread AngeloGioacchino Del Regno
Il 24/05/23 10:30, Julien Stephan ha scritto: From: Florian Sylvestre This adds the bindings, for the MIPI CD-PHY module v0.5 embedded in some Mediatek soc, such as the mt8365 Signed-off-by: Florian Sylvestre Signed-off-by: Julien Stephan --- .../bindings/phy/mediatek,mt8365-csi-rx.yaml |

Re: [PATCH v3 1/3] dt-bindings: phy: add PHY_TYPE_CDPHY definition

2023-05-24 Thread AngeloGioacchino Del Regno
Il 24/05/23 10:30, Julien Stephan ha scritto: Add definition for CDPHY phy type that can be configured in either D-PHY mode or C-PHY mode Signed-off-by: Julien Stephan Reviewed-by: AngeloGioacchino Del Regno --- include/dt-bindings/phy/phy.h | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH v2] drm/panel: samsung-s6d7aa0: use pointer for drm_mode in panel desc struct

2023-05-24 Thread Neil Armstrong
Hi, On Wed, 24 May 2023 10:43:24 +0200, Artur Weber wrote: > Fixes compilation issues with older GCC versions and Clang after > changes introduced in commit 6810bb390282 ("drm/panel: Add Samsung > S6D7AA0 panel controller driver"). Tested with GCC 13.1.1, GCC 6.4.0 > and Clang 16.0.3. > > Fixes t

Re: [PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

2023-05-24 Thread Marijn Suijten
On 2023-05-23 13:01:13, Abhinav Kumar wrote: > > > On 5/21/2023 10:21 AM, Dmitry Baryshkov wrote: > > Drop SSPP-specifig debugfs register dumps in favour of using > > debugfs/dri/0/kms or devcoredump. > > > > I did see another series which removes src_blk from the catalog (I am > yet to review

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2023-05-24 Thread Heikki Krogerus
On Mon, May 22, 2023 at 02:53:48PM -0700, Bjorn Andersson wrote: > On Mon, May 22, 2023 at 03:51:01PM -0500, Bjorn Andersson wrote: > > On Fri, Oct 08, 2021 at 03:38:21PM +0300, Heikki Krogerus wrote: > > > Hi, > > > > > > On Thu, Oct 07, 2021 at 09:15:12AM -0700, Bjorn Andersson wrote: > > > > Th

Re: [PATCH 2/9] drm/panel: Check for already prepared/enabled in drm_panel

2023-05-24 Thread Neil Armstrong
Hi, On 23/05/2023 21:27, Douglas Anderson wrote: In a whole pile of panel drivers, we have code to make the prepare/unprepare/enable/disable callbacks behave as no-ops if they've already been called. It's silly to have this code duplicated everywhere. Add it to the core instead so that we can ev

Re: [PATCH 0/5] accel/ivpu: Add debugfs support

2023-05-24 Thread Oded Gabbay
On Wed, May 24, 2023 at 11:29 AM Stanislaw Gruszka wrote: > > Hi > > On Wed, May 24, 2023 at 10:55:08AM +0300, Oded Gabbay wrote: > > On Wed, May 24, 2023 at 10:49 AM Stanislaw Gruszka > > wrote: > > > > > > Add debugfs support for ivpu driver, most importantly firmware loging > > > and tracing.

Re: [PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

2023-05-24 Thread Dmitry Baryshkov
On Wed, 24 May 2023 at 12:48, Marijn Suijten wrote: > > On 2023-05-23 13:01:13, Abhinav Kumar wrote: > > > > > > On 5/21/2023 10:21 AM, Dmitry Baryshkov wrote: > > > Drop SSPP-specifig debugfs register dumps in favour of using > > > debugfs/dri/0/kms or devcoredump. > > > > > > > I did see another

Re: [PATCH 0/7] Add a DRM driver to support AI Processing Unit (APU)

2023-05-24 Thread Oded Gabbay
On Wed, May 24, 2023 at 2:34 AM Kevin Hilman wrote: > > Jeffrey Hugo writes: > > > On 5/17/2023 8:52 AM, Alexandre Bailon wrote: > >> This adds a DRM driver that implements communication between the CPU and an > >> APU. The driver target embedded device that usually run inference using > >> some

[PATCH] drm/i915:fix kernel-doc trivial warnings

2023-05-24 Thread pengfuyuan
The test robot reports some make warnings. Fix those warnings: drivers/gpu/drm/i915/i915_gpu_error.c:2174: warning: Function parameter or member 'dump_flags' not described in 'i915_capture_error_state' drivers/gpu/drm/i915/i915_perf.c:5307: warning: Function parameter or member 'i915' no

[PATCH] drm/i915/gt: fix kernel-doc trivial warnings

2023-05-24 Thread pengfuyuan
The test robot reports some make warnings. Fix those warnings: drivers/gpu/drm/i915/gt/intel_gtt.h:499: warning: Function parameter or member 'vm' not described in 'i915_vm_resv_put' drivers/gpu/drm/i915/gt/intel_context.h:108: warning: Function parameter or member 'ce' not described in

[PATCH] drm/i915/gt/uc:fix kernel-doc trivial warnings

2023-05-24 Thread pengfuyuan
The test robot reports some make warnings. Fix those warnings: drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:491: warning: Function parameter or member 'marker' not described in 'guc_log_buffer_state' drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:491: warning: Function parameter or member 'r

Re: [PATCH] dma-buf/sw_sync: Replace all non-returning strlcpy with strscpy

2023-05-24 Thread Sumit Semwal
Hello Azeem, On Tue, 23 May 2023 at 22:52, Kees Cook wrote: > > On Tue, May 23, 2023 at 02:19:43AM +, Azeem Shaikh wrote: > > strlcpy() reads the entire source buffer first. > > This read may exceed the destination size limit. > > This is both inefficient and can lead to linear read > > over

Re: [PATCH 0/7] Add a DRM driver to support AI Processing Unit (APU)

2023-05-24 Thread Daniel Vetter
On Wed, May 24, 2023 at 01:27:00PM +0300, Oded Gabbay wrote: > On Wed, May 24, 2023 at 2:34 AM Kevin Hilman wrote: > > > > Jeffrey Hugo writes: > > > > > On 5/17/2023 8:52 AM, Alexandre Bailon wrote: > > >> This adds a DRM driver that implements communication between the CPU and > > >> an > > >>

[PATCH] drm/i915/pxp:fix kernel-doc trivial warnings

2023-05-24 Thread pengfuyuan
The test robot reports some make warnings. Fix those warnings: drivers/gpu/drm/i915/pxp/intel_pxp_types.h:96: warning: Function parameter or member 'dev_link' not described in 'intel_pxp' Reported-by: k2ci Signed-off-by: pengfuyuan --- drivers/gpu/drm/i915/pxp/intel_pxp_types.h | 2 +- 1

Re: [PATCH v2] drm/ast: Fix long time waiting on s3/s4 resume

2023-05-24 Thread Thomas Zimmermann
Hi, sorry that this took so long. Am 24.05.23 um 04:34 schrieb Jammy Huang: Hi Thomas, Could you help review this patch? This is an issue leading to kernel panic found by Intel. Wendy has confirmed issue resolved by this patch. On 2023/4/14 下午 03:42, Jammy Huang wrote: In resume, DP's lau

Re: [PATCH] drm/ast: Fix modeset failed on DisplayPort

2023-05-24 Thread Thomas Zimmermann
Hi, this patch also fell through the cracks. Apologies. Am 24.05.23 um 04:29 schrieb Jammy Huang: Hi Thomas, Do you have other suggestion for this patch?? The main issue was that struct ast_private is now called struct ast_device. So the current patch cannot be applied. Please kindly a

Re: [PATCH] drm/i915:fix kernel-doc trivial warnings

2023-05-24 Thread Jani Nikula
On Wed, 24 May 2023, pengfuyuan wrote: > The test robot reports some make warnings. > > Fix those warnings: > drivers/gpu/drm/i915/i915_gpu_error.c:2174: warning: Function parameter > or member 'dump_flags' not described in 'i915_capture_error_state' > drivers/gpu/drm/i915/i915_perf.c:530

Re: [PATCH 2/2] drm/i915/pmu: Make PMU sample array two-dimensional

2023-05-24 Thread Tvrtko Ursulin
On 23/05/2023 16:19, Ashutosh Dixit wrote: No functional changes but we can remove some unsightly index computation and read/write functions if we convert the PMU sample array from a one-dimensional to a two-dimensional array. Suggested-by: Tvrtko Ursulin Signed-off-by: Ashutosh Dixit ---

Re: [PATCH v2] drm/fb-helper: Fix height, width, and accel_flags in fb_var

2023-05-24 Thread Thomas Zimmermann
Thanks a lot. Pushed to drm-misc-fixes. Am 23.05.23 um 17:06 schrieb Geert Uytterhoeven: Fbtest contains some very simple validation of the fbdev userspace API contract. When used with shmob-drm, it reports the following warnings and errors: height changed from 68 to 0 height was rou

Re: [PATCH v3 0/5] drm: shmobile: Fixes and enhancements

2023-05-24 Thread Thomas Zimmermann
Hi Am 23.05.23 um 17:31 schrieb Geert Uytterhoeven: Hi all, Currently, there are two drivers for the LCD controller on Renesas SuperH-based and ARM-based SH-Mobile and R-Mobile SoCs: 1. sh_mobile_lcdcfb, using the fbdev framework, 2. shmob_drm, using the DRM framework. However, on

Re: [PATCH v6] drm/msm/dp: enable HDP plugin/unplugged interrupts at hpd_enable/disable

2023-05-24 Thread Leonard Lausen
Kuogee Hsieh writes: > The internal_hpd flag is set to true by dp_bridge_hpd_enable() and set to > false by dp_bridge_hpd_disable() to handle GPIO pinmuxed into DP controller > case. HDP related interrupts can not be enabled until internal_hpd is set > to true. At current implementation dp_display

Re: [PATCH v3 0/5] drm: shmobile: Fixes and enhancements

2023-05-24 Thread Geert Uytterhoeven
Hi Thomas, On Wed, May 24, 2023 at 1:42 PM Thomas Zimmermann wrote: > Am 23.05.23 um 17:31 schrieb Geert Uytterhoeven: > > Currently, there are two drivers for the LCD controller on Renesas > > SuperH-based and ARM-based SH-Mobile and R-Mobile SoCs: > >1. sh_mobile_lcdcfb, using the fbdev fra

Re: [Intel-gfx] [PATCH v10 0/2] drm/i915: Allow user to set cache at BO creation

2023-05-24 Thread Tvrtko Ursulin
On 23/05/2023 09:37, Andi Shyti wrote: Hi Fei, finally... pushed in drm-intel-gt-next! :) I had to revert this (uapi commit only) by force pushing, luckily it was the top commit. 1) IGT is not merged yet. 2) The tools/include/uapi/drm/i915_drm.h part of the patch was not removed. Please

Re: [PATCH v3 0/5] drm: shmobile: Fixes and enhancements

2023-05-24 Thread Thomas Zimmermann
Am 24.05.23 um 13:54 schrieb Geert Uytterhoeven: Hi Thomas, On Wed, May 24, 2023 at 1:42 PM Thomas Zimmermann wrote: Am 23.05.23 um 17:31 schrieb Geert Uytterhoeven: Currently, there are two drivers for the LCD controller on Renesas SuperH-based and ARM-based SH-Mobile and R-Mobile SoCs:

Re: [Intel-gfx] [PATCH v10 0/2] drm/i915: Allow user to set cache at BO creation

2023-05-24 Thread Tvrtko Ursulin
On 24/05/2023 12:56, Tvrtko Ursulin wrote: On 23/05/2023 09:37, Andi Shyti wrote: Hi Fei, finally... pushed in drm-intel-gt-next! :) I had to revert this (uapi commit only) by force pushing, luckily it was the top commit. 1) IGT is not merged yet. 2) The tools/include/uapi/drm/i915_drm

Re: [Intel-gfx] [PATCH v10 0/2] drm/i915: Allow user to set cache at BO creation

2023-05-24 Thread Andi Shyti
Hi Tvrtko, > > finally... pushed in drm-intel-gt-next! :) > > I had to revert this (uapi commit only) by force pushing, luckily it was the > top commit. OK, sorry! > 1) > IGT is not merged yet. if igt is merged without the kernel it would fail, though. > 2) > The tools/include/uapi/drm/i915_d

Re: [Intel-gfx] [PATCH v10 0/2] drm/i915: Allow user to set cache at BO creation

2023-05-24 Thread Andi Shyti
Hi again, > > > finally... pushed in drm-intel-gt-next! :) > > > > I had to revert this (uapi commit only) by force pushing, luckily it was the > > top commit. > > OK, sorry! > > > 1) > > IGT is not merged yet. > > if igt is merged without the kernel it would fail, though. can we at least agr

[PATCH 0/2] drm/panel: simple: Add support for Ampire AM-800480L1TMQW-T00H

2023-05-24 Thread Geert Uytterhoeven
Hi all, This patch series adds support for the Ampire AM-800480L1TMQW-T00H 5" WVGA TFT LCD panel, which can be found on e.g. the Atmark Techno Armadillo-800-EVA development board. It has been tested with a WIP DT-enhanced version of the shmob-drm driver. Thanks for your comments! Geert

[PATCH 1/2] dt-bindings: display: panel-simple: Add Ampire AM-800480L1TMQW-T00H

2023-05-24 Thread Geert Uytterhoeven
Document support for the Ampire AM-800480L1TMQW-T00H 5" WVGA TFT LCD panel. Signed-off-by: Geert Uytterhoeven --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yam

[PATCH 2/2] drm/panel: simple: Add Ampire AM-800480L1TMQW-T00H

2023-05-24 Thread Geert Uytterhoeven
Add support for the Ampire AM-800480L1TMQW-T00H 5" WVGA TFT LCD panel. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/panel/panel-simple.c | 33 1 file changed, 33 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-

Re: [Intel-gfx] [PATCH v10 0/2] drm/i915: Allow user to set cache at BO creation

2023-05-24 Thread Tvrtko Ursulin
On 24/05/2023 13:19, Andi Shyti wrote: Hi Tvrtko, finally... pushed in drm-intel-gt-next! :) I had to revert this (uapi commit only) by force pushing, luckily it was the top commit. OK, sorry! 1) IGT is not merged yet. if igt is merged without the kernel it would fail, though. Ideal

[PATCH] drm/panel: simple: Simplify matching using of_device_get_match_data()

2023-05-24 Thread Geert Uytterhoeven
Both the patform_driver and mipi_dsi_driver structures contain pointers to the match table used, so the custom code to obtain match and match data can be replaced by calls to of_device_get_match_data(). Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/panel/panel-simple.c | 15 ++---

Re: [PATCH 12/13] drm/i915/dp: Get optimal link config to have best compressed bpp

2023-05-24 Thread Ville Syrjälä
On Tue, May 23, 2023 at 12:01:34PM +0300, Lisovskiy, Stanislav wrote: > On Tue, May 16, 2023 at 02:40:27PM +0300, Ville Syrjälä wrote: > > On Tue, May 16, 2023 at 01:43:44PM +0300, Lisovskiy, Stanislav wrote: > > > On Fri, May 12, 2023 at 11:54:16AM +0530, Ankit Nautiyal wrote: > > > > Currently, w

[PULL] drm-misc-next

2023-05-24 Thread Thomas Zimmermann
Hi Dave and Daniel, here is this week's PR for drm-misc-next. I'm taking over while Maxime is away. There's support for a few more panels and bridges. In fbdev, I/O helpers are now implemented within the architecture code. DRM's shmobile driver received some updates. Best regards Thomas drm-misc

Re: [PATCH V7 0/6] drm: bridge: samsung-dsim: Support variable clocking

2023-05-24 Thread Fabio Estevam
Hi Adam, On Tue, May 23, 2023 at 8:49 PM Adam Ford wrote: > Inki, > > I haven't heard back from you on whether or not you want the bindings > patch to be included with me resending the series as V7 or if you're > OK with a single, stand-alone patch. > Will you let me know? I have the patch stan

Re: [PATCH V7 0/6] drm: bridge: samsung-dsim: Support variable clocking

2023-05-24 Thread Adam Ford
On Wed, May 24, 2023 at 7:45 AM Fabio Estevam wrote: > > Hi Adam, > > On Tue, May 23, 2023 at 8:49 PM Adam Ford wrote: > > > Inki, > > > > I haven't heard back from you on whether or not you want the bindings > > patch to be included with me resending the series as V7 or if you're > > OK with a s

Re: [Intel-gfx] [PATCH v10 0/2] drm/i915: Allow user to set cache at BO creation

2023-05-24 Thread Tvrtko Ursulin
On 24/05/2023 13:30, Andi Shyti wrote: Hi again, finally... pushed in drm-intel-gt-next! :) I had to revert this (uapi commit only) by force pushing, luckily it was the top commit. OK, sorry! 1) IGT is not merged yet. if igt is merged without the kernel it would fail, though. can we

  1   2   3   >