On Wed, May 24, 2023 at 10:49 AM Stanislaw Gruszka <stanislaw.grus...@linux.intel.com> wrote: > > Add debugfs support for ivpu driver, most importantly firmware loging > and tracing. Hi, Without looking at the code I have 2 comments/questions:
1. Please add an ABI documentation in Documentation/ABI/testing/ or Documentation/ABI/stable (if you are feeling courageous). You can see for example habana's file at Documentation/ABI/testing/debugfs-driver-habanalabs 2. Is this synced with Christian's upcoming changes to the debugfs infra in drm ? If not, I might suggest to sync with that and wait until those patches are merged because they change the layout of debugfs nodes. Oded > > Andrzej Kacprowski (1): > accel/ivpu: Print firmware name and version > > Krystian Pradzynski (1): > accel/ivpu: Add fw_name file to debugfs > > Stanislaw Gruszka (3): > accel/ivpu: Initial debugfs support > accel/ivpu: Add firmware tracing support > accel/ivpu: Add debugfs files for testing device reset > > drivers/accel/ivpu/Makefile | 4 +- > drivers/accel/ivpu/ivpu_debugfs.c | 294 ++++++++++++++++++++++++++++++ > drivers/accel/ivpu/ivpu_debugfs.h | 13 ++ > drivers/accel/ivpu/ivpu_drv.c | 5 + > drivers/accel/ivpu/ivpu_fw.c | 68 ++++++- > drivers/accel/ivpu/ivpu_fw.h | 4 + > drivers/accel/ivpu/ivpu_fw_log.c | 142 +++++++++++++++ > drivers/accel/ivpu/ivpu_fw_log.h | 38 ++++ > drivers/accel/ivpu/ivpu_pm.c | 1 + > drivers/accel/ivpu/ivpu_pm.h | 1 + > 10 files changed, 563 insertions(+), 7 deletions(-) > create mode 100644 drivers/accel/ivpu/ivpu_debugfs.c > create mode 100644 drivers/accel/ivpu/ivpu_debugfs.h > create mode 100644 drivers/accel/ivpu/ivpu_fw_log.c > create mode 100644 drivers/accel/ivpu/ivpu_fw_log.h > > -- > 2.25.1 >
