Re: [PATCH 0/4] Track exported dma-buffers with memcg

2023-01-12 Thread Shakeel Butt
On Wed, Jan 11, 2023 at 04:49:36PM -0800, T.J. Mercier wrote: > [...] > > The problem is a bit that with gpu allocations reclaim is essentially "we > > pass the error to userspace and they get to sort the mess out". There are > > some exceptions (some gpu drivers to have shrinkers) would we need t

Re: [PATCH 0/4] Track exported dma-buffers with memcg

2023-01-12 Thread Christian König
Am 12.01.23 um 09:13 schrieb Shakeel Butt: On Wed, Jan 11, 2023 at 04:49:36PM -0800, T.J. Mercier wrote: [...] The problem is a bit that with gpu allocations reclaim is essentially "we pass the error to userspace and they get to sort the mess out". There are some exceptions (some gpu drivers to

Re: [PATCH v10 3/9] drm/display: Add Type-C switch helpers

2023-01-12 Thread Pin-yen Lin
On Thu, Jan 12, 2023 at 1:50 PM Dmitry Baryshkov wrote: > > On 12/01/2023 07:48, Pin-yen Lin wrote: > > On Thu, Jan 12, 2023 at 1:24 PM Dmitry Baryshkov > > wrote: > >> > >> On 12/01/2023 07:19, Pin-yen Lin wrote: > >>> Hi Dmitry, > >>> > >>> Thanks for the review. > >>> > >>> On Thu, Jan 12, 202

[PATCH] drm/nouveau/mmu: Fix an UAF issue in NVKM

2023-01-12 Thread korantwork
From: Xinghui Li In nvkm_mem_new_host, the mem is be alloced. And mem->memory is assigned to pmemory. During this process, the mem will be free if the error occurs. But the *pmemory still points to the &mem->memory which has been relased.Laterly, the nvkm_memory_unref will put the memory which po

Re: [PATCH 11/11] video/aperture: Only remove sysfb on the default vga pci device

2023-01-12 Thread Aaron Plattner
On 1/11/23 8:58 AM, Javier Martinez Canillas wrote: Hello Daniel, On 1/11/23 16:41, Daniel Vetter wrote: This fixes a regression introduced by ee7a69aa38d8 ("fbdev: Disable sysfb device registration when removing conflicting FBs"), where we remove the sysfb when loading a driver for an unrelate

Re: [PATCH v10 3/9] drm/display: Add Type-C switch helpers

2023-01-12 Thread Jani Nikula
On Thu, 12 Jan 2023, Pin-yen Lin wrote: > Add helpers to register and unregister Type-C "switches" for bridges > capable of switching their output between two downstream devices. > > The helper registers USB Type-C mode switches when the "mode-switch" > and the "data-lanes" properties are availabl

Re: [PATCH v2 12/13] drm/bridge: lt9611: stop filtering modes via the table

2023-01-12 Thread neil . armstrong
On 11/01/2023 16:37, Dmitry Baryshkov wrote: On 11/01/2023 12:57, Neil Armstrong wrote: On 08/01/2023 17:56, Dmitry Baryshkov wrote: The lt9611 bridge can support different modes, it makes no sense to list them in the table. Drop the table and check the number of interfaces using the fixed valu

Re: [PATCH 11/11] video/aperture: Only remove sysfb on the default vga pci device

2023-01-12 Thread Javier Martinez Canillas
On 1/12/23 08:55, Thomas Zimmermann wrote: [...] >> Thanks Daniel and Javier! >> >> I wasn't able to reproduce the original problem on my hybrid laptop >> since it refuses to boot with the console on an external display, but I >> was able to reproduce it by switching the configuration around: b

Re: [PATCH 01/13] drm/debugfs: Create helper to add debugfs files to device's list

2023-01-12 Thread Jani Nikula
On Wed, 11 Jan 2023, Maíra Canal wrote: > Create a helper to encapsulate the code that adds a new debugfs file to > a linked list related to a object. Moreover, the helper also provides > more flexibily on the type of the object, allowing to use the helper for > other types of drm_debugfs_entry. >

[PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-12 Thread Wayne Lin
This reverts commit 4d07b0bc403403438d9cf88450506240c5faf92f. [Why] Changes cause regression on amdgpu mst. E.g. In fill_dc_mst_payload_table_from_drm(), amdgpu expects to add/remove payload one by one and call fill_dc_mst_payload_table_from_drm() to update the HW maintained payload table. But pre

Re: [PATCH 02/13] drm/debugfs: Create helper to create debugfs files from list

2023-01-12 Thread Jani Nikula
On Wed, 11 Jan 2023, Maíra Canal wrote: > Create a helper to encapsulate the code that creates a new debugfs file > from a linked list related to an object. Moreover, the helper also provides > more flexibily on the type of the object. > > Signed-off-by: Maíra Canal > --- > drivers/gpu/drm/drm_d

Re: [PATCH 04/13] drm/debugfs: Create a debugfs infrastructure for encoders

2023-01-12 Thread Jani Nikula
On Wed, 11 Jan 2023, Maíra Canal wrote: > Introduce the ability to add DRM debugfs files to a list managed by the > encoder and, during drm_encoder_register_all(), all added files will be > created at once. > > Moreover, introduce some typesafety as struct drm_debugfs_encoder_entry > holds a drm_e

Re: [PATCH 02/11] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-01-12 Thread Thomas Zimmermann
Hi Am 11.01.23 um 16:41 schrieb Daniel Vetter: This one nukes all framebuffers, which is a bit much. In reality gma500 is igpu and never shipped with anything discrete, so there should not be any difference. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/gma500/psb_drv.c | 2 +- 1 file ch

Re: [PATCH 03/13] drm/debugfs: Create a debugfs infrastructure for connectors

2023-01-12 Thread Jani Nikula
On Wed, 11 Jan 2023, Maíra Canal wrote: > Introduce the ability to add DRM debugfs files to a list managed by the > connector and, during drm_connector_register(), all added files will be > created at once. > > Moreover, introduce some typesafety as struct drm_debugfs_connector_entry > holds a drm

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-12 Thread Boris Brezillon
Hi Daniel, On Wed, 11 Jan 2023 22:47:02 +0100 Daniel Vetter wrote: > On Tue, 10 Jan 2023 at 09:46, Boris Brezillon > wrote: > > > > Hi Daniel, > > > > On Mon, 9 Jan 2023 21:40:21 +0100 > > Daniel Vetter wrote: > > > > > On Mon, Jan 09, 2023 at 06:17:48PM +0100, Boris Brezillon wrote: > > >

Re: [PATCH 01/13] drm/debugfs: Create helper to add debugfs files to device's list

2023-01-12 Thread Daniel Vetter
On Thu, Jan 12, 2023 at 10:50:40AM +0200, Jani Nikula wrote: > On Wed, 11 Jan 2023, Maíra Canal wrote: > > Create a helper to encapsulate the code that adds a new debugfs file to > > a linked list related to a object. Moreover, the helper also provides > > more flexibily on the type of the object,

[PATCH] drm/vc4: bo: Fix drmm_mutex_init memory hog

2023-01-12 Thread Maxime Ripard
Commit 374146cad469 ("drm/vc4: Switch to drmm_mutex_init") converted, among other functions, vc4_create_object() to use drmm_mutex_init(). However, that function is used to allocate a BO, and therefore the mutex needs to be freed much sooner than when the DRM device is removed from the system. Fo

Re: [PATCH 03/13] drm/debugfs: Create a debugfs infrastructure for connectors

2023-01-12 Thread Daniel Vetter
On Wed, Jan 11, 2023 at 02:37:38PM -0300, Maíra Canal wrote: > Introduce the ability to add DRM debugfs files to a list managed by the > connector and, during drm_connector_register(), all added files will be > created at once. > > Moreover, introduce some typesafety as struct drm_debugfs_connecto

Re: [PATCH v1 2/2] drm/virtio: Add the hotplug_mode_update property for rescanning of modes

2023-01-12 Thread Daniel Vetter
On Thu, Jan 12, 2023 at 08:17:19AM +0100, Gerd Hoffmann wrote: > Hi, > > > > > I think we need to do a bit of refactoring/documenting here first. > > > [Kasireddy, Vivek] Just for reference, here is Dave's commit that added > > > this > > > property for qxl: > > > commit 4695b03970df378dcb93fe3

Re: [PATCH v2 12/13] drm/bridge: lt9611: stop filtering modes via the table

2023-01-12 Thread Dmitry Baryshkov
On 12/01/2023 10:43, neil.armstr...@linaro.org wrote: On 11/01/2023 16:37, Dmitry Baryshkov wrote: On 11/01/2023 12:57, Neil Armstrong wrote: On 08/01/2023 17:56, Dmitry Baryshkov wrote: The lt9611 bridge can support different modes, it makes no sense to list them in the table. Drop the table

Re: [PATCH 07/13] drm/vc4: Use the encoders' debugfs infrastructure

2023-01-12 Thread Jani Nikula
On Wed, 11 Jan 2023, Maíra Canal wrote: > Replace the use of drm_debugfs_add_files() with the new > drm_debugfs_encoder_add_files() function, which centers the debugfs files > management on the drm_encoder instead of drm_device. Using this function > on late register callbacks is more adequate as

Re: [PATCH 03/13] drm/debugfs: Create a debugfs infrastructure for connectors

2023-01-12 Thread Jani Nikula
On Thu, 12 Jan 2023, Daniel Vetter wrote: > On Wed, Jan 11, 2023 at 02:37:38PM -0300, Maíra Canal wrote: >> Introduce the ability to add DRM debugfs files to a list managed by the >> connector and, during drm_connector_register(), all added files will be >> created at once. >> >> Moreover, introd

Re: [PATCH v2 01/13] drm/bridge: lt9611: fix sleep mode setup

2023-01-12 Thread Neil Armstrong
On 08/01/2023 17:56, Dmitry Baryshkov wrote: On atomic_post_disable the bridge goes to the low power state. However the code disables too much of the chip, so the HPD event is not being detected and delivered to the host. Reduce the power saving in order to get the HPD event. Fixes: 23278bf54afe

Re: [PATCH v2 02/13] drm/bridge: lt9611: fix HPD reenablement

2023-01-12 Thread Neil Armstrong
On 08/01/2023 17:56, Dmitry Baryshkov wrote: The driver will reset the bridge in the atomic_pre_enable(). However this will also drop the HPD interrupt state. Instead of resetting the bridge, properly wake it up. This fixes the HPD interrupt delivery after the disable/enable cycle. Fixes: 23278b

Re: [PATCH 01/13] drm/debugfs: Create helper to add debugfs files to device's list

2023-01-12 Thread Jani Nikula
On Thu, 12 Jan 2023, Daniel Vetter wrote: > On Thu, Jan 12, 2023 at 10:50:40AM +0200, Jani Nikula wrote: >> On Wed, 11 Jan 2023, Maíra Canal wrote: >> > Create a helper to encapsulate the code that adds a new debugfs file to >> > a linked list related to a object. Moreover, the helper also provid

Re: [PATCH v2 03/13] drm/bridge: lt9611: fix polarity programming

2023-01-12 Thread Neil Armstrong
On 08/01/2023 17:56, Dmitry Baryshkov wrote: Fix programming of hsync and vsync polarities Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/lontium-lt9611.c | 17 - 1 file changed, 12 insertions

Re: [PATCH v2 04/13] drm/bridge: lt9611: fix programming of video modes

2023-01-12 Thread Neil Armstrong
On 08/01/2023 17:56, Dmitry Baryshkov wrote: Program the upper part of the hfront_porch into the proper register. Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/lontium-lt9611.c | 3 ++- 1 file changed, 2 ins

Re: [PATCH v2 05/13] drm/bridge: lt9611: fix clock calculation

2023-01-12 Thread Neil Armstrong
On 08/01/2023 17:56, Dmitry Baryshkov wrote: Instead of having several fixed values for the pcr register, calculate it before programming. This allows the bridge to support most of the display modes. Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge") Signed-off-by: Dmitry Ba

Re: [PATCH v2 06/13] drm/bridge: lt9611: pass a pointer to the of node

2023-01-12 Thread Neil Armstrong
On 08/01/2023 17:56, Dmitry Baryshkov wrote: Pass a pointer to the OF node while registering lt9611 MIPI device. Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/lontium-lt9611.c | 2 +- 1 file changed, 1 inser

Re: [PATCH v2 09/13] drm/bridge: lt9611: fix sync polarity for DVI output

2023-01-12 Thread Neil Armstrong
On 08/01/2023 17:56, Dmitry Baryshkov wrote: Attaching DVI sink to the lt9611 requires different setup. Fix the register write to make the DVI displays sync onto the correct sync pulse. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/lontium-lt9611.c | 9 ++--- 1 file changed,

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-12 Thread Daniel Vetter
On Thu, Jan 12, 2023 at 10:10:53AM +0100, Boris Brezillon wrote: > Hi Daniel, > > On Wed, 11 Jan 2023 22:47:02 +0100 > Daniel Vetter wrote: > > > On Tue, 10 Jan 2023 at 09:46, Boris Brezillon > > wrote: > > > > > > Hi Daniel, > > > > > > On Mon, 9 Jan 2023 21:40:21 +0100 > > > Daniel Vetter wr

Re: [v3, 3/7] drm/bridge_connector: rely on drm_kms_helper_poll_* for HPD enablement

2023-01-12 Thread Neil Armstrong
On 11/01/2023 13:41, Marek Szyprowski wrote: On 02.11.2022 19:07, Dmitry Baryshkov wrote: Use drm_connector's helpers enable_hpd and disable_hpd to enable and disable HPD automatically by the means of drm_kms_helper_poll_* functions. As the drm_bridge_connector_enable_hpd() and drm_bridge_connec

Re: [v3, 3/7] drm/bridge_connector: rely on drm_kms_helper_poll_* for HPD enablement

2023-01-12 Thread Dmitry Baryshkov
On 12/01/2023 11:35, Neil Armstrong wrote: On 11/01/2023 13:41, Marek Szyprowski wrote: On 02.11.2022 19:07, Dmitry Baryshkov wrote: Use drm_connector's helpers enable_hpd and disable_hpd to enable and disable HPD automatically by the means of drm_kms_helper_poll_* functions. As the drm_bridge_

Re: [PATCH v2 2/3] drm/panel: boe-tv101wum-nl6: Reduce lcm_reset to send initial code time

2023-01-12 Thread 李昕磊

Re: [PATCH 01/11] drm/ast: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-01-12 Thread Thomas Zimmermann
Am 11.01.23 um 16:41 schrieb Daniel Vetter: It's just open coded and matches. Note that Thomas said that his version apparently failed for some reason, but hey maybe we should try again. It apparently worked this time. Tested on an AST2100 chip. Signed-off-by: Daniel Vetter Cc: Dave Airl

Re: [RESEND PATCH linux-next v2 00/10] drm: Remove some obsolete drivers(tdfx, mga, i810, savage, r128, sis, via)

2023-01-12 Thread Daniel Vetter
On Thu, Jan 05, 2023 at 02:01:50PM +0100, Thomas Zimmermann wrote: > Hi > > Am 05.01.23 um 13:40 schrieb Daniel Vetter: > > On Thu, Dec 08, 2022 at 08:42:07PM +0800, Cai Huoqing wrote: > > > On 03 12月 22 18:22:51, Cai Huoqing wrote: > > > > Commit 399516ab0fee ("MAINTAINERS: Add a bunch of legacy

Re: [PATCH 07/13] drm/vc4: Use the encoders' debugfs infrastructure

2023-01-12 Thread Daniel Vetter
On Thu, Jan 12, 2023 at 11:19:37AM +0200, Jani Nikula wrote: > On Wed, 11 Jan 2023, Maíra Canal wrote: > > Replace the use of drm_debugfs_add_files() with the new > > drm_debugfs_encoder_add_files() function, which centers the debugfs files > > management on the drm_encoder instead of drm_device.

Re: [Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2023-01-12 Thread Lucas De Marchi
On Thu, Jan 05, 2023 at 09:27:57PM +, Matthew Brost wrote: On Tue, Jan 03, 2023 at 12:21:08PM +, Tvrtko Ursulin wrote: On 22/12/2022 22:21, Matthew Brost wrote: > Hello, > > This is a submission for Xe, a new driver for Intel GPUs that supports both > integrated and discrete platforms s

Re: [PATCH 02/11] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-01-12 Thread Daniel Vetter
On Thu, Jan 12, 2023 at 10:04:48AM +0100, Thomas Zimmermann wrote: > Hi > > Am 11.01.23 um 16:41 schrieb Daniel Vetter: > > This one nukes all framebuffers, which is a bit much. In reality > > gma500 is igpu and never shipped with anything discrete, so there should > > not be any difference. > >

Re: [PATCH v2 3/3] drm/panel: boe-tv101wum-nl6: Fine tune the panel power sequence

2023-01-12 Thread 李昕磊

Re: [PATCH 9/9] arm64: dts: mediatek: mt8186: Add display nodes

2023-01-12 Thread Chen-Yu Tsai
Hi, On Wed, Jan 11, 2023 at 8:37 PM Allen-KH Cheng wrote: > > Add display nodes and GCE info for MT8186 SoC. Also, add GCE > (Global Command Engine) properties to the display nodes in order to > enable the usage of the CMDQ (Command Queue), which is required for > operating the display. > > Signe

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Allow error capture without a request

2023-01-12 Thread Tvrtko Ursulin
On 12/01/2023 02:53, john.c.harri...@intel.com wrote: From: John Harrison There was a report of error captures occurring without any hung context being indicated despite the capture being initiated by a 'hung context notification' from GuC. The problem was not reproducible. However, it is pos

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Allow error capture of a pending request

2023-01-12 Thread Tvrtko Ursulin
On 12/01/2023 02:53, john.c.harri...@intel.com wrote: From: John Harrison A hang situation has been observed where the only requests on the context were either completed or not yet started according to the breaadcrumbs. However, the register state claimed a batch was (maybe) in progress. So,

Re: [PATCH v2] drm/i915: Fix CFI violations in gt_sysfs

2023-01-12 Thread Jocelyn Falempe
Hi, This patch does also solve a kernel crash when reading /sys/class/drm/card1/gt/gt0/* on a skylake machine: https://bugzilla.redhat.com/show_bug.cgi?id=2154880 Do you think it can be backported to stable releases ? Conflicts are trivial on top of v6.0 at least. Thanks, -- Jocelyn On 13

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-12 Thread Boris Brezillon
On Thu, 12 Jan 2023 10:32:18 +0100 Daniel Vetter wrote: > On Thu, Jan 12, 2023 at 10:10:53AM +0100, Boris Brezillon wrote: > > Hi Daniel, > > > > On Wed, 11 Jan 2023 22:47:02 +0100 > > Daniel Vetter wrote: > > > > > On Tue, 10 Jan 2023 at 09:46, Boris Brezillon > > > wrote: > > > > > > >

Re: [Intel-gfx] [PATCH 4/4] drm/i915/guc: Add a debug print on GuC triggered reset

2023-01-12 Thread Tvrtko Ursulin
On 12/01/2023 02:53, john.c.harri...@intel.com wrote: From: John Harrison For understanding bug reports, it can be useful to have an explicit dmesg print when a reset notification is received from GuC. As opposed to simply inferring that this happened from other messages. Signed-off-by: John

Re: [Intel-gfx] [PATCH 3/4] drm/i915/guc: Look for a guilty context when an engine reset fails

2023-01-12 Thread Tvrtko Ursulin
On 12/01/2023 02:53, john.c.harri...@intel.com wrote: From: John Harrison Engine resets are supposed to never fail. But in the case when one does (due to unknown reasons that normally come down to a missing w/a), it is useful to get as much information out of the system as possible. Given tha

Re: [PATCH 02/11] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-01-12 Thread Thomas Zimmermann
Hi Am 12.01.23 um 10:59 schrieb Daniel Vetter: On Thu, Jan 12, 2023 at 10:04:48AM +0100, Thomas Zimmermann wrote: Hi Am 11.01.23 um 16:41 schrieb Daniel Vetter: This one nukes all framebuffers, which is a bit much. In reality gma500 is igpu and never shipped with anything discrete, so there s

Re: [PATCH 0/4] Track exported dma-buffers with memcg

2023-01-12 Thread Michal Hocko
On Thu 12-01-23 07:56:31, Shakeel Butt wrote: > On Wed, Jan 11, 2023 at 11:56:45PM +0100, Daniel Vetter wrote: > > > [...] > > I think eventually, at least for other "account gpu stuff in cgroups" use > > case we do want to actually charge the memory. > > > > The problem is a bit that with gpu al

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-12 Thread Boris Brezillon
On Thu, 12 Jan 2023 11:11:03 +0100 Boris Brezillon wrote: > On Thu, 12 Jan 2023 10:32:18 +0100 > Daniel Vetter wrote: > > > On Thu, Jan 12, 2023 at 10:10:53AM +0100, Boris Brezillon wrote: > > > Hi Daniel, > > > > > > On Wed, 11 Jan 2023 22:47:02 +0100 > > > Daniel Vetter wrote: > > >

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-12 Thread Boris Brezillon
On Thu, 12 Jan 2023 11:11:03 +0100 Boris Brezillon wrote: > On Thu, 12 Jan 2023 10:32:18 +0100 > Daniel Vetter wrote: > > > On Thu, Jan 12, 2023 at 10:10:53AM +0100, Boris Brezillon wrote: > > > Hi Daniel, > > > > > > On Wed, 11 Jan 2023 22:47:02 +0100 > > > Daniel Vetter wrote: > > >

Re: [PATCH v10 0/9] Register Type-C mode-switch in DP bridge endpoints

2023-01-12 Thread Andy Shevchenko
On Thu, Jan 12, 2023 at 06:34:52AM +0200, Dmitry Baryshkov wrote: > On 12/01/2023 06:20, Pin-yen Lin wrote: > > > > This series introduces bindings for anx7625/it6505 to register Type-C > > mode-switch in their output endpoints, and use data-lanes property to > > describe the pin connections. > >

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-12 Thread Daniel Vetter
On Thu, Jan 12, 2023 at 11:25:53AM +0100, Boris Brezillon wrote: > On Thu, 12 Jan 2023 11:11:03 +0100 > Boris Brezillon wrote: > > > On Thu, 12 Jan 2023 10:32:18 +0100 > > Daniel Vetter wrote: > > > > > On Thu, Jan 12, 2023 at 10:10:53AM +0100, Boris Brezillon wrote: > > > > Hi Daniel, > > >

Re: [PATCH 02/11] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-01-12 Thread Daniel Vetter
On Thu, Jan 12, 2023 at 11:24:13AM +0100, Thomas Zimmermann wrote: > Hi > > Am 12.01.23 um 10:59 schrieb Daniel Vetter: > > On Thu, Jan 12, 2023 at 10:04:48AM +0100, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 11.01.23 um 16:41 schrieb Daniel Vetter: > > > > This one nukes all framebuffers,

Re: [PATCH] drm/vc4: bo: Fix drmm_mutex_init memory hog

2023-01-12 Thread Daniel Vetter
On Thu, Jan 12, 2023 at 10:12:43AM +0100, Maxime Ripard wrote: > Commit 374146cad469 ("drm/vc4: Switch to drmm_mutex_init") converted, > among other functions, vc4_create_object() to use drmm_mutex_init(). > > However, that function is used to allocate a BO, and therefore the > mutex needs to be f

Re: [v3,3/7] drm/bridge_connector: rely on drm_kms_helper_poll_* for HPD enablement

2023-01-12 Thread Marek Szyprowski
ridge_connector_enable_hpd() has been removed with > 4c00ac500d0e ("drm/bridge_connector: drop > drm_bridge_connector_en/disable_hpd()") The above log has been captured at commit 92d755d8f13b during bisecting, so 4c00ac500d0e is not applied yet. Maybe I should have mention that

Re: [PATCH 1/9] arm64: dts: mediatek: mt8186: Add MTU3 nodes

2023-01-12 Thread Chen-Yu Tsai
On Wed, Jan 11, 2023 at 8:37 PM Allen-KH Cheng wrote: > > Add MTU3 nodes for MT8186 SoC. > > Signed-off-by: Allen-KH Cheng Tested-by: Chen-Yu Tsai

Re: [PATCH 7/9] arm64: dts: mediatek: mt8186: Add DPI node

2023-01-12 Thread Chen-Yu Tsai
On Wed, Jan 11, 2023 at 8:37 PM Allen-KH Cheng wrote: > > Add DPI node for MT8186 SoC. > > Signed-off-by: Allen-KH Cheng > --- > arch/arm64/boot/dts/mediatek/mt8186.dtsi | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi > b/arch

Re: [PATCH v3] drm/vkms: reintroduce prepare_fb and cleanup_fb functions

2023-01-12 Thread Melissa Wen
On 01/11, Maíra Canal wrote: > With commit 359c6649cd9a ("drm/gem: Implement shadow-plane {begin, > end}_fb_access with vmap"), the behavior of the shadow-plane helpers > changed and the vunmap is now performed at the end of > the current pageflip, instead of the end of the following pageflip. App

[PATCH v2] drm: Optimize drm buddy top-down allocation method

2023-01-12 Thread Arunpravin Paneer Selvam
We are observing performance drop in many usecases which include games, 3D benchmark applications,etc.. To solve this problem, We are strictly not allowing top down flag enabled allocations to steal the memory space from cpu visible region. The idea is, we are sorting each order list entries in as

[PULL] drm-intel-next

2023-01-12 Thread Jani Nikula
Hi Dave & Daniel - Here's the first i915 feature pull towards v6.3. drm-intel-next-2023-01-12: drm/i915 feature pull #1 for v6.3: Features and functionality: - Meteorlake display enabling (Animesh, Luca, Stan, Jouni, Anusha) - DP MST DSC support (Stan) - Gamma/degamma readout support for the s

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-12 Thread Boris Brezillon
On Thu, 12 Jan 2023 11:42:57 +0100 Daniel Vetter wrote: > On Thu, Jan 12, 2023 at 11:25:53AM +0100, Boris Brezillon wrote: > > On Thu, 12 Jan 2023 11:11:03 +0100 > > Boris Brezillon wrote: > > > > > On Thu, 12 Jan 2023 10:32:18 +0100 > > > Daniel Vetter wrote: > > > > > > > On Thu, Jan 12

Re: [PATCH] drm/ttm: Fix a regression causing kernel oops'es

2023-01-12 Thread Zack Rusin
On Thu, 2023-01-12 at 08:01 +0100, Christian König wrote: > !! External Email > > Am 11.01.23 um 18:50 schrieb Zack Rusin: > > From: Zack Rusin > > > > The branch is explicitly taken if ttm == NULL which means that to avoid > > a null pointer reference the ttm object can not be used inside. Swit

Re: [PATCH 02/11] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-01-12 Thread Thomas Zimmermann
Hi Am 12.01.23 um 11:45 schrieb Daniel Vetter: On Thu, Jan 12, 2023 at 11:24:13AM +0100, Thomas Zimmermann wrote: Hi Am 12.01.23 um 10:59 schrieb Daniel Vetter: On Thu, Jan 12, 2023 at 10:04:48AM +0100, Thomas Zimmermann wrote: Hi Am 11.01.23 um 16:41 schrieb Daniel Vetter: This one nukes

Re: [PATCH 2/5] drm/amdgpu: Remove redundant framebuffer format check

2023-01-12 Thread Simon Ser
Reviewed-by: Simon Ser

Re: [PATCH 3/5] drm/i915: Remove redundant framebuffer format check

2023-01-12 Thread Simon Ser
The Intel counterpart is also: Reviewed-by: Simon Ser

Re: [PATCH v10 9/9] drm/bridge: it6505: Register Type C mode switches

2023-01-12 Thread Chen-Yu Tsai
On Thu, Jan 12, 2023 at 12:22 PM Pin-yen Lin wrote: > > Register USB Type-C mode switches when the "mode-switch" property and > relevant port are available in Device Tree. Configure the "lane_swap" > state based on the entered alternate mode for a specific Type-C > connector, which ends up updatin

Re: [PATCH 3/5] drm/i915: Remove redundant framebuffer format check

2023-01-12 Thread Ville Syrjälä
On Mon, Jan 09, 2023 at 07:58:06AM -0300, Maíra Canal wrote: > Now that framebuffer_check() verifies that the format is properly > supported, there is no need to check it again on i915's inside > helpers. > > Therefore, remove the redundant framebuffer format check from the > intel_framebuffer_ini

Re: [PATCH 5.10 1/1] drm/amdkfd: Check for null pointer after calling kmemdup

2023-01-12 Thread Greg KH
On Wed, Jan 04, 2023 at 07:56:33PM +0200, Dragos-Marian Panait wrote: > From: Jiasheng Jiang > > [ Upstream commit abfaf0eee97925905e742aa3b0b72e04a918fa9e ] > > As the possible failure of the allocation, kmemdup() may return NULL > pointer. > Therefore, it should be better to check the 'props2'

[PULL] drm-misc-next

2023-01-12 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the drm-misc-next PR for this week. Best regards Thomas drm-misc-next-2023-01-12: drm-misc-next for v6.3: UAPI Changes: * fourcc: Document Open Source user waiver Cross-subsystem Changes: * firmware: fix color-format selection for system framebuffers Core Change

Re: [PATCH] drm/ttm: Fix a regression causing kernel oops'es

2023-01-12 Thread Christian König
Am 12.01.23 um 13:11 schrieb Zack Rusin: On Thu, 2023-01-12 at 08:01 +0100, Christian König wrote: !! External Email Am 11.01.23 um 18:50 schrieb Zack Rusin: From: Zack Rusin The branch is explicitly taken if ttm == NULL which means that to avoid a null pointer reference the ttm object can n

[PULL] drm-misc-fixes

2023-01-12 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2023-01-12: Several fixes for amdgpu (all addressing issues with fences), yet another orientation quirk for a Lenovo device, a use-after-free fix for virtio, a regression fix in TTM and a performance regression in drm budd

[Bug 216917] hibernation regression since 6.0.18 (Ryzen-5650U incl. Radeon GPU)

2023-01-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216917 The Linux kernel's regression tracker (Thorsten Leemhuis) (regressi...@leemhuis.info) changed: What|Removed |Added C

Re: [PATCH v10 1/9] device property: Add remote endpoint to devcon matcher

2023-01-12 Thread Heikki Krogerus
On Thu, Jan 12, 2023 at 12:20:56PM +0800, Pin-yen Lin wrote: > From: Prashant Malani > > When searching the device graph for device matches, check the > remote-endpoint itself for a match. > > Some drivers register devices for individual endpoints. This allows > the matcher code to evaluate thos

Re: [PATCH v10 2/9] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2023-01-12 Thread Heikki Krogerus
On Thu, Jan 12, 2023 at 12:20:57PM +0800, Pin-yen Lin wrote: > From: Prashant Malani > > When using OF graph, the fw_devlink code will create links between the > individual port driver (cros-ec-typec here) and the parent device for > a Type-C switch (like mode-switch). Since the mode-switch will

Re: [PATCH v10 1/9] device property: Add remote endpoint to devcon matcher

2023-01-12 Thread Sakari Ailus
Hi Pin-yen, On Thu, Jan 12, 2023 at 12:20:56PM +0800, Pin-yen Lin wrote: > From: Prashant Malani > > When searching the device graph for device matches, check the > remote-endpoint itself for a match. > > Some drivers register devices for individual endpoints. This allows > the matcher code to

[PATCH] drm/nouveau: Remove support for legacy contexts/buffers

2023-01-12 Thread Thomas Zimmermann
Remove nouveau's support for legacy contexts and buffers. It was required by libdrm earlier than 2.4.33, released in March 2012. A previous attempt in 2013 to remove the functionality [1] had to be reverted [2] as there were still users left. Libdrm 2.4.33 is now almost 11 years old and it is time

Re: [PATCH] drm/nouveau: Remove support for legacy contexts/buffers

2023-01-12 Thread Thomas Zimmermann
If this patch gets accepted, I'd like to merge it via drm-misc-next together with the legacy-driver removal patches. Am 12.01.23 um 14:38 schrieb Thomas Zimmermann: Remove nouveau's support for legacy contexts and buffers. It was required by libdrm earlier than 2.4.33, released in March 2012. A

Re: [PATCH v2 13/13] drm/bridge: lt9611: properly program the dual host mode

2023-01-12 Thread Neil Armstrong
On 08/01/2023 17:56, Dmitry Baryshkov wrote: If the bridge is connected using both DSI ports, the driver should use both of them all the time. Correct programming sequence to always use dual-port mode if both dsi0 and dsi1 are connected. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bri

[PATCH] drm/amd/display: Conversion to bool not necessary

2023-01-12 Thread Deepak R Varma
A logical evaluation already results in bool. There is no need for using a ternary operator based evaluation and bool conversion of the outcome. Issue identified using boolconv.cocci Coccinelle semantic patch. This was also reported by the Kernel Test Robot. Hence Fixes: 473683a03495 ("drm/amd/dis

Re: [PATCH v2 11/13] drm/bridge: lt9611: rework infoframes handling

2023-01-12 Thread Neil Armstrong
On 08/01/2023 17:56, Dmitry Baryshkov wrote: Rework handling infoframes: - Write full HDMI AVI infoframe instead of just fixing the VIC value - Also send the HDMI Vendor Specific infoframe, as recommended by the HDMI spec. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/lontium-

Re: [PATCH 3/5] drm/i915: Remove redundant framebuffer format check

2023-01-12 Thread Maíra Canal
Hi, On 1/12/23 09:43, Ville Syrjälä wrote: On Mon, Jan 09, 2023 at 07:58:06AM -0300, Maíra Canal wrote: Now that framebuffer_check() verifies that the format is properly supported, there is no need to check it again on i915's inside helpers. Therefore, remove the redundant framebuffer format c

[PULL] drm-intel-fixes

2023-01-12 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes this week fix. There was only a small conflict in the multi-cast registers fix, but that's pretty trivial. Just go with the -gt-next version if needed on your side. drm-intel-fixes-2023-01-12: - Reserve enough fence slot for i915_vma_unbind_vsync (Nirmoy) - Fix pot

Re: [PATCH 3/5] drm/i915: Remove redundant framebuffer format check

2023-01-12 Thread Ville Syrjälä
On Thu, Jan 12, 2023 at 11:07:59AM -0300, Maíra Canal wrote: > Hi, > > On 1/12/23 09:43, Ville Syrjälä wrote: > > On Mon, Jan 09, 2023 at 07:58:06AM -0300, Maíra Canal wrote: > >> Now that framebuffer_check() verifies that the format is properly > >> supported, there is no need to check it again o

Re: [PATCH 5.10 1/1] drm/amdkfd: Check for null pointer after calling kmemdup

2023-01-12 Thread Daniel Vetter
On Thu, 12 Jan 2023 at 13:47, Greg KH wrote: > On Wed, Jan 04, 2023 at 07:56:33PM +0200, Dragos-Marian Panait wrote: > > From: Jiasheng Jiang > > > > [ Upstream commit abfaf0eee97925905e742aa3b0b72e04a918fa9e ] > > > > As the possible failure of the allocation, kmemdup() may return NULL > > point

Re: [PATCH 02/11] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-01-12 Thread Daniel Vetter
On Thu, 12 Jan 2023 at 13:15, Thomas Zimmermann wrote: > > Hi > > Am 12.01.23 um 11:45 schrieb Daniel Vetter: > > On Thu, Jan 12, 2023 at 11:24:13AM +0100, Thomas Zimmermann wrote: > >> Hi > >> > >> Am 12.01.23 um 10:59 schrieb Daniel Vetter: > >>> On Thu, Jan 12, 2023 at 10:04:48AM +0100, Thomas

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-12 Thread Daniel Vetter
On Thu, 12 Jan 2023 at 13:08, Boris Brezillon wrote: > On Thu, 12 Jan 2023 11:42:57 +0100 > Daniel Vetter wrote: > > > On Thu, Jan 12, 2023 at 11:25:53AM +0100, Boris Brezillon wrote: > > > On Thu, 12 Jan 2023 11:11:03 +0100 > > > Boris Brezillon wrote: > > > > > > > On Thu, 12 Jan 2023 10:32:18

[PATCH] drm/probe_helper: sort out poll_running vs poll_enabled

2023-01-12 Thread Dmitry Baryshkov
There are two flags attemting to guard connector polling: poll_enabled and poll_running. While poll_enabled semantics is clearly defined and fully adhered (mark that drm_kms_helper_poll_init() was called and not finalized by the _fini() call), the poll_running flag doesn't have such clearliness. T

[linux-next:master] BUILD REGRESSION 0a093b2893c711d82622a9ab27da4f1172821336

2023-01-12 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 0a093b2893c711d82622a9ab27da4f1172821336 Add linux-next specific files for 20230112 Error/Warning: (recently discovered and may have been fixed) aarch64-linux-ld: ID map text too big or

Re: [PATCH v2] drm/i915: Fix CFI violations in gt_sysfs

2023-01-12 Thread Nathan Chancellor
Hi Jocelyn, On Thu, Jan 12, 2023 at 11:08:17AM +0100, Jocelyn Falempe wrote: > This patch does also solve a kernel crash when reading > /sys/class/drm/card1/gt/gt0/* on a skylake machine: > https://bugzilla.redhat.com/show_bug.cgi?id=2154880 Interesting, I wonder what aspect of this patch fixes t

[Bug 216920] New: Running IDE eventually leads to BUG: kernel NULL pointer dereference

2023-01-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216920 Bug ID: 216920 Summary: Running IDE eventually leads to BUG: kernel NULL pointer dereference Product: Drivers Version: 2.5 Kernel Version: 6.1.4-arch1-1 Hardware: Intel

Re: [PATCH] drm: amd: display: Fix memory leakage

2023-01-12 Thread Rodrigo Siqueira Jordao
On 11/29/22 21:50, Konstantin Meskhidze wrote: This commit fixes memory leakage in dc_construct_ctx() function. Signed-off-by: Konstantin Meskhidze --- drivers/gpu/drm/amd/display/dc/core/dc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/

Re: [Intel-gfx] [PATCH 2/2] drm/ttm: replace busy placement with flags

2023-01-12 Thread Christian König
Am 11.01.23 um 16:18 schrieb Matthew Auld: [SNIP] Currently "dim rebuild-tip" doesn't work for me because of a conflict in i915_gem_execbuffer.c Seems to be working now. Nope. When I do a fresh install with "drm setup" in a different working directly I run into exactly this problem again.

Re: [PATCH] drm/amd/display: Fix set scaling doesn's work

2023-01-12 Thread Rodrigo Siqueira Jordao
On 1/11/23 10:19, Harry Wentland wrote: On 1/10/23 10:58, Rodrigo Siqueira Jordao wrote: On 11/22/22 06:20, hongao wrote: [Why] Setting scaling does not correctly update CRTC state. As a result dc stream state's src (composition area) && dest (addressable area) was not calculated as expect

[PATCH 1/1] drm: panel: Set connector type for Armadeus ST0700 Adapt panel

2023-01-12 Thread Sébastien Szymanski
The Armadeus ST0700 Adapt is a DPI panel, set the connector type accordingly. Signed-off-by: Sébastien Szymanski --- drivers/gpu/drm/panel/panel-simple.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 8a3b685

Re: [PATCH AUTOSEL 6.1 5/7] drm/amdgpu: Fix size validation for non-exclusive domains (v4)

2023-01-12 Thread Luben Tuikov
Hi Sasha, The patch in the link is a Fixes patch of the quoted patch, and should also go in: https://lore.kernel.org/all/20230104221935.113400-1-luben.tui...@amd.com/ Regards, Luben On 2022-12-31 15:04, Sasha Levin wrote: > From: Luben Tuikov > > [ Upstream commit 7554886daa31eacc8e7fac9e15b

Re: [PATCH 5.10 1/1] drm/amdkfd: Check for null pointer after calling kmemdup

2023-01-12 Thread Greg KH
On Thu, Jan 12, 2023 at 04:26:45PM +0100, Daniel Vetter wrote: > On Thu, 12 Jan 2023 at 13:47, Greg KH wrote: > > On Wed, Jan 04, 2023 at 07:56:33PM +0200, Dragos-Marian Panait wrote: > > > From: Jiasheng Jiang > > > > > > [ Upstream commit abfaf0eee97925905e742aa3b0b72e04a918fa9e ] > > > > > > A

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-12 Thread Boris Brezillon
On Thu, 12 Jan 2023 16:38:18 +0100 Daniel Vetter wrote: > > > > > > Also if you do the allocation in ->prepare_job with dma_fence and not > > > run_job, then I think can sort out fairness issues (if they do pop up) in > > > the drm/sched code instead of having to think about this in each driver.

[RFC v3 00/12] DRM scheduling cgroup controller

2023-01-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This series contains a proposal for a DRM scheduling cgroup controller which implements a weight based hierarchical GPU usage budget based controller similar in concept to some of the existing controllers. Motivation mostly comes from my earlier proposal where I identified t

[RFC 01/12] drm: Track clients by tgid and not tid

2023-01-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Thread group id (aka pid from userspace point of view) is a more interesting thing to show as an owner of a DRM fd, so track and show that instead of the thread id. In the next patch we will make the owner updated post file descriptor handover, which will also be tgid based

  1   2   >