[PATCH] amdgpu_dm_2027: Add pointer check

2022-11-11 Thread Denis Arefev
Return value of a function 'dc_create_state' is dereferenced at amdgpu_dm.c:2027 without checking for null Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Denis Arefev --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +++- 1 file changed, 3 insertions(+

[PATCH] nbio_v7_4: Add pointer check

2022-11-11 Thread Denis Arefev
Return value of a function 'amdgpu_ras_find_obj' is dereferenced at nbio_v7_4.c:325 without checking for null Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Denis Arefev --- drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH] fbdev: smscufx: fix error handling code in ufx_usb_probe

2022-11-11 Thread Dongliang Mu
The current error handling code in ufx_usb_probe have many unmatching issues, e.g., missing ufx_free_usb_list, destroy_modedb label should only include framebuffer_release, fb_dealloc_cmap only matches fb_alloc_cmap. My local syzkaller reports a memory leak bug: memory leak in ufx_usb_probe BUG:

Re: [PATCH v8 01/14] drm: exynos: dsi: Fix MIPI_DSI*_NO_* mode flags

2022-11-11 Thread Jagan Teki
On Fri, Nov 11, 2022 at 6:19 AM Nicolas Boichat wrote: > > On Fri, Nov 11, 2022 at 2:40 AM Jagan Teki wrote: > > > > HFP/HBP/HSA/EOT_PACKET modes in Exynos DSI host specifies > > 0 = Enable and 1 = Disable. > > Oh I see, that's confusing... IMHO you might want to change the > register macro name.

RE: [PATCH] nbio_v7_4: Add pointer check

2022-11-11 Thread Zhang, Hawking
[AMD Official Use Only - General] Hey, The patch does the right thing from coding principal perspective, but it is really redundant check in RAS context. The function is a hardware interrupt handler which is only triggered for specific RAS event. When software receives the interrupt, the point

[PATCH 1/5] drm/nouveau/nvfw/acr: make wpr_generic_header_dump() static

2022-11-11 Thread Jiapeng Chong
This symbol is not used outside of acr.c, so marks it static. drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: no previous prototype for ‘wpr_generic_header_dump’. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3023 Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers

[PATCH 2/5] drm/nouveau/acr: remove the unused variable loc

2022-11-11 Thread Jiapeng Chong
The variable loc is not effectively used in the function, so delete it. drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:7: warning: variable ‘loc’ set but not used. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3024 Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/g

[PATCH 3/5] drm/nouveau/fifo: make nvkm_engn_cgrp_get static

2022-11-11 Thread Jiapeng Chong
This symbol is not used outside of runl.c, so marks it static. drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c:34:1: warning: no previous prototype for ‘nvkm_engn_cgrp_get’. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3022 Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- dri

[PATCH 4/5] drm/nouveau/fifo/gf100-: make gf100_fifo_nonstall_block() static

2022-11-11 Thread Jiapeng Chong
This symbol is not used outside of gf100.c, so marks it static. drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c:451:1: warning: no previous prototype for ‘gf100_fifo_nonstall_block’. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3021 Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong

[PATCH 5/5] drm/nouveau/gr/tu102: Remove the unused function tu102_gr_load()

2022-11-11 Thread Jiapeng Chong
The function tu102_gr_load() is defined in the tu102.c file, but not called elsewhere, so remove this unused function. drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c:210:1: warning: no previous prototype for ‘tu102_gr_load’. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3020 Reported-by: A

Re: Coverity: nouveau_dp_irq(): Null pointer dereferences

2022-11-11 Thread Jani Nikula
On Thu, 10 Nov 2022, coverity-bot wrote: > Hello! > > This is an experimental semi-automated report about issues detected by > Coverity from a scan of next-20221110 as part of the linux-next scan project: > https://scan.coverity.com/projects/linux-next-weekly-scan > > You're getting this email bec

Re: [PATCH 1/5] drm/fb-helper: Set damage-clip area in helper

2022-11-11 Thread Daniel Vetter
On Thu, Nov 10, 2022 at 02:55:15PM +0100, Thomas Zimmermann wrote: > Set the damage area in the new helper drm_fb_helper_add_damage_clip(). > It can now be updated without scheduling the damage worker. This change > will help to remove the damage worker entirely. No functional changes. > > Signed-

Re: [PATCH 2/5] drm/fb-helper: Move dirty-fb update into helper function

2022-11-11 Thread Daniel Vetter
On Thu, Nov 10, 2022 at 02:55:16PM +0100, Thomas Zimmermann wrote: > Move the dirty-fb update from the damage-worker callback into the > new helper drm_fb_helper_fb_dirty(), so that it can run outside the > damage worker. This change will help to remove the damage worker > entirely. No functional c

Re: [PATCH v2 35/65] clk: ux500: sysctrl: Add a determine_rate hook

2022-11-11 Thread Linus Walleij
On Thu, Nov 10, 2022 at 2:05 PM Ulf Hansson wrote: > On Thu, 10 Nov 2022 at 12:39, Linus Walleij wrote: > > > > On Thu, Nov 10, 2022 at 12:29 PM Ulf Hansson wrote: > > > On Fri, 4 Nov 2022 at 14:32, Maxime Ripard wrote: > > > > > > > > The UX500 sysctrl "set_parent" clocks implement a mux with

Re: [PATCH 3/5] drm/fb-helper: Perform damage handling in deferred-I/O helper

2022-11-11 Thread Daniel Vetter
On Thu, Nov 10, 2022 at 02:55:17PM +0100, Thomas Zimmermann wrote: > Call fb_dirty directly from drm_fb_helper_deferred_io() to avoid the > latency of running the damage worker. > > The deferred-I/O helper drm_fb_helper_deferred_io() runs in a worker > thread at regular intervals as part of writin

Re: [PATCH 4/5] drm/fb-helper: Schedule deferred-I/O worker after writing to framebuffer

2022-11-11 Thread Daniel Vetter
On Thu, Nov 10, 2022 at 02:55:18PM +0100, Thomas Zimmermann wrote: > Schedule the deferred-I/O worker instead of the damage worker after > writing to the fbdev framebuffer. The deferred-I/O worker then performs > the dirty-fb update. The fbdev emulation will initialize deferred I/O > for all driver

Re: [PATCH 1/2] drm: Move nomodeset kernel parameter to drivers/video

2022-11-11 Thread Javier Martinez Canillas
Hello Thomas, On 11/7/22 11:49, Thomas Zimmermann wrote: [...] > > diff --git a/Documentation/admin-guide/kernel-parameters.txt > b/Documentation/admin-guide/kernel-parameters.txt > index a465d5242774a..70178c5f53956 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Docume

Re: [PATCH 5/5] drm/fb-helper: Remove damage worker

2022-11-11 Thread Daniel Vetter
On Thu, Nov 10, 2022 at 02:55:19PM +0100, Thomas Zimmermann wrote: > The fbdev damage worker is unused, so remove it. > > Signed-off-by: Thomas Zimmermann I'd squash this into the previous patch, which gets rid of the schedule_work(), if you limit the previous patch to really just that change. B

Re: [PATCH 2/2] fbdev: Add support for the nomodeset kernel parameter

2022-11-11 Thread Javier Martinez Canillas
On 11/7/22 11:49, Thomas Zimmermann wrote: > Support the kernel's nomodeset parameter for all PCI-based fbdev > drivers that use aperture helpers to remove other, hardware-agnostic > graphics drivers. > > The parameter is a simple way of using the firmware-provided scanout > buffer if the hardware

Re: [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-11 Thread Daniel Vetter
On Wed, Nov 09, 2022 at 05:44:37PM -0800, Jessica Zhang wrote: > > > On 11/9/2022 5:59 AM, Daniel Vetter wrote: > > On Wed, Nov 09, 2022 at 04:53:45PM +0300, Dmitry Baryshkov wrote: > > > On 09/11/2022 16:52, Daniel Vetter wrote: > > > > On Tue, Nov 08, 2022 at 06:25:29PM +, Simon Ser wrote:

[PATCH] drm/amd/display: remove set but unused variable 'state'

2022-11-11 Thread Jiapeng Chong
The variable state is not effectively used in the function, so delete it. drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c:1613:24: warning: variable ‘state’ set but not used. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3027#c0 Reported-by: Abaci Robot Signed-off-by: Jia

[PATCH] drm/nouveau/svm: Remove set but unused variable 'priority'

2022-11-11 Thread Jiapeng Chong
Variable priority is not effectively used in the function, so delete it. drivers/gpu/drm/nouveau/nouveau_svm.c:115:24: warning: variable 'priority' set but not used. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3028 Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu

Re: [PATCH 2/2] fbdev: Add support for the nomodeset kernel parameter

2022-11-11 Thread Javier Martinez Canillas
On 11/8/22 09:16, Thomas Zimmermann wrote: > Hi [...] > > My proposal would be to add a little helper to fbdev that includes your > suggestions: > >bool fb_modesetting_disabled(const char *drvname) >{ > fwonly = video_firmware_drivers_only() > if (fbonly && drvname) >

Re: [PATCH v4] drm/sysfs: Link DRM connectors to corresponding Type-C connectors

2022-11-11 Thread Daniel Vetter
On Thu, Nov 10, 2022 at 11:33:11AM -0800, Won Chung wrote: > Hi Daniel, > > Thank you very much for a review. > > On Wed, Nov 9, 2022 at 3:54 AM Daniel Vetter wrote: > > > > On Tue, Nov 08, 2022 at 06:50:04PM +, Won Chung wrote: > > > Create a symlink pointing to USB Type-C connector for DRM

Re: [PATCH 3/5] drm/msm: Fix IS_ERR_OR_NULL() vs NULL check in msm_icc_get()

2022-11-11 Thread Marijn Suijten
On 2022-11-10 17:44:43, Gaosheng Cui wrote: > The of_icc_get() function returns NULL or error pointers on error path, > so we should use IS_ERR_OR_NULL() to check the return value. > > Fixes: 5ccdcecaf8f7 ("drm/msm: lookup the ICC paths in both mdp5/dpu and mdss > devices") > Signed-off-by: Gaosh

[Bug 216673] Recurring amdgpu freeze on kernel 6.0.6 only

2022-11-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216673 --- Comment #6 from Michele Della Guardia (micheledellaguar...@yahoo.it) --- Update: downloaded kernel 6.0.8, applied patches found here: https://gitlab.freedesktop.org/drm/amd/-/issues/2113 and compiled. That problem seems gone. Hope to find pa

[RFC v2 README 00/13] DRM scheduling cgroup controller

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin *** vvv Read this first please vvv *** I am re-sending this to dri-devel directly, having realized neither v1 or v2 have reached dri-devel due possible SMTP server issues. Other recipients and lists however did get both v1 in October and v2 two days ago. Hence this is a re-

[RFC 03/13] drm: Update file owner during use

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin With the typical model where the display server opends the file descriptor and then hands it over to the client we were showing stale data in debugfs. Fix it by updating the drm_file->pid on ioctl access from a different process. The field is also made RCU protected to allo

[RFC 02/13] drm: Track clients by tgid and not tid

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Thread group id (aka pid from userspace point of view) is a more interesting thing to show as an owner of a DRM fd, so track and show that instead of the thread id. In the next patch we will make the owner updated post file descriptor handover, which will also be tgid based

[RFC 08/13] drm/cgroup: Add over budget signalling callback

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add a new callback via which the drm cgroup controller is notifying the drm core that a certain process is above its allotted GPU time. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/drm_cgroup.c | 21 + include/drm/drm_clients.h| 1 + include/d

[RFC 09/13] drm/cgroup: Only track clients which are providing drm_cgroup_ops

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To reduce the number of tracking going on, especially with drivers which will not support any sort of control from the drm cgroup controller side, lets express the funcionality as opt-in and use the presence of drm_cgroup_ops as activation criteria. Signed-off-by: Tvrtko Urs

[RFC 01/13] drm: Replace DRM_DEBUG with drm_dbg_core in file and ioctl handling

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Replace the deprecated macro with the per-device one. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/drm_file.c | 21 +++-- drivers/gpu/drm/drm_ioc32.c | 13 +++-- drivers/gpu/drm/drm_ioctl.c | 25 + 3 files changed, 31 i

[RFC 05/13] drm/cgroup: Track clients per owning process

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To enable propagation of settings from the cgroup drm controller to drm we need to start tracking which processes own which drm clients. Implement that by tracking the struct pid pointer of the owning process in a new XArray, pointing to a structure containing a list of asso

[RFC 10/13] cgroup/drm: Client exit hook

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We need the ability for DRM core to inform the cgroup controller when a client has closed a DRM file descriptor. This will allow us not needing to keep state relating to GPU time usage by tasks sets in the cgroup controller itself. Signed-off-by: Tvrtko Ursulin --- drivers

[RFC 04/13] cgroup: Add the DRM cgroup controller

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Skeleton controller without any functionality. Signed-off-by: Tvrtko Ursulin --- include/linux/cgroup_drm.h| 9 ++ include/linux/cgroup_subsys.h | 4 +++ init/Kconfig | 7 + kernel/cgroup/Makefile| 1 + kernel/cgroup/drm.c

[RFC 11/13] cgroup/drm: Introduce weight based drm cgroup control

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Similar to CPU scheduling, implement a concept of weight in the drm cgroup controller. Uses the same range and default as the CPU controller - CGROUP_WEIGHT_MIN, CGROUP_WEIGHT_DFL and CGROUP_WEIGHT_MAX. Later each cgroup is assigned a time budget proportionaly based on the

[RFC 13/13] drm/i915: Implement cgroup controller over budget throttling

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When notified by the drm core we are over our allotted time budget, i915 instance will check if any of the GPU engines it is reponsible for is fully saturated. If it is, and the client in question is using that engine, it will throttle it. For now throttling is done simplist

[RFC 12/13] drm/i915: Wire up with drm controller GPU time query

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Implement the drm_cgroup_ops->active_time_us callback. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_driver.c | 10 drivers/gpu/drm/i915/i915_drm_client.c | 76 ++ drivers/gpu/drm/i915/i915_drm_client.h | 2 + 3 files changed

[RFC 06/13] drm/cgroup: Allow safe external access to file_priv

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Entry points from the cgroup subsystem into the drm cgroup controller will need to walk the file_priv structures associated with registered clients and since those are not RCU protected lets add a hack for now to make this safe. Signed-off-by: Tvrtko Ursulin --- drivers/gp

[RFC 07/13] drm/cgroup: Add ability to query drm cgroup GPU time

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add a driver callback and core helper which allow querying the time spent on GPUs for processes belonging to a group. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/drm_cgroup.c | 24 include/drm/drm_clients.h| 2 ++ include/drm/drm_drv.h

Re: [PATCH printk v3 33/40] printk, xen: fbfront: create/use safe function for forcing preferred

2022-11-11 Thread Petr Mladek
On Mon 2022-11-07 15:22:31, John Ogness wrote: > With commit 9e124fe16ff2("xen: Enable console tty by default in domU > if it's not a dummy") a hack was implemented to make sure that the > tty console remains the console behind the /dev/console device. The > main problem with the hack is that, afte

Re: [PATCH 2/2] fbdev: Add support for the nomodeset kernel parameter

2022-11-11 Thread Helge Deller
On 11/11/22 10:49, Javier Martinez Canillas wrote: On 11/8/22 09:16, Thomas Zimmermann wrote: Hi [...] My proposal would be to add a little helper to fbdev that includes your suggestions: bool fb_modesetting_disabled(const char *drvname) { fwonly = video_firmware_drivers_onl

[syzbot] inconsistent lock state in trace_hardirqs_on

2022-11-11 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:bbed346d5a96 Merge branch 'for-next/core' into for-kernelci git tree: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci console output: https://syzkaller.appspot.com/x/log.txt?x=14c82f3988 kernel confi

[Bug 216673] Recurring amdgpu freeze on kernel 6.0.6 only

2022-11-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216673 --- Comment #7 from Stanislav Modrak (stanislav.mod...@gmail.com) --- (In reply to Michele Della Guardia from comment #6) > Update: downloaded kernel 6.0.8, applied patches found here: > > https://gitlab.freedesktop.org/drm/amd/-/issues/2113 > >

Re: [PATCH 2/2] fbdev: Add support for the nomodeset kernel parameter

2022-11-11 Thread Thomas Zimmermann
Hi Am 11.11.22 um 11:49 schrieb Helge Deller: On 11/11/22 10:49, Javier Martinez Canillas wrote: On 11/8/22 09:16, Thomas Zimmermann wrote: Hi [...] My proposal would be to add a little helper to fbdev that includes your suggestions:     bool fb_modesetting_disabled(const char *drvname)

Re: [PATCH v5 5/6] drm/mediatek: add mediatek-drm of vdosys0 support for mt8195

2022-11-11 Thread Matthias Brugger
On 27/09/2022 17:27, Jason-JH.Lin wrote: Add driver data of mt8195 vdosys0 to mediatek-drm and the sub driver. Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 28 2 files changed, 34

Re: [PATCH] drm/amdgpu: Fix memory leak in amdgpu_cs_pass1

2022-11-11 Thread Christian König
Am 10.11.22 um 15:33 schrieb Dong Chenchen: When p->gang_size equals 0, amdgpu_cs_pass1() will return directly without freeing chunk_array, which will cause a memory leak issue, this patch fixes it. Fixes: 4624459c84d7 ("drm/amdgpu: add gang submit frontend v6") Signed-off-by: Dong Chenchen G

Re: [PATCH] udmabuf: add vmap method to udmabuf_ops

2022-11-11 Thread Christian König
Adding Dmitry as well. Am 11.11.22 um 12:45 schrieb Lukasz Wiecaszek: The reason behind that patch is associated with videobuf2 subsystem (or more genrally with v4l2 framework) and user created dma buffers (udmabuf). In some circumstances when dealing with V4L2_MEMORY_DMABUF buffers videobuf2 su

Re: [PATCH v8 01/14] drm: exynos: dsi: Fix MIPI_DSI*_NO_* mode flags

2022-11-11 Thread Nicolas Boichat
On Fri, Nov 11, 2022 at 4:49 PM Jagan Teki wrote: > > On Fri, Nov 11, 2022 at 6:19 AM Nicolas Boichat wrote: > > > > On Fri, Nov 11, 2022 at 2:40 AM Jagan Teki > > wrote: > > > > > > HFP/HBP/HSA/EOT_PACKET modes in Exynos DSI host specifies > > > 0 = Enable and 1 = Disable. > > > > Oh I see, th

Re: [PATCH] udmabuf: add vmap method to udmabuf_ops

2022-11-11 Thread Dmitry Osipenko
On 11/11/22 15:05, Christian König wrote: > Adding Dmitry as well. > > Am 11.11.22 um 12:45 schrieb Lukasz Wiecaszek: >> The reason behind that patch is associated with videobuf2 subsystem >> (or more genrally with v4l2 framework) and user created >> dma buffers (udmabuf). In some circumstances >>

Re: [PATCH 1/2] drm: Move nomodeset kernel parameter to drivers/video

2022-11-11 Thread Thomas Zimmermann
Hi Am 11.11.22 um 10:28 schrieb Javier Martinez Canillas: Hello Thomas, On 11/7/22 11:49, Thomas Zimmermann wrote: [...] diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index a465d5242774a..70178c5f53956 100644 --- a/Documentat

Re: [PATCH v1 3/9] drm/msm/dpu: Add SM8350 to hw catalog

2022-11-11 Thread Robert Foss
On Fri, 28 Oct 2022 at 14:27, Dmitry Baryshkov wrote: > > On 28/10/2022 15:08, Robert Foss wrote: > > Add compatibility for SM8350 display subsystem, including > > required entries in DPU hw catalog. > > --- > > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 217 ++ > > .../gpu

Re: [PATCH v8 01/14] drm: exynos: dsi: Fix MIPI_DSI*_NO_* mode flags

2022-11-11 Thread Jagan Teki
On Fri, Nov 11, 2022 at 5:42 PM Nicolas Boichat wrote: > > On Fri, Nov 11, 2022 at 4:49 PM Jagan Teki wrote: > > > > On Fri, Nov 11, 2022 at 6:19 AM Nicolas Boichat > > wrote: > > > > > > On Fri, Nov 11, 2022 at 2:40 AM Jagan Teki > > > wrote: > > > > > > > > HFP/HBP/HSA/EOT_PACKET modes in E

Re: [PATCH v1 1/6] dma-buf: Move dma_buf_mmap_internal() to dynamic locking specification

2022-11-11 Thread Christian König
Am 10.11.22 um 21:13 schrieb Dmitry Osipenko: All dma-buf functions has been moved to dynamic locking specification The dma_buf_mmap_internal() was missed out by accident. Take reservation lock around file mapping operation to adhere the common locking convention. Reported-by: Daniel Vetter Sig

Re: [PATCH 1/2] drm: Move nomodeset kernel parameter to drivers/video

2022-11-11 Thread Thomas Zimmermann
Hi Am 11.11.22 um 10:28 schrieb Javier Martinez Canillas: Hello Thomas, On 11/7/22 11:49, Thomas Zimmermann wrote: [...] diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index a465d5242774a..70178c5f53956 100644 --- a/Documentat

Re: [RFC 02/13] drm: Track clients by tgid and not tid

2022-11-11 Thread Zack Rusin
On Fri, 2022-11-11 at 10:44 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Thread group id (aka pid from userspace point of view) is a more > interesting thing to show as an owner of a DRM fd, so track and show that > instead of the thread id. > > In the next patch we will make the owne

Re: [PATCH 2/2] fbdev: Add support for the nomodeset kernel parameter

2022-11-11 Thread Helge Deller
On 11/11/22 12:42, Thomas Zimmermann wrote: Hi Am 11.11.22 um 11:49 schrieb Helge Deller: On 11/11/22 10:49, Javier Martinez Canillas wrote: On 11/8/22 09:16, Thomas Zimmermann wrote: Hi [...] My proposal would be to add a little helper to fbdev that includes your suggestions:     bool

[PATCH v2 0/2] video/fbdev: Support 'nomodeset' in PCI drivers

2022-11-11 Thread Thomas Zimmermann
Add support for the kernel's 'nomodeset' parameter to PCI-based fbdev drivers. The option prevents DRM drivers from loading if they could possibly displace a hardware-agnostic driver that runs on the firmware framebuffer. It is a fallback for systems on which the hardware's native driver does not w

[PATCH v2 1/2] drm: Move nomodeset kernel parameter to drivers/video

2022-11-11 Thread Thomas Zimmermann
Move the nomodeset kernel parameter to drivers/video to make it available to non-DRM drivers. Adapt the interface, but keep the DRM interface drm_firmware_drivers_only() to avoid churn within DRM. The function should later be inlined into callers. The parameter disables any DRM graphics driver tha

[PATCH v2 2/2] fbdev: Add support for the nomodeset kernel parameter

2022-11-11 Thread Thomas Zimmermann
Support the kernel's nomodeset parameter for all PCI-based fbdev drivers that use aperture helpers to remove other, hardware-agnostic graphics drivers. The parameter is a simple way of using the firmware-provided scanout buffer if the hardware's native driver is broken. The same effect could be ac

Re: [PATCH v1 6/9] arm64: dts: qcom: sm8350: Use 2 interconnect cells

2022-11-11 Thread Robert Foss
On Fri, 28 Oct 2022 at 15:44, Bjorn Andersson wrote: > > On Fri, Oct 28, 2022 at 02:08:09PM +0200, Robert Foss wrote: > > Use two interconnect cells in order to optionally > > support a path tag. > > > > Signed-off-by: Robert Foss > > --- > > arch/arm64/boot/dts/qcom/sm8350.dtsi | 20 ++-

RE: [PATCH 4/4] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-11 Thread Kalyan Thota
>-Original Message- >From: Dmitry Baryshkov >Sent: Wednesday, November 9, 2022 6:02 PM >To: Kalyan Thota (QUIC) ; dri- >de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; >freedr...@lists.freedesktop.org; devicet...@vger.kernel.org >Cc: linux-ker...@vger.kernel.org; robdcl...@ch

[v9] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2022-11-11 Thread Kalyan Thota
Flush mechanism for DSPP blocks has changed in sc7280 family, it allows individual sub blocks to be flushed in coordination with master flush control. Representation: master_flush && (PCC_flush | IGC_flush .. etc ) This change adds necessary support for the above design. Changes in v1: - Few nit

[v1] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder

2022-11-11 Thread Kalyan Thota
Pin each crtc with one encoder. This arrangement will disallow crtc switching between encoders and also will facilitate to advertise certain features on crtc based on encoder type. Changes in v1: - use drm_for_each_encoder macro while iterating through encoder list (Dmitry) Signed-off-by: Kalya

[v1] drm/msm/disp/dpu1: populate disp_info with connector type

2022-11-11 Thread Kalyan Thota
Populate disp_info with connector type. Since DRM encoder type for few encoders can be similar (like eDP and DP) this information will be useful to differentiate interfaces. Changes in v1: - add connector type in the disp_info (Dmitry) - add helper functions to know encoder type - update commit te

[v1] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-11 Thread Kalyan Thota
Add color management support for the crtc provided there are enough dspps that can be allocated from the catalogue. Changes in v1: - cache color enabled state in the dpu crtc obj (Dmitry) - simplify dspp allocation while creating crtc (Dmitry) - register for color when crtc is created (Dmitry) Si

Re: [PATCH 10/26] drm: imx/dcss: Remove #ifdef guards for PM related functions

2022-11-11 Thread Laurentiu Palcu
Hi Paul, On Mon, Nov 07, 2022 at 05:50:50PM +, Paul Cercueil wrote: > Use the EXPORT_GPL_DEV_PM_OPS() and pm_ptr() macros to handle the PM > callbacks. > > These macros allow the PM functions to be automatically dropped by the > compiler when CONFIG_PM is disabled, without having to use #ifde

Re: [RESEND PATCH] drm/tegra: switch to using devm_fwnode_gpiod_get()

2022-11-11 Thread Thierry Reding
From: Thierry Reding On Mon, 7 Nov 2022 20:41:42 -0800, Dmitry Torokhov wrote: > devm_gpiod_get_from_of_node() is going away and GPIO consumers should > use generic device/firmware node APIs to fetch GPIOs assigned to them. > Switch the driver to use devm_fwnode_gpiod_get() instead. > > Applie

[Bug 216625] [regression] GPU lockup on Radeon R7 Kaveri

2022-11-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216625 --- Comment #6 from Alex Deucher (alexdeuc...@gmail.com) --- (In reply to Pierre Ossman from comment #5) > > Could the issue be with the firmware? Has that changed recently for these > devices? > > The last good firmware should be: > > linux-

Re: [PATCH] amdgpu_dm_2027: Add pointer check

2022-11-11 Thread Harry Wentland
The commit title should user the drm/amd/display prefix. It might also be good to be more specific, like: drm/amd/display: Check dc_resource_state_construct succeeded On 11/11/22 02:14, Denis Arefev wrote: > Return value of a function 'dc_create_state' is > dereferenced at amdgpu_dm.c:2027 without

Re: [PATCH v1 7/9] arm64: dts: qcom: sm8350: Add display system nodes

2022-11-11 Thread Robert Foss
On Sat, 29 Oct 2022 at 00:01, Krzysztof Kozlowski wrote: > > On 28/10/2022 08:08, Robert Foss wrote: > > Add mdss, mdss_mdp, dsi0, dsi0_phy nodes. With these > > nodes the display subsystem is configured to support > > one DSI output. > > > > Signed-off-by: Robert Foss > > --- > > arch/arm64/boo

Re: [PATCH v1 8/9] arm64: dts: qcom: sm8350-hdk: Enable display & dsi nodes

2022-11-11 Thread Robert Foss
On Sat, 29 Oct 2022 at 00:03, Krzysztof Kozlowski wrote: > > On 28/10/2022 08:08, Robert Foss wrote: > > Enable the display subsystem and the dsi0 output for > > the sm8350-hdk board. > > > > Signed-off-by: Robert Foss > > --- > > arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 22

Re: [PATCH v1 9/9] arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge

2022-11-11 Thread Robert Foss
On Fri, 28 Oct 2022 at 15:57, Bjorn Andersson wrote: > > On Fri, Oct 28, 2022 at 02:08:12PM +0200, Robert Foss wrote: > > The sm8350-hdk ships with the LT9611 UXC DSI/HDMI bridge chip. > > > > In order to toggle the board to enable the HDMI output, > > switch #7 & #8 on the rightmost multi-switch

Re: [PATCH v1 9/9] arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge

2022-11-11 Thread Robert Foss
On Sat, 29 Oct 2022 at 00:06, Krzysztof Kozlowski wrote: > > On 28/10/2022 08:08, Robert Foss wrote: > > The sm8350-hdk ships with the LT9611 UXC DSI/HDMI bridge chip. > > > > In order to toggle the board to enable the HDMI output, > > switch #7 & #8 on the rightmost multi-switch package have > >

Re: [Intel-gfx] [PATCH 0/3] Add _PICK_EVEN_RANGES

2022-11-11 Thread Jani Nikula
On Fri, 21 Oct 2022, Lucas De Marchi wrote: > On Wed, Oct 12, 2022 at 12:05:31PM -0700, Lucas De Marchi wrote: >>On Wed, Oct 12, 2022 at 11:51:48AM +0300, Jani Nikula wrote: >>>On Tue, 11 Oct 2022, Lucas De Marchi wrote: Add a new macro, _PICK_EVEN_RANGES, that supports using 2 address ra

Re: [PATCH v2.5] drm/msm/dsi: switch to DRM_PANEL_BRIDGE

2022-11-11 Thread Caleb Connolly
Hi, This patch has caused a regression on 6.1-rc for some devices that use DSI panels. The new behaviour results in the DSI controller being switched off before the panel unprepare hook is called. As a result, panel drivers which call mipi_dsi_dcs_write() or similar in unprepare() fail. I'v

[PATCH i-g-t 0/8] Vendor agnostic gputop

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This is a pile of patches which implements a rudimentary vendor agnostic gputop tool based of the new DRM spec as documented in Documentation/gpu/drm-usage-stats.rst. First part of the series is code refactoring which should be reasonably stable. I've tested it all while wor

[PATCH i-g-t 1/8] lib: Extract igt_drm_clients from intel_gpu_top

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Extract some code into a new library to prepare for further work towards making a vendor agnostic gputop tool. Signed-off-by: Tvrtko Ursulin --- lib/igt_drm_clients.c | 432 ++ lib/igt_drm_clients.h | 85 +++ lib/meson.build | 8

[PATCH i-g-t 6/8] libdrmclient/intel_gpu_top: Decouple hardcoded engine assumptions

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Intel_gpu_top gets it's main engine configuration data via PMU probe and uses that for per client view as well. Furthemore code so far assumed only clients belonging from a single DRM card would be tracked in a single clients list. Break this inter-dependency by moving the e

[PATCH i-g-t 2/8] libdrmfdinfo: Allow specifying custom engine map

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Instead of hard coding the engine names, allow a map of names to indices to either be passed in or it gets auto-detected (less efficient) while parsing. --- lib/igt_drm_clients.c | 18 +--- lib/igt_drm_clients.h | 3 ++- lib/igt_drm_fdinfo.c| 48

[PATCH i-g-t 4/8] libdrmclient: Support multiple DRM cards

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Require DRM minor match during client lookup. Signed-off-by: Tvrtko Ursulin --- lib/igt_drm_clients.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/igt_drm_clients.c b/lib/igt_drm_clients.c index c23a3fae9793..e11c8b18188f 100644 --

[PATCH i-g-t 3/8] libdrmclients: Record client drm minor

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Prepare for supporting clients belonging to multiple DRM cards by storing the DRM minor in the client record. Signed-off-by: Tvrtko Ursulin --- lib/igt_drm_clients.c | 22 ++ lib/igt_drm_clients.h | 1 + 2 files changed, 15 insertions(+), 8 deletions(-

[PATCH i-g-t 5/8] libdrmfdinfo: Track largest engine index

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Prep code for incoming work. Signed-off-by: Tvrtko Ursulin --- lib/igt_drm_fdinfo.c | 2 ++ lib/igt_drm_fdinfo.h | 1 + 2 files changed, 3 insertions(+) diff --git a/lib/igt_drm_fdinfo.c b/lib/igt_drm_fdinfo.c index 68c89ad2c17e..b850d2210ae7 100644 --- a/lib/igt_drm_fdin

[PATCH i-g-t 7/8] libdrmclient: Enforce client status sort order in the library

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Some libdrmclient operations require that inactive clients are last in the list. Rather than relying on callers of the library sort routine to implement their comparison callbacks correctly, enforce this order directly in the library and let callers comparison callbacks conce

[PATCH i-g-t 8/8] gputop: Basic vendor agnostic GPU top tool

2022-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Rudimentary vendor agnostic example of how lib_igt_drm_clients can be used to display a sorted by card and usage list of processes using GPUs. Borrows a bit of code from intel_gpu_top but for now omits the fancy features like interactive functionality, card selection, client

Re: [PATCH v3 1/2] drm_bridge: register content protect property

2022-11-11 Thread Sean Paul
On Wed, Nov 02, 2022 at 07:11:46PM +0800, Hsin-Yi Wang wrote: > Some bridges are able to update HDCP status from userspace request if > they support HDCP. > > HDCP property is the same as other connector properties that needs to be > created after the connecter is initialized and before the connec

Re: [PATCH v3 2/2] drm/bridge: anx7625: register content protect property

2022-11-11 Thread Sean Paul
On Wed, Nov 02, 2022 at 07:11:47PM +0800, Hsin-Yi Wang wrote: > Set support_hdcp so the connector can register content protect proterty > when it's initializing. > Reviewed-by: Sean Paul > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 1 + > 1 file changed, 1

Re: [git pull] drm fixes for 6.1-rc5

2022-11-11 Thread pr-tracker-bot
The pull request you sent on Fri, 11 Nov 2022 12:18:21 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-11-11 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/fd979ca691715891a979ce12d1a485b108af74d3 Thank you! -- Deet-doot-dot, I am a bot. https://k

Re: [PATCH] drm/virtio: Fix memory leak in virtio_gpu_object_create()

2022-11-11 Thread Dmitry Osipenko
On 11/9/22 12:19, Xiu Jianfeng wrote: > The virtio_gpu_object_shmem_init() will alloc memory and save it in > @ents, so when virtio_gpu_array_alloc() fails, this memory should be > freed, this patch fixes it. > > Fixes: e7fef0923303 ("drm/virtio: Simplify error handling of > virtio_gpu_object_cre

[linux-next:master] BUILD REGRESSION f8f60f322f0640c8edda2942ca5f84b7a27c417a

2022-11-11 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: f8f60f322f0640c8edda2942ca5f84b7a27c417a Add linux-next specific files for 2022 Error/Warning reports: https://lore.kernel.org/linux-mm/202210261404.b6ulzg7h-...@intel.com https

Re: Coverity: nouveau_dp_irq(): Null pointer dereferences

2022-11-11 Thread Kees Cook
On Fri, Nov 11, 2022 at 11:13:17AM +0200, Jani Nikula wrote: > On Thu, 10 Nov 2022, coverity-bot wrote: > > Hello! > > > > This is an experimental semi-automated report about issues detected by > > Coverity from a scan of next-20221110 as part of the linux-next scan > > project: > > https://scan.

Re: [PATCH printk v3 00/40] reduce console_lock scope

2022-11-11 Thread Mathieu Desnoyers
On 2022-11-07 09:15, John Ogness wrote: [...] The base commit for this series is from Paul McKenney's RCU tree and provides an NMI-safe SRCU implementation [1]. Without the NMI-safe SRCU implementation, this series is not less safe than mainline. But we will need the NMI-safe SRCU implementation

[PATCH] udmabuf: add vmap method to udmabuf_ops

2022-11-11 Thread Lukasz Wiecaszek
The reason behind that patch is associated with videobuf2 subsystem (or more genrally with v4l2 framework) and user created dma buffers (udmabuf). In some circumstances when dealing with V4L2_MEMORY_DMABUF buffers videobuf2 subsystem wants to use dma_buf_vmap() method on the attached dma buffer. As

Re: Coverity: nouveau_dp_irq(): Null pointer dereferences

2022-11-11 Thread Karol Herbst
On Fri, Nov 11, 2022 at 8:21 PM Kees Cook wrote: > > On Fri, Nov 11, 2022 at 11:13:17AM +0200, Jani Nikula wrote: > > On Thu, 10 Nov 2022, coverity-bot wrote: > > > Hello! > > > > > > This is an experimental semi-automated report about issues detected by > > > Coverity from a scan of next-2022111

Re: Coverity: nouveau_dp_irq(): Null pointer dereferences

2022-11-11 Thread Kees Cook
On Fri, Nov 11, 2022 at 09:06:54PM +0100, Karol Herbst wrote: > On Fri, Nov 11, 2022 at 8:21 PM Kees Cook wrote: > > > > On Fri, Nov 11, 2022 at 11:13:17AM +0200, Jani Nikula wrote: > > > On Thu, 10 Nov 2022, coverity-bot wrote: > > > > Hello! > > > > > > > > This is an experimental semi-automate

[pull] amdgpu, amdkfd, radeon drm-next-6.2

2022-11-11 Thread Alex Deucher
Hi Dave, Daniel, More new stuff for 6.2. The following changes since commit a143bc517bf31c4575191efbaac216a11ec016e0: Merge branch '00.06-gr-ampere' of https://gitlab.freedesktop.org/skeggsb/nouveau into drm-next (2022-11-09 11:18:56 +1000) are available in the Git repository at: https:/

[PATCH V5 0/3] drm/panel: Add NewVision NV3051D Panels

2022-11-11 Thread Chris Morgan
From: Chris Morgan Add the NewVision NV3051D panel as found on the Anbernic RG353P and RG353V. The underlying LCD panel itself is unknown (the NV3051D is the controller), so the device name is used for the panel with a fallback to the driver IC. Changes from V4: - Removed "prepared" as its trac

[PATCH V5 1/3] dt-bindings: vendor-prefixes: add NewVision vendor prefix

2022-11-11 Thread Chris Morgan
From: Chris Morgan NewVision (also sometimes written as New Vision) is a company based in Shenzen that manufactures ICs for controlling LCD panels. https://www.newvisiondisplay.com/ Signed-off-by: Chris Morgan Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/vendor-prefixe

[PATCH V5 3/3] drm/panel: Add NewVision NV3051D MIPI-DSI LCD panel

2022-11-11 Thread Chris Morgan
From: Chris Morgan Support NewVision NV3051D panels as found on the Anbernic RG353P and RG353V. The underlying LCD part number for the RG353x devices is unknown, so the device name and a fallback for the driver IC is used instead. Signed-off-by: Chris Morgan --- drivers/gpu/drm/panel/Kconfig

[PATCH V5 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

2022-11-11 Thread Chris Morgan
From: Chris Morgan Add documentation for the NewVision NV3051D panel bindings. Note that for the two expected consumers of this panel binding the underlying LCD model is unknown. Name "anbernic,rg353p-panel" is used because the hardware itself is known as "anbernic,rg353p". Signed-off-by: Chris

  1   2   >