RE: [PATCH 01/10] vfio: Move vfio_device driver open/close code to a function

2022-11-01 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Wednesday, October 26, 2022 2:17 AM > > This error unwind is getting complicated. Move all the code into two > pair'd function. The functions should be called when the open_count == 1 > after incrementing/before decrementing. > > Signed-off-by: Jason Gunthorpe R

RE: [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()

2022-11-01 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Wednesday, October 26, 2022 2:17 AM > > +err_container: > + vfio_device_unassign_container(device); > err_module_put: > device->kvm = NULL; err_module_put should be moved after nullifying device->kvm. otherwise it looks good to me: Reviewed-by: Kevin

RE: [PATCH 03/10] vfio: Rename vfio_device_assign/unassign_container()

2022-11-01 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Wednesday, October 26, 2022 2:17 AM > > These functions don't really assign anything anymore, they just increment > some refcounts and do a sanity check. Call them > vfio_group_[un]use_container() > > Signed-off-by: Jason Gunthorpe Reviewed-by: Kevin Tian

RE: [PATCH 05/10] vfio: Use IOMMU_CAP_ENFORCE_CACHE_COHERENCY for vfio_file_enforced_coherent()

2022-11-01 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Wednesday, October 26, 2022 2:17 AM > > iommufd doesn't establish the iommu_domains until after the device FD is > opened, even if the container has been set. This design is part of moving > away from the group centric iommu APIs. > > This is fine, except that the

RE: [PATCH 06/10] vfio-iommufd: Allow iommufd to be used in place of a container fd

2022-11-01 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Wednesday, October 26, 2022 2:51 AM > > menuconfig VFIO > tristate "VFIO Non-Privileged userspace driver framework" > select IOMMU_API > + depends on IOMMUFD || !IOMMUFD Out of curiosity. What is the meaning of this dependency claim? > @@ -717,12

RE: [PATCH 07/10] vfio-iommufd: Support iommufd for physical VFIO devices

2022-11-01 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Wednesday, October 26, 2022 2:51 AM > > +int vfio_iommufd_bind(struct vfio_device *vdev, struct iommufd_ctx *ictx) > +{ > + u32 ioas_id; > + u32 device_id; > + int ret; > + > + lockdep_assert_held(&vdev->dev_set->lock); > + > + /* > + * If

RE: [PATCH 08/10] vfio-iommufd: Support iommufd for emulated VFIO devices

2022-11-01 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Wednesday, October 26, 2022 2:51 AM > > Emulated VFIO devices are calling vfio_register_emulated_iommu_dev() and > consist of all the mdev drivers. > > Like the physical drivers, support for iommufd is provided by the driver > supplying the correct correct standar

[Bug 216645] Fence fallback timer expired on ring gfx

2022-11-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216645 --- Comment #7 from Martin Šušla (ask4supp...@email.cz) --- Sure, the GPU (at :03:00.0) being initialized before the message mentioned in the title appears is the dGPU. Line 1078 in the "Kernel log created by the script in the menuentry" confi

RE: [PATCH 09/10] vfio: Make vfio_container optionally compiled

2022-11-01 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Wednesday, October 26, 2022 2:51 AM > > if VFIO > +config VFIO_CONTAINER > + bool "Support for the VFIO container /dev/vfio/vfio" > + select VFIO_IOMMU_TYPE1 if MMU && (X86 || S390 || ARM || > ARM64) > + default y > + help > + The VFIO contai

[PATCH v8 2/4] drm/loongson: Add GPIO and I2C driver for loongson drm.

2022-11-01 Thread lichenyang_ls
Implement use GPIO and I2C driver to detect connector and fetch EDID via DDC. v5: - Use braidge->ddc to get EDID and detect connector. v4: - Delete the gpio_chip subsystem call. - Delete some redundant prints. v3: - Change some driver log to the drm_ version. v2: - Optimize the error handling p

[PATCH 2/2] drm: Fix potential null-ptr-deref in drm_vblank_destroy_worker()

2022-11-01 Thread Shang XiaoJing
drm_vblank_init() call drmm_add_action_or_reset() with drm_vblank_init_release() as action. If __drmm_add_action() failed, will directly call drm_vblank_init_release() with the vblank whose worker is NULL. As the resule, a null-ptr-deref will happen in kthread_destroy_worker(). Add the NULL check b

[PATCH 0/2] frm: Fix some bugs in drm

2022-11-01 Thread Shang XiaoJing
A memleak and a null-ptr-deref are found and fixed by this patch. Shang XiaoJing (2): drm/drv: Fix potential memory leak in drm_dev_init() drm: Fix potential null-ptr-deref in drm_vblank_destroy_worker() drivers/gpu/drm/drm_drv.c | 2 +- drivers/gpu/drm/drm_internal.h | 3 ++- 2 files c

[PATCH v8 1/4] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip

2022-11-01 Thread lichenyang_ls
From: Chenyang Li This patch adds an initial DRM driver for the Loongson LS7A1000 bridge chip(LS7A). The Loongson 7A1000 bridge chip is Loongson’s first dedicated chipset product, providing north-south bridge functionality for Loongson processors. The bridge chip is connected to the Loongson Seri

Re: [RESEND PATCH v2] drm/bridge: dw-hdmi-i2s: set insert_pcuv bit if hardware supports it

2022-11-01 Thread Geraldo Nascimento
On Mon, Oct 31, 2022 at 09:20:36AM +0100, Neil Armstrong wrote: > Hi, > Hi Neil and thanks for caring. > > On 17/10/2022 14:04, Geraldo Nascimento wrote: > > Hi Mark, resending this as it failed to apply in my last submission. Added > > Neil Armstrong to Cc: as hopefully he will be able to bette

[PATCH 1/2] drm/drv: Fix potential memory leak in drm_dev_init()

2022-11-01 Thread Shang XiaoJing
drm_dev_init() will add drm_dev_init_release() as a callback. When drmm_add_action() failed, the release function won't be added. As the result, the ref cnt added by device_get() in drm_dev_init() won't be put by drm_dev_init_release(), which leads to the memleak. Use drmm_add_action_or_reset() ins

[PATCH v8 3/4] drm/loongson: Add interrupt driver for LS7A.

2022-11-01 Thread lichenyang_ls
Add LS7A DC vsync interrupt enable and close function, and register irq_handler function interface. Add vbrank event processing flow. v4: - Replace drm_irq_install with devm_request_irq. - Delete the irq_ hooks in drm_driver. v3: - Improve code readability. - Use the to_pci_dev function to get pc

[PATCH v8 4/4] drm/loongson: Use acpi to get video bios.

2022-11-01 Thread lichenyang_ls
Add get video bios from the ACPI table. Define new acpi table "VIAT" for loongson video bios. Signed-off-by: Chenyang Li --- drivers/gpu/drm/loongson/Makefile | 3 +- drivers/gpu/drm/loongson/loongson_drv.c | 21 +++- drivers/gpu/drm/loongson/loongson_drv.h | 1 + drivers/gpu/d

Re: [Intel-gfx] [PATCH v7 0/9] dyndbg: drm.debug adaptation

2022-11-01 Thread Ville Syrjälä
On Mon, Oct 31, 2022 at 08:20:54PM -0400, Jason Baron wrote: > > > On 10/31/22 6:11 PM, jim.cro...@gmail.com wrote: > > On Mon, Oct 31, 2022 at 7:07 AM Ville Syrjälä > > wrote: > >> On Sun, Oct 30, 2022 at 08:42:52AM -0600, jim.cro...@gmail.com wrote: > >>> On Thu, Oct 27, 2022 at 2:10 PM Ville

Re: [PATCH v3 2/7] drm/ivpu: Add Intel VPU MMU support

2022-11-01 Thread Thomas Zimmermann
Hi Am 24.09.22 um 17:11 schrieb Jacek Lawrynowicz: VPU Memory Management Unit is based on ARM MMU-600. It allows to create multiple virtual address spaces for the device and map noncontinuous host memory (there is no dedicated memory on the VPU). Address space is implemented as a struct ivpu_mm

Re: [PATCH v3 RESEND 0/7] New DRM driver for Intel VPU

2022-11-01 Thread Thomas Zimmermann
Hi Am 24.09.22 um 17:11 schrieb Jacek Lawrynowicz: Hi, This patchset contains a new Linux* Kernel Driver for Intel® VPUs. VPU stands for Versatile Processing Unit and it is an AI inference accelerator integrated with Intel non-server CPUs starting from 14th generation. VPU enables efficient ex

Re: [PATCH v3 2/7] drm/ivpu: Add Intel VPU MMU support

2022-11-01 Thread Thomas Zimmermann
Hi Am 24.09.22 um 17:11 schrieb Jacek Lawrynowicz: VPU Memory Management Unit is based on ARM MMU-600. It allows to create multiple virtual address spaces for the device and map noncontinuous host memory (there is no dedicated memory on the VPU). Address space is implemented as a struct ivpu_mm

RE: [PATCH v1 4/7] vfio/ccw: move private to mdev lifecycle

2022-11-01 Thread Tian, Kevin
> From: Eric Farman > Sent: Thursday, October 20, 2022 12:22 AM > > @@ -101,15 +101,20 @@ static int vfio_ccw_mdev_probe(struct > mdev_device *mdev) > { > struct subchannel *sch = to_subchannel(mdev->dev.parent); > struct vfio_ccw_parent *parent = dev_get_drvdata(&sch->dev); > -

RE: [PATCH v1 5/7] vfio/ccw: remove release completion

2022-11-01 Thread Tian, Kevin
> From: Eric Farman > Sent: Thursday, October 20, 2022 12:22 AM > > There's enough separation between the parent and private structs now, > that it is fine to remove the release completion hack. > > Signed-off-by: Eric Farman Reviewed-by: Kevin Tian

RE: [PATCH v1 6/7] vfio/ccw: replace vfio_init_device with _alloc_

2022-11-01 Thread Tian, Kevin
> From: Eric Farman > Sent: Thursday, October 20, 2022 12:22 AM > > Now that we have a reasonable separation of structs that follow > the subchannel and mdev lifecycles, there's no reason we can't > call the official vfio_alloc_device routine for our private data, > and behave like everyone else.

RE: [PATCH v1 7/7] vfio: Remove vfio_free_device

2022-11-01 Thread Tian, Kevin
> From: Eric Farman > Sent: Thursday, October 20, 2022 12:22 AM > > With the "mess" sorted out, we should be able to inline the > vfio_free_device call introduced by commit cb9ff3f3b84c > ("vfio: Add helpers for unifying vfio_device life cycle") > and remove them from driver release callbacks. >

Re: [PATCH 06/10] vfio-iommufd: Allow iommufd to be used in place of a container fd

2022-11-01 Thread Nicolin Chen
On Tue, Nov 01, 2022 at 08:09:52AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, October 26, 2022 2:51 AM > > > > menuconfig VFIO > > tristate "VFIO Non-Privileged userspace driver framework" > > select IOMMU_API > > + depends on IOMMUFD || !IOMMUFD >

[PATCH 0/6] Add DP MST DSC support to i915

2022-11-01 Thread Stanislav Lisovskiy
Currently we have only DSC support for DP SST. Stanislav Lisovskiy (6): drm: Add missing DP DSC extended capability definitions. drm/i915: Fix intel_dp_mst_compute_link_config drm/i915: Extract drm_dp_atomic_find_vcpi_slots cycle to separate function drm/i915: Add DSC support to MST pa

[PATCH 2/6] drm/i915: Fix intel_dp_mst_compute_link_config

2022-11-01 Thread Stanislav Lisovskiy
We currently always exit that bpp loop because drm_dp_atomic_find_vcpi_slots doesn't care if we actually can fit those or not. I think that wasn't the initial intention here, especially when we keep trying with lower bpps, we are supposed to keep trying until we actually find some _working_ configu

[PATCH 1/6] drm: Add missing DP DSC extended capability definitions.

2022-11-01 Thread Stanislav Lisovskiy
Adding DP DSC register definitions, we might need for further DSC implementation, supporting MST and DP branch pass-through mode. v2: - Fixed checkpatch comment warning v3: - Removed function which is not yet used(Jani Nikula) Reviewed-by: Vinod Govindapillai Signed-off-by: Stanislav Lisovskiy

[PATCH 3/6] drm/i915: Extract drm_dp_atomic_find_vcpi_slots cycle to separate function

2022-11-01 Thread Stanislav Lisovskiy
We would be using almost same code to loop through bpps while calling drm_dp_atomic_find_vcpi_slots - lets remove this duplication by introducing a new function intel_dp_mst_find_vcpi_slots_for_bpp v2: Fix pbn_div calculation - shouldn't matter if its DSC or not. v3: FIx rebase conflict, constant_

[PATCH 4/6] drm/i915: Add DSC support to MST path

2022-11-01 Thread Stanislav Lisovskiy
Whenever we are not able to get enough timeslots for required PBN, let's try to allocate those using DSC, just same way as we do for SST. v2: Removed intel_dp_mst_dsc_compute_config and refactored intel_dp_dsc_compute_config to support timeslots as a parameter(Ville Syrjälä) v3: - Rebased

[PATCH 5/6] drm/i915: Extract VESA DSC bpp alignment to separate function

2022-11-01 Thread Stanislav Lisovskiy
We might to use that function separately from intel_dp_dsc_compute_config for DP DSC over MST case, because allocating bandwidth in that case can be a bit more tricky. So in order to avoid code copy-pasta lets extract this to separate function and reuse it for both SST and MST cases. Signed-off-by

[PATCH 6/6] drm/i915: Bpp/timeslot calculation fixes for DP MST DSC

2022-11-01 Thread Stanislav Lisovskiy
Fix intel_dp_dsc_compute_config, previously timeslots parameter was used in fact not as a timeslots, but more like a ratio timeslots/64, which of course didn't have any effect for SST DSC, but causes now issues for MST DSC. Secondly we need to calculate pipe_bpp using intel_dp_dsc_compute_bpp only

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Don't deadlock busyness stats vs reset

2022-11-01 Thread Tvrtko Ursulin
On 31/10/2022 18:30, John Harrison wrote: On 10/31/2022 05:51, Tvrtko Ursulin wrote: On 31/10/2022 10:09, Tvrtko Ursulin wrote: On 28/10/2022 20:46, john.c.harri...@intel.com wrote: From: John Harrison The engine busyness stats has a worker function to do things like 64bit extend the 32bit

Re: [PATCH v3 4/7] drm/ivpu: Add IPC driver and JSM messages

2022-11-01 Thread Thomas Zimmermann
Hi Am 24.09.22 um 17:11 schrieb Jacek Lawrynowicz: The IPC driver is used to send and receive messages to/from firmware running on the VPU. The only supported IPC message format is Job Submission Model (JSM) defined in vpu_jsm_api.h header. Signed-off-by: Andrzej Kacprowski Signed-off-by: Kry

[PATCH v3 0/4] Add pixel formats used in Synatpics SoC

2022-11-01 Thread Hsia-Jun Li
From: "Hsia-Jun(Randy) Li" Those pixel formats are used in Synaptics's VideoSmart series SoCs, likes VS640, VS680. I just disclose the pixel formats used in the video codecs and display pipeline this time. Actually any device connected to the MTR module could support those tiled and compressed pi

[PATCH v3 1/4] drm/fourcc: Add Synaptics VideoSmart tiled modifiers

2022-11-01 Thread Hsia-Jun Li
From: "Hsia-Jun(Randy) Li" Memory Traffic Reduction(MTR) is a module in Synaptics VideoSmart platform could process lossless compression image and cache the tile memory line. Those modifiers only record the parameters would effort pixel layout or memory layout. Whether physical memory page mappi

[PATCH v3 2/4] media: videodev2.h: add pixel format modifiers

2022-11-01 Thread Hsia-Jun Li
From: "Hsia-Jun(Randy) Li" Signed-off-by: Hsia-Jun(Randy) Li --- include/uapi/linux/videodev2.h | 20 1 file changed, 20 insertions(+) diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index 29da1f4b4578..d00b2e9c0c54 100644 --- a/include/uapi/li

[PATCH v3 3/4] media: videodev2.h: add Synaptics tiled modifiers

2022-11-01 Thread Hsia-Jun Li
From: "Hsia-Jun(Randy) Li" These modifiers would have the same values as the one defined in drm_fourcc.h, they would just be named in v4l2 style. Signed-off-by: Hsia-Jun(Randy) Li --- include/uapi/linux/videodev2.h | 30 ++ 1 file changed, 30 insertions(+) diff --g

[PATCH v3 4/4] media: docs: Add Synpatics tile modifiers

2022-11-01 Thread Hsia-Jun Li
From: Randy Li The pixel formats used in Synpatics video smart platform are too many. It is impossible to store them in fourcc namespace. Signed-off-by: Randy Li Signed-off-by: Hsia-Jun(Randy) Li --- .../media/v4l/pixfmt-synaptics.rst| 86 +++ .../userspace-api/med

Re: [PATCH v3 5/7] drm/ivpu: Implement firmware parsing and booting

2022-11-01 Thread Thomas Zimmermann
Hi Am 24.09.22 um 17:11 schrieb Jacek Lawrynowicz: Read, parse and boot VPU firmware image. Signed-off-by: Andrzej Kacprowski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/ivpu/Makefile | 1 + drivers/gpu/drm/ivpu/ivpu_drv.c | 122

Re: [PATCH v3 RESEND 0/7] New DRM driver for Intel VPU

2022-11-01 Thread Thomas Zimmermann
Hi Am 01.11.22 um 09:58 schrieb Thomas Zimmermann: Hi Am 24.09.22 um 17:11 schrieb Jacek Lawrynowicz: Hi, This patchset contains a new Linux* Kernel Driver for Intel® VPUs. VPU stands for Versatile Processing Unit and it is an AI inference accelerator integrated with Intel non-server CPUs

[PATCH] video: fbdev: omapfb: remove redundant variable checksum

2022-11-01 Thread Colin Ian King
Variable checksum is being used to accumulate values however it is never read or used afterwards. It is redundant and can be removed. Signed-off-by: Colin Ian King --- drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/video/fbdev/omap2

[PATCH] drm/ofdrm: Depend on CONFIG_MMU

2022-11-01 Thread Thomas Zimmermann
Add a dependency on CONFIG_MMU to ofdrm. The driver uses GEM SHMEM helpers, which require MMU support. A reported error message [1] is shown below. arm-linux-gnueabi-ld: drivers/gpu/drm/drm_gem_shmem_helper.o: in function `drm_gem_shmem_fault': >> drivers/gpu/drm/drm_gem_shmem_helper.c:562:

Re: [PATCH] drm/nouveau: Add support to control backlight using bl_power for nva3.

2022-11-01 Thread Karol Herbst
On Tue, Nov 1, 2022 at 3:12 AM Bagas Sanjaya wrote: > > On 10/31/22 23:32, antoniospg wrote: > > Summary: > > > > * Add support to turn on/off backlight when changing values in bl_power > > file. This is achieved by using function backlight_get_brightness() > > in nva3_set_intensity to get cur

[v7] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2022-11-01 Thread Kalyan Thota
Flush mechanism for DSPP blocks has changed in sc7280 family, it allows individual sub blocks to be flushed in coordination with master flush control. Representation: master_flush && (PCC_flush | IGC_flush .. etc ) This change adds necessary support for the above design. Changes in v1: - Few nit

Re: [PATCH] drm/i915/hwmon: Don't use FIELD_PREP

2022-11-01 Thread Jani Nikula
On Mon, 31 Oct 2022, Ashutosh Dixit wrote: > FIELD_PREP and REG_FIELD_PREP have checks requiring a compile time constant > mask. When the mask comes in as the argument of a function these checks can > can fail depending on the compiler (gcc vs clang), optimization level, > etc. Use a simpler versi

[PATCH] drm/msm/disp/dpu1: register crtc color management to first crtc in the list

2022-11-01 Thread Kalyan Thota
This patch does the following: 1) Registers crtc color management to the first crtc in the list and attach to an encoder which is neither pluggable nor virtual 2) Pin 1 crtc to 1 encoder 3) Assign dspp block if crtc supports color processing. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/

RE: [PATCH v8 01/15] drm/msm/disp/dpu: clear dpu_assign_crtc and get crtc from connector state instead of dpu_enc

2022-11-01 Thread Vinod Polimera
> -Original Message- > From: Dmitry Baryshkov > Sent: Thursday, October 27, 2022 11:11 PM > To: Vinod Polimera ; Vinod Polimera (QUIC) > ; dri-devel@lists.freedesktop.org; linux-arm- > m...@vger.kernel.org; freedr...@lists.freedesktop.org; > devicet...@vger.kernel.org > Cc: linux-ker...@

[PATCH] drm/bridge: it6505: handle HDCP request

2022-11-01 Thread Hsin-Yi Wang
it6505 supports HDCP 1.3, but current implementation lacks the update of HDCP status through drm_hdcp_update_content_protection(). it6505 default enables the HDCP. If user set it to undesired then the driver will stop HDCP. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/bridge/ite-it6505.c | 54

[PATCH AUTOSEL 6.0 20/34] drm/vc4: hdmi: Check the HSM rate at runtime_resume

2022-11-01 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit 4190e8bbcbc77a9c36724681801cedc5229e7fc2 ] If our HSM clock has not been properly initialized, any register access will silently lock up the system. Let's check that this can't happen by adding a check for the rate before any register access, and error out

[PATCH AUTOSEL 6.0 26/34] drm/amdgpu: set vm_update_mode=0 as default for Sienna Cichlid in SRIOV case

2022-11-01 Thread Sasha Levin
From: Danijel Slivka [ Upstream commit 65f8682b9aaae20c2cdee993e6fe52374ad513c9 ] For asic with VF MMIO access protection avoid using CPU for VM table updates. CPU pagetable updates have issues with HDP flush as VF MMIO access protection blocks write to mmBIF_BX_DEV0_EPF0_VF0_HDP_MEM_COHERENCY_F

[PATCH AUTOSEL 6.0 27/34] drm/amd/pm: skip loading pptable from driver on secure board for smu_v13_0_10

2022-11-01 Thread Sasha Levin
From: Kenneth Feng [ Upstream commit f700486cd1f2bf381671d1c2c7dc9000db10c50e ] skip loading pptable from driver on secure board since it's loaded from psp. Signed-off-by: Kenneth Feng Reviewed-by: Guan Yu Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/pm/sw

[PATCH AUTOSEL 6.0 28/34] drm/amdkfd: Fix type of reset_type parameter in hqd_destroy() callback

2022-11-01 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit e688ba3e276422aa88eae7a54186a95320836081 ] When booting a kernel compiled with CONFIG_CFI_CLANG on a machine with an RX 6700 XT, there is a CFI failure in kfd_destroy_mqd_cp(): [ 12.894543] CFI failure at kfd_destroy_mqd_cp+0x2a/0x40 [amdgpu] (targe

[PATCH AUTOSEL 6.0 29/34] drm/amdgpu: Program GC registers through RLCG interface in gfx_v11/gmc_v11

2022-11-01 Thread Sasha Levin
From: Yifan Zha [ Upstream commit 97a3d6090f5c2a165dc88bda05c1dcf9f08bf886 ] [Why] L1 blocks most of GC registers accessing by MMIO. [How] Use RLCG interface to program GC registers under SRIOV VF in full access time. Signed-off-by: Yifan Zha Reviewed-by: Hawking Zhang Acked-by: Alex Deucher

[PATCH AUTOSEL 6.0 30/34] drm/amdgpu: dequeue mes scheduler during fini

2022-11-01 Thread Sasha Levin
From: YuBiao Wang [ Upstream commit 2abe92c7adc9c0397ba51bf74909b85bc0fff84b ] [Why] If mes is not dequeued during fini, mes will be in an uncleaned state during reload, then mes couldn't receive some commands which leads to reload failure. [How] Perform MES dequeue via MMIO after all the unmap

[PATCH AUTOSEL 5.15 17/19] drm/amdgpu: set vm_update_mode=0 as default for Sienna Cichlid in SRIOV case

2022-11-01 Thread Sasha Levin
From: Danijel Slivka [ Upstream commit 65f8682b9aaae20c2cdee993e6fe52374ad513c9 ] For asic with VF MMIO access protection avoid using CPU for VM table updates. CPU pagetable updates have issues with HDP flush as VF MMIO access protection blocks write to mmBIF_BX_DEV0_EPF0_VF0_HDP_MEM_COHERENCY_F

[PATCH AUTOSEL 5.10 13/14] drm/amdgpu: set vm_update_mode=0 as default for Sienna Cichlid in SRIOV case

2022-11-01 Thread Sasha Levin
From: Danijel Slivka [ Upstream commit 65f8682b9aaae20c2cdee993e6fe52374ad513c9 ] For asic with VF MMIO access protection avoid using CPU for VM table updates. CPU pagetable updates have issues with HDP flush as VF MMIO access protection blocks write to mmBIF_BX_DEV0_EPF0_VF0_HDP_MEM_COHERENCY_F

Re: [PATCH 00/10] Connect VFIO to IOMMUFD

2022-11-01 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 11:04:38AM +0800, Yi Liu wrote: > On 2022/11/1 07:24, Jason Gunthorpe wrote: > > On Mon, Oct 31, 2022 at 08:25:39PM +0800, Yi Liu wrote: > > > > There is something wrong with the test suite that it isn't covering > > > > the above, I'm going to look into that today. > > > >

Re: [v7] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2022-11-01 Thread Marijn Suijten
On 2022-11-01 03:57:05, Kalyan Thota wrote: > Flush mechanism for DSPP blocks has changed in sc7280 family, it > allows individual sub blocks to be flushed in coordination with > master flush control. > > Representation: master_flush && (PCC_flush | IGC_flush .. etc ) > > This change adds necessa

Re: [PATCH 06/10] vfio-iommufd: Allow iommufd to be used in place of a container fd

2022-11-01 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 02:19:04AM -0700, Nicolin Chen wrote: > On Tue, Nov 01, 2022 at 08:09:52AM +, Tian, Kevin wrote: > > > > From: Jason Gunthorpe > > > Sent: Wednesday, October 26, 2022 2:51 AM > > > > > > menuconfig VFIO > > > tristate "VFIO Non-Privileged userspace driver framew

Re: [PATCH] drm/msm/disp/dpu1: register crtc color management to first crtc in the list

2022-11-01 Thread Marijn Suijten
On 2022-11-01 03:59:21, Kalyan Thota wrote: > This patch does the following: Don't self-reference "this patch": https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes > 1) Registers crtc color management to the first crtc in the list and > attach to an encode

Re: [PATCH 01/10] vfio: Move vfio_device driver open/close code to a function

2022-11-01 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 07:33:30AM +, Tian, Kevin wrote: > > + /* > > +* Here we pass the KVM pointer with the group under the read lock. > > Now the read lock is replaced by mutex. Let's correct it when moving this > piece of code. Done, thanks Jason

Re: [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()

2022-11-01 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 07:38:47AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, October 26, 2022 2:17 AM > > > > +err_container: > > + vfio_device_unassign_container(device); > > err_module_put: > > device->kvm = NULL; > > err_module_put should be moved after n

Re: [PATCH v8 12/15] drm/msm/disp/dpu: get timing engine status from intf status register

2022-11-01 Thread Marijn Suijten
On 2022-10-12 17:32:36, Vinod Polimera wrote: > Timing gen status can be read reliablly from intf status Typo. "reliably read from the intf status register..." > register rather than from the timing gen control register, > which will readback as "0" after disable though the timing > gen is still

Re: [PATCH 05/10] vfio: Use IOMMU_CAP_ENFORCE_CACHE_COHERENCY for vfio_file_enforced_coherent()

2022-11-01 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 07:52:23AM +, Tian, Kevin wrote: > > IOMMU_CAP_ENFORCE_CACHE_COHERENCY we know what the > > iommu_domain will be > > capable of without having to create it. Use this to compute > > it's worth noting that the prerequisite is that vfio always enforces > cache coherency on

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-01 Thread Mauro Carvalho Chehab
On Thu, 1 Sep 2022 14:37:06 +0800 David Gow wrote: > On Mon, Aug 29, 2022 at 8:10 AM Isabella Basso wrote: > > > > This adds functions for both executing the tests as well as parsing (K)TAP > > kmsg output, as per the KTAP spec [1]. > > > > [1] https://www.kernel.org/doc/html/latest/dev-tools/kt

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-01 Thread Mauro Carvalho Chehab
Hi Isabella, On Mon, 19 Sep 2022 17:43:19 -0300 Isabella Basso wrote: > > Do you want to _require_ KUnit be built as a module, rather than built-in > > here? > > I’ll change the comment and the warning in v3 to clarify this. When do you intend to submit v3? Regards, Mauro

Re: [PATCH 06/10] vfio-iommufd: Allow iommufd to be used in place of a container fd

2022-11-01 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 08:09:52AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, October 26, 2022 2:51 AM > > > > menuconfig VFIO > > tristate "VFIO Non-Privileged userspace driver framework" > > select IOMMU_API > > + depends on IOMMUFD || !IOMMUFD > > Out o

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-01 Thread Mauro Carvalho Chehab
On Mon, 19 Sep 2022 17:25:38 -0700 Daniel Latypov wrote: > On Mon, Sep 19, 2022 at 1:43 PM Isabella Basso wrote: > > >> +* "(K)TAP version XX" should be the first line on all > > >> (sub)tests as per > > >> +* > > >> https://www.kernel.org/doc/html/latest/dev-tools/ktap.html#ve

Re: [PATCH 08/10] vfio-iommufd: Support iommufd for emulated VFIO devices

2022-11-01 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 08:37:39AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, October 26, 2022 2:51 AM > > > > Emulated VFIO devices are calling vfio_register_emulated_iommu_dev() and > > consist of all the mdev drivers. > > > > Like the physical drivers, support fo

RE: [v7] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2022-11-01 Thread Kalyan Thota
>-Original Message- >From: Marijn Suijten >Sent: Tuesday, November 1, 2022 5:13 PM >To: Kalyan Thota (QUIC) >Cc: dri-devel@lists.freedesktop.org; linux-arm-...@vger.kernel.org; >freedr...@lists.freedesktop.org; devicet...@vger.kernel.org; linux- >ker...@vger.kernel.org; robdcl...@gmail

Re: [PATCH 00/10] Connect VFIO to IOMMUFD

2022-11-01 Thread Yi Liu
On 2022/11/1 12:21, Nicolin Chen wrote: On Tue, Nov 01, 2022 at 11:04:38AM +0800, Yi Liu wrote: On 2022/11/1 07:24, Jason Gunthorpe wrote: On Mon, Oct 31, 2022 at 08:25:39PM +0800, Yi Liu wrote: There is something wrong with the test suite that it isn't covering the above, I'm going to look in

Re: [igt-dev] [PATCH i-g-t v2 4/4] tests: DRM selftests: switch to KUnit

2022-11-01 Thread Mauro Carvalho Chehab
On Tue, 20 Sep 2022 11:18:25 +0300 Petri Latvala wrote: > On Sun, Aug 28, 2022 at 09:09:20PM -0300, Isabella Basso wrote: > > As the DRM selftests are now using KUnit [1], update IGT tests as well. > > > > [1] - > > https://lore.kernel.org/all/20220708203052.236290-1-maira.ca...@usp.br/ > > >

Re: [PATCH 00/10] Connect VFIO to IOMMUFD

2022-11-01 Thread Yi Liu
On 2022/11/1 19:41, Jason Gunthorpe wrote: On Tue, Nov 01, 2022 at 11:04:38AM +0800, Yi Liu wrote: On 2022/11/1 07:24, Jason Gunthorpe wrote: On Mon, Oct 31, 2022 at 08:25:39PM +0800, Yi Liu wrote: There is something wrong with the test suite that it isn't covering the above, I'm going to look

Re: [PATCH 09/10] vfio: Make vfio_container optionally compiled

2022-11-01 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 08:41:56AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, October 26, 2022 2:51 AM > > > > if VFIO > > +config VFIO_CONTAINER > > + bool "Support for the VFIO container /dev/vfio/vfio" > > + select VFIO_IOMMU_TYPE1 if MMU && (X86 || S390 || A

Re: [Intel-gfx] [PATCH v7 0/9] dyndbg: drm.debug adaptation

2022-11-01 Thread jim . cromie
On Tue, Nov 1, 2022 at 2:52 AM Ville Syrjälä wrote: > > On Mon, Oct 31, 2022 at 08:20:54PM -0400, Jason Baron wrote: > > > > > > On 10/31/22 6:11 PM, jim.cro...@gmail.com wrote: > > > On Mon, Oct 31, 2022 at 7:07 AM Ville Syrjälä > > > wrote: > > >> On Sun, Oct 30, 2022 at 08:42:52AM -0600, jim.c

Re: [igt-dev] [PATCH i-g-t v2 4/4] tests: DRM selftests: switch to KUnit

2022-11-01 Thread Petri Latvala
On Tue, Nov 01, 2022 at 01:54:25PM +0100, Mauro Carvalho Chehab wrote: > On Tue, 20 Sep 2022 11:18:25 +0300 > Petri Latvala wrote: > > > On Sun, Aug 28, 2022 at 09:09:20PM -0300, Isabella Basso wrote: > > > As the DRM selftests are now using KUnit [1], update IGT tests as well. > > > > > > [1] -

Re: [PATCH] drm/imx: Kconfig: Remove duplicated 'select DRM_KMS_HELPER' line

2022-11-01 Thread Philipp Zabel
On So, 2022-10-09 at 10:35 +0800, Liu Ying wrote: > A duplicated line 'select DRM_KMS_HELPER' was introduced in Kconfig file > by commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option"), > so remove it. > > Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option") > Signed-

Re: [PATCH] drm/imx: imx-tve: Fix return type of imx_tve_connector_mode_valid

2022-11-01 Thread Philipp Zabel
On Di, 2022-09-13 at 13:55 -0700, Nathan Huckleberry wrote: > The mode_valid field in drm_connector_helper_funcs is expected to be of > type: > enum drm_mode_status (* mode_valid) (struct drm_connector *connector, >  struct drm_display_mode *mode); > > The misma

Re: [PATCH 6/6] drm/i915: Bpp/timeslot calculation fixes for DP MST DSC

2022-11-01 Thread kernel test robot
Hi Stanislav, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on drm/drm-next linus/master v6.1-rc3 next-20221101] [cannot apply to drm-intel/for-linux-next] [If your patch is applied to the wrong git tree, kindly drop

Re: [igt-dev] [PATCH i-g-t v2 4/4] tests: DRM selftests: switch to KUnit

2022-11-01 Thread Mauro Carvalho Chehab
On Tue, 1 Nov 2022 15:16:02 +0200 Petri Latvala wrote: > On Tue, Nov 01, 2022 at 01:54:25PM +0100, Mauro Carvalho Chehab wrote: > > On Tue, 20 Sep 2022 11:18:25 +0300 > > Petri Latvala wrote: > > > > > On Sun, Aug 28, 2022 at 09:09:20PM -0300, Isabella Basso wrote: > > > > As the DRM selftests

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-01 Thread Marco Felsch
Hi Marek, Liu, On 22-10-28, Liu Ying wrote: > On Fri, 2022-10-28 at 02:03 +0200, Marek Vasut wrote: > > On 10/27/22 19:47, Marco Felsch wrote: > > > On 22-10-27, Liu Ying wrote: > > > > On Thu, 2022-10-27 at 12:03 +0200, Marek Vasut wrote: > > > > > On 10/27/22 07:45, Liu Ying wrote: > > > > > >

Re: [igt-dev] [PATCH i-g-t v2 4/4] tests: DRM selftests: switch to KUnit

2022-11-01 Thread Daniel Latypov
On Tue, Nov 1, 2022, 6:53 AM Mauro Carvalho Chehab wrote: > > Ah, the selection is in kunit.ko itself. kunit.filter_glob, set from > > kunit.py with > > > > positional arguments: > > filter_glob Filter which KUnit test suites/tests run at > > boot-time, e.g. list* or list*.*del_test >

Re: [PATCH v1 4/7] vfio/ccw: move private to mdev lifecycle

2022-11-01 Thread Eric Farman
On Tue, 2022-11-01 at 09:08 +, Tian, Kevin wrote: > > From: Eric Farman > > Sent: Thursday, October 20, 2022 12:22 AM > > > > @@ -101,15 +101,20 @@ static int vfio_ccw_mdev_probe(struct > > mdev_device *mdev) > >  { > > struct subchannel *sch = to_subchannel(mdev->dev.parent); > >    

Re: [PATCH] drm/amd/display (gcc13): fix enum mismatch

2022-11-01 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Oct 31, 2022 at 9:59 AM Harry Wentland wrote: > > On 2022-10-31 07:42, Jiri Slaby (SUSE) wrote: > > rn_vbios_smu_set_dcn_low_power_state() produces a valid warning with > > gcc-13: > > > > drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c:237:6

Re: [PATCH] drm/radeon: Use a local mutex for bind/unbind protection

2022-11-01 Thread Alex Deucher
On Mon, Oct 31, 2022 at 2:49 AM Takashi Iwai wrote: > > We used drm_modeset_lock_all() for protecting the audio component > bind/unbind operations against the notification, but it seems leading > to kernel WARNING and Oops. Moreover, the use of > drm_modeset_lock_all() is rather an overkill only

Re: [PATCH 01/10] vfio: Move vfio_device driver open/close code to a function

2022-11-01 Thread Yi Liu
On 2022/10/26 02:17, Jason Gunthorpe wrote: This error unwind is getting complicated. Move all the code into two pair'd function. The functions should be called when the open_count == 1 after incrementing/before decrementing. Signed-off-by: Jason Gunthorpe --- drivers/vfio/vfio_main.c | 95 ++

Re: [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()

2022-11-01 Thread Yi Liu
On 2022/10/26 02:17, Jason Gunthorpe wrote: The only thing this function does is assert the group has an assigned container and incrs refcounts. The overall model we have is that once a conatiner_users refcount is typo. s/conatiner_users/container_users incremented it cannot be de-assigned

Re: [PATCH v2] [next] drm/radeon: Replace one-element array with flexible-array member

2022-11-01 Thread Alex Deucher
On Fri, Oct 28, 2022 at 11:32 PM Paulo Miguel Almeida wrote: > > One-element arrays are deprecated, and we are replacing them with > flexible array members instead. So, replace one-element array with > flexible-array member in struct _ATOM_FAKE_EDID_PATCH_RECORD and > refactor the rest of the code

Re: [PATCH 03/10] vfio: Rename vfio_device_assign/unassign_container()

2022-11-01 Thread Yi Liu
On 2022/10/26 02:17, Jason Gunthorpe wrote: These functions don't really assign anything anymore, they just increment some refcounts and do a sanity check. Call them vfio_group_[un]use_container() Signed-off-by: Jason Gunthorpe --- drivers/vfio/container.c | 14 ++ drivers/vfio/v

Re: [PATCH] drm/msm/dp: remove limitation of link rate at 5.4G to support HBR3

2022-11-01 Thread Doug Anderson
Hi, On Mon, Oct 31, 2022 at 5:15 PM Dmitry Baryshkov wrote: > > On 01/11/2022 03:08, Doug Anderson wrote: > > Hi, > > > > On Mon, Oct 31, 2022 at 2:11 PM Kuogee Hsieh > > wrote: > >> > >> Hi Dmitry, > >> > >> > >> Link rate is advertised by sink, but adjusted (reduced the link rate) > >> by hos

[PATCH v1 1/2] fbdev: ssd1307fb: Drop optional dependency

2022-11-01 Thread Andy Shevchenko
Only a single out of three devices need a PWM, so from driver it's optional. Moreover it's a single driver in the entire kernel that currently selects PWM. Unfortunately this selection is a root cause of the circular dependencies when we want to enable optional PWM for some other drivers that selec

[PATCH v1 2/2] fbdev: ssd1307fb: Drop duplicate NULL checks for PWM APIs

2022-11-01 Thread Andy Shevchenko
pwm_disable() and pwm_put() are NULL-aware, no need to duplicate the check in the caller. Signed-off-by: Andy Shevchenko --- drivers/video/fbdev/ssd1307fb.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1

Re: [PATCH] drm/i915/mtl: Add MC6 Wa_14017210380 for SAMedia

2022-11-01 Thread Matt Roper
On Sat, Oct 29, 2022 at 12:59:35AM +0530, Badal Nilawar wrote: > This workaround is added for Media Tile of MTL A step. It is to help > pcode workaround which handles the hardware bug seen on CXL splitter > during package C2/C3 transitins due to MC6 entry/exit. As a part of > workaround pcode expec

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-01 Thread Marek Vasut
On 11/1/22 15:04, Marco Felsch wrote: Hi Marek, Liu, Hi, [...] Also IMHO the threshold should be taken wisely to not enter panic mode to early to not block others from the bus e.g. the GPU. As far as I understand the PANIC0_THRES, both thresholds are really watermarks in the FIFO, 0=EMPTY,

[PATCH v2] drm: lcdif: Set and enable FIFO Panic threshold

2022-11-01 Thread Marek Vasut
In case the LCDIFv3 is used to drive a 4k panel via i.MX8MP HDMI bridge, the LCDIFv3 becomes susceptible to FIFO underflows, these lead to nasty flicker of the image on the panel, or image being shifted by half frame horizontally every second frame. The flicker can be easily triggered by running 3D

Re: [PATCH v1 1/2] fbdev: ssd1307fb: Drop optional dependency

2022-11-01 Thread Helge Deller
On 11/1/22 16:09, Andy Shevchenko wrote: Only a single out of three devices need a PWM, so from driver it's optional. Moreover it's a single driver in the entire kernel that currently selects PWM. Unfortunately this selection is a root cause of the circular dependencies when we want to enable opt

Re: [PATCH] video: fbdev: omapfb: remove redundant variable checksum

2022-11-01 Thread Helge Deller
On 11/1/22 11:29, Colin Ian King wrote: Variable checksum is being used to accumulate values however it is never read or used afterwards. It is redundant and can be removed. Signed-off-by: Colin Ian King applied. Thanks! Helge --- drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 2 --

Re: [PATCH] drm/amd/display: add parameter backlight_min

2022-11-01 Thread Filip Moc
Hello Harry, thank you for your response. > amdgpu.backlight_min=2:-1 almost :-) Array elements in module parameters are separated by commas not colons. So for cmdline it should look like this: amdgpu.backlight_min=2,-1 Though you can just drop the ,-1 relying on kernel leaving the rest of arr

  1   2   >