Re: [PATCH v1 0/11] drm/via: Make via a single file driver

2022-07-11 Thread Thomas Zimmermann
Hi Sam, this looks like a good solution to me. I'd give you a detailed review, but dri-devel decided to only send me the color letter. I had to use patchwork get the patches. For the series Acked-by: Thomas Zimmermann with suggestions below. Am 10.07.22 um 10:54 schrieb Sam Ravnborg: We

Re: drm-tip amdgpu not compiling, possible fix attached

2022-07-11 Thread Thomas Zimmermann
Hi Am 10.07.22 um 22:01 schrieb Hans de Goede: Hi All, I've been rebasing my backlight refactor on top of drm-tip to submit a new version upstream and I noticed that drm-tip does not compile. This is caused by a mismerge of: commit 925b6e59138cefa47275c67891c65d48d3266d57 (drm-misc/for-linux-

Re: [PATCH 02/14] drm/mgag200: Move DAC-register setup into model-specific code

2022-07-11 Thread Thomas Zimmermann
Hi Sam Am 08.07.22 um 17:54 schrieb Sam Ravnborg: Hi Thomas, On Fri, Jul 08, 2022 at 11:39:17AM +0200, Thomas Zimmermann wrote: Provide an init function for each model's DAC registers. Remove the shared helper. The code for initializing the DAC registers consisted of a large table of default

Re: [RFC PATCH 1/3] drm/bridge: ti-sn65dsi86: switch to atomic ops

2022-07-11 Thread Dmitry Baryshkov
On Sun, 10 Jul 2022 at 22:04, Sam Ravnborg wrote: > > Hi Dmitry, > > On Sun, Jul 10, 2022 at 09:45:34PM +0300, Dmitry Baryshkov wrote: > > Make ti-sn65dsi86 use atomic_enable / atomic_disable / atomic_pre_enable > > / atomic_post_disable rather than their non-atomic versions. > > > > Signed-off-by

Re: [PATCH 00/14] drm/mgag200: Move model-specific code into separate functions

2022-07-11 Thread Thomas Zimmermann
Hi Sam, thanks for reviewing. Am 08.07.22 um 19:22 schrieb Sam Ravnborg: Hi Thomas, On Fri, Jul 08, 2022 at 11:39:15AM +0200, Thomas Zimmermann wrote: Mgag200 still mixes model-specific code and generic code in the same functions. Separate it into distinct helpers. As part of this effort, co

Re: [RFC PATCH 2/3] drm/bridge: ti-sn65dsi86: fetch bpc using drm_atomic_state

2022-07-11 Thread Dmitry Baryshkov
On Sun, 10 Jul 2022 at 22:11, Sam Ravnborg wrote: > > Hi Dmitry, > > On Sun, Jul 10, 2022 at 09:45:35PM +0300, Dmitry Baryshkov wrote: > > Rather than reading the pdata->connector directly, fetch the connector > > using drm_atomic_state. This allows us to make pdata->connector optional > > (and th

[RFC PATCH v2 0/2] drm/bridge: ti-sn65dsi86: support DRM_BRIDGE_ATTACH_NO_CONNECTOR

2022-07-11 Thread Dmitry Baryshkov
An RFC (or rather RFT, Request-for-Testing) series adding support for DRM_BRIDGE_ATTACH_NO_CONNECTOR. Note, it was compile-tested only. This bridge is the last one used on the Qualcomm platforms (in upstream-supported devices) and thus it is the only bridge that prevents us from removing support f

[RFC PATCH v2 1/2] drm/bridge: ti-sn65dsi86: fetch bpc using drm_atomic_state

2022-07-11 Thread Dmitry Baryshkov
Rather than reading the pdata->connector directly, fetch the connector using drm_atomic_state. This allows us to make pdata->connector optional (and thus supporting DRM_BRIDGE_ATTACH_NO_CONNECTOR). Reviewed-by: Sam Ravnborg Reviewed-by: Laurent Pinchart Signed-off-by: Dmitry Baryshkov --- driv

[RFC PATCH v2 2/2] drm/bridge: ti-sn65dsi86: support DRM_BRIDGE_ATTACH_NO_CONNECTOR

2022-07-11 Thread Dmitry Baryshkov
Now as the driver does not depend on pdata->connector, add support for attaching the bridge with DRM_BRIDGE_ATTACH_NO_CONNECTOR. Reviewed-by: Sam Ravnborg Reviewed-by: Laurent Pinchart Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 18 -- 1 file cha

[PATCH] drm/panel-edp: add AUO B133UAN02.1 panel entry

2022-07-11 Thread Johan Hovold
Add an eDP panel entry for AUO B133UAN02.1. Due to lack of documentation, use the delay_200_500_e50 timings like some other AUO entries for now. Signed-off-by: Johan Hovold --- drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-edp.

Re: [PATCH 02/11] fbdev/vga16fb: Create EGA/VGA devices in sysfb code

2022-07-11 Thread Thomas Zimmermann
Hi Javier, I'll try to give the motivation of this patch below. I known it's rather hypothetical as the VGA driver is probably not used much. Am 08.07.22 um 15:09 schrieb Javier Martinez Canillas: Hello Thomas, On 7/7/22 17:39, Thomas Zimmermann wrote: Move the device-creation from vga16fb

Re: [PATCH 03/11] fbdev/vga16fb: Auto-generate module init/exit code

2022-07-11 Thread Thomas Zimmermann
Hi Am 08.07.22 um 15:16 schrieb Javier Martinez Canillas: On 7/7/22 17:39, Thomas Zimmermann wrote: Move vgag16fb's option parsing into the driver's probe function and generate the rest of the module's init/exit functions from macros. Keep the options code, although there are no options defined

Re: linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2022-07-11 Thread Christian König
Hi Stephen, Am 11.07.22 um 04:47 schrieb Stephen Rothwell: Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c between commit: 925b6e59138c ("Revert "drm/amdgpu: add drm buddy support to amdgpu"") from the drm-misc-fixes tre

[syzbot] BUG: unable to handle kernel paging request in bitfill_aligned (3)

2022-07-11 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:e35e5b6f695d Merge tag 'xsa-5.19-tag' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17f49bbc08 kernel config: https://syzkaller.appspot.com/x/.config?x=f3bf7765b1ebd721 das

Re: [PATCH v2 02/11] arm64: dts: qcom: sc7180: rename DPU device node

2022-07-11 Thread Konrad Dybcio
On 10.07.2022 11:00, Dmitry Baryshkov wrote: > Rename DPU device node to display-controller@ae01000 to follow the > DPU schema. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH v2 01/11] arm64: dts: qcom: sdm845: rename DPU device node

2022-07-11 Thread Konrad Dybcio
On 10.07.2022 11:00, Dmitry Baryshkov wrote: > Rename DPU device node to display-controller@ae01000 to follow the > DPU schema. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH v2 03/11] arm64: dts: qcom: sm8250: rename DPU device node

2022-07-11 Thread Konrad Dybcio
On 10.07.2022 11:00, Dmitry Baryshkov wrote: > Rename DPU device node to display-controller@ae01000 to follow the > DPU schema. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH 1/9] dt-bindings: msm/dp: drop extra p1 region

2022-07-11 Thread Dmitry Baryshkov
On 08/07/2022 22:47, Kuogee Hsieh wrote: On 7/8/2022 12:38 PM, Abhinav Kumar wrote: + kuogee On 7/8/2022 12:27 PM, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-07-07 20:46:43) On 08/07/2022 04:28, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-07-07 14:31:56) The p1 region was pr

Re: [PATCH v3 06/10] drm/fb-helper: Add support for DRM_FORMAT_C[124]

2022-07-11 Thread Thomas Zimmermann
Hi Am 08.07.22 um 20:20 schrieb Geert Uytterhoeven: Add support for color-indexed frame buffer formats with two, four, and sixteen colors to the DRM framebuffer helper functions: 1. Add support for 1, 2, and 4 bits per pixel to the damage helper, 2. For color-indexed modes, the length of t

[PATCH] drm/mipi-dsi: Fix device_node's refcount bugs

2022-07-11 Thread Liang He
In mipi_dsi_device_register_full(), we should call of_node_get() when a new reference is created in to dsi->dev.of_node(), and call of_node_put() in fail path or when it is not used anymore in *_unregister(). The reasons to commit this patch as folllow: (1) There are totally 16 locations to call

Re: [PATCH v3 00/10] drm: Add support for low-color frame buffer formats

2022-07-11 Thread Thomas Zimmermann
Hi Am 09.07.22 um 15:38 schrieb Sam Ravnborg: Hi Geert, On Fri, Jul 08, 2022 at 08:20:45PM +0200, Geert Uytterhoeven wrote: Hi all, A long outstanding issue with the DRM subsystem has been the lack of support for low-color displays, as used typically on older desktop systems, and on s

[PATCH v3] drm/i915/ttm: fix sg_table construction

2022-07-11 Thread Matthew Auld
If we encounter some monster sized local-memory page that exceeds the maximum sg length (UINT32_MAX), ensure that don't end up with some misaligned address in the entry that follows, leading to fireworks later. Also ensure we have some coverage of this in the selftests. v2(Chris): - Use round_do

Re: [PATCH v1 0/11] drm/via: Make via a single file driver

2022-07-11 Thread Sam Ravnborg
Hi Thomas, On Mon, Jul 11, 2022 at 09:01:50AM +0200, Thomas Zimmermann wrote: > Hi Sam, > > this looks like a good solution to me. I'd give you a detailed review, but > dri-devel decided to only send me the color letter. I had to use patchwork > get the patches. > > For the series > > Acked-by:

Re: [PATCH 4/5] drm/modes: Add support for driver-specific named modes

2022-07-11 Thread Thomas Zimmermann
Hi Geert Am 08.07.22 um 20:21 schrieb Geert Uytterhoeven: The mode parsing code recognizes named modes only if they are explicitly listed in the internal whitelist, which is currently limited to "NTSC" and "PAL". Provide a mechanism for drivers to override this list to support custom mode names

Re: [PATCH 0/5] drm/modes: Command line mode selection fixes and improvements

2022-07-11 Thread Thomas Zimmermann
Hi Am 08.07.22 um 20:21 schrieb Geert Uytterhoeven: Hi all, This patch series contains fixes and improvements for specifying video modes on the kernel command line. This has been tested on ARAnyM using a work-in-progress Atari DRM driver (more info and related patches can be found in [

Re: [PATCH v1 0/11] drm/via: Make via a single file driver

2022-07-11 Thread Thomas Zimmermann
Hi Am 11.07.22 um 11:01 schrieb Sam Ravnborg: Hi Thomas, On Mon, Jul 11, 2022 at 09:01:50AM +0200, Thomas Zimmermann wrote: Hi Sam, this looks like a good solution to me. I'd give you a detailed review, but dri-devel decided to only send me the color letter. I had to use patchwork get the pat

Re: [RFC PATCH v2 1/2] drm/bridge: ti-sn65dsi86: fetch bpc using drm_atomic_state

2022-07-11 Thread Sam Ravnborg
Hi Dmitry, On Mon, Jul 11, 2022 at 10:37:32AM +0300, Dmitry Baryshkov wrote: > Rather than reading the pdata->connector directly, fetch the connector > using drm_atomic_state. This allows us to make pdata->connector optional > (and thus supporting DRM_BRIDGE_ATTACH_NO_CONNECTOR). > > Reviewed-by:

Re: [PATCH v3 00/10] drm: Add support for low-color frame buffer formats

2022-07-11 Thread Sam Ravnborg
Hi Thomas, On Mon, Jul 11, 2022 at 10:50:00AM +0200, Thomas Zimmermann wrote: > Hi > > Am 09.07.22 um 15:38 schrieb Sam Ravnborg: > > Hi Geert, > > > > On Fri, Jul 08, 2022 at 08:20:45PM +0200, Geert Uytterhoeven wrote: > > > Hi all, > > > > > > A long outstanding issue with the DRM subsystem

Re: [RFC PATCH v2 1/2] drm/bridge: ti-sn65dsi86: fetch bpc using drm_atomic_state

2022-07-11 Thread Dmitry Baryshkov
On 11/07/2022 12:10, Sam Ravnborg wrote: Hi Dmitry, On Mon, Jul 11, 2022 at 10:37:32AM +0300, Dmitry Baryshkov wrote: Rather than reading the pdata->connector directly, fetch the connector using drm_atomic_state. This allows us to make pdata->connector optional (and thus supporting DRM_BRIDGE_A

[RFC PATCH v3 0/2] drm/bridge: ti-sn65dsi86: support DRM_BRIDGE_ATTACH_NO_CONNECTOR

2022-07-11 Thread Dmitry Baryshkov
An RFC (or rather RFT, Request-for-Testing) series adding support for DRM_BRIDGE_ATTACH_NO_CONNECTOR. Note, it was compile-tested only. This bridge is the last one used on the Qualcomm platforms (in upstream-supported devices) and thus it is the only bridge that prevents us from removing support f

[RFC PATCH v3 2/2] drm/bridge: ti-sn65dsi86: support DRM_BRIDGE_ATTACH_NO_CONNECTOR

2022-07-11 Thread Dmitry Baryshkov
Now as the driver does not depend on pdata->connector, add support for attaching the bridge with DRM_BRIDGE_ATTACH_NO_CONNECTOR. Reviewed-by: Sam Ravnborg Reviewed-by: Laurent Pinchart Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 18 -- 1 file cha

[RFC PATCH v3 1/2] drm/bridge: ti-sn65dsi86: fetch bpc using drm_atomic_state

2022-07-11 Thread Dmitry Baryshkov
Rather than reading the pdata->connector directly, fetch the connector using drm_atomic_state. This allows us to make pdata->connector optional (and thus supporting DRM_BRIDGE_ATTACH_NO_CONNECTOR). Reviewed-by: Sam Ravnborg Reviewed-by: Laurent Pinchart Signed-off-by: Dmitry Baryshkov --- driv

Re: [PATCH] drm/mgag200: Don't read-back PCI option register before writing

2022-07-11 Thread Jocelyn Falempe
On 08/07/2022 09:21, Thomas Zimmermann wrote: Remove the read operation from mgag200_init_pci_options(). It was incorrectly added while refactoring the code. Reading the PCI option register clears the register's new value and subsequently leads to re-writing the old value. Looks good to me. Re

Re: [PATCH 4/5] drm/modes: Add support for driver-specific named modes

2022-07-11 Thread Maxime Ripard
Hi Thomas, On Mon, Jul 11, 2022 at 11:03:38AM +0200, Thomas Zimmermann wrote: > Am 08.07.22 um 20:21 schrieb Geert Uytterhoeven: > > The mode parsing code recognizes named modes only if they are explicitly > > listed in the internal whitelist, which is currently limited to "NTSC" > > and "PAL". >

Re: [PATCH 4/5] drm/modes: Add support for driver-specific named modes

2022-07-11 Thread Geert Uytterhoeven
Hi Thomas, On Mon, Jul 11, 2022 at 11:03 AM Thomas Zimmermann wrote: > Am 08.07.22 um 20:21 schrieb Geert Uytterhoeven: > > The mode parsing code recognizes named modes only if they are explicitly > > listed in the internal whitelist, which is currently limited to "NTSC" > > and "PAL". > > > > Pr

[PATCH v2 0/4] drm/msm/dsi: stop using drm_panel directly

2022-07-11 Thread Dmitry Baryshkov
This series superseeds two existing patch series ([1] and [2]) and merges them together in a single patchset to demonstrate necessity for the first three patches. The drm/msm/dsi driver has two separate code paths, one utilizing a chain of drm_bridges and another one for directly interfacing the d

[PATCH v2 1/4] drm/mipi-dsi: pass DSC data through the struct mipi_dsi_device

2022-07-11 Thread Dmitry Baryshkov
The commit 0f40ba48de3b ("drm/msm/dsi: Pass DSC params to drm_panel") added a pointer to the DSC data to the struct drm_panel. However DSC support is not limited to the DSI panels. MIPI DSI bridges can also consume DSC command streams. Thus add struct drm_dsc_config pointer to the struct mipi_dsi_d

[PATCH v2 2/4] drm/msm/dsi: fetch DSC pps payload from struct mipi_dsi_device

2022-07-11 Thread Dmitry Baryshkov
Now that struct mipi_dsi_device provides DSC data, fetch it from the mentioned struct rather than from the struct drm_panel itself. This would allow supporting MIPI DSI bridges handling DSC on their input side. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_host.c | 25 +

[PATCH v2 4/4] drm/msm/dsi: switch to DRM_PANEL_BRIDGE

2022-07-11 Thread Dmitry Baryshkov
Currently the DSI driver has two separate paths: one if the next device in a chain is a bridge and another one if the panel is connected directly to the DSI host. Simplify the code path by using panel-bridge driver (already selected in Kconfig) and dropping support for handling the panel directly.

[PATCH v2 3/4] drm/panel: drop DSC pps pointer

2022-07-11 Thread Dmitry Baryshkov
Complete the move of DSC data pointer from struct drm_panel to struct mipi_dsi_device. Signed-off-by: Dmitry Baryshkov --- include/drm/drm_panel.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h index 3a271128c078..994bfcdd84c5 100644 -

Re: [PATCH 3/5] dma-buf: return only unsignaled fences in dma_fence_unwrap_for_each v3

2022-07-11 Thread Karolina Drobnik
Hi Christian, I'm sorry for digging this one out so late. On 06.05.2022 16:10, Christian König wrote: dma_fence_chain containers cleanup signaled fences automatically, so filter those out from arrays as well. v2: fix missing walk over the array v3: massively simplify the patch and actually upd

[PATCH v5 05/10] drm/msm/dp: use the eDP bridge ops to validate eDP modes

2022-07-11 Thread Vinod Polimera
The eDP and DP interfaces shared the bridge operations and the eDP specific changes were implemented under is_edp check. To add psr support for eDP, we started using a new set of eDP bridge ops. We are moving the eDP specific code in the dp_bridge_mode_valid function to a new eDP function, edp_brid

[PATCH v5 04/10] drm/msm/dp: Add basic PSR support for eDP

2022-07-11 Thread Vinod Polimera
Add support for basic panel self refresh (PSR) feature for eDP. Add a new interface to set PSR state in the sink from DPU. Program the eDP controller to issue PSR enter and exit SDP to the sink. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/dp/dp_cata

[PATCH v5 08/10] drm/msm/disp/dpu1: use atomic enable/disable callbacks for encoder functions

2022-07-11 Thread Vinod Polimera
Use atomic variants for encoder callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Reviewed-by: Dmitry Baryshkov Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 ++-

[PATCH v5 01/10] drm/msm/disp/dpu1: clear dpu_assign_crtc and get crtc from connector state instead of dpu_enc

2022-07-11 Thread Vinod Polimera
Update crtc retrieval from dpu_enc to dpu_enc connector state, since new links get set as part of the dpu enc virt mode set. The dpu_enc->crtc cache is no more needed, hence cleaning it as part of this change. Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 4 ---

[PATCH v5 03/10] drm/msm/dp: use atomic callbacks for DP bridge ops

2022-07-11 Thread Vinod Polimera
Use atomic variants for DP bridge callback functions so that the atomic state can be accessed in the interface drivers. The atomic state will help the driver find out if the display is in self refresh state. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera --- drivers/gpu/drm/m

[PATCH v5 04/10] drm/msm/dp: add basic PSR support for eDP

2022-07-11 Thread Vinod Polimera
Add support for basic panel self refresh (PSR) feature for eDP. Add a new interface to set PSR state in the sink from DPU. Program the eDP controller to issue PSR enter and exit SDP to the sink. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/dp/dp_cata

[PATCH v5 09/10] drm/msm/disp/dpu1: add PSR support for eDP interface in dpu driver

2022-07-11 Thread Vinod Polimera
Enable PSR on eDP interface using drm self-refresh librabry. This patch uses a trigger from self-refresh library to enter/exit into PSR, when there are no updates from framework. Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 13 +

[PATCH v5 06/10] drm/bridge: use atomic enable/disable callbacks for panel bridge

2022-07-11 Thread Vinod Polimera
Use atomic variants for panel bridge callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Reviewed-by: Dmitry Baryshkov Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera --- drivers/gpu/drm/bridge/panel.c | 20 +++

[PATCH v5 02/10] drm: add helper functions to retrieve old and new crtc

2022-07-11 Thread Vinod Polimera
Add new helper functions, drm_atomic_get_old_crtc_for_encoder and drm_atomic_get_new_crtc_for_encoder to retrieve the corresponding crtc for the encoder. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera --- drivers/gpu/drm/drm_atomic.c | 60 +

[PATCH v5 07/10] drm/bridge: add psr support for panel bridge callbacks

2022-07-11 Thread Vinod Polimera
This change will handle the psr entry exit cases in the panel bridge atomic callback functions. For example, the panel power should not turn off if the panel is entering psr. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera --- drivers/gpu/drm/bridge/panel.c | 48 ++

[PATCH v5 10/10] drm/msm/disp/dpu1: check for crtc enable rather than crtc active to release shared resources

2022-07-11 Thread Vinod Polimera
According to KMS documentation, The driver must not release any shared resources if active is set to false but enable still true. Fixes: ccc862b957c6 ("drm/msm/dpu: Fix reservation failures in modeset") Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- 1 file

[PATCH v5 00/10] Add PSR support for eDP

2022-07-11 Thread Vinod Polimera
Changes in v2: - Use dp bridge to set psr entry/exit instead of dpu_enocder. - Don't modify whitespaces. - Set self refresh aware from atomic_check. - Set self refresh aware only if psr is supported. - Provide a stub for msm_dp_display_set_psr. - Move dp functions to bridge code. Chang

Re: [PATCH v3] drm/i915/ttm: fix sg_table construction

2022-07-11 Thread Das, Nirmoy
On 7/11/2022 10:58 AM, Matthew Auld wrote: If we encounter some monster sized local-memory page that exceeds the maximum sg length (UINT32_MAX), ensure that don't end up with some misaligned address in the entry that follows, leading to fireworks later. Also ensure we have some coverage of this

Re: [PATCH 02/11] fbdev/vga16fb: Create EGA/VGA devices in sysfb code

2022-07-11 Thread Javier Martinez Canillas
Hello Thomas, On 7/11/22 09:58, Thomas Zimmermann wrote: > Hi Javier, > > I'll try to give the motivation of this patch below. I known it's rather > hypothetical as the VGA driver is probably not used much. > > Am 08.07.22 um 15:09 schrieb Javier Martinez Canillas: >> Hello Thomas, >> >> On 7/7

Re: [PATCH 03/11] fbdev/vga16fb: Auto-generate module init/exit code

2022-07-11 Thread Javier Martinez Canillas
On 7/11/22 10:01, Thomas Zimmermann wrote: > Hi > > Am 08.07.22 um 15:16 schrieb Javier Martinez Canillas: >> On 7/7/22 17:39, Thomas Zimmermann wrote: >>> Move vgag16fb's option parsing into the driver's probe function and >>> generate the rest of the module's init/exit functions from macros. >>>

[PATCH v3 0/2] Add R16 Vista E board from RenewWorldOutreach

2022-07-11 Thread Suniel Mahesh
This patch series adds the R16-Vista-E board from RenewWorldOutreach based on allwinner R16(A33). Patch 1/2 adds the dt-bindings for the board. Patch 2/2 adds the board with the following below features: General features: - 1GB RAM - microSD slot - Realtek Wifi - 1 x USB 2.0 - HDMI IN - HDMI OUT

Re: [PATCH 3/5] dma-buf: return only unsignaled fences in dma_fence_unwrap_for_each v3

2022-07-11 Thread Christian König
Hi Karolina, Am 11.07.22 um 11:44 schrieb Karolina Drobnik: Hi Christian, I'm sorry for digging this one out so late. On 06.05.2022 16:10, Christian König wrote: dma_fence_chain containers cleanup signaled fences automatically, so filter those out from arrays as well. v2: fix missing walk ov

[PATCH v3 1/2] dt-bindings: arm: sunxi: Add binding for RenewWorldOutReach R16-Vista-E board

2022-07-11 Thread Suniel Mahesh
Add a binding for the RenewWorldOutReach R16-Vista-E board based on allwinner R16. Signed-off-by: Suniel Mahesh Signed-off-by: Jagan Teki Signed-off-by: Christopher Vollo Acked-by: Rob Herring --- Changes for v3: - As suggested by Samuel Holland: - vendor prefix documented - primary author of

[PATCH v3 2/2] ARM: dts: sun8i: Add R16 Vista E board from RenewWorldOutreach

2022-07-11 Thread Suniel Mahesh
The R16-Vista-E board from RenewWorldOutreach based on allwinner R16(A33). General features: - 1GB RAM - microSD slot - Realtek Wifi - 1 x USB 2.0 - HDMI IN - HDMI OUT - Audio out - MIPI DSI - TI DLPC3433 It has also connectors to connect an external mini keypad. Signed-off-by: Suniel Mahesh Si

[PATCH 1/2] drm: mxsfb: DRM_MXSFB should depend on ARCH_MXS || ARCH_MXC

2022-07-11 Thread Geert Uytterhoeven
Freescale/NXP i.MX LCDIF and eLCDIF LCD controllers are only present on Freescale/NXP i.MX SoCs. Hence add a dependency on ARCH_MXS || ARCH_MXC, to prevent asking the user about this driver when configuring a kernel without Freescale/NXP i.MX support. Fixes: 45d59d704080cc0c ("drm: Add new driver

[PATCH 2/2] drm: mxsfb: DRM_IMX_LCDIF should depend on ARCH_MXC

2022-07-11 Thread Geert Uytterhoeven
The Freescale/NXP i.MX LCDIFv3 LCD controller is only present on Freescale/NXP i.MX SoCs. Hence add a dependency on ARCH_MXC, to prevent asking the user about this driver when configuring a kernel without Freescale/NXP i.MX support. Fixes: 9db35bb349a0ef32 ("drm: lcdif: Add support for i.MX8MP LC

[PATCH 0/2] drm/msm: remove struct msm_display_dsc_config

2022-07-11 Thread Dmitry Baryshkov
The struct msm_display_dsc_config contains just a single member, a pointer to struct drm_dsc_config. Use the later one directly instead of wrapping it in the additional struct. Dmitry Baryshkov (2): drm/msm/dpu: use drm_dsc_config instead of msm_display_dsc_config drm/msm/dsi: use drm_dsc_conf

[PATCH 1/2] drm/msm/dpu: use drm_dsc_config instead of msm_display_dsc_config

2022-07-11 Thread Dmitry Baryshkov
There is no need to use the struct msm_display_dsc_config wrapper inside the dpu driver, use the struct drm_dsc_config directly to pass pps data. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 25 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 2 +- dri

[PATCH 2/2] drm/msm/dsi: use drm_dsc_config instead of msm_display_dsc_config

2022-07-11 Thread Dmitry Baryshkov
There is no need to use the struct msm_display_dsc_config wrapper inside the dsi driver, use the struct drm_dsc_config directly to pass pps data. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- drivers/gpu/drm/msm/dsi/dsi.c | 2 +- drivers/gpu/dr

Re: [PATCH v5 01/10] drm/msm/disp/dpu1: clear dpu_assign_crtc and get crtc from connector state instead of dpu_enc

2022-07-11 Thread Dmitry Baryshkov
On 11/07/2022 12:47, Vinod Polimera wrote: Update crtc retrieval from dpu_enc to dpu_enc connector state, since new links get set as part of the dpu enc virt mode set. The dpu_enc->crtc cache is no more needed, hence cleaning it as part of this change. Signed-off-by: Vinod Polimera --- driver

Re: [PATCH v5 00/10] Add PSR support for eDP

2022-07-11 Thread Dmitry Baryshkov
On 11/07/2022 12:47, Vinod Polimera wrote: Changes in v2: - Use dp bridge to set psr entry/exit instead of dpu_enocder. - Don't modify whitespaces. - Set self refresh aware from atomic_check. - Set self refresh aware only if psr is supported. - Provide a stub for msm_dp_display_set

Re: [PATCH v5 03/10] drm/msm/dp: use atomic callbacks for DP bridge ops

2022-07-11 Thread Dmitry Baryshkov
On 11/07/2022 12:47, Vinod Polimera wrote: Use atomic variants for DP bridge callback functions so that the atomic state can be accessed in the interface drivers. The atomic state will help the driver find out if the display is in self refresh state. Signed-off-by: Sankeerth Billakanti Signed-o

Re: [PATCH 3/3] drm/komeda - Fix handling of pending crtc state commit to avoid lock-up

2022-07-11 Thread Liviu Dudau
On Fri, Jul 08, 2022 at 07:03:37PM +0100, Carsten Haitzler wrote: > > > On 7/8/22 17:02, Liviu Dudau wrote: > > On Mon, Jun 06, 2022 at 12:47:14PM +0100, carsten.haitz...@foss.arm.com > > wrote: > > > From: Carsten Haitzler > > > > Hi Carsten, > > > > > > > > Sometimes there is an extra dcm

Re: [PATCH v5 04/10] drm/msm/dp: add basic PSR support for eDP

2022-07-11 Thread Dmitry Baryshkov
On 11/07/2022 12:47, Vinod Polimera wrote: Add support for basic panel self refresh (PSR) feature for eDP. Add a new interface to set PSR state in the sink from DPU. Program the eDP controller to issue PSR enter and exit SDP to the sink. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod

Re: [PATCH 2/2] drm: mxsfb: DRM_IMX_LCDIF should depend on ARCH_MXC

2022-07-11 Thread Marek Vasut
On 7/11/22 11:01, Geert Uytterhoeven wrote: The Freescale/NXP i.MX LCDIFv3 LCD controller is only present on Freescale/NXP i.MX SoCs. Hence add a dependency on ARCH_MXC, to prevent asking the user about this driver when configuring a kernel without Freescale/NXP i.MX support. Fixes: 9db35bb349a

Re: [PATCH 1/2] drm: mxsfb: DRM_MXSFB should depend on ARCH_MXS || ARCH_MXC

2022-07-11 Thread Marek Vasut
On 7/11/22 11:01, Geert Uytterhoeven wrote: Freescale/NXP i.MX LCDIF and eLCDIF LCD controllers are only present on Freescale/NXP i.MX SoCs. Hence add a dependency on ARCH_MXS || ARCH_MXC, to prevent asking the user about this driver when configuring a kernel without Freescale/NXP i.MX support.

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-07-11 Thread Robin Murphy
On 2022-06-25 16:31, Piotr Oniszczuk wrote: Wiadomość napisana przez Peter Geis w dniu 25.06.2022, o godz. 16:00: The first issue you have is the TV isn't responding until the absolute end. I suspect this is because lack on idle gaps between cec commands sent from board to tv. Maybe TV

Re: [PATCH 02/11] fbdev/vga16fb: Create EGA/VGA devices in sysfb code

2022-07-11 Thread Thomas Zimmermann
Hi Javier Am 11.07.22 um 11:54 schrieb Javier Martinez Canillas: Hello Thomas, On 7/11/22 09:58, Thomas Zimmermann wrote: Hi Javier, I'll try to give the motivation of this patch below. I known it's rather hypothetical as the VGA driver is probably not used much. Am 08.07.22 um 15:09 schrieb

Re: [PATCH 02/11] fbdev/vga16fb: Create EGA/VGA devices in sysfb code

2022-07-11 Thread Javier Martinez Canillas
On 7/11/22 12:42, Thomas Zimmermann wrote: > Hi Javier [...] >> That's why I think that "vga-framebuffer" as driver name would be misleading. >> Specially since it would also bind to the "ega-framebuffer" platform device. > > I messed up device and driver name, such that misunderstood your remar

Re: [PATCH 04/11] fbdev/core: Remove remove_conflicting_pci_framebuffers()

2022-07-11 Thread Javier Martinez Canillas
On 7/7/22 17:39, Thomas Zimmermann wrote: > Remove remove_conflicting_pci_framebuffers() and implement similar > functionality in aperture_remove_conflicting_pci_device(), which was > the only caller. Removes an otherwise unused interface and streamlines > the aperture helper. No functional changes

Re: [PATCH 05/11] fbdev: Convert drivers to aperture helpers

2022-07-11 Thread Javier Martinez Canillas
On 7/7/22 17:39, Thomas Zimmermann wrote: > Convert fbdev drivers from fbdev's remove_conflicting_framebuffers() to > the framework-independent aperture_remove_conflicting_devices(). Calling > this function will also remove conflicting DRM drivers. > > Signed-off-by: Thomas Zimmermann > --- [...

Re: [PATCH 4/5] drm/modes: Add support for driver-specific named modes

2022-07-11 Thread Thomas Zimmermann
Hi Am 11.07.22 um 11:35 schrieb Geert Uytterhoeven: Hi Thomas, On Mon, Jul 11, 2022 at 11:03 AM Thomas Zimmermann wrote: Am 08.07.22 um 20:21 schrieb Geert Uytterhoeven: The mode parsing code recognizes named modes only if they are explicitly listed in the internal whitelist, which is curren

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-07-11 Thread Piotr Oniszczuk
> Wiadomość napisana przez Robin Murphy w dniu > 11.07.2022, o godz. 12:41: > > On 2022-06-25 16:31, Piotr Oniszczuk wrote: >>> Wiadomość napisana przez Peter Geis w dniu >>> 25.06.2022, o godz. 16:00: >>> >>> >>> The first issue you have is the TV isn't responding until the absolute >>>

Re: [PATCH 4/5] drm/modes: Add support for driver-specific named modes

2022-07-11 Thread Thomas Zimmermann
Hi Maxime Am 11.07.22 um 11:35 schrieb Maxime Ripard: Hi Thomas, On Mon, Jul 11, 2022 at 11:03:38AM +0200, Thomas Zimmermann wrote: Am 08.07.22 um 20:21 schrieb Geert Uytterhoeven: The mode parsing code recognizes named modes only if they are explicitly listed in the internal whitelist, which

Re: [PATCH 06/11] fbdev: Remove conflicting devices on PCI bus

2022-07-11 Thread Javier Martinez Canillas
On 7/7/22 17:39, Thomas Zimmermann wrote: > Remove firmware devices on the PCI bus, by calling > aperture_remove_conflicting_pci_devices() in the probe function of > each related fbdev driver. iSo far, most of these drivers did not > remove conflicting VESA or EFI devices, or outride failed for > r

Re: [PATCH 07/11] video/aperture: Disable and unregister sysfb devices via aperture helpers

2022-07-11 Thread Javier Martinez Canillas
On 7/7/22 17:39, Thomas Zimmermann wrote: > Call sysfb_disable() before removing conflicting devices in aperture > helpers. Fixes sysfb state if fbdev has been disabled. > > Signed-off-by: Thomas Zimmermann > Fixes: fb84efa28a48 ("drm/aperture: Run fbdev removal before internal > helpers") > Cc:

Re: [PATCH 08/11] video: Provide constants for VGA I/O range

2022-07-11 Thread Javier Martinez Canillas
On 7/7/22 17:39, Thomas Zimmermann wrote: > Provide VGA_FB_ constants for the VGA framebuffer I/O range and convert > fbdev code. > I would probably mention in the commit message to that you are renaming s/VGA_FB_PHYS/VGA_FB_PHYS_BASE and s/VGA_FB_PHYS_LEN/VGA_FB_PHYS_SIZE. I do agree with the re

Re: [PATCH 09/11] video/aperture: Remove conflicting VGA devices, if any

2022-07-11 Thread Javier Martinez Canillas
On 7/7/22 17:39, Thomas Zimmermann wrote: > On the primary graphics adapter, a driver might conflict with a VGA > driver that controls the VGA framebuffer I/O range. Remove the VGA > driver from the aperture helpers. Until now, this case has been > hendled by fbdev, but it should work even with fbd

Re: [PATCH 10/11] fbdev: Acquire framebuffer apertures for firmware devices

2022-07-11 Thread Javier Martinez Canillas
On 7/7/22 17:39, Thomas Zimmermann wrote: > When registering a generic framebuffer, automatically acquire ownership > of the framebuffer's I/O range. The device will now be handled by the > aperture helpers. Fbdev-based conflict handling is no longer required. > > Signed-off-by: Thomas Zimmermann

Re: [PATCH 11/11] fbdev: Remove conflict-handling code

2022-07-11 Thread Javier Martinez Canillas
On 7/7/22 17:39, Thomas Zimmermann wrote: > Remove the call to do_remove_conflicting_framebuffers() from the > framebuffer registration. Aperture helpers take care of removing > conflicting devices. With all ownership information stored in the > aperture datastrcutures, remove remove_conflicting_fr

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-07-11 Thread Robin Murphy
On 2022-07-11 12:04, Piotr Oniszczuk wrote: Wiadomość napisana przez Robin Murphy w dniu 11.07.2022, o godz. 12:41: On 2022-06-25 16:31, Piotr Oniszczuk wrote: Wiadomość napisana przez Peter Geis w dniu 25.06.2022, o godz. 16:00: The first issue you have is the TV isn't responding unti

Re: [PATCH v2 04/11] dt-bindings: display/msm: split qcom, mdss bindings

2022-07-11 Thread Krzysztof Kozlowski
On 10/07/2022 11:00, Dmitry Baryshkov wrote: Thank you for your patch. There is something to discuss/improve. > +required: > + - compatible > + - reg > + - reg-names > + - interrupts > + - interrupt-controller > + - "#interrupt-cells" > + - power-domains > + - clocks > + - clock-names >

Re: [PATCH 4/5] drm/modes: Add support for driver-specific named modes

2022-07-11 Thread Maxime Ripard
On Mon, Jul 11, 2022 at 01:11:14PM +0200, Thomas Zimmermann wrote: > Hi Maxime > > Am 11.07.22 um 11:35 schrieb Maxime Ripard: > > Hi Thomas, > > > > On Mon, Jul 11, 2022 at 11:03:38AM +0200, Thomas Zimmermann wrote: > > > Am 08.07.22 um 20:21 schrieb Geert Uytterhoeven: > > > > The mode parsing

Re: [PATCH 4/5] drm/modes: Add support for driver-specific named modes

2022-07-11 Thread Geert Uytterhoeven
Hi Maxime, On Mon, Jul 11, 2022 at 1:42 PM Maxime Ripard wrote: > On Mon, Jul 11, 2022 at 01:11:14PM +0200, Thomas Zimmermann wrote: > > Am 11.07.22 um 11:35 schrieb Maxime Ripard: > > > On Mon, Jul 11, 2022 at 11:03:38AM +0200, Thomas Zimmermann wrote: > > > > Am 08.07.22 um 20:21 schrieb Geert

Re: [PATCH 4/5] drm/modes: Add support for driver-specific named modes

2022-07-11 Thread Maxime Ripard
On Mon, Jul 11, 2022 at 01:59:28PM +0200, Geert Uytterhoeven wrote: > Hi Maxime, > > On Mon, Jul 11, 2022 at 1:42 PM Maxime Ripard wrote: > > On Mon, Jul 11, 2022 at 01:11:14PM +0200, Thomas Zimmermann wrote: > > > Am 11.07.22 um 11:35 schrieb Maxime Ripard: > > > > On Mon, Jul 11, 2022 at 11:03:

Re: [PATCH 4/5] drm/modes: Add support for driver-specific named modes

2022-07-11 Thread Geert Uytterhoeven
Hi Maxime, On Mon, Jul 11, 2022 at 2:02 PM Maxime Ripard wrote: > On Mon, Jul 11, 2022 at 01:59:28PM +0200, Geert Uytterhoeven wrote: > > On Mon, Jul 11, 2022 at 1:42 PM Maxime Ripard wrote: > > > On Mon, Jul 11, 2022 at 01:11:14PM +0200, Thomas Zimmermann wrote: > > > > Am 11.07.22 um 11:35 sch

Re: [PATCH libdrm v2 04/10] util: Add missing big-endian RGB16 frame buffer formats

2022-07-11 Thread Ville Syrjälä
On Fri, Jul 08, 2022 at 08:21:43PM +0200, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > Any better suggestion than appending "be"? > > v2: > - New. > --- > tests/util/format.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/util/format.c b/tests/util/

Re: [PATCH 3/5] dma-buf: return only unsignaled fences in dma_fence_unwrap_for_each v3

2022-07-11 Thread Karolina Drobnik
Hi Christian, On 11.07.2022 11:57, Christian König wrote: Hi Karolina, Am 11.07.22 um 11:44 schrieb Karolina Drobnik: Hi Christian, I'm sorry for digging this one out so late. On 06.05.2022 16:10, Christian König wrote: dma_fence_chain containers cleanup signaled fences automatically, so fi

Re: [PATCH 3/5] dma-buf: return only unsignaled fences in dma_fence_unwrap_for_each v3

2022-07-11 Thread Christian König
Hi Karolina, Am 11.07.22 um 14:17 schrieb Karolina Drobnik: Hi Christian, On 11.07.2022 11:57, Christian König wrote: Hi Karolina, Am 11.07.22 um 11:44 schrieb Karolina Drobnik: Hi Christian, I'm sorry for digging this one out so late. On 06.05.2022 16:10, Christian König wrote: dma_fence

Re: [PATCH v3 0/4] drm: rename CMA helpers to DMA helpers

2022-07-11 Thread Danilo Krummrich
On 7/7/22 19:39, Danilo Krummrich wrote: This patch series renames all CMA helpers to DMA helpers - considering the hierarchy of APIs (mm/cma -> dma -> gem/fb dma helpers) calling them DMA helpers seems to be more applicable. Additionally, commit e57924d4ae80 ("drm/doc: Task to rename CMA helper

Re: [PATCH libdrm v2 04/10] util: Add missing big-endian RGB16 frame buffer formats

2022-07-11 Thread Geert Uytterhoeven
Hi Ville, On Mon, Jul 11, 2022 at 2:17 PM Ville Syrjälä wrote: > On Fri, Jul 08, 2022 at 08:21:43PM +0200, Geert Uytterhoeven wrote: > > Signed-off-by: Geert Uytterhoeven > > --- > > Any better suggestion than appending "be"? > > > > v2: > > - New. > > --- a/tests/util/format.c > > +++ b/test

Re: [PATCH v3 0/4] drm: rename CMA helpers to DMA helpers

2022-07-11 Thread Laurent Pinchart
Hi Danilo, On Mon, Jul 11, 2022 at 02:32:53PM +0200, Danilo Krummrich wrote: > On 7/7/22 19:39, Danilo Krummrich wrote: > > This patch series renames all CMA helpers to DMA helpers - considering the > > hierarchy of APIs (mm/cma -> dma -> gem/fb dma helpers) calling them DMA > > helpers seems to b

Re: [PATCH 3/5] dma-buf: return only unsignaled fences in dma_fence_unwrap_for_each v3

2022-07-11 Thread Karolina Drobnik
Hi Christian, On 11.07.2022 14:25, Christian König wrote: Hi Karolina, Am 11.07.22 um 14:17 schrieb Karolina Drobnik: Hi Christian, On 11.07.2022 11:57, Christian König wrote: Hi Karolina, Am 11.07.22 um 11:44 schrieb Karolina Drobnik: Hi Christian, I'm sorry for digging this one out so l

[PATCH v6 06/10] drm/bridge: use atomic enable/disable callbacks for panel bridge

2022-07-11 Thread Vinod Polimera
Use atomic variants for panel bridge callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Reviewed-by: Dmitry Baryshkov Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera --- drivers/gpu/drm/bridge/panel.c | 20 +++

  1   2   3   >