[PATCH v2 0/9] dt-bindings: msm/dp: cleanup Qualcomm DP and eDP bidndings

2022-07-10 Thread Dmitry Baryshkov
Fix several issues with the DP and eDP bindings on the Qualcomm platforms. While we are at it, fix several small issues with platform files declaring these controllers. Changes since v1: - Reordered patches to cleanup dts first, to remove warnings from DP schema - Split DP register blocks in

[PATCH v2 3/9] arm64: dts: qcom: sc7280: split register block for DP controller

2022-07-10 Thread Dmitry Baryshkov
Follow the schema for the DP controller and declare 5 register regions instead of using a single region for all the registers. Note, this extends the dts by adding p1 region to the DP node (to be used for DP MST). Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 6 +

[PATCH v2 1/9] arm64: dts: qcom: sc7180: split register block for DP controller

2022-07-10 Thread Dmitry Baryshkov
Follow the schema for the DP controller and declare 5 register regions instead of using a single region for all the registers. Note, this extends the dts by adding p1 region to the DP node (to be used for DP MST). Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 6 +

[PATCH v2 4/9] arm64: dts: qcom: sc7280: drop #clock-cells from displayport-controller

2022-07-10 Thread Dmitry Baryshkov
Drop #clock-cells from DP device node. It is a leftover from the times before splitting the deviice into controller and PHY devices. Now the clocks are provided by the PHY, while the controller doesn't provide any clocks. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- arch/arm64/

[PATCH v2 6/9] arm64: dts: qcom: sc7280: drop unused clocks from eDP node

2022-07-10 Thread Dmitry Baryshkov
The eDP node includes two clocks which are used by the eDP PHY rather than eDP controller itself. Drop these clocks to remove extra difference between eDP and DP controllers. Suggested-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++-- 1 file

[PATCH v2 7/9] dt-bindings: msm/dp: mark vdda supplies as deprecated

2022-07-10 Thread Dmitry Baryshkov
The commit fa384dd8b9b8 ("drm/msm/dp: delete vdda regulator related functions from eDP/DP controller") removed support for VDDA supplies from the DP controller driver. These supplies are now handled by the eDP or QMP PHYs. Mark these properties as deprecated and drop them from the example. Signed-

[PATCH v2 2/9] arm64: dts: qcom: sc7180: drop #clock-cells from displayport-controller

2022-07-10 Thread Dmitry Baryshkov
Drop #clock-cells from DP device node. It is a leftover from the times before splitting the device into controller and PHY devices. Now the clocks are provided by the PHY, while the controller doesn't provide any clocks. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- arch/arm64/b

[PATCH v2 5/9] arm64: dts: qcom: sc7280: drop address/size-cells from eDP node

2022-07-10 Thread Dmitry Baryshkov
Drop #address/#size-cells from eDP device node. For eDP the panels are not described directly under the controller node. They are either present under aux-bus child node, or they are declared separately (e.g. in a /soc node). Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- arch/ar

[PATCH v2 9/9] dt-bindings: msm/dp: handle DP vs eDP difference

2022-07-10 Thread Dmitry Baryshkov
The #sound-dai-cells property should be used only for DP controllers. It doesn't make sense for eDP, there is no support for audio output. The aux-bus should not be used for DP controllers. Also p1 MMIO region should be used only for DP controllers. Take care of these differences. Signed-off-by:

[PATCH v2 8/9] dt-bindings: msm/dp: add missing properties

2022-07-10 Thread Dmitry Baryshkov
Document missing definitions for opp-table (DP controller OPPs), aux-bus (DP AUX BUS) and data-lanes (DP/eDP lanes mapping) properties. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dp-controller.yaml | 12 1 file changed, 12 insert

[PATCH v1 0/11] drm/via: Make via a single file driver

2022-07-10 Thread Sam Ravnborg
We have an upcoming openchrome driver for VIA where some of the files conflicts with the existing via driver. It is not acceptable to just delete the existing DRI1 based driver as there are most likely users out there, so a different approach was required. It was disccussed what to do and the lea

[PATCH v1 01/11] drm/via: Rename via_drv to via_dri1

2022-07-10 Thread Sam Ravnborg
The via driver implements the DRI1 interface, and we have a new implementation of the via driver coming that supports atomic modesetting. It is not acceptable just to replace the existing driver so this is first step to make it a single-file implementation allowing it to stay without interfering w

[PATCH v1 02/11] drm/via: Embed via_dma in via_dri1

2022-07-10 Thread Sam Ravnborg
Moved the copyright notices so all copyrights are kept. A few variables was made static as there are no more users outside this file. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/Makefile | 2 +- drivers/gpu/drm/via/via_dma.c | 744 - drivers/gpu/drm/v

[PATCH v1 04/11] drm/via: Embed via_mm in via_dri1

2022-07-10 Thread Sam Ravnborg
All functions was made static as there are no external users. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/Makefile | 2 +- drivers/gpu/drm/via/via_dri1.c | 208 drivers/gpu/drm/via/via_drv.h | 9 -- drivers/gpu/drm/via/via_mm.c | 241

[PATCH v1 03/11] drm/via: Embed via_map in via_dri1

2022-07-10 Thread Sam Ravnborg
A few functions has no external use and are made static. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/Makefile | 2 +- drivers/gpu/drm/via/via_dri1.c | 102 + drivers/gpu/drm/via/via_drv.h | 4 - drivers/gpu/drm/via/via_map.c | 132 -

[PATCH v1 06/11] drm/via: Embed via_irq in via_dri1

2022-07-10 Thread Sam Ravnborg
All functions are made static as there are no more external users. The file had new copyrights that are kept. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/Makefile | 2 +- drivers/gpu/drm/via/via_dri1.c | 347 + drivers/gpu/drm/via/via_drv.h | 9 - drive

[PATCH v1 05/11] drm/via: Embed via_video in via_dri1

2022-07-10 Thread Sam Ravnborg
All functions are made static as there are no more external users. The file had a new copyright that is kept. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/Makefile| 2 +- drivers/gpu/drm/via/via_dri1.c | 66 ++- drivers/gpu/drm/via/via_drv.h | 4 -- drivers/gp

[PATCH v1 07/11] drm/via: Embed via_dmablit in via_dri1

2022-07-10 Thread Sam Ravnborg
Embed some of the header file in via_drv.h and the rest in via_dri1.c While embedding deleted extra empty lines and functions that has no external users are made static. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/Makefile | 2 +- drivers/gpu/drm/via/via_dmablit.c | 807 --

[PATCH v1 09/11] drm/via: Embed via_drv.h in via_dri1

2022-07-10 Thread Sam Ravnborg
With this change the driver is now a signle file driver. The only remaning heder file describes the HW and can be shared with the new openchrome driver. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/via_dri1.c | 229 +++- drivers/gpu/drm/via/via_drv.h | 265 ---

[PATCH v1 08/11] drm/via: Embed via_verifier in via_dri1

2022-07-10 Thread Sam Ravnborg
Embed the header file in via_drv.h and the code in via_dri1. All functions are made static as there are no more external users. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/Makefile |2 +- drivers/gpu/drm/via/via_dri1.c | 1071 +++ drivers/gpu/drm/via

[PATCH v1 10/11] drm/via: Rename the via driver to via_dri1

2022-07-10 Thread Sam Ravnborg
The via driver is a dri1 driver. Make this obvious in the name of the driver. This also make the diver name "via" free for the upcoming openchrome driver. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/

[PATCH v1 11/11] drm/via: Update to the latest via_3d_reg file

2022-07-10 Thread Sam Ravnborg
Updated the 3d_reg header file to match what is used by the openchrome driver. This verifies that the two drivers can use the same header file. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/via_3d_reg.h | 395 --- 1 file changed, 304 insertions(+), 91 deletions(

[PATCH v2 00/11] dt-bindings: display/msm: rework MDSS and DPU bindings

2022-07-10 Thread Dmitry Baryshkov
Create separate YAML schema for MDSS devicesd$ (both for MDP5 and DPU devices). Cleanup DPU schema files, so that they do not contain schema for both MDSS and DPU nodes. Apply misc small fixes to the DPU schema afterwards. Changes since v1: - Renamed DPU device nodes from mdp@ to display-controll

[PATCH v2 01/11] arm64: dts: qcom: sdm845: rename DPU device node

2022-07-10 Thread Dmitry Baryshkov
Rename DPU device node to display-controller@ae01000 to follow the DPU schema. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi

[PATCH v2 02/11] arm64: dts: qcom: sc7180: rename DPU device node

2022-07-10 Thread Dmitry Baryshkov
Rename DPU device node to display-controller@ae01000 to follow the DPU schema. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi

[PATCH v2 08/11] dt-bindings: display/msm: move qcom, qcm2290-mdss schema to mdss.yaml

2022-07-10 Thread Dmitry Baryshkov
Move schema for qcom,qcm2290-mdss from dpu-qcm2290.yaml to mdss.yaml so that the dpu file describes only the DPU schema. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-qcm2290.yaml | 140 +- .../devicetree/bindings/display/msm/mdss.yaml | 24 +++ 2 files ch

[PATCH v2 05/11] dt-bindings: display/msm: move qcom, sdm845-mdss schema to mdss.yaml

2022-07-10 Thread Dmitry Baryshkov
Move schema for qcom,sdm845-mdss from dpu-sdm845.yaml to mdss.yaml so that the dpu file describes only the DPU schema. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sdm845.yaml | 135 --- .../devicetree/bindings/display/msm/mdss.yaml | 156 ++

[PATCH v2 06/11] dt-bindings: display/msm: move qcom, sc7180-mdss schema to mdss.yaml

2022-07-10 Thread Dmitry Baryshkov
Move schema for qcom,sc7180-mdss from dpu-sc7180.yaml to mdss.yaml so that the dpu file describes only the DPU schema. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sc7180.yaml | 149 +- .../devicetree/bindings/display/msm/mdss.yaml | 45 +- 2 files c

[PATCH v2 07/11] dt-bindings: display/msm: move qcom, sc7280-mdss schema to mdss.yaml

2022-07-10 Thread Dmitry Baryshkov
Move schema for qcom,sc7280-mdss from dpu-sc7280.yaml to mdss.yaml so that the dpu file describes only the DPU schema. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sc7280.yaml | 148 +- .../devicetree/bindings/display/msm/mdss.yaml | 19 +++ 2 files chan

[PATCH v2 09/11] dt-bindings: display/msm: move qcom, msm8998-mdss schema to mdss.yaml

2022-07-10 Thread Dmitry Baryshkov
Move schema for qcom,msm8998-mdss from dpu-msm8998.yaml to mdss.yaml so that the dpu file describes only the DPU schema. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-msm8998.yaml | 142 +- .../devicetree/bindings/display/msm/mdss.yaml | 24 +++ 2 files ch

[PATCH v2 04/11] dt-bindings: display/msm: split qcom, mdss bindings

2022-07-10 Thread Dmitry Baryshkov
Split Mobile Display SubSystem (MDSS) root node bindings to the separate yaml file. Changes to the existing (txt) schema: - Added optional "vbif_nrt_phys" region used by msm8996 - Made "bus" and "vsync" clocks optional (they are not used by some platforms) - Added (optional) "core" clock adde

[PATCH v2 11/11] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-07-10 Thread Dmitry Baryshkov
Move properties common to all DPU DT nodes to the dpu-common.yaml. Note, this removes description of individual DPU port@ nodes. However such definitions add no additional value. The reg values do not correspond to hardware INTF indices. The driver discovers and binds these ports not paying any ca

[PATCH v2 03/11] arm64: dts: qcom: sm8250: rename DPU device node

2022-07-10 Thread Dmitry Baryshkov
Rename DPU device node to display-controller@ae01000 to follow the DPU schema. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi

[PATCH v2 10/11] dt-bindings: display/mdm: add gcc-bus clock to dpu-smd845

2022-07-10 Thread Dmitry Baryshkov
Add gcc-bus clock required for the SDM845 DPU device tree node. This change was made in the commit 111c52854102 ("arm64: dts: qcom: sdm845: move bus clock to mdp node for sdm845 target"), but was not reflected in the schema. Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/display/msm

Re: [PATCH v2 1/2] dt-bindings: display: panel: Add Novatek NT35596S panel bindings

2022-07-10 Thread Sam Ravnborg
Hi Molly, On Sun, Jul 10, 2022 at 02:19:41PM +0800, Molly Sophia wrote: > Hi Sam, > > Thanks for your suggestions. > > Sam Ravnborg 于 2022年7月10日周日 上午4:47写道: > > > Hi Molly, > > > > thanks for the quick response to the review comments. > > > > On Sat, Jul 09, 2022 at 10:11:35PM +0800, MollySoph

Re: [PATCH libdrm v2 01/10] util: Improve SMPTE color LUT accuracy

2022-07-10 Thread Sam Ravnborg
Hi Geert, On Fri, Jul 08, 2022 at 08:21:31PM +0200, Geert Uytterhoeven wrote: > Fill in the LSB when converting color components from 8-bit to 16-bit. > > Signed-off-by: Geert Uytterhoeven > --- > v2: > - New. > --- > tests/util/pattern.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 delet

Re: [PATCH libdrm v2 00/10] Add support for low-color frame buffer formats

2022-07-10 Thread Sam Ravnborg
Hi Geert, On Fri, Jul 08, 2022 at 08:21:30PM +0200, Geert Uytterhoeven wrote: > Hi all, > > A long outstanding issue with the DRM subsystem has been the lack of > support for low-color displays, as used typically on older desktop > systems, and on small embedded displays. > > This patch se

[Bug 216143] [bisected] garbled screen when starting X + dmesg cluttered with "[drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* Failed in the dependencies handling -1431655766!"

2022-07-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216143 --- Comment #8 from Erhard F. (erhar...@mailbox.org) --- Tried https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-fixes&id=925b6e59138cefa47275c67891c65d48d3266d57 suggested in https://gitlab.freedesktop.org/drm/amd/-/issues/2050#note_14

Re: [PATCH libdrm v2 01/10] util: Improve SMPTE color LUT accuracy

2022-07-10 Thread Geert Uytterhoeven
Hi Sam, On Sun, Jul 10, 2022 at 12:31 PM Sam Ravnborg wrote: > On Fri, Jul 08, 2022 at 08:21:31PM +0200, Geert Uytterhoeven wrote: > > Fill in the LSB when converting color components from 8-bit to 16-bit. > > > > Signed-off-by: Geert Uytterhoeven > > --- > > v2: > > - New. > > --- > > tests/

Re: [PATCH v2 1/2] dt-bindings: display: panel: Add Novatek NT35596S panel bindings

2022-07-10 Thread Molly Sophia
Hi Sam, Thank you again for your support. I forgot that point, which is really important to know. Molly Sam Ravnborg 于2022年7月10日周日 18:13写道: > Hi Molly, > > On Sun, Jul 10, 2022 at 02:19:41PM +0800, Molly Sophia wrote: > > Hi Sam, > > > > Thanks for your suggestions. > > > > Sam Ravnborg 于

Re: [PATCH libdrm v2 01/10] util: Improve SMPTE color LUT accuracy

2022-07-10 Thread Sam Ravnborg
Hi Geert, On Sun, Jul 10, 2022 at 01:04:23PM +0200, Geert Uytterhoeven wrote: > Hi Sam, > > On Sun, Jul 10, 2022 at 12:31 PM Sam Ravnborg wrote: > > On Fri, Jul 08, 2022 at 08:21:31PM +0200, Geert Uytterhoeven wrote: > > > Fill in the LSB when converting color components from 8-bit to 16-bit. >

Re: [PATCH libdrm v2 00/10] Add support for low-color frame buffer formats

2022-07-10 Thread Geert Uytterhoeven
Hi Sam, On Sun, Jul 10, 2022 at 12:40 PM Sam Ravnborg wrote: > On Fri, Jul 08, 2022 at 08:21:30PM +0200, Geert Uytterhoeven wrote: > > A long outstanding issue with the DRM subsystem has been the lack of > > support for low-color displays, as used typically on older desktop > > systems, and on sm

Re: [PATCH] staging: fbtft: replace udelay with usleep_range

2022-07-10 Thread Christos Kollintzas
On Sat, Jul 09, 2022 at 12:30:51PM +0200, Greg KH wrote: > On Sat, Jul 09, 2022 at 01:06:56PM +0300, Christos Kollintzas wrote: > > Adhere to Linux kernel coding style. > > > > Reported by checkpatch: > > > > CHECK: usleep_range is preferred over udelay > > > > Signed-off-by: Christos Kollintzas

Re: [PATCH 1/6] dt-bindings/display: ingenic: Add compatible string for the JZ4760(B)

2022-07-10 Thread Krzysztof Kozlowski
On 08/07/2022 22:54, Paul Cercueil wrote: > Add compatible strings for the LCD controllers found in the JZ4760 and > JZ4760B SoCs from Ingenic. > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

[pull] drm/msm: drm-msm-next-2022-07-10 for v5.20

2022-07-10 Thread Rob Clark
Hi Dave & Daniel, Here is main drm/msm pull for v5.20, description below and in tag The following changes since commit b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3: Linux 5.19-rc2 (2022-06-12 16:11:37 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/drm/msm.git tag

[PATCH -next] drm/amdgpu: double free error and freeing uninitialized null pointer

2022-07-10 Thread Sebin Sebastian
Fix two coverity warning's double free and and an uninitialized pointer read. Both tmp and new are pointing at same address and both are freed which leads to double free. Freeing tmp in the condition after new is assigned with new address fixes the double free issue. new is not initialized to null

VKMS driver Kernel 5.4 - vkms_vblank_simulate: vblank timer overrun

2022-07-10 Thread Mohd Yusuf Abdul Hamid
Hi Developers, I am seeing thrashing of errors print once Android kernel trying to enable SurfaceFlinger (swiftshader) stuff. [drm:drm_calc_timestamping_constants] *ERROR* crtc 32: Can't calculate constants, dotclock = 0! [ 19.985323][C0] vkms_vblank_simulate: vblank timer overrun [ 19.991

Re: [PATCH v2 1/2] dt-bindings: display: panel: Add Novatek NT35596S panel bindings

2022-07-10 Thread Rob Herring
On Sat, 09 Jul 2022 22:11:35 +0800, MollySophia wrote: > Add documentation for "novatek,nt35596s" panel. > > Signed-off-by: MollySophia > --- > .../display/panel/novatek,nt35596s.yaml | 83 +++ > 1 file changed, 83 insertions(+) > create mode 100644 > Documentation/device

Re: [PATCH v2 04/11] dt-bindings: display/msm: split qcom, mdss bindings

2022-07-10 Thread Rob Herring
On Sun, 10 Jul 2022 12:00:33 +0300, Dmitry Baryshkov wrote: > Split Mobile Display SubSystem (MDSS) root node bindings to the separate > yaml file. Changes to the existing (txt) schema: > - Added optional "vbif_nrt_phys" region used by msm8996 > - Made "bus" and "vsync" clocks optional (they are

Re: [PATCH v2 04/11] dt-bindings: display/msm: split qcom, mdss bindings

2022-07-10 Thread Dmitry Baryshkov
On 10/07/2022 19:54, Rob Herring wrote: On Sun, 10 Jul 2022 12:00:33 +0300, Dmitry Baryshkov wrote: Split Mobile Display SubSystem (MDSS) root node bindings to the separate yaml file. Changes to the existing (txt) schema: - Added optional "vbif_nrt_phys" region used by msm8996 - Made "bus" a

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-07-10 Thread Piotr Oniszczuk
> Wiadomość napisana przez Piotr Oniszczuk w dniu > 25.06.2022, o godz. 17:31: > > > >> Wiadomość napisana przez Peter Geis w dniu 25.06.2022, >> o godz. 16:00: >> >> >> The first issue you have is the TV isn't responding until the absolute >> end. > > I suspect this is because lack on

[RFC PATCH 0/3] drm/bridge: ti-sn65dsi86: support DRM_BRIDGE_ATTACH_NO_CONNECTOR

2022-07-10 Thread Dmitry Baryshkov
An RFC (or rather RFT, Request-for-Testing) series adding support for DRM_BRIDGE_ATTACH_NO_CONNECTOR. Note, it was compile-tested only. This bridge is the last one used on the Qualcomm platforms (in upstream-supported devices) and thus it is the only bridge that prevents us from removing support f

[RFC PATCH 1/3] drm/bridge: ti-sn65dsi86: switch to atomic ops

2022-07-10 Thread Dmitry Baryshkov
Make ti-sn65dsi86 use atomic_enable / atomic_disable / atomic_pre_enable / atomic_post_disable rather than their non-atomic versions. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git

[RFC PATCH 2/3] drm/bridge: ti-sn65dsi86: fetch bpc using drm_atomic_state

2022-07-10 Thread Dmitry Baryshkov
Rather than reading the pdata->connector directly, fetch the connector using drm_atomic_state. This allows us to make pdata->connector optional (and thus supporting DRM_BRIDGE_ATTACH_NO_CONNECTOR). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 20 ++-

[RFC PATCH 3/3] drm/bridge: ti-sn65dsi86: support DRM_BRIDGE_ATTACH_NO_CONNECTOR

2022-07-10 Thread Dmitry Baryshkov
Now as the driver does not depend on pdata->connector, add support for attaching the bridge with DRM_BRIDGE_ATTACH_NO_CONNECTOR. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/

Re: [RFC PATCH 1/3] drm/bridge: ti-sn65dsi86: switch to atomic ops

2022-07-10 Thread Sam Ravnborg
Hi Dmitry, On Sun, Jul 10, 2022 at 09:45:34PM +0300, Dmitry Baryshkov wrote: > Make ti-sn65dsi86 use atomic_enable / atomic_disable / atomic_pre_enable > / atomic_post_disable rather than their non-atomic versions. > > Signed-off-by: Dmitry Baryshkov a more or less identical patch was applied t

Re: [RFC PATCH 2/3] drm/bridge: ti-sn65dsi86: fetch bpc using drm_atomic_state

2022-07-10 Thread Sam Ravnborg
Hi Dmitry, On Sun, Jul 10, 2022 at 09:45:35PM +0300, Dmitry Baryshkov wrote: > Rather than reading the pdata->connector directly, fetch the connector > using drm_atomic_state. This allows us to make pdata->connector optional > (and thus supporting DRM_BRIDGE_ATTACH_NO_CONNECTOR). > > Signed-off-b

Re: [RFC PATCH 3/3] drm/bridge: ti-sn65dsi86: support DRM_BRIDGE_ATTACH_NO_CONNECTOR

2022-07-10 Thread Sam Ravnborg
Hi Dmitry, On Sun, Jul 10, 2022 at 09:45:36PM +0300, Dmitry Baryshkov wrote: > Now as the driver does not depend on pdata->connector, add support for > attaching the bridge with DRM_BRIDGE_ATTACH_NO_CONNECTOR. > > Signed-off-by: Dmitry Baryshkov Looks good, Reviewed-by: Sam Ravnborg

[PATCH 2/9] drm/panel/panel-sitronix-st7701: Enable DSI burst mode, LPM, non-continuous clock

2022-07-10 Thread Marek Vasut
The ST7701(S) is capable of DSI burst mode, which is more energy efficient than the non-burst modes. Make use of it. The ST7701(S) is capable of DSI non-continuous clock, since it sources the TFT matrix driver clock from internal clock source. The DSI non-continuous clock further reduce power util

[PATCH 4/9] drm/panel/panel-sitronix-st7701: Make gamma correction TFT specific

2022-07-10 Thread Marek Vasut
The gamma correction values are specific to the TFT which is attached to the ST7701 TFT matrix driver, move the gamma correction values from what incorrectly looks like common init sequence into TFT matrix specific settings. While doing so, add macros which defined fields within the gamma register

[PATCH 6/9] drm/panel/panel-sitronix-st7701: Adjust porch control bitfield name

2022-07-10 Thread Marek Vasut
Define DSI_CMD2_BK0_PORCTRL_VBP_MASK and DSI_CMD2_BK0_PORCTRL_VFP_MASK and move the vertical back and front porch calculation from macros into the st7701_init_sequence() function, so it is clear what this does. No functional change. Signed-off-by: Marek Vasut Cc: Guido Günther Cc: Jagan Teki C

[PATCH 7/9] drm/panel/panel-sitronix-st7701: Infer horizontal pixel count from TFT mode

2022-07-10 Thread Marek Vasut
The horizontal pixel count is a property of the TFT matrix. Currently the driver hard-codes content of this register to specific value which is only compatible with one TFT matrix, likely the TS8550B one. Calculate the horizontal pixel count from the mode instead. Signed-off-by: Marek Vasut Cc:

[PATCH 1/9] drm/panel/panel-sitronix-st7701: Make DSI mode flags common to ST7701

2022-07-10 Thread Marek Vasut
The ST7701 and ST7701S are TFT matrix drivers with integrated multi protocol decoder capable of DSI/DPI/SPI input and 480x360...864 line TFT matrix output. Currently the only supported input is DSI. The protocol decoder is separate from the TFT matrix driver and is always capable of handling all o

[PATCH 5/9] drm/panel/panel-sitronix-st7701: Infer vertical line count from TFT mode

2022-07-10 Thread Marek Vasut
The vertical line count is a property of the TFT matrix. Currently the driver hard-codes content of this register to specific value which is only compatible with one TFT matrix, likely the TS8550B one. Calculate the vertical line count from the mode instead. Signed-off-by: Marek Vasut Cc: Guido

[PATCH 3/9] drm/panel/panel-sitronix-st7701: Make voltage supplies common to ST7701

2022-07-10 Thread Marek Vasut
The ST7701 and ST7701S all have two voltage supplies, one for internal logic and one for the TFT matrix driver. The supplies are not property of the TFT matrix driver, so move them to common ST7701 code. Signed-off-by: Marek Vasut Cc: Guido Günther Cc: Jagan Teki Cc: Laurent Pinchart Cc: Linus

[PATCH 8/9] drm/panel/panel-sitronix-st7701: Parametrize voltage and timing

2022-07-10 Thread Marek Vasut
Instead of hard-coding TFT matrix voltage and timing settings, which can even lead to permanent TFT matrix damage, parametrize them in TFT matrix descriptor. Signed-off-by: Marek Vasut Cc: Guido Günther Cc: Jagan Teki Cc: Laurent Pinchart Cc: Linus Walleij Cc: Sam Ravnborg Cc: Thierry Reding

[PATCH 9/9] drm/panel/panel-sitronix-st7701: Split GIP and init sequences

2022-07-10 Thread Marek Vasut
The ST7701 initialization sequence is well parametrized, split the GIP programming sequence, which is fully custom completely undocumented TFT matrix specific magic register programming sequence into separate callback so other TFT matrix definitions can add their own GIP sequence. Signed-off-by: M

drm-tip amdgpu not compiling, possible fix attached

2022-07-10 Thread Hans de Goede
Hi All, I've been rebasing my backlight refactor on top of drm-tip to submit a new version upstream and I noticed that drm-tip does not compile. This is caused by a mismerge of: commit 925b6e59138cefa47275c67891c65d48d3266d57 (drm-misc/for-linux-next-fixes, drm-misc/drm-misc-fixes, drm-misc-fix

Re: [RFC PATCH 3/3] drm/bridge: ti-sn65dsi86: support DRM_BRIDGE_ATTACH_NO_CONNECTOR

2022-07-10 Thread Laurent Pinchart
Hi Dmitry, Thank you for the patch. On Sun, Jul 10, 2022 at 09:45:36PM +0300, Dmitry Baryshkov wrote: > Now as the driver does not depend on pdata->connector, add support for > attaching the bridge with DRM_BRIDGE_ATTACH_NO_CONNECTOR. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm

Re: [RFC PATCH 2/3] drm/bridge: ti-sn65dsi86: fetch bpc using drm_atomic_state

2022-07-10 Thread Laurent Pinchart
Hi Dmitry, Thank you for the patch. On Sun, Jul 10, 2022 at 09:45:35PM +0300, Dmitry Baryshkov wrote: > Rather than reading the pdata->connector directly, fetch the connector > using drm_atomic_state. This allows us to make pdata->connector optional > (and thus supporting DRM_BRIDGE_ATTACH_NO_CON

Re: [PATCH v5 04/13] dt-bindings: memory-controllers: add canaan k210 sram controller

2022-07-10 Thread Damien Le Moal
On 7/11/22 04:39, conor.doo...@microchip.com wrote: > Damien, Krzysztof, > > I know this particular version has not been posted for all that > long, but this binding is (functionally) unchanged for a few > versions now. Are you happy with this approach Damien? > U-Boot only cares about the compati

linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2022-07-10 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c between commit: 925b6e59138c ("Revert "drm/amdgpu: add drm buddy support to amdgpu"") from the drm-misc-fixes tree and commit: 5e3f1e7729ec ("drm/amdgpu: fix start calculatio

Re: [PATCH] drm/i915/gvt: fix typo in comment

2022-07-10 Thread Zhenyu Wang
On 2022.05.21 13:10:59 +0200, Julia Lawall wrote: > Spelling mistake (triple letters) in comment. > Detected with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/gpu/drm/i915/gvt/gtt.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers

Re: [PATCH 1/2] drm/i915/gvt: Fix kernel-doc

2022-07-10 Thread Zhenyu Wang
On 2022.05.24 16:37:33 +0800, Jiapeng Chong wrote: > Fix the following W=1 kernel warnings: > > drivers/gpu/drm/i915/gvt/handlers.c:3066: warning: expecting prototype > for intel_t_default_mmio_write(). Prototype was for > intel_vgpu_default_mmio_write() instead. > > Reported-by: Abaci Robot > S

Re: [PATCH 2/2] drm/i915/gvt: Fix kernel-doc

2022-07-10 Thread Zhenyu Wang
On 2022.05.24 16:37:32 +0800, Jiapeng Chong wrote: > Fix the following W=1 kernel warnings: > > drivers/gpu/drm/i915/gvt/mmio_context.c:560: warning: expecting > prototype for intel_gvt_switch_render_mmio(). Prototype was for > intel_gvt_switch_mmio() instead. > > Reported-by: Abaci Robot > Sign

Re: [PATCH] drm/i915/gvt: Fix kernel-doc

2022-07-10 Thread Zhenyu Wang
On 2022.06.02 15:35:19 +0800, Jiapeng Chong wrote: > Fix the following W=1 kernel warnings: > > drivers/gpu/drm/i915/gvt/aperture_gm.c:308: warning: expecting prototype > for inte_gvt_free_vgpu_resource(). Prototype was for > intel_vgpu_free_resource() instead. > > drivers/gpu/drm/i915/gvt/apertu

Re: [PATCH v2 1/2] dt-bindings: arm: sunxi: Add binding for RenewWorldOutReach R16-Vista-E board

2022-07-10 Thread Suniel Mahesh
Hi Samuel, On Sun, Jul 3, 2022 at 1:17 PM Samuel Holland wrote: > On 6/15/22 4:38 AM, Suniel Mahesh wrote: > > Add a binding for the RenewWorldOutReach R16-Vista-E board based on > > allwinner R16. > > > > Signed-off-by: Christopher Vollo > > Signed-off-by: Jagan Teki > > Signed-off-by: Suniel

Re: [PATCH v2 2/2] ARM: dts: sun8i: Add R16 Vista E board from RenewWorldOutreach

2022-07-10 Thread Suniel Mahesh
Hi Samuel, On Sun, Jul 3, 2022 at 1:12 PM Samuel Holland wrote: > On 6/15/22 4:39 AM, Suniel Mahesh wrote: > > The R16-Vista-E board from RenewWorldOutreach based on allwinner > > R16(A33). > > > > General features: > > - 1GB RAM > > - microSD slot > > - Realtek Wifi > > - 1 x USB 2.0 > > - HDMI

[PATCH v4 0/2] Fix TLB invalidate issues with Broadwell

2022-07-10 Thread Mauro Carvalho Chehab
i915 selftest hangcheck is causing the i915 driver timeouts, as reported by Intel CI bot: http://gfx-ci.fi.intel.com/cibuglog-ng/issuefilterassoc/24297?query_key=42a999f48fa6ecce068bc8126c069be7c31153b4 When such test runs, the only output is: [ 68.811639] i915: Performing live selftes

[PATCH v4 2/2] drm/i915/gt: Serialize TLB invalidates with GT resets

2022-07-10 Thread Mauro Carvalho Chehab
From: Chris Wilson Avoid trying to invalidate the TLB in the middle of performing an engine reset, as this may result in the reset timing out. Currently, the TLB invalidate is only serialised by its own mutex, forgoing the uncore lock, but we can take the uncore->lock as well to serialise the mmi

[PATCH v4 1/2] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-07-10 Thread Mauro Carvalho Chehab
From: Chris Wilson Don't allow two engines to be reset in parallel, as they would both try to select a reset bit (and send requests to common registers) and wait on that register, at the same time. Serialize control of the reset requests/acks using the uncore->lock, which will also ensure that no