Re: [PATCH 2/2] drm/i915/hdmi: Prune unsupported modes as per HDMI2.1 spec

2022-05-10 Thread Ville Syrjälä
On Mon, May 09, 2022 at 03:01:30PM +0530, Ankit Nautiyal wrote: > As per Sec 7.8.1 of HDMI2.1 spec, sources that support modes: > 4K100, 4K120, 8K50, 8K60 must support these modes in at least one of > the below formats: > i) uncompressed FRL, 420 format and min of 10 bpc, or > ii) compressed FRL, 4

[RFC] drm/msm: Add initial ci/ subdirectory

2022-05-10 Thread Tomeu Vizoso
And use it to store expectations about what the drm/msm driver is supposed to pass in the IGT test suite. Also include a configuration file that points to the out-of-tree CI scripts. By storing the test expectations along the code we can make sure both stay in sync with each other, and so we can

[PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2

2022-05-10 Thread Sascha Hauer
The VOP2 driver relies on reg-names properties, but these are not documented. Add the missing documentation, make reg-names mandatory and increase minItems to 2 as always both register spaces are needed. Signed-off-by: Sascha Hauer --- .../bindings/display/rockchip/rockchip-vop2.yaml |

[PATCH 3/3] arm64: dts: rockchip: rk356x: Change VOP2 register space names

2022-05-10 Thread Sascha Hauer
"regs" seems to generic when there are multiple register spaces, so rename to "vop". Also, replace "gamma_lut" with better looking "gamma-lut". This has been changed in the driver and binding documentation as well. Signed-off-by: Sascha Hauer --- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 2 +-

[PATCH 0/3] RK356x VOP2: Change register space names

2022-05-10 Thread Sascha Hauer
The VOP2 driver sitting in next uses named register spaces, but the binding lacks documentation for that. Add the missing documentation and while at it take the opportunity to rename the register spaces from too generic "regs" to "vop" and from "gamma_lut" to better looking "gamma-lut". Sascha Hau

[PATCH 2/3] drm: rockchip: Change register space names

2022-05-10 Thread Sascha Hauer
"regs" seems to generic when there are multiple register spaces, so rename that one to "vop". Also change "gamma_lut" to better looking "gamma-lut". Signed-off-by: Sascha Hauer --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] mgag200: Enable atomic gamma lut update

2022-05-10 Thread Thomas Zimmermann
Hi Am 09.05.22 um 17:43 schrieb Jocelyn Falempe: On 09/05/2022 16:22, Thomas Zimmermann wrote: Hi, first of all Tested-by: Thomas Zimemrmann on G200EH. I clicked a bit in Gnome settings and the display changed colors. It's pretty cool. yeah, I also played a bit with https://github.com/zb

Re: [PATCH v2 08/25] drm/edid: convert struct detailed_mode_closure to drm_edid

2022-05-10 Thread Nautiyal, Ankit K
LGTM, The subject perhaps can be modified to suggest drm_edid being added to detailed_mode_closure. In any case: Reviewed-by: Ankit Nautiyal On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 2

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-10 Thread Andrzej Hajda
On 10.05.2022 00:42, Javier Martinez Canillas wrote: On 5/10/22 00:22, Andrzej Hajda wrote: [snip] static void drm_fbdev_fb_destroy(struct fb_info *info) { + if (info->cmap.len) + fb_dealloc_cmap(&info->cmap); + drm_fbdev_release(info->par); + frame

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-05-10 Thread Piotr Oniszczuk
> Wiadomość napisana przez Peter Geis w dniu 10.05.2022, > o godz. 03:35: > > Could you grab the clock tree from /sys/kernel/debug/clk/clk_summary > for the clk_hdmi_cec tree? Here it is: enable prepare protect duty hardware

[PATCH 1/2] drm/msm/a6xx: Add support for a new 7c3 sku

2022-05-10 Thread Akhil P Oommen
Add a new sku to the fuse map of 7c3 gpu. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index 841e47a..61bb21d 100644 --- a/drivers/gpu/

[PATCH 2/2] arm64: dts: Support a new sc7280 gpu sku

2022-05-10 Thread Akhil P Oommen
Add support for a new sc7280 sku in the gpu's opp table. Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index d782ffe..16f

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-10 Thread Javier Martinez Canillas
On 5/10/22 09:19, Andrzej Hajda wrote: > > > On 10.05.2022 00:42, Javier Martinez Canillas wrote: >> On 5/10/22 00:22, Andrzej Hajda wrote: >> >> [snip] >> static void drm_fbdev_fb_destroy(struct fb_info *info) { + if (info->cmap.len) + fb_dealloc_cma

[PATCH v2 1/2] drm/msm/a6xx: Add support for a new 7c3 sku

2022-05-10 Thread Akhil P Oommen
Add a new sku to the fuse map of 7c3 gpu. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index 841e47a..61bb21d 10

[PATCH v2 2/2] arm64: dts: qcom: sc7280: Support a new gpu sku

2022-05-10 Thread Akhil P Oommen
Add support for a new sc7280 sku in the gpu's opp table. Signed-off-by: Akhil P Oommen --- Changes in v2: - Commit message update arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-10 Thread Thomas Zimmermann
Hi Am 10.05.22 um 00:42 schrieb Javier Martinez Canillas: On 5/10/22 00:22, Andrzej Hajda wrote: [snip] static void drm_fbdev_fb_destroy(struct fb_info *info) { + if (info->cmap.len) + fb_dealloc_cmap(&info->cmap); + drm_fbdev_release(info->par); + fr

[RFC] drm/amdgpu: Convert to common fdinfo format

2022-05-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Convert fdinfo format to one documented in drm-usage-stats.rst. Opens/TODO: * Does someone from AMD want to take over this patch? (I have no access to amdgpu hardware so won't be able to test any hypothetical gputop work.) * What are the semantics of AMD engine ut

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-10 Thread Javier Martinez Canillas
Hello Thomas, On 5/10/22 10:04, Thomas Zimmermann wrote: > Hi > > Am 10.05.22 um 00:42 schrieb Javier Martinez Canillas: >> On 5/10/22 00:22, Andrzej Hajda wrote: >> >> [snip] >> static void drm_fbdev_fb_destroy(struct fb_info *info) { + if (info->cmap.len) +

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-10 Thread Thomas Zimmermann
Hi Am 10.05.22 um 10:30 schrieb Javier Martinez Canillas: Hello Thomas, On 5/10/22 10:04, Thomas Zimmermann wrote: Hi Am 10.05.22 um 00:42 schrieb Javier Martinez Canillas: On 5/10/22 00:22, Andrzej Hajda wrote: [snip] static void drm_fbdev_fb_destroy(struct fb_info *info) { +

Re: [RFC] drm/amdgpu: Convert to common fdinfo format

2022-05-10 Thread Christian König
Hi Tvrtko, Am 10.05.22 um 10:23 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Convert fdinfo format to one documented in drm-usage-stats.rst. Opens/TODO: * Does someone from AMD want to take over this patch? (I have no access to amdgpu hardware so won't be able to test any hypothe

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-10 Thread Thomas Zimmermann
Hi Am 10.05.22 um 10:37 schrieb Thomas Zimmermann: ... You have to go through all DRM drivers that call drm_fb_helper_fini() and make sure that they free fb_info. For example armada appears to be leaking now. [1] But shouldn't fb_info be freed when unregister_framebuffer() is called through

Re: [PATCH] drm/stm: dsi: Enable wrapper glue regulator early

2022-05-10 Thread Raphael Gallais-Pou
On 5/5/22 19:40, Marek Vasut wrote: > On 5/4/22 09:59, Raphael Gallais-Pou wrote: >> Hi Marek, > > Hi, > > [...] > >>> @@ -499,8 +512,16 @@ static int dw_mipi_dsi_stm_probe(struct platform_device >>> *pdev) >>>   } >>>     dsi->hw_version = dsi_read(dsi, DSI_VERSION) & VERSION; >>> + >>>

Re: [Intel-gfx] [PATCH v2 09/25] drm/edid: convert drm_mode_detailed() to drm_edid

2022-05-10 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm

Re: [Intel-gfx] [PATCH v2 10/25] drm/edid: convert drm_dmt_modes_for_range() to drm_edid

2022-05-10 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-10 Thread Javier Martinez Canillas
Hello Thomas, On 5/10/22 10:50, Thomas Zimmermann wrote: [snip] >>> Drivers shouldn't really explicitly call this helper in my opinion. > > One more stupid question: does armada actually use > drm_fbdev_fb_destroy()? It's supposed to be a callback for struct > fb_ops. Armada uses it's own ins

Re: [PATCH v2 11/25] drm/edid: convert drm_gtf_modes_for_range() to drm_edid

2022-05-10 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/

Re: [PATCH] drm/stm: dsi: Enable wrapper glue regulator early

2022-05-10 Thread Marek Vasut
On 5/10/22 10:51, Raphael Gallais-Pou wrote: On 5/5/22 19:40, Marek Vasut wrote: On 5/4/22 09:59, Raphael Gallais-Pou wrote: Hi Marek, Hi, [...] @@ -499,8 +512,16 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev)   }     dsi->hw_version = dsi_read(dsi, DSI_VERSIO

Re: [Intel-gfx] [PATCH v2 12/25] drm/edid: convert drm_cvt_modes_for_range() to drm_edid

2022-05-10 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/dr

Re: [Intel-gfx] [PATCH v2 13/25] drm/edid: convert drm_mode_std() and children to drm_edid

2022-05-10 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 52 -- 1 file changed, 27 insertions(+), 25 deletions(-)

Re: [Intel-gfx] [PATCH v2 14/25] drm/edid: convert mode_in_range() and drm_monitor_supports_rb() to drm_edid

2022-05-10 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git

Re: [PATCH v2 15/25] drm/edid: convert get_monitor_name() to drm_edid

2022-05-10 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Drop incorrect NULL name check (Dan Carpenter) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 24 1 file chang

Re: [PATCH] dma-buf: call dma_buf_stats_setup after dmabuf is in valid list

2022-05-10 Thread Christian König
Am 10.05.22 um 04:43 schrieb Charan Teja Kalla: Hello Mercier, On 5/10/2022 3:19 AM, T.J. Mercier wrote: On Mon, May 9, 2022 at 12:50 PM Charan Teja Kalla wrote: From: Charan Teja Reddy When dma_buf_stats_setup() fails, it closes the dmabuf file which results into the calling of dma_buf_fil

Re: [PATCH v2 16/25] drm/edid: convert drm_for_each_detailed_block() to drm_edid

2022-05-10 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Fix checkpatch warning on superfluous parens Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 36 ++-- 1

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-10 Thread Thomas Zimmermann
Hi Javier Am 10.05.22 um 11:06 schrieb Javier Martinez Canillas: Hello Thomas, On 5/10/22 10:50, Thomas Zimmermann wrote: [snip] Drivers shouldn't really explicitly call this helper in my opinion. One more stupid question: does armada actually use drm_fbdev_fb_destroy()? It's supposed to b

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-10 Thread Javier Martinez Canillas
On 5/10/22 11:39, Thomas Zimmermann wrote: [snip] >> >> 3) Set .fb_destroy to drm_fbdev_fb_destroy() if isn't set by drivers when >> they call drm_fb_helper_initial_config() or drm_fb_helper_fill_info(). >> >> I'm leaning towards option (3). Then the fb_info release will be automatic >> wheth

Re: [PATCH v2 17/25] drm/edid: add drm_edid helper for drm_edid_to_sad()

2022-05-10 Thread Nautiyal, Ankit K
On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit --- drivers/gpu/drm/drm_edid.c | 34 +- 1 file

Re: [Intel-gfx] [PATCH v2 18/25] drm/edid: add drm_edid helper for drm_edid_to_speaker_allocation()

2022-05-10 Thread Nautiyal, Ankit K
LGTM Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere.' v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 37 +++-- 1 file ch

Re: [Intel-gfx] [PATCH v2 19/25] drm/edid: add drm_edid helper for drm_detect_hdmi_monitor()

2022-05-10 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 33 - 1 file change

Re: [Intel-gfx] [PATCH v2 20/25] drm/edid: add drm_edid helper for drm_detect_monitor_audio()

2022-05-10 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 37 ++--- 1 file ch

Re: [PATCH v2 21/25] drm/edid: convert cea_db_iter_edid_begin() to drm_edid

2022-05-10 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Handle NULL drm_edid Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 21 +++-- 1 file changed, 11 insertions(+), 10 dele

[PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Charan Teja Kalla
The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> alloc_anon_inode()) to get an inode number and uses the same as a directory name under /sys/kernel/dmabuf/buffers/. This directory is used to collect the dmabuf stats and it is created through dma_buf_stats_setup(). At current, failur

Re: [PATCH v2 22/25] drm/edid: convert drm_edid_iter_begin() to drm_edid

2022-05-10 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Rebase Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) dif

Re: [PATCH v2 1/3] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-05-10 Thread Krzysztof Kozlowski
On 09/05/2022 10:45, Rex-BC Chen wrote: >>> +soc { >>> +#address-cells = <2>; >>> +#size-cells = <2>; >>> + >>> +vdo1_rdma0: mdp-rdma@1c104000 { >> >> Generic node name. dma-controller (if it does not conflict with >> dma-common.yaml schema)? > > We don't understand wha

Re: [Intel-gfx] [PATCH v2 23/25] drm/edid: add drm_edid helper for drm_update_tile_info()

2022-05-10 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 14 +++--- 1 file changed, 11 insertions(+)

Re: [PATCH v2 1/3] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-05-10 Thread Chen-Yu Tsai
On Tue, May 10, 2022 at 6:28 PM Krzysztof Kozlowski wrote: > > On 09/05/2022 10:45, Rex-BC Chen wrote: > >>> +soc { > >>> +#address-cells = <2>; > >>> +#size-cells = <2>; > >>> + > >>> +vdo1_rdma0: mdp-rdma@1c104000 { > >> > >> Generic node name. dma-controller (if it d

[PATCH 14/15] drm/edid: Extract drm_edid_decode_mfg_id()

2022-05-10 Thread Ville Syrjala
From: Ville Syrjälä Make the PNPID decoding available for other users. Cc: dri-devel@lists.freedesktop.org Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- include/drm/drm_edid.h | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/include/drm/dr

[PATCH] drm/ast: Support multiple outputs

2022-05-10 Thread Thomas Zimmermann
Systems with AST graphics can have multiple output; typically VGA plus some other port. Record detected output chips in a bitmask and initialize each output on its own. Tested on AST2100. Signed-off-by: Thomas Zimmermann Fixes: a59b026419f3 ("drm/ast: Initialize encoder and connector for VGA in

Re: [RFC] drm/amdgpu: Convert to common fdinfo format

2022-05-10 Thread Tvrtko Ursulin
Hi, On 10/05/2022 09:48, Christian König wrote: Hi Tvrtko, Am 10.05.22 um 10:23 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Convert fdinfo format to one documented in drm-usage-stats.rst. Opens/TODO:   * Does someone from AMD want to take over this patch? (I have no access to amdgpu

Re: [PATCH v4] drm/ast: Create the driver for ASPEED proprietory Display-Port

2022-05-10 Thread Thomas Zimmermann
Hi Am 04.05.22 um 10:49 schrieb Kuo-Hsiang Chou: Hi Thomas, Thanks for your efforts to review this patch. Now, I observe a change that after DP unplugged and then the system is unable to get EDID from D-sub connecting. The reason seems that TXs are merged into union structure in /drivers/g

Re: [PATCH v2 1/3] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-05-10 Thread Krzysztof Kozlowski
On 10/05/2022 12:37, Chen-Yu Tsai wrote: >> Use a generic node name, as Devicetree spec asks: >> "The name of a node should be somewhat generic, reflecting the function >> of the device and not its precise programming >> >> model. If appropriate, the name should be one of the following choices:" >>

Re: [PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Greg KH
On Tue, May 10, 2022 at 03:53:32PM +0530, Charan Teja Kalla wrote: > The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> > alloc_anon_inode()) to get an inode number and uses the same as a > directory name under /sys/kernel/dmabuf/buffers/. This directory is > used to collect the dmabu

Re: 5.18 vmwgfx seems to break booting VirtualBox VMs

2022-05-10 Thread Thorsten Leemhuis
Hi, this is your Linux kernel regression tracker. On 10.05.22 02:12, Zack Rusin wrote: >> On May 9, 2022, at 6:57 AM, Hans de Goede >> wrote: On 4/11/22 16:24, Zack Rusin wrote: >>> On Mon, 2022-04-11 at 10:52 +0200, Hans de Goede wrote: Fedora has received a bug report here: >>>

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-10 Thread Hyeonggon Yoo
On Mon, May 09, 2022 at 09:16:37AM +0900, Byungchul Park wrote: > On Sat, May 07, 2022 at 04:20:50PM +0900, Hyeonggon Yoo wrote: > > On Fri, May 06, 2022 at 09:11:35AM +0900, Byungchul Park wrote: > > > Linus wrote: > > > > > > > > On Wed, May 4, 2022 at 1:19 AM Byungchul Park > > > > wrote: > >

Re: [V2 0/3] Expose max and current bpc via debugfs

2022-05-10 Thread Modem, Bhanuprakash
Hi Jani, Can you please help to push this series to drm-next? CI result: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102502v7/index.html? I'll merge IGT changes [1] first, so that we won't break the CI. [1]: https://patchwork.freedesktop.org/series/102387/ - Bhanu On Mon-11-04-2022 0

Re: [PATCH v2 3/3] dt-bindings: mediatek: add ethdr definition for mt8195

2022-05-10 Thread Krzysztof Kozlowski
On 10/05/2022 03:46, Rex-BC Chen wrote: >> >> >> That's mediatek-drm, and this refers to the HDR block in the display >> IP... >> >> Though, I have no idea of what "ET" stands for in "ETHDR", so, it >> would be >> definitely nice if MediaTek can write the meaning in the description, >> like >> >> d

Re: [RFC] drm/amdgpu: Convert to common fdinfo format

2022-05-10 Thread Christian König
Am 10.05.22 um 12:50 schrieb Tvrtko Ursulin: Hi, On 10/05/2022 09:48, Christian König wrote: Hi Tvrtko, Am 10.05.22 um 10:23 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Convert fdinfo format to one documented in drm-usage-stats.rst. Opens/TODO:   * Does someone from AMD want to take over

Re: [PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Christian König
Am 10.05.22 um 13:00 schrieb Greg KH: On Tue, May 10, 2022 at 03:53:32PM +0530, Charan Teja Kalla wrote: The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> alloc_anon_inode()) to get an inode number and uses the same as a directory name under /sys/kernel/dmabuf/buffers/. This direc

Re: [PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Charan Teja Kalla
Thanks Greg for the inputs!! On 5/10/2022 4:30 PM, Greg KH wrote: >> The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> >> alloc_anon_inode()) to get an inode number and uses the same as a >> directory name under /sys/kernel/dmabuf/buffers/. This directory is >> used to collect the d

Re: [PATCH v2 24/25] drm/displayid: convert to drm_edid

2022-05-10 Thread Nautiyal, Ankit K
LGTM Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Rebase Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_displayid.c | 16 drivers/gpu/drm/drm_edid.c | 17 ++---

Re: [PATCH v2 25/25] drm/edid: convert version_greater() to drm_edid

2022-05-10 Thread Nautiyal, Ankit K
LGTM Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Also make version_greater() a function for type safety. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 29 + 1 fi

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-05-10 Thread Peter Geis
On Tue, May 10, 2022 at 3:29 AM Piotr Oniszczuk wrote: > > > > > Wiadomość napisana przez Peter Geis w dniu > > 10.05.2022, o godz. 03:35: > > > > Could you grab the clock tree from /sys/kernel/debug/clk/clk_summary > > for the clk_hdmi_cec tree? > > Here it is: >

Re: [PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Greg KH
On Tue, May 10, 2022 at 01:35:41PM +0200, Christian König wrote: > Am 10.05.22 um 13:00 schrieb Greg KH: > > On Tue, May 10, 2022 at 03:53:32PM +0530, Charan Teja Kalla wrote: > > > The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> > > > alloc_anon_inode()) to get an inode number and

Re: [PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Charan Teja Kalla
Thanks Christian for the inputs!! On 5/10/2022 5:05 PM, Christian König wrote: > >> And what's to keep the seconds field from also being the same? > > Well exporting two DMA-bufs with the same ino in the same nanosecond > should be basically impossible, but I would rather opt for using a 64bit >

Re: [PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Christian König
Am 10.05.22 um 14:16 schrieb Charan Teja Kalla: Thanks Christian for the inputs!! On 5/10/2022 5:05 PM, Christian König wrote: And what's to keep the seconds field from also being the same? Well exporting two DMA-bufs with the same ino in the same nanosecond should be basically impossible, but

Re: 5.18 vmwgfx seems to break booting VirtualBox VMs

2022-05-10 Thread Zack Rusin
> On May 10, 2022, at 7:06 AM, Thorsten Leemhuis > wrote: > > Hi, this is your Linux kernel regression tracker. > > On 10.05.22 02:12, Zack Rusin wrote: >>> On May 9, 2022, at 6:57 AM, Hans de Goede >>> wrote: On 4/11/22 16:24, Zack Rusin wrote: On Mon, 2022-04-11 at 10:52 +0200, Hans d

Re: 5.18 vmwgfx seems to break booting VirtualBox VMs

2022-05-10 Thread Thorsten Leemhuis
On 10.05.22 14:26, Zack Rusin wrote: >> On May 10, 2022, at 7:06 AM, Thorsten Leemhuis >> wrote: >> On 10.05.22 02:12, Zack Rusin wrote: On May 9, 2022, at 6:57 AM, Hans de Goede wrote: On 4/11/22 16:24, Zack Rusin wrote: > On Mon, 2022-04-11 at 10:52 +0200, Hans de Goede wrote: >>

Re: [Linaro-mm-sig] Re: [PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Christian König
Am 10.05.22 um 14:10 schrieb Greg KH: On Tue, May 10, 2022 at 01:35:41PM +0200, Christian König wrote: Am 10.05.22 um 13:00 schrieb Greg KH: On Tue, May 10, 2022 at 03:53:32PM +0530, Charan Teja Kalla wrote: The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> alloc_anon_inode()) t

Re: [RFC] drm/amdgpu: Convert to common fdinfo format

2022-05-10 Thread Tvrtko Ursulin
On 10/05/2022 12:26, Christian König wrote: Am 10.05.22 um 12:50 schrieb Tvrtko Ursulin: Hi, On 10/05/2022 09:48, Christian König wrote: Hi Tvrtko, Am 10.05.22 um 10:23 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Convert fdinfo format to one documented in drm-usage-stats.rst. Opens/TO

Re: 5.18 vmwgfx seems to break booting VirtualBox VMs

2022-05-10 Thread Zack Rusin
On Tue, 2022-05-10 at 14:44 +0200, Thorsten Leemhuis wrote: > On 10.05.22 14:26, Zack Rusin wrote: > > > On May 10, 2022, at 7:06 AM, Thorsten Leemhuis > > > wrote: > > > On 10.05.22 02:12, Zack Rusin wrote: > > > > > On May 9, 2022, at 6:57 AM, Hans de Goede > > > > > > > > > > wrote: On 4/11/22

Re: [PATCH v4 10/15] drm/shmem-helper: Take reservation lock instead of drm_gem_shmem locks

2022-05-10 Thread Dmitry Osipenko
On 5/9/22 16:42, Daniel Vetter wrote: > On Fri, May 06, 2022 at 01:49:12AM +0300, Dmitry Osipenko wrote: >> On 5/5/22 11:12, Daniel Vetter wrote: >>> On Wed, May 04, 2022 at 06:56:09PM +0300, Dmitry Osipenko wrote: On 5/4/22 11:21, Daniel Vetter wrote: ... >>> - Maybe also do what you

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-10 Thread Dmitry Osipenko
On 5/9/22 16:49, Daniel Vetter wrote: > On Fri, May 06, 2022 at 03:10:43AM +0300, Dmitry Osipenko wrote: >> On 5/5/22 11:34, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 18.04.22 um 00:37 schrieb Dmitry Osipenko: Introduce a common DRM SHMEM shrinker. It allows to reduce code duplication am

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-05-10 Thread Piotr Oniszczuk
> Wiadomość napisana przez Peter Geis w dniu 10.05.2022, > o godz. 14:08: > > > You are on the clk_rtc32k_frac which is a fractional divider that is > fed from the 24m clock. Your clock likely isn't the issue here. I'd > recommend setting up the cec-gpio node to validate your hardware > work

Re: 5.18 vmwgfx seems to break booting VirtualBox VMs

2022-05-10 Thread Thorsten Leemhuis
On 10.05.22 15:30, Zack Rusin wrote: > On Tue, 2022-05-10 at 14:44 +0200, Thorsten Leemhuis wrote: >> On 10.05.22 14:26, Zack Rusin wrote: On May 10, 2022, at 7:06 AM, Thorsten Leemhuis wrote: On 10.05.22 02:12, Zack Rusin wrote: >> On May 9, 2022, at 6:57 AM, Hans de Goede

Re: 5.18 vmwgfx seems to break booting VirtualBox VMs

2022-05-10 Thread Zack Rusin
On Tue, 2022-05-10 at 15:49 +0200, Thorsten Leemhuis wrote: > On 10.05.22 15:30, Zack Rusin wrote: > > On Tue, 2022-05-10 at 14:44 +0200, Thorsten Leemhuis wrote: > > > On 10.05.22 14:26, Zack Rusin wrote: > > > > > On May 10, 2022, at 7:06 AM, Thorsten Leemhuis > > > > > wrote: > > > > > On 10.05

[PATCH] drm/i915/gt: Fix use of static in macro mismatch

2022-05-10 Thread Andi Shyti
The INTEL_GT_RPS_SYSFS_ATTR was creating to different structures but. When called with the "static" keyword this is affecting only the first structure, while the second is created as non static. Move the static keyword inside the macros to affect both the structures. Reported-by: Jani Nikula Fix

[PATCH V2] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Charan Teja Kalla
The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> alloc_anon_inode()) to get an inode number and uses the same as a directory name under /sys/kernel/dmabuf/buffers/. This directory is used to collect the dmabuf stats and it is created through dma_buf_stats_setup(). At current, failur

Re: [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2

2022-05-10 Thread Heiko Stübner
Hi Sascha, Am Dienstag, 10. Mai 2022, 09:09:12 CEST schrieb Sascha Hauer: > The VOP2 driver relies on reg-names properties, but these are not > documented. Add the missing documentation, make reg-names mandatory > and increase minItems to 2 as always both register spaces are needed. > > Signed-of

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-10 Thread Steven Rostedt
On Tue, 10 May 2022 08:38:38 +0900 Byungchul Park wrote: > Yes, I was talking about A and L'. > > > detect that regardless of L. A nested lock associates the the nesting with > > When I checked Lockdep code, L' with depth n + 1 and L' with depth n > have different classes in Lockdep. If that

[RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-10 Thread Tomeu Vizoso
And use it to store expectations about what the drm/msm driver is supposed to pass in the IGT test suite. Also include a configuration file that points to the out-of-tree CI scripts. By storing the test expectations along the code we can make sure both stay in sync with each other, and so we can

[PATCH] drm/stm: ltdc: fix unchecked dereferenced pointer

2022-05-10 Thread Raphael Gallais-Pou
Pointer of struct *drm_crtc was dereferenced before checking it was non NULL. This could potentially create a kernel panic. Fixes: 79b44684a14e ("drm/stm: ltdc: add support for CRC hashing feature") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Raphael Gallais-Pou ---

Re: [PATCH] drm/amdgpu: Remove duplicated argument in vcn_v4_0

2022-05-10 Thread Alex Deucher
Applied. Thanks! Alex On Mon, May 9, 2022 at 10:50 PM Wan Jiabing wrote: > > Fix following coccicheck warning: > ./drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c:724:4-36: duplicated argument to & or > | > > Remove duplicated UVD_SUVD_CGC_GATE__SRE_H264_MASK. > > Signed-off-by: Wan Jiabing > --- > dr

Re: [PATCH] drm/amdgpu: clean up some inconsistent indenting

2022-05-10 Thread Alex Deucher
Applied. Thanks! Alex On Tue, May 10, 2022 at 2:05 AM Jiapeng Chong wrote: > > Eliminate the follow smatch warning: > > drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c:35 nbio_v7_7_get_rev_id() warn: > inconsistent indenting. > > drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c:214 nbio_v7_7_init_registers() > wa

Re: [PATCH V2] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Christian König
Am 10.05.22 um 16:06 schrieb Charan Teja Kalla: The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> alloc_anon_inode()) to get an inode number and uses the same as a directory name under /sys/kernel/dmabuf/buffers/. This directory is used to collect the dmabuf stats and it is created

Re: [BUG] Warning and NULL-ptr dereference in amdgpu driver with 5.18

2022-05-10 Thread Alex Deucher
On Tue, May 10, 2022 at 7:12 AM Jörg Rödel wrote: > > Gentle ping. This is a 5.18 regression and I also see it with > 5.18-rc6. Please let me know if you need anything else to debug. > Are you doing anything special when it happens? I.e., does it happen when the monitor is coming out of DPMS or

[PATCH] drm/msm: Fix fb plane offset calculation

2022-05-10 Thread Rob Clark
From: Rob Clark The offset got dropped by accident. Fixes: d413e6f97134 ("drm/msm: Drop msm_gem_iova()") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c ind

Re: [Bug 215958] New: thunderbolt3 egpu cannot disconnect cleanly

2022-05-10 Thread Andrey Grodzovsky
On 2022-05-09 14:03, Deucher, Alexander wrote: [Public] -Original Message- From: Bjorn Helgaas Sent: Monday, May 9, 2022 12:23 PM To: Linux PCI Cc: r087...@yahoo.it; Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; amd-gfx mailing list ; dri-devel Subject: Re: [Bug 215958] Ne

Re: [PATCH V2] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Charan Teja Kalla
On 5/10/2022 8:42 PM, Christian König wrote: >>    * The information in the interface can also be used to derive >> per-exporter >>    * statistics. The data from the interface can be gathered on error >> conditions >> @@ -172,6 +172,7 @@ int dma_buf_stats_setup(struct dma_buf *dmabuf) >>   { >>   

Re: [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2

2022-05-10 Thread Rob Herring
On Tue, May 10, 2022 at 09:09:12AM +0200, Sascha Hauer wrote: > The VOP2 driver relies on reg-names properties, but these are not > documented. Add the missing documentation, make reg-names mandatory > and increase minItems to 2 as always both register spaces are needed. > > Signed-off-by: Sascha

[PATCH] drm/i2c: tda9950: Lower severity of log message about missing interrupts

2022-05-10 Thread Mark Brown
The tda9950 driver prints an error message if it is instantiated without an interrupt being available since the device is non-functional in that case. Unfortunately due to packaging of tda9950 with tda998x series devices the tda998x driver unconditionally instantiates a tda9950 so systems with a td

Re: [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2

2022-05-10 Thread Rob Herring
On Tue, May 10, 2022 at 04:08:02PM +0200, Heiko Stübner wrote: > Hi Sascha, > > Am Dienstag, 10. Mai 2022, 09:09:12 CEST schrieb Sascha Hauer: > > The VOP2 driver relies on reg-names properties, but these are not > > documented. Add the missing documentation, make reg-names mandatory > > and incre

Re: [PATCH V2] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Christian König
Am 10.05.22 um 19:14 schrieb Charan Teja Kalla: On 5/10/2022 8:42 PM, Christian König wrote:    * The information in the interface can also be used to derive per-exporter    * statistics. The data from the interface can be gathered on error conditions @@ -172,6 +172,7 @@ int dma_buf_stats_setu

Re: [PATCH] drm/msm: Fix fb plane offset calculation

2022-05-10 Thread Abhinav Kumar
On 5/10/2022 9:52 AM, Rob Clark wrote: From: Rob Clark The offset got dropped by accident. Fixes: d413e6f97134 ("drm/msm: Drop msm_gem_iova()") Signed-off-by: Rob Clark Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/msm_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] drm/msm: Fix fb plane offset calculation

2022-05-10 Thread Dmitry Baryshkov
On Tue, 10 May 2022 at 19:52, Rob Clark wrote: > > From: Rob Clark > > The offset got dropped by accident. > > Fixes: d413e6f97134 ("drm/msm: Drop msm_gem_iova()") > Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/msm_fb.c | 2 +- > 1 file changed, 1 insert

Re: [PATCH] drm/msm: Fix fb plane offset calculation

2022-05-10 Thread Rob Clark
On Tue, May 10, 2022 at 10:46 AM Dmitry Baryshkov wrote: > > On Tue, 10 May 2022 at 19:52, Rob Clark wrote: > > > > From: Rob Clark > > > > The offset got dropped by accident. > > > > Fixes: d413e6f97134 ("drm/msm: Drop msm_gem_iova()") > > Signed-off-by: Rob Clark > > Reviewed-by: Dmitry Barys

Re: [PATCH] drm/msm: Fix fb plane offset calculation

2022-05-10 Thread Stephen Boyd
Quoting Rob Clark (2022-05-10 09:52:16) > From: Rob Clark > > The offset got dropped by accident. > > Fixes: d413e6f97134 ("drm/msm: Drop msm_gem_iova()") > Signed-off-by: Rob Clark > --- Reviewed-by: Stephen Boyd Tested-by: Stephen Boyd # CoachZ

Re: [PATCH v0.5 1/9] dt-bindings: display: imx: add binding for i.MX8MP HDMI TX

2022-05-10 Thread Rob Herring
On Fri, May 06, 2022 at 08:10:26PM +0200, Lucas Stach wrote: > The HDMI TX controller on the i.MX8MP SoC is a Synopsys designware IP > core with a little bit of SoC integration around it. > > Signed-off-by: Lucas Stach > --- > .../bindings/display/imx/fsl,imx8mp-hdmi.yaml | 73 ++

Re: [PATCH v0.5 5/9] dt-bindings: phy: add binding for the i.MX8MP HDMI PHY

2022-05-10 Thread Rob Herring
On Fri, May 06, 2022 at 08:10:30PM +0200, Lucas Stach wrote: > Add a DT binding for the HDMI PHY found on the i.MX8MP SoC. > > Signed-off-by: Lucas Stach > --- > .../bindings/phy/fsl,imx8mp-hdmi-phy.yaml | 62 +++ > 1 file changed, 62 insertions(+) > create mode 100644 > Do

Re: [PATCH] drm/bridge: simplify the return expression of ps8640_bridge_host_attach

2022-05-10 Thread Doug Anderson
Hi, On Fri, Apr 29, 2022 at 9:21 AM Doug Anderson wrote: > > Hi, > > On Thu, Apr 28, 2022 at 10:51 PM wrote: > > > > From: Minghao Chi > > > > Simplify the return expression. > > > > Reported-by: Zeal Robot > > Signed-off-by: Minghao Chi > > --- > > drivers/gpu/drm/bridge/parade-ps8640.c | 7

[PATCH] drm: Add a debug message when getting a prop is missing

2022-05-10 Thread Mark Yacoub
[Why] If a connector property is attached but drm_atomic_connector_get_property doesn't handle a case for it, modeteset will crash with a segfault without. [How] Add a debug message indicating that a connector property is not handled when user space is trying to read it. TEST=modetest Signed-off

[PATCH v3 0/3] Fixes for selective fetch area calculation

2022-05-10 Thread Jouni Högander
Currently selective fetch area calculation ends up as bogus area in at least following cases: 1. Updated plane is partially or fully outside pipe area 2. Big fb with only part of memory area used for plane These end up as y1 = 0, y2 = 4 or y2 being outside pipe area. This patch set addresses thes

  1   2   >