[PATCH] backlight: replace usage of found with dedicated list iterator variable

2022-03-24 Thread Jakob Koschel
To move the list iterator variable into the list_for_each_entry_*() macro in the future it should be avoided to use the list iterator variable after the loop body. To *never* use the list iterator variable after the loop it was concluded to use a separate iterator variable instead of a found boole

Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

2022-03-24 Thread Sui Jingfeng
On 2022/3/23 04:49, Rob Herring wrote: + } + + spin_lock_init(&li2c->reglock); + + snprintf(compat, sizeof(compat), "lsdc,i2c-gpio-%d", index); compatible values shouldn't have an index and you shouldn't need a index in DT. You need to iterate over child nodes with matching c

Re:[PATCH] drm: mali-dp: check the return value of kzalloc()

2022-03-24 Thread Xiaoke Wang
Thu, 24 Mar 2022 14:43:17 +0800, xkernel.w...@foxmail.com wrote: > kzalloc() is a memory allocation function which can return NULL when > some internal memory errors happen. So it is better to check it to > prevent potential wrong memory access. Withdraw this. The original code is also fine since

[PULL] drm-misc-fixes

2022-03-24 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the weekly PR for drm-misc-fixes. Best regards Thomas drm-misc-fixes-2022-03-24: * drm/panel/ili9341: Fix optional regulator handling The following changes since commit 3c3384050d68570f9de0fec9e58824decfefba7a: drm: Don't make DRM_PANEL_BRIDGE dependent on DRM_KMS_

Re: [RFC PATCH] drm/panel: simple: panel-dpi: use bus-format to set bpc and bus_format

2022-03-24 Thread Francesco Dolcini
On Wed, Mar 23, 2022 at 09:06:18PM +0100, Max Krummenacher wrote: > Am Mittwoch, den 23.03.2022, 16:58 +0100 schrieb Maxime Ripard: > > On Wed, Mar 23, 2022 at 09:42:11AM +0100, Max Krummenacher wrote: > > > I would copy the definitions of media-bus-format.h into a header in > > > include/dt-bindin

Re: [PATCH] dt-bindings: display: bridge: Drop requirement on input port for DSI devices

2022-03-24 Thread Maxime Ripard
On Wed, Mar 23, 2022 at 10:38:19PM +0200, Laurent Pinchart wrote: > Hi Maxime, > > (CC'ing Sakari) > > Thank you for the patch. > > On Wed, Mar 23, 2022 at 04:48:23PM +0100, Maxime Ripard wrote: > > MIPI-DSI devices, if they are controlled through the bus itself, have to > > be described as a ch

RE: [PATCH 1/2] dt-bindings: display: bridge: Document RZ/G2L MIPI DSI TX bindings

2022-03-24 Thread Biju Das
Hi Rob, > Subject: Re: [PATCH 1/2] dt-bindings: display: bridge: Document RZ/G2L > MIPI DSI TX bindings > > On Wed, Mar 23, 2022 at 06:26:31PM +, Biju Das wrote: > > Hi Rob, > > > > Thanks for the feedback. > > > > > Subject: Re: [PATCH 1/2] dt-bindings: display: bridge: Document > > > RZ/G2L

[PATCH] drm/msm/mdp5: check the return of kzalloc()

2022-03-24 Thread xkernel . wang
From: Xiaoke Wang kzalloc() is a memory allocation function which can return NULL when some internal memory errors happen. So it is better to check it to prevent potential wrong memory access. Signed-off-by: Xiaoke Wang --- drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 17 ++--- 1 f

[PULL] drm-intel-next-fixes

2022-03-24 Thread Tvrtko Ursulin
Hi Dave, Daniel, A few fixes for the merge window. Apart from a uninteresting rename of a field in an unused macro, the rest are display fixes - two for SAGV and one for TDMS rate calculation on Icelake and above. Regards, Tvrtko drm-intel-next-fixes-2022-03-24: - Reject unsupported TMDS rat

Re: [PATCH 0/3] drm: bridge: it66121: Add audio support

2022-03-24 Thread Neil Armstrong
Hi, On Wed, 16 Mar 2022 14:57:30 +0100, Nicolas Belin wrote: > This patch series adds the audio support on the it66121 HDMI bridge. > > Patch 1 updates the ITE 66121 HDMI bridge bindings in order to support > audio. > > Patch 2 sets the register page length or window length of the ITE 66121 > HD

[PATCH] drm/msm/disp: check the return value of kzalloc()

2022-03-24 Thread xkernel . wang
From: Xiaoke Wang kzalloc() is a memory allocation function which can return NULL when some internal memory errors happen. So it is better to check it to prevent potential wrong memory access. Signed-off-by: Xiaoke Wang --- drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 2 ++ 1 file chang

Re: 回复: Re: 回复: Re: 回复: Re: [PATCH v1 1/2] drm/qxl: replace ioremap by ioremap_cache on arm64

2022-03-24 Thread Christian König
Hi Cong, when I understand Robin correctly all mapping (host, guest, kernel, userspace etc..) must have the same caching attributes unless you use the S2FWB feature introduced with Armv8.4. If you don't follow those rules you usually run into coherency issues or even worse system hangs. So y

Re: [RFC] drm/i915: Split out intel_vtd_active and run_as_guest to own header

2022-03-24 Thread Jani Nikula
On Tue, 22 Mar 2022, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > ... > > Signed-off-by: Tvrtko Ursulin > Cc: Jani Nikula > Cc: Lucas De Marchi > --- > Typed up how I see it - bash away. So is intel_vtd_active() so performance critical that it needs to be inline? We're passing struct drm

Re: [RFC] drm/i915: Split out intel_vtd_active and run_as_guest to own header

2022-03-24 Thread Jani Nikula
On Thu, 24 Mar 2022, Jani Nikula wrote: > On Tue, 22 Mar 2022, Tvrtko Ursulin wrote: >> From: Tvrtko Ursulin >> >> ... >> >> Signed-off-by: Tvrtko Ursulin >> Cc: Jani Nikula >> Cc: Lucas De Marchi >> --- >> Typed up how I see it - bash away. > > So is intel_vtd_active() so performance critica

Re: [Intel-gfx] [PATCH] drm/i915/guc: Correctly free guc capture struct on error

2022-03-24 Thread Das, Nirmoy
Reviewed-by: Nirmoy Das On 3/24/2022 1:04 AM, Daniele Ceraolo Spurio wrote: On error the "new" allocation is not freed, so add the required kfree. Fixes: 247f8071d5893 ("drm/i915/guc: Pre-allocate output nodes for extraction") Signed-off-by: Daniele Ceraolo Spurio Cc: Alan Previn Cc: John Ha

Re: [v3] drm/edid: check basic audio support on CEA extension block

2022-03-24 Thread Jani Nikula
On Thu, 24 Mar 2022, Lee Shawn C wrote: > From: Cooper Chiou > > Tag code stored in bit7:5 for CTA block byte[3] is not the same as > CEA extension block definition. Only check CEA block has > basic audio support. > > v3: update commit message. > > Cc: sta...@vger.kernel.org > Cc: Jani Nikula >

Re: [PATCH] drm/edid: fix CEA extension byte #3 parsing

2022-03-24 Thread Jani Nikula
On Wed, 23 Mar 2022, Ville Syrjälä wrote: > On Wed, Mar 23, 2022 at 12:04:38PM +0200, Jani Nikula wrote: >> Only an EDID CEA extension has byte #3, while the CTA DisplayID Data >> Block does not. Don't interpret bogus data for color formats. > > I think what we might want eventually is a cleaner s

Re: [PATCH v5 2/4] drm: introduce drm_writeback_connector_init_with_encoder() API

2022-03-24 Thread Liviu Dudau
On Wed, Mar 23, 2022 at 11:28:56AM -0700, Abhinav Kumar wrote: > Hi Liviu Hello, > > Thanks for the review. > > On 3/23/2022 9:46 AM, Liviu Dudau wrote: > > On Mon, Mar 21, 2022 at 04:56:43PM -0700, Abhinav Kumar wrote: > > > For vendors drivers which pass an already allocated and > > > initial

Re: 回复: Re: 回复: Re: 回复: Re: [PATCH v1 1/2] drm/qxl: replace ioremap by ioremap_cache on arm64

2022-03-24 Thread Gerd Hoffmann
On Thu, Mar 24, 2022 at 10:20:40AM +0100, Christian König wrote: > Hi Cong, > > when I understand Robin correctly all mapping (host, guest, kernel, > userspace etc..) must have the same caching attributes unless you use the > S2FWB feature introduced with Armv8.4. > > If you don't follow those ru

Re: [PATCH v6 0/7] drm/vc4: hdmi: Yet Another Approach to HDMI YUV output

2022-03-24 Thread Ville Syrjälä
On Tue, Feb 22, 2022 at 05:40:35PM +0100, Maxime Ripard wrote: > Hi, > > This is another attempt at supporting the HDMI YUV output in the vc4 HDMI > driver. > > This is a follow-up of > https://lore.kernel.org/dri-devel/20210317154352.732095-1-max...@cerno.tech/ > > And the discussions that occu

Re: [Intel-gfx] Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-24 Thread Daniel Vetter
On Wed, 23 Mar 2022 at 16:32, Christian König wrote: > > Am 23.03.22 um 16:24 schrieb Daniel Stone: > > On Wed, 23 Mar 2022 at 15:14, Alex Deucher wrote: > >> On Wed, Mar 23, 2022 at 11:04 AM Daniel Stone wrote: > >>> That's not what anyone's saying here ... > >>> > >>> No-one's demanding AMD pu

[PATCH] gpu: host1x: Do not use mapping cache for job submissions

2022-03-24 Thread Thierry Reding
From: Thierry Reding Buffer mappings used in job submissions are usually small and not rapidly reused as opposed to framebuffers (which are usually large and rapidly reused, for example when page-flipping between double-buffered framebuffers). Avoid going through the mapping cache for these buffe

[PATCH] drm/omapdrm: check the return value of kzalloc()

2022-03-24 Thread xkernel . wang
From: Xiaoke Wang kzalloc() is a memory allocation function which can return NULL when some internal memory errors happen. So it is better to check it. Besides, to properly handle the error, another check is added for the return of omap_irq_wait_init(). Signed-off-by: Xiaoke Wang --- drivers/g

Re: [RFC] drm/i915: Split out intel_vtd_active and run_as_guest to own header

2022-03-24 Thread Tvrtko Ursulin
On 24/03/2022 09:31, Jani Nikula wrote: On Tue, 22 Mar 2022, Tvrtko Ursulin wrote: From: Tvrtko Ursulin ... Signed-off-by: Tvrtko Ursulin Cc: Jani Nikula Cc: Lucas De Marchi --- Typed up how I see it - bash away. So is intel_vtd_active() so performance critical that it needs to be inl

Re: [PATCH -next] drm/bridge: it6505: Fix build error

2022-03-24 Thread Robert Foss
Added r-b & applied to drm-misc-next.

[PATCH] dt-bindings: display/msm: another fix for the dpu-qcm2290 example

2022-03-24 Thread Dmitry Baryshkov
Make dpu-qcm2290 example really follow the defined schema: - Drop qcom,mdss compatible. It's only used for MDP5 devices. - Change display controller name to display-controller as specified in the yaml Reported-by: Rob Herring Cc: Loic Poulain Fixes: 164f69d9d45a ("dt-bindings: msm: disp: add y

Re: [RFC] drm/i915: Split out intel_vtd_active and run_as_guest to own header

2022-03-24 Thread Jani Nikula
On Thu, 24 Mar 2022, Tvrtko Ursulin wrote: > On 24/03/2022 09:31, Jani Nikula wrote: >> On Tue, 22 Mar 2022, Tvrtko Ursulin wrote: >>> From: Tvrtko Ursulin >>> >>> ... >>> >>> Signed-off-by: Tvrtko Ursulin >>> Cc: Jani Nikula >>> Cc: Lucas De Marchi >>> --- >>> Typed up how I see it - bash aw

Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-24 Thread Robert Foss
> > > > The driver uses DRM_DEV_* for logs. Can we use this? > > > Hi Hsin-Yi, as comment in drm/drm_print.h: > > > "NOTE: this is deprecated in favor of drm_dbg". DRM bridge driver not > > > use DRM_DEV_* any more. I'll send a patch to replace all of DRM_DEV_* > > > later. > > > > drm_dbg is bette

Re: [PATCH v6 0/7] drm/vc4: hdmi: Yet Another Approach to HDMI YUV output

2022-03-24 Thread Maxime Ripard
On Tue, 22 Feb 2022 17:40:35 +0100, Maxime Ripard wrote: > This is another attempt at supporting the HDMI YUV output in the vc4 HDMI > driver. > > This is a follow-up of > https://lore.kernel.org/dri-devel/20210317154352.732095-1-max...@cerno.tech/ > > And the discussions that occured recently on

Re: [PATCH -next] drm/vc4: Fix build error when CONFIG_DRM_VC4=y && CONFIG_RASPBERRYPI_FIRMWARE=m

2022-03-24 Thread Maxime Ripard
On Thu, Mar 24, 2022 at 03:25:42PM +0800, Zheng Bin wrote: > If CONFIG_DRM_VC4=y, CONFIG_RASPBERRYPI_FIRMWARE=m, CONFIG_COMPILE_TEST=n, > bulding fails: > > drivers/gpu/drm/vc4/vc4_drv.o: In function `vc4_drm_bind': > vc4_drv.c:(.text+0x320): undefined reference to `rpi_firmware_get' > vc4_drv.c:(

[PULL] drm-misc-next-fixes

2022-03-24 Thread Maarten Lankhorst
drm-misc-next-fixes-2022-03-24: Short summary of fixes pull (less than what git shortlog provides): - explain anything non-fixes (e.g. cleanups) and why it's appropriate - highlight regressions - summarize pull requests contained This shouldn't be more than a few lines (or it indicates your fixes p

[PULL] drm-misc-next-fixes

2022-03-24 Thread Maarten Lankhorst
The previous pull request tag was botched due to my key expiring, updated! drm-misc-next-fixes-2022-03-24-1: drm-misc-next-fixes for v5.18-rc1: - Make audio and color plane support checking only happen when a CEA extension block is found. - Fix a small regression from ttm_resource_fini() - Small

Re: 回复: Re: 回复: Re: 回复: Re: 回复: Re: [PATCH v1 1/2] drm/qxl: replace ioremap by ioremap_cache on arm64

2022-03-24 Thread Gerd Hoffmann
On Thu, Mar 24, 2022 at 06:34:02PM +0800, liuco...@kylinos.cn wrote: >ok, thanks, a lot of our customer use qxl on x86 before, so it still need >to supoort qxl on arm64. Well, qxl isn't the best choice even on x86. The main advantage it offers (2d acceleration) is basically useless today

Re: [PATCH v11 5/7] dt-bindings: display: Add Loongson display controller

2022-03-24 Thread Rob Herring
On Thu, Mar 24, 2022 at 09:48:19AM +0800, Sui Jingfeng wrote: > > On 2022/3/23 21:03, Rob Herring wrote: > > On Wed, Mar 23, 2022 at 11:38:55AM +0800, Sui Jingfeng wrote: > > > On 2022/3/23 04:55, Rob Herring wrote: > > > > On Tue, Mar 22, 2022 at 10:33:45AM +0800, Sui Jingfeng wrote: > > > > > On

Re: [PATCH] drm: gma500: clean up some style problems reported by checkpatch.pl

2022-03-24 Thread Patrik Jakobsson
On Thu, Mar 24, 2022 at 10:16 AM Haowen Bai wrote: > > WARNING: Statements should start on a tabstop > > WARNING: Missing a blank line after declarations > > Signed-off-by: Haowen Bai Hi, thanks for the patch. > --- > drivers/gpu/drm/gma500/mid_bios.c | 5 +++-- > 1 file changed, 3 insertions(

Re: [RFC] drm/i915: Split out intel_vtd_active and run_as_guest to own header

2022-03-24 Thread Tvrtko Ursulin
On 24/03/2022 11:57, Jani Nikula wrote: On Thu, 24 Mar 2022, Tvrtko Ursulin wrote: On 24/03/2022 09:31, Jani Nikula wrote: On Tue, 22 Mar 2022, Tvrtko Ursulin wrote: From: Tvrtko Ursulin ... Signed-off-by: Tvrtko Ursulin Cc: Jani Nikula Cc: Lucas De Marchi --- Typed up how I see it -

Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

2022-03-24 Thread Rob Herring
On Thu, Mar 24, 2022 at 09:39:49AM +0800, Sui Jingfeng wrote: > > On 2022/3/23 04:49, Rob Herring wrote: > > On Tue, Mar 22, 2022 at 12:29:16AM +0800, Sui Jingfeng wrote: > > > From: suijingfeng > > > > > > There is a display controller in loongson's LS2K1000 SoC and LS7A1000 > > > bridge chip,

Re: [PATCH] dt-bindings: display: bridge: Drop requirement on input port for DSI devices

2022-03-24 Thread Laurent Pinchart
Hi Maxime, On Thu, Mar 24, 2022 at 09:18:19AM +0100, Maxime Ripard wrote: > On Wed, Mar 23, 2022 at 10:38:19PM +0200, Laurent Pinchart wrote: > > Hi Maxime, > > > > (CC'ing Sakari) > > > > Thank you for the patch. > > > > On Wed, Mar 23, 2022 at 04:48:23PM +0100, Maxime Ripard wrote: > > > MIPI

Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

2022-03-24 Thread Rob Herring
On Thu, Mar 24, 2022 at 03:32:01PM +0800, Sui Jingfeng wrote: > > On 2022/3/23 04:49, Rob Herring wrote: > > > + } > > > + > > > + spin_lock_init(&li2c->reglock); > > > + > > > + snprintf(compat, sizeof(compat), "lsdc,i2c-gpio-%d", index); > > compatible values shouldn't have an index and you shou

Re: [PATCH] dt-bindings: display/msm: another fix for the dpu-qcm2290 example

2022-03-24 Thread Krzysztof Kozlowski
On 24/03/2022 12:55, Dmitry Baryshkov wrote: > Make dpu-qcm2290 example really follow the defined schema: > - Drop qcom,mdss compatible. It's only used for MDP5 devices. > - Change display controller name to display-controller as specified in > the yaml > > Reported-by: Rob Herring > Cc: Loic P

Re: [Intel-gfx] [PATCH v5 15/19] drm/i915/dg2: Add DG2 unified compression

2022-03-24 Thread Imre Deak
On Thu, Mar 24, 2022 at 01:40:37AM +0200, Chery, Nanley G wrote: > > [...] > > Capturing all the above would you be ok with the following?: > > > > Intel color control surfaces (CCS) for DG2 render compression. > > > > The main surface is Tile 4 and at plane index 0. The CCS data is stored > > ou

Re: [PATCH] dt-bindings: display: bridge: Drop requirement on input port for DSI devices

2022-03-24 Thread Maxime Ripard
On Thu, Mar 24, 2022 at 03:43:42PM +0200, Laurent Pinchart wrote: > On Thu, Mar 24, 2022 at 09:18:19AM +0100, Maxime Ripard wrote: > > On Wed, Mar 23, 2022 at 10:38:19PM +0200, Laurent Pinchart wrote: > > > Hi Maxime, > > > > > > (CC'ing Sakari) > > > > > > Thank you for the patch. > > > > > > O

Re: [PATCH 1/6] drm/ttm: move the LRU into resource handling v4

2022-03-24 Thread Christian König
Am 23.03.22 um 11:35 schrieb Daniel Vetter: On Mon, Mar 21, 2022 at 02:25:56PM +0100, Christian König wrote: [SNIP] EXPORT_SYMBOL(ttm_resource_init); @@ -66,15 +172,21 @@ EXPORT_SYMBOL(ttm_resource_init); * @res: the resource to clean up * * Should be used by resource manager backends

Re: [Intel-gfx] [PATCH v5 16/19] uapi/drm/dg2: Introduce format modifier for DG2 clear color

2022-03-24 Thread Imre Deak
On Thu, Mar 24, 2022 at 01:42:33AM +0200, Chery, Nanley G wrote: > > -Original Message- > > From: Deak, Imre > > Sent: Monday, March 21, 2022 6:20 AM > > To: Chery, Nanley G ; Juha-Pekka Heikkila > > > > Cc: Nanley Chery ; C, Ramalingam > > ; intel-gfx ; > > Auld, Matthew ; dri-devel >

[PATCH 0/4] drm/atomic: Atomic Private State debugging

2022-03-24 Thread Maxime Ripard
Hi, This series adds an atomic_print_state hook for drm_private_obj to ease the debugging of driver-specific sub-classes, and adds one for vc4. It also changes the call site of drm_atomic_print_new_state to make it more consistent. Let me know what you think, Maxime Maxime Ripard (4): drm/ato

[PATCH 1/4] drm/atomic: Print the state every commit

2022-03-24 Thread Maxime Ripard
The DRM_UT_STATE controls whether we're calling drm_atomic_print_new_state() whenever a new state is committed. However, that call is made in the drm_mode_atomic_ioctl(), whereas we have multiple users of the drm_atomic_commit() function in the kernel (framebuffer emulation, drm_atomic_helper_dirty

[PATCH 3/4] drm/vc4: Constify private state accessors

2022-03-24 Thread Maxime Ripard
None of those helpers modify the pointed data, let's make them const. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_kms.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c index 24de29bc1cda..26b771

[PATCH 2/4] drm/atomic: Add atomic_print_state to private objects

2022-03-24 Thread Maxime Ripard
A number of drivers (amdgpu, komeda, vc4, etc.) leverage the drm_private_state structure, but we don't have any infrastructure to provide debugging like we do for the other components state. Let's add an atomic_print_state hook to be consistent. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/d

[PATCH 4/4] drm/vc4: Implement atomic_print_state for HVS channel state

2022-03-24 Thread Maxime Ripard
The HVS state configuration is useful when debugging what's going on in the vc4 hardware pipeline. Add an implementation of .atomic_print_state. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_kms.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/v

Re: [PATCH] dt-bindings: display: bridge: Drop requirement on input port for DSI devices

2022-03-24 Thread Laurent Pinchart
Hi Maxime, On Thu, Mar 24, 2022 at 03:23:24PM +0100, Maxime Ripard wrote: > On Thu, Mar 24, 2022 at 03:43:42PM +0200, Laurent Pinchart wrote: > > On Thu, Mar 24, 2022 at 09:18:19AM +0100, Maxime Ripard wrote: > > > On Wed, Mar 23, 2022 at 10:38:19PM +0200, Laurent Pinchart wrote: > > > > Hi Maxime

Re: [PATCH] backlight: replace usage of found with dedicated list iterator variable

2022-03-24 Thread Daniel Thompson
On Thu, Mar 24, 2022 at 08:06:08AM +0100, Jakob Koschel wrote: > To move the list iterator variable into the list_for_each_entry_*() > macro in the future it should be avoided to use the list iterator > variable after the loop body. > > To *never* use the list iterator variable after the loop it w

[PATCH] dt-bindings: display: mediatek: Add includes on examples

2022-03-24 Thread Corentin Labbe
make dt_binding_check fail on lot of mediatek bindings due to missing includes. Signed-off-by: Corentin Labbe --- 2 files remains to be fixed, but their examples use some variable undefined, so I cannot do anything: - display/mediatek/mediatek,ethdr.yaml - display/mediatek/mediatek,merge.yaml

Re: [Spice-devel] 回复: Re: 回复: Re: 回复: Re: 回复: Re: [PATCH v1 1/2] drm/qxl: replace ioremap by ioremap_cache on arm64

2022-03-24 Thread Daniel P . Berrangé
On Thu, Mar 24, 2022 at 02:21:09PM +0100, Gerd Hoffmann wrote: > On Thu, Mar 24, 2022 at 06:34:02PM +0800, liuco...@kylinos.cn wrote: > >ok, thanks, a lot of our customer use qxl on x86 before, so it still need > >to supoort qxl on arm64. > > Well, qxl isn't the best choice even on x86. T

Re: [Intel-gfx] [PATCH v5 2/9] drm/i915/gt: Optimize the migration and clear loop

2022-03-24 Thread Intel
On 3/21/22 23:44, Ramalingam C wrote: Move the static calculations out of the loops for copy and clear. Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gt/intel_migrate.c | 44 - 1 file changed, 21 insertions(+), 23 deletions

Re: [PATCH 1/4] drm/etnaviv: check for reaped mapping in etnaviv_iommu_unmap_gem

2022-03-24 Thread Philipp Zabel
On Mi, 2022-03-23 at 17:08 +0100, Lucas Stach wrote: > When the mapping is already reaped the unmap must be a no-op, as we > would otherwise try to remove the mapping twice, corrupting the > involved > data structures. > > Cc: sta...@vger.kernel.org # 5.4 > Signed-off-by: Lucas Stach Reviewed-by

Re: [PATCH 2/4] drm/etnaviv: move MMU context ref/unref into map/unmap_gem

2022-03-24 Thread Philipp Zabel
On Mi, 2022-03-23 at 17:08 +0100, Lucas Stach wrote: > This makes it a little more clear that the mapping holds a reference > to the context once the buffer has been successfully mapped into that > context and simplifies the error handling a bit. > > Signed-off-by: Lucas Stach Reviewed-by: Phili

Re: [PATCH 3/4] drm/etnaviv: move flush_seq increment into etnaviv_iommu_map/unmap

2022-03-24 Thread Philipp Zabel
On Mi, 2022-03-23 at 17:08 +0100, Lucas Stach wrote: The flush sequence is a marker that the page tables have been changed and any affected TLBs need to be flushed. Move the flush_seq increment a little further down the call stack to place it next to the actual page table manipulation. Not function

Re: [REPOST PATCH v4 07/13] drm/msm/disp/dpu1: Add support for DSC in encoder

2022-03-24 Thread Vinod Koul
On 23-03-22, 20:10, Vinod Koul wrote: > On 17-02-22, 23:32, Marijn Suijten wrote: > > On 2022-02-10 16:04:17, Vinod Koul wrote: > > > + > > > + slice_count = dsc->drm->slice_count; > > > + slice_per_intf = DIV_ROUND_UP(width, dsc->drm->slice_width); > > > + > > > + /* > > > + * If slice_count is

Re: [REPOST PATCH v4 13/13] drm/msm/dsi: Add support for DSC configuration

2022-03-24 Thread Vinod Koul
On 21-02-22, 05:11, Dmitry Baryshkov wrote: > On 10/02/2022 13:34, Vinod Koul wrote: > > When DSC is enabled, we need to configure DSI registers accordingly and > > configure the respective stream compression registers. > > > > Add support to calculate the register setting based on DSC params and

Re: [Intel-gfx] [PATCH v5 3/9] drm/i915/gt: Clear compress metadata for Flat-ccs objects

2022-03-24 Thread Intel
Hi, Ram On 3/21/22 23:44, Ramalingam C wrote: Xe-HP and latest devices support Flat CCS which reserved a portion of the device memory to store compression metadata, during the clearing of device memory buffer object we also need to clear the associated CCS buffer. XY_CTRL_SURF_COPY_BLT is a BLT

Re: [Intel-gfx] [PATCH v5 17/19] drm/i915/dg2: Flat CCS Support

2022-03-24 Thread Imre Deak
On Tue, Feb 01, 2022 at 04:11:30PM +0530, Ramalingam C wrote: > From: Anshuman Gupta > > DG2 onwards discrete gfx has support for new flat CCS mapping, > which brings in display feature in to avoid Aux walk for compressed > surface. This support build on top of Flat CCS support added in XEHPSDV.

Re: [Intel-gfx] [PATCH v5 6/9] drm/i915/gt: offset handling for multiple copy engines

2022-03-24 Thread Intel
On 3/21/22 23:44, Ramalingam C wrote: Handle the src and dst chunk offsets for different instances of the copy engines. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/

Re: [REPOST PATCH v4 06/13] drm/msm/disp/dpu1: Add DSC support in hw_ctl

2022-03-24 Thread Vinod Koul
On 17-02-22, 23:20, Marijn Suijten wrote: > On 2022-02-10 16:04:16, Vinod Koul wrote: > > Later gens of hardware have DSC bits moved to hw_ctl, so configure these > > bits so that DSC would work there as well > > > > Reviewed-by: Dmitry Baryshkov > > Signed-off-by: Vinod Koul > > --- > > driver

Re: [PATCH v5 8/9] drm/i915/gem: Add extra pages in ttm_tt for ccs data

2022-03-24 Thread Thomas Hellström
On 3/21/22 23:44, Ramalingam C wrote: On Xe-HP and later devices, dedicated compression control state (CCS) stored in local memory is used for each surface, to support the 3D and media compression formats. The memory required for the CCS of the entire local memory is 1/256 of the local memory

Re: [PATCH v5 2/4] drm: introduce drm_writeback_connector_init_with_encoder() API

2022-03-24 Thread Abhinav Kumar
Hi Liviu Thanks for the response. On 3/24/2022 3:12 AM, Liviu Dudau wrote: On Wed, Mar 23, 2022 at 11:28:56AM -0700, Abhinav Kumar wrote: Hi Liviu Hello, Thanks for the review. On 3/23/2022 9:46 AM, Liviu Dudau wrote: On Mon, Mar 21, 2022 at 04:56:43PM -0700, Abhinav Kumar wrote: For v

Re: [PATCH 1/4] drm/atomic: Print the state every commit

2022-03-24 Thread Daniel Vetter
On Thu, Mar 24, 2022 at 03:47:21PM +0100, Maxime Ripard wrote: > The DRM_UT_STATE controls whether we're calling > drm_atomic_print_new_state() whenever a new state is committed. However, > that call is made in the drm_mode_atomic_ioctl(), whereas we have > multiple users of the drm_atomic_commit()

Re: [PATCH 2/4] drm/atomic: Add atomic_print_state to private objects

2022-03-24 Thread Daniel Vetter
On Thu, Mar 24, 2022 at 03:47:22PM +0100, Maxime Ripard wrote: > A number of drivers (amdgpu, komeda, vc4, etc.) leverage the > drm_private_state structure, but we don't have any infrastructure to > provide debugging like we do for the other components state. Let's add > an atomic_print_state hook

Re: [PATCH 4/4] drm/vc4: Implement atomic_print_state for HVS channel state

2022-03-24 Thread Daniel Vetter
On Thu, Mar 24, 2022 at 03:47:24PM +0100, Maxime Ripard wrote: > The HVS state configuration is useful when debugging what's going on in > the vc4 hardware pipeline. Add an implementation of .atomic_print_state. > > Signed-off-by: Maxime Ripard On the two vc4 patches: Acked-by: Daniel Vetter >

[PATCH 1/2] drm/i915/ttm: limit where we apply TTM_PL_FLAG_CONTIGUOUS

2022-03-24 Thread Matthew Auld
We only need this when allocating device local-memory, where this influences the drm_buddy. Currently there is some funny behaviour where an "in limbo" system memory object is lacking the relevant placement flags etc. before we first allocate the ttm_tt, leading to ttm performing a move when not ne

[PATCH 2/2] drm/i915/migrate: move the sanity check

2022-03-24 Thread Matthew Auld
Move the sanity check that both src and dst are never both system memory, which should never happen on discrete, and likely means we have a bug. The only exception is on integrated where we trigger this path in the selftests. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Nirmoy Das ---

Re: Parallel modesets and private state objects broken, where to go with MST?

2022-03-24 Thread Daniel Vetter
On Wed, Mar 23, 2022 at 02:34:35PM -0400, Lyude Paul wrote: > On Wed, 2022-03-23 at 11:25 +0100, Daniel Vetter wrote: > > On Tue, Mar 22, 2022 at 05:37:40PM -0400, Lyude Paul wrote: > > > OK so - this has become a bit of a larger rabbit hole. I've been putting > > > quite > > > a bit of work into t

Re: [PATCH 1/6] drm/ttm: move the LRU into resource handling v4

2022-03-24 Thread Daniel Vetter
On Thu, Mar 24, 2022 at 03:25:08PM +0100, Christian König wrote: > Am 23.03.22 um 11:35 schrieb Daniel Vetter: > > On Mon, Mar 21, 2022 at 02:25:56PM +0100, Christian König wrote: > > > [SNIP] > > > EXPORT_SYMBOL(ttm_resource_init); > > > @@ -66,15 +172,21 @@ EXPORT_SYMBOL(ttm_resource_init); > >

Re: [PATCH] drm/msm/disp: check the return value of kzalloc()

2022-03-24 Thread Abhinav Kumar
On 3/24/2022 2:15 AM, xkernel.w...@foxmail.com wrote: From: Xiaoke Wang kzalloc() is a memory allocation function which can return NULL when some internal memory errors happen. So it is better to check it to prevent potential wrong memory access. Signed-off-by: Xiaoke Wang Reviewed-by: Ab

Re: [PATCH] drm/msm/mdp5: check the return of kzalloc()

2022-03-24 Thread Abhinav Kumar
On 3/24/2022 1:36 AM, xkernel.w...@foxmail.com wrote: From: Xiaoke Wang kzalloc() is a memory allocation function which can return NULL when some internal memory errors happen. So it is better to check it to prevent potential wrong memory access. Signed-off-by: Xiaoke Wang Reviewed-by: Ab

[PATCH 1/2] dt-bindings: display: simple: Add AUO B133UAN01 panel

2022-03-24 Thread Matthias Kaehlcke
Add binding for the AUO B133UAN01 panel. It is 13.3" TFT LCD panel with WUXGA (1920x1200) resolution. Signed-off-by: Matthias Kaehlcke --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/disp

[PATCH 2/2] drm/panel-edp: Add AUO B133UAN01

2022-03-24 Thread Matthias Kaehlcke
Add support for the AUO B133UAN01 13.3" WUXGA panel. Signed-off-by: Matthias Kaehlcke --- output of edid-decode: Block 0, Base EDID: EDID Structure Version & Revision: 1.4 Vendor & Product Identification: Manufacturer: AUO Model: 34196 Made in: 2020 Basic Display

Re: [PATCH 2/2] drm/panel-edp: Add AUO B133UAN01

2022-03-24 Thread Doug Anderson
Hi, On Thu, Mar 24, 2022 at 11:14 AM Matthias Kaehlcke wrote: > > Add support for the AUO B133UAN01 13.3" WUXGA panel. > > Signed-off-by: Matthias Kaehlcke > --- > output of edid-decode: > > Block 0, Base EDID: > EDID Structure Version & Revision: 1.4 > Vendor & Product Identification:

Re: [RFC] drm/i915: Split out intel_vtd_active and run_as_guest to own header

2022-03-24 Thread Jani Nikula
On Thu, 24 Mar 2022, Tvrtko Ursulin wrote: > On 24/03/2022 11:57, Jani Nikula wrote: >> On Thu, 24 Mar 2022, Tvrtko Ursulin wrote: >>> On 24/03/2022 09:31, Jani Nikula wrote: On Tue, 22 Mar 2022, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > ... > > Signed-off-by: Tv

Re: [PATCH v7 06/12] clk: Always set the rate on clk_set_range_rate

2022-03-24 Thread Stephen Boyd
Quoting Maxime Ripard (2022-03-23 01:51:40) > Hi, > > > The whole point of this patch is to give an opportunity to every driver > to change the rate whenever the boundaries have changed, so we very much > want to have the option to change it if clk_set_rate() has never been > called. > > However

Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()

2022-03-24 Thread Thomas Zimmermann
ror: Oops: 807 [#1] ARM CPU: 0 PID: 1 Comm: swapper Not tainted 5.17.0-next-20220324 #1 Hardware name: Sharp-Collie PC is at cfb_imageblit+0x58c/0x6e0 LR is at 0x5 pc : []lr : [<0005>]psr: a153 sp : e0809958 ip : e090d000 fp : e08099f4 r10: e08099c8 r9 : c0c70600 r8 : ff

Re: [PATCH 2/2] drm/panel-edp: Add AUO B133UAN01

2022-03-24 Thread Matthias Kaehlcke
Hi Doug, On Thu, Mar 24, 2022 at 11:27:46AM -0700, Doug Anderson wrote: > Hi, > > On Thu, Mar 24, 2022 at 11:14 AM Matthias Kaehlcke wrote: > > > > Add support for the AUO B133UAN01 13.3" WUXGA panel. > > > > Signed-off-by: Matthias Kaehlcke > > --- > > output of edid-decode: > > > > Block 0,

Re: [PATCH v7 06/12] clk: Always set the rate on clk_set_range_rate

2022-03-24 Thread Dmitry Osipenko
On 3/23/22 11:51, Maxime Ripard wrote: > Hi, > > On Tue, Mar 22, 2022 at 10:05:56PM +0300, Dmitry Osipenko wrote: >> On 2/25/22 17:35, Maxime Ripard wrote: >>> When we change a clock minimum or maximum using clk_set_rate_range(), >>> clk_set_min_rate() or clk_set_max_rate(), the current code will

Re: [git pull] drm for 5.18-rc1

2022-03-24 Thread Guenter Roeck
Internal error: Oops: 807 [#1] ARM CPU: 0 PID: 1 Comm: swapper Not tainted 5.17.0-next-20220324 #1 Hardware name: Sharp-Collie PC is at cfb_imageblit+0x58c/0x6e0 Guenter

Re: [PATCH] drm/virtio: fix NULL pointer dereference in virtio_gpu_conn_get_modes

2022-03-24 Thread Chia-I Wu
On Wed, Mar 23, 2022 at 4:01 AM Liu Zixian wrote: > diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c > b/drivers/gpu/drm/virtio/virtgpu_display.c > index 5b00310ac..f73352e7b 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_display.c > +++ b/drivers/gpu/drm/virtio/virtgpu_display.c > @@ -179,6

Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()

2022-03-24 Thread Guenter Roeck
m. collie crash log and bisect log attached. Guenter --- 8<--- cut here --- Unable to handle kernel paging request at virtual address e090d000 [e090d000] *pgd=c0c0b811c0c0b811, *pte=c0c0b000, *ppte= Internal error: Oops: 807 [#1] ARM CPU: 0 PID: 1 Comm: swapper Not tainted 5.17.0-next-20220

Re: [PATCH 1/3] drm/msm/dp: drop dp_mode argument from dp_panel_get_modes()

2022-03-24 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-23 03:35:44) > Since the commit ab205927592b ("drm/msm/dp: remove mode hard-coding in > case of DP CTS") the function dp_panel_get_modes() doesn't use (or fill) > the dp_mode argument. Drop it completely. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Ste

Re: [PATCH 3/3] drm/msm/dp: remove max_pclk_khz field from dp_panel/dp_display

2022-03-24 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-23 03:35:46) > Since the last commit, the max_pclk_khz became constant, it's set to > DP_MAX_PIXEL_CLK_KHZ and never changed afterwards. Remove it completely > and use DP_MAX_PIXEL_CLK_KHZ directly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen B

Re: [PATCH 2/3] drm/msm/dp: simplify dp_connector_get_modes()

2022-03-24 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-23 03:35:45) > Since dp_panel_get_modes() handling for dp_mode was removed, > dp_display_get_modes also doesn't change the passed dp_mode, drop the > unused dp_mode variable being allocated unused and then freed. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed

Re: [PATCH] dt-bindings: display/msm: another fix for the dpu-qcm2290 example

2022-03-24 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-24 04:55:36) > Make dpu-qcm2290 example really follow the defined schema: > - Drop qcom,mdss compatible. It's only used for MDP5 devices. > - Change display controller name to display-controller as specified in > the yaml > > Reported-by: Rob Herring > Cc: Loic

[PATCH v2] panel-edp: drm/panel-edp: Add AUO B133UAN01

2022-03-24 Thread Matthias Kaehlcke
Add support for the AUO B133UAN01 13.3" WUXGA panel. Signed-off-by: Matthias Kaehlcke --- Changes in v2: - autodetect and configure the panel based on the EDID data instead of relying on a compatible string and hardcoded mode settings. drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed,

Re: [PATCH v2] panel-edp: drm/panel-edp: Add AUO B133UAN01

2022-03-24 Thread Doug Anderson
Hi, On Thu, Mar 24, 2022 at 1:48 PM Matthias Kaehlcke wrote: > > Add support for the AUO B133UAN01 13.3" WUXGA panel. > > Signed-off-by: Matthias Kaehlcke > --- > > Changes in v2: > - autodetect and configure the panel based on the EDID data instead of > relying on a compatible string and hard

Re: [PATCH 1/2] dt-bindings: display: simple: Add AUO B133UAN01 panel

2022-03-24 Thread Doug Anderson
Hi, On Thu, Mar 24, 2022 at 11:14 AM Matthias Kaehlcke wrote: > > Add binding for the AUO B133UAN01 panel. It is 13.3" TFT LCD panel > with WUXGA (1920x1200) resolution. > > Signed-off-by: Matthias Kaehlcke > --- > > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 fi

Re: [PATCH v3 3/6] drm/msm: split the main platform driver

2022-03-24 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-23 02:25:35) > Currently the msm platform driver is a multiplex handling several cases: > - headless GPU-only driver, > - MDP4 with flat device nodes, > - MDP5/DPU MDSS with all the nodes being children of MDSS node. > > This results in not-so-perfect code, checkin

Re: [PATCH v3 6/6] drm/msm: make mdp5/dpu devices master components

2022-03-24 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-23 02:25:38) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > index 38627ccf3068..ab8a35e09bc9 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > @@ -381,8 +3

Re: [2/2] fbdev: Fix cfb_imageblit() for arbitrary image widths

2022-03-24 Thread Guenter Roeck
On Sun, Mar 13, 2022 at 08:29:52PM +0100, Thomas Zimmermann wrote: > Commit 0d03011894d2 ("fbdev: Improve performance of cfb_imageblit()") > broke cfb_imageblit() for image widths that are not aligned to 8-bit > boundaries. Fix this by handling the trailing pixels on each line > separately. The per

Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()

2022-03-24 Thread Guenter Roeck
On 3/24/22 12:18, Thomas Zimmermann wrote: Hi Am 24.03.22 um 20:11 schrieb Guenter Roeck: Hi, On Wed, Feb 23, 2022 at 08:38:03PM +0100, Thomas Zimmermann wrote: Improve the performance of cfb_imageblit() by manually unrolling the inner blitting loop and moving some invariants out. The compile

Re: [git pull] drm for 5.18-rc1

2022-03-24 Thread Rob Herring
On Thu, Mar 24, 2022 at 3:32 AM Dave Airlie wrote: > > Hi Linus, > > This is the main drm pull request for 5.18. > > The summary changelog is below, lots of work all over, > Intel improving DG2 support, amdkfd CRIU support, msm > new hw support, and faster fbdev support. > > Conflicts: > I did a m

Re: [PATCH v2 1/2] dt-bindings: pinctrl: aspeed: Update gfx node in example

2022-03-24 Thread Linus Walleij
On Fri, Mar 4, 2022 at 1:03 AM Joel Stanley wrote: > The example needs updating to match the to be added yaml bindings for > the gfx node. > > Signed-off-by: Joel Stanley Patch applied. Yours, Linus Walleij

[GIT PULL] mediatek drm fixes - 20220325

2022-03-24 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Fix dt-binding issue. Regards, Chun-Kuang. The following changes since commit 71941773e143369a73c9c4a3b62fbb60736a1182: Add linux-next specific files for 20220310 (2022-03-10 20:04:36 +1100) are available in the git repository at: https://git.kernel.o

Re: [PATCH] dt-bindings: display: mediatek: Add includes on examples

2022-03-24 Thread Chun-Kuang Hu
Hi, Corentin: I've applied Jason's series [1] to my tree [2], does that series fix your problem? [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=621899 [2] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes Regards, Chun-Kuang.

  1   2   >