On 2022/3/23 04:49, Rob Herring wrote:
+       }
+
+       spin_lock_init(&li2c->reglock);
+
+       snprintf(compat, sizeof(compat), "lsdc,i2c-gpio-%d", index);
compatible values shouldn't have an index and you shouldn't need a
index in DT. You need to iterate over child nodes with matching
compatible.

Why compatible values shouldn't have an index, does devicetree
specification prohibit this? [1]

The recommended format is "manufacturer,model", where manufacturer is a string 
describing the name
of the manufacturer (such as a stock ticker symbol), and model specifies the 
model number. [1]

[1] https://www.devicetree.org/specifications/

Reply via email to