Re: (subset) [PATCH] drm/bridge: parade-ps8640: switch to devm_drm_of_get_bridge

2022-03-08 Thread Maxime Ripard
On Mon, 28 Feb 2022 19:31:31 +0100, José Expósito wrote: > The function "drm_of_find_panel_or_bridge" has been deprecated in > favor of "devm_drm_of_get_bridge". > > Switch to the new function and reduce boilerplate. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH] drm/bridge: nxp-ptn3460: switch to devm_drm_of_get_bridge

2022-03-08 Thread Maxime Ripard
On Mon, 28 Feb 2022 19:26:00 +0100, José Expósito wrote: > The function "drm_of_find_panel_or_bridge" has been deprecated in > favor of "devm_drm_of_get_bridge". > > Switch to the new function and reduce boilerplate. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH] drm/bridge: tc358775: switch to devm_drm_of_get_bridge

2022-03-08 Thread Maxime Ripard
On Mon, 28 Feb 2022 19:35:37 +0100, José Expósito wrote: > The function "drm_of_find_panel_or_bridge" has been deprecated in > favor of "devm_drm_of_get_bridge". > > Switch to the new function and reduce boilerplate. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH] drm/bridge: ti-sn65dsi83: switch to devm_drm_of_get_bridge

2022-03-08 Thread Maxime Ripard
On Mon, 28 Feb 2022 19:37:24 +0100, José Expósito wrote: > The function "drm_of_find_panel_or_bridge" has been deprecated in > favor of "devm_drm_of_get_bridge". > > Switch to the new function and reduce boilerplate. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH] drm/bridge: parade-ps8622: switch to devm_drm_of_get_bridge

2022-03-08 Thread Maxime Ripard
On Mon, 28 Feb 2022 19:29:04 +0100, José Expósito wrote: > The function "drm_of_find_panel_or_bridge" has been deprecated in > favor of "devm_drm_of_get_bridge". > > Switch to the new function and reduce boilerplate. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH] drm/bridge: tc358762: switch to devm_drm_of_get_bridge

2022-03-08 Thread Maxime Ripard
On Mon, 28 Feb 2022 19:33:42 +0100, José Expósito wrote: > The function "drm_of_find_panel_or_bridge" has been deprecated in > favor of "devm_drm_of_get_bridge". > > Switch to the new function and reduce boilerplate. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH] drm/bridge: parade-ps8622: switch to devm_drm_of_get_bridge

2022-03-08 Thread Jagan Teki
Hi Maxime, On Tue, Mar 8, 2022 at 4:51 PM Maxime Ripard wrote: > > On Mon, 28 Feb 2022 19:29:04 +0100, José Expósito wrote: > > The function "drm_of_find_panel_or_bridge" has been deprecated in > > favor of "devm_drm_of_get_bridge". > > > > Switch to the new function and reduce boilerplate. > > >

Re: [PATCH V3 05/13] drm: bridge: icn6211: Add DSI lane count DT property parsing

2022-03-08 Thread Jagan Teki
Hi Marek, On Tue, Mar 8, 2022 at 4:00 PM Marek Vasut wrote: > > On 3/8/22 11:07, Jagan Teki wrote: > > On Tue, Mar 8, 2022 at 3:19 PM Marek Vasut wrote: > >> > >> On 3/8/22 09:03, Jagan Teki wrote: > >> > >> Hi, > >> > >> [...] > >> > @@ -314,7 +321,9 @@ static const struct drm_bridge_funcs

[Bug 215669] New: [drm:gfx_v10_0_priv_reg_irq [amdgpu]] *ERROR* Illegal register access in command stream

2022-03-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215669 Bug ID: 215669 Summary: [drm:gfx_v10_0_priv_reg_irq [amdgpu]] *ERROR* Illegal register access in command stream Product: Drivers Version: 2.5 Kernel Version: 5.10.103-1-MANJARO x

Re: [PATCH 06/10] drm/gma500: Move GTT resume logic out of psb_gtt_init()

2022-03-08 Thread Patrik Jakobsson
On Tue, Mar 8, 2022 at 9:48 AM Thomas Zimmermann wrote: > > Hi Sam and Patrik > > Am 07.03.22 um 22:02 schrieb Patrik Jakobsson: > > On Mon, Mar 7, 2022 at 8:07 PM Sam Ravnborg wrote: > >> > >> Hi Thomas, > >> > >> One comment below. > >> > >> On Sun, Mar 06, 2022 at 09:36:15PM +0100, Thomas Zimm

Re: [PATCH v1 1/1] staging: fbtft: Consider type of init sequence values in fbtft_init_display()

2022-03-08 Thread Andy Shevchenko
On Tue, Mar 08, 2022 at 11:46:32AM +0100, Greg Kroah-Hartman wrote: > On Tue, Mar 08, 2022 at 12:18:25PM +0200, Andy Shevchenko wrote: > > +Cc: Helge > > > > Maybe you can pick this up? > > > > On Fri, Mar 04, 2022 at 09:34:14PM +0200, Andy Shevchenko wrote: > > You sent this less than a week ag

Re: [PATCH V3 01/13] dt-bindings: display: bridge: icn6211: Document DSI data-lanes property

2022-03-08 Thread Maxime Ripard
On Fri, Mar 04, 2022 at 01:24:56AM +0100, Marek Vasut wrote: > It is necessary to specify the number of connected/used DSI data lanes when > using the DSI input port of this bridge. Document the 'data-lanes' property > of the DSI input port. > > Signed-off-by: Marek Vasut > Cc: Jagan Teki > Cc:

Re: [PATCH V3 04/13] drm: bridge: icn6211: Add HS/VS/DE polarity handling

2022-03-08 Thread Maxime Ripard
On Fri, Mar 04, 2022 at 01:24:59AM +0100, Marek Vasut wrote: > The driver currently hard-codes HS/VS polarity to active-low and DE to > active-high, which is not correct for a lot of supported DPI panels. > Add the missing mode flag handling for HS/VS/DE polarity. > > Signed-off-by: Marek Vasut >

Re: [PATCH RFC libdrm 1/2] intel: Improve checks for big-endian

2022-03-08 Thread Robin Murphy
On 2022-03-07 20:53, Geert Uytterhoeven wrote: - sparc64-linux-gnu-gcc does not define __BIG_ENDIAN__ or SPARC, but does define __sparc__, hence replace the check for SPARC by a check for __sparc__, - powerpc{,64,64}-linux-gnu-gcc does not define __ppc__ or __ppc64__, but doe

Re: [PATCH] drm/doc: pull in drm_buddy.c

2022-03-08 Thread Matthew Auld
On 09/02/2022 07:32, Christian König wrote: Am 08.02.22 um 16:12 schrieb Matthew Auld: Make sure we pull in the kernel-doc for this. Reported-by: Daniel Vetter Signed-off-by: Matthew Auld Cc: Arunpravin Cc: Christian König Reviewed-by: Christian König Thanks. Could you also push this?

Re: [PATCH V3 05/13] drm: bridge: icn6211: Add DSI lane count DT property parsing

2022-03-08 Thread Maxime Ripard
On Tue, Mar 08, 2022 at 11:29:59AM +0100, Marek Vasut wrote: > On 3/8/22 11:07, Jagan Teki wrote: > > On Tue, Mar 8, 2022 at 3:19 PM Marek Vasut wrote: > > > > > > On 3/8/22 09:03, Jagan Teki wrote: > > > > > > Hi, > > > > > > [...] > > > > > > > > @@ -314,7 +321,9 @@ static const struct drm_b

Re: [PATCH v1 02/10] drm/msm/a6xx: Send NMI to gmu when it is hung

2022-03-08 Thread kernel test robot
Hi Akhil, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc7 next-20220308] [cannot apply to airlied/drm-next] [If

[PATCH v2 0/4] Ingenic DRM bridge_atomic_enable proposal

2022-03-08 Thread Christophe Branchereau
Hello, this is the v2 for my set of patches : - use dev_err_probe() instead of dev_err() in the newvision panel driver probe function - add bindings documentation for the Leadtek ltk035c5444t Cheers - Christophe Hello, this is a set of patches to allow the upstreaming

[PATCH v2 1/4] drm/ingenic : add ingenic_drm_bridge_atomic_enable

2022-03-08 Thread Christophe Branchereau
This allows the CRTC to be enabled after panels have slept out, and before their display is turned on, solving a graphical bug on the newvision nv3502c Signed-off-by: Christophe Branchereau --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 19 +-- 1 file changed, 13 insertions(+),

[PATCH v2 2/4] drm/panel: Add panel driver for NewVision NV3052C based LCDs

2022-03-08 Thread Christophe Branchereau
This driver supports the NewVision NV3052C based LCDs. Right now, it only supports the LeadTek LTK035C5444T 2.4" 640x480 TFT LCD panel, which can be found in the Anbernic RG-350M handheld console. Signed-off-by: Christophe Branchereau --- drivers/gpu/drm/panel/Kconfig | 9 + dr

[PATCH v2 3/4] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable

2022-03-08 Thread Christophe Branchereau
Following the introduction of bridge_atomic_enable in the ingenic drm driver, the crtc is enabled between .prepare and .enable, if it exists. Add it so the backlight is only enabled after the crtc is, to avoid graphical issues. Signed-off-by: Christophe Branchereau --- drivers/gpu/drm/panel/pan

[PATCH v2 4/4] dt-bindings: display/panel: Add Leadtek ltk035c5444t

2022-03-08 Thread Christophe Branchereau
Add binding for the leadtek ltk035c5444t, which is a 640x480 mipi-dbi over spi / 24-bit RGB panel based on the newvision NV03052C chipset. It is found in the Anbernic RG350M mips handheld. Signed-off-by: Christophe Branchereau --- .../panel/leadtek,ltk035c5444t-spi.yaml | 59 +

Re: [PATCH] drm/doc: pull in drm_buddy.c

2022-03-08 Thread Christian König
Am 08.03.22 um 13:51 schrieb Matthew Auld: On 09/02/2022 07:32, Christian König wrote: Am 08.02.22 um 16:12 schrieb Matthew Auld: Make sure we pull in the kernel-doc for this. Reported-by: Daniel Vetter Signed-off-by: Matthew Auld Cc: Arunpravin Cc: Christian König Reviewed-by: Christian

[PATCH v1 0/5] Add memory shrinker to VirtIO-GPU DRM driver

2022-03-08 Thread Dmitry Osipenko
Hello, This patchset introduces memory shrinker for the VirtIO-GPU DRM driver. During OOM, the shrinker will release BOs that are marked as "not needed" by userspace using the new madvise IOCTL. The userspace in this case is the Mesa VirGL driver, it will mark the cached BOs as "not needed", allow

[PATCH v1 1/5] drm/virtio: Correct drm_gem_shmem_get_sg_table() error handling

2022-03-08 Thread Dmitry Osipenko
drm_gem_shmem_get_sg_table() never ever returned NULL on error. Correct the error handling to avoid crash on OOM. Cc: sta...@vger.kernel.org Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/virtio/virtgpu_object.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH v1 2/5] drm/virtio: Check whether transferred 2D BO is shmem

2022-03-08 Thread Dmitry Osipenko
Transferred 2D BO always must be a shmem BO. Add check for that to prevent NULL dereference if userspace passes a VRAM BO. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/virtio/virtgpu_vq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.

[PATCH v1 3/5] drm/virtio: Unlock GEM reservations in error code path

2022-03-08 Thread Dmitry Osipenko
Unlock reservations in the error code path of virtio_gpu_object_create() to silence debug warning splat produced by ww_mutex_destroy(&obj->lock) when GEM is released with the held lock. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/virtio/virtgpu_object.c | 2 ++ 1 file changed, 2 insertion

[PATCH v1 5/5] drm/virtio: Add memory shrinker

2022-03-08 Thread Dmitry Osipenko
Add memory shrinker and new madvise IOCTL to the VirtIO-GPU driver. Userspace (BO cache manager of Mesa driver) will mark BOs as "don't need" using the new IOCTL to let shrinker purge the marked BOs on OOM, thus shrinker will lower memory pressure and prevent OOM kills. Signed-off-by: Daniel Almei

[PATCH v1 4/5] drm/virtio: Improve DMA API usage for shmem BOs

2022-03-08 Thread Dmitry Osipenko
DRM API requires the DRM's driver to be backed with the device that can be used for generic DMA operations. The VirtIO-GPU device can't perform DMA operations if it uses PCI transport because PCI device driver creates a virtual VirtIO-GPU device that isn't associated with the PCI. Use PCI's GPU dev

Re: [PATCH V3 05/13] drm: bridge: icn6211: Add DSI lane count DT property parsing

2022-03-08 Thread Marek Vasut
On 3/8/22 13:51, Maxime Ripard wrote: On Tue, Mar 08, 2022 at 11:29:59AM +0100, Marek Vasut wrote: On 3/8/22 11:07, Jagan Teki wrote: On Tue, Mar 8, 2022 at 3:19 PM Marek Vasut wrote: On 3/8/22 09:03, Jagan Teki wrote: Hi, [...] @@ -314,7 +321,9 @@ static const struct drm_bridge_funcs ch

[PATCH v1] drm/shmem-helper: Correct doc-comment of drm_gem_shmem_get_sg_table()

2022-03-08 Thread Dmitry Osipenko
drm_gem_shmem_get_sg_table() never returns NULL on error, but a ERR_PTR. Correct the doc comment which says that it returns NULL on error. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

Re: [RESEND v13 07/22] soc: mediatek: mmsys: specify 64BIT dependency for MTK_MMSYS

2022-03-08 Thread AngeloGioacchino Del Regno
Il 08/03/22 10:30, Nancy.Lin ha scritto: Because mtk-mutex change to use unsigned long mutex module type, it should depend 64BIT. This is a preparation for adding support for mt8195 vdosys1 mutex. Signed-off-by: Nancy.Lin --- drivers/soc/mediatek/Kconfig | 1 + 1 file changed, 1 insertion(+)

Re: [RESEND v13 22/22] arm64: dts: mt8195: add display node for vdosys1

2022-03-08 Thread AngeloGioacchino Del Regno
Il 08/03/22 10:30, Nancy.Lin ha scritto: Add display node for vdosys1. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno --- arch/arm64/boot/dts/mediatek/mt8195.dtsi | 223 +++ 1 file changed, 223 insertions(+)

Re: [RESEND v13 01/22] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-03-08 Thread AngeloGioacchino Del Regno
Il 08/03/22 10:29, Nancy.Lin ha scritto: Add vdosys1 RDMA definition. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno --- .../arm/mediatek/mediatek,mdp-rdma.yaml | 86 +++ 1 file changed, 86 insertions(+) create mode 100644 Documentation/device

Re: [PATCH] drm: remove min_order BUG_ON check

2022-03-08 Thread Arunpravin
On 07/03/22 10:11 pm, Matthew Auld wrote: > On 07/03/2022 14:37, Arunpravin wrote: >> place BUG_ON(order < min_order) outside do..while >> loop as it fails Unigine Heaven benchmark. >> >> Unigine Heaven has buffer allocation requests for >> example required pages are 161 and alignment request >>

Re: [PATCH V3 05/13] drm: bridge: icn6211: Add DSI lane count DT property parsing

2022-03-08 Thread Maxime Ripard
On Tue, Mar 08, 2022 at 02:27:40PM +0100, Marek Vasut wrote: > On 3/8/22 13:51, Maxime Ripard wrote: > > On Tue, Mar 08, 2022 at 11:29:59AM +0100, Marek Vasut wrote: > > > On 3/8/22 11:07, Jagan Teki wrote: > > > > On Tue, Mar 8, 2022 at 3:19 PM Marek Vasut wrote: > > > > > > > > > > On 3/8/22 09

Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: Revert DPI support

2022-03-08 Thread Rob Herring
On Tue, Mar 8, 2022 at 3:49 AM Robert Foss wrote: > > Revert DPI support from binding. > > DPI support relies on the bus-type enum which does not yet support > Mipi DPI, since no v4l2_fwnode_bus_type has been defined for this > bus type. > > When DPI for anx7625 was initially added, it assumed tha

Re: [PATCH 2/9] fbdev: Put mmap for deferred I/O into drivers

2022-03-08 Thread Javier Martinez Canillas
On 3/3/22 21:58, Thomas Zimmermann wrote: > The fbdev mmap function fb_mmap() unconditionally overrides the > driver's implementation if deferred I/O has been activated. This > makes it hard to implement mmap with anything but a vmalloc()'ed > software buffer. That is specifically a problem for DRM

Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver

2022-03-08 Thread Daniel Stone
On Tue, 8 Mar 2022 at 08:42, Andy Yan wrote: > On 3/7/22 21:09, Daniel Stone wrote: > > On Mon, 7 Mar 2022 at 12:18, Andy Yan wrote: > >> When run a weston 10.0.0: > >> > >># export XDG_RUNTIME_DIR=/tmp > >># weston --backend=drm-backend.so --use-pixma --tty=2 > >> --continue=without-inpu

Re: [PATCH v2 2/4] drm/bridge: ti-sn65dsi86: Make connector creation optional

2022-03-08 Thread Kieran Bingham
Hi Doug, Quoting Doug Anderson (2022-03-07 23:21:28) > Hi, > > On Mon, Mar 7, 2022 at 10:00 AM Kieran Bingham > wrote: > > > > From: Laurent Pinchart > > > > Now that the driver supports the connector-related bridge operations, > > make the connector creation optional. This enables usage of the

Re: Writeback Assumptions for XRGB

2022-03-08 Thread Maxime Ripard
Hi! On Tue, Mar 08, 2022 at 10:26:24AM +0200, Pekka Paalanen wrote: > On Fri, 4 Mar 2022 15:46:07 +0100 > Maxime Ripard wrote: > > > Indeed, while the input buffer uses 0xff for the X component, we'll get > > back 0x00 from the hardware, and thus the hashes are not identical. We > > can force th

Re: [PATCH] drm: remove min_order BUG_ON check

2022-03-08 Thread Arunpravin
On 07/03/22 9:23 pm, Christian König wrote: > Am 07.03.22 um 15:37 schrieb Arunpravin: >> place BUG_ON(order < min_order) outside do..while >> loop as it fails Unigine Heaven benchmark. >> >> Unigine Heaven has buffer allocation requests for >> example required pages are 161 and alignment reques

Re: [PATCH v2 2/2] Revert "arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint"

2022-03-08 Thread Matthias Brugger
On 08/03/2022 10:49, Robert Foss wrote: This reverts commit 32568ae37596b529628ac09b875f4874e614f63f. Signed-off-by: Robert Foss Reviewed-by: Chen-Yu Tsai Reviewed-by: Laurent Pinchart Acked-by: Matthias Brugger --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 -- 1 f

[Bug 215669] [drm:gfx_v10_0_priv_reg_irq [amdgpu]] *ERROR* Illegal register access in command stream

2022-03-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215669 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [Intel-gfx] [PATCH] drm: remove min_order BUG_ON check

2022-03-08 Thread Arunpravin
On 07/03/22 8:15 pm, Jani Nikula wrote: > On Mon, 07 Mar 2022, Arunpravin wrote: >> place BUG_ON(order < min_order) outside do..while >> loop as it fails Unigine Heaven benchmark. >> >> Unigine Heaven has buffer allocation requests for >> example required pages are 161 and alignment request >>

RE: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-08 Thread Kandpal, Suraj
Hi Abhinav, > > Hi, > >>> Hi, > > Hi Abhinav, > >> Hi Laurent > >> > >> Ok sure, I can take this up but I need to understand the proposal > >> a little bit more before proceeding on this. So we will discuss > >> this in another email where we specifically talk about the > >>

Re: [PATCH 3/9] fbdev: Track deferred-I/O pages in pageref struct

2022-03-08 Thread Javier Martinez Canillas
On 3/3/22 21:58, Thomas Zimmermann wrote: > Store the per-page state for fbdev's deferred I/O in struct > fb_deferred_io_pageref. Maintain a list of pagerefs for the pages > that have to be flushed out to video memory. Update all affected > drivers. > > Like with pages before, fbdev acquires a pag

Re: [PATCH V3 05/13] drm: bridge: icn6211: Add DSI lane count DT property parsing

2022-03-08 Thread Marek Vasut
On 3/8/22 14:49, Maxime Ripard wrote: On Tue, Mar 08, 2022 at 02:27:40PM +0100, Marek Vasut wrote: On 3/8/22 13:51, Maxime Ripard wrote: On Tue, Mar 08, 2022 at 11:29:59AM +0100, Marek Vasut wrote: On 3/8/22 11:07, Jagan Teki wrote: On Tue, Mar 8, 2022 at 3:19 PM Marek Vasut wrote: On 3/8/

[PATCH 2/2] drm/amdkfd: CRIU Refactor restore BO function

2022-03-08 Thread David Yat Sin
Refactor CRIU restore BO to reduce identation before adding support for IPC. Signed-off-by: David Yat Sin --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 271 +++ 1 file changed, 129 insertions(+), 142 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/driv

[PATCH 1/2] drm/amdkfd: CRIU remove sync and TLB flush on restore

2022-03-08 Thread David Yat Sin
When the process is getting restored, the queues are not mapped yet, so there is no VMID assigned for this process and no TLBs to flush. Signed-off-by: David Yat Sin Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 30 +--- 1 file changed, 1 inserti

Re: [PATCH 2/2] drm/amdkfd: CRIU Refactor restore BO function

2022-03-08 Thread Felix Kuehling
Am 2022-03-08 um 10:28 schrieb David Yat Sin: Refactor CRIU restore BO to reduce identation before adding support for IPC. Update the commit message. There is no IPC support on the public branch. The refactoring is still welcome to improve the readability and maintainability of the code. With

Re: Mandatory Test Suite for KMS Drivers?

2022-03-08 Thread Maxime Ripard
Hi Rodrigo, On Thu, Mar 03, 2022 at 05:52:57AM -0500, Rodrigo Vivi wrote: > On Thu, Mar 03, 2022 at 10:05:07AM +0100, Maxime Ripard wrote: > > Hi, > > > > Back at XDC we floated the idea of creating a test suite for IGT that we > > expect any KMS driver to pass, similar to what v4l2-compliance an

Re: [igt-dev] Mandatory Test Suite for KMS Drivers?

2022-03-08 Thread Maxime Ripard
Hi Daniel, On Fri, Mar 04, 2022 at 08:45:07AM +, Daniel Stone wrote: > On Thu, 3 Mar 2022 at 10:53, Rodrigo Vivi wrote: > > On Thu, Mar 03, 2022 at 10:05:07AM +0100, Maxime Ripard wrote: > > > Back at XDC we floated the idea of creating a test suite for IGT that we > > > expect any KMS driver

Re: [PATCH v1 5/5] drm/virtio: Add memory shrinker

2022-03-08 Thread Dmitry Osipenko
On 3/8/22 16:17, Dmitry Osipenko wrote: > @@ -246,20 +246,28 @@ static int virtio_gpu_plane_prepare_fb(struct drm_plane > *plane, > struct virtio_gpu_device *vgdev = dev->dev_private; > struct virtio_gpu_framebuffer *vgfb; > struct virtio_gpu_object *bo; > + int err; > >

[PATCH 1/2] drm: ssd130x: Fix COM scan direction register mask

2022-03-08 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The SSD130x's command to toggle COM scan direction uses bit 3 and only bit 3 to set the direction of the scanout. The driver has an incorrect GENMASK(3, 2), causing the setting to be set on bit 2, rendering it ineffective. Fix the mask to only bit 3, so that the requested sett

[PATCH 2/2] drm: ssd130x: Always apply segment remap setting

2022-03-08 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Currently the ssd130x driver only sets the segment remap setting when the device tree requests it; it however does not clear the setting if it is not requested. This leads to the setting incorrectly persisting if the hardware is always on and has no reset GPIO wired. This might

Re: [PATCH 0/3] Fix MediaTek display dt-bindings issues

2022-03-08 Thread Rob Herring
On Fri, Mar 4, 2022 at 5:49 PM Chun-Kuang Hu wrote: > > Hi, Rob: > > Would you like to take this series into your tree, or I take this > series into my tree? I can't. I don't have the broken commits in my tree. Rob

Re: [PATCH v6 2/6] drm/format-helper: Add drm_fb_xrgb8888_to_mono_reversed()

2022-03-08 Thread Geert Uytterhoeven
Hi Javier, On Mon, Feb 14, 2022 at 2:37 PM Javier Martinez Canillas wrote: > Add support to convert from XR24 to reversed monochrome for drivers that > control monochromatic display panels, that only have 1 bit per pixel. > > The function does a line-by-line conversion doing an intermediate step

Re: [PATCH V3 05/13] drm: bridge: icn6211: Add DSI lane count DT property parsing

2022-03-08 Thread Maxime Ripard
On Tue, Mar 08, 2022 at 03:47:22PM +0100, Marek Vasut wrote: > On 3/8/22 14:49, Maxime Ripard wrote: > > On Tue, Mar 08, 2022 at 02:27:40PM +0100, Marek Vasut wrote: > > > On 3/8/22 13:51, Maxime Ripard wrote: > > > > On Tue, Mar 08, 2022 at 11:29:59AM +0100, Marek Vasut wrote: > > > > > On 3/8/22

Re: [PATCH v1 0/5] Add memory shrinker to VirtIO-GPU DRM driver

2022-03-08 Thread Rob Clark
On Tue, Mar 8, 2022 at 5:17 AM Dmitry Osipenko wrote: > > Hello, > > This patchset introduces memory shrinker for the VirtIO-GPU DRM driver. > During OOM, the shrinker will release BOs that are marked as "not needed" > by userspace using the new madvise IOCTL. The userspace in this case is > the M

Re: [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-03-08 Thread Geert Uytterhoeven
Hi Javier, On Mon, Feb 14, 2022 at 2:37 PM Javier Martinez Canillas wrote: > This adds a DRM driver for SSD1305, SSD1306, SSD1307 and SSD1309 Solomon > OLED display controllers. > > It's only the core part of the driver and a bus specific driver is needed > for each transport interface supported

[PATCH] drm/i915/guc: Use iosys_map interface to update lrc_desc

2022-03-08 Thread Balasubramani Vivekanandan
This patch is continuation of the effort to move all pointers in i915, which at any point may be pointing to device memory or system memory, to iosys_map interface. More details about the need of this change is explained in the patch series which initiated this task https://patchwork.freedesktop.or

[PATCH v5 1/5] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk

2022-03-08 Thread Vinod Polimera
Kernel clock driver assumes that initial rate is the max rate for that clock and was not allowing it to scale beyond the assigned clock value. Drop the assigned clock rate property and vote on the mdp clock as per calculated value during the usecase. Changes in v2: - Remove assigned-clock-rate pr

[PATCH v5 5/5] drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table during probe

2022-03-08 Thread Vinod Polimera
use max clock during probe/bind sequence from the opp table. The clock will be scaled down when framework sends an update. Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/d

[PATCH v5 4/5] arm64/dts/qcom/sm8250: remove assigned-clock-rate property for mdp clk

2022-03-08 Thread Vinod Polimera
Kernel clock driver assumes that initial rate is the max rate for that clock and was not allowing it to scale beyond the assigned clock value. Drop the assigned clock rate property and vote on the mdp clock as per calculated value during the usecase. Fixes: 7c1dffd471("arm64: dts: qcom: sm8250.dt

[PATCH v5 3/5] arm64/dts/qcom/sdm845: remove assigned-clock-rate property for mdp clk

2022-03-08 Thread Vinod Polimera
Kernel clock driver assumes that initial rate is the max rate for that clock and was not allowing it to scale beyond the assigned clock value. Drop the assigned clock rate property and vote on the mdp clock as per calculated value during the usecase. Fixes: 08c2a076d1("arm64: dts: qcom: sdm845: A

[PATCH v5 2/5] arm64/dts/qcom/sc7180: remove assigned-clock-rate property for mdp clk

2022-03-08 Thread Vinod Polimera
Kernel clock driver assumes that initial rate is the max rate for that clock and was not allowing it to scale beyond the assigned clock value. Drop the assigned clock rate property and vote on the mdp clock as per calculated value during the usecase. Fixes: a3db7ad1af("arm64: dts: qcom: sc7180: a

[PATCH v5 0/5] Update mdp clk to max supported value to support higher refresh rates

2022-03-08 Thread Vinod Polimera
Kernel clock driver assumes that initial rate is the max rate for that clock and was not allowing it to scale beyond the assigned clock value. Drop the assigned clock rate property and vote on the mdp clock as per calculated value during the usecase. Changes in v2: - Remove assigned-clock-rate pr

Re: [PATCH] drm: remove min_order BUG_ON check

2022-03-08 Thread Matthew Auld
On 08/03/2022 13:59, Arunpravin wrote: On 07/03/22 10:11 pm, Matthew Auld wrote: On 07/03/2022 14:37, Arunpravin wrote: place BUG_ON(order < min_order) outside do..while loop as it fails Unigine Heaven benchmark. Unigine Heaven has buffer allocation requests for example required pages are 16

Re: [PATCH v5 5/5] drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table during probe

2022-03-08 Thread Dmitry Baryshkov
On Tue, 8 Mar 2022 at 19:55, Vinod Polimera wrote: > > use max clock during probe/bind sequence from the opp table. > The clock will be scaled down when framework sends an update. > > Signed-off-by: Vinod Polimera > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 +++ > 1 file changed, 3 inser

[PATCH] drm/mgag200: Fix PLL setup for g200wb and g200ew

2022-03-08 Thread Jocelyn Falempe
commit f86c3ed55920ca1d874758cc290890902a6cffc4 ("drm/mgag200: Split PLL setup into compute and update functions") introduced a regression for g200wb and g200ew. The PLLs are not set up properly, and VGA screen stays black, or displays "out of range" message. MGA1064_WB_PIX_PLLC_N/M/P was mistaken

Re: [PATCH 4/9] fbdev: Export helper for implementing page_mkwrite

2022-03-08 Thread Javier Martinez Canillas
On 3/3/22 21:58, Thomas Zimmermann wrote: > Refactor the page-write handler and export it as helper function > fb_deferred_io_page_mkwrite(). Drivers that implement struct > vm_operations_struct.page_mkwrite for deferred I/O should use the > function to let fbdev track written pages of mmap'ed fram

Re: [PATCH 5/9] drm/fb-helper: Separate deferred I/O from shadow buffers

2022-03-08 Thread Javier Martinez Canillas
On 3/3/22 21:58, Thomas Zimmermann wrote: > DRM drivers will be able to handle deferred I/O by themselves. So > a driver will be able to use deferred I/O without an intermediate > shadow buffer. > > Prepare fbdev emulation by separating shadow buffers and deferred > I/O from each other. > > Signe

Re: [PATCH] drm/mgag200: Fix PLL setup for g200wb and g200ew

2022-03-08 Thread Greg KH
On Tue, Mar 08, 2022 at 06:11:11PM +0100, Jocelyn Falempe wrote: > commit f86c3ed55920ca1d874758cc290890902a6cffc4 ("drm/mgag200: Split PLL > setup into compute and update functions") introduced a regression for > g200wb and g200ew. No need for all those digits in the sha1, see below: > The PLLs

Re: [PATCH] drm/mgag200: Fix PLL setup for g200wb and g200ew

2022-03-08 Thread Jocelyn Falempe
On 08/03/2022 18:31, Greg KH wrote: On Tue, Mar 08, 2022 at 06:11:11PM +0100, Jocelyn Falempe wrote: commit f86c3ed55920ca1d874758cc290890902a6cffc4 ("drm/mgag200: Split PLL setup into compute and update functions") introduced a regression for g200wb and g200ew. No need for all those digits in

[PATCH v2] drm/mgag200: Fix PLL setup for g200wb and g200ew

2022-03-08 Thread Jocelyn Falempe
commit f86c3ed55920 ("drm/mgag200: Split PLL setup into compute and update functions") introduced a regression for g200wb and g200ew. The PLLs are not set up properly, and VGA screen stays black, or displays "out of range" message. MGA1064_WB_PIX_PLLC_N/M/P was mistakenly replaced with MGA1064_PI

Re: [PATCH 6/9] drm/fb-helper: Provide callback to create fbdev dumb buffers

2022-03-08 Thread Javier Martinez Canillas
On 3/3/22 21:58, Thomas Zimmermann wrote: > Provide struct drm_driver.dumb_create_fbdev, a callback hook for > fbdev dumb buffers. Wire up fbdev and client helpers to use the new > interface, if present. > > This acknowledges the fact that fbdev buffers are different. The most > significant differ

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/gem: Remove logic for wbinvd_on_all_cpus

2022-03-08 Thread Lucas De Marchi
On Tue, Feb 22, 2022 at 08:24:31PM +0100, Thomas Hellström (Intel) wrote: Hi, Michael, On 2/22/22 18:26, Michael Cheng wrote: This patch removes logic for wbinvd_on_all_cpus and brings in drm_cache.h. This header has the logic that outputs a warning when wbinvd_on_all_cpus when its being used o

Re: [Intel-gfx] [PATCH] drm/i915/xehp: Drop aux table invalidation on FlatCCS platforms

2022-03-08 Thread Lucas De Marchi
On Mon, Feb 28, 2022 at 09:29:52PM -0800, Matt Roper wrote: Platforms with FlatCCS do not use auxiliary planes for compression control data and thus do not need traditional aux table invalidation (and the registers no longer even exist). Original-author: CQ Tang Signed-off-by: Matt Roper --- dr

[PATCH] drm/msm/gpu: Fix crash on devices without devfreq support (v2)

2022-03-08 Thread Rob Clark
From: Rob Clark Avoid going down devfreq paths on devices where devfreq is not initialized. v2: Change has_devfreq() logic [Dmitry] Reported-by: Linux Kernel Functional Testing Reported-by: Anders Roxell Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu_devfreq.c | 30 +++

Re: [PATCH] drm/msm/gpu: Fix crash on devices without devfreq support (v2)

2022-03-08 Thread Fabio Estevam
On Tue, Mar 8, 2022 at 3:48 PM Rob Clark wrote: > > From: Rob Clark > > Avoid going down devfreq paths on devices where devfreq is not > initialized. > > v2: Change has_devfreq() logic [Dmitry] > > Reported-by: Linux Kernel Functional Testing > Reported-by: Anders Roxell > Signed-off-by: Rob Cl

RE: [RFC 18/28] drm: rcar-du: Add RZ/G2L LCDC Support

2022-03-08 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [RFC 18/28] drm: rcar-du: Add RZ/G2L LCDC Support > > Hi Biju, > > Thank you for the patch. > > On Wed, Jan 12, 2022 at 05:46:02PM +, Biju Das wrote: > > The LCD controller is composed of Frame Compression Processor (FCPVD), > > Video Sig

Re: [PATCH 7/9] drm/fb-helper: Provide fbdev deferred-I/O helpers

2022-03-08 Thread Javier Martinez Canillas
On 3/3/22 21:58, Thomas Zimmermann wrote: > Add drm_fb_helper_vm_page_mkwrite(), a helper to track pages written > by fbdev userspace. DRM drivers should use this function to implement > fbdev deferred I/O. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Be

Re: [PATCH] drm/msm/gpu: Fix crash on devices without devfreq support (v2)

2022-03-08 Thread Rob Clark
On Tue, Mar 8, 2022 at 10:53 AM Fabio Estevam wrote: > > On Tue, Mar 8, 2022 at 3:48 PM Rob Clark wrote: > > > > From: Rob Clark > > > > Avoid going down devfreq paths on devices where devfreq is not > > initialized. > > > > v2: Change has_devfreq() logic [Dmitry] > > > > Reported-by: Linux Kern

[PATCH 1/3] drm/bridge: Add MAINTAINERS entry for DRM drivers for bridge chip bindings

2022-03-08 Thread Douglas Anderson
The bindings for bridge chips should also get the same maintainers entry so the right people get notified about bindings changes. Signed-off-by: Douglas Anderson --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0216d2ffe728..a73179d55d00 100644

[PATCH 2/3] drm/bridge: Add myself as a reviewer for the TI SN65DSI86 bridge chip

2022-03-08 Thread Douglas Anderson
I've spent quite a bit of time poking at this driver and it's used on several Chromebooks I'm involved with. I'd like to get notified about patches. Add myself as a reviewer. It's expected that changes will still be landed through drm-misc as they always have been. Signed-off-by: Douglas Anderson

[PATCH 3/3] drm/bridge: Add myself as a reviewer for the Parade PS8640 bridge chip

2022-03-08 Thread Douglas Anderson
Though the parade bridge chip is a little bit of a black box, I'm at least interested in hearing about changes to the driver since this bridge chip is used on some Chromebooks that I'm involved with. Signed-off-by: Douglas Anderson --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) dif

[PATCH] drm/amdkfd: CRIU export dmabuf handles for GTT BOs

2022-03-08 Thread David Yat Sin
Export dmabuf handles for GTT BOs so that their contents can be accessed using SDMA during checkpoint/restore. Signed-off-by: David Yat Sin --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd

Re: [PATCH v1 0/5] Add memory shrinker to VirtIO-GPU DRM driver

2022-03-08 Thread Dmitry Osipenko
On 3/8/22 19:29, Rob Clark wrote: > On Tue, Mar 8, 2022 at 5:17 AM Dmitry Osipenko > wrote: >> >> Hello, >> >> This patchset introduces memory shrinker for the VirtIO-GPU DRM driver. >> During OOM, the shrinker will release BOs that are marked as "not needed" >> by userspace using the new madvise

Re: [PATCH 8/9] drm/gem-shmem: Implement fbdev dumb buffer and mmap helpers

2022-03-08 Thread Javier Martinez Canillas
On 3/3/22 21:58, Thomas Zimmermann wrote: > Implement struct drm_driver.dumb_create_fbdev for GEM SHMEM. The > created buffer object returned by this function implements deferred > I/O for its mmap operation. > > Add this feature to a number of drivers that use GEM SHMEM helpers > as shadow planes

Re: [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml

2022-03-08 Thread Rob Herring
On Tue, Mar 1, 2022 at 6:14 PM Dmitry Baryshkov wrote: > > Add missing brace in dpu-qcm2290.yaml. While we are at it, also fix > indentation for another brace, so it matches the corresponding line. > > Reported-by: Rob Herring > Cc: Loic Poulain > Reviewed-by: Bjorn Andersson > Signed-off-by: D

Re: [PATCH 9/9] drm/virtio: Implement dumb_create_fbdev with GEM SHMEM helpers

2022-03-08 Thread Javier Martinez Canillas
On 3/3/22 21:58, Thomas Zimmermann wrote: > Implement struct drm_driver.dumb_create_fbdev with the helpers > provided by GEM SHMEM. Fbdev deferred I/O will now work without > an intermediate shadow buffer for mmap. > > As the virtio driver replaces several of the regular GEM SHMEM > functions with

Re: [PATCH 06/10] drm/gma500: Move GTT resume logic out of psb_gtt_init()

2022-03-08 Thread Thomas Zimmermann
Hi Am 08.03.22 um 13:07 schrieb Patrik Jakobsson: On Tue, Mar 8, 2022 at 9:48 AM Thomas Zimmermann wrote: Hi Sam and Patrik Am 07.03.22 um 22:02 schrieb Patrik Jakobsson: On Mon, Mar 7, 2022 at 8:07 PM Sam Ravnborg wrote: Hi Thomas, One comment below. On Sun, Mar 06, 2022 at 09:36:15PM

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-08 Thread Abhinav Kumar
Hi Suraj On 3/8/2022 6:30 AM, Kandpal, Suraj wrote: Hi Abhinav, Hi, Hi, Hi Abhinav, Hi Laurent Ok sure, I can take this up but I need to understand the proposal a little bit more before proceeding on this. So we will discuss this in another email where we specifically talk about the connec

[PATCH v2 00/12] drm/gma500: Various cleanups to GEM code

2022-03-08 Thread Thomas Zimmermann
Refactor and simplify various parts of the memory management. This includes locking, initialization and finalizer functions, and code organization. Tested on Atom N2800 hardware. v2: * put common code in psb_gtt_{init,fini,resume}() into helpers (Sam, Patrik) Thomas Zimmermann

[PATCH v2 05/12] drm/gma500: Move GTT setup and restoration into helper funtions

2022-03-08 Thread Thomas Zimmermann
The GTT init and restore functions contain logic to populate the GTT entries. Move the code into helper functions. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gtt.c | 115 +-- 1 file changed, 68 insertions(+), 47 deletio

[PATCH v2 06/12] drm/gma500: Move GTT resume logic out of psb_gtt_init()

2022-03-08 Thread Thomas Zimmermann
The current implementation of psb_gtt_init() also does resume handling. Move the resume code into its own helper. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gtt.c | 122 ++- drivers/gpu/drm/gma500/gtt.h | 2 +- dr

[PATCH v2 10/12] drm/gma500: Move GEM memory management functions to gem.c

2022-03-08 Thread Thomas Zimmermann
Move GEM functions from gtt.c to gem.c. Adapt some names. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gem.c | 133 +++ drivers/gpu/drm/gma500/gem.h | 12 +++ drivers/gpu/drm/gma500/gtt.c |

[PATCH v2 07/12] drm/gma500: Cleanup GTT uninit and error handling

2022-03-08 Thread Thomas Zimmermann
Replace psb_gtt_takedown() with finalizer function that is only called for unloading the driver. Use roll-back pattern for error handling in psb_gtt_init() and _resume(). Also fixes a bug where vmap_addr was never unmapped. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers

[PATCH v2 11/12] drm/gma500: Move GTT enable and disable code into helpers

2022-03-08 Thread Thomas Zimmermann
Move the code for enabling and disabling the GTT into helpers and call the functions in psb_gtt_init(), psb_gtt_fini() and psb_gtt_resume(). Removes code duplication. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/gtt.c | 81 1 file changed, 46 i

  1   2   3   >