Re: [PATCH 2/2] drm/i915: Remove the vm open count

2022-03-02 Thread Thomas Hellström
On Tue, 2022-03-01 at 19:45 -0800, Niranjana Vishwanathapura wrote: > On Tue, Feb 22, 2022 at 06:10:30PM +0100, Thomas Hellström wrote: > > vms are not getting properly closed. Rather than fixing that, > > Remove the vm open count and instead rely on the vm refcount. > > > > The vm open count exis

[v3 0/4] enhanced edid driver compatibility

2022-03-02 Thread Lee Shawn C
Support to parse multiple CEA extension blocks and HF-EEODB to extend drm edid driver's capability. Lee Shawn C (4): drm/edid: seek for available CEA block from specific EDID block index drm/edid: parse multiple CEA extension block drm/edid: read HF-EEODB ext block drm/edid: parse HF-EEODB

[v3 1/4] drm/edid: seek for available CEA block from specific EDID block index

2022-03-02 Thread Lee Shawn C
drm_find_cea_extension() always look for a top level CEA block. Pass ext_index from caller then this function to search next available CEA ext block from a specific EDID block pointer. Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Nautiyal Signed-off-by: Lee Shawn C --- drivers/gpu/drm/drm_edid

[v3 2/4] drm/edid: parse multiple CEA extension block

2022-03-02 Thread Lee Shawn C
Try to find and parse more CEA ext blocks if edid->extensions is greater than one. v2: split prvious patch to two. And do CEA block parsing in this one. v3: simplify this patch based on previous change. Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Nautiyal Signed-off-by: Lee Shawn C --- d

[v3 3/4] drm/edid: read HF-EEODB ext block

2022-03-02 Thread Lee Shawn C
According to HDMI 2.1 spec. "The HDMI Forum EDID Extension Override Data Block (HF-EEODB) is utilized by Sink Devices to provide an alternate method to indicate an EDID Extension Block count larger than 1, while avoiding the need to present a VESA Block Map in the first E-EDID Extension Block." I

[v3 4/4] drm/edid: parse HF-EEODB CEA extension block

2022-03-02 Thread Lee Shawn C
While adding CEA modes, try to get available EEODB block number. Then based on it to parse numbers of ext blocks, retrieve CEA information and add more CEA modes. Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Nautiyal Signed-off-by: Lee Shawn C --- drivers/gpu/drm/drm_displayid.c | 5 - dr

RE: [EXT] Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-02 Thread Robby Cai
>-Original Message- >From: Lucas Stach >Sent: 2022年3月1日 21:19 >To: Adam Ford >Cc: Marek Vasut ; Ying Liu (OSS) ; >dri-devel ; devicetree >; Peng Fan ; Alexander Stein >; Rob Herring ; >Laurent Pinchart ; Sam Ravnborg >; Robby Cai >Subject: [EXT] Re: [PATCH 1/9] dt-bindings: mxsfb: Add

[PATCH] video: fbdev: s3c-fb: fix platform_get_irq.cocci warning

2022-03-02 Thread Yihao Han
Remove dev_err() messages after platform_get_irq*() failures. platform_get_irq() already prints an error. Generated by: scripts/coccinelle/api/platform_get_irq.cocci Signed-off-by: Yihao Han --- drivers/video/fbdev/s3c-fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/

Re: [PATCH] drm/exynos: fimd: add BGR support for exynos4/5

2022-03-02 Thread Martin Jücker
Hi Inki, On Tue, Mar 01, 2022 at 04:52:20PM +0900, Inki Dae wrote: > Hi Martin, > > 22. 2. 25. 18:33에 Martin Jücker 이(가) 쓴 글: > > Hello Inki, > > > > On Fri, Feb 25, 2022 at 12:52:56PM +0900, Inki Dae wrote: > >> Hi Martin, > >> > >> 22. 2. 25. 08:27에 Martin Jücker 이(가) 쓴 글: > >>> Hello Inki, >

Re: [PATCH v3 00/21] DEPT(Dependency Tracker)

2022-03-02 Thread Hyeonggon Yoo
On Mon, Feb 28, 2022 at 06:56:39PM +0900, Byungchul Park wrote: > I didn't want to bother you so I was planning to send the next spin > after making more progress. However, PATCH v2 reports too many false > positives because Dept tracked the bit_wait_table[] wrong way - I > apologize for that. So I

Re: [PATCH v3 00/21] DEPT(Dependency Tracker)

2022-03-02 Thread Hyeonggon Yoo
On Wed, Mar 02, 2022 at 04:36:38AM +, Hyeonggon Yoo wrote: > On Mon, Feb 28, 2022 at 06:56:39PM +0900, Byungchul Park wrote: > > I didn't want to bother you so I was planning to send the next spin > > after making more progress. However, PATCH v2 reports too many false > > positives because Dep

Re: [PATCH 5/5] spi: make remove callback a void function

2022-03-02 Thread Pavel Machek
Hi! > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that

[PATCH] drm/sprd: fix platform_get_irq.cocci warning

2022-03-02 Thread Yihao Han
Remove dev_err() messages after platform_get_irq*() failures. platform_get_irq() already prints an error. Generated by: scripts/coccinelle/api/platform_get_irq.cocci Signed-off-by: Yihao Han --- drivers/gpu/drm/sprd/sprd_dpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [PATCH v7, 04/15] media: mtk-vcodec: Read max resolution from dec_capability

2022-03-02 Thread Przemysław Drozdowski

MSM8960: gpu/drm/dp/drm_dp.c:59:27: warning: array subscript 10 is outside, array bounds of 'const u8[6]'

2022-03-02 Thread Rudraksha Gupta
Hi all, I am getting this warning when compiling the kernel for the MSM8960 with this defconfig: https://raw.githubusercontent.com/apq8064-mainline/linux/qcom-apq8064-next/arch/arm/configs/qcom_apq8064_defconfig Warning: ../drivers/gpu/drm/dp/drm_dp.c: In function 'drm_dp_get_adjust_reque

[Bug 215648] amdgpu: Changing monitor configuration (plug/unplug/wake from DPMS) causes kernel panic

2022-03-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215648 --- Comment #2 from Philipp Riederer (pr_ker...@tum.fail) --- Hey, this is the log I could recover: > <4>[ 70.829010] RSP: 0018:ad060ad67838 EFLAGS: 0202 > <4>[ 70.829013] RAX: RBX: 92c82ff28000 RCX: > 00

Re: [PATCH v1,2/3] drm/mediatek: Add TOPCKGEN select mux control dpi_clk

2022-03-02 Thread AngeloGioacchino Del Regno
Il 25/02/22 10:53, xinlei@mediatek.com ha scritto: From: Xinlei Lee Dpi_clk is controlled by the mux selected by TOPCKGEN and APMIXEDSYS can support small resolution. Signed-off-by: Xinlei Lee Hello Xinlei, as it was pointed out by reviewers in the MT8195 DisplayPort series, that is ad

Re: [PATCH] drm/panfrost: cleanup comments

2022-03-02 Thread Steven Price
On 01/03/2022 12:43, t...@redhat.com wrote: > From: Tom Rix > > For spdx > change tab to space delimiter > Use // for *.c > > Replacements > commited to committed, use multiline comment style > regsiters to registers > initialze to initialize > > Signed-off-by: Tom Rix Thanks, most of the cha

Re: linux-next: build failure after merge of the kspp tree

2022-03-02 Thread Stephen Rothwell
Hi Kees, On Mon, 28 Feb 2022 15:02:48 -0800 Kees Cook wrote: > > On Tue, Mar 01, 2022 at 09:27:30AM +1100, Stephen Rothwell wrote: > > > > After merging the kspp tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > drivers/gpu/drm/drm_dp_helper.c: In function 'drm_

Re: [Intel-gfx] [PATCH 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

2022-03-02 Thread Tvrtko Ursulin
On 01/03/2022 19:57, John Harrison wrote: On 3/1/2022 02:50, Tvrtko Ursulin wrote: On 28/02/2022 18:32, John Harrison wrote: On 2/28/2022 08:11, Tvrtko Ursulin wrote: On 25/02/2022 17:39, John Harrison wrote: On 2/25/2022 09:06, Tvrtko Ursulin wrote: On 24/02/2022 19:19, John Harrison wro

[v4 0/5] enhanced edid driver compatibility

2022-03-02 Thread Lee Shawn C
Support to parse multiple CEA extension blocks and HF-EEODB to extend drm edid driver's capability. v4: add one more patch to support HF-SCDB Lee Shawn C (5): drm/edid: seek for available CEA block from specific EDID block index drm/edid: parse multiple CEA extension block drm/edid: read HF

[v4 1/5] drm/edid: seek for available CEA block from specific EDID block index

2022-03-02 Thread Lee Shawn C
drm_find_cea_extension() always look for a top level CEA block. Pass ext_index from caller then this function to search next available CEA ext block from a specific EDID block pointer. Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Nautiyal Signed-off-by: Lee Shawn C --- drivers/gpu/drm/drm_edid

[v4 2/5] drm/edid: parse multiple CEA extension block

2022-03-02 Thread Lee Shawn C
Try to find and parse more CEA ext blocks if edid->extensions is greater than one. v2: split prvious patch to two. And do CEA block parsing in this one. v3: simplify this patch based on previous change. Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Nautiyal Signed-off-by: Lee Shawn C --- d

[v4 5/5] drm/edid: check for HF-SCDB block

2022-03-02 Thread Lee Shawn C
Find HF-SCDB information in CEA extensions block. And retrieve Max_TMDS_Character_Rate that support by sink device. Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Nautiyal Signed-off-by: Lee Shawn C --- drivers/gpu/drm/drm_edid.c | 36 1 file changed, 36 inse

[v4 4/5] drm/edid: parse HF-EEODB CEA extension block

2022-03-02 Thread Lee Shawn C
While adding CEA modes, try to get available EEODB block number. Then based on it to parse numbers of ext blocks, retrieve CEA information and add more CEA modes. Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Nautiyal Signed-off-by: Lee Shawn C --- drivers/gpu/drm/drm_displayid.c | 5 - dr

[v4 3/5] drm/edid: read HF-EEODB ext block

2022-03-02 Thread Lee Shawn C
According to HDMI 2.1 spec. "The HDMI Forum EDID Extension Override Data Block (HF-EEODB) is utilized by Sink Devices to provide an alternate method to indicate an EDID Extension Block count larger than 1, while avoiding the need to present a VESA Block Map in the first E-EDID Extension Block." I

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-02 Thread Lucas Stach
Am Mittwoch, dem 02.03.2022 um 03:54 +0100 schrieb Marek Vasut: > On 3/1/22 14:18, Lucas Stach wrote: > > Am Dienstag, dem 01.03.2022 um 07:03 -0600 schrieb Adam Ford: > > > On Tue, Mar 1, 2022 at 5:05 AM Lucas Stach wrote: > > > > > > > > Am Dienstag, dem 01.03.2022 um 11:19 +0100 schrieb Marek

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-02 Thread Rasmus Villemoes
On 02/03/2022 00.55, Linus Torvalds wrote: > On Tue, Mar 1, 2022 at 3:19 PM David Laight wrote: >> > With the "don't use iterator outside the loop" approach, the exact > same code works in both the old world order and the new world order, > and you don't have the semantic confusion. And *if* you

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-02 Thread Liu Ying
On Wed, 2022-03-02 at 10:23 +0100, Lucas Stach wrote: > Am Mittwoch, dem 02.03.2022 um 03:54 +0100 schrieb Marek Vasut: > > On 3/1/22 14:18, Lucas Stach wrote: > > > Am Dienstag, dem 01.03.2022 um 07:03 -0600 schrieb Adam Ford: > > > > On Tue, Mar 1, 2022 at 5:05 AM Lucas Stach > > > > wrote: > >

[PATCH] drm/xlnx: Handle error for dma_set_mask

2022-03-02 Thread Jiasheng Jiang
As the potential failure of the dma_set_mask(), it should be better to check it and return error if fails. Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem") Signed-off-by: Jiasheng Jiang --- drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 4 +++- 1 file changed, 3

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

2022-03-02 Thread Tvrtko Ursulin
On 25/02/2022 20:41, john.c.harri...@intel.com wrote: From: John Harrison GuC converts the pre-emption timeout and timeslice quantum values into clock ticks internally. That significantly reduces the point of 32bit overflow. On current platforms, worst case scenario is approximately 110 secon

Re: [PATCH V2 01/12] drm: bridge: icn6211: Fix register layout

2022-03-02 Thread Maxime Ripard
On Thu, Feb 17, 2022 at 01:25:19AM +0100, Marek Vasut wrote: > The chip register layout has nothing to do with MIPI DCS, the registers > incorrectly marked as MIPI DCS in the driver are regular chip registers > often with completely different function. > > Fill in the actual register names and bit

Re: [PATCH V2 02/12] drm: bridge: icn6211: Fix HFP_HSW_HBP_HI and HFP_MIN handling

2022-03-02 Thread Maxime Ripard
On Thu, Feb 17, 2022 at 01:25:20AM +0100, Marek Vasut wrote: > The HFP_HSW_HBP_HI register must be programmed with 2 LSbits of each > Horizontal Front Porch/Sync/Back Porch. Currently the driver programs > this register to 0, which breaks displays with either value above 255. > > The HFP_MIN regis

Re: [PATCH V2 03/12] drm: bridge: icn6211: Add HS/VS/DE polarity handling

2022-03-02 Thread Maxime Ripard
On Thu, Feb 17, 2022 at 01:25:21AM +0100, Marek Vasut wrote: > The driver currently hard-codes HS/VS polarity to active-low and DE to > active-high, which is not correct for a lot of supported DPI panels. > Add the missing mode flag handling for HS/VS/DE polarity. > > Signed-off-by: Marek Vasut >

Re: [PATCH V2 04/12] drm: bridge: icn6211: Add DSI lane count DT property parsing

2022-03-02 Thread Maxime Ripard
On Thu, Feb 17, 2022 at 01:25:22AM +0100, Marek Vasut wrote: > The driver currently hard-codes DSI lane count to two, however the chip > is capable of operating in 1..4 DSI lanes mode. Parse 'data-lanes' DT > property and program the result into DSI_CTRL register. > > Signed-off-by: Marek Vasut >

Re: [PATCH V2 05/12] drm: bridge: icn6211: Add generic DSI-to-DPI PLL configuration

2022-03-02 Thread Maxime Ripard
On Thu, Feb 17, 2022 at 01:25:23AM +0100, Marek Vasut wrote: > The chip contains fractional PLL, however the driver currently hard-codes > one specific PLL setting. Implement generic PLL parameter calculation code, > so any DPI panel with arbitrary pixel clock can be attached to this bridge. > > T

Re: [PATCH V2 06/12] drm: bridge: icn6211: Use DSI burst mode without EoT and with LP command mode

2022-03-02 Thread Maxime Ripard
On Thu, Feb 17, 2022 at 01:25:24AM +0100, Marek Vasut wrote: > The DSI burst mode is more energy efficient than the DSI sync pulse mode, > make use of the burst mode since the chip supports it as well. Disable the > generation of EoT packet, the chip ignores it, so no point in emitting it. > Enable

Re: [PATCH V2 07/12] drm: bridge: icn6211: Disable DPI color swap

2022-03-02 Thread Maxime Ripard
On Thu, Feb 17, 2022 at 01:25:25AM +0100, Marek Vasut wrote: > The chip is capable of swapping DPI RGB channels. The driver currently > does not implement support for this functionality. Write the MIPI_PN_SWAP > register to 0 to assure the color swap is disabled. > > Signed-off-by: Marek Vasut >

Re: [PATCH V2 08/12] drm: bridge: icn6211: Set SYS_CTRL_1 to value used in examples

2022-03-02 Thread Maxime Ripard
On Thu, Feb 17, 2022 at 01:25:26AM +0100, Marek Vasut wrote: > Both example code [1], [2] as well as one provided by custom panel vendor > set register SYS_CTRL_1 to 0x88. What exactly does the value mean is unknown > due to unavailable datasheet. Align this register value with example code. > > [

Re: [PATCH V2 09/12] drm: bridge: icn6211: Implement atomic_get_input_bus_fmts

2022-03-02 Thread Maxime Ripard
On Thu, Feb 17, 2022 at 01:25:27AM +0100, Marek Vasut wrote: > Implement .atomic_get_input_bus_fmts callback, which sets up the > input (DSI-end) format, and that format can then be used in pipeline > format negotiation between the DSI-end of this bridge and the other > component closer to the scan

Re: [PATCH v12 19/23] drm/mediatek: add dma dev get function

2022-03-02 Thread AngeloGioacchino Del Regno
Il 22/02/22 11:07, Nancy.Lin ha scritto: This is a preparation for adding support for the ovl_adaptor sub driver Ovl_adaptor is a DRM sub driver, which doesn't have dma dev. Add dma_dev_get function for getting representative dma dev in ovl_adaptor. Signed-off-by: Nancy.Lin Reviewed-by: Angel

Re: [PATCH V2 10/12] drm: bridge: icn6211: Add I2C configuration support

2022-03-02 Thread Maxime Ripard
On Thu, Feb 17, 2022 at 01:25:28AM +0100, Marek Vasut wrote: > The ICN6211 chip starts in I2C configuration mode after cold boot. > Implement support for configuring the chip via I2C in addition to > the current DSI LP command mode configuration support. The later > seems to be available only on ch

Re: [PATCH V2 11/12] drm: bridge: icn6211: Rework ICN6211_DSI to chipone_writeb()

2022-03-02 Thread Maxime Ripard
On Thu, Feb 17, 2022 at 01:25:29AM +0100, Marek Vasut wrote: > Rename and inline macro ICN6211_DSI() into function chipone_writeb() > to keep all function names lower-case. No functional change. > > Signed-off-by: Marek Vasut > Cc: Jagan Teki > Cc: Maxime Ripard > Cc: Robert Foss > Cc: Sam Rav

Re: [PATCH V2 12/12] drm: bridge: icn6211: Read and validate chip IDs before configuration

2022-03-02 Thread Maxime Ripard
On Thu, Feb 17, 2022 at 01:25:30AM +0100, Marek Vasut wrote: > Read out the Vendor/Chip/Version ID registers from the chip before > performing any configuration, and validate that the registers have > correct values. This is mostly a simple test whether DSI register > access does work, since that t

Re: [PATCH v12 23/23] arm64: dts: mt8195: add display node for vdosys1

2022-03-02 Thread AngeloGioacchino Del Regno
Il 22/02/22 11:07, Nancy.Lin ha scritto: Add display node for vdosys1. Signed-off-by: Nancy.Lin --- arch/arm64/boot/dts/mediatek/mt8195.dtsi | 222 +++ 1 file changed, 222 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek

Re: [PATCH v12 01/23] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-03-02 Thread AngeloGioacchino Del Regno
Il 22/02/22 11:07, Nancy.Lin ha scritto: Add vdosys1 RDMA definition. Signed-off-by: Nancy.Lin --- .../arm/mediatek/mediatek,mdp-rdma.yaml | 77 +++ 1 file changed, 77 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,mdp-rdma.y

Re: [PATCH v12 03/23] dt-bindings: mediatek: add ethdr definition for mt8195

2022-03-02 Thread AngeloGioacchino Del Regno
Il 22/02/22 11:07, Nancy.Lin ha scritto: Add vdosys1 ETHDR definition. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu --- .../display/mediatek/mediatek,ethdr.yaml | 147 ++ 1 file changed, 147 insertions(+) create mode 100644 Documentation/devicetree/bindings/di

Re: [PATCH v12 04/23] dt-bindings: reset: mt8195: add vdosys1 reset control bit

2022-03-02 Thread AngeloGioacchino Del Regno
Il 22/02/22 11:07, Nancy.Lin ha scritto: Add vdosys1 reset control bit for MT8195 platform. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu Reviewed-by: AngeloGioacchino Del Regno

[PATCH v2 0/3] vm- and vma cleanups

2022-03-02 Thread Thomas Hellström
The first patch of the series addresses a vm open count bug by removing the vm open count. The second patch removes the vma refcount that is no longer needed; the vma is kept a live by taking the vm refcount and object lock. Finally the last patch removes some unnecessary code. There should be no

[PATCH v2 1/3] drm/i915: Remove the vm open count

2022-03-02 Thread Thomas Hellström
vms are not getting properly closed. Rather than fixing that, Remove the vm open count and instead rely on the vm refcount. The vm open count existed solely to break the strong references the vmas had on the vms. Now instead make those references weak and ensure vmas are destroyed when the vm is d

[PATCH v2 2/3] drm/i915: Remove the vma refcount

2022-03-02 Thread Thomas Hellström
Now that i915_vma_parked() is taking the object lock on vma destruction, and the only user of the vma refcount, i915_gem_object_unbind() also takes the object lock, remove the vma refcount. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/i915_gem.c | 17 + drivers/

[PATCH v2 3/3] drm/i915/gem: Remove some unnecessary code

2022-03-02 Thread Thomas Hellström
The test for vma should always return true, and when assigning -EBUSY to ret, the variable should already have that value. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/i915_gem.c | 32 ++-- 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/dr

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-02 Thread Neil Armstrong
H, On 01/03/2022 21:37, H. Nikolaus Schaller wrote: Hi Neil, Am 01.03.2022 um 10:18 schrieb Neil Armstrong : Hi, On 26/02/2022 18:13, H. Nikolaus Schaller wrote: Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts callbacks") introduced a new mechanism to negotiate b

Re: linux-next: build warning after merge of the drm tree

2022-03-02 Thread Hans de Goede
Hi, On 3/2/22 02:34, Stephen Rothwell wrote: > Hi all, > > On Wed, 2 Feb 2022 09:38:37 +0100 Hans de Goede wrote: >> >> On 2/2/22 05:03, Stephen Rothwell wrote: >>> >>> On Wed, 2 Feb 2022 15:02:01 +1100 Stephen Rothwell >>> wrote: After merging the drm tree, today's linux-next buil

Re: [PATCH] drm/i915/gt: Handle errors for i915_gem_object_trylock

2022-03-02 Thread Tvrtko Ursulin
+ Thomas, Matt On 02/03/2022 06:19, Jiasheng Jiang wrote: As the potential failure of the i915_gem_object_trylock(), it should be better to check it and return error if fails. Fixes: 94ce0d65076c ("drm/i915/gt: Setup a default migration context on the GT") Signed-off-by: Jiasheng Jiang ---

Re: [PATCH v1 2/3] drm/panel: Add panel driver for NewVision NV3052C based LCDs

2022-03-02 Thread Paul Cercueil
Hi Christophe, Le mar., mars 1 2022 at 16:31:21 +0100, Christophe Branchereau a écrit : This driver supports the NewVision NV3052C based LCDs. Right now, it only supports the LeadTek LTK035C5444T 2.4" 640x480 TFT LCD panel, which can be found in the Anbernic RG-350M handheld console. You'd

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Make the heartbeat play nice with long pre-emption timeouts

2022-03-02 Thread Tvrtko Ursulin
On 01/03/2022 20:59, John Harrison wrote: On 3/1/2022 04:09, Tvrtko Ursulin wrote: I'll trim it a bit again.. On 28/02/2022 18:55, John Harrison wrote: On 2/28/2022 09:12, Tvrtko Ursulin wrote: On 25/02/2022 18:48, John Harrison wrote: On 2/25/2022 10:14, Tvrtko Ursulin wrote: [snip] Y

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-02 Thread H. Nikolaus Schaller
Hi Neil, > Am 02.03.2022 um 11:25 schrieb Neil Armstrong : > >> I added a printk for hdmi->sink_is_hdmi. This returns 1. Which IMHO is to be >> expected >> since I am using a HDMI connector and panel... So your patch will still add >> the UYVY formats. >> Either the synposys module inside the j

Re: [Intel-gfx] [PATCH 0/3] Improve anti-pre-emption w/a for compute workloads

2022-03-02 Thread Tvrtko Ursulin
On 28/02/2022 19:17, John Harrison wrote: On 2/28/2022 07:32, Tvrtko Ursulin wrote: On 25/02/2022 19:03, John Harrison wrote: On 2/25/2022 10:29, Tvrtko Ursulin wrote: On 25/02/2022 18:01, John Harrison wrote: On 2/25/2022 09:39, Tvrtko Ursulin wrote: On 25/02/2022 17:11, John Harrison wro

Re: [PATCH v1 3/3] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable

2022-03-02 Thread Paul Cercueil
Hi Christophe, Le mar., mars 1 2022 at 16:31:22 +0100, Christophe Branchereau a écrit : Following the introduction of bridge_atomic_enable in the ingenic drm driver, the crtc is enabled between .prepare and .enable, if it exists. Add it so the backlight is only enabled after the crtc is, to a

Re: [PATCH v7 10/24] drm/rockchip: dw_hdmi: Add support for hclk

2022-03-02 Thread Sascha Hauer
On Tue, Mar 01, 2022 at 01:39:31PM +, Robin Murphy wrote: > On 2022-02-28 14:19, Sascha Hauer wrote: > > On Fri, Feb 25, 2022 at 02:11:54PM +0100, Sascha Hauer wrote: > > > On Fri, Feb 25, 2022 at 12:41:23PM +, Robin Murphy wrote: > > > > On 2022-02-25 11:10, Dmitry Osipenko wrote: > > > >

Re: [PATCH v2 2/8] drm: bridge: nwl-dsi: Switch to devm_drm_of_get_bridge

2022-03-02 Thread Guido Günther
Hi, On Tue, Mar 01, 2022 at 07:42:41PM +0530, Jagan Teki wrote: > devm_drm_of_get_bridge is capable of looking up the downstream > bridge and panel and trying to add a panel bridge if the panel > is found. > > Replace explicit finding calls with devm_drm_of_get_bridge. > > Cc: Guido Günther > Si

Re: MSM8960: gpu/drm/dp/drm_dp.c:59:27: warning: array subscript 10 is outside, array bounds of 'const u8[6]'

2022-03-02 Thread Jani Nikula
On Tue, 01 Mar 2022, Rudraksha Gupta wrote: > Hi all, > > > I am getting this warning when compiling the kernel for the MSM8960 with > this defconfig: > https://raw.githubusercontent.com/apq8064-mainline/linux/qcom-apq8064-next/arch/arm/configs/qcom_apq8064_defconfig > > > Warning: > > ../driver

Re: [PATCH] drm/bridge: nwl-dsi: Remove superfluous write to NWL_DSI_IRQ_MASK register

2022-03-02 Thread Guido Günther
Hi Liu, On Wed, Feb 16, 2022 at 04:58:42PM +0800, Liu Ying wrote: > To initialize register NWL_DSI_IRQ_MASK, it's enough to write it > only once in function nwl_dsi_init_interrupts(). > > Signed-off-by: Liu Ying > --- > drivers/gpu/drm/bridge/nwl-dsi.c | 14 +- > 1 file changed, 5 in

Re: linux-next: build warning after merge of the drm tree

2022-03-02 Thread Stephen Rothwell
Hi Hans, On Wed, 2 Mar 2022 11:32:37 +0100 Hans de Goede wrote: > > On 3/2/22 02:34, Stephen Rothwell wrote: > > Hi all, > > > > On Wed, 2 Feb 2022 09:38:37 +0100 Hans de Goede > > wrote: > >> > >> On 2/2/22 05:03, Stephen Rothwell wrote: > >>> > >>> On Wed, 2 Feb 2022 15:02:01 +1100 Steph

Re: [PATCH] drm/i915: Depend on !PREEMPT_RT.

2022-03-02 Thread Tvrtko Ursulin
On 01/03/2022 15:13, Sebastian Andrzej Siewior wrote: On 2022-03-01 14:27:18 [+], Tvrtko Ursulin wrote: you see: 0003-drm-i915-Use-preempt_disable-enable_rt-where-recomme.patch 0004-drm-i915-Don-t-disable-interrupts-on-PREEMPT_RT-duri.patch Two for the display folks. 000

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-02 Thread Lucas Stach
Am Mittwoch, dem 02.03.2022 um 17:41 +0800 schrieb Liu Ying: > On Wed, 2022-03-02 at 10:23 +0100, Lucas Stach wrote: > > Am Mittwoch, dem 02.03.2022 um 03:54 +0100 schrieb Marek Vasut: > > > On 3/1/22 14:18, Lucas Stach wrote: > > > > Am Dienstag, dem 01.03.2022 um 07:03 -0600 schrieb Adam Ford: >

Re: [PATCH v2 8/8] drm: bridge: anx7625: Switch to devm_drm_of_get_bridge

2022-03-02 Thread Linus Walleij
On Wed, Mar 2, 2022 at 5:37 AM Jagan Teki wrote: > On Wed, Mar 2, 2022 at 4:50 AM Linus Walleij wrote: > > > > On Tue, Mar 1, 2022 at 3:13 PM Jagan Teki > > wrote: > > > > > + bridge = devm_drm_of_get_bridge(dev, dev->of_node, 0, 0); > > > + if (IS_ERR(bridge)) { > > > +

[PATCH] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-02 Thread Xin Ji
As downstream sink was set into standby mode while bridge disabled, this patch used for setting downstream sink into normal status while enable bridge. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/

Re: [PATCH] drm/panfrost: cleanup comments

2022-03-02 Thread Tom Rix
On 3/2/22 1:09 AM, Steven Price wrote: On 01/03/2022 12:43, t...@redhat.com wrote: From: Tom Rix For spdx change tab to space delimiter Use // for *.c Replacements commited to committed, use multiline comment style regsiters to registers initialze to initialize Signed-off-by: Tom Rix Tha

Re: [PATCH v4 1/9] dt-bindings: host1x: Add iommu-map property

2022-03-02 Thread Mikko Perttunen
On 3/1/22 20:12, Robin Murphy wrote: On 2022-03-01 16:14, cyn...@kapsi.fi wrote: From: Mikko Perttunen Add schema information for specifying context stream IDs. This uses the standard iommu-map property. Signed-off-by: Mikko Perttunen --- v3: * New patch v4: * Remove memory-contexts subnode.

Re: [PATCH] drm/i915: Depend on !PREEMPT_RT.

2022-03-02 Thread Sebastian Andrzej Siewior
On 2022-03-02 11:42:35 [+], Tvrtko Ursulin wrote: > > > > 0005-drm-i915-Don-t-check-for-atomic-context-on-PREEMPT_R.patch > > > > > > What do preempt_disable/enable do on PREEMPT_RT? Thinking if instead the > > > solution could be to always force the !ATOMIC path (for the whole > > > _wai

[PATCH v2] drm/panfrost: cleanup comments

2022-03-02 Thread trix
From: Tom Rix For spdx change tab to space delimiter Use // for *.c Replacements commited to committed regsiters to registers initialze to initialize Signed-off-by: Tom Rix --- v2: remove multiline comment change drivers/gpu/drm/panfrost/panfrost_drv.c | 2 +- drivers/gpu/drm/panfro

Re: [PATCH v12 1/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-03-02 Thread Robin Murphy
On 2022-02-25 19:27, Michael Cheng wrote: Hi Robin, [ +arm64 maintainers for their awareness, which would have been a good thing to do from the start ]  * Thanks for adding the arm64 maintainer and sorry I didn't rope them    in sooner. Why does i915 need to ensure the CPU's instruction ca

Re: [PATCH v2 2/4] drm/ttm: parameter to add extra pages into ttm_tt

2022-03-02 Thread Thomas Hellström
On Wed, 2022-03-02 at 03:23 +0530, Ramalingam C wrote: > When a driver needs extra pages in ttm_tt, to facilidate such > requirement, parameter called "extra_pages" is added for > ttm_tt_init nit: Please use imperative wording in commit title and description, "Add a parameter to add extra pages.."

Re: [PATCH v2 3/4] drm/i915/gem: Extra pages in ttm_tt for ccs data

2022-03-02 Thread Thomas Hellström
On Wed, 2022-03-02 at 03:23 +0530, Ramalingam C wrote: > On Xe-HP and later devices, we use dedicated compression control > state (CCS) stored in local memory for each surface, to support the > 3D and media compression formats. > > The memory required for the CCS of the entire local memory is 1/25

Re: [PATCH] drm/bridge: nwl-dsi: Remove superfluous write to NWL_DSI_IRQ_MASK register

2022-03-02 Thread Robert Foss
On Wed, 2 Mar 2022 at 12:35, Guido Günther wrote: > > Hi Liu, > On Wed, Feb 16, 2022 at 04:58:42PM +0800, Liu Ying wrote: > > To initialize register NWL_DSI_IRQ_MASK, it's enough to write it > > only once in function nwl_dsi_init_interrupts(). > > > > Signed-off-by: Liu Ying > > --- > > drivers/

Re: [PATCH v2 2/4] drm/ttm: parameter to add extra pages into ttm_tt

2022-03-02 Thread Christian König
Am 01.03.22 um 22:53 schrieb Ramalingam C: When a driver needs extra pages in ttm_tt, to facilidate such requirement, parameter called "extra_pages" is added for ttm_tt_init Signed-off-by: Ramalingam C cc: Christian Koenig cc: Hellstrom Thomas With the nits pointed out by Thomas the patch i

Re: [PATCH v2] drm/panfrost: cleanup comments

2022-03-02 Thread Steven Price
On 02/03/2022 12:45, t...@redhat.com wrote: > From: Tom Rix > > For spdx > change tab to space delimiter > Use // for *.c > > Replacements > commited to committed > regsiters to registers > initialze to initialize > > Signed-off-by: Tom Rix Reviewed-by: Steven Price > --- > v2: remove multi

Re: [PATCH 1/2] drm: Introduce DRM_BRIDGE_OP_UPSTREAM_FIRST to alter bridge init order

2022-03-02 Thread Dave Stevenson
Hi Andrzej On Mon, 28 Feb 2022 at 15:36, Andrzej Hajda wrote: > > > > On 22.02.2022 09:43, Dave Stevenson wrote: > > Hi Laurent. > > > > Thanks for the review. > > > > On Tue, 22 Feb 2022 at 06:34, Laurent Pinchart > > wrote: > >> Hi Dave, > >> > >> Thank you for the patch. > >> > >> On Wed, Feb

RE: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-02 Thread David Laight
From: Xiaomeng Tong > Sent: 02 March 2022 09:31 > > On Mon, 28 Feb 2022 16:41:04 -0800, Linus Torvalds > wrote: > > > > But basically to _me_, the important part is that the end result is > > maintainable longer-term. > > I couldn't agree more. And because of that, I stick with the following > a

[Bug 215648] amdgpu: Changing monitor configuration (plug/unplug/wake from DPMS) causes kernel panic

2022-03-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215648 --- Comment #3 from Alex Deucher (alexdeuc...@gmail.com) --- Thanks. Can you get the dmesg output from boot prior to the hang? -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee

[Bug 215648] amdgpu: Changing monitor configuration (plug/unplug/wake from DPMS) causes kernel panic

2022-03-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215648 --- Comment #4 from Philipp Riederer (pr_ker...@tum.fail) --- Created attachment 300517 --> https://bugzilla.kernel.org/attachment.cgi?id=300517&action=edit dmesg from boot using kernel 5.15.12@94ba5b0fb52d6dbf1f200351876a839afb74aedd -- You m

[Bug 215648] amdgpu: Changing monitor configuration (plug/unplug/wake from DPMS) causes kernel panic

2022-03-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215648 --- Comment #5 from Philipp Riederer (pr_ker...@tum.fail) --- Hey, Thank you for working on this! I added the dmesg as attachment to the bug. Please note that this is from the working kernel (commit 94ba5b0fb52d6dbf1f200351876a839afb74aedd) as t

Re: [RFC PATCH] drm/panel: simple: panel-dpi: use bus-format to set bpc and bus_format

2022-03-02 Thread Maxime Ripard
Hi, Please try to avoid top posting On Wed, Feb 23, 2022 at 04:25:19PM +0100, Max Krummenacher wrote: > The goal here is to set the element bus_format in the struct > panel_desc. This is an enum with the possible values defined in > include/uapi/linux/media-bus-format.h. > > The enum values are

[PATCH] video: fbdev: sm712fb: Fix crash in smtcfb_write()

2022-03-02 Thread Zheyu Ma
When the sm712fb driver writes three bytes to the framebuffer, the driver will crash: BUG: unable to handle page fault for address: c90001ff RIP: 0010:smtcfb_write+0x454/0x5b0 Call Trace: vfs_write+0x291/0xd60 ? do_sys_openat2+0x27d/0x350 ? __fget_light+0x54/0x34

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-02 Thread Neil Armstrong
Hi, On 02/03/2022 12:15, H. Nikolaus Schaller wrote: Hi Neil, Am 02.03.2022 um 11:25 schrieb Neil Armstrong : I added a printk for hdmi->sink_is_hdmi. This returns 1. Which IMHO is to be expected since I am using a HDMI connector and panel... So your patch will still add the UYVY formats.

Re: [PATCH V2 03/12] drm: bridge: icn6211: Add HS/VS/DE polarity handling

2022-03-02 Thread Marek Vasut
On 3/2/22 10:59, Maxime Ripard wrote: On Thu, Feb 17, 2022 at 01:25:21AM +0100, Marek Vasut wrote: The driver currently hard-codes HS/VS polarity to active-low and DE to active-high, which is not correct for a lot of supported DPI panels. Add the missing mode flag handling for HS/VS/DE polarity.

Re: [PATCH V2 04/12] drm: bridge: icn6211: Add DSI lane count DT property parsing

2022-03-02 Thread Marek Vasut
On 3/2/22 11:01, Maxime Ripard wrote: On Thu, Feb 17, 2022 at 01:25:22AM +0100, Marek Vasut wrote: The driver currently hard-codes DSI lane count to two, however the chip is capable of operating in 1..4 DSI lanes mode. Parse 'data-lanes' DT property and program the result into DSI_CTRL register.

[PATCH 0/8] drm/vmwgfx: 3D on arm64 and large cursor support

2022-03-02 Thread Zack Rusin
From: Zack Rusin Series finishes 3D support on arm64 with vmwgfx. With this and changes that add svga3 pci id's to Mesa3D - OpenGL 4.3 and GLES 3.1 work smoothly on arm64. Most changes are not svga3 specific but rather co

[PATCH 3/8] drm/vmwgfx: Print capabilities early during the initialization

2022-03-02 Thread Zack Rusin
From: Zack Rusin Capabilities were logged at the end of initialization so any early errors would make them not appear in the logs. Which is also when they're needed the most. Print the the capabilities right after fetching them, before the init code starts using them to make sure they always show

[PATCH 2/8] drm/vmwgfx: Cleanup multimon initialization code

2022-03-02 Thread Zack Rusin
From: Zack Rusin The results of the legacy display unit initialization were being silently ignored. Unifying the selection of number of display units based on whether the underlying device supports multimon makes it easier to add error checking to all paths. This makes the driver report the erro

[PATCH 4/8] drm/vmwgfx: Fix fencing on SVGAv3

2022-03-02 Thread Zack Rusin
From: Zack Rusin Port of the vmwgfx to SVGAv3 lacked support for fencing. SVGAv3 removed FIFO's and replaced them with command buffers and extra registers. The initial version of SVGAv3 lacked support for most advanced features (e.g. 3D) which made fences unnecessary. That is no longer the case,

[PATCH 1/8] drm/vmwgfx: Add support for CursorMob and CursorBypass 4

2022-03-02 Thread Zack Rusin
From: Martin Krastev * Add support for CursorMob * Add support for CursorBypass 4 * Refactor vmw_du_cursor_plane_atomic_update to be kms-helper-atomic -- move BO mappings to vmw_du_cursor_plane_prepare_fb -- move BO unmappings to vmw_du_cursor_plane_cleanup_fb Cursor mobs are a new svga feat

[PATCH 7/8] drm/vmwgfx: Implement MSI/MSI-X support for IRQs

2022-03-02 Thread Zack Rusin
From: Zack Rusin SVGAv3 deprecates legacy interrupts and adds support for MSI/MSI-X. With MSI the driver visible side remains largely unchanged but with MSI-X each interrupt gets delivered on its own vector. Add support for MSI/MSI-X while preserving the old functionality for SVGAv2. Code betwee

[PATCH 5/8] drm/vmwgfx: Allow querying of the SVGA PCI id from the userspace

2022-03-02 Thread Zack Rusin
From: Zack Rusin Mesa3D loaders require knowledge of the devices PCI id. SVGAv2 and v3 have different PCI id's, but the same driver is used to handle them both. To allow Mesa3D svga driver to be loaded automatically for both SVGAv2 and SVGAv3 make the kernel return the PCI id of the currently run

[PATCH 8/8] drm/vmwgfx: Stop using surface dma commands on most configurations

2022-03-02 Thread Zack Rusin
From: Zack Rusin Initial version of guest backed objects in the host had some performance issues that made using surface-dma's instead of direct copies faster. Surface dma's force a migration to vram which at best is slow and at worst is impossible (e.g. on svga3 where there's not enough vram to

[PATCH 6/8] drm/vmwgfx: Initialize drm_mode_fb_cmd2

2022-03-02 Thread Zack Rusin
From: Zack Rusin Transition to drm_mode_fb_cmd2 from drm_mode_fb_cmd left the structure unitialized. drm_mode_fb_cmd2 adds a few additional members, e.g. flags and modifiers which were never initialized. Garbage in those members can cause random failures during the bringup of the fbcon. Initiali

Re: [PATCH v12 1/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-03-02 Thread Michael Cheng
Thanks for the feedback Robin! Sorry my choices of word weren't that great, but what I meant is to understand how ARM flushes a range of dcache for device drivers, and not an equal to x86 clflush. I believe the concern is if the CPU writes an update, that update might only be sitting in the

Re: [RFC PATCH] drm/panel: simple: panel-dpi: use bus-format to set bpc and bus_format

2022-03-02 Thread Marek Vasut
On 3/2/22 15:21, Maxime Ripard wrote: Hi, Hi, Please try to avoid top posting On Wed, Feb 23, 2022 at 04:25:19PM +0100, Max Krummenacher wrote: The goal here is to set the element bus_format in the struct panel_desc. This is an enum with the possible values defined in include/uapi/linux/med

  1   2   >