Re: [PATCH] lib/stackdepot: always do filter_irq_stacks() in stack_depot_save()

2021-12-01 Thread Andrey Konovalov
On Tue, Nov 30, 2021 at 11:14 AM Marco Elver wrote: > > The non-interrupt portion of interrupt stack traces before interrupt > entry is usually arbitrary. Therefore, saving stack traces of interrupts > (that include entries before interrupt entry) to stack depot leads to > unbounded stackdepot gro

Re: [Linaro-mm-sig] [RFC PATCH 1/2] dma-fence: Avoid establishing a locking order between fence classes

2021-12-01 Thread Intel
On 12/1/21 08:05, Christian König wrote: Am 30.11.21 um 20:27 schrieb Thomas Hellström: On 11/30/21 19:12, Thomas Hellström wrote: On Tue, 2021-11-30 at 16:02 +0100, Christian König wrote: Am 30.11.21 um 15:35 schrieb Thomas Hellström: On Tue, 2021-11-30 at 14:26 +0100, Christian König wro

Re: [Linaro-mm-sig] [RFC PATCH 1/2] dma-fence: Avoid establishing a locking order between fence classes

2021-12-01 Thread Christian König
Am 01.12.21 um 09:23 schrieb Thomas Hellström (Intel):  [SNIP] Jason and I came up with a deep dive iterator for his use case, but I think we don't want to use that any more after my dma_resv rework. In other words when you need to create a new dma_fence_array you flatten out the existing const

Re: [PATCH v3] drm/i915/dp: Perform 30ms delay after source OUI write

2021-12-01 Thread Jani Nikula
On Tue, 30 Nov 2021, Lyude Paul wrote: > While working on supporting the Intel HDR backlight interface, I noticed > that there's a couple of laptops that will very rarely manage to boot up > without detecting Intel HDR backlight support - even though it's supported > on the system. One example of

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Use to_root_gt() to refer to the root tile

2021-12-01 Thread Michal Wajdeczko
On 01.12.2021 01:38, Lucas De Marchi wrote: > On Wed, Dec 01, 2021 at 12:41:08AM +0200, Andi Shyti wrote: >> Hi Lucas, >> >> fist of all thanks for taking a look at this, I was eagerly >> waiting for reviewers. >> >> On Tue, Nov 30, 2021 at 01:07:30PM -0800, Lucas De Marchi wrote: >>> On Sun, No

Re: [PATCH v4] dma-buf: system_heap: Use 'for_each_sgtable_sg' in pages free flow

2021-12-01 Thread Sumit Semwal
Hello Guangming, On Mon, 29 Nov 2021 at 23:35, John Stultz wrote: > > On Thu, Nov 25, 2021 at 11:48 PM wrote: > > > > From: Guangming > > > > For previous version, it uses 'sg_table.nent's to traverse sg_table in pages > > free flow. > > However, 'sg_table.nents' is reassigned in 'dma_map_sg',

Re: [Linaro-mm-sig] [RFC PATCH 1/2] dma-fence: Avoid establishing a locking order between fence classes

2021-12-01 Thread Intel
On 12/1/21 09:36, Christian König wrote: Am 01.12.21 um 09:23 schrieb Thomas Hellström (Intel):  [SNIP] Jason and I came up with a deep dive iterator for his use case, but I think we don't want to use that any more after my dma_resv rework. In other words when you need to create a new dma_f

Re: [Linaro-mm-sig] [RFC PATCH 1/2] dma-fence: Avoid establishing a locking order between fence classes

2021-12-01 Thread Christian König
Am 01.12.21 um 11:15 schrieb Thomas Hellström (Intel): [SNIP] What we could do is to avoid all this by not calling the callback with the lock held in the first place. If that's possible that might be a good idea, pls also see below. The problem with that is dma_fence_signal_locked()/dma_f

Re: [PATCH v3 2/2] drm: rcar-du: Add R-Car DSI driver

2021-12-01 Thread Kieran Bingham
Quoting Laurent Pinchart (2021-12-01 05:24:06) > From: LUU HOAI > > The driver supports the MIPI DSI/CSI-2 TX encoder found in the R-Car V3U > SoC. It currently supports DSI mode only. > > Signed-off-by: LUU HOAI > Signed-off-by: Laurent Pinchart > Reviewed-by: Kieran Bingham > Tested-by: Kie

Re: [PATCH v3 2/2] drm: rcar-du: Add R-Car DSI driver

2021-12-01 Thread Jagan Teki
Hi Laurent, On Wed, Dec 1, 2021 at 10:54 AM Laurent Pinchart wrote: > > From: LUU HOAI > > The driver supports the MIPI DSI/CSI-2 TX encoder found in the R-Car V3U > SoC. It currently supports DSI mode only. > > Signed-off-by: LUU HOAI > Signed-off-by: Laurent Pinchart > Reviewed-by: Kieran Bi

Re: [PATCH v2 1/2] drm: rcar-du: mipi-dsi: Support bridge probe ordering

2021-12-01 Thread Kieran Bingham
Quoting Laurent Pinchart (2021-12-01 04:38:46) > Hi Kieran, > > Thank you for the patch. > > On Tue, Nov 30, 2021 at 04:25:12PM +, Kieran Bingham wrote: > > The bridge probe ordering for DSI devices has been clarified and further > > documented in > > I've read the document and > Good, I'm

[PATCH v3 0/2] drm/msm: Fix dsi/bridge probe

2021-12-01 Thread AngeloGioacchino Del Regno
Context, from patch 2/2: Since commit 8f59ee9a570c ("drm/msm/dsi: Adjust probe order"), the DSI host gets initialized earlier, but this caused unability to probe the entire stack of components because they all depend on interrupts coming from the main `mdss` node (mdp5, or dpu1). Changes in v3: -

[PATCH v3 1/2] drm/msm: Allocate msm_drm_private early and pass it as driver data

2021-12-01 Thread AngeloGioacchino Del Regno
In preparation for registering the mdss interrupt controller earlier, move the allocation of msm_drm_private from component bind time to msm_drv probe; this also allows us to use the devm variant of kzalloc. Since it is not right to allocate the drm_device at probe time (as it should exist only wh

[PATCH v3 2/2] drm/msm: Initialize MDSS irq domain at probe time

2021-12-01 Thread AngeloGioacchino Del Regno
Since commit 8f59ee9a570c ("drm/msm/dsi: Adjust probe order"), the DSI host gets initialized earlier, but this caused unability to probe the entire stack of components because they all depend on interrupts coming from the main `mdss` node (mdp5, or dpu1). To fix this issue, anticipate registering

Re: [Linaro-mm-sig] [RFC PATCH 1/2] dma-fence: Avoid establishing a locking order between fence classes

2021-12-01 Thread Intel
On 12/1/21 11:32, Christian König wrote: Am 01.12.21 um 11:15 schrieb Thomas Hellström (Intel): [SNIP] What we could do is to avoid all this by not calling the callback with the lock held in the first place. If that's possible that might be a good idea, pls also see below. The problem w

Re: [Intel-gfx] [PATCH v2 00/16] drm/i915: Remove short term pins from execbuf.

2021-12-01 Thread Maarten Lankhorst
On 30-11-2021 19:38, Tvrtko Ursulin wrote: > > On 30/11/2021 11:17, Maarten Lankhorst wrote: >> On 30-11-2021 09:54, Tvrtko Ursulin wrote: >>> >>> Hi, >>> >>> On 29/11/2021 13:47, Maarten Lankhorst wrote: New version of the series, with feedback from previous series added. >>> >>> If there was

Re: [Linaro-mm-sig] [RFC PATCH 1/2] dma-fence: Avoid establishing a locking order between fence classes

2021-12-01 Thread Christian König
Am 01.12.21 um 12:04 schrieb Thomas Hellström (Intel): On 12/1/21 11:32, Christian König wrote: Am 01.12.21 um 11:15 schrieb Thomas Hellström (Intel): [SNIP] What we could do is to avoid all this by not calling the callback with the lock held in the first place. If that's possible that mi

[PATCH v2 1/3] dt-bindings: ls2k1000: add gpu device node

2021-12-01 Thread Sui Jingfeng
From: suijingfeng There is a vivante gpu (GC1000 V5037) in ls2k1000, but it is pci device not platform device. ls2k1000 is dual-core mips64 cpu made by loongson. Signed-off-by: suijingfeng Signed-off-by: Sui Jingfeng <15330273...@189.cn> --- arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi

[PATCH v2 1/3] dt-bindings: ls2k1000: add gpu device node

2021-12-01 Thread Sui Jingfeng
From: suijingfeng There is a vivante gpu (GC1000 V5037) in ls2k1000, but it is pci device not platform device. ls2k1000 is dual-core mips64 cpu made by loongson. Signed-off-by: suijingfeng Signed-off-by: Sui Jingfeng <15330273...@189.cn> --- arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi

[PATCH v2 2/3] drm/etnaviv: add pci device driver support

2021-12-01 Thread Sui Jingfeng
From: suijingfeng v2: update commits and provide more material. There is a Vivante GC1000 V5037 in LS2K1000 and LS7A1000, the gpu in those chip is a PCI device not platform one. This GPU have 2D and 3D in the same core, so component framework can be avoid, in fact we find it is diffcul

[PATCH v2 3/3] mips: loongson64: enable etnaviv drm driver on ls2k1000 and ls3a4000

2021-12-01 Thread Sui Jingfeng
From: suijingfeng v2: merge the last two trival patches into one patch. Signed-off-by: suijingfeng Signed-off-by: Sui Jingfeng <15330273...@189.cn> --- arch/mips/configs/loongson2k_defconfig | 1 + arch/mips/configs/loongson3_defconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/a

Re: [PATCH v3 2/2] drm: rcar-du: Add R-Car DSI driver

2021-12-01 Thread Laurent Pinchart
Hi Jagan, On Wed, Dec 01, 2021 at 04:12:39PM +0530, Jagan Teki wrote: > On Wed, Dec 1, 2021 at 10:54 AM Laurent Pinchart wrote: > > > > From: LUU HOAI > > > > The driver supports the MIPI DSI/CSI-2 TX encoder found in the R-Car V3U > > SoC. It currently supports DSI mode only. > > > > Signed-off-

[PATCH v2 2/7] agp: Include "compat_ioctl.h" where necessary

2021-12-01 Thread Thomas Zimmermann
Fix compiler warnings like drivers/char/agp/frontend.c:46:20: warning: no previous prototype for 'agp_find_mem_by_key' [-Wmissing-prototypes] 46 | struct agp_memory *agp_find_mem_by_key(int key) by including the compat_ioctl.h in the source file. Signed-off-by: Thomas Zimmermann Acked-by

[PATCH v2 0/7] agp: Various minor fixes

2021-12-01 Thread Thomas Zimmermann
Fix a number of compiler warnings in the AGP drivers. No functional changes. v2: * ati-agp: free page in error branch (Helge) * nvidia-agp: Mark temp as __maybe_unused (Helge) Thomas Zimmermann (7): agp: Remove trailing whitespaces agp: Include "compat_ioctl.h" where necessary

[PATCH v2 4/7] agp/ati: Return error from ati_create_page_map()

2021-12-01 Thread Thomas Zimmermann
Fix the compiler warning drivers/char/agp/ati-agp.c: In function 'ati_create_page_map': drivers/char/agp/ati-agp.c:58:16: warning: variable 'err' set but not used [-Wunused-but-set-variable] 58 | int i, err = 0; by returing the error to the caller. v2: * free page in err

[PATCH v2 6/7] agp/sworks: Remove unused variable 'current_size'

2021-12-01 Thread Thomas Zimmermann
Fix the compiler warning drivers/char/agp/sworks-agp.c: In function 'serverworks_configure': drivers/char/agp/sworks-agp.c:265:37: warning: variable 'current_size' set but not used [-Wunused-but-set-variable] 265 | struct aper_size_info_lvl2 *current_size; by removing the variabl

[PATCH v2 3/7] agp: Documentation fixes

2021-12-01 Thread Thomas Zimmermann
Fix compiler warnings drivers/char/agp/backend.c:68: warning: Function parameter or member 'pdev' not described in 'agp_backend_acquire' drivers/char/agp/backend.c:93: warning: Function parameter or member 'bridge' not described in 'agp_backend_release' by adding the necessary documentation

[PATCH v2 5/7] agp/nvidia: Declare value returned by readl() as unused

2021-12-01 Thread Thomas Zimmermann
Fix the compiler warning drivers/char/agp/nvidia-agp.c: In function 'nvidia_tlbflush': drivers/char/agp/nvidia-agp.c:264:22: warning: variable 'temp' set but not used [-Wunused-but-set-variable] 264 | u32 wbc_reg, temp; by marking the temp variable with __maybe_unused. The affect

[PATCH v2 7/7] agp/via: Remove unused variable 'current_size'

2021-12-01 Thread Thomas Zimmermann
Fix the compiler warning drivers/char/agp/via-agp.c: In function 'via_configure_agp3': drivers/char/agp/via-agp.c:131:35: warning: variable 'current_size' set but not used [-Wunused-but-set-variable] 131 | struct aper_size_info_16 *current_size; by removing the variable. Signed-

[PATCH v2 1/7] agp: Remove trailing whitespaces

2021-12-01 Thread Thomas Zimmermann
Trivial coding-style fix. Signed-off-by: Thomas Zimmermann Acked-by: Helge Deller --- drivers/char/agp/ati-agp.c| 2 +- drivers/char/agp/frontend.c | 2 +- drivers/char/agp/sworks-agp.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/char/agp/ati-agp.c b/dri

Re: [PATCH v11, 18/19] media: mtk-vcodec: Remove mtk_vcodec_release_dec_pm

2021-12-01 Thread AngeloGioacchino Del Regno
Il 29/11/21 04:42, Yunfei Dong ha scritto: There are only two lines in mtk_vcodec_release_dec_pm, using pm_runtime_disable and put_device instead directly. Move pm_runtime_enable outside mtk_vcodec_init_dec_pm to symmetry with pm_runtime_disable, after that, rename mtk_vcodec_init_dec_pm to *_cl

Re: [PATCH v11, 19/19] media: mtk-vcodec: Remove mtk_vcodec_release_enc_pm

2021-12-01 Thread AngeloGioacchino Del Regno
Il 29/11/21 04:42, Yunfei Dong ha scritto: There are only two lines in mtk_vcodec_release_enc_pm, using pm_runtime_disable and put_device instead directly. Move pm_runtime_enable outside mtk_vcodec_release_enc_pm to symmetry with pm_runtime_disable, after that, rename mtk_vcodec_init_enc_pm to *

Re: [PATCH v11,14/19] media: mtk-vcodec: Support 34bits dma address for vdec

2021-12-01 Thread AngeloGioacchino Del Regno
Il 29/11/21 04:41, Yunfei Dong ha scritto: Use the dma_set_mask_and_coherent helper to set vdec DMA bit mask to support 34bits iova space(16GB) that the mt8192 iommu HW support. Whole the iova range separate to 0~4G/4G~8G/8G~12G/12G~16G, regarding which iova range VDEC actually locate, it depend

Re: [PATCH v11, 10/19] media: mtk-vcodec: Add msg queue feature for lat and core architecture

2021-12-01 Thread AngeloGioacchino Del Regno
Il 29/11/21 04:41, Yunfei Dong ha scritto: For lat and core architecture, lat thread will send message to core thread when lat decode done. Core hardware will use the message from lat to decode, then free message to lat thread when decode done. Signed-off-by: Yunfei Dong --- drivers/media/pla

Re: [PATCH v11, 11/19] media: mtk-vcodec: Generalize power and clock on/off interfaces

2021-12-01 Thread AngeloGioacchino Del Regno
Il 29/11/21 04:41, Yunfei Dong ha scritto: Generalizes power and clock on/off interfaces to support different hardware. Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 6 +- .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 2 +- .../platform/mtk-vcodec/mtk_vc

Re: [PATCH v11, 09/19] media: mtk-vcodec: Add irq interface for multi hardware

2021-12-01 Thread AngeloGioacchino Del Regno
Il 29/11/21 04:41, Yunfei Dong ha scritto: Adds irq interface for multi hardware. Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 33 --- .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 2 +- .../platform/mtk-vcodec/mtk_vcodec_drv.h | 25

Re: [PATCH v11, 04/19] media: mtk-vcodec: export decoder pm functions

2021-12-01 Thread AngeloGioacchino Del Regno
Il 29/11/21 04:41, Yunfei Dong ha scritto: Register each hardware as platform device, need to call pm functions to open/close power and clock from module mtk-vcodec-dec, export these functions. Signed-off-by: Yunfei Dong Reviewed-by: Benjamin Gaignard Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v11, 05/19] media: mtk-vcodec: Support MT8192

2021-12-01 Thread AngeloGioacchino Del Regno
Il 29/11/21 04:41, Yunfei Dong ha scritto: From: Yunfei Dong Adds MT8192's compatible "mediatek,mt8192-vcodec-dec". Adds MT8192's device private data mtk_lat_sig_core_pdata. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH] drm/msm/dpu: fix exception in error path

2021-12-01 Thread Dmitry Baryshkov
On 01/12/2021 05:53, Bjorn Andersson wrote: On Thu 25 Nov 12:01 CST 2021, Dmitry Baryshkov wrote: In case of DPU probe failure, prevent the following NULL pointer exception: [3.976112] Unable to handle kernel NULL pointer dereference at virtual address 0030 [3.984983] Mem

Re: [Linaro-mm-sig] [RFC PATCH 1/2] dma-fence: Avoid establishing a locking order between fence classes

2021-12-01 Thread Intel
On 12/1/21 12:25, Christian König wrote: Am 01.12.21 um 12:04 schrieb Thomas Hellström (Intel): On 12/1/21 11:32, Christian König wrote: Am 01.12.21 um 11:15 schrieb Thomas Hellström (Intel): [SNIP] What we could do is to avoid all this by not calling the callback with the lock held in t

Re: [PATCH v2 0/3] drm/etnaviv: IOMMU related fixes

2021-12-01 Thread Lucas Stach
Hi Michael, Am Dienstag, dem 07.09.2021 um 18:49 +0200 schrieb Michael Walle: > This patch series fixes usage of the etnaviv driver with GPUs behind a > IOMMU. It was tested on a NXP LS1028A SoC. Together with Lucas' MMU patches > [1] there are not more (GPU internal) MMU nor (system) IOMMU faults

Re: [PATCH] drm/etnaviv: constify static struct cooling_ops

2021-12-01 Thread Lucas Stach
Am Sonntag, dem 28.11.2021 um 21:19 +0100 schrieb Rikard Falkeborn: > The only usage of cooling_ops is to pass its address to > thermal_of_cooling_device_register(), which takes a pointer to const > struct thermal_cooling_device_ops as input. Make it const to allow the > compiler to put it in read-

Re: [PATCH v2 3/3] drm/etnaviv: use a 32 bit mask as coherent DMA mask

2021-12-01 Thread Robin Murphy
Sorry I missed this earlier... On 2021-09-07 17:49, Michael Walle wrote: The STLB and the first command buffer (which is used to set up the TLBs) has a 32 bit size restriction in hardware. There seems to be no way to specify addresses larger than 32 bit. Keep it simple and restict the addresses

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Use to_root_gt() to refer to the root tile

2021-12-01 Thread Andi Shyti
Hi Michal, > >> fist of all thanks for taking a look at this, I was eagerly > >> waiting for reviewers. > >> > >> On Tue, Nov 30, 2021 at 01:07:30PM -0800, Lucas De Marchi wrote: > >>> On Sun, Nov 28, 2021 at 01:09:26PM +0200, Andi Shyti wrote: > >>> > Starting from a patch from Matt to_root_gt()

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread Paul Cercueil
Hi Nikolaus, Le mar., nov. 30 2021 at 22:26:37 +0100, H. Nikolaus Schaller a écrit : From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Here we add Kconfig

Re: [Intel-gfx] [PATCH v2 00/16] drm/i915: Remove short term pins from execbuf.

2021-12-01 Thread Tvrtko Ursulin
On 01/12/2021 11:15, Maarten Lankhorst wrote: On 30-11-2021 19:38, Tvrtko Ursulin wrote: On 30/11/2021 11:17, Maarten Lankhorst wrote: On 30-11-2021 09:54, Tvrtko Ursulin wrote: Hi, On 29/11/2021 13:47, Maarten Lankhorst wrote: New version of the series, with feedback from previous serie

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread H. Nikolaus Schaller
Hi Paul, > Am 01.12.2021 um 14:02 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le mar., nov. 30 2021 at 22:26:37 +0100, H. Nikolaus Schaller > a écrit : >> From: Paul Boddie >> A specialisation of the generic Synopsys HDMI driver is employed for >> JZ4780 HDMI support. This requires a new dr

Re: [PATCH v2] drm/komeda: Fix an undefined behavior bug in komeda_plane_add()

2021-12-01 Thread Liviu Dudau
On Wed, Dec 01, 2021 at 11:37:03AM +0800, Zhou Qingyang wrote: > In komeda_plane_add(), komeda_get_layer_fourcc_list() is assigned to > formats and used in drm_universal_plane_init(). > drm_universal_plane_init() passes formats to > __drm_universal_plane_init(). __drm_universal_plane_init() further

Re: [PATCH v2 3/3] drm/etnaviv: use a 32 bit mask as coherent DMA mask

2021-12-01 Thread Lucas Stach
Hi Robin, Am Mittwoch, dem 01.12.2021 um 12:50 + schrieb Robin Murphy: > Sorry I missed this earlier... > > On 2021-09-07 17:49, Michael Walle wrote: > > The STLB and the first command buffer (which is used to set up the TLBs) > > has a 32 bit size restriction in hardware. There seems to be n

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread Mark Brown
On Wed, Dec 01, 2021 at 01:02:45PM +, Paul Cercueil wrote: > Le mar., nov. 30 2021 at 22:26:37 +0100, H. Nikolaus Schaller > > + regulator = devm_regulator_get_optional(&pdev->dev, "hdmi-5v"); > > + if (IS_ERR(regulator)) { > > + ret = PTR_ERR(regulator); Why is this using _opti

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread H. Nikolaus Schaller
Hi, > Am 01.12.2021 um 14:39 schrieb Mark Brown : > > On Wed, Dec 01, 2021 at 01:02:45PM +, Paul Cercueil wrote: >> Le mar., nov. 30 2021 at 22:26:37 +0100, H. Nikolaus Schaller > >>> + regulator = devm_regulator_get_optional(&pdev->dev, "hdmi-5v"); >>> + if (IS_ERR(regulator)) { >>> +

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread Paul Cercueil
Hi Nikolaus, Mark, Le mer., déc. 1 2021 at 14:51:51 +0100, H. Nikolaus Schaller a écrit : Hi, Am 01.12.2021 um 14:39 schrieb Mark Brown : On Wed, Dec 01, 2021 at 01:02:45PM +, Paul Cercueil wrote: Le mar., nov. 30 2021 at 22:26:37 +0100, H. Nikolaus Schaller + regulator = d

Re: [PATCH v2 3/3] drm/etnaviv: use a 32 bit mask as coherent DMA mask

2021-12-01 Thread Robin Murphy
On 2021-12-01 13:41, Lucas Stach wrote: Hi Robin, Am Mittwoch, dem 01.12.2021 um 12:50 + schrieb Robin Murphy: Sorry I missed this earlier... On 2021-09-07 17:49, Michael Walle wrote: The STLB and the first command buffer (which is used to set up the TLBs) has a 32 bit size restriction in

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread H. Nikolaus Schaller
Hi Paul, > Am 01.12.2021 um 15:03 schrieb Paul Cercueil : > > Hi Nikolaus, Mark, > > Le mer., déc. 1 2021 at 14:51:51 +0100, H. Nikolaus Schaller > a écrit : >> Hi, >>> Am 01.12.2021 um 14:39 schrieb Mark Brown : >>> On Wed, Dec 01, 2021 at 01:02:45PM +, Paul Cercueil wrote: Le mar.,

Re: [PATCH 0/6] drm/tiny/st7735r: Match up with staging/fbtft driver

2021-12-01 Thread Maxime Ripard
Hi Noralf, On Tue, Nov 30, 2021 at 03:30:11PM +0100, Noralf Trønnes wrote: > Den 29.11.2021 10.39, skrev Maxime Ripard: > > On Wed, Nov 24, 2021 at 04:03:07PM -0600, David Lechner wrote: > >> On 11/24/21 9:07 AM, Noralf Trønnes wrote: > > I agree that it doesn't really fit in the DT either though.

Re: [PATCH] drm: Return error codes from struct drm_driver.gem_create_object

2021-12-01 Thread Maxime Ripard
On Tue, Nov 30, 2021 at 10:52:55AM +0100, Thomas Zimmermann wrote: > GEM helper libraries use struct drm_driver.gem_create_object to let > drivers override GEM object allocation. On failure, the call returns > NULL. > > Change the semantics to make the calls return a pointer-encoded error. > This

Re: [PATCH] drm/i915: Force ww lock for i915_gem_object_ggtt_pin_ww, v2.

2021-12-01 Thread Matthew Auld
On Tue, 30 Nov 2021 at 09:21, Maarten Lankhorst wrote: > > We will need the lock to unbind the vma, and wait for bind to complete. > Remove the special casing for the !ww path, and force ww locking for all. > > Changes since v1: > - Pass err to for_i915_gem_ww handling for -EDEADLK handling. > > S

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread Mark Brown
On Wed, Dec 01, 2021 at 03:33:24PM +0100, H. Nikolaus Schaller wrote: > > Am 01.12.2021 um 15:03 schrieb Paul Cercueil : > > Please make it mandatory in DTS then, and use devm_regulator_get() in the > > driver. > Well, I just wonder why the elegant devm_regulator_get_optional() exists at > all

Re: [PATCH v5] drm/radeon/radeon_kms: Fix a NULL pointer dereference in radeon_driver_open_kms()

2021-12-01 Thread Christian König
Am 01.12.21 um 16:13 schrieb Zhou Qingyang: In radeon_driver_open_kms(), radeon_vm_bo_add() is assigned to vm->ib_bo_va and passes and used in radeon_vm_bo_set_addr(). In radeon_vm_bo_set_addr(), there is a dereference of vm->ib_bo_va, which could lead to a NULL pointer dereference on failure of

Re: [PATCH] drm: Return error codes from struct drm_driver.gem_create_object

2021-12-01 Thread Steven Price
On 30/11/2021 09:52, Thomas Zimmermann wrote: > GEM helper libraries use struct drm_driver.gem_create_object to let > drivers override GEM object allocation. On failure, the call returns > NULL. > > Change the semantics to make the calls return a pointer-encoded error. > This aligns the callback w

Re: [PATCH v4 4/4] arm64: dts: qcom: sc7280: Add Display Port node

2021-12-01 Thread Bjorn Andersson
On Mon 22 Nov 05:29 CST 2021, Sankeerth Billakanti wrote: > From: Kuogee Hsieh > > Signed-off-by: Kuogee Hsieh > Reviewed-by: Stephen Boyd > Signed-off-by: Sankeerth Billakanti Can you please update this to make From: and Signed-off-by: match. Also I don't know how you prepared this patch

Re: [PATCH v4 1/4] arm64: dts: qcom: sc7280: add display dt nodes

2021-12-01 Thread Bjorn Andersson
On Mon 22 Nov 05:26 CST 2021, Sankeerth Billakanti wrote: > From: Krishna Manikandan > > Add mdss and mdp DT nodes for sc7280. > > Signed-off-by: Krishna Manikandan > Reported-by: kernel test robot > Reviewed-by: Stephen Boyd > Reported-by: kernel test robot > Signed-off-by: Sankeerth Billa

Re: [PATCH v4 1/4] arm64: dts: qcom: sc7280: add display dt nodes

2021-12-01 Thread Bjorn Andersson
On Mon 22 Nov 05:26 CST 2021, Sankeerth Billakanti wrote: > From: Krishna Manikandan > > Add mdss and mdp DT nodes for sc7280. > > Signed-off-by: Krishna Manikandan > Reported-by: kernel test robot Sorry, missed this one before sending my reply. "kernel test robot" did not report the lack o

Re: [PATCH v4 2/4] arm64: dts: qcom: sc7280: Add DSI display nodes

2021-12-01 Thread Bjorn Andersson
On Mon 22 Nov 05:26 CST 2021, Sankeerth Billakanti wrote: > From: Krishna Manikandan > > Add DSI controller and PHY nodes for sc7280. > > Signed-off-by: Rajeev Nandan > Signed-off-by: Krishna Manikandan > Reviewed-by: Matthias Kaehlcke > Reviewed-by: Stephen Boyd > Signed-off-by: Sankeerth

[PATCH 1/3] drm/ast: Handle failed I2C initialization gracefully

2021-12-01 Thread Thomas Zimmermann
I2C initialization is allowed to fail. In this case, create a connector without DDC adapter. The current code would dereference a NULL pointer. Reading the modes from the connector is supposed to work without I2C adapter. Add the respective test. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[PATCH 2/3] drm/ast: Convert I2C code to managed cleanup

2021-12-01 Thread Thomas Zimmermann
Release the I2C adapter as part of the DRM device cleanup. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 36 +++--- 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c

[PATCH 0/3] ast: Fix I2C corner cases wrt init/cleanup

2021-12-01 Thread Thomas Zimmermann
The VGA connector in ast is supposed to work without I2C. Currently, this isn't correctly implemented in several places. Fix this. Also add managed cleanup of the I2C code, and fail if the connector setup fail. Tested on AST2100 hardware. Thomas Zimmermann (3): drm/ast: Handle failed I2C initia

[PATCH 3/3] drm/ast: Fail if connector initialization fails

2021-12-01 Thread Thomas Zimmermann
Update the connector code to fail if the connector could not be initialized. The current code just ignored the error and failed later when the connector was supposed to be used. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 13 - 1 file changed, 8 insertions(+

Re: [PATCH v4 3/4] arm64: dts: qcom: sc7280: add edp display dt nodes

2021-12-01 Thread Bjorn Andersson
On Mon 22 Nov 05:26 CST 2021, Sankeerth Billakanti wrote: > Add edp controller and phy DT nodes for sc7280. > > Signed-off-by: Krishna Manikandan If Krishna authored the patch (he certified its origin first), then he should be From: as well. > Reviewed-by: Stephen Boyd > Signed-off-by: Sankee

Re: [PATCH] drm/komeda: Fix an undefined behavior bug in komeda_plane_add()

2021-12-01 Thread Steven Price
On 30/11/2021 14:25, Zhou Qingyang wrote: > In komeda_plane_add(), komeda_get_layer_fourcc_list() is assigned to > formats and used in drm_universal_plane_init(). > drm_universal_plane_init() passes formats to > __drm_universal_plane_init(). __drm_universal_plane_init() further > passes formats to

Re: [PATCH v2] drm/gma500/cdv: Fix a wild pointer dereference in cdv_intel_dp_get_modes()

2021-12-01 Thread Patrik Jakobsson
On Wed, Dec 1, 2021 at 4:29 PM Zhou Qingyang wrote: > > In cdv_intel_dp_get_modes(), the third return value of > drm_mode_duplicate() is assigned to mode and used in > drm_mode_probed_add(). drm_mode_probed_add() passes mode->head to > list_add_tail(). list_add_tail() will further call __list_add(

Re: [PATCH 09/12] arm64: dts: rockchip: rk356x: Add HDMI nodes

2021-12-01 Thread Sascha Hauer
On Wed, Nov 17, 2021 at 09:13:33AM -0600, Rob Herring wrote: > On Wed, Nov 17, 2021 at 8:34 AM Sascha Hauer wrote: > > > > Add support for the HDMI port found on RK3568. > > > > Signed-off-by: Sascha Hauer > > --- > > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 65 > > 1

[PATCH v4 2/6] drm: improve drm_buddy_alloc function

2021-12-01 Thread Arunpravin
- Make drm_buddy_alloc a single function to handle range allocation and non-range allocation demands - Implemented a new function alloc_range() which allocates the requested power-of-two block comply with range limitations - Moved order computation and memory alignment logic from i915 drive

[PATCH v4 3/6] drm: implement top-down allocation method

2021-12-01 Thread Arunpravin
Implemented a function which walk through the order list, compares the offset and returns the maximum offset block, this method is unpredictable in obtaining the high range address blocks which depends on allocation and deallocation. for instance, if driver requests address at a low specific range,

[PATCH v4 1/6] drm: move the buddy allocator from i915 into common drm

2021-12-01 Thread Arunpravin
Move the base i915 buddy allocator code into drm - Move i915_buddy.h to include/drm - Move i915_buddy.c to drm root folder - Rename "i915" string with "drm" string wherever applicable - Rename "I915" string with "DRM" string wherever applicable - Fix header file dependencies - Fix alignment issues

[PATCH v4 4/6] drm: implement a method to free unused pages

2021-12-01 Thread Arunpravin
On contiguous allocation, we round up the size to the *next* power of 2, implement a function to free the unused pages after the newly allocate block. v2(Matthew Auld): - replace function name 'drm_buddy_free_unused_pages' with drm_buddy_block_trim - replace input argument name 'actual_siz

[PATCH v4 6/6] drm/amdgpu: add drm buddy support to amdgpu

2021-12-01 Thread Arunpravin
- Remove drm_mm references and replace with drm buddy functionalities - Add res cursor support for drm buddy v2(Matthew Auld): - replace spinlock with mutex as we call kmem_cache_zalloc (..., GFP_KERNEL) in drm_buddy_alloc() function - lock drm_buddy_block_trim() function as it calls

[PATCH v4 5/6] drm/amdgpu: move vram inline functions into a header

2021-12-01 Thread Arunpravin
Move shared vram inline functions and structs into a header file Signed-off-by: Arunpravin --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h | 51 1 file changed, 51 insertions(+) create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h diff --git a/drivers/gpu/drm/a

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread H. Nikolaus Schaller
Hi Mark, > Am 01.12.2021 um 16:10 schrieb Mark Brown : > > On Wed, Dec 01, 2021 at 03:33:24PM +0100, H. Nikolaus Schaller wrote: >>> Am 01.12.2021 um 15:03 schrieb Paul Cercueil : > >>> Please make it mandatory in DTS then, and use devm_regulator_get() in the >>> driver. > >> Well, I just won

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread Mark Brown
On Wed, Dec 01, 2021 at 05:53:03PM +0100, H. Nikolaus Schaller wrote: > > Am 01.12.2021 um 16:10 schrieb Mark Brown : > > Again, if the supply can be physically absent that is a sensible use > > case but that means completely absent, not just not software > > controllable. We can represent fixed

Re: [PATCH v2 2/3] drm/etnaviv: add pci device driver support

2021-12-01 Thread Lucas Stach
Hi Sui, Am Mittwoch, dem 01.12.2021 um 19:35 +0800 schrieb Sui Jingfeng: > From: suijingfeng > > v2: update commits and provide more material. > > There is a Vivante GC1000 V5037 in LS2K1000 and LS7A1000, > the gpu in those chip is a PCI device not platform one. > This GPU have 2D and 3

Re: [PATCH] fix a NULL pointer dereference in amdgpu_connector_lcd_native_mode()

2021-12-01 Thread Alex Deucher
On Tue, Nov 30, 2021 at 6:24 AM Zhou Qingyang wrote: > > In amdgpu_connector_lcd_native_mode(), the return value of > drm_mode_duplicate() is assigned to mode, and there is a dereference > of it in amdgpu_connector_lcd_native_mode(), which will lead to a NULL > pointer dereference on failure of dr

Re: [PATCH] drm/radeon/radeon_connectors: Fix a NULL pointer dereference in radeon_fp_native_mode()

2021-12-01 Thread Alex Deucher
On Tue, Nov 30, 2021 at 9:49 AM Zhou Qingyang wrote: > > In radeon_fp_native_mode(), the return value of drm_mode_duplicate() is > assigned to mode and there is a dereference of it in > radeon_fp_native_mode(), which could lead to a NULL pointer > dereference on failure of drm_mode_duplicate(). >

[PATCH] drm/msm: Initialize MDSS irq domain at probe time

2021-12-01 Thread Dmitry Baryshkov
Since commit 8f59ee9a570c ("drm/msm/dsi: Adjust probe order"), the DSI host gets initialized earlier, but this caused unability to probe the entire stack of components because they all depend on interrupts coming from the main `mdss` node (mdp5, or dpu1). To fix this issue, move mdss device initia

Re: [PATCH v4 4/4] drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read failed

2021-12-01 Thread khsieh
On 2021-11-24 23:32, Dmitry Baryshkov wrote: On 04/05/2021 07:35, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-04-21 16:37:38) Add checking aux read/write status at both dp_link_parse_sink_count() and dp_link_parse_sink_status_filed() to avoid long timeout delay if s/filed/field/ dp aux r

[PATCH v2 0/2] staging: fbtft: add and use macro FBTFT_REGISTER_SPI_DRIVER

2021-12-01 Thread Heiner Kallweit
After 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT compatible") we need to add spi id_tables. Changing existing macro FBTFT_REGISTER_DRIVER would have meant to change arguments and therefore adjust all fbtft drivers. This series adds a new and simplified macro FBTFT_REGISTER_SPI_D

[PATCH v2 1/2] staging: fbtft: add macro FBTFT_REGISTER_SPI_DRIVER

2021-12-01 Thread Heiner Kallweit
After 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT compatible") we need to add spi id_tables. Changing existing macro FBTFT_REGISTER_DRIVER would have meant to change arguments and therefore adjust all fbtft drivers. This patch adds a new and simplified macro FBTFT_REGISTER_SPI_DR

[PATCH v2 2/2] staging: fbtft: sh1106: use new macro FBTFT_REGISTER_SPI_DRIVER

2021-12-01 Thread Heiner Kallweit
Make fb_sh1106 the first user of new macro FBTFT_REGISTER_SPI_DRIVER. In addition the MODULE_ALIASes can be removed. Module auto-loading was successfully tested with a SH1106-based OLED module connected to an Odroid C2. Signed-off-by: Heiner Kallweit --- drivers/staging/fbtft/fb_sh1106.c | 7 +--

Re: [PATCH] drm/komeda: Fix an undefined behavior bug in komeda_plane_add()

2021-12-01 Thread Liviu Dudau
On Wed, Dec 01, 2021 at 03:44:03PM +, Steven Price wrote: > On 30/11/2021 14:25, Zhou Qingyang wrote: > > In komeda_plane_add(), komeda_get_layer_fourcc_list() is assigned to > > formats and used in drm_universal_plane_init(). > > drm_universal_plane_init() passes formats to > > __drm_universal

Re: [PATCH 1/6] dt-bindings: display: sitronix,st7735r: Fix backlight in example

2021-12-01 Thread Rob Herring
On Wed, 24 Nov 2021 16:07:52 +0100, Noralf Trønnes wrote: > The backlight property was lost during conversion to yaml in commit > abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert to DT schema"). > Put it back. > > Fixes: abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert

Re: [PATCH 2/6] dt-bindings: display: sitronix,st7735r: Make reset-gpios optional

2021-12-01 Thread Rob Herring
On Wed, 24 Nov 2021 16:07:53 +0100, Noralf Trønnes wrote: > There are other ways than using a gpio to reset the controller so make > this property optional. > > Signed-off-by: Noralf Trønnes > --- > Documentation/devicetree/bindings/display/sitronix,st7735r.yaml | 1 - > 1 file changed, 1 deleti

Re: [PATCH 3/6] dt-bindings: display: sitronix,st7735r: Remove spi-max-frequency limit

2021-12-01 Thread Rob Herring
On Wed, 24 Nov 2021 16:07:54 +0100, Noralf Trønnes wrote: > The datasheet lists the minimum Serial clock cycle (Write) as 66ns which is > 15MHz. Mostly it can do much better than that and is in fact often run at > 32MHz. With a clever driver that runs configuration commands at a low speed > and onl

[PATCH v3.1 2/2] drm: rcar-du: Add R-Car DSI driver

2021-12-01 Thread Laurent Pinchart
From: LUU HOAI The driver supports the MIPI DSI/CSI-2 TX encoder found in the R-Car V3U SoC. It currently supports DSI mode only. Signed-off-by: LUU HOAI Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Tested-by: Kieran Bingham Acked-by: Sam Ravnborg --- Changes since v3: - Use

Re: [PATCH v3 2/2] drm: rcar-du: Add R-Car DSI driver

2021-12-01 Thread Laurent Pinchart
Hi Kieran, On Wed, Dec 01, 2021 at 10:40:07AM +, Kieran Bingham wrote: > Quoting Laurent Pinchart (2021-12-01 05:24:06) > > From: LUU HOAI > > > > The driver supports the MIPI DSI/CSI-2 TX encoder found in the R-Car V3U > > SoC. It currently supports DSI mode only. > > > > Signed-off-by: LU

Re: [PATCH 4/6] dt-bindings: display: sitronix,st7735r: Add initialization properties

2021-12-01 Thread Rob Herring
On Wed, Nov 24, 2021 at 04:07:55PM +0100, Noralf Trønnes wrote: > Add initialization properties that are commonly used to initialize the > controller for a specific display panel. It is common for displays to have > a datasheet listing the necessary controller settings or some example code > doing

[PATCH v1 1/8] drm/msm/dpu: move disable_danger out of plane subdir

2021-12-01 Thread Dmitry Baryshkov
The disable_danger debugfs file is not related to a single plane. Instead it is used by all registered planes. Move it from plane subtree to the global subtree next to danger_status and safe_status files, so that the new file supplements them. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/

[PATCH v1 0/8] drm/msm/dpu: cleanup debugfs code

2021-12-01 Thread Dmitry Baryshkov
This patchset provides a partial rework/cleanup/fixup of debugfs code in DPU driver. It started as a single patch removing (and then just moving) SSPP debugfs code from the plane (as planes are going to be less connected with SSPP blocks soon). However the more I touched this code, the more patches

[PATCH v1 2/8] drm/msm/dpu: fix safe status debugfs file

2021-12-01 Thread Dmitry Baryshkov
Make safe_status debugfs fs file actually return safe status rather than danger status data. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH v1 3/8] drm/msm/dpu: make danger_status/safe_status readable

2021-12-01 Thread Dmitry Baryshkov
Change \t to \n in the print format to stop putting all SSPP status in a single line. Splitting it to one SSPP per line is much more readable. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/g

[PATCH v1 4/8] drm/msm/dpu: drop plane's default_scaling debugfs file

2021-12-01 Thread Dmitry Baryshkov
Proper support for the 'default_scaling' debugfs file was removed during DPU driver pre-merge cleanup. Remove leftover file. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_pla

  1   2   >