Re: [PATCH v2 6/6] drm/msm/a6xx: Add a few gmu buffers to coredump

2021-11-24 Thread kernel test robot
Hi Akhil, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip v5.16-rc2 next-20211124] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v4] drm/ttm: Clarify that the TTM_PL_SYSTEM is under TTMs control

2021-11-24 Thread Christian König
Am 10.11.21 um 15:50 schrieb Zack Rusin: TTM takes full control over TTM_PL_SYSTEM placed buffers. This makes driver internal usage of TTM_PL_SYSTEM prone to errors because it requires the drivers to manually handle all interactions between TTM which can swap out those buffers whenever it thinks

Re: completely rework the dma_resv semantic

2021-11-24 Thread Pekka Paalanen
On Tue, 23 Nov 2021 15:20:45 +0100 "Christian König" wrote: > Hi guys, > > as discussed before this set of patches completely rework the dma_resv > semantic > and spreads the new handling over all the existing drivers and users. > > First of all this drops the DAG approach because it requires

Re: completely rework the dma_resv semantic

2021-11-24 Thread Christian König
Am 24.11.21 um 09:31 schrieb Pekka Paalanen: On Tue, 23 Nov 2021 15:20:45 +0100 "Christian König" wrote: Hi guys, as discussed before this set of patches completely rework the dma_resv semantic and spreads the new handling over all the existing drivers and users. First of all this drops the

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gt: Spread virtual engines over idle engines

2021-11-24 Thread Tvrtko Ursulin
On 23/11/2021 19:52, Rodrigo Vivi wrote: On Tue, Nov 23, 2021 at 09:39:25AM +, Tvrtko Ursulin wrote: On 17/11/2021 22:49, Vinay Belgaumkar wrote: From: Chris Wilson Everytime we come to the end of a virtual engine's context, re-randomise it's siblings[]. As we schedule the siblings' ta

Re: [PATCH v8 3/8] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema

2021-11-24 Thread Paul Cercueil
Hi Nikolaus, Le mar., nov. 23 2021 at 19:13:56 +0100, H. Nikolaus Schaller a écrit : From: Sam Ravnborg Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. Based on .txt binding from Zubair Lutfullah Kakakhel We also add generic ddc-i2c-bus to synopsys,dw-hdmi.yaml Signed-off-b

Re: [PATCH] drm/i915/dmabuf: remove duplicate include in i915_gem_dmabuf.c

2021-11-24 Thread Jani Nikula
On Wed, 24 Nov 2021, cgel@gmail.com wrote: > From: Yao Jing > > 'asm/smp.h' included in 'drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c' is > duplicated. It is clearly included on the 12 line. > > Reported-by: Zeal Robot > Signed-off-by: Yao Jing The correct fix is [1]. If you keep sending pat

Re: [PATCH v2 6/8] inotify: simplify subdirectory registration with register_sysctl()

2021-11-24 Thread Jan Kara
On Tue 23-11-21 12:24:20, Luis Chamberlain wrote: > From: Xiaoming Ni > > There is no need to user boiler plate code to specify a set of base > directories we're going to stuff sysctls under. Simplify this by using > register_sysctl() and specifying the directory path directly. > > Move inotify_

Re: [PATCH v2 4/8] ocfs2: simplify subdirectory registration with register_sysctl()

2021-11-24 Thread Jan Kara
On Tue 23-11-21 12:24:18, Luis Chamberlain wrote: > There is no need to user boiler plate code to specify a set of base > directories we're going to stuff sysctls under. Simplify this by using > register_sysctl() and specifying the directory path directly. > > // pycocci sysctl-subdir-register-sys

[PATCH] drm/amd/display: Fix warning comparing pointer to 0

2021-11-24 Thread Jiapeng Chong
Fix the following coccicheck warning: ./drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c:96:14-15: WARNING comparing pointer to 0. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH v2 4/6] drm/msm/a6xx: Capture gmu log in devcoredump

2021-11-24 Thread Akhil P Oommen
On 11/24/2021 4:33 AM, Bjorn Andersson wrote: On Tue 23 Nov 13:17 PST 2021, Akhil P Oommen wrote: Capture gmu log in coredump to enhance debugging. Signed-off-by: Akhil P Oommen --- Changes in v2: - Fix kernel test robot's warning about size_t's format specifier drivers/gpu/drm/msm/adreno

Re: [PATCH v3 2/6] drm: improve drm_buddy_alloc function

2021-11-24 Thread Matthew Auld
On 23/11/2021 22:39, Arunpravin wrote: On 18/11/21 12:09 am, Matthew Auld wrote: On 16/11/2021 20:18, Arunpravin wrote: - Make drm_buddy_alloc a single function to handle range allocation and non-range allocation demands - Implemented a new function alloc_range() which allocates the

[PATCH v3 1/2] drm/msm/a6xx: Fix uinitialized use of gpu_scid

2021-11-24 Thread Akhil P Oommen
Avoid a possible uninitialized use of gpu_scid variable to fix the below smatch warning: drivers/gpu/drm/msm/adreno/a6xx_gpu.c:1480 a6xx_llc_activate() error: uninitialized symbol 'gpu_scid'. Reported-by: Dan Carpenter Signed-off-by: Akhil P Oommen --- Reposting this patch again

[PATCH v3 2/2] drm/msm/a6xx: Capture gmu log in devcoredump

2021-11-24 Thread Akhil P Oommen
Capture gmu log in coredump to enhance debugging. Signed-off-by: Akhil P Oommen --- Changes in v3: - Fix style and a minor suggestion from Bjorn Changes in v2: - Fix kernel test robot's warning about size_t's format specifier drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 40 ++

[RE]: [PATCH v3 10/10] vfio/ccw: Move the lifecycle of the struct vfio_ccw_private to the mdev

2021-11-24 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Fri, 1 Oct 2021 14:52:51 -0300 > > The css_driver's main purpose is to create/destroy the mdev and relay the > shutdown, irq, sch_event, and chp_event css_driver ops to the single > created vfio_device, if it exists. > > Reframe the boundary where the css_driver do

Re: [PATCH v2 6/6] drm/msm/a6xx: Add a few gmu buffers to coredump

2021-11-24 Thread kernel test robot
Hi Akhil, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip v5.16-rc2 next-20211124] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v2] drm/bridge: anx7625: Fix edid_read break case in sp_tx_edid_read()

2021-11-24 Thread Robert Foss
On Fri, 19 Nov 2021 at 02:55, Xin Ji wrote: > > On Fri, Nov 19, 2021 at 03:30:02AM +0800, Hsin-Yi Wang wrote: > > edid_read() was assumed to return 0 on success. After > > 7f16d0f3b8e2("drm/bridge: anx7625: Propagate errors from sp_tx_rst_aux()"), > > the function will return > 0 for successful ca

drm/ttm: moving the LRU into the resource

2021-11-24 Thread Christian König
Hi guys, I've already send out this patch set a couple of times. This fixes the fundamental problem in TTM that during a move a buffer has resources allocated from two different domains at the same time. Additional to that it's a prerequisite to remove ghost objects and allow to allocate multipl

[PATCH 02/12] drm/ttm: add back a reference to the bdev to the res manager

2021-11-24 Thread Christian König
It is simply a lot cleaner to have this around instead of adding the device throughout the call chain. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.

[PATCH 07/12] drm/radeon: use ttm_resource_manager_debug

2021-11-24 Thread Christian König
Instead of calling the debug operation directly. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index 11b21d605584..0d1283cdc

[PATCH 06/12] drm/ttm: add resource iterator

2021-11-24 Thread Christian König
Instead of duplicating that at different places add an iterator over all the resources in a resource manager. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 41 +++ drivers/gpu/drm/ttm/ttm_device.c | 26 - drivers/gpu/drm/ttm/ttm

[PATCH 01/12] drm/ttm: add ttm_resource_fini

2021-11-24 Thread Christian König
Make sure we call the common cleanup function in all implementations of the resource manager. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c| 2 ++

[PATCH 05/12] drm/ttm: move the LRU into resource handling v2

2021-11-24 Thread Christian König
This way we finally fix the problem that new resource are not immediately evict-able after allocation. That has caused numerous problems including OOM on GDS handling and not being able to use TTM as general resource manager. v2: stop assuming in ttm_resource_fini that res->bo is still valid. Si

[PATCH 04/12] drm/ttm: add common accounting to the resource mgr v2

2021-11-24 Thread Christian König
It makes sense to have this in the common manager for debugging and accounting of how much resources are used. v2: cleanup kerneldoc a bit Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_resource.c | 8 include/drm/ttm/ttm_resource.h | 20 +++- 2 files c

[PATCH 08/12] drm/radeon: remove resource accounting

2021-11-24 Thread Christian König
Use the one provided by TTM instead. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon.h| 2 -- drivers/gpu/drm/radeon/radeon_kms.c| 7 -- drivers/gpu/drm/radeon/radeon_object.c | 30 +++--- drivers/gpu/drm/radeon/radeon_object.h | 1 - drive

[PATCH 10/12] drm/amdgpu: remove GTT accounting

2021-11-24 Thread Christian König
This is provided by TTM now. Also switch man->size to bytes instead of pages and fix the double printing of size and usage in debugfs. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 50 + drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 5 +--

[PATCH 03/12] drm/ttm: add a weak BO reference to the resource v3

2021-11-24 Thread Christian König
Keep track for which BO a resource was allocated. This is necessary to move the LRU handling into the resources. A bit problematic is i915 since it tries to use the resource interface without a BO which is illegal from the conceptional point of view. v2: Document that this is a weak reference and

[PATCH 11/12] drm/amdgpu: remove VRAM accounting

2021-11-24 Thread Christian König
This is provided by TTM now. Also switch man->size to bytes instead of pages and fix the double printing of size and usage in debugfs. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 5 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/a

[PATCH 12/12] drm/amdgpu: drop amdgpu_gtt_node

2021-11-24 Thread Christian König
We have the BO pointer in the base structure now as well. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 49 - 1 file changed, 18 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c b/drivers/gpu/drm/amd/

[PATCH 09/12] drm/amdgpu: use ttm_resource_manager_debug

2021-11-24 Thread Christian König
Instead of calling the debug operation directly. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index 9be5

[PATCH 5.15 226/279] drm/cma-helper: Release non-coherent memory with dma_free_noncoherent()

2021-11-24 Thread Greg Kroah-Hartman
From: Thomas Zimmermann commit 995f54ea962e03ec08b8bc6a4fe11a32b420edd3 upstream. The GEM CMA helpers allocate non-coherent (i.e., cached) backing storage with dma_alloc_noncoherent(), but release it with dma_free_wc(). Fix this with a call to dma_free_noncoherent(). Writecombining storage is st

[PATCH 5.15 247/279] drm/prime: Fix use after free in mmap with drm_gem_ttm_mmap

2021-11-24 Thread Greg Kroah-Hartman
From: Anand K Mistry commit 8244a3bc27b3efd057da154b8d7e414670d5044f upstream. drm_gem_ttm_mmap() drops a reference to the gem object on success. If the gem object's refcount == 1 on entry to drm_gem_prime_mmap(), that drop will free the gem object, and the subsequent drm_gem_object_get() will b

[Bug 211807] [drm:drm_dp_mst_dpcd_read] *ERROR* mstb 000000004e6288dd port 3: DPCD read on addr 0x60 for 1 bytes NAKed

2021-11-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211807 Chatty (m...@chatty.de) changed: What|Removed |Added CC||m...@chatty.de --- Comment #17

Re: [PATCH v2 12/63] thermal: intel: int340x_thermal: Use struct_group() for memcpy() region

2021-11-24 Thread Rafael J. Wysocki
On Wed, Nov 24, 2021 at 12:53 AM Srinivas Pandruvada wrote: > > On Tue, 2021-11-23 at 14:19 +0100, Rafael J. Wysocki wrote: > > On Wed, Aug 18, 2021 at 8:08 AM Kees Cook > > wrote: > > > > > > In preparation for FORTIFY_SOURCE performing compile-time and run- > > > time > > > field bounds checkin

Re: [PATCH v2 6/8] inotify: simplify subdirectory registration with register_sysctl()

2021-11-24 Thread Luis Chamberlain
On Wed, Nov 24, 2021 at 10:44:09AM +0100, Jan Kara wrote: > On Tue 23-11-21 12:24:20, Luis Chamberlain wrote: > > From: Xiaoming Ni > > > > There is no need to user boiler plate code to specify a set of base > > directories we're going to stuff sysctls under. Simplify this by using > > register_s

Re: [PATCH v6 7/7] drm/mediatek: Add mt8195 DisplayPort driver

2021-11-24 Thread Guillaume Ranquet
Hi, Thanks for all your input, really appreciated. Quoting Maxime Ripard (2021-11-16 15:51:12) > Hi, > > On Mon, Nov 15, 2021 at 09:33:52AM -0500, Guillaume Ranquet wrote: > > Quoting Maxime Ripard (2021-11-15 11:11:29) > > > > The driver creates a child device for the phy. The child device will >

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gt: Spread virtual engines over idle engines

2021-11-24 Thread Rodrigo Vivi
On Wed, Nov 24, 2021 at 08:56:52AM +, Tvrtko Ursulin wrote: > > On 23/11/2021 19:52, Rodrigo Vivi wrote: > > On Tue, Nov 23, 2021 at 09:39:25AM +, Tvrtko Ursulin wrote: > > > > > > On 17/11/2021 22:49, Vinay Belgaumkar wrote: > > > > From: Chris Wilson > > > > > > > > Everytime we come

Re: [PATCH 1/9] gpu: host1x: Add missing DMA API include

2021-11-24 Thread Robin Murphy
On 2021-11-23 14:10, Robin Murphy wrote: Host1x seems to be relying on picking up dma-mapping.h transitively from iova.h, which has no reason to include it in the first place. Fix the former issue before we totally break things by fixing the latter one. CC: Thierry Reding CC: Mikko Perttunen C

Re: [PATCH v6 6/7] phy: phy-mtk-dp: Add driver for DP phy

2021-11-24 Thread Guillaume Ranquet
Hi Chunfeng, Quoting Chunfeng Yun (2021-11-13 08:48:37) > On Wed, 2021-11-10 at 14:06 +0100, Guillaume Ranquet wrote: > > From: Markus Schneider-Pargmann > > > > This is a new driver that supports the integrated DisplayPort phy for > > mediatek SoCs, especially the mt8195. The phy is integrated i

[PATCH] drm/i915/gvt: Prevent integer overflow in intel_vgpu_emulate_cfg_write()

2021-11-24 Thread Dan Carpenter
The "offset" is a u32 that comes from the user. The bug is that the "offset + bytes" operation can have an integer overflow problem which leads to an out of bounds access. Fixes: 4d60c5fd3f87 ("drm/i915/gvt: vGPU PCI configuration space virtualization") Signed-off-by: Dan Carpenter --- drivers

[PATCH] drm/bridge: anx7625: fix an error code in anx7625_register_audio()

2021-11-24 Thread Dan Carpenter
This code accidentally returns IS_ERR(), which is 1, instead of propagating the negative error code. The caller doesn't check for errors so it doesn't affect run time at all. Fixes: 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/br

Re: [PATCH 1/2] drm: exynos: dsi: Convert to bridge driver

2021-11-24 Thread Marek Szyprowski
; 1380.decon not bound >>> 1388.decon not bound >>> 1393.mic not bound >>> (unknown) not registered >>>

Re: [PATCH 1/2] drm: exynos: dsi: Convert to bridge driver

2021-11-24 Thread Jagan Teki
---- > >>> 1380.decon not bound > >>> 1388.decon not bound > >>> 1393.micnot bound > >>> (unknown)

[PATCH 1/6] dt-bindings: display: sitronix, st7735r: Fix backlight in example

2021-11-24 Thread Noralf Trønnes
The backlight property was lost during conversion to yaml in commit abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert to DT schema"). Put it back. Fixes: abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert to DT schema") Signed-off-by: Noralf Trønnes --- Documentation/de

[PATCH 2/6] dt-bindings: display: sitronix, st7735r: Make reset-gpios optional

2021-11-24 Thread Noralf Trønnes
There are other ways than using a gpio to reset the controller so make this property optional. Signed-off-by: Noralf Trønnes --- Documentation/devicetree/bindings/display/sitronix,st7735r.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/sitronix,s

[PATCH 3/6] dt-bindings: display: sitronix, st7735r: Remove spi-max-frequency limit

2021-11-24 Thread Noralf Trønnes
The datasheet lists the minimum Serial clock cycle (Write) as 66ns which is 15MHz. Mostly it can do much better than that and is in fact often run at 32MHz. With a clever driver that runs configuration commands at a low speed and only the pixel data at the maximum speed the configuration can't be m

[PATCH 4/6] dt-bindings: display: sitronix, st7735r: Add initialization properties

2021-11-24 Thread Noralf Trønnes
Add initialization properties that are commonly used to initialize the controller for a specific display panel. It is common for displays to have a datasheet listing the necessary controller settings or some example code doing the same. These settings can be matched directly to the DT properties.

[PATCH 5/6] drm/mipi-dbi: Add device property functions

2021-11-24 Thread Noralf Trønnes
Add helper functions for configuring a MIPI DBI controller from device properties. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_mipi_dbi.c | 139 + include/drm/drm_mipi_dbi.h | 3 + 2 files changed, 142 insertions(+) diff --git a/drivers/gpu/drm/dr

[PATCH 0/6] drm/tiny/st7735r: Match up with staging/fbtft driver

2021-11-24 Thread Noralf Trønnes
Hi, This patchset adds a missing piece for decommissioning the staging/fbtft/fb_st7735r.c driver namely a way to configure the controller from Device Tree. All fbtft drivers have builtin support for one display panel and all other panels using that controller are configured using the Device Tree

[PATCH 6/6] drm: tiny: st7735r: Support DT initialization of controller

2021-11-24 Thread Noralf Trønnes
Add support for initializing the controller from device properties when the compatible is "sitronix,st7735r". The rotation property does not apply in this case since a matching ADDRESS_MODE/madctl value is necessary. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tiny/st7735r.c | 87

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gt: Spread virtual engines over idle engines

2021-11-24 Thread Rodrigo Vivi
On Wed, Nov 24, 2021 at 08:55:39AM -0500, Rodrigo Vivi wrote: > On Wed, Nov 24, 2021 at 08:56:52AM +, Tvrtko Ursulin wrote: > > > > On 23/11/2021 19:52, Rodrigo Vivi wrote: > > > On Tue, Nov 23, 2021 at 09:39:25AM +, Tvrtko Ursulin wrote: > > > > > > > > On 17/11/2021 22:49, Vinay Belgaum

Re: [PATCH] MAINTAINERS: Update email of Andrzej Hajda

2021-11-24 Thread Sylwester Nawrocki
On 18.10.2021 23:13, Andrzej Hajda wrote: > Beside updating email, the patch updates maintainers > of Samsung drivers. > > Signed-off-by: Andrzej Hajda > --- > .mailmap| 1 + > MAINTAINERS | 13 - > 2 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/.mailmap b/.m

Re: linux-next: Tree for Nov 24 (drivers/gpu/drm/amd/display/dc/dsc/rc_calc_dpi.o)

2021-11-24 Thread Randy Dunlap
On 11/23/21 9:16 PM, Stephen Rothwell wrote: Hi all, Changes since 20211123: on i386: ld: drivers/gpu/drm/amd/display/dc/dsc/rc_calc_dpi.o: in function `dscc_compute_dsc_parameters': rc_calc_dpi.c:(.text+0x31f): undefined reference to `__udivdi3' -- ~Randy

Re: [PATCH v3 02/13] drm/msm/disp/dpu1: Add support for DSC

2021-11-24 Thread Dmitry Baryshkov
On 16/11/2021 09:22, Vinod Koul wrote: Display Stream Compression (DSC) is one of the hw blocks in dpu, so add support by adding hw blocks for DSC Signed-off-by: Vinod Koul Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Makefile | 1 + .../gpu/drm/msm/disp/dpu1

Re: [PATCH v3 05/13] drm/msm/disp/dpu1: Don't use DSC with mode_3d

2021-11-24 Thread Dmitry Baryshkov
On 16/11/2021 09:22, Vinod Koul wrote: We cannot enable mode_3d when we are using the DSC. So pass configuration to detect DSC is enabled and not enable mode_3d when we are using DSC We add a helper dpu_encoder_helper_get_dsc() to detect dsc enabled and pass this to .setup_intf_cfg() Signed-off

Re: [PATCH v3 05/13] drm/msm/disp/dpu1: Don't use DSC with mode_3d

2021-11-24 Thread Dmitry Baryshkov
On 16/11/2021 09:22, Vinod Koul wrote: We cannot enable mode_3d when we are using the DSC. So pass configuration to detect DSC is enabled and not enable mode_3d when we are using DSC We add a helper dpu_encoder_helper_get_dsc() to detect dsc enabled and pass this to .setup_intf_cfg() Signed-off

Re: [PATCH v3 06/13] drm/msm/disp/dpu1: Add DSC support in hw_ctl

2021-11-24 Thread Dmitry Baryshkov
On 16/11/2021 09:22, Vinod Koul wrote: Later gens of hardware have DSC bits moved to hw_ctl, so configure these bits so that DSC would work there as well Signed-off-by: Vinod Koul Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 11 ++- 1 file chang

Re: [PATCH v3 05/13] drm/msm/disp/dpu1: Don't use DSC with mode_3d

2021-11-24 Thread Dmitry Baryshkov
On 16/11/2021 09:22, Vinod Koul wrote: We cannot enable mode_3d when we are using the DSC. So pass configuration to detect DSC is enabled and not enable mode_3d when we are using DSC We add a helper dpu_encoder_helper_get_dsc() to detect dsc enabled and pass this to .setup_intf_cfg() Signed-off

Re: [PATCH v3 01/13] drm/msm/dsi: add support for dsc data

2021-11-24 Thread Dmitry Baryshkov
On 16/11/2021 09:22, Vinod Koul wrote: Display Stream Compression (DSC) parameters need to be calculated. Add helpers and struct msm_display_dsc_config in msm_drv for this msm_display_dsc_config uses drm_dsc_config for DSC parameters. Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi_

Re: [PATCH v3 05/13] drm/msm/disp/dpu1: Don't use DSC with mode_3d

2021-11-24 Thread Dmitry Baryshkov
On Wed, 24 Nov 2021 at 18:40, Dmitry Baryshkov wrote: > > On 16/11/2021 09:22, Vinod Koul wrote: > > We cannot enable mode_3d when we are using the DSC. So pass > > configuration to detect DSC is enabled and not enable mode_3d > > when we are using DSC > > > > We add a helper dpu_encoder_helper_ge

Re: [PATCH v3 07/13] drm/msm/disp/dpu1: Add support for DSC in encoder

2021-11-24 Thread Dmitry Baryshkov
On 16/11/2021 09:22, Vinod Koul wrote: We need to configure the encoder for DSC configuration and calculate DSC parameters for the given timing so this patch adds that support by adding dpu_encoder_prep_dsc() which is invoked when DSC is enabled. Signed-off-by: Vinod Koul --- drivers/gpu/drm/

Re: [PATCH v3 09/13] drm/msm/disp/dpu1: Add support for DSC in topology

2021-11-24 Thread Dmitry Baryshkov
On 16/11/2021 09:22, Vinod Koul wrote: For DSC to work we typically need a 2,2,1 configuration. This should suffice for resolutions up to 4k. For more resolutions like 8k this won't work. Also, it is better to use 2 LMs and DSC instances as half width results in lesser power consumption as compa

Re: [PATCH v3 10/13] drm/msm/disp/dpu1: Add DSC support in RM

2021-11-24 Thread Dmitry Baryshkov
On 16/11/2021 09:22, Vinod Koul wrote: This add the bits in RM to enable the DSC blocks Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 66 + drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 1 + 3 fi

Re: [PATCH v2] i2c: tegra: Add ACPI support

2021-11-24 Thread Dmitry Osipenko
24.11.2021 10:18, Akhil R пишет: >> *i2c_dev) >>> i2c_dev->is_vi = true; >>> } >> How are you going to differentiate the VI I2C from a non-VI? This doesn't >> look >> right. > This patch adds the ACPI support to only non-VI I2C. The device_ids in match > table > are added according

Re: [PATCH v8 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-11-24 Thread H. Nikolaus Schaller
> Am 23.11.2021 um 21:05 schrieb Paul Cercueil : > > Hi Nikolaus, > > I keep seeing a few things, sorry. no problem. > > > Le mar., nov. 23 2021 at 19:13:57 +0100, H. Nikolaus Schaller > a écrit : >> From: Paul Boddie >> A specialisation of the generic Synopsys HDMI driver is employed f

Re: [PATCH v8 6/8] MIPS: DTS: CI20: Add DT nodes for HDMI setup

2021-11-24 Thread H. Nikolaus Schaller
> Am 23.11.2021 um 21:10 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le mar., nov. 23 2021 at 19:13:59 +0100, H. Nikolaus Schaller > a écrit : >> From: Paul Boddie >> We need to hook up >> * HDMI connector >> * HDMI power regulator >> * JZ4780_CLK_HDMI @ 27 MHz >> * DDC pinmux >> * HDMI an

Re: [PATCH v8 3/8] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema

2021-11-24 Thread H. Nikolaus Schaller
Hi Rob and Paul, > Am 24.11.2021 um 10:17 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le mar., nov. 23 2021 at 19:13:56 +0100, H. Nikolaus Schaller > a écrit : >> From: Sam Ravnborg >> Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. >> Based on .txt binding from Zubair Lutful

Re: [PATCH v3 12/13] drm/msm/dsi: Add support for DSC configuration

2021-11-24 Thread Dmitry Baryshkov
On 16/11/2021 09:22, Vinod Koul wrote: When DSC is enabled, we need to configure DSI registers accordingly and configure the respective stream compression registers. Add support to calculate the register setting based on DSC params and timing information and configure these registers. Signed-of

Re: [PATCH v8 6/8] MIPS: DTS: CI20: Add DT nodes for HDMI setup

2021-11-24 Thread Geert Uytterhoeven
Hi Nikolaus, On Wed, Nov 24, 2021 at 5:19 PM H. Nikolaus Schaller wrote: > > Am 23.11.2021 um 21:10 schrieb Paul Cercueil : > > Le mar., nov. 23 2021 at 19:13:59 +0100, H. Nikolaus Schaller > > a écrit : > >> +assigned-clock-rates = <4800>, <0>, <5400>, <0>, <2700>; > >> }; > >>

Re: [PATCH v8 3/8] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema

2021-11-24 Thread H. Nikolaus Schaller
> Am 24.11.2021 um 03:59 schrieb Rob Herring : > > On Tue, 23 Nov 2021 19:13:56 +0100, H. Nikolaus Schaller wrote: >> From: Sam Ravnborg >> >> Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. >> Based on .txt binding from Zubair Lutfullah Kakakhel >> >> We also add generic ddc

Re: [PATCH v3 12/13] drm/msm/dsi: Add support for DSC configuration

2021-11-24 Thread Dmitry Baryshkov
On 24/11/2021 19:21, Dmitry Baryshkov wrote: On 16/11/2021 09:22, Vinod Koul wrote: When DSC is enabled, we need to configure DSI registers accordingly and configure the respective stream compression registers. Add support to calculate the register setting based on DSC params and timing informa

Re: [PATCH v3 13/13] drm/msm/dsi: Pass DSC params to drm_panel

2021-11-24 Thread Dmitry Baryshkov
On 16/11/2021 09:22, Vinod Koul wrote: When DSC is enabled, we need to pass the DSC parameters to panel driver as well, so add a dsc parameter in panel and set it when DSC is enabled Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi_host.c | 16 +++- include/drm/drm_panel

Re: [PATCH v8 6/8] MIPS: DTS: CI20: Add DT nodes for HDMI setup

2021-11-24 Thread H. Nikolaus Schaller
Hi Geert, > Am 24.11.2021 um 17:21 schrieb Geert Uytterhoeven : > > Hi Nikolaus, > > On Wed, Nov 24, 2021 at 5:19 PM H. Nikolaus Schaller > wrote: >>> Am 23.11.2021 um 21:10 schrieb Paul Cercueil : >>> Le mar., nov. 23 2021 at 19:13:59 +0100, H. Nikolaus Schaller >>> a écrit : +assi

Re: [PATCH v2 01/11] ASoC: tegra20-spdif: stop setting slave_id

2021-11-24 Thread Dmitry Osipenko
23.11.2021 01:21, Arnd Bergmann пишет: > From: Arnd Bergmann > > The DMA resource is never set up anywhere, and passing this as slave_id > has not been the proper procedure in a long time. > > As a preparation for removing all slave_id references from the ALSA code, > remove this one. > > Accor

RE: [PATCH v2] i2c: tegra: Add ACPI support

2021-11-24 Thread Akhil R
> 24.11.2021 10:18, Akhil R пишет: > >> *i2c_dev) > >>> i2c_dev->is_vi = true; } > >> How are you going to differentiate the VI I2C from a non-VI? This > >> doesn't look right. > > This patch adds the ACPI support to only non-VI I2C. The device_ids in > > match table are added accord

Re: [PATCH v2 01/11] ASoC: tegra20-spdif: stop setting slave_id

2021-11-24 Thread Arnd Bergmann
On Wed, Nov 24, 2021 at 5:32 PM Dmitry Osipenko wrote: > 23.11.2021 01:21, Arnd Bergmann пишет: > > The commit message is correct, however you could remove even more code > here. But there is no need to make a v3 just because this patch because > I already prepared patchset that revives this S/PDI

Re: [PATCH v8 0/8] MIPS: JZ4780 and CI20 HDMI

2021-11-24 Thread H. Nikolaus Schaller
Hi Paul, > Am 23.11.2021 um 21:44 schrieb H. Nikolaus Schaller : > > Hi Paul, > >> Am 23.11.2021 um 21:12 schrieb Paul Cercueil : >> >> Hi Nikolaus, >> >> I think if you can fix the last few things I commented on, and I get an ACK >> from Rob for the Device Tree related patches, then it will

Re: [PATCH v3 13/13] drm/msm/dsi: Pass DSC params to drm_panel

2021-11-24 Thread Dmitry Baryshkov
On 16/11/2021 09:22, Vinod Koul wrote: When DSC is enabled, we need to pass the DSC parameters to panel driver as well, so add a dsc parameter in panel and set it when DSC is enabled Nit: I think patch description is a bit inaccurate, since we pass DSC parameters from panel to DSI host rather

[PATCH 1/2] dt-bindings: display: bridge: Add TI DLPC3433 bindings

2021-11-24 Thread Jagan Teki
TI DLPC3433 is a MIPI DSI based display controller bridge for processing high resolution DMD based projectors. It has a flexible configuration of MIPI DSI signal input produces RGB565, RGB666, RGB888 output format with maximum of 720p resolution in 60 and 120 Hz refresh rates. Add dt-bingings for

[PATCH 2/2] drm: bridge: Add TI DLPC3433

2021-11-24 Thread Jagan Teki
TI DLPC3433 is a MIPI DSI based display controller bridge for processing high resolution DMD based projectors. It has a flexible configuration of MIPI DSI signal input produces RGB565, RGB666, RGB888 output format with maximum of 720p resolution. Add bridge driver for it. Signed-off-by: Christop

Re: [PATCH v2] i2c: tegra: Add ACPI support

2021-11-24 Thread Dmitry Osipenko
24.11.2021 19:40, Akhil R пишет: >> 24.11.2021 10:18, Akhil R пишет: *i2c_dev) > i2c_dev->is_vi = true; } How are you going to differentiate the VI I2C from a non-VI? This doesn't look right. >>> This patch adds the ACPI support to only non-VI I2C. The device_ids i

Re: [PATCH v2 01/11] ASoC: tegra20-spdif: stop setting slave_id

2021-11-24 Thread Dmitry Osipenko
24.11.2021 19:47, Arnd Bergmann пишет: > On Wed, Nov 24, 2021 at 5:32 PM Dmitry Osipenko wrote: >> 23.11.2021 01:21, Arnd Bergmann пишет: >> >> The commit message is correct, however you could remove even more code >> here. But there is no need to make a v3 just because this patch because >> I alr

Re: [PATCH v2 01/11] ASoC: tegra20-spdif: stop setting slave_id

2021-11-24 Thread Dmitry Osipenko
23.11.2021 01:21, Arnd Bergmann пишет: > From: Arnd Bergmann > > The DMA resource is never set up anywhere, and passing this as slave_id > has not been the proper procedure in a long time. > > As a preparation for removing all slave_id references from the ALSA code, > remove this one. > > Accor

Re: [PATCH v8 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-11-24 Thread Paul Cercueil
Hi Nikolaus, Le mer., nov. 24 2021 at 17:13:30 +0100, H. Nikolaus Schaller a écrit : Am 23.11.2021 um 21:05 schrieb Paul Cercueil : Hi Nikolaus, I keep seeing a few things, sorry. no problem. Le mar., nov. 23 2021 at 19:13:57 +0100, H. Nikolaus Schaller a écrit : From: Paul

Re: [PATCH] drm/bridge: megachips: Ensure both bridges are probed before registration

2021-11-24 Thread Martyn Welch
On Tue, 2021-11-23 at 16:18 +0100, Robert Foss wrote: > Hey Martyn, > > On Tue, 16 Nov 2021 at 13:28, Martyn Welch > wrote: > > > > In the configuration used by the b850v3, the STDP2690 is used to read > > EDID > > data whilst it's the STDP4028 which can detect when monitors are > > connected. >

[PATCH] drm/tegra: vic: Fix DMA API misuse

2021-11-24 Thread Robin Murphy
Upon failure, dma_alloc_coherent() returns NULL. If that does happen, passing some uninitialised stack contents to dma_mapping_error() - which belongs to a different API in the first place - has precious little chance of detecting it. Also include the correct header, because the fragile transitive

Re: [PATCH 1/2] dt-bindings: display: bridge: Add TI DLPC3433 bindings

2021-11-24 Thread Fabio Estevam
Hi Jagan, On Wed, Nov 24, 2021 at 2:26 PM Jagan Teki wrote: > > TI DLPC3433 is a MIPI DSI based display controller bridge > for processing high resolution DMD based projectors. > > It has a flexible configuration of MIPI DSI signal input > produces RGB565, RGB666, RGB888 output format with maximu

Re: [PATCH] drm/amd/display: Fix warning comparing pointer to 0

2021-11-24 Thread Rodrigo Siqueira Jordao
On 2021-11-24 5:20 a.m., Jiapeng Chong wrote: Fix the following coccicheck warning: ./drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c:96:14-15: WARNING comparing pointer to 0. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fp

Re: [PATCH v3] drm/msm/dp: employ bridge mechanism for display enable and disable

2021-11-24 Thread Dmitry Baryshkov
On 15/11/2021 21:48, Kuogee Hsieh wrote: Currently the msm_dp_*** functions implement the same sequence which would happen when drm_bridge is used. hence get rid of this intermediate layer and align with the drm_bridge usage to avoid customized implementation. Signed-off-by: Kuogee Hsieh Chang

[PATCH] drm/gud: Fix descriptor magic check

2021-11-24 Thread Noralf Trønnes
le32_to_cpu() was put around the wrong operand in the descriptor magic value check. Fix this and put it around the descriptor value which is the one that is in little endian format. Fixes: 40e1a70 ("drm: Add GUD USB Display driver") Reported-by: kernel test robot Signed-off-by: Noralf Trønnes --

Re: [PATCH v3 11/13] drm/msm/dsi: add mode valid callback for dsi_mgr

2021-11-24 Thread Dmitry Baryshkov
On 16/11/2021 09:22, Vinod Koul wrote: Add a mode valid callback for dsi_mgr for checking mode being valid in case of DSC. For DSC the height and width needs to be multiple of slice, so we check that here Signed-off-by: Vinod Koul Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi

[pull] amdgpu, amdkfd drm-fixes-5.16

2021-11-24 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.16. The following changes since commit 136057256686de39cc3a07c2e39ef6bc43003ff6: Linux 5.16-rc2 (2021-11-21 13:47:39 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.16-2021-11-24 for you to fe

Re: [PATCH v8 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-11-24 Thread H. Nikolaus Schaller
Hi Paul, >>> You probably should disable the regulator (if not NULL) here. >> Indeed. Would it be ok to make struct regulator *regulator static >> or do we need dynamically allocated memory? > > static non-const is almost always a bad idea, so avoid it. Well some years ago it was a perfectly si

[PATCH v9 0/8] MIPS: JZ4780 and CI20 HDMI

2021-11-24 Thread H. Nikolaus Schaller
PATCH V9 2021-11-24 22:29:14: - patch 6/8: remove optional <0> for assigned-clocks and unintentionally included "unwedge" setup (found by p...@crapouillou.net) - patch 4/8: some cosmetics make regulator enable/disable only if not NULL (found by p...@crapouillou.net) simp

[PATCH v9 3/8] dt-bindings: display: Add ingenic, jz4780-dw-hdmi DT Schema

2021-11-24 Thread H. Nikolaus Schaller
From: Sam Ravnborg Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. Based on .txt binding from Zubair Lutfullah Kakakhel We also add generic ddc-i2c-bus to synopsys,dw-hdmi.yaml Signed-off-by: Sam Ravnborg Signed-off-by: H. Nikolaus Schaller Cc: Rob Herring Cc: devicet...@vger

[PATCH v9 5/8] MIPS: DTS: jz4780: Account for Synopsys HDMI driver and LCD controllers

2021-11-24 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Here we add jz4780 device tree setup. Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- a

[PATCH v9 1/8] drm/ingenic: prepare ingenic drm for later addition of JZ4780

2021-11-24 Thread H. Nikolaus Schaller
This changes the way the regmap is allocated to prepare for the later addition of the JZ4780 which has more registers and bits than the others. Therefore we make the regmap as big as the reg property in the device tree tells. Suggested-by: Paul Cercueil Signed-off-by: H. Nikolaus Schaller ---

[PATCH v9 7/8] MIPS: defconfig: CI20: configure for DRM_DW_HDMI_JZ4780

2021-11-24 Thread H. Nikolaus Schaller
Enable CONFIG options as modules. Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- arch/mips/configs/ci20_defconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci20_defconfig index ab7ebb0668340..cc69b21585

[PATCH v9 2/8] drm/ingenic: Add support for JZ4780 and HDMI output

2021-11-24 Thread H. Nikolaus Schaller
From: Paul Boddie Add support for the LCD controller present on JZ4780 SoCs. This SoC uses 8-byte descriptors which extend the current 4-byte descriptors used for other Ingenic SoCs. Tested on MIPS Creator CI20 board. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H.

[PATCH v9 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-11-24 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Here we add Kconfig DRM_INGENIC_DW_HDMI, Makefile and driver code. Signed-off-by: Paul Boddie Signed-off-by:

  1   2   >