[PATCH V7 10/11] PCI/VGA: Use unsigned format string to print lock counts

2021-10-15 Thread Huacai Chen
From: Bjorn Helgaas In struct vga_device, io_lock_cnt and mem_lock_cnt are unsigned, but we previously printed them with "%d", the signed decimal format. Print them with the unsigned format "%u" instead. Signed-off-by: Bjorn Helgaas Signed-off-by: Huacai Chen --- drivers/gpu/vga/vgaarb.c | 2

[PATCH V7 11/11] PCI/VGA: Replace full MIT license text with SPDX identifier

2021-10-15 Thread Huacai Chen
From: Bjorn Helgaas Per Documentation/process/license-rules.rst, the SPDX MIT identifier is equivalent to including the entire MIT license text from LICENSES/preferred/MIT. Replace the MIT license text with the equivalent SPDX identifier. Signed-off-by: Bjorn Helgaas Signed-off-by: Huacai Chen

[PATCH -next] drm/v3d: nullify pointer se with a NULL

2021-10-15 Thread Yang Li
Currently a plain integer is being used to nullify the pointer struct v3d_submit_ext *se. Use NULL instead. Cleans up sparse warnings: drivers/gpu/drm/v3d/v3d_gem.c:777:53: warning: Using plain integer as NULL pointer drivers/gpu/drm/v3d/v3d_gem.c:1010:45: warning: Using plain integer as NULL point

[PATCH] Revert "drm/ast: Zero is missing in detect function"

2021-10-15 Thread Thomas Zimmermann
Commit 572994bf18ff ("drm/ast: Zero is missing in detect function") prevents some systems from booting. Seen on Supermicro Super Server/X10SRL-F, BIOS 3.3 10/28/2020 . There's further a bug that results in KASAN: use-after-free in enqueue_timer+0x4f/0x1e0 which is also triggered by commit 57299

Re: [PATCH] drm/bridge: Ignore -EPROBE_DEFER when bridge attach fails

2021-10-15 Thread Guido Günther
Hi Sam, On Thu, Oct 14, 2021 at 09:35:20PM +0200, Sam Ravnborg wrote: > Hi Guido, > > > > > > > > > + if (ret != -EPROBE_DEFER) { > > > > #ifdef CONFIG_OF > > > > - DRM_ERROR("failed to attach bridge %pOF to encoder %s: %d\n", > > > > - bridge->of_node, encoder->name

Re: [RFC v2 01/22] drm: RFC for Plane Color Hardware Pipeline

2021-10-15 Thread Pekka Paalanen
On Thu, 14 Oct 2021 19:44:25 + "Shankar, Uma" wrote: > > -Original Message- > > From: Pekka Paalanen > > Sent: Wednesday, October 13, 2021 2:01 PM > > To: Shankar, Uma > > Cc: harry.wentl...@amd.com; ville.syrj...@linux.intel.com; intel- > > g...@lists.freedesktop.org; dri-devel@li

Re: [PATCH v6 14/16] drm/mediatek: add ovl_adaptor support for MT8195

2021-10-15 Thread AngeloGioacchino Del Regno
Add ovl_adaptor driver for MT8195. Ovl_adaptor is an encapsulated module and designed for simplified DRM control flow. This module is composed of 8 RDMAs, 4 MERGEs and an ETHDR. Two RDMAs merge into one layer, so this module support 4 layers. Signed-off-by: Nancy.Lin --- drivers/gpu/drm/mediat

Re: [RFC v1 3/6] drm: Add a capability flag to support additional flip completion signalling

2021-10-15 Thread Pekka Paalanen
On Fri, 15 Oct 2021 03:37:01 + "Kasireddy, Vivek" wrote: > Hi Pekka, > Thank you for reviewing this patch. > Hi Vivek! > > On Mon, 13 Sep 2021 16:35:26 -0700 > > Vivek Kasireddy wrote: > > > > > If a driver supports this capability, it means that there would be an > > > additional sig

Re: [PATCH 2/7] drm/meson: remove useless recursive components matching

2021-10-15 Thread Neil Armstrong
Hi Sam, On 14/10/2021 19:49, Sam Ravnborg wrote: > Hi Neil, > > one comment below. Other than that > Acked-by: Sam Ravnborg > > Sam > > On Thu, Oct 14, 2021 at 05:26:01PM +0200, Neil Armstrong wrote: >> The initial design was recursive to cover all port/endpoints, but only the >> first

Re: [PATCH 3/7] drm/meson: split out encoder from meson_dw_hdmi

2021-10-15 Thread Neil Armstrong
Hi, On 14/10/2021 20:07, Sam Ravnborg wrote: > Hi Neil, > > I did not verify all the code movements - but it looked correct from a > quick glance. > A few comments below, especially the use of mode_set() should be > addressed as it is deprecated. I was not sure about mode_set, will move to atomi

Re: [PATCH 7/7] drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR

2021-10-15 Thread Neil Armstrong
Hi Sam, On 14/10/2021 20:15, Sam Ravnborg wrote: > Hi Neil, > > with include order fixed and the comment below considered: > Acked-by: Sam Ravnborg > > Sam > > > On Thu, Oct 14, 2021 at 05:26:06PM +0200, Neil Armstrong wrote: >> Drop the local connector and move all callback to bridge f

Re: [PATCH 4/7] drm/bridge: synopsys: dw-hdmi: also allow interlace on bridge

2021-10-15 Thread Neil Armstrong
Hi Sam, On 14/10/2021 20:08, Sam Ravnborg wrote: > On Thu, Oct 14, 2021 at 05:26:03PM +0200, Neil Armstrong wrote: >> Since we allow interlace on the encoder, also allow it on the bridge >> so we can allow interlaced modes when using DRM_BRIDGE_ATTACH_NO_CONNECTOR. >> >> Signed-off-by: Neil Armstr

Re: [PATCH v6 02/16] dt-bindings: mediatek: add vdosys1 MERGE property for mt8195

2021-10-15 Thread AngeloGioacchino Del Regno
MT8195 vdosys1 merge1 to merge4 have HW mute function. Add MERGE additional mute property description. Signed-off-by: Nancy.Lin --- .../devicetree/bindings/display/mediatek/mediatek,merge.yaml | 4 1 file changed, 4 insertions(+) Acked-By: AngeloGioacchino Del Regno

Re: [bug report] drm/msm: dsi: Handle dual-channel for 6G as well

2021-10-15 Thread Dan Carpenter
On Thu, Oct 14, 2021 at 06:43:22PM -0700, Jessica Zhang wrote: > Hey Dan, > > On 10/1/2021 5:31 AM, Dan Carpenter wrote: > > Hello Sean Paul, > > > > The patch a6bcddbc2ee1: "drm/msm: dsi: Handle dual-channel for 6G as > > well" from Jul 25, 2018, leads to the following > > Smatch static checker

Re: [lib/stackdepot] 1cd8ce52c5: BUG:unable_to_handle_page_fault_for_address

2021-10-15 Thread Vlastimil Babka
On 10/14/21 12:16, Mike Rapoport wrote: > On Thu, Oct 14, 2021 at 11:33:03AM +0200, Vlastimil Babka wrote: >> On 10/14/21 10:54, kernel test robot wrote: >> >> In my local testing of the patch, when stackdepot was initialized through >> page owner init, it was using kvmalloc() so slab_is_available

[PATCH v3 06/10] drm/gma500: Inline psb_gtt_attach_pages() and psb_gtt_detach_pages()

2021-10-15 Thread Thomas Zimmermann
psb_gtt_attach_pages() are not GTT functions but deal with the GEM object's SHMEM pages. The only callers of psb_gtt_attach_pages() and psb_gtt_detach_pages() are the GEM pin helpers. Inline the calls and cleanup the resulting code. v2: * unlock gtt_mutex in pin-error handling (Patrik) Si

[PATCH v3 00/10] drm/gma500: Refactor GEM code

2021-10-15 Thread Thomas Zimmermann
Bring GEM code up to current standards and untangle the connection to GTT helpers. The allocation and pinning helpers for struct gtt_range are located in the GTT code, but actually part of the GEM implementation. The patchset moves them to GEM code and refactors much of the implementation. Most of

[PATCH v3 03/10] drm/gma500: Reimplement psb_gem_create()

2021-10-15 Thread Thomas Zimmermann
Implement psb_gem_create() for general use. Create the GEM handle in psb_gem_create_dumb(). Allows to use psb_gem_create() for creating all of the GEM objects. While at it, clean-up drm_gem_dumb_create() to make it more readable. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson ---

[PATCH v3 02/10] drm/gma500: Use to_gtt_range() everywhere

2021-10-15 Thread Thomas Zimmermann
Convert upcasts from struct drm_gem_object to struct gtt_range to to_gtt_range(). Some places used container_of() directly. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gem.c | 4 ++-- drivers/gpu/drm/gma500/gma_display.c | 7 +++ 2 files ch

[PATCH v3 04/10] drm/gma500: Allocate GTT ranges in stolen memory with psb_gem_create()

2021-10-15 Thread Thomas Zimmermann
Support private objects for stolen memory in psb_gem_create() and convert users to psb_gem_create(). For stolen memory, psb_gem_create() now initializes the GEM object via drm_gem_private_object_init(). In the fbdev setup, replace the open-coded initialization of struct gtt_range with a call to ps

[PATCH v3 05/10] drm/gma500: Rename psb_gtt_{pin, unpin}() to psb_gem_{pin, unpin}()

2021-10-15 Thread Thomas Zimmermann
Rename psb_gtt_pin() to psb_gem_pin() to reflect the semantics of the function. Same for psb_gtt_unpin(). No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gem.c | 8 drivers/gpu/drm/gma500/gem.h | 4 ++-- dr

[PATCH v3 07/10] drm/gma500: Inline psb_gtt_{alloc, free}_range() into rsp callers

2021-10-15 Thread Thomas Zimmermann
psb_gtt_alloc_range() allocates struct gtt_range, create the GTT resource and performs some half-baked initialization. Inline the function into its only caller psb_gem_create(). For creating the GTT resource, introduce a new helper, psb_gtt_alloc_resource() that hides the details of the GTT. For p

[PATCH v3 10/10] drm/gma500: Rename struct gtt_range to struct psb_gem_object

2021-10-15 Thread Thomas Zimmermann
struct gtt_range represents a GEM object. Rename the structure to struct psb_gem_object and update all users. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/framebuffer.c | 9 +- drivers/gpu/drm/gma500/gem.c |

[PATCH v3 08/10] drm/gma500: Set page-caching flags in GEM pin/unpin

2021-10-15 Thread Thomas Zimmermann
Caching of the GEM object's backing pages are unrelated to GTT management. Move the respective calls from GTT code to GEM code. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gem.c | 9 - drivers/gpu/drm/gma500/gtt.c | 17 ++--- drive

[PATCH v3 01/10] drm/gma500: Move helpers for struct gtt_range from gtt.c to gem.c

2021-10-15 Thread Thomas Zimmermann
Allocation and pinning helpers for struct gtt_range are GEM functions, so move them to gem.c. No functional changes. v2: * keep docs for psb_gtt_{attach,detach}_pages() (Patrik) Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/framebuffer.c |

[PATCH v3 09/10] drm/gma500: Rewrite GTT page insert/remove without struct gtt_range

2021-10-15 Thread Thomas Zimmermann
struct gtt_range represents a GEM object and should not be used for GTT setup. Change psb_gtt_insert() and psb_gtt_remove() to receive all necessary parameters from their caller. This also eliminates possible failure from psb_gtt_insert(). There's one exception in psb_gtt_restore(), which requires

Re: [Intel-gfx] [PATCH v5] drm/i915/gt: move remaining debugfs interfaces into gt

2021-10-15 Thread Andi Shyti
Hi Lucas, > > > > The following interfaces: > > > > > > > > i915_wedged > > > > i915_forcewake_user > > > > > > > > are dependent on gt values. Put them inside gt/ and drop the > > > > "i915_" prefix name. This would be the new structure: > > > > > > > > dri/0/gt > > > > | > > > > +-- forcewa

Re: [lib/stackdepot] 1cd8ce52c5: BUG:unable_to_handle_page_fault_for_address

2021-10-15 Thread Mike Rapoport
On Fri, Oct 15, 2021 at 10:27:17AM +0200, Vlastimil Babka wrote: > On 10/14/21 12:16, Mike Rapoport wrote: > > On Thu, Oct 14, 2021 at 11:33:03AM +0200, Vlastimil Babka wrote: > >> On 10/14/21 10:54, kernel test robot wrote: > >> > >> In my local testing of the patch, when stackdepot was initializ

Re: [PATCH v3] lib/stackdepot: allow optional init and stack_table allocation by kvmalloc()

2021-10-15 Thread Vlastimil Babka
On 10/13/21 09:30, Vlastimil Babka wrote: > Currently, enabling CONFIG_STACKDEPOT means its stack_table will be allocated > from memblock, even if stack depot ends up not actually used. The default size > of stack_table is 4MB on 32-bit, 8MB on 64-bit. > > This is fine for use-cases such as KASAN

linux-next: build failure after merge of the drm-misc tree

2021-10-15 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/gpu/drm/drm_modeset_lock.c:111:29: error: conflicting types for '__stack_depot_save' 111 | static depot_stack_handle_t __stack_depot_save(void) |

linux-next: build warning after merge of the drm-misc tree

2021-10-15 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning: Documentation/gpu/drm-kms-helpers:451: /home/sfr/next/next/drivers/gpu/drm/drm_privacy_screen.c:270: WARNING: Inline emphasis start-string without end-string. Introduced by commit 8a12b170558

Re: linux-next: build failure after merge of the drm-misc tree

2021-10-15 Thread Jani Nikula
On Fri, 15 Oct 2021, Stephen Rothwell wrote: > Hi all, > > After merging the drm-misc tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/gpu/drm/drm_modeset_lock.c:111:29: error: conflicting types for > '__stack_depot_save' > 111 | static depot_stack_handle_

linux-next: build warning after merge of the drm-misc tree

2021-10-15 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning: include/drm/drm_modeset_lock.h:74: warning: Function parameter or member 'stack_depot' not described in 'drm_modeset_acquire_ctx' Introduced by commit cd06ab2fd48f ("drm/locking: add backtrace

RE: [PATCH 2/4] drm/dp_mst: Only create connector for connected end device

2021-10-15 Thread Lin, Wayne
[Public] Thanks Lyude! And sorry for late reply. I'm also struggling for other tasks so haven't get through your detail elaboration honestly. Would like to take time to think through your elaboration : ) Anyway, will response it ASAP. Thanks again! > -Original Message- > From: Lyude Pa

Re: linux-next: build failure after merge of the drm-misc tree

2021-10-15 Thread Stephen Rothwell
Hi Jani, On Fri, 15 Oct 2021 12:56:58 +0300 Jani Nikula wrote: > > The fix looks good, but I'd rename __stack_depot_print too added in the > same commit. Do you want to respin or shall I take it from here? If you are happy to take it on, then thanks. -- Cheers, Stephen Rothwell pgpMzYtLeuRtv

Re: [PATCH v1 2/2] mm: remove extra ZONE_DEVICE struct page refcount

2021-10-15 Thread Jason Gunthorpe
On Thu, Oct 14, 2021 at 10:45:52PM -0500, Sierra Guiza, Alejandro (Alex) wrote: > > On 10/14/2021 3:57 PM, Ralph Campbell wrote: > > > > On 10/14/21 11:01 AM, Jason Gunthorpe wrote: > > > On Thu, Oct 14, 2021 at 10:35:27AM -0700, Ralph Campbell wrote: > > > > > > > I ran xfstests-dev using the k

Re: [PATCH] drm: panel: replace snprintf in show functions with sysfs_emit

2021-10-15 Thread Sebastian Reichel
Hi, On Thu, Oct 14, 2021 at 11:48:10PM -0700, Qing Wang wrote: > show() must not use snprintf() when formatting the value to be > returned to user space. > > Fix the following coccicheck warning: > drivers/gpu/drm/panel/panel-dsi-cm.c:251: WARNING: use scnprintf or sprintf. > drivers/gpu/drm/pane

[PATCH 03/15] drm/vc4: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Use this value instead of calling drm_detect_hdmi_monitor() to avoid a second parse. This is a TODO task in Documentation/gpu/todo.rst Signed-off-by: Claudio Suarez --- drivers/gpu/drm/vc4/v

[PATCH 01/15] gpu/drm: make drm_add_edid_modes() consistent when updating connector->display_info

2021-10-15 Thread Claudio Suarez
According to the documentation, drm_add_edid_modes "... Also fills out the &drm_display_info structure and ELD in @connector with any information which can be derived from the edid." drm_add_edid_modes accepts a struct edid *edid parameter which may have a value or may be null. When it is not null

[PATCH 02/15] drm/amdgpu: use drm_* functions instead of duplicated code in amdgpu driver

2021-10-15 Thread Claudio Suarez
a) Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. The amdgpu driver still calls drm_detect_hdmi_monitor() to retrieve the same information, which is less efficient. Change to drm_display_info.is_hdmi This is a TODO task in Documentation/gpu

[PATCH 2/2] dma-buf: Fix dma_resv_test_signaled.

2021-10-15 Thread Maarten Lankhorst
Commit 7fa828cb9265 ("dma-buf: use new iterator in dma_resv_test_signaled") accidentally forgot to test whether the dma-buf is actually signaled, breaking pretty much everything depending on it. Fixes: 7fa828cb9265 ("dma-buf: use new iterator in dma_resv_test_signaled") Cc: Christian König Cc: Da

[PATCH 1/2] dma-buf: Fix dma_resv_wait_timeout handling of timeout = 0.

2021-10-15 Thread Maarten Lankhorst
Commit ada5c48b11a3 ("dma-buf: use new iterator in dma_resv_wait_timeout") accidentally started mishandling timeout = 0, by forcing a blocking wait with timeout = 1 passed to fences. This is not intended, as timeout = 0 may be used for peeking, similar to test_signaled. Fixes: ada5c48b11a3 ("dma-b

[PATCH 0/2] dma-buf: Fix breakages from dma_resv_iter conversion.

2021-10-15 Thread Maarten Lankhorst
Urgent fixes! dma_resv_test_signaled is completely broken, dma_resv_wait_timeout kind of broken. Maarten Lankhorst (2): dma-buf: Fix dma_resv_wait_timeout handling of timeout = 0. dma-buf: Fix dma_resv_test_signaled. drivers/dma-buf/dma-resv.c | 20 +++- 1 file changed, 11

Re: [PATCH 01/15] gpu/drm: make drm_add_edid_modes() consistent when updating connector->display_info

2021-10-15 Thread Ville Syrjälä
On Fri, Oct 15, 2021 at 01:36:59PM +0200, Claudio Suarez wrote: > According to the documentation, drm_add_edid_modes > "... Also fills out the &drm_display_info structure and ELD in @connector > with any information which can be derived from the edid." > > drm_add_edid_modes accepts a struct edid

Re: [PATCH 2/2] dma-buf: Fix dma_resv_test_signaled.

2021-10-15 Thread Christian König
Am 15.10.21 um 13:57 schrieb Maarten Lankhorst: Commit 7fa828cb9265 ("dma-buf: use new iterator in dma_resv_test_signaled") accidentally forgot to test whether the dma-buf is actually signaled, breaking pretty much everything depending on it. NAK, the dma_resv_for_each_fence_unlocked() returns

[PATCH 07/15] drm/exynos: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Retriving the same information with drm_detect_hdmi_monitor() is less efficient. Change to drm_display_info.is_hdmi Signed-off-by: Claudio Suarez --- drivers/gpu/drm/exynos/exynos_hdmi.c | 6

[PATCH 06/15] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Retriving the same information with drm_detect_hdmi_monitor() is less efficient. Change to drm_display_info.is_hdmi Signed-off-by: Claudio Suarez --- drivers/gpu/drm/gma500/cdv_intel_hdmi.c |

[PATCH 15/15] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Retriving the same information with drm_detect_hdmi_monitor() is less efficient. Change to drm_display_info.is_hdmi where possible. This is a TODO task in Documentation/gpu/todo.rst Signed-off

[PATCH 14/15] drm/nouveau: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Retriving the same information with drm_detect_hdmi_monitor() is less efficient. Change to drm_display_info.is_hdmi Signed-off-by: Claudio Suarez --- drivers/gpu/drm/nouveau/dispnv50/disp.c

[PATCH 13/15] drm/bridge: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Retriving the same information with drm_detect_hdmi_monitor() is less efficient. Change to drm_display_info.is_hdmi where possible Signed-off-by: Claudio Suarez --- drivers/gpu/drm/bridge/adv

[PATCH 12/15] drm/rockchip: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Retriving the same information with drm_detect_hdmi_monitor() is less efficient. Change to drm_display_info.is_hdmi Signed-off-by: Claudio Suarez --- drivers/gpu/drm/rockchip/inno_hdmi.c |

[PATCH 11/15] drm/zte: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Retriving the same information with drm_detect_hdmi_monitor() is less efficient. Change to drm_display_info.is_hdmi Signed-off-by: Claudio Suarez --- drivers/gpu/drm/zte/zx_hdmi.c | 4 ++-- 1

[PATCH 10/15] drm/sti: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Retriving the same information with drm_detect_hdmi_monitor() is less efficient. Change to drm_display_info.is_hdmi Signed-off-by: Claudio Suarez --- drivers/gpu/drm/sti/sti_hdmi.c | 10 +

[PATCH 00/15] replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Copy&paste from the TODO document Documentation/gpu/todo.rst === Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi --- Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi

[PATCH 09/15] drm/sun4i: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Retriving the same information with drm_detect_hdmi_monitor() is less efficient. Change to drm_display_info.is_hdmi Signed-off-by: Claudio Suarez --- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c |

[PATCH 08/15] drm/msm: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Retriving the same information with drm_detect_hdmi_monitor() is less efficient. Change to drm_display_info.is_hdmi Signed-off-by: Claudio Suarez --- drivers/gpu/drm/msm/hdmi/hdmi_connector.c

[PATCH 04/15] drm/radeon: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Retriving the same information is less efficient. Change to drm_display_info.is_hdmi This is a TODO task in Documentation/gpu/todo.rst Also, correct an inacurracy or bug in radeon_connector_ge

[PATCH 05/15] drm/tegra: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Retriving the same information with drm_detect_hdmi_monitor() is less efficient. Change to drm_display_info.is_hdmi Signed-off-by: Claudio Suarez --- drivers/gpu/drm/tegra/hdmi.c | 6 +-

Re: [Intel-gfx] [PATCH 15/15] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Ville Syrjälä
On Fri, Oct 15, 2021 at 01:37:13PM +0200, Claudio Suarez wrote: > Once EDID is parsed, the monitor HDMI support information is available > through drm_display_info.is_hdmi. Retriving the same information with > drm_detect_hdmi_monitor() is less efficient. Change to > drm_display_info.is_hdmi where

Re: [PATCH 15/15] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Jani Nikula
On Fri, 15 Oct 2021, Claudio Suarez wrote: > Once EDID is parsed, the monitor HDMI support information is available > through drm_display_info.is_hdmi. Retriving the same information with > drm_detect_hdmi_monitor() is less efficient. Change to > drm_display_info.is_hdmi where possible. > > This i

Re: [PATCH 2/2] dma-buf: Fix dma_resv_test_signaled.

2021-10-15 Thread Maarten Lankhorst
Op 15-10-2021 om 14:07 schreef Christian König: > Am 15.10.21 um 13:57 schrieb Maarten Lankhorst: >> Commit 7fa828cb9265 ("dma-buf: use new iterator in dma_resv_test_signaled") >> accidentally forgot to test whether the dma-buf is actually signaled, >> breaking >> pretty much everything depending

Re: [Linaro-mm-sig] [PATCH 2/2] dma-buf: Fix dma_resv_test_signaled.

2021-10-15 Thread Christian König
Am 15.10.21 um 14:52 schrieb Maarten Lankhorst: Op 15-10-2021 om 14:07 schreef Christian König: Am 15.10.21 um 13:57 schrieb Maarten Lankhorst: Commit 7fa828cb9265 ("dma-buf: use new iterator in dma_resv_test_signaled") accidentally forgot to test whether the dma-buf is actually signaled, br

Re: [Intel-gfx] [PATCH 15/15] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Ville Syrjälä
On Fri, Oct 15, 2021 at 03:44:48PM +0300, Jani Nikula wrote: > On Fri, 15 Oct 2021, Claudio Suarez wrote: > > Once EDID is parsed, the monitor HDMI support information is available > > through drm_display_info.is_hdmi. Retriving the same information with > > drm_detect_hdmi_monitor() is less effic

Re: [PATCH -next] drm/v3d: nullify pointer se with a NULL

2021-10-15 Thread Melissa Wen
On 10/15, Yang Li wrote: > Currently a plain integer is being used to nullify the pointer > struct v3d_submit_ext *se. Use NULL instead. Cleans up sparse > warnings: > drivers/gpu/drm/v3d/v3d_gem.c:777:53: warning: Using plain integer as > NULL pointer > drivers/gpu/drm/v3d/v3d_gem.c:1010:45: warni

Re: [PATCH] dt-bindings: display/bridge: ptn3460: Convert to YAML binding

2021-10-15 Thread Rob Herring
On Thu, 07 Oct 2021 09:58:22 +0200, AngeloGioacchino Del Regno wrote: > Convert the NXP PTN3460 eDP to LVDS bridge documentation to YAML. > > Signed-off-by: AngeloGioacchino Del Regno > > --- > .../bindings/display/bridge/nxp,ptn3460.yaml | 106 ++ > .../bindings/display/bridge

[PATCH v2 0/6] drm/meson: rework encoders to pass ATTACH_NO_CONNECTOR

2021-10-15 Thread Neil Armstrong
This serie finnally reworks the drm/meson driver by extracting the encoders in their own file and moves to bridge-only callbacks. This permits passing the ATTACH_NO_CONNECTOR bridge attach flag and finally use the CVBS & HDMI display-connector driver. This will ease Martin Blumenstingl writing th

[PATCH v2 1/6] drm/bridge: display-connector: implement bus fmts callbacks

2021-10-15 Thread Neil Armstrong
Since this bridge is tied to the connector, it acts like a passthrough, so concerning the output & input bus formats, either pass the bus formats from the previous bridge or return fallback data like done in the bridge function: drm_atomic_bridge_chain_select_bus_fmts() & select_bus_fmt_recursive.

[PATCH v2 3/6] drm/meson: split out encoder from meson_dw_hdmi

2021-10-15 Thread Neil Armstrong
This moves all the non-DW-HDMI code where it should be: an encoder in the drm/meson core driver. The bridge functions are copied as-is, except: - the encoder init uses the simple kms helper - the mode_set has been moved to atomic_enable() - debug prints are converted to dev_debg() For now the bri

[PATCH v2 5/6] drm/meson: rename venc_cvbs to encoder_cvbs

2021-10-15 Thread Neil Armstrong
Rename the cvbs encoder to match the newly introduced meson_encoder_hdmi. Signed-off-by: Neil Armstrong Acked-by: Sam Ravnborg --- drivers/gpu/drm/meson/Makefile| 2 +- drivers/gpu/drm/meson/meson_drv.c | 4 +- ...meson_venc_cvbs.c => meson_encoder_cvbs.c} | 78 +++

[PATCH v2 4/6] drm/meson: encoder_hdmi: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR

2021-10-15 Thread Neil Armstrong
This implements the necessary change to no more use the embedded connector in dw-hdmi and use the dedicated bridge connector driver by passing DRM_BRIDGE_ATTACH_NO_CONNECTOR to the bridge attach call. The necessary connector properties are added to handle the same functionalities as the embedded d

[PATCH v2 2/6] drm/meson: remove useless recursive components matching

2021-10-15 Thread Neil Armstrong
The initial design was recursive to cover all port/endpoints, but only the first layer of endpoints should be covered by the components list. This also breaks the MIPI-DSI init/bridge attach sequence, thus only parse the first endpoints instead of recursing. Signed-off-by: Neil Armstrong Acked-b

[PATCH v2 6/6] drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR

2021-10-15 Thread Neil Armstrong
Drop the local connector and move all callback to bridge funcs in order to leverage the generic CVBS display connector. This will also permit adding custom cvbs connectors for ADC based HPD detection on some Amlogic SoC based boards. Signed-off-by: Neil Armstrong Acked-by: Sam Ravnborg --- dri

Re: [git pull] drm fixes for 5.15-rc6

2021-10-15 Thread pr-tracker-bot
The pull request you sent on Fri, 15 Oct 2021 15:15:31 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2021-10-15-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/591a495d440ff8dd2b51a47eb6053c83f68a7f6b Thank you! -- Deet-doot-dot, I am a bot. https:/

Re: [Intel-gfx] [PATCH] drm/i915: fix blank screen booting crashes

2021-10-15 Thread Tvrtko Ursulin
On 04/10/2021 08:36, Jani Nikula wrote: On Fri, 24 Sep 2021, Ville Syrjälä wrote: On Tue, Sep 21, 2021 at 06:50:39PM -0700, Matthew Brost wrote: From: Hugh Dickins 5.15-rc1 crashes with blank screen when booting up on two ThinkPads using i915. Bisections converge convincingly, but arrive

[PATCH RESEND v10 2/2] drm/tiny: add driver for newhaven, 1.8-128160EF

2021-10-15 Thread Daniel Mack
This patch adds support for Newhaven's NHD-1.8-128160EF display, featuring an Ilitek ILI9163 controller. Signed-off-by: Daniel Mack Acked-by: Daniel Vetter Acked-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/Kconfig | 13 ++ drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/ili9

[PATCH RESEND v10 0/2] gpu: drm: add driver for ili9361 panel

2021-10-15 Thread Daniel Mack
This is v10 of the series. Resending without changes. Changelog: v2 -> v3: * Turn Documentation into yaml format v3 -> v4: * Fix reference error in yaml file v4 -> v5: * More yaml file documentation fixes v5 -> v6: * More yaml file documentation fixes v6 -> v7

[PATCH v8 0/2] gpu: drm: add driver for ili9361 panel

2021-10-15 Thread Daniel Mack
This is v3 of the series. Changelog: v2 -> v3: * Turn Documentation into yaml format v3 -> v4: * Fix reference error in yaml file v4 -> v5: * More yaml file documentation fixes v5 -> v6: * More yaml file documentation fixes v6 -> v7: * Fix ordering of p

[PATCH v8 1/2] dt-bindings: display: add bindings for newhaven, 1.8-128160EF

2021-10-15 Thread Daniel Mack
This adds documentation for a new ILI9163 based, SPI connected display. Signed-off-by: Daniel Mack --- .../display/panel/ilitek,ili9163.yaml | 69 +++ 1 file changed, 69 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml

[PATCH v8 2/2] drm/tiny: add driver for newhaven,1.8-128160EF

2021-10-15 Thread Daniel Mack
This patch adds support for Newhaven's NHD-1.8-128160EF display, featuring an Ilitek ILI9163 controller. Signed-off-by: Daniel Mack Acked-by: Daniel Vetter --- drivers/gpu/drm/tiny/Kconfig | 13 ++ drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/ili9163.c | 224 +

Re: [PATCH v8 0/2] gpu: drm: add driver for ili9361 panel

2021-10-15 Thread Daniel Mack
On 10/15/21 16:59, Daniel Mack wrote: > This is v3 of the series. Ups, sorry. Ignore this one. I meant to resend a different version of this series. My apologies, Daniel > > Changelog: > > v2 -> v3: > * Turn Documentation into yaml format > > v3 -> v4: > * Fix reference error i

[PATCH RESEND v10 1/2] dt-bindings: display: add bindings for newhaven, 1.8-128160EF

2021-10-15 Thread Daniel Mack
This adds documentation for a new ILI9163 based, SPI connected display. Signed-off-by: Daniel Mack Reviewed-by: Rob Herring --- .../display/panel/ilitek,ili9163.yaml | 69 +++ 1 file changed, 69 insertions(+) create mode 100644 Documentation/devicetree/bindings/display

Re: [PATCH 02/15] drm/amdgpu: use drm_* functions instead of duplicated code in amdgpu driver

2021-10-15 Thread Harry Wentland
On 2021-10-15 07:37, Claudio Suarez wrote: > a) Once EDID is parsed, the monitor HDMI support information is available > through drm_display_info.is_hdmi. The amdgpu driver still calls > drm_detect_hdmi_monitor() to retrieve the same information, which > is less efficient. Change to drm_display_

Re: [Intel-gfx] [PATCH 15/15] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Jani Nikula
On Fri, 15 Oct 2021, Ville Syrjälä wrote: > On Fri, Oct 15, 2021 at 03:44:48PM +0300, Jani Nikula wrote: >> On Fri, 15 Oct 2021, Claudio Suarez wrote: >> > Once EDID is parsed, the monitor HDMI support information is available >> > through drm_display_info.is_hdmi. Retriving the same information

Re: [PATCH 1/3] drm/dp: add helpers to read link training delays

2021-10-15 Thread Jani Nikula
On Thu, 14 Oct 2021, Jani Nikula wrote: > The link training delays are different and/or available in different > DPCD offsets depending on: > > - Clock recovery vs. channel equalization > - DPRX vs. LTTPR > - 128b/132b vs. 8b/10b > - DPCD 1.4+ vs. earlier > > Add helpers to get the correct delays

Re: [Intel-gfx] [PATCH] drm/i915: fix blank screen booting crashes

2021-10-15 Thread John Harrison
On 10/15/2021 07:52, Tvrtko Ursulin wrote: On 04/10/2021 08:36, Jani Nikula wrote: On Fri, 24 Sep 2021, Ville Syrjälä wrote: On Tue, Sep 21, 2021 at 06:50:39PM -0700, Matthew Brost wrote: From: Hugh Dickins 5.15-rc1 crashes with blank screen when booting up on two ThinkPads using i915.  Bis

Re: [Intel-gfx] [PATCH] drm/i915: fix blank screen booting crashes

2021-10-15 Thread Jani Nikula
On Fri, 15 Oct 2021, John Harrison wrote: > On 10/15/2021 07:52, Tvrtko Ursulin wrote: >> On 04/10/2021 08:36, Jani Nikula wrote: >>> On Fri, 24 Sep 2021, Ville Syrjälä >>> wrote: On Tue, Sep 21, 2021 at 06:50:39PM -0700, Matthew Brost wrote: > From: Hugh Dickins > > 5.15-rc1 c

Re: [PATCH v6 02/16] dt-bindings: mediatek: add vdosys1 MERGE property for mt8195

2021-10-15 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年10月4日 週一 下午2:21寫道: > > MT8195 vdosys1 merge1 to merge4 have HW mute function. > Add MERGE additional mute property description. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Nancy.Lin > --- > .../devicetree/bindings/display/mediatek/mediatek,merge.yaml | 4 >

[PATCH v3 1/6] drm/sysfs: introduce drm_sysfs_connector_hotplug_event

2021-10-15 Thread Simon Ser
This function sends a hotplug uevent with a CONNECTOR property. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_sysfs.c | 25 + include/drm/drm_sysfs.h | 1 + 2 files changed, 26 insertions(+) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c i

[PATCH v3 0/6] drm: add per-connector hotplug events

2021-10-15 Thread Simon Ser
When a uevent only updates a single connector, add a CONNECTOR property to the uevent. This allows user-space to ignore other connectors when handling the uevent. This is purely an optimization, drivers can still send a uevent without the CONNECTOR property. The CONNECTOR property is already set w

[PATCH v3 2/6] drm/probe-helper: add drm_kms_helper_connector_hotplug_event

2021-10-15 Thread Simon Ser
This function is the same as drm_kms_helper_hotplug_event, but takes a connector instead of a device. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_probe_helper.c | 23 +++ include/drm/drm_probe_helper.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers/g

[PATCH v3 5/6] drm/probe-helper: use drm_kms_helper_connector_hotplug_event

2021-10-15 Thread Simon Ser
If an hotplug event only updates a single connector, use drm_kms_helper_connector_hotplug_event instead of drm_kms_helper_hotplug_event. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_probe_helper.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH v3 6/6] i915/display/dp: send a more fine-grained link-status uevent

2021-10-15 Thread Simon Ser
When link-status changes, send a hotplug uevent which contains the connector and property ID. That way, user-space can more easily figure out that only the link-status property of this connector has been updated. Signed-off-by: Simon Ser --- drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ 1 file

[PATCH v3 4/6] amdgpu: use drm_kms_helper_connector_hotplug_event

2021-10-15 Thread Simon Ser
When updating a single connector, use drm_kms_helper_connector_hotplug_event instead of drm_kms_helper_hotplug_event. Signed-off-by: Simon Ser --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 4 ++-- 2 files c

[PATCH v3 3/6] drm/connector: use drm_sysfs_connector_hotplug_event

2021-10-15 Thread Simon Ser
In drm_connector_register, use drm_sysfs_connector_hotplug_event instead of drm_sysfs_hotplug_event, because the hotplug event only updates a single connector. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [bug report] drm/msm: dsi: Handle dual-channel for 6G as well

2021-10-15 Thread Jessica Zhang
On 10/15/2021 1:12 AM, Dan Carpenter wrote: On Thu, Oct 14, 2021 at 06:43:22PM -0700, Jessica Zhang wrote: Hey Dan, On 10/1/2021 5:31 AM, Dan Carpenter wrote: Hello Sean Paul, The patch a6bcddbc2ee1: "drm/msm: dsi: Handle dual-channel for 6G as well" from Jul 25, 2018, leads to the followin

RE: [PATCH v3 7/7] drm/kmb: Enable support for framebuffer console

2021-10-15 Thread Chrisanthus, Anitha
Hi Thomas, Thanks for your review. > -Original Message- > From: Thomas Zimmermann > Sent: Thursday, October 14, 2021 6:08 AM > To: Chrisanthus, Anitha ; dri- > de...@lists.freedesktop.org > Cc: s...@ravnborg.org; Dea, Edmund J > Subject: Re: [PATCH v3 7/7] drm/kmb: Enable support for fra

RE: [PATCH v3 7/7] drm/kmb: Enable support for framebuffer console

2021-10-15 Thread Chrisanthus, Anitha
Hi Thomas, Thanks for your review. > -Original Message- > From: Thomas Zimmermann > Sent: Thursday, October 14, 2021 5:50 AM > To: Chrisanthus, Anitha ; dri- > de...@lists.freedesktop.org > Cc: s...@ravnborg.org; Dea, Edmund J > Subject: Re: [PATCH v3 7/7] drm/kmb: Enable support for fra

Re: [PATCH 0/9] treewide: simplify getting .driver_data

2021-10-15 Thread Bjorn Andersson
On Mon, 20 Sep 2021 11:05:12 +0200, Wolfram Sang wrote: > I got tired of fixing this in Renesas drivers manually, so I took the big > hammer. Remove this cumbersome code pattern which got copy-pasted too much > already: > > - struct platform_device *pdev = to_platform_device(dev); > - stru

Re: [PATCH v2 3/6] drm/meson: split out encoder from meson_dw_hdmi

2021-10-15 Thread Sam Ravnborg
Hi Neil, On Fri, Oct 15, 2021 at 04:11:04PM +0200, Neil Armstrong wrote: > This moves all the non-DW-HDMI code where it should be: > an encoder in the drm/meson core driver. > > The bridge functions are copied as-is, except: > - the encoder init uses the simple kms helper > - the mode_set has bee

Re: [PATCH] drm: panel: replace snprintf in show functions with sysfs_emit

2021-10-15 Thread Sam Ravnborg
Hi Qing and Sebastian. On Fri, Oct 15, 2021 at 01:11:39PM +0200, Sebastian Reichel wrote: > Hi, > > On Thu, Oct 14, 2021 at 11:48:10PM -0700, Qing Wang wrote: > > show() must not use snprintf() when formatting the value to be > > returned to user space. > > > > Fix the following coccicheck warni

  1   2   >