Re: [PATCH] drm/bridge: Ignore -EPROBE_DEFER when bridge attach fails

Hi, On Wed, Oct 13, 2021 at 08:48:32AM +0200, Andrzej Hajda wrote: > On 12.10.2021 22:47, Guido Günther wrote: > > Hi Laurent, > > On Tue, Oct 12, 2021 at 11:17:07PM +0300, Laurent Pinchart wrote: > > > Hi Guido, > > > > > > Thank you for the patch. > > > > > > On Tue, Oct 12, 2021 at 09:58:58PM

Re: [RFC v2 01/22] drm: RFC for Plane Color Hardware Pipeline

On Tue, 12 Oct 2021 19:11:29 + "Shankar, Uma" wrote: > > -Original Message- > > From: Pekka Paalanen > > Sent: Tuesday, October 12, 2021 5:30 PM > > To: Simon Ser > > Cc: Shankar, Uma ; intel-...@lists.freedesktop.org; > > dri- > > de...@lists.freedesktop.org; harry.wentl...@amd.co

[PATCH v3] lib/stackdepot: allow optional init and stack_table allocation by kvmalloc()

Currently, enabling CONFIG_STACKDEPOT means its stack_table will be allocated from memblock, even if stack depot ends up not actually used. The default size of stack_table is 4MB on 32-bit, 8MB on 64-bit. This is fine for use-cases such as KASAN which is also a config option and has overhead on it

Re: [PATCH v2 3/4] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings

Hi, On Tue, Oct 12, 2021 at 08:48:42AM +0200, Alexander Stein wrote: > Add a VCC regulator which needs to be enabled before the EN pin is > released. > > Reviewed-by: Sam Ravnborg > Signed-off-by: Alexander Stein > --- > .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 5 + >

[PATCH] drm/bridge: display-connector: fix an uninitialized pointer in probe()

The "label" pointer is used for debug output. The code assumes that it is either NULL or valid, but it is never set to NULL. It is either valid or uninitialized. Fixes: 0c275c30176b ("drm/bridge: Add bridge driver for display connectors") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/bridge

[PATCH 1/2] drm/msm: fix potential NULL dereference in cleanup

The "msm_obj->node" list needs to be initialized earlier so that the list_del() in msm_gem_free_object() doesn't experience a NULL pointer dereference. Fixes: 6ed0897cd800 ("drm/msm: Fix debugfs deadlock") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/msm/msm_gem.c | 1 + 1 file changed, 1 in

[PATCH 2/2] drm/msm: uninitialized variable in msm_gem_import()

The msm_gem_new_impl() function cleans up after itself so there is no need to call drm_gem_object_put(). Conceptually, it does not make sense to call a kref_put() function until after the reference counting has been initialized which happens immediately after this call in the drm_gem_(private_)obj

Re: [RFC v2 01/22] drm: RFC for Plane Color Hardware Pipeline

On Tue, 12 Oct 2021 20:58:27 + "Shankar, Uma" wrote: > > -Original Message- > > From: Pekka Paalanen > > Sent: Tuesday, October 12, 2021 4:01 PM > > To: Shankar, Uma > > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > > harry.wentl...@amd.com; ville.syrj...@

AW: (EXT) Re: [PATCH v2 4/4] drm/bridge: ti-sn65dsi83: Add vcc supply regulator support

Hello Laurent, On Tue, Oct 12, 2021 at 10:43 +0200, Laurent Pinchart wrote: > On Tue, Oct 12, 2021 at 08:48:43AM +0200, Alexander Stein wrote: > > VCC needs to be enabled before releasing the enable GPIO. > > > > Reviewed-by: Sam Ravnborg > > Signed-off-by: Alexander Stein > > --- > > drivers/

Re: (EXT) Re: [PATCH v2 4/4] drm/bridge: ti-sn65dsi83: Add vcc supply regulator support

Hi Alexander, On Wed, Oct 13, 2021 at 08:59:22AM +, Alexander Stein wrote: > On Tue, Oct 12, 2021 at 10:43 +0200, Laurent Pinchart wrote: > > On Tue, Oct 12, 2021 at 08:48:43AM +0200, Alexander Stein wrote: > > > VCC needs to be enabled before releasing the enable GPIO. > > > > > > Reviewed-b

Re: [PATCH v2 3/4] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings

Hi Maxime, On Wed, Oct 13, 2021 at 09:47:22AM +0200, Maxime Ripard wrote: > On Tue, Oct 12, 2021 at 08:48:42AM +0200, Alexander Stein wrote: > > Add a VCC regulator which needs to be enabled before the EN pin is > > released. > > > > Reviewed-by: Sam Ravnborg > > Signed-off-by: Alexander Stein

[PATCH] drm/i915: Use dma_resv_iter for waiting in i915_gem_object_wait_reservation.

No memory should be allocated when calling i915_gem_object_wait, because it may be called to idle a BO when evicting memory. Fix this by using dma_resv_iter helpers to call i915_gem_object_wait_fence() on each fence, which cleans up the code a lot. Also remove dma_resv_prune, it's questionably. T

Re: mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o)

On Thu, Oct 7, 2021 at 11:51 AM Geert Uytterhoeven wrote: > On Wed, Oct 6, 2021 at 9:28 AM Christian König > wrote: > > Am 06.10.21 um 09:20 schrieb Stephen Rothwell: > > > On Tue, 5 Oct 2021 22:48:03 -0700 Randy Dunlap > > > wrote: > > >> on i386: > > >> > > >> ld: drivers/gpu/drm/msm/hdmi/hd

Re: [PATCH v7, 00/15] Support multi hardware decode using of_platform_populate

Hi, W dniu 13.10.2021 o 03:08, yunfei.d...@mediatek.com pisze: Hi Andrzej, On Tue, 2021-10-12 at 16:27 +0200, Andrzej Pietrasiewicz wrote: Hi Yunfei Dong, W dniu 11.10.2021 o 09:02, Yunfei Dong pisze: This series adds support for multi hardware decode into mtk-vcodec, by first adding use of

[PATCH RFC] virtio: wrap config->reset calls

This will enable cleanups down the road. The idea is to disable cbs, then add "flush_queued_cbs" callback as a parameter, this way drivers can flush any work queued after callbacks have been disabled. Signed-off-by: Michael S. Tsirkin --- arch/um/drivers/virt-pci.c | 2 +- driver

Re: [PATCH RFC] virtio: wrap config->reset calls

On 13-10-21, 06:55, Michael S. Tsirkin wrote: > This will enable cleanups down the road. > The idea is to disable cbs, then add "flush_queued_cbs" callback > as a parameter, this way drivers can flush any work > queued after callbacks have been disabled. > > Signed-off-by: Michael S. Tsirkin > --

Re: [PATCH RFC] virtio: wrap config->reset calls

On 13.10.21 12:55, Michael S. Tsirkin wrote: This will enable cleanups down the road. The idea is to disable cbs, then add "flush_queued_cbs" callback as a parameter, this way drivers can flush any work queued after callbacks have been disabled. Signed-off-by: Michael S. Tsirkin --- arch/um/d

[PATCH] drm/i915: Use dma_resv_iter for waiting in i915_gem_object_wait_reservation.

No memory should be allocated when calling i915_gem_object_wait, because it may be called to idle a BO when evicting memory. Fix this by using dma_resv_iter helpers to call i915_gem_object_wait_fence() on each fence, which cleans up the code a lot. Also remove dma_resv_prune, it's questionably. T

Re: [PATCH] drm/i915: Prefer struct_size over open coded arithmetic

On Mon, 11 Oct 2021, Len Baker wrote: > Hi, > > On Sun, Oct 03, 2021 at 12:42:58PM +0200, Len Baker wrote: >> As noted in the "Deprecated Interfaces, Language Features, Attributes, >> and Conventions" documentation [1], size calculations (especially >> multiplication) should not be performed in me

Re: [RFC PATCH v2 2/2] RDMA/rxe: Add dma-buf support

On Fri, Oct 01, 2021 at 12:56:48PM +0900, Shunsuke Mie wrote: > 2021年9月30日(木) 23:41 Daniel Vetter : > > > > On Wed, Sep 29, 2021 at 01:19:05PM +0900, Shunsuke Mie wrote: > > > Implement a ib device operation ‘reg_user_mr_dmabuf’. Generate a > > > rxe_map from the memory space linked the passed dma-

Re: mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o)

On Wed, Oct 13, 2021 at 12:54 PM Arnd Bergmann wrote: > On Thu, Oct 7, 2021 at 11:51 AM Geert Uytterhoeven > wrote: > > -msm-$(CONFIG_DRM_FBDEV_EMULATION) += msm_fbdev.o > -msm-$(CONFIG_COMMON_CLK) += disp/mdp4/mdp4_lvds_pll.o > -msm-$(CONFIG_COMMON_CLK) += hdmi/hdmi_pll_8960.o > -msm-$(CONFIG_C

Re: [PATCH 15/16] Revert "drm/i915: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()"

On Mon, Oct 04, 2021 at 10:31:04PM +0200, Fernando Ramos wrote: > On 21/10/04 11:56AM, Sean Paul wrote: > > @Fernando, hopefully you can revise and post again. Thank you for your > > patches > > and your effort! > > No problem :) > > Just to be sure I do the right thing this time (and to better

Re: [PATCH] drm/i915: Prefer struct_size over open coded arithmetic

On Wed, Oct 13, 2021 at 02:24:05PM +0300, Jani Nikula wrote: > On Mon, 11 Oct 2021, Len Baker wrote: > > Hi, > > > > On Sun, Oct 03, 2021 at 12:42:58PM +0200, Len Baker wrote: > >> As noted in the "Deprecated Interfaces, Language Features, Attributes, > >> and Conventions" documentation [1], size

Re: [PATCH 1/4] drm: Introduce drm_modeset_lock_ctx_retry()

On Mon, Oct 04, 2021 at 02:15:51PM +0300, Ville Syrjälä wrote: > On Tue, Jul 20, 2021 at 03:44:49PM +0200, Daniel Vetter wrote: > > On Thu, Jul 15, 2021 at 09:49:51PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Quite a few places are hand rolling the modeset lock backoff dan

Re: [Intel-gfx] [RFC 6/8] drm/i915: Make some recently added vfuncs use full scheduling attribute

On Wed, Oct 06, 2021 at 10:12:29AM -0700, Matthew Brost wrote: > On Mon, Oct 04, 2021 at 03:36:48PM +0100, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > Code added in 71ed60112d5d ("drm/i915: Add kick_backend function to > > i915_sched_engine") and ee242ca704d3 ("drm/i915/guc: Implement

Re: [RFC PATCH] drm: Increase DRM_OBJECT_MAX_PROPERTY by 18.

On Tue, Oct 05, 2021 at 08:51:51AM +0200, Sebastian Andrzej Siewior wrote: > The warning poped up, it says it increase it by the number of occurrence. > I saw it 18 times so here it is. > It started to up since commit >2f425cf5242a0 ("drm: Fix oops in damage self-tests by mocking damage > prop

Re: [PATCH] drm/i915: Handle Intel igfx + Intel dgfx hybrid graphics setup

On Tue, Oct 05, 2021 at 03:05:25PM +0200, Thomas Hellström wrote: > Hi, Tvrtko, > > On 10/5/21 13:31, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > In short this makes i915 work for hybrid setups (DRI_PRIME=1 with Mesa) > > when rendering is done on Intel dgfx and scanout/composition on

Re: [PATCH 1/4] drm: Introduce drm_modeset_lock_ctx_retry()

On Wed, Oct 13, 2021 at 01:59:47PM +0200, Daniel Vetter wrote: > On Mon, Oct 04, 2021 at 02:15:51PM +0300, Ville Syrjälä wrote: > > On Tue, Jul 20, 2021 at 03:44:49PM +0200, Daniel Vetter wrote: > > > On Thu, Jul 15, 2021 at 09:49:51PM +0300, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > >

Re: [PATCH 03/11] drm/i915: Restructure probe to handle multi-tile platforms

On Fri, 08 Oct 2021, Matt Roper wrote: > On a multi-tile platform, each tile has its own registers + GGTT space, > and BAR 0 is extended to cover all of them. Upcoming patches will start > exposing the tiles as multiple GTs within a single PCI device. In > preparation for supporting such setups,

[PATCH] drm/bridge: nwl-dsi: Move bridge add/remove to dsi callbacks

Move the panel and bridge_{add,remove} from the bridge callbacks to the DSI callbacks to make sure we don't indicate readiness to participate in the display pipeline before the panel is attached. This was prompted by commit fb8d617f8fd6 ("drm/bridge: Centralize error message when bridge attach fai

Re: [PATCH v2 00/34] component: Make into an aggregate bus

On Thu, Oct 07, 2021 at 04:46:22PM -0400, Stephen Boyd wrote: > Quoting Andrzej Hajda (2021-10-07 03:16:27) > > Hi Stephen, > > > > On 06.10.2021 21:37, Stephen Boyd wrote: > > > This series is from discussion we had on reordering the device lists for > > > drm shutdown paths[1]. I've introduced an

Re: [PATCH RFC] virtio: wrap config->reset calls

On Wed, Oct 13, 2021 at 01:03:46PM +0200, David Hildenbrand wrote: > On 13.10.21 12:55, Michael S. Tsirkin wrote: > > This will enable cleanups down the road. > > The idea is to disable cbs, then add "flush_queued_cbs" callback > > as a parameter, this way drivers can flush any work > > queued afte

Re: [PATCH v2] dma-buf: remove restriction of IOCTL:DMA_BUF_SET_NAME

Am 13.10.21 um 01:56 schrieb Sumit Semwal: Hello Guangming, Christian, On Tue, 12 Oct 2021, 14:09 , > wrote: From: Guangming Cao mailto:guangming@mediatek.com>> > Am 09.10.21 um 07:55 schrieb guangming@mediatek.com

Re: [PATCH v2 01/34] component: Introduce struct aggregate_device

On Wed, Oct 06, 2021 at 12:37:46PM -0700, Stephen Boyd wrote: > Replace 'struct master' with 'struct aggregate_device' and then rename > 'master' to 'adev' everywhere in the code. While we're here, put a > struct device inside the aggregate device so that we can register it > with a bus_type in the

Re: [PATCH] drm/bridge: nwl-dsi: Move bridge add/remove to dsi callbacks

On Wed, Oct 13, 2021 at 5:44 PM Guido Günther wrote: > > Move the panel and bridge_{add,remove} from the bridge callbacks to the > DSI callbacks to make sure we don't indicate readiness to participate in > the display pipeline before the panel is attached. > > This was prompted by commit fb8d617f8

Re: [PATCH] Revert "drm/fb-helper: improve DRM fbdev emulation device names"

On Fri, Oct 08, 2021 at 02:02:40PM +0300, Ville Syrjälä wrote: > On Fri, Oct 08, 2021 at 09:17:08AM +0200, Javier Martinez Canillas wrote: > > This reverts commit b3484d2b03e4c940a9598aa841a52d69729c582a. > > > > That change attempted to improve the DRM drivers fbdev emulation device > > names to

Re: [PATCH] dma-buf: Update obsoluted comments on dma_buf_vmap/vunmap()

On Fri, Oct 08, 2021 at 02:09:41PM +0200, Christian König wrote: > Am 08.10.21 um 13:20 schrieb Shunsuke Mie: > > A comment for the dma_buf_vmap/vunmap() is not catching up a > > corresponding implementation. > > > > Signed-off-by: Shunsuke Mie > > Reviewed-by: Christian König You're also push

[PATCH] drm/i915: Use dma_resv_iter for waiting in i915_gem_object_wait_reservation.

No memory should be allocated when calling i915_gem_object_wait, because it may be called to idle a BO when evicting memory. Fix this by using dma_resv_iter helpers to call i915_gem_object_wait_fence() on each fence, which cleans up the code a lot. Also remove dma_resv_prune, it's questionably. T

Re: [RFC PATCH] drm: Increase DRM_OBJECT_MAX_PROPERTY by 18.

On 2021-10-13 14:02:59 [+0200], Daniel Vetter wrote: > On Tue, Oct 05, 2021 at 08:51:51AM +0200, Sebastian Andrzej Siewior wrote: > > The warning poped up, it says it increase it by the number of occurrence. > > I saw it 18 times so here it is. > > It started to up since commit > >2f425cf5242a0

Re: [PATCH 1/6] drm/i915: Update dma_fence_work

On Fri, Oct 08, 2021 at 03:35:25PM +0200, Thomas Hellström wrote: > Move the release callback to after fence signaling to align with > what's done for upcoming VM_BIND user-fence signaling. > > Finally call the work callback regardless of whether we have a fence > error or not and update the exist

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Add a struct dma_fence_work timeline

On Fri, Oct 08, 2021 at 03:35:28PM +0200, Thomas Hellström wrote: > The TTM managers and, possibly, the gtt address space managers will > need to be able to order fences for async operation. > Using dma_fence_is_later() for this will require that the fences we hand > them are from a single fence co

Re: [PATCH 0/5] drm/vmwgfx: Support module unload and hotunplug

On Tue, Oct 12, 2021 at 05:34:50PM +, Zack Rusin wrote: > On Tue, 2021-10-12 at 11:10 +0200, Thomas Hellström wrote: > > On Tue, 2021-10-12 at 10:27 +0200, Christian König wrote: > > > Am 11.10.21 um 14:04 schrieb Thomas Hellström: > > > > > > > > > > > > > > So now if this is going to be ch

Re: [RFC PATCH] drm: Increase DRM_OBJECT_MAX_PROPERTY by 18.

On Wed, Oct 13, 2021 at 02:35:25PM +0200, Sebastian Andrzej Siewior wrote: > On 2021-10-13 14:02:59 [+0200], Daniel Vetter wrote: > > On Tue, Oct 05, 2021 at 08:51:51AM +0200, Sebastian Andrzej Siewior wrote: > > > The warning poped up, it says it increase it by the number of occurrence. > > > I sa

Re: [PATCH 1/6] drm/i915: Update dma_fence_work

On 10/13/21 14:41, Daniel Vetter wrote: On Fri, Oct 08, 2021 at 03:35:25PM +0200, Thomas Hellström wrote: Move the release callback to after fence signaling to align with what's done for upcoming VM_BIND user-fence signaling. Finally call the work callback regardless of whether we have a fenc

Re: [PATCH v2] drm/locking: add backtrace for locking contended locks without backoff

On Fri, 01 Oct 2021, Jani Nikula wrote: > If drm_modeset_lock() returns -EDEADLK, the caller is supposed to drop > all currently held locks using drm_modeset_backoff(). Failing to do so > will result in warnings and backtraces on the paths trying to lock a > contended lock. Add support for optiona

Re: (subset) [PATCH] drm/vc4: crtc: Make sure the HDMI controller is powered when disabling

On Thu, 23 Sep 2021 20:50:13 +0200, Maxime Ripard wrote: > Since commit 875a4d536842 ("drm/vc4: drv: Disable the CRTC at boot > time"), during the initial setup of the driver we call into the VC4 HDMI > controller hooks to make sure the controller is properly disabled. > > However, we were never m

Re: [PATCH v2] component: do not leave master devres group open after bind

On Wed, Oct 06, 2021 at 04:47:57PM +0300, Kai Vehmanen wrote: > Hi, > > On Tue, 5 Oct 2021, Greg KH wrote: > > > On Wed, Sep 22, 2021 at 11:54:32AM +0300, Kai Vehmanen wrote: > > > In current code, the devres group for aggregate master is left open > > > after call to component_master_add_*(). Th

Re: [PATCH RFC] virtio: wrap config->reset calls

On Wed, Oct 13, 2021 at 06:55:31AM -0400, Michael S. Tsirkin wrote: > This will enable cleanups down the road. > The idea is to disable cbs, then add "flush_queued_cbs" callback > as a parameter, this way drivers can flush any work > queued after callbacks have been disabled. > > Signed-off-by: Mi

Re: DRM KUnit hackathon

On Mon, Oct 11, 2021 at 10:23:33AM -0500, Nícolas F. R. A. Prado wrote: > Hello, > > We belong to a student group, LKCAMP [1], which is focused on sharing kernel > and > free software development knowledge and mentoring newcomers to become > contributors to these projects. > > As part of our eff

Re: Should multiple PRIME_FD_TO_HANDLE ioctls on the same fd require multiple GEM_CLOSE?

On Tue, Oct 12, 2021 at 07:37:11PM +0100, John Cox wrote: > On Tue, 12 Oct 2021 17:33:18 +, you wrote: > > >Yes, this is expected behavior, even if it's not intuitive. For more > >details, see: > > > >https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/110 > > Thanks - as noted in that d

Re: [PATCH v1 00/12] MEMORY_DEVICE_COHERENT for CPU-accessible coherent device memory

On Tue, Oct 12, 2021 at 03:56:29PM -0300, Jason Gunthorpe wrote: > On Tue, Oct 12, 2021 at 11:39:57AM -0700, Andrew Morton wrote: > > On Tue, 12 Oct 2021 12:12:35 -0500 Alex Sierra wrote: > > > > > This patch series introduces MEMORY_DEVICE_COHERENT, a type of memory > > > owned by a device that

Re: [PATCH 03/14] drm/i915/xehpsdv: enforce min GTT alignment

On Mon, Oct 11, 2021 at 09:41:44PM +0530, Ramalingam C wrote: > From: Matthew Auld > > For local-memory objects we need to align the GTT addresses to 64K, both > for the ppgtt and ggtt. > > Signed-off-by: Matthew Auld > Signed-off-by: Stuart Summers > Signed-off-by: Ramalingam C > Cc: Joonas

[PATCH 2/3] drm/amdgpu:move vram manager defines into a header file

Move vram related defines and inline functions into a separate header file Signed-off-by: Arunpravin --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h | 72 1 file changed, 72 insertions(+) create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h diff --git a/drivers

[PATCH 3/3] drm/amdgpu: Replace drm_mm with drm buddy manager

Add drm buddy allocator support for vram memory management Signed-off-by: Arunpravin --- .../gpu/drm/amd/amdgpu/amdgpu_res_cursor.h| 97 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 251 ++ 3 files changed, 2

Re: [PATCH] drm/i915: Use dma_resv_iter for waiting in i915_gem_object_wait_reservation.

Hi Maarten, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.15-rc5 next-20211013] [cannot apply to airlied/drm-next] [If your patch is applied to

Re: [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

Hi John, On Wed, Sep 29, 2021 at 04:29:42PM -0700, John Stultz wrote: > On Wed, Sep 29, 2021 at 2:51 PM John Stultz wrote: > > > > On Wed, Sep 29, 2021 at 2:32 PM John Stultz wrote: > > > On Wed, Sep 29, 2021 at 2:27 PM John Stultz > > > wrote: > > > > On Fri, Sep 10, 2021 at 3:12 AM Maxime Ri

Re: [PATCH 13/14] drm/i915/uapi: document behaviour for DG2 64K support

On Mon, Oct 11, 2021 at 09:41:54PM +0530, Ramalingam C wrote: > From: Matthew Auld > > On discrete platforms like DG2, we need to support a minimum page size > of 64K when dealing with device local-memory. This is quite tricky for > various reasons, so try to document the new implicit uapi for th

Re: [PATCH 14/14] Doc/gpu/rfc/i915: i915 DG2 uAPI

On Mon, Oct 11, 2021 at 09:41:55PM +0530, Ramalingam C wrote: > Details of the new features getting added as part of DG2 enabling and their > implicit impact on the uAPI. > > Signed-off-by: Ramalingam C > cc: Daniel Vetter > cc: Matthew Auld > --- > Documentation/gpu/rfc/i915_dg2.rst | 47

Re: [PATCH 00/14] drm/i915/dg2: Enabling 64k page size and flat ccs

On Mon, Oct 11, 2021 at 09:41:41PM +0530, Ramalingam C wrote: > This series introduces the enabling patches for new flat ccs feature and > 64k page support for i915 local memory, along with documentation on the > uAPI impact. > > 64k page support > > > On discrete platforms, star

Re: [PATCH 1/3] drm:Enable buddy allocator support

On Wed, Oct 13, 2021 at 07:05:34PM +0530, Arunpravin wrote: > Port Intel buddy manager to drm root folder One patch to move it 1:1, then follow-up patches to change it. Not everything in one. Also i915 needs to be adopted to use this too, or this just doesn't make sense. I'm also wondering wheth

Re: [Intel-gfx] [PATCH] drm/i915: Use dma_resv_iter for waiting in i915_gem_object_wait_reservation.

On Wed, Oct 13, 2021 at 02:32:03PM +0200, Maarten Lankhorst wrote: > No memory should be allocated when calling i915_gem_object_wait, > because it may be called to idle a BO when evicting memory. > > Fix this by using dma_resv_iter helpers to call > i915_gem_object_wait_fence() on each fence, whic

Re: [PATCH 03/28] dma-buf: add dma_resv selftest v3

On Tue, Oct 05, 2021 at 01:37:17PM +0200, Christian König wrote: > Just exercising a very minor subset of the functionality, but already > proven useful. > > v2: add missing locking > v3: some more cleanup and consolidation, add unlocked test as well > > Signed-off-by: Christian König Yeah this

Re: [PATCH 11/28] drm/amdgpu: use the new iterator in amdgpu_sync_resv

On Tue, Oct 05, 2021 at 01:37:25PM +0200, Christian König wrote: > Simplifying the code a bit. > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter Yeah these iterators rock :-) -Daniel > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 44 > 1 file changed,

Re: [PATCH 12/28] drm/amdgpu: use new iterator in amdgpu_ttm_bo_eviction_valuable

On Tue, Oct 05, 2021 at 01:37:26PM +0200, Christian König wrote: > Simplifying the code a bit. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 14 -- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/a

Re: [PATCH] fbdev: Garbage collect fbdev scrolling acceleration, part 1 (from TODO list)

Hi Am 01.10.21 um 14:48 schrieb Claudio Suarez: On Fri, Oct 01, 2021 at 10:21:44AM +0200, Thomas Zimmermann wrote: Hi Am 30.09.21 um 17:10 schrieb Claudio: Scroll acceleration is disabled in fbcon by hard-wiring p->scrollmode = SCROLL_REDRAW. Remove the obsolete code in fbcon.c and fbdev/core

Re: [PATCH 13/28] drm/amdgpu: use new iterator in amdgpu_vm_prt_fini

On Tue, Oct 05, 2021 at 01:37:27PM +0200, Christian König wrote: > No need to actually allocate an array of fences here. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 26 +- > 1 file changed, 5 insertions(+), 21 deletions(-) > > diff

Re: [PATCH v9 2/4] dt-bindings: mfd: logicvc: Add patternProperties for the display

Hi Lee, On Wed, Sep 22, 2021 at 4:46 PM Lee Jones wrote: > On Tue, 14 Sep 2021, Paul Kocialkowski wrote: > > The LogiCVC multi-function device has a display part which is now > > described in its binding. Add a patternProperties match for it. > > > > Signed-off-by: Paul Kocialkowski > > --- > >

Re: [PATCH 03/14] drm/i915/xehpsdv: enforce min GTT alignment

On 13/10/2021 14:38, Daniel Vetter wrote: On Mon, Oct 11, 2021 at 09:41:44PM +0530, Ramalingam C wrote: From: Matthew Auld For local-memory objects we need to align the GTT addresses to 64K, both for the ppgtt and ggtt. Signed-off-by: Matthew Auld Signed-off-by: Stuart Summers Signed-off-by

Re: [PATCH 14/28] drm/msm: use new iterator in msm_gem_describe

On Tue, Oct 05, 2021 at 01:37:28PM +0200, Christian König wrote: > Simplifying the code a bit. Also drop the RCU read side lock since the > object is locked anyway. > > Untested since I can't get the driver to compile on !ARM. Cross-compiler install is pretty easy and you should have that for pus

Re: [PATCH v8 1/4] dt-bindings: display: Document the Xylon LogiCVC display controller

Hi Paul, On Wed, Dec 23, 2020 at 10:32 PM Paul Kocialkowski wrote: > The Xylon LogiCVC is a display controller implemented as programmable > logic in Xilinx FPGAs. > > Signed-off-by: Paul Kocialkowski > Acked-by: Rob Herring > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/xyl

Re: [PATCH 15/28] drm/radeon: use new iterator in radeon_sync_resv

On Tue, Oct 05, 2021 at 01:37:29PM +0200, Christian König wrote: > Simplifying the code a bit. > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/radeon/radeon_sync.c | 22 +++--- > 1 file changed, 3 insertions(+), 19 deletions(-) > > diff -

Re: [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

Hi Caleb, On Thu, Sep 30, 2021 at 09:20:52PM +0100, Caleb Connolly wrote: > Hi, > > On 30/09/2021 20:49, Amit Pundir wrote: > > On Thu, 30 Sept 2021 at 04:50, Rob Clark wrote: > > > > > > On Wed, Sep 29, 2021 at 2:51 PM John Stultz > > > wrote: > > > > > > > > On Wed, Sep 29, 2021 at 2:32 PM

Re: [PATCH 17/28] drm/i915: use the new iterator in i915_gem_busy_ioctl v2

On Tue, Oct 05, 2021 at 02:44:50PM +0200, Christian König wrote: > Am 05.10.21 um 14:40 schrieb Tvrtko Ursulin: > > > > On 05/10/2021 12:37, Christian König wrote: > > > This makes the function much simpler since the complex > > > retry logic is now handled else where. > > > > > > Signed-off-by:

Re: [PATCH 23/28] drm: use new iterator in drm_gem_fence_array_add_implicit v3

On Tue, Oct 05, 2021 at 01:37:37PM +0200, Christian König wrote: > Simplifying the code a bit. > > v2: add missing rcu_read_lock()/unlock() > v3: switch to locked version > > Signed-off-by: Christian König > Reviewed-by: Tvrtko Ursulin Please make sure you also apply this to the new copy of th

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Add a struct dma_fence_work timeline

On Wed, 2021-10-13 at 14:43 +0200, Daniel Vetter wrote: > On Fri, Oct 08, 2021 at 03:35:28PM +0200, Thomas Hellström wrote: > > The TTM managers and, possibly, the gtt address space managers will > > need to be able to order fences for async operation. > > Using dma_fence_is_later() for this will r

Re: [PATCH 24/28] drm: use new iterator in drm_gem_plane_helper_prepare_fb v2

On Tue, Oct 05, 2021 at 01:37:38PM +0200, Christian König wrote: > Makes the handling a bit more complex, but avoids the use of > dma_resv_get_excl_unlocked(). > > v2: improve coding and documentation > > Signed-off-by: Christian König > --- > drivers/gpu/drm/drm_gem_atomic_helper.c | 13 ++

Re: [PATCH 25/28] drm/nouveau: use the new iterator in nouveau_fence_sync

On Tue, Oct 05, 2021 at 01:37:39PM +0200, Christian König wrote: > Simplifying the code a bit. > > Signed-off-by: Christian König A bit a trick conversion since the previous code was clever with the ret handling in the loop, but looks correct. Please mention in the commit message that this code

Re: [PATCH 26/28] drm/nouveau: use the new interator in nv50_wndw_prepare_fb

On Tue, Oct 05, 2021 at 01:37:40PM +0200, Christian König wrote: > Makes the handling a bit more complex, but avoids the use of > dma_resv_get_excl_unlocked(). > > Signed-off-by: Christian König > --- > drivers/gpu/drm/nouveau/dispnv50/wndw.c | 10 +- > 1 file changed, 9 insertions(+), 1

Re: [PATCH 27/28] drm/etnaviv: use new iterator in etnaviv_gem_describe

On Tue, Oct 05, 2021 at 01:37:41PM +0200, Christian König wrote: > Instead of hand rolling the logic. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 31 ++- > 1 file changed, 11 insertions(+), 20 deletions(-) > > diff --git a/drivers/g

Re: [PATCH 28/28] drm/etnaviv: replace dma_resv_get_excl_unlocked

On Tue, Oct 05, 2021 at 01:37:42PM +0200, Christian König wrote: > We certainly hold the reservation lock here, no need for the RCU dance. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --g

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Add a struct dma_fence_work timeline

On Wed, Oct 13, 2021 at 04:21:43PM +0200, Thomas Hellström wrote: > On Wed, 2021-10-13 at 14:43 +0200, Daniel Vetter wrote: > > On Fri, Oct 08, 2021 at 03:35:28PM +0200, Thomas Hellström wrote: > > > The TTM managers and, possibly, the gtt address space managers will > > > need to be able to order

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Add a struct dma_fence_work timeline

On 10/13/21 16:33, Daniel Vetter wrote: On Wed, Oct 13, 2021 at 04:21:43PM +0200, Thomas Hellström wrote: On Wed, 2021-10-13 at 14:43 +0200, Daniel Vetter wrote: On Fri, Oct 08, 2021 at 03:35:28PM +0200, Thomas Hellström wrote: The TTM managers and, possibly, the gtt address space managers w

[PATCH] drm/tegra: mark nvdec_writel as inline

From: Arnd Bergmann Without CONFIG_IOMMU_API, the nvdec_writel() function is unused, causing a warning: drivers/gpu/drm/tegra/nvdec.c:48:13: error: 'nvdec_writel' defined but not used [-Werror=unused-function] 48 | static void nvdec_writel(struct nvdec *nvdec, u32 value, unsigned int offset

Re: [PATCH 2/6] drm/i915: Introduce refcounted sg-tables

On Fri, Oct 08, 2021 at 03:35:26PM +0200, Thomas Hellström wrote: > As we start to introduce asynchronous failsafe object migration, > where we update the object state and then submit asynchronous > commands we need to record what memory resources are actually used > by various part of the command

[PATCH] drm/tegra: mark nvdec PM functions as __maybe_unused

From: Arnd Bergmann The resume helper is called conditionally and causes a harmless warning when stubbed out: drivers/gpu/drm/tegra/nvdec.c:240:12: error: 'nvdec_runtime_resume' defined but not used [-Werror=unused-function] 240 | static int nvdec_runtime_resume(struct device *dev) Mark both

[PATCH] drm/amd/display: fix apply_degamma_for_user_regamma() warning

From: Arnd Bergmann It appears that the wrong argument was removed in this call: drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c: In function 'apply_degamma_for_user_regamma': drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c:1694:36: error: implicit conversio

[PATCH] drm: msm: fix building without CONFIG_COMMON_CLK

From: Arnd Bergmann When CONFIG_COMMON_CLOCK is disabled, the 8996 specific phy code is left out, which results in a link failure: ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg' This was only exposed after it became possible to build tes

[PATCH v2] drm/cma-helper: Set VM_DONTEXPAND for mmap

From: Robin Murphy drm_gem_cma_mmap() cannot assume every implementation of dma_mmap_wc() will end up calling remap_pfn_range() (which happens to set the relevant vma flag, among others), so in order to make sure expectations around VM_DONTEXPAND are met, let it explicitly set the flag like most

Re: [PATCH 2/6] drm/i915: Introduce refcounted sg-tables

On 10/13/21 16:41, Daniel Vetter wrote: On Fri, Oct 08, 2021 at 03:35:26PM +0200, Thomas Hellström wrote: As we start to introduce asynchronous failsafe object migration, where we update the object state and then submit asynchronous commands we need to record what memory resources are actually

Re: [PATCH 0/5] drm/vmwgfx: Support module unload and hotunplug

On Wed, 2021-10-13 at 14:50 +0200, Daniel Vetter wrote: > On Tue, Oct 12, 2021 at 05:34:50PM +, Zack Rusin wrote: > > > On the flip side that does mean that vmwgfx and i915 need to redo > > some > > code. For vmwgfx it's probably a net positive anyway as we've been > > using TTM for, what is r

Re: 572994bf18ff prevents system boot

> On Oct 8, 2021, at 4:49 AM, Thomas Zimmermann wrote: > > Hi > > Am 04.10.21 um 16:11 schrieb Chuck Lever III: >>> On Oct 4, 2021, at 10:07 AM, Thomas Zimmermann wrote: >>> >>> Hi >>> >>> Am 04.10.21 um 15:34 schrieb Chuck Lever III: > On Oct 4, 2021, at 3:07 AM, Thomas Zimmermann wro

Re: Regression with mainline kernel on rpi4

On Thu, Sep 30, 2021 at 11:19:59AM +0200, Daniel Vetter wrote: > On Tue, Sep 28, 2021 at 10:34:46AM +0200, Maxime Ripard wrote: > > Hi Daniel, > > > > On Sat, Sep 25, 2021 at 12:50:17AM +0200, Daniel Vetter wrote: > > > On Fri, Sep 24, 2021 at 3:30 PM Maxime Ripard wrote: > > > > > > > > On Wed,

Re: [Intel-gfx] [PATCH] drm/i915: Use dma_resv_iter for waiting in i915_gem_object_wait_reservation.

On 13/10/2021 15:00, Daniel Vetter wrote: On Wed, Oct 13, 2021 at 02:32:03PM +0200, Maarten Lankhorst wrote: No memory should be allocated when calling i915_gem_object_wait, because it may be called to idle a BO when evicting memory. Fix this by using dma_resv_iter helpers to call i915_gem_ob

Re: [Intel-gfx] [RFC 6/8] drm/i915: Make some recently added vfuncs use full scheduling attribute

On 13/10/2021 13:01, Daniel Vetter wrote: On Wed, Oct 06, 2021 at 10:12:29AM -0700, Matthew Brost wrote: On Mon, Oct 04, 2021 at 03:36:48PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Code added in 71ed60112d5d ("drm/i915: Add kick_backend function to i915_sched_engine") and ee242ca70

Re: [PATCH RFC] virtio: wrap config->reset calls

On 13.10.21 14:17, Michael S. Tsirkin wrote: > On Wed, Oct 13, 2021 at 01:03:46PM +0200, David Hildenbrand wrote: >> On 13.10.21 12:55, Michael S. Tsirkin wrote: >>> This will enable cleanups down the road. >>> The idea is to disable cbs, then add "flush_queued_cbs" callback >>> as a parameter, thi

Re: [PATCH] drm/i915: Handle Intel igfx + Intel dgfx hybrid graphics setup

On 13/10/2021 13:06, Daniel Vetter wrote: On Tue, Oct 05, 2021 at 03:05:25PM +0200, Thomas Hellström wrote: Hi, Tvrtko, On 10/5/21 13:31, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In short this makes i915 work for hybrid setups (DRI_PRIME=1 with Mesa) when rendering is done on Intel dgfx

Re: [PATCH 2/2] drm/i915/pmu: Connect engine busyness stats from GuC to pmu

On 13/10/2021 01:56, Umesh Nerlige Ramappa wrote: With GuC handling scheduling, i915 is not aware of the time that a context is scheduled in and out of the engine. Since i915 pmu relies on this info to provide engine busyness to the user, GuC shares this info with i915 for all engines using sha

Re: [PATCH] drm: Update MST First Link Slot Information Based on Encoding Format

On Tue, 12 Oct 2021, Bhawanpreet Lakha wrote: > 8b/10b encoding format requires to reserve the first slot for > recording metadata. Real data transmission starts from the second slot, > with a total of available 63 slots available. > > In 128b/132b encoding format, metadata is transmitted separate

[PATCH v2 2/7] nouveau: ACPI: Use the ACPI_COMPANION() macro directly

From: Rafael J. Wysocki The ACPI_HANDLE() macro is a wrapper arond the ACPI_COMPANION() macro and the ACPI handle produced by the former comes from the ACPI device object produced by the latter, so it is way more straightforward to evaluate the latter directly instead of passing the handle produc

Re: [Intel-gfx] [PATCH] drm/i915: Use dma_resv_iter for waiting in i915_gem_object_wait_reservation.

On Wed, Oct 13, 2021 at 04:37:03PM +0100, Tvrtko Ursulin wrote: > > On 13/10/2021 15:00, Daniel Vetter wrote: > > On Wed, Oct 13, 2021 at 02:32:03PM +0200, Maarten Lankhorst wrote: > > > No memory should be allocated when calling i915_gem_object_wait, > > > because it may be called to idle a BO wh

  1   2   3   >