Re: [PATCH] drm/msm: Avoid potential overflow in timeout_to_jiffies()

On Fri, Sep 17, 2021 at 2:59 AM Marek Vasut wrote: > > The return type of ktime_divns() is s64. The timeout_to_jiffies() currently > assigns the result of this ktime_divns() to unsigned long, which on 32 bit > systems may overflow. Furthermore, the result of this function is sometimes > also passe

linux-next: build failure after merge of the drm-misc tree

Hi all, After merging the drm-misc tree, today's linux-next build (x86_64 modules_install) failed like this: depmod: ERROR: Cycle detected: drm_kms_helper -> drm -> drm_kms_helper depmod: ERROR: Cycle detected: cec depmod: ERROR: Found 2 modules in dependency cycles! Caused by commit 87ea9580

[PATCH] drm/ast: Atomic CR/SR reg R/W

1. Avoid IO-index racing 2. IO-index racing happened on resolustion switching and mouse moving at the same time 3. System hung while IO-index racing occurred. Signed-off-by: KuoHsiang Chou --- drivers/gpu/drm/ast/ast_main.c | 48 +- 1 file changed, 36 insertion

Re: [Intel-gfx] [PATCH v2] drm/i915: use strscpy() to avoid buffer overrun

On 16/09/2021 13:26, Tim Gardner wrote: In capture_vma() Coverity complains of a possible buffer overrun. Even though this is a static function where all call sites can be checked, limiting the copy length could save some future grief. CID 93300 (#1 of 1): Copy into fixed size buffer (STRING_O

Re: [PATCH 1/2] backlight: bd6107: Make use of the helper function dev_err_probe()

On Fri, Sep 17, 2021 at 11:13:06AM +0800, Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value

Re: [PATCH] drm/v3d: fix sched job resources cleanup when a job is aborted

On 09/17, Iago Toral wrote: > Reviewed-by: Iago Toral Quiroga > > With that said, I don't like how we are doing error handling here, I > think we want to simplify this and try to make it so we centralize > error handling in one place instead of having multiple error exits > paths, each one trying

Re: [PATCH v2] drm/panfrost: Calculate lock region size correctly

On 03/09/2021 10:49, Steven Price wrote: > It turns out that when locking a region, the region must be a naturally > aligned power of 2. The upshot of this is that if the desired region > crosses a 'large boundary' the region size must be increased > significantly to ensure that the locked region c

[kbuild] Re: [PATCH v2 04/13] drm/hdcp: Expand HDCP helper library for enable/disable/check

Hi Sean, url: https://github.com/0day-ci/linux/commits/Sean-Paul/drm-hdcp-Pull-HDCP-auth-exchange-check-into-helpers/20210916-044145 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: x86_64-randconfig-m001-20210916 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22)

Re: [PATCH 1/2] backlight: bd6107: Make use of the helper function dev_err_probe()

Hi Thanks for your feedback. On 17 9月 21 10:17:29, Daniel Thompson wrote: > On Fri, Sep 17, 2021 at 11:13:06AM +0800, Cai Huoqing wrote: > > When possible use dev_err_probe help to properly deal with the > > PROBE_DEFER error, the benefit is that DEFER issue will be logged > > in the devices_deferr

[syzbot] kernel BUG in vmf_insert_pfn_prot

Hello, syzbot found the following issue on: HEAD commit:9004fd387338 Add linux-next specific files for 20210917 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=17ecf0ad30 kernel config: https://syzkaller.appspot.com/x/.config?x=45d5ac72f31f29f3

Re: [PATCH v2 0/9] Move vfio_ccw to the new mdev API

On Tue, Sep 14 2021, Jason Gunthorpe wrote: > On Mon, Sep 13, 2021 at 04:31:54PM -0400, Eric Farman wrote: >> > I rebased it and fixed it up here: >> > >> > https://github.com/jgunthorpe/linux/tree/vfio_ccw >> > >> > Can you try again? >> >> That does address the crash, but then why is it proc

Re: [PATCH v3 3/6] drm/i915 Implement LMEM backup and restore for suspend / resume

On 14/09/2021 20:31, Thomas Hellström wrote: Just evict unpinned objects to system. For pinned LMEM objects, make a backup system object and blit the contents to that. Backup is performed in three steps, 1: Opportunistically evict evictable objects using the gpu blitter. 2: After gt idle, evict

Re: [PATCH 01/14] dma-buf: add dma_resv_for_each_fence_unlocked

On Fri, Sep 17, 2021 at 08:32:49AM +0200, Christian König wrote: > Am 16.09.21 um 16:09 schrieb Daniel Vetter: > > On Thu, Sep 16, 2021 at 02:49:26PM +0200, Christian König wrote: > > > Am 16.09.21 um 14:14 schrieb Daniel Vetter: > > > > On Thu, Sep 16, 2021 at 10:50 AM Christian König > > > > wr

Re: [PATCH v6 0/2] Add p2p via dmabuf to habanalabs

On Thu, Sep 16, 2021 at 03:44:25PM +0300, Oded Gabbay wrote: > On Thu, Sep 16, 2021 at 3:31 PM Daniel Vetter wrote: > > > > On Wed, Sep 15, 2021 at 10:45:36AM +0300, Oded Gabbay wrote: > > > On Tue, Sep 14, 2021 at 7:12 PM Jason Gunthorpe wrote: > > > > > > > > On Tue, Sep 14, 2021 at 04:18:31PM

Re: [PATCH v6 0/2] Add p2p via dmabuf to habanalabs

On Thu, Sep 16, 2021 at 10:10:14AM -0300, Jason Gunthorpe wrote: > On Thu, Sep 16, 2021 at 02:31:34PM +0200, Daniel Vetter wrote: > > On Wed, Sep 15, 2021 at 10:45:36AM +0300, Oded Gabbay wrote: > > > On Tue, Sep 14, 2021 at 7:12 PM Jason Gunthorpe wrote: > > > > > > > > On Tue, Sep 14, 2021 at 04

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Do not define vma on stack

On Tue, Sep 14, 2021 at 02:10:22PM -0700, Matthew Brost wrote: > On Tue, Sep 14, 2021 at 10:05:03PM +0200, Daniel Vetter wrote: > > On Tue, Sep 14, 2021 at 08:36:56AM -0700, Matthew Brost wrote: > > > On Tue, Sep 14, 2021 at 03:04:59PM +1000, Dave Airlie wrote: > > > > On Tue, 14 Sept 2021 at 14:55

Re: [PATCH 1/2] backlight: bd6107: Make use of the helper function dev_err_probe()

On Fri, Sep 17, 2021 at 07:05:28PM +0800, Cai Huoqing wrote: > Hi > Thanks for your feedback. > On 17 9月 21 10:17:29, Daniel Thompson wrote: > > On Fri, Sep 17, 2021 at 11:13:06AM +0800, Cai Huoqing wrote: > > > When possible use dev_err_probe help to properly deal with the > > > PROBE_DEFER error,

Deploying new iterator interface for dma-buf

Hopefully the last round for this. Added dma_resv_iter_begin/end as requested by Daniel. Fixed a bunch of problems pointed out by the CI systems and found a few more myselve. Please review and/or comment, Christian.

[PATCH 02/26] dma-buf: add dma_resv_for_each_fence

A simpler version of the iterator to be used when the dma_resv object is locked. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 33 + include/linux/dma-resv.h | 17 + 2 files changed, 50 insertions(+) diff --git a/drivers/dma-bu

[PATCH 05/26] dma-buf: use new iterator in dma_resv_wait_timeout

This makes the function much simpler since the complex retry logic is now handled elsewhere. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 68 ++ 1 file changed, 10 insertions(+), 58 deletions(-) diff --git a/drivers/dma-buf/dma-resv.c b/dri

[PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked v2

Abstract the complexity of iterating over all the fences in a dma_resv object. The new loop handles the whole RCU and retry dance and returns only fences where we can be sure we grabbed the right one. v2: fix accessing the shared fences while they might be freed, improve kerneldoc, rename _cu

[PATCH 03/26] dma-buf: use new iterator in dma_resv_copy_fences

This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 86 -- 1 file changed, 35 insertions(+), 51 deletions(-) diff --git a/drivers/dma-buf/dma-resv.c b/dr

[PATCH 06/26] dma-buf: use new iterator in dma_resv_test_signaled

This makes the function much simpler since the complex retry logic is now handled elsewhere. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 56 ++ 1 file changed, 9 insertions(+), 47 deletions(-) diff --git a/drivers/dma-buf/dma-resv.c b/driv

[PATCH 11/26] drm/radeon: use new iterator in radeon_sync_resv

Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_sync.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_sync.c b/drivers/gpu/drm/radeon/radeon_sync.c index 9257b60144c4..b991ba1

[PATCH 15/26] drm/i915: use the new iterator in i915_request_await_object v2

Simplifying the code a bit. v2: add missing rcu_read_lock()/rcu_read_unlock() v3: use dma_resv_for_each_fence instead Signed-off-by: Christian König --- drivers/gpu/drm/i915/i915_request.c | 34 + 1 file changed, 5 insertions(+), 29 deletions(-) diff --git a/drivers

[PATCH 13/26] drm/i915: use the new iterator in i915_gem_busy_ioctl

This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_busy.c | 32 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_g

[PATCH 22/26] drm/nouveau: use the new iterator in nouveau_fence_sync

Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_fence.c | 48 +++-- 1 file changed, 12 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c index 05d0b3eb

[PATCH 26/26] dma-buf: nuke dma_resv_get_excl_unlocked

Heureka, that's finally not used any more. Signed-off-by: Christian König --- include/linux/dma-resv.h | 26 -- 1 file changed, 26 deletions(-) diff --git a/include/linux/dma-resv.h b/include/linux/dma-resv.h index 8c968f8c9d33..f42ca254acb5 100644 --- a/include/linux/dm

[PATCH 10/26] drm/msm: use new iterator in msm_gem_describe

Simplifying the code a bit. Also drop the RCU read side lock since the object is locked anyway. Untested since I can't get the driver to compile on !ARM. Signed-off-by: Christian König --- drivers/gpu/drm/msm/msm_gem.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-)

[PATCH 08/26] drm/amdgpu: use the new iterator in amdgpu_sync_resv

Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 44 1 file changed, 14 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c index 862eb3

[PATCH 09/26] drm/amdgpu: use new iterator in amdgpu_ttm_bo_eviction_valuable

Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index 1129e17e9f09..4511cd

[PATCH 20/26] drm: use new iterator in drm_gem_fence_array_add_implicit v2

Simplifying the code a bit. v2: add missing rcu_read_lock()/unlock() Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem.c | 34 -- 1 file changed, 12 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index

[PATCH 04/26] dma-buf: use new iterator in dma_resv_get_fences v2

This makes the function much simpler since the complex retry logic is now handled elsewhere. v2: use sizeof(void*) instead Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 112 + 1 file changed, 40 insertions(+), 72 deletions(-) diff --git a/d

[PATCH 21/26] drm: use new iterator in drm_gem_plane_helper_prepare_fb v2

Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). v2: add missing rcu_read_lock()/unlock() Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_atomic_helper.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/driv

[PATCH 23/26] drm/nouveau: use the new interator in nv50_wndw_prepare_fb v2

Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). v2: add missing rcu_read_lock()/unlock() Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine v2

This is maybe even a fix since the RCU usage here looks incorrect. v2: add missing rcu_read_lock()/unlock() Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_object.h | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i

[PATCH 17/26] drm/i915: use new iterator in i915_gem_object_wait_priority v2

Simplifying the code a bit. v2: add missing rcu_read_lock()/unlock() Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 34 +++- 1 file changed, 10 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu

[PATCH 24/26] drm/etnaviv: use new iterator in etnaviv_gem_describe

Instead of hand rolling the logic. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 29 ++- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c index 8f1b5

[PATCH 16/26] drm/i915: use new iterator in i915_gem_object_wait_reservation v2

Simplifying the code a bit. v2: add missing rcu read unlock. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 57 ++-- 1 file changed, 14 insertions(+), 43 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i91

[PATCH 14/26] drm/i915: use the new iterator in i915_sw_fence_await_reservation v3

Simplifying the code a bit. v2: use dma_resv_for_each_fence instead, according to Tvrtko the lock is held here anyway. v3: back to using dma_resv_for_each_fence_unlocked. Signed-off-by: Christian König --- drivers/gpu/drm/i915/i915_sw_fence.c | 57 1 file change

[PATCH 12/26] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2

Simplifying the code a bit. v2: use dma_resv_for_each_fence Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/sched_main.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/schedul

[PATCH 19/26] drm/i915: use new cursor in intel_prepare_plane_fb v2

Simplifying the code a bit. v2: add rcu_read_lock()/unlock() Signed-off-by: Christian König --- drivers/gpu/drm/i915/display/intel_display.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/displ

[PATCH 25/26] drm/etnaviv: replace dma_resv_get_excl_unlocked

We certainly hold the reservation lock here, no need for the RCU dance. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etna

[PATCH 07/26] drm/ttm: use the new iterator in ttm_bo_flush_all_fences

This is probably a fix since we didn't even grabed a reference to the fences. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 3b22

Re: [Intel-gfx] [PATCH 4/4] drm/i915/guc: Refcount context during error capture

On Tue, Sep 14, 2021 at 04:23:26PM -0700, John Harrison wrote: > On 9/14/2021 07:29, Daniel Vetter wrote: > > On Mon, Sep 13, 2021 at 10:09:56PM -0700, Matthew Brost wrote: > > > From: John Harrison > > > > > > When i915 receives a context reset notification from GuC, it triggers > > > an error c

Re: [Intel-gfx] [PATCH 4/4] drm/i915/guc: Refcount context during error capture

On Tue, Sep 14, 2021 at 04:36:54PM -0700, Matthew Brost wrote: > On Tue, Sep 14, 2021 at 04:29:21PM +0200, Daniel Vetter wrote: > > On Mon, Sep 13, 2021 at 10:09:56PM -0700, Matthew Brost wrote: > > > From: John Harrison > > > > > > When i915 receives a context reset notification from GuC, it tri

Re: [PATCH v3 01/13] drm/dp: add DP 2.0 UHBR link rate and bw code conversions

On Thu, Sep 09, 2021 at 03:51:53PM +0300, Jani Nikula wrote: > The bw code equals link_rate / 0.27 Gbps only for 8b/10b link > rates. Handle DP 2.0 UHBR rates as special cases, though this is not > pretty. > > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Jani Nikula Reviewed-by: Ville Sy

Re: [PATCH v3 06/13] drm/i915/dp: add helper for checking for UHBR link rate

On Thu, Sep 09, 2021 at 03:51:58PM +0300, Jani Nikula wrote: > Helpful abstraction to avoid duplication. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_dp.c | 6 ++ > drivers/gpu/drm/i915/display/intel_dp.h | 1 + > 2 files changed, 7

Re: [PATCH v3 10/13] drm/i915/dp: add HAS_DP20 macro

On Thu, Sep 09, 2021 at 03:52:02PM +0300, Jani Nikula wrote: > Let's abstract the DP 2.0 feature. Initially just DG2. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/i915_drv.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i91

Re: [PATCH v4 24/24] drm/exynos: dsi: Adjust probe order

Hi, On 13.09.2021 12:30, Andrzej Hajda wrote: > W dniu 10.09.2021 o 12:12, Maxime Ripard pisze: >> Without proper care and an agreement between how DSI hosts and devices >> drivers register their MIPI-DSI entities and potential components, we can >> end up in a situation where the drivers can neve

Re: [PATCH] drm/i915/debugfs: Do not report currently active engine when describing objects

On Wed, Sep 15, 2021 at 12:41:53PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > It is not very useful to have code which tries to report a rapidly > transient state which will not report anything majority of the time, > especially since it is currently only used from > /i915_gem_frameb

Re: [PATCH 5/5] drm/vboxvideo: Use managed interfaces for framebuffer write combining

On Thu, Sep 16, 2021 at 09:28:53PM +0200, Hans de Goede wrote: > Hi, > > On 9/16/21 8:16 PM, Thomas Zimmermann wrote: > > Replace arch_phys_wc_add() with the rsp managed function. Allows for > > removing the cleanup code for memory management > > > > Signed-off-by: Thomas Zimmermann > > Thanks,

Re: [PATCH v2 0/9] Move vfio_ccw to the new mdev API

On Fri, Sep 17, 2021 at 01:59:16PM +0200, Cornelia Huck wrote: > > ret = cio_cancel_halt_clear(sch, &iretry); > > - > > if (ret == -EIO) { > > pr_err("vfio_ccw: could not quiesce subchannel > > 0.%x.%04x!\n", > >sch->schid.ssi

Re: [PATCH v3 11/13] drm/i915/dg2: use 128b/132b transcoder DDI mode

On Thu, Sep 09, 2021 at 03:52:03PM +0300, Jani Nikula wrote: > 128b/132b has a separate transcoder DDI mode, which also requires the > MST transport select to be set. Note that we'll use DP MST also for > single-stream 128b/132b. > > Having the FDI and 128b/132b modes share the register mode value

Re: [Intel-gfx] [PATCH v2 00/13] drm/hdcp: Pull HDCP auth/exchange/check into helpers

On Wed, 15 Sep 2021, Sean Paul wrote: > From: Sean Paul > > Hello again, > This is the second version of the HDCP helper patchset. See version 1 > here: https://patchwork.freedesktop.org/series/94623/ > > In this second version, I've fixed up the oopsies exposed by 0-day and > yamllint and incorp

[PATCH v2] video: backlight: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing --- v1->v2: backlight pat

Re: [PATCH v3 12/13] drm/i915/dg2: configure TRANS_DP2_VFREQ{HIGH,LOW} for 128b/132b

On Thu, Sep 09, 2021 at 03:52:04PM +0300, Jani Nikula wrote: > There's a new register pair for 128b/132b mode where you need to set the > pixel clock in Hz. > > v2: Fix UHBR rate check, use intel_dp_is_uhbr() helper > > Bspec: 54128 > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --

Re: [PATCH v3 00/13] drm/i915/dp: dp 2.0 enabling prep work

On Thu, 09 Sep 2021, Jani Nikula wrote: > v3 of https://patchwork.freedesktop.org/series/93800/ with minor tweaks > and the already merged patches obviously dropped. > > Jani Nikula (13): > drm/dp: add DP 2.0 UHBR link rate and bw code conversions > drm/dp: use more of the extended receiver ca

Re: [PATCH v3 05/13] drm/i915/dg2: add DG2+ TRANS_DDI_FUNC_CTL DP 2.0 128b/132b mode

On Thu, Sep 09, 2021 at 03:51:57PM +0300, Jani Nikula wrote: > Unfortunately, the DP 2.0 128b/132b DDI mode selection in the register > conflicts with FDI. Since we have to deal with both meanings in the same > code, for different platforms, clarify the macro name so we don't > forget. > > Bspec:

Re: [PATCH v2] kernel/locking: Add context to ww_mutex_trylock.

On Thu, Sep 16, 2021 at 03:28:11PM +0200, Peter Zijlstra wrote: > On Thu, Sep 16, 2021 at 03:00:39PM +0200, Maarten Lankhorst wrote: > > > > For merge logistics, can we pls have a stable branch? I expect that the > > > i915 patches will be ready for 5.16. > > > > > > Or send it in for -rc2 so that

Re: [PATCH v2] video: backlight: Make use of the helper function dev_err_probe()

On Fri, Sep 17, 2021 at 08:53:23PM +0800, Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value

Re: [PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked v2

On Fri, Sep 17, 2021 at 02:34:48PM +0200, Christian König wrote: > Abstract the complexity of iterating over all the fences > in a dma_resv object. > > The new loop handles the whole RCU and retry dance and > returns only fences where we can be sure we grabbed the > right one. > > v2: fix accessi

Re: [PATCH 02/26] dma-buf: add dma_resv_for_each_fence

On Fri, Sep 17, 2021 at 02:34:49PM +0200, Christian König wrote: > A simpler version of the iterator to be used when the dma_resv object is > locked. > > Signed-off-by: Christian König > --- > drivers/dma-buf/dma-resv.c | 33 + > include/linux/dma-resv.h | 17 ++

Re: [PATCH v2] video: backlight: Make use of the helper function dev_err_probe()

On 17 9月 21 14:15:29, Daniel Thompson wrote: > On Fri, Sep 17, 2021 at 08:53:23PM +0800, Cai Huoqing wrote: > > When possible use dev_err_probe help to properly deal with the > > PROBE_DEFER error, the benefit is that DEFER issue will be logged > > in the devices_deferred debugfs file. > > Using de

Re: [PATCH v1 6/6] drm/mediatek: Add mt8195 DisplayPort driver

Hi Chun-Kuang, On Tue, Sep 14, 2021 at 07:25:48AM +0800, Chun-Kuang Hu wrote: > Hi, Markus: > > Markus Schneider-Pargmann 於 2021年9月10日 週五 下午1:36寫道： > > > > Hi Chun-Kuang, > > > > On Fri, Sep 10, 2021 at 07:37:50AM +0800, Chun-Kuang Hu wrote: > > > Hi, Markus: > > > > > > Markus Schneider-Pargman

Re: [PATCH] drm/i915/debugfs: Do not report currently active engine when describing objects

On 17/09/2021 13:43, Daniel Vetter wrote: On Wed, Sep 15, 2021 at 12:41:53PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin It is not very useful to have code which tries to report a rapidly transient state which will not report anything majority of the time, especially since it is curren

Re: [PATCH 9/9] drm/i915: Add privacy-screen support

Hi, On 9/16/21 4:04 PM, Ville Syrjälä wrote: > On Thu, Sep 16, 2021 at 12:40:11PM +0300, Jani Nikula wrote: >> >> Cc: Ville for input here, see question inline. >> >> On Mon, 06 Sep 2021, Hans de Goede wrote: >>> Add support for eDP panels with a built-in privacy screen using the >>> new drm_priv

Re: [PATCH 02/26] dma-buf: add dma_resv_for_each_fence

On Fri, Sep 17, 2021 at 03:27:55PM +0200, Daniel Vetter wrote: > On Fri, Sep 17, 2021 at 02:34:49PM +0200, Christian König wrote: > > A simpler version of the iterator to be used when the dma_resv object is > > locked. > > > > Signed-off-by: Christian König > > --- > > drivers/dma-buf/dma-resv.c

Re: [PATCH 03/26] dma-buf: use new iterator in dma_resv_copy_fences

On Fri, Sep 17, 2021 at 02:34:50PM +0200, Christian König wrote: > This makes the function much simpler since the complex > retry logic is now handled else where. > > Signed-off-by: Christian König > --- > drivers/dma-buf/dma-resv.c | 86 -- > 1 file changed,

Re: [PATCH v1 6/6] drm/mediatek: Add mt8195 DisplayPort driver

Hi, Markus: Markus Schneider-Pargmann 於 2021年9月17日 週五 下午9:33寫道： > > Hi Chun-Kuang, > > On Tue, Sep 14, 2021 at 07:25:48AM +0800, Chun-Kuang Hu wrote: > > Hi, Markus: > > > > Markus Schneider-Pargmann 於 2021年9月10日 週五 下午1:36寫道： > > > > > > Hi Chun-Kuang, > > > > > > On Fri, Sep 10, 2021 at 07:37:5

Re: [PATCH 9/9] drm/i915: Add privacy-screen support

Hi, On 9/16/21 3:45 PM, Ville Syrjälä wrote: > On Mon, Sep 06, 2021 at 09:35:19AM +0200, Hans de Goede wrote: >> Add support for eDP panels with a built-in privacy screen using the >> new drm_privacy_screen class. >> >> One thing which stands out here is the addition of these 2 lines to >> intel_a

Re: [PATCH v2 0/9] Move vfio_ccw to the new mdev API

On Fri, Sep 17 2021, Jason Gunthorpe wrote: > On Fri, Sep 17, 2021 at 01:59:16PM +0200, Cornelia Huck wrote: >> >ret = cio_cancel_halt_clear(sch, &iretry); >> > - >> >if (ret == -EIO) { >> >pr_err("vfio_ccw: could not quiesce subchannel >> > 0.%x.%04x!

Re: [PATCH 04/26] dma-buf: use new iterator in dma_resv_get_fences v2

On Fri, Sep 17, 2021 at 02:34:51PM +0200, Christian König wrote: > This makes the function much simpler since the complex > retry logic is now handled elsewhere. > > v2: use sizeof(void*) instead > > Signed-off-by: Christian König > --- > drivers/dma-buf/dma-resv.c | 112 +--

Re: [PATCH 05/26] dma-buf: use new iterator in dma_resv_wait_timeout

On Fri, Sep 17, 2021 at 02:34:52PM +0200, Christian König wrote: > This makes the function much simpler since the complex > retry logic is now handled elsewhere. > > Signed-off-by: Christian König > --- > drivers/dma-buf/dma-resv.c | 68 ++ > 1 file changed, 1

Re: [PATCH 06/26] dma-buf: use new iterator in dma_resv_test_signaled

On Fri, Sep 17, 2021 at 02:34:53PM +0200, Christian König wrote: > This makes the function much simpler since the complex > retry logic is now handled elsewhere. > > Signed-off-by: Christian König > --- > drivers/dma-buf/dma-resv.c | 56 ++ > 1 file changed, 9

Re: [PATCH 0/5] lib: devres: Add managed helpers for write-combine setup

Hi, On 9/16/21 8:15 PM, Thomas Zimmermann wrote: > Add devm_arch_phys_wc_add() and devm_arch_io_reserve_memtype_wc() for > automatic cleanup of writecombine setup. > > Several DRM drivers use the non-managed functions for setting their > framebuffer memory to write-combine access. Convert ast, mg

Re: [PATCH 07/26] drm/ttm: use the new iterator in ttm_bo_flush_all_fences

On Fri, Sep 17, 2021 at 02:34:54PM +0200, Christian König wrote: > This is probably a fix since we didn't even grabed a reference to the > fences. It's rcu protected, and we only care about speeding things up a bit. I think this wont have any impact on correctness, and I don't think any driver cou

Re: [PATCH 12/26] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2

On Fri, Sep 17, 2021 at 02:34:59PM +0200, Christian König wrote: > Simplifying the code a bit. > > v2: use dma_resv_for_each_fence > > Signed-off-by: Christian König > --- > drivers/gpu/drm/scheduler/sched_main.c | 26 ++ > 1 file changed, 6 insertions(+), 20 deletions(-

Re: [PATCH 20/26] drm: use new iterator in drm_gem_fence_array_add_implicit v2

On Fri, Sep 17, 2021 at 02:35:07PM +0200, Christian König wrote: > Simplifying the code a bit. > > v2: add missing rcu_read_lock()/unlock() > > Signed-off-by: Christian König This will be gone as soon as I can land the last conversion patches. Plus it's always called with dma_resv_lock held. I

Re: [PATCH 21/26] drm: use new iterator in drm_gem_plane_helper_prepare_fb v2

On Fri, Sep 17, 2021 at 02:35:08PM +0200, Christian König wrote: > Makes the handling a bit more complex, but avoids the use of > dma_resv_get_excl_unlocked(). > > v2: add missing rcu_read_lock()/unlock() > > Signed-off-by: Christian König > --- > drivers/gpu/drm/drm_gem_atomic_helper.c | 14 ++

Re: [PATCH 26/26] dma-buf: nuke dma_resv_get_excl_unlocked

On Fri, Sep 17, 2021 at 02:35:13PM +0200, Christian König wrote: > Heureka, that's finally not used any more. > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter > --- > include/linux/dma-resv.h | 26 -- > 1 file changed, 26 deletions(-) > > diff --git a/inc

Re: [PATCH v6 4/6] drm/sprd: add Unisoc's drm display controller driver

Hi, On Fri, Aug 13, 2021 at 10:53:00PM +0800, Kevin Tang wrote: > Adds DPU(Display Processor Unit) support for the Unisoc's display > subsystem. > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. > > v2: > - Use drm_xxx to replace all DRM_XXX. > - Use kzalloc to repl

Re: [PATCH v3 2/3] drm/bridge: parade-ps8640: Use regmap APIs

Hi, On Thu, Sep 16, 2021 at 11:12 PM Stephen Boyd wrote: > > > > > In the case of devm_regmap_init_i2c(), the driver could be fine but > > > > you might be trying to instantiate it on a system whose i2c bus lacks > > > > the needed functionality. That's not a bug in the bridge driver but an > > >

Re: [PATCH 00/15] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible

On Thu, Sep 16, 2021 at 11:15:37PM +0200, Fernando Ramos wrote: > Hi all, > > One of the things in the DRM TODO list ("Documentation/gpu/todo.rst") was to > "use DRM_MODESET_LOCAL_ALL_* helpers instead of boilerplate". That's what this > patch series is about. > > You will find two types of chang

Re: [PATCH 01/15] dmr: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

On Thu, Sep 16, 2021 at 11:15:38PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace the boilerplate code > surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() > and DRM_MODESET_LOCK_ALL_END() > Hi Fernando, Thank you for your patch. Could you

Re: [PATCH 03/15] dmr/msm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

On Thu, Sep 16, 2021 at 11:15:40PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace the boilerplate code > surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() > and DRM_MODESET_LOCK_ALL_END() > With the subject fixed (s/dmr/drm/), Reviewed-b

Re: [PATCH 02/15] dmr/i915: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

On Thu, Sep 16, 2021 at 11:15:39PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace the boilerplate code > surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() > and DRM_MODESET_LOCK_ALL_END() > With the subject fixed (s/dmr/drm), Reviewed-by

Re: [PATCH 04/15] drm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

On Thu, Sep 16, 2021 at 11:15:41PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace driver calls to > drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and > DRM_MODESET_LOCK_ALL_END() > > Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul > --- > dr

Re: [PATCH 05/15] drm/vmwgfx: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

On Thu, Sep 16, 2021 at 11:15:42PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace driver calls to > drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and > DRM_MODESET_LOCK_ALL_END() > Reviewed-by: Sean Paul > Signed-off-by: Fernando Ramos > --- > dr

Re: [PATCH 06/15] drm/tegra: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

On Thu, Sep 16, 2021 at 11:15:43PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace driver calls to > drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and > DRM_MODESET_LOCK_ALL_END() > > Signed-off-by: Fernando Ramos > --- > drivers/gpu/drm/tegra/dsi.c

Re: [PATCH 07/15] drm/shmobile: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

On Thu, Sep 16, 2021 at 11:15:44PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace driver calls to > drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and > DRM_MODESET_LOCK_ALL_END() > > Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul > --- > dr

Re: [PATCH 08/15] drm/radeon: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

On Thu, Sep 16, 2021 at 11:15:45PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace driver calls to > drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and > DRM_MODESET_LOCK_ALL_END() > > Signed-off-by: Fernando Ramos > --- > drivers/gpu/drm/radeon/radeo

Re: [PATCH v6 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver

On Fri, Aug 13, 2021 at 10:53:02PM +0800, Kevin Tang wrote: > Adds dsi host controller support for the Unisoc's display subsystem. > Adds dsi phy support for the Unisoc's display subsystem. > Only MIPI DSI Displays supported, DP/TV/HMDI will be support > in the feature. > > v1: > - Remove dphy a

Re: [PATCH 09/15] drm/omapdrm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

On Thu, Sep 16, 2021 at 11:15:46PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace driver calls to > drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and > DRM_MODESET_LOCK_ALL_END() > > Signed-off-by: Fernando Ramos > --- > drivers/gpu/drm/omapdrm/omap

Re: [PATCH 09/15] drm/omapdrm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

On Thu, Sep 16, 2021 at 11:15:46PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace driver calls to > drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and > DRM_MODESET_LOCK_ALL_END() > > Signed-off-by: Fernando Ramos > --- > drivers/gpu/drm/omapdrm/omap

Re: [PATCH 10/15] drm/nouveau: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

On Thu, Sep 16, 2021 at 11:15:47PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace driver calls to > drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and > DRM_MODESET_LOCK_ALL_END() > > Signed-off-by: Fernando Ramos > --- > drivers/gpu/drm/nouveau/disp

Re: [PATCH 11/15] drm/msm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

On Thu, Sep 16, 2021 at 11:15:48PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace driver calls to > drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and > DRM_MODESET_LOCK_ALL_END() > > Signed-off-by: Fernando Ramos > --- > drivers/gpu/drm/msm/disp/dpu

Re: [PATCH 12/15] drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

On Thu, Sep 16, 2021 at 11:15:49PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace driver calls to > drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and > DRM_MODESET_LOCK_ALL_END() > > Signed-off-by: Fernando Ramos > --- > drivers/gpu/drm/i915/display

Re: [PATCH 13/15] drm/gma500: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

On Thu, Sep 16, 2021 at 11:15:50PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace driver calls to > drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and > DRM_MODESET_LOCK_ALL_END() > > Signed-off-by: Fernando Ramos > --- > drivers/gpu/drm/gma500/psb_d

Re: [PATCH 14/15] drm/amd: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

On Thu, Sep 16, 2021 at 11:15:51PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace driver calls to > drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and > DRM_MODESET_LOCK_ALL_END() > > Signed-off-by: Fernando Ramos > --- > drivers/gpu/drm/amd/amdgpu/a

  1   2   >