Re: [BISECTED] 5.14.0-rc4 broke drm/ttm when !CONFIG_DEBUG_FS

2021-08-03 Thread Mikael Pettersson
On Mon, Aug 2, 2021 at 8:29 PM Duncan wrote: > > [Not subscribed so please CC me. Manual quoting after using lore's > in-reply-to functionality. First time doing that so hope I got it > right.] > > Mikael Pettersson wrote... > > Booting 5.14.0-rc4 on my box with Radeon graphics breaks with > >

Re: [RFC v1 0/4] drm: Add support for DRM_CAP_DEFERRED_OUT_FENCE capability

2021-08-03 Thread Michel Dänzer
On 2021-08-03 8:11 a.m., Kasireddy, Vivek wrote: > >>> The goal: >>> - Maintain full framerate even when the Guest scanout FB is flipped onto a >>> hardware >> plane >>> on the Host -- regardless of either compositor's scheduling policy -- >>> without making any >>> copies and ensuring that both

Re: [RFC v1 0/4] drm: Add support for DRM_CAP_DEFERRED_OUT_FENCE capability

2021-08-03 Thread Gerd Hoffmann
Hi, > > virtio_gpu_primary_plane_update() will send RESOURCE_FLUSH only for > > DIRTYFB and both SET_SCANOUT + RESOURCE_FLUSH for page-flip, and I > > think for the page-flip case the host (aka qemu) doesn't get the > > "wait until old framebuffer is not in use any more" right yet. > [Kasireddy,

Re: [PATCH 3/4] drm/tiny: add simple-dbi driver

2021-08-03 Thread Thomas Zimmermann
Hi Am 03.08.21 um 03:25 schrieb Icenowy Zheng: 在 2021-08-02星期一的 17:08 +0200,Thomas Zimmermann写道: Hi Am 02.08.21 um 08:35 schrieb Icenowy Zheng: Add a driver for generic MIPI DBI panels initialized with MIPI DCS commands. Currently a ST7789V-based panel is added to it. This panel has its conf

Re: [PATCH] drm/vbox: Convert to Linux IRQ interfaces

2021-08-03 Thread Thomas Zimmermann
Hi Am 02.08.21 um 13:52 schrieb Hans de Goede: Hi, On 7/6/21 9:50 AM, Thomas Zimmermann wrote: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. Signed-off-by: Thomas Zimmermann T

Re: [PATCH] drm/radeon: Update pitch for page flip

2021-08-03 Thread Michel Dänzer
On 2021-08-02 4:51 p.m., Alex Deucher wrote: > On Mon, Aug 2, 2021 at 4:31 AM Daniel Vetter wrote: >> >> On Mon, Aug 02, 2021 at 10:12:47AM +0200, Christian König wrote: >>> Am 02.08.21 um 09:43 schrieb Zhenneng Li: When primary bo is updated, crtc's pitch may have not been updated, this

Re: [PATCH v2] drm/msm/dp: update is_connected status base on sink count at dp_pm_resume()

2021-08-03 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-08-02 13:20:55) > Currently at dp_pm_resume() is_connected state is decided base on hpd > connection > status only. This will put is_connected in wrongly "true" state at the > scenario > that dongle attached to DUT but without hmdi cable connecting to it. Fix this > pro

Re: [PATCH v5] drm/ast: Fixed CVE for DP501

2021-08-03 Thread Thomas Zimmermann
Hi Am 29.04.21 um 11:21 schrieb Kuo-Hsiang Chou: More generally speaking, the DP501 code needs a major refactoring. It's currently bolted onto the regular VGA connector code. It should rather be a separate connector or a DRM bridge. I always wanted to work on this, but don't have a device for

[PATCH v2 01/14] drm/amdgpu: Convert to Linux IRQ interfaces

2021-08-03 Thread Thomas Zimmermann
Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. The interrupt number returned by pci_msi_vector() is now stored in struct am

[PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy

2021-08-03 Thread Thomas Zimmermann
DRM's IRQ helpers are only helpful for old, non-KMS drivers. Move the code behind CONFIG_DRM_LEGACY. Convert KMS drivers to Linux IRQ interfaces. DRM provides IRQ helpers for setting up, receiving and removing IRQ handlers. It's an abstraction over plain Linux functions. The code is mid-layerish w

[PATCH v2 02/14] drm/arm/hdlcd: Convert to Linux IRQ interfaces

2021-08-03 Thread Thomas Zimmermann
Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Calls to platform_get_irq() can fail with a negative errno code. Abort initi

[PATCH v2 04/14] drm/fsl-dcu: Convert to Linux IRQ interfaces

2021-08-03 Thread Thomas Zimmermann
Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_dr

[PATCH v2 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-08-03 Thread Thomas Zimmermann
Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. v2: * use managed release via devm_request_irq() (Sam) * drop

[PATCH v2 06/14] drm/kmb: Convert to Linux IRQ interfaces

2021-08-03 Thread Thomas Zimmermann
Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/kmb/kmb_drv.c | 26 ++

[PATCH v2 07/14] drm/msm: Convert to Linux IRQ interfaces

2021-08-03 Thread Thomas Zimmermann
Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_drv.c | 113 +

[PATCH v2 08/14] drm/mxsfb: Convert to Linux IRQ interfaces

2021-08-03 Thread Thomas Zimmermann
Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Calls to platform_get_irq() can fail with a negative errno code. Abort initi

[PATCH v2 05/14] drm/gma500: Convert to Linux IRQ interfaces

2021-08-03 Thread Thomas Zimmermann
Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/power.c | 1

[PATCH v2 09/14] drm/radeon: Convert to Linux IRQ interfaces

2021-08-03 Thread Thomas Zimmermann
Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher --- drivers/gp

[PATCH v2 11/14] drm/tilcdc: Convert to Linux IRQ interfaces

2021-08-03 Thread Thomas Zimmermann
Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Calls to platform_get_irq() can fail with a negative errno code. Abort initi

[PATCH v2 13/14] drm: Remove unused devm_drm_irq_install()

2021-08-03 Thread Thomas Zimmermann
DRM IRQ helpers will become legacy. The function devm_drm_irq_install() is unused and won't be required later. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_irq.c | 32 include/drm/drm_irq.h | 1 - 2 files changed, 33 deletions(-) diff --git a/dr

[PATCH v2 10/14] drm/tidss: Convert to Linux IRQ interfaces

2021-08-03 Thread Thomas Zimmermann
Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann Reviewed-by: Tomi Valkeinen --- drivers/

[PATCH v2 12/14] drm/vc4: Convert to Linux IRQ interfaces

2021-08-03 Thread Thomas Zimmermann
Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Calls to platform_get_irq() can fail with a negative errno code. Abort initi

[PATCH v2 14/14] drm: IRQ midlayer is now legacy

2021-08-03 Thread Thomas Zimmermann
Hide the DRM midlayer behind CONFIG_DRM_LEGACY, make functions use the prefix drm_legacy_, and move declarations to drm_legacy.h. In struct drm_device, move the fields irq and irq_enabled behind CONFIG_DRM_LEGACY. All callers have been updated. Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravn

Re: [PATCH v2 07/14] drm/msm: Convert to Linux IRQ interfaces

2021-08-03 Thread Dmitry Baryshkov
On 03/08/2021 12:06, Thomas Zimmermann wrote: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmer

New uAPI for color management proposal and feedback request v2

2021-08-03 Thread Werner Sembach
Greetings, Original proposal: https://www.mail-archive.com/amd-gfx@lists.freedesktop.org/msg62387.html Abstract: Add "preferred color format", "active color format", "active bpc", and "active Broadcast RGB" drm properties, to control color information send to the monitor. It seems that the "pr

Re: [PATCH 01/21] drm/i915/gvt: integrate into the main Makefile

2021-08-03 Thread Zhenyu Wang
On 2021.07.21 17:53:35 +0200, Christoph Hellwig wrote: > Remove the separately included Makefile and just use the relative > reference from the main i915 Makefile as for source files in other > subdirectories. > We agreed to make gvt mostly self-contained in its own directory before. Although I do

Re: refactor the i915 GVT support

2021-08-03 Thread Zhenyu Wang
On 2021.07.29 09:20:22 +0200, Christoph Hellwig wrote: > On Wed, Jul 28, 2021 at 02:59:25PM -0300, Jason Gunthorpe wrote: > > On Wed, Jul 28, 2021 at 01:38:58PM +, Wang, Zhi A wrote: > > > > > I guess those APIs you were talking about are KVM-only. For other > > > hypervisors, e.g. Xen, ARCN c

[PATCH v3 0/4] drm/msm/dpu: always use mdp device to scale bandwidth

2021-08-03 Thread Dmitry Baryshkov
In 5.13 the DPU driver was changed to vote on the bus bandwidth for all the soc families, however suggested [1] dts changes were for some reason not merged at that time. Let's merge them now. If the bootloader does not setup the bus vote, clock might not be enabled before the driver votes on the M

[PATCH v3 2/2] arm64: dts: sm8250: remove bus clock from the mdss node for sm8250 target

2021-08-03 Thread Dmitry Baryshkov
Remove the bus clock from the mdss device node, in order to facilitate bus band width scaling on sm8250 target. The parent device MDSS will not vote for bus bw, instead the vote will be triggered by mdp device node. Since a minimum vote is required to turn on bus clock, and since mdp device node a

[PATCH v3 1/2] arm64: dts: sdm845: move bus clock to mdp node for sdm845 target

2021-08-03 Thread Dmitry Baryshkov
Move the bus clock to mdp device node,in order to facilitate bus band width scaling on sdm845 target. The parent device MDSS will not vote for bus bw, instead the vote will be triggered by mdp device node. Since a minimum vote is required to turn on bus clock, move the clock node to mdp device fro

[v2] drm/msm/disp/dpu1: add safe lut config in dpu driver

2021-08-03 Thread Kalyan Thota
Add safe lut configuration for all the targets in dpu driver as per QOS recommendation. Issue reported on SC7280: With wait-for-safe feature in smmu enabled, RT client buffer levels are checked to be safe before smmu invalidation. Since display was always set to unsafe it was delaying the invalid

[PATCH AUTOSEL 5.13 09/11] drm/amdgpu/display: only enable aux backlight control for OLED panels

2021-08-03 Thread Sasha Levin
From: Alex Deucher [ Upstream commit f2ad3accefc63e72e9932e141c21875cc04beec8 ] We've gotten a number of reports about backlight control not working on panels which indicate that they use aux backlight control. A recent patch: commit 2d73eabe2984a435737498ab39bb1500a9ffe9a9 Author: Camille Cho

[PATCH AUTOSEL 5.10 9/9] drm/amdgpu/display: only enable aux backlight control for OLED panels

2021-08-03 Thread Sasha Levin
From: Alex Deucher [ Upstream commit f2ad3accefc63e72e9932e141c21875cc04beec8 ] We've gotten a number of reports about backlight control not working on panels which indicate that they use aux backlight control. A recent patch: commit 2d73eabe2984a435737498ab39bb1500a9ffe9a9 Author: Camille Cho

Re: [PATCH 0/4] Enable GuC submission by default on DG1

2021-08-03 Thread Daniel Vetter
On Tue, Aug 3, 2021 at 6:53 AM Matthew Brost wrote: > > Minimum set of patches to enable GuC submission on DG1 and enable it by > default. > > A little difficult to test as IGTs do not work with DG1 due to a bunch > of uAPI features being disabled (e.g. relocations, caching memory > options, etc..

[PATCH 1/2] drm/i915: Disable gpu relocations

2021-08-03 Thread Daniel Vetter
Media userspace was the last userspace to still use them, and they converted now too: https://github.com/intel/media-driver/commit/144020c37770083974bedf59902b70b8f444c799 This means no reason anymore to make relocations faster than they've been for the first 9 years of gem. This code was added i

[PATCH 2/2] drm/i915: delete gpu reloc code

2021-08-03 Thread Daniel Vetter
It's already removed, this just garbage collects it all. v2: Rebase over s/GEN/GRAPHICS_VER/ v3: Also ditch eb.reloc_pool and eb.reloc_context (Maarten) Signed-off-by: Daniel Vetter Cc: Jon Bloomfield Cc: Chris Wilson Cc: Maarten Lankhorst Cc: Daniel Vetter Cc: Joonas Lahtinen Cc: "Thomas

[PATCH 01/11] drm/gem: Provide offset-adjusted framebuffer BO mappings

2021-08-03 Thread Thomas Zimmermann
Add an additional argument to drm_gem_fb_vmap() to return each BO's mapping adjusted by the rsp offset. Update all callers. The newly returned values point to the first by of the data stored in the framebuffer BOs. Drivers that access the BO data should use it. Signed-off-by: Thomas Zimmermann -

[PATCH 03/11] drm/gud: Get offset-adjusted mapping from drm_gem_fb_vmap()

2021-08-03 Thread Thomas Zimmermann
Pass the data parameter to drm_gem_fb_vmap() to retrieve pointers to the data. This address is different from the mapping addresses for framebuffers with non-zero offsets. Replaces gud's internal computation. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gud/gud_pipe.c | 5 +++-- 1 file c

[PATCH 00/11] Provide offset-adjusted framebuffer mappings

2021-08-03 Thread Thomas Zimmermann
A framebuffer's offsets field might be non-zero to make the BO data start at the specified offset within the BO's memory. Handle this case in drm_gem_fb_vmap() and update all callers. So far, many drivers ignore the offsets, which can lead to visual artifacts. Patch 1 adds an optional argument to

[PATCH 02/11] drm/ast: Use offset-adjusted shadow-plane mappings

2021-08-03 Thread Thomas Zimmermann
For framebuffers with non-zero offset fields, shadow-plane helpers provide a pointer to the first byte of the contained data. Use it in ast. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ast

[PATCH 06/11] drm/cirrus: Use offset-adjusted shadow-plane mappings

2021-08-03 Thread Thomas Zimmermann
For framebuffers with non-zero offset fields, shadow-plane helpers provide a pointer to the first byte of the contained data. Use it in cirrus. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/cirrus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/d

[PATCH 07/11] drm/gm12u320: Use offset-adjusted shadow-plane mappings

2021-08-03 Thread Thomas Zimmermann
For framebuffers with non-zero offset fields, shadow-plane helpers provide a pointer to the first byte of the contained data. Use it in gm12u320. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/gm12u320.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/g

[PATCH 04/11] drm/hyperv: Use offset-adjusted shadow-plane mappings

2021-08-03 Thread Thomas Zimmermann
For framebuffers with non-zero offset fields, shadow-plane helpers provide a pointer to the first byte of the contained data. Use it in hyperv. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 11/11] drm/vkms: Use offset-adjusted shadow-plane mappings and output

2021-08-03 Thread Thomas Zimmermann
For framebuffers with non-zero offset fields, shadow-plane helpers provide a pointer to the first byte of the contained data. Use it in vkms. Also provide use the offset-adjusted data address for the writeback job's output buffers. Output framebuffers with non-zero offsets now have their content w

[PATCH 05/11] drm/mgag200: Use offset-adjusted shadow-plane mappings

2021-08-03 Thread Thomas Zimmermann
For framebuffers with non-zero offset fields, shadow-plane helpers provide a pointer to the first byte of the contained data. Use it in mgag200. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH 10/11] drm/vbox: Use offset-adjusted shadow-plane mappings

2021-08-03 Thread Thomas Zimmermann
For framebuffers with non-zero offset fields, shadow-plane helpers provide a pointer to the first byte of the contained data. Use it in vbox. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vboxvideo/vbox_mode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu

[PATCH 08/11] drm/simpledrm: Use offset-adjusted shadow-plane mapping

2021-08-03 Thread Thomas Zimmermann
For framebuffers with non-zero offset fields, shadow-plane helpers provide a pointer to the first byte of the contained data. Use it in simpledrm. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/simpledrm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 09/11] drm/udl: Use offset-adjusted shadow-plane mapping

2021-08-03 Thread Thomas Zimmermann
For framebuffers with non-zero offset fields, shadow-plane helpers provide a pointer to the first byte of the contained data. Use it in udl. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/udl_modeset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/

Re: [v2] drm/msm/disp/dpu1: add safe lut config in dpu driver

2021-08-03 Thread Dmitry Baryshkov
On Tue, 3 Aug 2021 at 13:42, Kalyan Thota wrote: > > Add safe lut configuration for all the targets in dpu > driver as per QOS recommendation. > > Issue reported on SC7280: > > With wait-for-safe feature in smmu enabled, RT client > buffer levels are checked to be safe before smmu invalidation. >

Re: [PATCH v8, 2/2] soc: mediatek: mmsys: Add mt8192 mmsys routing table

2021-08-03 Thread Enric Balletbo Serra
Hi Yongqiang, Thank you for your patch Missatge de Yongqiang Niu del dia dl., 2 d’ag. 2021 a les 11:00: > > mt8192 has different routing registers than mt8183 > ... than mt8183 and other Mediatek SoC's I guess ;-) > Signed-off-by: Yongqiang Niu Reviewed-by: Enric Balletbo i Serra Thanks,

Re: refactor the i915 GVT support

2021-08-03 Thread Jason Gunthorpe
On Tue, Aug 03, 2021 at 05:43:15PM +0800, Zhenyu Wang wrote: > Acked-by: Zhenyu Wang > > Thanks a lot for this effort! Great, do we have a submission plan for this? how much does it clash with my open_device/etc patch? ie does the whole thing have to go through the vfio tree? Thanks, Jason

Re: [PATCH] drm/panel: s6d27a1: Add driver for Samsung S6D27A1 display panel

2021-08-03 Thread Sam Ravnborg
Hi Markuss, just a random collection of minor things to fix. Overall the driver looks good. Sam On Tue, Aug 03, 2021 at 04:54:18PM +0300, Markuss Broks wrote: > This adds a driver for Samsung S6D27A1 display controller and panel. > This panel is found in the Samsung GT-I8160 mobile phone,

Re: [PATCH] drm/radeon: Update pitch for page flip

2021-08-03 Thread Alex Deucher
On Tue, Aug 3, 2021 at 4:34 AM Michel Dänzer wrote: > > On 2021-08-02 4:51 p.m., Alex Deucher wrote: > > On Mon, Aug 2, 2021 at 4:31 AM Daniel Vetter wrote: > >> > >> On Mon, Aug 02, 2021 at 10:12:47AM +0200, Christian König wrote: > >>> Am 02.08.21 um 09:43 schrieb Zhenneng Li: > When prima

Re: [PATCH v2 07/14] drm/msm: Convert to Linux IRQ interfaces

2021-08-03 Thread Rob Clark
On Tue, Aug 3, 2021 at 2:37 AM Dmitry Baryshkov wrote: > > On 03/08/2021 12:06, Thomas Zimmermann wrote: > > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > > don't benefit from using it. > > > > DRM IRQ call

Re: [PATCH v2 11/14] drm/tilcdc: Convert to Linux IRQ interfaces

2021-08-03 Thread Sam Ravnborg
Hi Thomas, On Tue, Aug 03, 2021 at 11:07:01AM +0200, Thomas Zimmermann wrote: > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > don't benefit from using it. > > DRM IRQ callbacks are now being called directly

[Bug 205169] AMDGPU driver with Navi card hangs Xorg in fullscreen only.

2021-08-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205169 --- Comment #27 from aladjev.and...@gmail.com (aladjev.and...@gmail.com) --- Kernel driver hangs in production using regular usage. Such issues should be escalated as much as possible: DCN authors and developers meetings, core developers replaceme

Re: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy

2021-08-03 Thread Sam Ravnborg
Hi Thomas, On Tue, Aug 03, 2021 at 11:06:50AM +0200, Thomas Zimmermann wrote: > DRM's IRQ helpers are only helpful for old, non-KMS drivers. Move > the code behind CONFIG_DRM_LEGACY. Convert KMS drivers to Linux > IRQ interfaces. > > DRM provides IRQ helpers for setting up, receiving and removing

Re: [Intel-gfx] [PATCH] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-08-03 Thread Daniel Vetter
On Wed, Jul 28, 2021 at 4:22 PM Matthew Auld wrote: > > On Mon, 26 Jul 2021 at 17:10, Tvrtko Ursulin > wrote: > > > > > > On 26/07/2021 16:14, Jason Ekstrand wrote: > > > On Mon, Jul 26, 2021 at 3:31 AM Maarten Lankhorst > > > wrote: > > >> > > >> Op 23-07-2021 om 13:34 schreef Matthew Auld: > >

Re: [PATCH v2 0/9] drm: Add privacy-screen class and connector properties

2021-08-03 Thread Marco Trevisan
Hi Rajat, The merge proposals are now in place after discussing a bit more with upstream: - https://gitlab.gnome.org/GNOME/gsettings-desktop-schemas/-/merge_requests/49 - https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1952 - https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_r

Re: [Intel-gfx] [PATCH] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-08-03 Thread Jason Ekstrand
On Tue, Aug 3, 2021 at 10:09 AM Daniel Vetter wrote: > On Wed, Jul 28, 2021 at 4:22 PM Matthew Auld > wrote: > > > > On Mon, 26 Jul 2021 at 17:10, Tvrtko Ursulin > > wrote: > > > > > > > > > On 26/07/2021 16:14, Jason Ekstrand wrote: > > > > On Mon, Jul 26, 2021 at 3:31 AM Maarten Lankhorst > >

Re: [PATCH 2/2] drm/i915: delete gpu reloc code

2021-08-03 Thread Jason Ekstrand
Both are Reviewed-by: Jason Ekstrand On Tue, Aug 3, 2021 at 7:49 AM Daniel Vetter wrote: > > It's already removed, this just garbage collects it all. > > v2: Rebase over s/GEN/GRAPHICS_VER/ > > v3: Also ditch eb.reloc_pool and eb.reloc_context (Maarten) > > Signed-off-by: Daniel Vetter > Cc: J

Re: [Intel-gfx] [PATCH] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-08-03 Thread Maarten Lankhorst
Op 2021-08-03 om 17:45 schreef Jason Ekstrand: > On Tue, Aug 3, 2021 at 10:09 AM Daniel Vetter wrote: >> On Wed, Jul 28, 2021 at 4:22 PM Matthew Auld >> wrote: >>> On Mon, 26 Jul 2021 at 17:10, Tvrtko Ursulin >>> wrote: On 26/07/2021 16:14, Jason Ekstrand wrote: > On Mon, Jul 26, 2

Re: [PATCH v5 1/6] arm64: dts: mt8195: add display node for vdosys0

2021-08-03 Thread Jason-JH Lin
Hi CK, On Sun, 2021-08-01 at 08:36 +0800, Chun-Kuang Hu wrote: > Hi, Jason: > > jason-jh.lin 於 2021年7月30日 週五 上午1:07寫道: > > > > Add display node for vdosys0. > > > > Signed-off-by: jason-jh.lin > > --- > > This patch is based on [1][2][3][4] > > > > [1]arm64: dts: Add Mediatek SoC MT8195 and

Re: [PATCH 01/11] drm/gem: Provide offset-adjusted framebuffer BO mappings

2021-08-03 Thread Sam Ravnborg
Hi Thomas, On Tue, Aug 03, 2021 at 02:59:18PM +0200, Thomas Zimmermann wrote: > Add an additional argument to drm_gem_fb_vmap() to return each BO's > mapping adjusted by the rsp offset. Update all callers. rsp? respective? > > The newly returned values point to the first by of the data stored b

Re: [PATCH 00/11] Provide offset-adjusted framebuffer mappings

2021-08-03 Thread Sam Ravnborg
Hi Thomas, On Tue, Aug 03, 2021 at 02:59:17PM +0200, Thomas Zimmermann wrote: > A framebuffer's offsets field might be non-zero to make the BO data > start at the specified offset within the BO's memory. Handle this > case in drm_gem_fb_vmap() and update all callers. So far, many drivers > ignore

[PATCH v3] drm/msm/dp: update is_connected status base on sink count at dp_pm_resume()

2021-08-03 Thread Kuogee Hsieh
Currently at dp_pm_resume() is_connected state is decided base on hpd connection status only. This will put is_connected in wrongly "true" state at the scenario that dongle attached to DUT but without hmdi cable connecting to it. Fix this problem by adding read sink count from dongle and decided is

Re: [PATCH v3 09/14] vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set

2021-08-03 Thread Alex Williamson
On Wed, 28 Jul 2021 21:49:18 -0300 Jason Gunthorpe wrote: > Keep track of all the vfio_devices that have been added to the device set > and use this list in vfio_pci_try_bus_reset() instead of trying to work > backwards from the pci_device. > > The dev_set->lock directly prevents devices from jo

[PATCH] drm/panel: s6d27a1: Add driver for Samsung S6D27A1 display panel

2021-08-03 Thread Markuss Broks
This adds a driver for Samsung S6D27A1 display controller and panel. This panel is found in the Samsung GT-I8160 mobile phone, and possibly some other mobile phones. This display needs manufactrer commands to configure it to a working state; the commands used in this driver were taken from downstr

Re: [PATCH v3 09/14] vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set

2021-08-03 Thread Jason Gunthorpe
On Tue, Aug 03, 2021 at 10:34:06AM -0600, Alex Williamson wrote: > On Wed, 28 Jul 2021 21:49:18 -0300 > Jason Gunthorpe wrote: > > > Keep track of all the vfio_devices that have been added to the device set > > and use this list in vfio_pci_try_bus_reset() instead of trying to work > > backwards

Re: [PATCH v3 09/14] vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set

2021-08-03 Thread Alex Williamson
On Tue, 3 Aug 2021 13:41:52 -0300 Jason Gunthorpe wrote: > On Tue, Aug 03, 2021 at 10:34:06AM -0600, Alex Williamson wrote: > > I think the vfio_pci_find_reset_target() function needs to be re-worked > > to just tell us true/false that it's ok to reset the provided device, > > not to anoint an arb

Re: [PATCH v2 0/9] PCI/VGA: Rework default VGA device selection

2021-08-03 Thread Bjorn Helgaas
On Sat, Jul 24, 2021 at 05:30:02PM +0800, Huacai Chen wrote: > Hi, Bjorn, > > On Sat, Jul 24, 2021 at 8:10 AM Bjorn Helgaas wrote: > > > > On Fri, Jul 23, 2021 at 05:53:36PM +0800, Huacai Chen wrote: > > > Hi, Bjorn, > > > > > > On Fri, Jul 23, 2021 at 5:29 AM Bjorn Helgaas wrote: > > > > > > >

Re: [Freedreno] [PATCH v2 07/14] drm/msm: Convert to Linux IRQ interfaces

2021-08-03 Thread abhinavk
On 2021-08-03 02:06, Thomas Zimmermann wrote: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmer

[PATCH v2] drm/panel: s6d27a1: Add driver for Samsung S6D27A1 display panel

2021-08-03 Thread Markuss Broks
This adds a driver for Samsung S6D27A1 display controller and panel. This panel is found in the Samsung GT-I8160 mobile phone, and possibly some other mobile phones. This display needs manufacturer commands to configure it to a working state; the commands used in this driver were taken from downst

Re: [PATCH 0/4] Enable GuC submission by default on DG1

2021-08-03 Thread Matthew Brost
On Tue, Aug 03, 2021 at 02:15:13PM +0200, Daniel Vetter wrote: > On Tue, Aug 3, 2021 at 6:53 AM Matthew Brost wrote: > > > > Minimum set of patches to enable GuC submission on DG1 and enable it by > > default. > > > > A little difficult to test as IGTs do not work with DG1 due to a bunch > > of uA

Re: [PATCH v2] drm/panel: s6d27a1: Add driver for Samsung S6D27A1 display panel

2021-08-03 Thread Sam Ravnborg
Hi Markuss, On Tue, Aug 03, 2021 at 08:24:50PM +0300, Markuss Broks wrote: > This adds a driver for Samsung S6D27A1 display controller and panel. > This panel is found in the Samsung GT-I8160 mobile phone, > and possibly some other mobile phones. > > This display needs manufacturer commands to con

RE: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy

2021-08-03 Thread Chrisanthus, Anitha
Hi Thomas, Can you please hold off on applying the kmb patch, I am seeing some issues while testing. Modetest works, but video playback only plays once, and it fails the second time with this patch. Thanks, Anitha > -Original Message- > From: Sam Ravnborg > Sent: Tuesday, August 3, 20

Re: [PATCH v3] drm/msm/dp: update is_connected status base on sink count at dp_pm_resume()

2021-08-03 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-08-03 09:25:13) > Currently at dp_pm_resume() is_connected state is decided base on hpd > connection > status only. This will put is_connected in wrongly "true" state at the > scenario > that dongle attached to DUT but without hmdi cable connecting to it. Fix this > pro

Re: [PATCH V5 2/2] drm/vkms: Add support for virtual hardware mode

2021-08-03 Thread Melissa Wen
On 08/01, Sumera Priyadarsini wrote: > Add a virtual hardware or vblank-less mode as a module > to enable VKMS to emulate virtual hardware drivers. This means > no vertical blanking events occur and pageflips are completed > arbitrarily and when required for updating the frame. > > Add a new drm_c

Re: [v2] drm/msm/disp/dpu1: add safe lut config in dpu driver

2021-08-03 Thread Stephen Boyd
Quoting Kalyan Thota (2021-08-03 03:41:47) > Add safe lut configuration for all the targets in dpu > driver as per QOS recommendation. > > Issue reported on SC7280: > > With wait-for-safe feature in smmu enabled, RT client > buffer levels are checked to be safe before smmu invalidation. > Since dis

[PATCH 6/8] drm/i915/perf: Whitelist OA report trigger registers

2021-08-03 Thread Umesh Nerlige Ramappa
OA reports can be triggered into the OA buffer by writing into the OAREPORTTRIG registers. Whitelist the registers to allow non-privileged user to trigger reports. Whitelist registers only if perf_stream_paranoid is set to 0. In i915_perf_open_ioctl, this setting is checked and the whitelist is en

[PATCH 0/8] Enable triggered perf query for Xe_HP

2021-08-03 Thread Umesh Nerlige Ramappa
This is a revival of the patch series to support triggered perf query reports from here - https://patchwork.freedesktop.org/series/83831/ The patches were not pushed earlier because corresponding UMD changes were missing. This revival addresses UMD changes in GPUvis for this series. GPUvis uses th

[PATCH 3/8] drm/i915/gt: Check for conflicting RING_NONPRIV

2021-08-03 Thread Umesh Nerlige Ramappa
From: Chris Wilson Strip the encoded bits from the register offset so that we only use the address for looking up the RING_NONPRIV entry. Signed-off-by: Chris Wilson Reviewed-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 66 + 1 file changed,

[PATCH 7/8] drm/i915/perf: Whitelist OA counter and buffer registers

2021-08-03 Thread Umesh Nerlige Ramappa
It is useful to have markers in the OA reports to identify triggered reports. Whitelist some OA counters that can be used as markers. A triggered report can be found faster if we can sample the HW tail and head registers when the report was triggered. Whitelist OA buffer specific registers. v2: -

[PATCH 2/8] drm/i915/gt: Refactor _wa_add to reuse wa_index and wa_list_grow

2021-08-03 Thread Umesh Nerlige Ramappa
From: Chris Wilson Switch the search and grow code of the _wa_add to use _wa_index and _wa_list_grow. Signed-off-by: Chris Wilson Reviewed-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 124 +++- 1 file changed, 71 insertions(+), 53 deletions(-) d

[PATCH 1/8] drm/i915/gt: Lock intel_engine_apply_whitelist with uncore->lock

2021-08-03 Thread Umesh Nerlige Ramappa
Refactor intel_engine_apply_whitelist into locked and unlocked versions so that a caller who already has the lock can apply whitelist. v2: Fix sparse warning v3: (Chris) - Drop prefix and suffix for static function - Use longest to shortest line ordering for variable declaration Signed-off-by: Um

[PATCH 8/8] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2021-08-03 Thread Umesh Nerlige Ramappa
i915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single draw call or dispatch. Gen9-Gen11 are using current i915 perf implementation for query, but Gen12+ requires a new approach for query based on triggere

[PATCH 4/8] drm/i915/gt: Enable dynamic adjustment of RING_NONPRIV

2021-08-03 Thread Umesh Nerlige Ramappa
From: Chris Wilson The OA subsystem would like to enable its privileged clients access to the OA registers from execbuf. This requires temporarily removing the HW validation from those registers for the duration of the OA client, for which we need to allow OA to dynamically adjust the set of RING

[PATCH 5/8] drm/i915/perf: Ensure observation logic is not clock gated

2021-08-03 Thread Umesh Nerlige Ramappa
From: Piotr Maciejewski A clock gating switch can control if the performance monitoring and observation logic is enaled or not. Ensure that we enable the clocks. v2: Separate code from other patches (Lionel) v3: Reset PMON enable when disabling perf to save power (Lionel) v4: Use intel_uncore_rm

Re: [PATCH 0/8] Enable triggered perf query for Xe_HP

2021-08-03 Thread Umesh Nerlige Ramappa
+ Joonas On Tue, Aug 03, 2021 at 01:13:41PM -0700, Umesh Nerlige Ramappa wrote: This is a revival of the patch series to support triggered perf query reports from here - https://patchwork.freedesktop.org/series/83831/ The patches were not pushed earlier because corresponding UMD changes were mi

Re: [PATCH 0/8] Enable triggered perf query for Xe_HP

2021-08-03 Thread Umesh Nerlige Ramappa
On Tue, Aug 03, 2021 at 01:18:38PM -0700, Umesh Nerlige Ramappa wrote: + Joonas On Tue, Aug 03, 2021 at 01:13:41PM -0700, Umesh Nerlige Ramappa wrote: This is a revival of the patch series to support triggered perf query reports from here - https://patchwork.freedesktop.org/series/83831/ The p

Re: [PATCH v2 0/6] eDP: Support probing eDP panels dynamically instead of hardcoding

2021-08-03 Thread Sam Ravnborg
Hi Douglas, On Fri, Jul 30, 2021 at 02:26:19PM -0700, Douglas Anderson wrote: > The goal of this patch series is to move away from hardcoding exact > eDP panels in device tree files. As discussed in the various patches > in this series (I'm not repeating everything here), most eDP panels > are 99%

Re: [PATCH v2 0/9] drm: Add privacy-screen class and connector properties

2021-08-03 Thread Rajat Jain
Hello DRM / GPU maintainers, On Tue, Aug 3, 2021 at 8:20 AM Marco Trevisan wrote: > > Hi Rajat, > > The merge proposals are now in place after discussing a bit more with > upstream: > > - > https://gitlab.gnome.org/GNOME/gsettings-desktop-schemas/-/merge_requests/49 > - https://gitlab.gnome.o

Re: [PATCH] dma-buf: heaps: Set allocation limit for system heap

2021-08-03 Thread Hridya Valsaraju
On Mon, Aug 2, 2021 at 7:18 PM John Stultz wrote: > > On Thu, Jul 22, 2021 at 12:07 PM Hridya Valsaraju wrote: > > This patch limits the size of total memory that can be requested in a > > single allocation from the system heap. This would prevent a > > buggy/malicious client from depleting syste

[PATCH v2 1/8] drm/kmb: Work around for higher system clock

2021-08-03 Thread Anitha Chrisanthus
Use a different value for system clock offset in the ppl/llp ratio calculations for clocks higher than 500 Mhz. Fixes: 98521f4d4b4c ("drm/kmb: Mipi DSI part of the display driver") Signed-off-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_dsi.c | 11 ++- 1 file changed, 10 insertions

[PATCH v2 2/8] drm/kmb : W/A for 256B cache alignment for video

2021-08-03 Thread Anitha Chrisanthus
For B0 silicon, the media driver pads the decoded video dmabufs for 256B alignment. This is the backing buffer of the framebuffer and info in the drm frame buffer is not correct for these buffers as this is done internally in the media driver. This change extracts the meta data info from dmabuf pri

[PATCH v2 4/8] drm/kmb: Remove clearing DPHY regs

2021-08-03 Thread Anitha Chrisanthus
From: Edmund Dea Don't clear the shared DPHY registers common to MIPI Rx and MIPI Tx during DSI initialization since this was causing MIPI Rx reset. Rest of the writes are bitwise, so do not affect Mipi Rx side. Fixes: 98521f4d4b4c ("drm/kmb: Mipi DSI part of the display driver") Signed-off-by:

[PATCH v2 3/8] drm/kmb: Limit supported mode to 1080p

2021-08-03 Thread Anitha Chrisanthus
KMB only supports single resolution(1080p), this commit checks for 1920x1080x60 or 1920x1080x59 in crtc_mode_valid. Also, modes with vfp < 4 are not supported in KMB display. This change prunes display modes with vfp < 4. v2: added vfp check Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay

[PATCH v2 5/8] drm/kmb: Disable change of plane parameters

2021-08-03 Thread Anitha Chrisanthus
From: Edmund Dea Due to HW limitations, KMB cannot change height, width, or pixel format after initial plane configuration. Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display") Signed-off-by: Edmund Dea Signed-off-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_crtc.c | 2 ++

[PATCH v2 6/8] drm/kmb: Corrected typo in handle_lcd_irq

2021-08-03 Thread Anitha Chrisanthus
Check for Overflow bits for layer3 in the irq handler. Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display") Signed-off-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/

[PATCH v2 7/8] drm/kmb: Enable ADV bridge after modeset

2021-08-03 Thread Anitha Chrisanthus
On KMB, ADV bridge must be programmed and powered on prior to MIPI DSI HW initialization. Fixes: 98521f4d4b4c ("drm/kmb: Mipi DSI part of the display driver") Signed-off-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_dsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/k

  1   2   >