[Bug 211425] [drm:atom_op_jump] *ERROR* atombios stuck in loop for more than 20secs aborting

2021-07-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211425 Andreas (icedragon...@web.de) changed: What|Removed |Added Kernel Version|5.12.14 |5.12.11 - 5.13.3 -- You

Re: [PATCH 05/13] vfio/fsl: Move to the device set infrastructure

2021-07-21 Thread Diana Craciun OSS
On 7/15/2021 3:20 AM, Jason Gunthorpe wrote: FSL uses the internal reflck to implement the open_device() functionality, conversion to the core code is straightforward. The decision on which set to be part of is trivially based on the is_fsl_mc_bus_dprc() and we use a 'struct device *' pointer as

Re: [PATCH 05/13] vfio/fsl: Move to the device set infrastructure

2021-07-21 Thread Diana Craciun OSS
On 7/20/2021 7:17 PM, Jason Gunthorpe wrote: On Tue, Jul 20, 2021 at 07:12:26PM +0300, Diana Craciun OSS wrote: On 7/15/2021 3:20 AM, Jason Gunthorpe wrote: FSL uses the internal reflck to implement the open_device() functionality, conversion to the core code is straightforward. The decision o

Re: [PATCH] dt-bindings: Remove "status" from schema examples

2021-07-21 Thread Rui Miguel Silva
On Tue Jul 20, 2021 at 6:20 PM WEST, Rob Herring wrote: > There's no reason to have "status" properties in examples. "okay" is the > default, and "disabled" turns off some schema checks ('required' > specifically). > > Enabling qca,ar71xx causes a warning, so let's fix the node names: > > Document

Re: [RFC PATCH 1/4] Add a RPMSG driver for the APU in the mt8183

2021-07-21 Thread Alexandre Bailon
Hi Mathieu, On Wed, Oct 14, 2020 at 04:55:34PM -0600, Mathieu Poirier wrote: Hi Alexandre, On Wed, Sep 30, 2020 at 01:53:47PM +0200, Alexandre Bailon wrote: This adds a driver to communicate with the APU available in the mt8183. The driver is generic and could be used for other APU. It mostly

[PATCH] drm/bridge/analogix/dp_core: Use devm_platform_ioremap_resource() to simplify code

2021-07-21 Thread Tang Bin
Use devm_platform_ioremap_resource() instead of platform_get_resource() & devm_ioremap_resource(). Signed-off-by: Tang Bin --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_co

Re: [PATCH 2/2] drm/panel: Add ilitek ili9341 panel driver

2021-07-21 Thread Dillon Min
Hi Linus, Thanks for your detailed review. On Sun, 18 Jul 2021 at 08:31, Linus Walleij wrote: > Hi Dillon, > > thanks for your patch! > > On Fri, Jul 16, 2021 at 12:20 PM wrote: > > > From: Dillon Min > > > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > > with mipi_dpi_inter

Re: [PATCH 1/2] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2021-07-21 Thread Dillon Min
Hi Linus, Thanks for your detailed reply. On Sun, 18 Jul 2021 at 08:17, Linus Walleij wrote: > Hi Dillon, > > thanks for your patch! > > On Fri, Jul 16, 2021 at 12:20 PM wrote: > > > From: Dillon Min > > > > Add documentation for "ilitek,ili9341" panel. > > > > Signed-off-by: Dillon Min > >

Re: [PATCH 1/2] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2021-07-21 Thread Dillon Min
Hi Kernel test robot, Thanks for your time to test my patch. I did the dtbs_check on my side, and got the same warnings. But I guess these warnings do not come from this submission, So, I will not be going to fix it at this time, but will at other submissions to fix these, add arm,armv7m-nvic.ya

[PATCH v2 0/3] Add ilitek ili9341 panel driver

2021-07-21 Thread dillon . minfei
From: Dillon Min Since the st,sf-tc240t-9370-t dts binding already exist in stm32f429-disco.dts but, the panel driver didn't get accepted from mainline. it's time to submit patch fot it. This driver can support two different interface by different dts bindings: - spi+dpi, use spi to configure re

[PATCH v2 1/3] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2021-07-21 Thread dillon . minfei
From: Dillon Min Add documentation for "ilitek,ili9341" panel. Cc: Linus Walleij Signed-off-by: Dillon Min Reviewed-by: Rob Herring --- changes in v2: - add {vci, vddi, vddi-led}-supply bulk regulator according to linus suggestion, thanks. - add DBI panel in D/CX description. .../bindings

[PATCH v2 2/3] ARM: dts: stm32: fix dtbs_check warning on ili9341 dts binding

2021-07-21 Thread dillon . minfei
From: Dillon Min Since the compatible string defined from ilitek,ili9341.yaml is "st,sf-tc240t-9370-t", "ilitek,ili9341" so, append "ilitek,ili9341" to avoid below dtbs_check warning. arch/arm/boot/dts/stm32f429-disco.dt.yaml: display@1: compatible: ['st,sf-tc240t-9370-t'] is too short Signed-

[PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-21 Thread dillon . minfei
From: Dillon Min This driver combine tiny/ili9341.c mipi_dbi_interface driver with mipi_dpi_interface driver, can support ili9341 with serial mode or parallel rgb interface mode by register configuration. Cc: Linus Walleij Signed-off-by: Dillon Min --- changes in v2: - replace vcc regulator to

Re: [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 12:32 AM Rob Clark wrote: > > On Tue, Jul 20, 2021 at 1:55 PM Daniel Vetter wrote: > > > > On Tue, Jul 20, 2021 at 8:26 PM Rob Clark wrote: > > > > > > On Tue, Jul 20, 2021 at 11:03 AM Christian König > > > wrote: > > > > > > > > Hi Rob, > > > > > > > > Am 20.07.21 um 17

Re: [PATCH 3/7] drm/i915/gem: Unify user object creation

2021-07-21 Thread Matthew Auld
On Tue, 20 Jul 2021 at 23:04, Jason Ekstrand wrote: > > On Tue, Jul 20, 2021 at 4:35 AM Matthew Auld > wrote: > > > > On Thu, 15 Jul 2021 at 23:39, Jason Ekstrand wrote: > > > > > > Instead of hand-rolling the same three calls in each function, pull them > > > into an i915_gem_object_create_user

Re: [PATCH 1/7] vgaarb: remove VGA_DEFAULT_DEVICE

2021-07-21 Thread Christian König
Am 20.07.21 um 15:50 schrieb Daniel Vetter: On Fri, Jul 16, 2021 at 09:14:02AM +0200, Christian König wrote: Am 16.07.21 um 08:16 schrieb Christoph Hellwig: The define is entirely unused. Signed-off-by: Christoph Hellwig I'm not an expert for this particular code, but at least of hand eve

Re: [PATCH 2/7] drm/i915/gem: Refactor placement setup for i915_gem_object_create* (v2)

2021-07-21 Thread Matthew Auld
On Tue, 20 Jul 2021 at 23:07, Jason Ekstrand wrote: > > On Mon, Jul 19, 2021 at 3:18 AM Matthew Auld > wrote: > > > > On Fri, 16 Jul 2021 at 15:14, Jason Ekstrand wrote: > > > > > > Since we don't allow changing the set of regions after creation, we can > > > make ext_set_placements() build up t

Re: [PATCH] dt-bindings: Remove "status" from schema examples

2021-07-21 Thread Philipp Zabel
Hi Rob, On Tue, 2021-07-20 at 11:20 -0600, Rob Herring wrote: > There's no reason to have "status" properties in examples. "okay" is the > default, and "disabled" turns off some schema checks ('required' > specifically). Is this documented somewhere? If not, should it be? (Maybe in writing- schem

Re: [PULL] drm-misc-next

2021-07-21 Thread Thomas Zimmermann
Hi Am 21.07.21 um 06:03 schrieb Dave Airlie: On Fri, 16 Jul 2021 at 21:07, Maarten Lankhorst wrote: Hi Dave & Daniel, Lots of stuff this time around. Enjoy! I've pulled this but there is an outstanding warning /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_d

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Use a table for i915_init/exit

2021-07-21 Thread Tvrtko Ursulin
On 20/07/2021 19:13, Jason Ekstrand wrote: If the driver was not fully loaded, we may still have globals lying around. If we don't tear those down in i915_exit(), we'll leak a bunch of memory slabs. This can happen two ways: use_kms = false and if we've run mock selftests. In either case, we

Re: [Intel-gfx] [PATCH 4/6] drm/ttm: Force re-init if ttm_global_init() fails

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 8:36 AM Christian König wrote: > Am 20.07.21 um 20:13 schrieb Jason Ekstrand: > > If we have a failure, decrement the reference count so that the next > > call to ttm_global_init() will actually do something instead of assume > > everything is all set up. > > > > Signed-off

Re: [Intel-gfx] [PATCH 4/6] drm/ttm: Force re-init if ttm_global_init() fails

2021-07-21 Thread Christian König
Am 21.07.21 um 11:06 schrieb Daniel Vetter: On Wed, Jul 21, 2021 at 8:36 AM Christian König wrote: Am 20.07.21 um 20:13 schrieb Jason Ekstrand: If we have a failure, decrement the reference count so that the next call to ttm_global_init() will actually do something instead of assume everything

Re: [Intel-gfx] [PATCH 1/4] drm/i915/gt: fix platform prefix

2021-07-21 Thread Tvrtko Ursulin
On 21/07/2021 00:20, Lucas De Marchi wrote: gen8_clear_engine_error_register() is actually not used by GRAPHICS_VER >= 8, since for those we are using another register that is not engine-dependent. Fix the platform prefix, to make clear we are not using any GEN6_RING_FAULT_REG_* one GRAPHICS_VE

Re: [Intel-gfx] [PATCH 4/6] drm/ttm: Force re-init if ttm_global_init() fails

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 11:08 AM Christian König wrote: > Am 21.07.21 um 11:06 schrieb Daniel Vetter: > > On Wed, Jul 21, 2021 at 8:36 AM Christian König > > wrote: > >> Am 20.07.21 um 20:13 schrieb Jason Ekstrand: > >>> If we have a failure, decrement the reference count so that the next > >>> c

Re: [PATCH v2 02/14] vfio/mbochs: Fix missing error unwind in mbochs_probe()

2021-07-21 Thread Cornelia Huck
On Tue, Jul 20 2021, Jason Gunthorpe wrote: > Compared to mbochs_remove() two cases are missing from the > vfio_register_group_dev() unwind. Add them in. > > Fixes: 681c1615f891 ("vfio/mbochs: Convert to use vfio_register_group_dev()") > Reported-by: Cornelia Huck > Signed-off-by: Jason Gunthorp

Re: [Intel-gfx] [PATCH 2/4] drm/i915/gt: nuke unused legacy engine hw_id

2021-07-21 Thread Tvrtko Ursulin
On 21/07/2021 00:20, Lucas De Marchi wrote: The engine hw_id is only used by RING_FAULT_REG(), which is not used since GRAPHICS_VER == 8. We tend to keep adding new defines just to be consistent, but let's try to remove them and let them defined to 0 when not used. Signed-off-by: Lucas De Marc

Re: [PATCH v2 02/14] vfio/mbochs: Fix missing error unwind in mbochs_probe()

2021-07-21 Thread Cornelia Huck
On Tue, Jul 20 2021, Jason Gunthorpe wrote: > On Tue, Jul 20, 2021 at 04:01:27PM -0600, Alex Williamson wrote: >> Hmm, doesn't this suggest we need another atomic conversion? (untested) > > Sure why not, I can add this as another patch Yes, I think that should be another patch.

Re: [Intel-gfx] [PATCH 3/4] drm/i915/gt: rename legacy engine->hw_id to engine->gen6_hw_id

2021-07-21 Thread Tvrtko Ursulin
On 21/07/2021 00:20, Lucas De Marchi wrote: We kept adding new engines and for that increasing hw_id unnecessarily: it's not used since GRAPHICS_VER == 8. Prepend "gen6" to the field and try to pack it in the structs to give a hint this field is actually not used in recent platforms. Signed-of

[PATCH 1/2] dma-buf: clarify dma_fence_ops->wait documentation

2021-07-21 Thread Christian König
This callback is pretty much deprecated and should not be used by new implementations. Clarify that in the documentation as well. Signed-off-by: Christian König --- include/linux/dma-fence.h | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/include/linux/dma-fence.

[PATCH 2/2] dma-buf: clarify dma_fence_add_callback documentation

2021-07-21 Thread Christian König
That the caller doesn't need to keep a reference is rather risky and not defensive at all. Especially dma_buf_poll got that horrible wrong, so better remove that sentence and also clarify that the callback might be called in atomic or interrupt context. Signed-off-by: Christian König --- driver

Re: [Intel-gfx] [PATCH 4/4] drm/i915/gt: nuke gen6_hw_id

2021-07-21 Thread Tvrtko Ursulin
On 21/07/2021 00:20, Lucas De Marchi wrote: This is only used by GRAPHICS_VER == 6 and GRAPHICS_VER == 7. All other recent platforms do not depend on this field, so it doesn't make much sense to keep it generic like that. Instead, just do a mapping from engine class to HW ID in the single place

Re: [PATCH] drm/i915/gvt: Convert from atomic_t to refcount_t on intel_vgpu_ppgtt_spt->refcount

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 4:21 AM Zhenyu Wang wrote: > On 2021.07.16 18:41:38 +0800, Xiyu Yang wrote: > > refcount_t type and corresponding API can protect refcounters from > > accidental underflow and overflow and further use-after-free situations > > > > Thanks for the patch. Is there any specific

[PATCH] dma-heap: Let dma heap use dma_map_attrs to map & unmap iova

2021-07-21 Thread guangming.cao
From: Guangming Cao On Thu, 2021-07-15 at 14:24 +0800, guangming@mediatek.com wrote: > From: Guangming Cao > > On Thu, 2021-07-08 at 18:14 +0800, guangming@mediatek.com wrote: > > Hi Sumit, Christian, Matthias, > > gentle ping for this patch :) move receviers to '--to' list. gentle p

Re: [PATCH v3 0/2] allow simple{fb, drm} drivers to be used on non-x86 EFI platforms

2021-07-21 Thread Thomas Zimmermann
Hi Am 21.07.21 um 07:09 schrieb Javier Martinez Canillas: ... Can I simply put the patches in to drm-misc-next? There was some talk about a topic branch? ... which AFAIU means that there's no need for a topic branch, since the patches will be present in linux-next. And the EFI folks can use

Re: [PATCH v3 0/2] allow simple{fb, drm} drivers to be used on non-x86 EFI platforms

2021-07-21 Thread Javier Martinez Canillas
On 7/21/21 12:07 PM, Thomas Zimmermann wrote: > Hi > > Am 21.07.21 um 07:09 schrieb Javier Martinez Canillas: > ... >>> >>> Can I simply put the patches in to drm-misc-next? There was some talk >>> about a topic branch? >>> >> >> ... which AFAIU means that there's no need for a topic branch, since

[PATCH] video: fbdev: arcfb: remove redundant initialization of variable err

2021-07-21 Thread Colin King
From: Colin Ian King The variable err is being initialized with a value that is never read, the assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/video/fbdev/arcfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v8 0/5] drm: address potential UAF bugs with drm_master ptrs

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 6:12 AM Desmond Cheong Zhi Xi wrote: > On 21/7/21 2:24 am, Daniel Vetter wrote: > > On Mon, Jul 12, 2021 at 12:35:03PM +0800, Desmond Cheong Zhi Xi wrote: > >> Hi, > >> > >> In the previous thread on this series we decided to remove a patch that > >> was violating a lockde

Re: [PATCH] backlight: pwm_bl: Avoid backlight flicker if backlight control GPIO is input

2021-07-21 Thread Daniel Thompson
On Tue, Jul 20, 2021 at 10:28:32PM +0200, Marek Vasut wrote: > On 7/19/21 1:22 PM, Daniel Thompson wrote: > > On Sun, Jul 18, 2021 at 11:14:15PM +0200, Marek Vasut wrote: > > > If the backlight enable GPIO is configured as input, the driver currently > > > unconditionally forces the GPIO to output-

Re: understanding virtio-gpu

2021-07-21 Thread Gerd Hoffmann
Hi, > 1. virtio_gpu_pci_quirk(): > > * what is the explicit framebuffer removal about ? unregister boot framebuffer (typically efifb or vesafb on x86). > * why is it necessary to rename the device with "pci:" prefix ? > > does it only work w/ pci transport ? > what's the backgrou

Re: [PATCH] dt-bindings: Remove "status" from schema examples

2021-07-21 Thread Oleksij Rempel
On Tue, Jul 20, 2021 at 11:20:25AM -0600, Rob Herring wrote: > There's no reason to have "status" properties in examples. "okay" is the > default, and "disabled" turns off some schema checks ('required' > specifically). > > Enabling qca,ar71xx causes a warning, so let's fix the node names: > > Do

Re: [PATCH] video: fbdev: arcfb: remove redundant initialization of variable err

2021-07-21 Thread Sam Ravnborg
Hi Colin, On Wed, Jul 21, 2021 at 11:26:08AM +0100, Colin King wrote: > From: Colin Ian King > > The variable err is being initialized with a value that is never > read, the assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > -

Re: [PATCH v3 0/2] allow simple{fb, drm} drivers to be used on non-x86 EFI platforms

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 12:15:12PM +0200, Javier Martinez Canillas wrote: > On 7/21/21 12:07 PM, Thomas Zimmermann wrote: > > Hi > > > > Am 21.07.21 um 07:09 schrieb Javier Martinez Canillas: > > ... > >>> > >>> Can I simply put the patches in to drm-misc-next? There was some talk > >>> about a to

Re: [PATCH 3/6] drm/i915: Always call i915_globals_exit() from i915_exit()

2021-07-21 Thread Daniel Vetter
On Tue, Jul 20, 2021 at 09:55:22AM -0500, Jason Ekstrand wrote: > On Tue, Jul 20, 2021 at 9:18 AM Daniel Vetter wrote: > > > > On Mon, Jul 19, 2021 at 01:30:44PM -0500, Jason Ekstrand wrote: > > > If the driver was not fully loaded, we may still have globals lying > > > around. If we don't tear t

Re: [PATCH v2 03/14] vfio: Introduce a vfio_uninit_group_dev() API call

2021-07-21 Thread Cornelia Huck
On Tue, Jul 20 2021, Jason Gunthorpe wrote: > From: Max Gurtovoy > > This pairs with vfio_init_group_dev() and allows undoing any state that is > stored in the vfio_device unrelated to registration. Add appropriately > placed calls to all the drivers. > > The following patch will use this to add

Re: [PATCH] drm: document drm_mode_get_property

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 06:49:32AM +, Simon Ser wrote: > It's not obvious what the fields mean and how they should be used. > The most important detail is the link to drm_property.flags, which > describes how property types work. > > Signed-off-by: Simon Ser > Cc: Pekka Paalanen > Cc: Daniel

Re: [PATCH] drm: document drm_property_enum.value for bitfields

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 06:51:30AM +, Simon Ser wrote: > When a property has the type DRM_MODE_PROP_BITMASK, the value field > stores a bitshift, not a bitmask, which can be surprising. > > Signed-off-by: Simon Ser > Cc: Pekka Paalanen > Cc: Daniel Vetter > Cc: Leandro Ribeiro > --- > inc

[PATCH v2 1/2] drm/i915: document caching related bits

2021-07-21 Thread Matthew Auld
Try to document the object caching related bits, like cache_coherent and cache_dirty. v2(Ville): - As pointed out by Ville, fix the completely incorrect assumptions about the "partial" coherency on shared LLC platforms. Suggested-by: Daniel Vetter Signed-off-by: Matthew Auld Cc: Ville Syrjä

[PATCH v2 2/2] drm/i915/ehl: unconditionally flush the pages on acquire

2021-07-21 Thread Matthew Auld
EHL and JSL add the 'Bypass LLC' MOCS entry, which should make it possible for userspace to bypass the GTT caching bits set by the kernel, as per the given object cache_level. This is troublesome since the heavy flush we apply when first acquiring the pages is skipped if the kernel thinks the objec

Re: [PATCH 1/2] dma-buf: clarify dma_fence_ops->wait documentation

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 11:21:32AM +0200, Christian König wrote: > This callback is pretty much deprecated and should not be used by new > implementations. > > Clarify that in the documentation as well. > > Signed-off-by: Christian König > --- > include/linux/dma-fence.h | 10 +++--- > 1 f

Re: [PATCH 2/2] dma-buf: clarify dma_fence_add_callback documentation

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 11:21:33AM +0200, Christian König wrote: > That the caller doesn't need to keep a reference is rather > risky and not defensive at all. > > Especially dma_buf_poll got that horrible wrong, so better > remove that sentence and also clarify that the callback > might be called

Re: [PATCH v3 2/4] drm/amd/display: Add FPU event trace

2021-07-21 Thread Christian König
Am 21.07.21 um 13:44 schrieb Rodrigo Siqueira: On 07/20, Christian König wrote: Am 20.07.21 um 02:49 schrieb Rodrigo Siqueira: We don't have any mechanism for tracing FPU operations inside the display core, making the debug work a little bit tricky. This commit introduces a trace mechanism ins

Re: [PATCH 04/10] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-07-21 Thread Daniel Vetter
On Tue, Jul 20, 2021 at 03:45:19PM +0200, Maxime Ripard wrote: > Interactions between bridges, panels, MIPI-DSI host and the component > framework are not trivial and can lead to probing issues when > implementing a display driver. Let's document the various cases we need > too consider, and the so

Re: [PATCH 04/10] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 02:05:01PM +0200, Daniel Vetter wrote: > On Tue, Jul 20, 2021 at 03:45:19PM +0200, Maxime Ripard wrote: > > Interactions between bridges, panels, MIPI-DSI host and the component > > framework are not trivial and can lead to probing issues when > > implementing a display driv

Re: [PATCH v2 1/2] drm/i915: document caching related bits

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 1:46 PM Matthew Auld wrote: > > Try to document the object caching related bits, like cache_coherent and > cache_dirty. > > v2(Ville): > - As pointed out by Ville, fix the completely incorrect assumptions >about the "partial" coherency on shared LLC platforms. > > Sugg

Re: [PATCH v8 0/5] drm: address potential UAF bugs with drm_master ptrs

2021-07-21 Thread Desmond Cheong Zhi Xi
On 21/7/21 6:29 pm, Daniel Vetter wrote: On Wed, Jul 21, 2021 at 6:12 AM Desmond Cheong Zhi Xi wrote: On 21/7/21 2:24 am, Daniel Vetter wrote: On Mon, Jul 12, 2021 at 12:35:03PM +0800, Desmond Cheong Zhi Xi wrote: Hi, In the previous thread on this series we decided to remove a patch that wa

Re: [PATCH] drm/ttm: remove special handling for non GEM drivers

2021-07-21 Thread Christian König
This is a known issue and fixed by: commit a3a9ee4b5254f212c2adaa8cd8ca03bfa112f49d Author: Christian König Date:   Wed Jun 9 19:25:56 2021 +0200     drm/nouveau: init the base GEM fields for internal BOs     TTMs buffer objects are based on GEM objects for quite a while     and rely on initia

Re: [PATCH] video: fbdev: neofb: add a check against divide error

2021-07-21 Thread Sam Ravnborg
Hi Zheyu, On Wed, Jul 21, 2021 at 12:43:44PM +, Zheyu Ma wrote: > The userspace program could pass any values to the driver through > ioctl() interface. If the driver doesn't check the value of 'pixclock', > it may cause divide error because of the 'PICOS2KHZ' macro. > > Fix this by checking w

Re: [PATCH v3 1/1] drm/mediatek: Fix cursor plane didn't update

2021-07-21 Thread Sean Paul
On Tue, Jul 20, 2021 at 3:47 AM jason-jh.lin wrote: > > The cursor plane should use the current plane state hook in > atomic_async_update because it would not be the new plane state in > the global atomic state, since drm_atomic_helper_swap_state happened > when those plane state hook are run. > >

[PATCH] drm/hisilicon/hibmc: Remove variable 'priv' from hibmc_unload()

2021-07-21 Thread Thomas Zimmermann
The variable 'priv' got introduced in commit 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces") by accident. It's unused; remove it. Fixes a compiler warning. Signed-off-by: Thomas Zimmermann Fixes: 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces") Reported-

Re: [PATCH 2/2] dma-buf: clarify dma_fence_add_callback documentation

2021-07-21 Thread Christian König
Am 21.07.21 um 13:52 schrieb Daniel Vetter: On Wed, Jul 21, 2021 at 11:21:33AM +0200, Christian König wrote: That the caller doesn't need to keep a reference is rather risky and not defensive at all. Especially dma_buf_poll got that horrible wrong, so better remove that sentence and also cla

Re: [PATCH v8 0/5] drm: address potential UAF bugs with drm_master ptrs

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 2:44 PM Desmond Cheong Zhi Xi wrote: > On 21/7/21 6:29 pm, Daniel Vetter wrote: > > On Wed, Jul 21, 2021 at 6:12 AM Desmond Cheong Zhi Xi > > wrote: > >> On 21/7/21 2:24 am, Daniel Vetter wrote: > >>> On Mon, Jul 12, 2021 at 12:35:03PM +0800, Desmond Cheong Zhi Xi wrote: >

[PATCH 1/3] drm/plane: remove drm_helper_get_plane_damage_clips

2021-07-21 Thread Daniel Vetter
It's not used. Drivers should instead use the helpers anyway. Currently both vbox and i915 hand-roll this and it's not the greatest. vbox looks buggy, and i915 does a bit much that helpers would take care of I think. Also improve the kerneldocs while we're at it. Cc: Ville Syrjälä Cc: Gwan-gyeo

[PATCH 2/3] drm/plane: check that fb_damage is set up when used

2021-07-21 Thread Daniel Vetter
There's two stages of manual upload/invalidate displays: - just handling dirtyfb and uploading the entire fb all the time - looking at damage clips In the latter case we support it through fbdev emulation (with fb_defio), atomic property, and with the dirtfy clip rects. Make sure at least the ato

[PATCH 3/3] drm/plane: Move drm_plane_enable_fb_damage_clips into core

2021-07-21 Thread Daniel Vetter
We're trying to have a fairly strict split between core functionality that defines the uapi, including the docs, and the helper functions to implement it. Move drm_plane_enable_fb_damage_clips and associated kerneldoc into drm_plane from drm_damage_helper.c to fix this. Cc: Ville Syrjälä Cc: Gwa

Re: [PATCH 2/2] dma-buf: clarify dma_fence_add_callback documentation

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 3:18 PM Christian König wrote: > Am 21.07.21 um 13:52 schrieb Daniel Vetter: > > On Wed, Jul 21, 2021 at 11:21:33AM +0200, Christian König wrote: > >> That the caller doesn't need to keep a reference is rather > >> risky and not defensive at all. > >> > >> Especially dma_bu

Re: [PATCH] drm/hisilicon/hibmc: Remove variable 'priv' from hibmc_unload()

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 3:17 PM Thomas Zimmermann wrote: > > The variable 'priv' got introduced in commit 39a364a19e03 > ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces") by accident. > It's unused; remove it. Fixes a compiler warning. > > Signed-off-by: Thomas Zimmermann > Fixes: 39a364a1

Re: [PATCH] dt-bindings: Remove "status" from schema examples

2021-07-21 Thread Rob Herring
On Wed, Jul 21, 2021 at 2:33 AM Philipp Zabel wrote: > > Hi Rob, > > On Tue, 2021-07-20 at 11:20 -0600, Rob Herring wrote: > > There's no reason to have "status" properties in examples. "okay" is the > > default, and "disabled" turns off some schema checks ('required' > > specifically). > > Is thi

Re: [PATCH 2/2] dma-buf: clarify dma_fence_add_callback documentation

2021-07-21 Thread Christian König
Am 21.07.21 um 15:36 schrieb Daniel Vetter: On Wed, Jul 21, 2021 at 3:18 PM Christian König wrote: Am 21.07.21 um 13:52 schrieb Daniel Vetter: On Wed, Jul 21, 2021 at 11:21:33AM +0200, Christian König wrote: That the caller doesn't need to keep a reference is rather risky and not defensive at

Re: [PATCH v2 1/3] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2021-07-21 Thread Linus Walleij
On Wed, Jul 21, 2021 at 9:41 AM wrote: > From: Dillon Min > > Add documentation for "ilitek,ili9341" panel. > > Cc: Linus Walleij > Signed-off-by: Dillon Min > Reviewed-by: Rob Herring Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-21 Thread Linus Walleij
On Wed, Jul 21, 2021 at 9:41 AM wrote: > From: Dillon Min > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > with mipi_dpi_interface driver, can support ili9341 with serial > mode or parallel rgb interface mode by register configuration. > > Cc: Linus Walleij > Signed-off-by: Di

[PATCH 10/54] dt-bindings: display: panel-lvds: Document panel compatibles

2021-07-21 Thread Maxime Ripard
The binding mentions that all the drivers using that driver must use a vendor-specific compatible but never enforces it, nor documents the vendor-specific compatibles. Let's make we document all of them, and that the binding will create an error if we add one that isn't. Cc: dri-devel@lists.freed

[PATCH 11/54] dt-bindings: display: simple-bridge: Add corpro, gm7123 compatible

2021-07-21 Thread Maxime Ripard
The corpro,gm7123 was in use in a DT but was never properly documented, let's add it. Cc: dri-devel@lists.freedesktop.org Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- Changes from v1: - Removed the dumb-vga-dac compatible from the list --- .../devicetree/bindings/display/b

Re: [PATCH 10/54] dt-bindings: display: panel-lvds: Document panel compatibles

2021-07-21 Thread Sam Ravnborg
Hi Maxime, On Wed, Jul 21, 2021 at 04:03:40PM +0200, Maxime Ripard wrote: > The binding mentions that all the drivers using that driver must use a > vendor-specific compatible but never enforces it, nor documents the > vendor-specific compatibles. > > Let's make we document all of them, and that t

Re: [PATCH 11/54] dt-bindings: display: simple-bridge: Add corpro, gm7123 compatible

2021-07-21 Thread Sam Ravnborg
On Wed, Jul 21, 2021 at 04:03:41PM +0200, Maxime Ripard wrote: > The corpro,gm7123 was in use in a DT but was never properly documented, > let's add it. > > Cc: dri-devel@lists.freedesktop.org > Reviewed-by: Laurent Pinchart > Signed-off-by: Maxime Ripard Acked-by: Sam Ravnborg

Re: [PATCH v2 1/3] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2021-07-21 Thread Sam Ravnborg
Hi Linus, On Wed, Jul 21, 2021 at 04:00:35PM +0200, Linus Walleij wrote: > On Wed, Jul 21, 2021 at 9:41 AM wrote: > > > From: Dillon Min > > > > Add documentation for "ilitek,ili9341" panel. > > > > Cc: Linus Walleij > > Signed-off-by: Dillon Min > > Reviewed-by: Rob Herring > > Reviewed-by:

答复: [PATCH] drm/hisilicon/hibmc: Remove variable 'priv' from hibmc_unload()

2021-07-21 Thread tiantao (H)
Reviewed-by: Tian Tao -邮件原件- 发件人: Thomas Zimmermann [mailto:tzimmerm...@suse.de] 发送时间: 2021年7月21日 21:17 收件人: xinliang@linaro.org; tiantao (H) ; john.stu...@linaro.org; kongxinwei (A) ; Chenfeng (puck) ; airl...@linux.ie; dan...@ffwll.ch; max...@cerno.tech; s...@ravnborg.org 抄送: dr

Re: [PATCH v2 1/3] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2021-07-21 Thread Linus Walleij
On Wed, Jul 21, 2021 at 4:18 PM Sam Ravnborg wrote: > Hi Linus, > On Wed, Jul 21, 2021 at 04:00:35PM +0200, Linus Walleij wrote: > > On Wed, Jul 21, 2021 at 9:41 AM wrote: > > > > > From: Dillon Min > > > > > > Add documentation for "ilitek,ili9341" panel. > > > > > > Cc: Linus Walleij > > > Si

Re: [PATCH] dt-bindings: Remove "status" from schema examples

2021-07-21 Thread Linus Walleij
On Tue, Jul 20, 2021 at 7:20 PM Rob Herring wrote: > There's no reason to have "status" properties in examples. "okay" is the > default, and "disabled" turns off some schema checks ('required' > specifically). All of mine are mistakes anyway. Reviewed-by: Linus Walleij Thanks for fixing this u

Re: [PATCH] drm/amdgpu/acp: Make PM domain really work

2021-07-21 Thread Alex Deucher
Applied. Thanks! I've removed the unused variables when I applied. Alex On Tue, Jul 20, 2021 at 1:31 PM Kai-Heng Feng wrote: > > Devices created by mfd_add_hotplug_devices() don't really increase the > index of its name, so get_mfd_cell_dev() cannot find any device, hence a > NULL dev is passe

Re: [PATCH v4] backlight: ktd253: Stabilize backlight

2021-07-21 Thread Lee Jones
On Thu, 15 Jul 2021, Linus Walleij wrote: > Remove interrupt disablement during backlight setting. It is > way to dangerous and makes platforms instable by having it > miss vblank IRQs leading to the graphics derailing. > > The code is using ndelay() which is not available on > platforms such as

Re: [PATCH 2/2] dma-buf: clarify dma_fence_add_callback documentation

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 3:57 PM Christian König wrote: > Am 21.07.21 um 15:36 schrieb Daniel Vetter: > > On Wed, Jul 21, 2021 at 3:18 PM Christian König > > wrote: > >> Am 21.07.21 um 13:52 schrieb Daniel Vetter: > >>> On Wed, Jul 21, 2021 at 11:21:33AM +0200, Christian König wrote: > That t

Re: [PATCH v2 2/3] ARM: dts: stm32: fix dtbs_check warning on ili9341 dts binding

2021-07-21 Thread Dillon Min
Hi Alex, I suppose you will going to review this patch, I forgot to add the Fixes tag in v2, just add it. I will submit v3 to add this tag in case necessary. Thanks, Best Regards. Dillon On Wed, 21 Jul 2021 at 15:41, wrote: > > From: Dillon Min > > Since the compatible string defined from ilit

Re: [PATCH 2/2] dma-buf: clarify dma_fence_add_callback documentation

2021-07-21 Thread Christian König
Am 21.07.21 um 16:37 schrieb Daniel Vetter: On Wed, Jul 21, 2021 at 3:57 PM Christian König wrote: Am 21.07.21 um 15:36 schrieb Daniel Vetter: On Wed, Jul 21, 2021 at 3:18 PM Christian König wrote: Am 21.07.21 um 13:52 schrieb Daniel Vetter: On Wed, Jul 21, 2021 at 11:21:33AM +0200, Christi

Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-21 Thread Dillon Min
On Wed, 21 Jul 2021 at 22:02, Linus Walleij wrote: > > On Wed, Jul 21, 2021 at 9:41 AM wrote: > > > From: Dillon Min > > > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > > with mipi_dpi_interface driver, can support ili9341 with serial > > mode or parallel rgb interface mode by

Re: [PATCH] backlight: pwm_bl: Avoid backlight flicker if backlight control GPIO is input

2021-07-21 Thread Marek Vasut
On 7/21/21 12:49 PM, Daniel Thompson wrote: [...] NOTE: I think this whole auto-detection scheme should just be replaced by a DT prop, because it is very fragile. I have some sympathy for this view... although I think the boat has already set sail. I'm not sure that's correct, we can

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Use a table for i915_init/exit

2021-07-21 Thread Jason Ekstrand
On Wed, Jul 21, 2021 at 4:06 AM Tvrtko Ursulin wrote: > > > On 20/07/2021 19:13, Jason Ekstrand wrote: > > If the driver was not fully loaded, we may still have globals lying > > around. If we don't tear those down in i915_exit(), we'll leak a bunch > > of memory slabs. This can happen two ways:

[PATCH] fbdev: simplefb: fix Kconfig dependencies

2021-07-21 Thread Arnd Bergmann
From: Arnd Bergmann Configurations with both CONFIG_FB_SIMPLE=y and CONFIG_DRM_SIMPLEDRM=m are allowed by Kconfig because the 'depends on !DRM_SIMPLEDRM' dependency does not disallow FB_SIMPLE as long as SIMPLEDRM is not built-in. This can however result in a build failure when cfb_fillrect() etc

Re: [PATCH 3/6] drm/i915: Always call i915_globals_exit() from i915_exit()

2021-07-21 Thread Jason Ekstrand
On Wed, Jul 21, 2021 at 6:26 AM Daniel Vetter wrote: > > On Tue, Jul 20, 2021 at 09:55:22AM -0500, Jason Ekstrand wrote: > > On Tue, Jul 20, 2021 at 9:18 AM Daniel Vetter wrote: > > > > > > On Mon, Jul 19, 2021 at 01:30:44PM -0500, Jason Ekstrand wrote: > > > > If the driver was not fully loaded,

[PATCH] drm: fb_helper: fix CONFIG_FB dependency

2021-07-21 Thread Arnd Bergmann
From: Arnd Bergmann With CONFIG_FB=m and CONFIG_DRM=y, we get a link error in the fb helper: aarch64-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_alloc_fbi': (.text+0x10cc): undefined reference to `framebuffer_alloc' Tighten the dependency so it is only allowed in the

[PATCH 0/6] Fix the debugfs splat from mock selftests (v3)

2021-07-21 Thread Jason Ekstrand
This patch series fixes a miscellaneous collection of bugs that all add up to all our mock selftests throwing dmesg warnings in CI. As can be seen from "drm/i915: Use a table for i915_init/exit", it's especially fun since those warnings don't always show up in the selftests but can show up in othe

[PATCH 2/6] drm/i915: Call i915_globals_exit() if pci_register_device() fails

2021-07-21 Thread Jason Ekstrand
In the unlikely event that pci_register_device() fails, we were tearing down our PMU setup but not globals. This leaves a bunch of memory slabs lying around. Signed-off-by: Jason Ekstrand Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global") Reviewed-by: Daniel Vetter --- dri

[PATCH 1/6] drm/i915: Call i915_globals_exit() after i915_pmu_exit()

2021-07-21 Thread Jason Ekstrand
We should tear down in the opposite order we set up. Signed-off-by: Jason Ekstrand Reviewed-by: Daniel Vetter Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i9

[PATCH 3/6] drm/i915: Use a table for i915_init/exit (v2)

2021-07-21 Thread Jason Ekstrand
If the driver was not fully loaded, we may still have globals lying around. If we don't tear those down in i915_exit(), we'll leak a bunch of memory slabs. This can happen two ways: use_kms = false and if we've run mock selftests. In either case, we have an early exit from i915_init which happen

[PATCH 6/6] drm/i915: Make the kmem slab for i915_buddy_block a global

2021-07-21 Thread Jason Ekstrand
There's no reason that I can tell why this should be per-i915_buddy_mm and doing so causes KMEM_CACHE to throw dmesg warnings because it tries to create a debugfs entry with the name i915_buddy_block multiple times. We could handle this by carefully giving each slab its own name but that brings its

[PATCH 5/6] drm/ttm: Initialize debugfs from ttm_global_init()

2021-07-21 Thread Jason Ekstrand
We create a bunch of debugfs entries as a side-effect of ttm_global_init() and then never clean them up. This isn't usually a problem because we free the whole debugfs directory on module unload. However, if the global reference count ever goes to zero and then ttm_global_init() is called again, w

[PATCH 4/6] drm/ttm: Force re-init if ttm_global_init() fails

2021-07-21 Thread Jason Ekstrand
If we have a failure, decrement the reference count so that the next call to ttm_global_init() will actually do something instead of assume everything is all set up. Signed-off-by: Jason Ekstrand Fixes: 62b53b37e4b1 ("drm/ttm: use a static ttm_bo_global instance") Reviewed-by: Christian König --

Re: [PATCH v4] backlight: ktd253: Stabilize backlight

2021-07-21 Thread Linus Walleij
On Wed, Jul 21, 2021 at 4:37 PM Lee Jones wrote: > How loudly will you shout if I submit this for v5.15-rc1? It's cool, the users (PostmarketOS) have the patch applied externally anyway. Yours, Linus Walleij

Re: [PATCH v3 2/4] drm/amd/display: Add FPU event trace

2021-07-21 Thread Rodrigo Siqueira
On 07/20, Christian König wrote: > > > Am 20.07.21 um 02:49 schrieb Rodrigo Siqueira: > > We don't have any mechanism for tracing FPU operations inside the > > display core, making the debug work a little bit tricky. This commit > > introduces a trace mechanism inside our DC_FP_START/END macros f

Re: [PATCH 3/7] drm/i915/gem: Unify user object creation

2021-07-21 Thread Jason Ekstrand
On Wed, Jul 21, 2021 at 3:25 AM Matthew Auld wrote: > > On Tue, 20 Jul 2021 at 23:04, Jason Ekstrand wrote: > > > > On Tue, Jul 20, 2021 at 4:35 AM Matthew Auld > > wrote: > > > > > > On Thu, 15 Jul 2021 at 23:39, Jason Ekstrand wrote: > > > > > > > > Instead of hand-rolling the same three call

Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-21 Thread Jagan Teki
On Wed, Jul 21, 2021 at 1:11 PM wrote: > > From: Dillon Min > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > with mipi_dpi_interface driver, can support ili9341 with serial > mode or parallel rgb interface mode by register configuration. > > Cc: Linus Walleij > Signed-off-by: D

  1   2   3   >