Re: [Intel-gfx] [PATCH 2/2] drm/doc: Add RFC section

2021-03-24 Thread Dave Airlie
On Tue, 23 Mar 2021 at 18:45, Daniel Vetter wrote: > > Motivated by the pre-review process for i915 gem/gt features, but > probably useful in general for complex stuff. > > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Jason Ekstrand > Cc: Dave Airlie > Signed-off-by: Daniel

Re: [PATCH v4 2/4] drm: sun4i: dsi: Add bridge support

2021-03-24 Thread Samuel Holland
On 3/22/21 9:01 AM, Jagan Teki wrote: > Some display panels would come up with a non-DSI output which > can have an option to connect DSI interface by means of bridge > converter. > > This DSI to non-DSI bridge converter would require a bridge > driver that would communicate the DSI controller for

Re: [PATCH v4 1/4] drm: sun4i: dsi: Use drm_of_find_panel_or_bridge

2021-03-24 Thread Samuel Holland
On 3/23/21 5:53 PM, Laurent Pinchart wrote: > Hi Jagan, > > Thank you for the patch. > > On Mon, Mar 22, 2021 at 07:31:49PM +0530, Jagan Teki wrote: >> Replace of_drm_find_panel with drm_of_find_panel_or_bridge >> for finding panel, this indeed help to find the bridge if >> bridge support added.

Re: [PATCH v6 1/5] dt-bindings:drm/bridge:anx7625:add vendor define flags

2021-03-24 Thread Xin Ji
On Sun, Mar 21, 2021 at 02:00:38PM +0200, Laurent Pinchart wrote: > Hi Xin, > > Thank you for the patch. > > On Fri, Mar 19, 2021 at 02:32:39PM +0800, Xin Ji wrote: > > Add 'bus-type' and 'data-lanes' define for port0. Define DP tx lane0, > > lane1 swing register array define, and audio enable fl

Re: [PATCH] drm/rockchip: Remove unused variable

2021-03-24 Thread Maxime Ripard
On Sat, Mar 20, 2021 at 02:20:56AM +0200, Laurent Pinchart wrote: > Hi Maxime, > > Thank you for the patch. > > On Fri, Mar 19, 2021 at 04:29:20PM +0100, Maxime Ripard wrote: > > Commit 977697e20b3d ("drm/atomic: Pass the full state to planes atomic > > disable and update") added the old_state va

Re: [RFC PATCH 04/11] drm/bridge: ti-sn65dsi86: Use bitmask to store valid rates

2021-03-24 Thread Geert Uytterhoeven
Hi Doug, On Tue, Mar 23, 2021 at 10:10 PM Doug Anderson wrote: > On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart > wrote: > > > > The valid rates are stored in an array of 8 booleans. Replace it with a > > bitmask to save space. > > I'm curious: do you have evidence that this does anything usef

Re: [PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible

2021-03-24 Thread Geert Uytterhoeven
Hi Lee, On Tue, Mar 23, 2021 at 9:40 AM Lee Jones wrote: > On Mon, 22 Mar 2021, Daniel Thompson wrote: > > On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > > > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. > > > > > > Signed-off-by: Konrad Dybcio > > > > Reviewed-

[PATCH] drm/bridge: adv7511: fix support for large EDIDs

2021-03-24 Thread Hans Verkuil
While testing support for large (> 256 bytes) EDIDs on the Renesas Koelsch board I noticed that the adv7511 bridge driver only read the first two blocks. The media V4L2 version for the adv7511 (drivers/media/i2c/adv7511-v4l2.c) handled this correctly. Besides a simple bug when setting the segment

Re: [PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible

2021-03-24 Thread Lee Jones
On Wed, 24 Mar 2021, Geert Uytterhoeven wrote: > Hi Lee, > > On Tue, Mar 23, 2021 at 9:40 AM Lee Jones wrote: > > On Mon, 22 Mar 2021, Daniel Thompson wrote: > > > On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > > > > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP.

Re: [PATCH v4 1/4] drm: sun4i: dsi: Use drm_of_find_panel_or_bridge

2021-03-24 Thread Jagan Teki
On Wed, Mar 24, 2021 at 8:18 AM Samuel Holland wrote: > > On 3/23/21 5:53 PM, Laurent Pinchart wrote: > > Hi Jagan, > > > > Thank you for the patch. > > > > On Mon, Mar 22, 2021 at 07:31:49PM +0530, Jagan Teki wrote: > >> Replace of_drm_find_panel with drm_of_find_panel_or_bridge > >> for finding

[PATCH drm/amdgpu 2/2] drm/amd/pm: Convert sysfs sprintf/snprintf family to sysfs_emit

2021-03-24 Thread Tian Tao
Fix the following coccicheck warning: drivers/gpu/drm/amd/pm/amdgpu_pm.c:1940:8-16: WARNING: use scnprintf or sprintf drivers/gpu/drm/amd/pm/amdgpu_pm.c:1978:8-16: WARNING: use scnprintf or sprintf drivers/gpu/drm/amd/pm/amdgpu_pm.c:2022:8-16: WARNING: use scnprintf or sprintf drivers/gpu/drm/amd/p

[PATCH drm/amdgpu 0/2] Convert sysfs sprintf/snprintf family to sysfs_emit

2021-03-24 Thread Tian Tao
Use the generic sysfs_emit() function to take place of snprintf/scnprintf, to avoid buffer overrun. Tian Tao (2): drm/amdgpu: Convert sysfs sprintf/snprintf family to sysfs_emit drm/amd/pm: Convert sysfs sprintf/snprintf family to sysfs_emit drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 2

[PATCH drm/amdgpu 1/2] drm/amdgpu: Convert sysfs sprintf/snprintf family to sysfs_emit

2021-03-24 Thread Tian Tao
Fix the following coccicheck warning: drivers/gpu//drm/amd/amdgpu/amdgpu_ras.c:434:9-17: WARNING: use scnprintf or sprintf drivers/gpu//drm/amd/amdgpu/amdgpu_xgmi.c:220:8-16: WARNING: use scnprintf or sprintf drivers/gpu//drm/amd/amdgpu/amdgpu_xgmi.c:249:8-16: WARNING: use scnprintf or sprintf driv

RE: [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

2021-03-24 Thread David Laight
From: Martin Sebor > Sent: 22 March 2021 22:08 ... > In GCC 11, all access warnings expect objects to be either declared > or allocated. Pointers with constant values are taken to point to > nothing valid (as Arnd mentioned above, this is to detect invalid > accesses to members of structs at addre

Re: [Intel-gfx] [PATCH] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v2)

2021-03-24 Thread Tvrtko Ursulin
On 23/03/2021 17:51, Jason Ekstrand wrote: This API is entirely unnecessary and I'd love to get rid of it. If userspace wants a single timeline across multiple contexts, they can either use implicit synchronization or a syncobj, both of which existed at the time this feature landed. The justi

Re: [Intel-gfx] [PATCH v9 68/70] drm/i915: Pass ww ctx to pin_map

2021-03-24 Thread Maarten Lankhorst
Op 23-03-2021 om 18:30 schreef Matthew Auld: > On Tue, 23 Mar 2021 at 15:51, Maarten Lankhorst > wrote: >> This will allow us to explicitly pass the ww to pin_pages, >> when it starts taking it. >> >> This allows us to finally kill off the explicit passing of ww >> by retrieving it from the obj. >

Re: [PATCH v4 1/4] drm: sun4i: dsi: Use drm_of_find_panel_or_bridge

2021-03-24 Thread Laurent Pinchart
Hi Jagan, On Wed, Mar 24, 2021 at 02:44:57PM +0530, Jagan Teki wrote: > On Wed, Mar 24, 2021 at 8:18 AM Samuel Holland wrote: > > On 3/23/21 5:53 PM, Laurent Pinchart wrote: > > > On Mon, Mar 22, 2021 at 07:31:49PM +0530, Jagan Teki wrote: > > >> Replace of_drm_find_panel with drm_of_find_panel_or

Re: [PATCH v2 1/3] drm: bridge/panel: Cleanup connector on bridge detach

2021-03-24 Thread Daniel Vetter
On Wed, Mar 24, 2021 at 04:15:37AM +0200, Laurent Pinchart wrote: > On Wed, Jan 20, 2021 at 06:38:03PM +0100, Daniel Vetter wrote: > > On Wed, Jan 20, 2021 at 6:12 PM Paul Cercueil wrote: > > > Le mer. 20 janv. 2021 à 17:03, Daniel Vetter a écrit : > > > > On Wed, Jan 20, 2021 at 1:35 PM Paul Cercu

Re: [Intel-gfx] [PATCH] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v2)

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 12:51:49PM -0500, Jason Ekstrand wrote: > This API is entirely unnecessary and I'd love to get rid of it. If > userspace wants a single timeline across multiple contexts, they can > either use implicit synchronization or a syncobj, both of which existed > at the time this f

Re: [PATCH v2 1/3] drm: bridge/panel: Cleanup connector on bridge detach

2021-03-24 Thread Laurent Pinchart
On Wed, Mar 24, 2021 at 10:39:52AM +0100, Daniel Vetter wrote: > On Wed, Mar 24, 2021 at 04:15:37AM +0200, Laurent Pinchart wrote: > > On Wed, Jan 20, 2021 at 06:38:03PM +0100, Daniel Vetter wrote: > > > On Wed, Jan 20, 2021 at 6:12 PM Paul Cercueil wrote: > > > > Le mer. 20 janv. 2021 à 17:03, Dan

Re: [PATCH v4 1/4] drm: sun4i: dsi: Use drm_of_find_panel_or_bridge

2021-03-24 Thread Jagan Teki
Hi Laurent, On Wed, Mar 24, 2021 at 3:09 PM Laurent Pinchart wrote: > > Hi Jagan, > > On Wed, Mar 24, 2021 at 02:44:57PM +0530, Jagan Teki wrote: > > On Wed, Mar 24, 2021 at 8:18 AM Samuel Holland wrote: > > > On 3/23/21 5:53 PM, Laurent Pinchart wrote: > > > > On Mon, Mar 22, 2021 at 07:31:49PM

Re: [Intel-gfx] [PATCH] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v2)

2021-03-24 Thread Daniel Vetter
On Wed, Mar 24, 2021 at 09:28:58AM +, Tvrtko Ursulin wrote: > > On 23/03/2021 17:51, Jason Ekstrand wrote: > > This API is entirely unnecessary and I'd love to get rid of it. If > > userspace wants a single timeline across multiple contexts, they can > > either use implicit synchronization or

Re: [PATCH v4 1/4] drm: sun4i: dsi: Use drm_of_find_panel_or_bridge

2021-03-24 Thread Laurent Pinchart
Hi Jagan, On Wed, Mar 24, 2021 at 03:19:10PM +0530, Jagan Teki wrote: > On Wed, Mar 24, 2021 at 3:09 PM Laurent Pinchart wrote: > > On Wed, Mar 24, 2021 at 02:44:57PM +0530, Jagan Teki wrote: > > > On Wed, Mar 24, 2021 at 8:18 AM Samuel Holland wrote: > > > > On 3/23/21 5:53 PM, Laurent Pinchart w

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 06:06:53PM +0100, Thomas Hellström (Intel) wrote: > > On 3/23/21 5:37 PM, Jason Gunthorpe wrote: > > On Tue, Mar 23, 2021 at 05:34:51PM +0100, Thomas Hellström (Intel) wrote: > > > > > > > @@ -210,6 +211,20 @@ static vm_fault_t ttm_bo_vm_insert_huge(struct > > > > > vm_fa

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 09:42:18PM +0100, Thomas Hellström (Intel) wrote: > > On 3/23/21 8:52 PM, Williams, Dan J wrote: > > On Sun, 2021-03-21 at 19:45 +0100, Thomas Hellström (Intel) wrote: > > > TTM sets up huge page-table-entries both to system- and device > > > memory, > > > and we don't want

Re: [PATCH] i915_vma: Rename vma_lookup to i915_vma_lookup

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 01:42:21PM +, Liam Howlett wrote: > Use i915 prefix to avoid name collision with future vma_lookup() in mm. > > Signed-off-by: Liam R. Howlett > Reviewed-by: Matthew Wilcox (Oracle) Applied to i915-gem-next branch for 5.13. We have a bit a branch shuffling going on r

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-24 Thread Intel
On 3/24/21 10:58 AM, Daniel Vetter wrote: On Tue, Mar 23, 2021 at 09:42:18PM +0100, Thomas Hellström (Intel) wrote: On 3/23/21 8:52 PM, Williams, Dan J wrote: On Sun, 2021-03-21 at 19:45 +0100, Thomas Hellström (Intel) wrote: TTM sets up huge page-table-entries both to system- and device memo

Re: [PATCH v4 1/4] drm: sun4i: dsi: Use drm_of_find_panel_or_bridge

2021-03-24 Thread Maxime Ripard
On Wed, Mar 24, 2021 at 11:55:35AM +0200, Laurent Pinchart wrote: > Hi Jagan, > > On Wed, Mar 24, 2021 at 03:19:10PM +0530, Jagan Teki wrote: > > On Wed, Mar 24, 2021 at 3:09 PM Laurent Pinchart wrote: > > > On Wed, Mar 24, 2021 at 02:44:57PM +0530, Jagan Teki wrote: > > > > On Wed, Mar 24, 2021 a

Re: [Intel-gfx] [PATCH v9 68/70] drm/i915: Pass ww ctx to pin_map

2021-03-24 Thread Daniel Vetter
On Wed, Mar 24, 2021 at 10:31:26AM +0100, Maarten Lankhorst wrote: > Op 23-03-2021 om 18:30 schreef Matthew Auld: > > On Tue, 23 Mar 2021 at 15:51, Maarten Lankhorst > > wrote: > >> This will allow us to explicitly pass the ww to pin_pages, > >> when it starts taking it. > >> > >> This allows us t

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-24 Thread Michel Dänzer
On 2021-03-23 4:32 p.m., Mark Yacoub wrote: > On Tue, Mar 23, 2021 at 11:02 AM Alex Deucher wrote: >> >> On Wed, Mar 10, 2021 at 11:15 AM Mark Yacoub wrote: >>> >>> From: Mark Yacoub >>> >>> On initializing the framebuffer, call drm_any_plane_has_format to do a >>> check if the modifier is suppo

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-24 Thread Intel
On 3/23/21 4:45 PM, Christian König wrote: Am 23.03.21 um 16:13 schrieb Michal Hocko: On Tue 23-03-21 14:56:54, Christian König wrote: Am 23.03.21 um 14:41 schrieb Michal Hocko: [...] Anyway, I am wondering whether the overall approach is sound. Why don't you simply use shmem as your backing

Re: [PATCH v1] MAINTAINERS: Update Maintainers of DRM Bridge Drivers

2021-03-24 Thread Neil Armstrong
Hi ! On 24/03/2021 11:20, Robert Foss wrote: > Add myself as co-maintainer of DRM Bridge Drivers. Repository > commit access has already been granted. > > https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/338 > > Cc: Neil Armstrong > Cc: Laurent Pinchart > Cc: Jonas Karlman > Cc

Re: [PATCH v1] MAINTAINERS: Update Maintainers of DRM Bridge Drivers

2021-03-24 Thread Laurent Pinchart
Hi Rob, On Wed, Mar 24, 2021 at 11:20:19AM +0100, Robert Foss wrote: > Add myself as co-maintainer of DRM Bridge Drivers. Repository > commit access has already been granted. > > https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/338 > > Cc: Neil Armstrong > Cc: Laurent Pinchart >

Re: [RESEND 00/19] Rid GPU from W=1 warnings

2021-03-24 Thread Lee Jones
Daniel, > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > This is a resend of the remaining patches. > > All of these patches have been sent before. Are you still keen to 'hoover these up'? Just leave the one that requires work and take the res

RE: [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

2021-03-24 Thread David Laight
From: David Laight > Sent: 24 March 2021 09:12 > > From: Martin Sebor > > Sent: 22 March 2021 22:08 > ... > > In GCC 11, all access warnings expect objects to be either declared > > or allocated. Pointers with constant values are taken to point to > > nothing valid (as Arnd mentioned above, this

Re: [PATCH v4 2/6] drm/sprd: add Unisoc's drm kms master

2021-03-24 Thread Maxime Ripard
Hi On Mon, Feb 22, 2021 at 09:28:18PM +0800, Kevin Tang wrote: > Adds drm support for the Unisoc's display subsystem. > > This is drm kms driver, this driver provides support for the > application framework in Android, Yocto and more. > > Application framework can access Unisoc's display interne

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-24 Thread Bas Nieuwenhuizen
On Wed, Mar 24, 2021 at 11:13 AM Michel Dänzer wrote: > On 2021-03-23 4:32 p.m., Mark Yacoub wrote: > > On Tue, Mar 23, 2021 at 11:02 AM Alex Deucher > wrote: > >> > >> On Wed, Mar 10, 2021 at 11:15 AM Mark Yacoub > wrote: > >>> > >>> From: Mark Yacoub > >>> > >>> On initializing the framebuff

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-03-24 Thread Maxime Ripard
Hi, On Mon, Feb 22, 2021 at 09:28:20PM +0800, Kevin Tang wrote: > Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. > > Cc: Orson Zhai > Cc: Chunyan Zhang > Signed-off-by: Kevin Tang > > v2

Re: [PATCH v4 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings

2021-03-24 Thread Maxime Ripard
On Mon, Feb 22, 2021 at 09:28:21PM +0800, Kevin Tang wrote: > From: Kevin Tang > > Adds MIPI DSI Controller > support for Unisoc's display subsystem. > > Cc: Orson Zhai > Cc: Chunyan Zhang > Signed-off-by: Kevin Tang > Reviewed-by: Rob Herring > --- > .../display/sprd/sprd,sharkl3-dsi-host.

Re: [Intel-gfx] [PATCH v9 17/70] drm/i915: Flatten obj->mm.lock

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 04:50:06PM +0100, Maarten Lankhorst wrote: > With userptr fixed, there is no need for all separate lockdep classes > now, and we can remove all lockdep tricks used. A trylock in the > shrinker is all we need now to flatten the locking hierarchy. > > Signed-off-by: Maarten L

Re: [PATCH v4 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver

2021-03-24 Thread Maxime Ripard
On Mon, Feb 22, 2021 at 09:28:22PM +0800, Kevin Tang wrote: > Adds dsi host controller support for the Unisoc's display subsystem. > Adds dsi phy support for the Unisoc's display subsystem. > Only MIPI DSI Displays supported, DP/TV/HMDI will be support > in the feature. > > v1: > - Remove dphy a

Re: [Intel-gfx] [PATCH v9 16/70] drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v7.

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 04:50:05PM +0100, Maarten Lankhorst wrote: > Instead of doing what we do currently, which will never work with > PROVE_LOCKING, do the same as AMD does, and something similar to > relocation slowpath. When all locks are dropped, we acquire the > pages for pinning. When the l

Re: [Intel-gfx] [PATCH v9 16/70] drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v7.

2021-03-24 Thread Intel
On 3/24/21 12:28 PM, Daniel Vetter wrote: On Tue, Mar 23, 2021 at 04:50:05PM +0100, Maarten Lankhorst wrote: Instead of doing what we do currently, which will never work with PROVE_LOCKING, do the same as AMD does, and something similar to relocation slowpath. When all locks are dropped, we acq

Re: [Intel-gfx] [PATCH] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v2)

2021-03-24 Thread Tvrtko Ursulin
On 24/03/2021 09:52, Daniel Vetter wrote: On Wed, Mar 24, 2021 at 09:28:58AM +, Tvrtko Ursulin wrote: On 23/03/2021 17:51, Jason Ekstrand wrote: This API is entirely unnecessary and I'd love to get rid of it. If userspace wants a single timeline across multiple contexts, they can either

[PATCH v2 0/2] HDCP 2.2 DP errata

2021-03-24 Thread Anshuman Gupta
HDCP DP 2.2 errata is part of HDCP DP 2.3 specs as well. Anshuman Gupta (2): drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16 drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 45 ++-- include/drm/drm_hdcp.h

[PATCH v2 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg

2021-03-24 Thread Anshuman Gupta
As documented in HDCP 2.2 DP Errata spec transmitter should abort the authentication protocol in case transmitter has not received the entire {AKE_Send_Cert, AKE_Send_H_prime, AKE_Send_Paring_Info} msg within {110,7,5} miliseconds. Adding above msg timeout values and aborting the HDCP authenticati

[PATCH v2 2/2] drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16

2021-03-24 Thread Anshuman Gupta
Fix LC_Send_L_Prime message timeout to 16 as documented in DP HDCP 2.2 errata page 3. https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf Cc: Ramalingam C Reviewed-by: Ankit Nautiyal Signed-off-by: Anshuman Gupta --- include/drm/drm_hdcp.h | 2 +- 1 file chan

[PATCH] drm/i915: Pass ww ctx to pin_map, v2.

2021-03-24 Thread Maarten Lankhorst
This will allow us to explicitly pass the ww to pin_pages, when it starts taking it. This allows us to finally kill off the explicit passing of ww by retrieving it from the obj. Changes since v1: - Rename 'ret' to ptr, fix error handling of return ptr. Signed-off-by: Maarten Lankhorst --- .../

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-24 Thread Daniel Vetter
On Wed, Mar 24, 2021 at 11:19:13AM +0100, Thomas Hellström (Intel) wrote: > > On 3/23/21 4:45 PM, Christian König wrote: > > Am 23.03.21 um 16:13 schrieb Michal Hocko: > > > On Tue 23-03-21 14:56:54, Christian König wrote: > > > > Am 23.03.21 um 14:41 schrieb Michal Hocko: > > > [...] > > > > > An

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-24 Thread Christian König
Am 24.03.21 um 12:55 schrieb Daniel Vetter: On Wed, Mar 24, 2021 at 11:19:13AM +0100, Thomas Hellström (Intel) wrote: On 3/23/21 4:45 PM, Christian König wrote: Am 23.03.21 um 16:13 schrieb Michal Hocko: On Tue 23-03-21 14:56:54, Christian König wrote: Am 23.03.21 um 14:41 schrieb Michal Hock

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-24 Thread Daniel Vetter
On Wed, Mar 24, 2021 at 01:00:28PM +0100, Christian König wrote: > Am 24.03.21 um 12:55 schrieb Daniel Vetter: > > On Wed, Mar 24, 2021 at 11:19:13AM +0100, Thomas Hellström (Intel) wrote: > > > On 3/23/21 4:45 PM, Christian König wrote: > > > > Am 23.03.21 um 16:13 schrieb Michal Hocko: > > > > >

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-24 Thread Christian König
Am 24.03.21 um 13:01 schrieb Daniel Vetter: On Wed, Mar 24, 2021 at 01:00:28PM +0100, Christian König wrote: Am 24.03.21 um 12:55 schrieb Daniel Vetter: On Wed, Mar 24, 2021 at 11:19:13AM +0100, Thomas Hellström (Intel) wrote: On 3/23/21 4:45 PM, Christian König wrote: Am 23.03.21 um 16:13

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-24 Thread Daniel Stone
On Wed, 24 Mar 2021 at 10:53, Bas Nieuwenhuizen wrote: > On Wed, Mar 24, 2021 at 11:13 AM Michel Dänzer wrote: > >> No modifier support does not imply linear. It's generally signalled via >> DRM_FORMAT_MOD_INVALID, which roughly means "tiling is determined by driver >> specific mechanisms". >> >

[PATCH v4 0/7] Default request/fence expiry + watchdog

2021-03-24 Thread Tvrtko Ursulin
From: Tvrtko Ursulin "Watchdog" aka "restoring hangcheck" aka default request/fence expiry - second post of a somewhat controversial feature, now upgraded to patch status. I quote the "watchdog" becuase in classical sense watchdog would allow userspace to ping it and so remain alive. I quote "r

[PATCH 1/7] drm/i915: Extract active lookup engine to a helper

2021-03-24 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Move active engine lookup to exported i915_request_active_engine. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 34 +--- drivers/gpu/drm/i915/i915_request.c | 44 + drivers/gpu/drm/i915/i915_request.

[PATCH 2/7] drm/i915: Individual request cancellation

2021-03-24 Thread Tvrtko Ursulin
From: Chris Wilson Currently, we cancel outstanding requests within a context when the context is closed. We may also want to cancel individual requests using the same graceful preemption mechanism. v2 (Tvrtko): * Cancel waiters carefully considering no timeline lock and RCU. * Fixed selftests

[PATCH 3/7] drm/i915: Restrict sentinel requests further

2021-03-24 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Disallow sentinel requests follow previous sentinels to make request cancellation work better when faced with a chain of requests which have all been marked as in error. Because in cases where we end up with a stream of cancelled requests we want to turn of request coalescin

[PATCH 4/7] drm/i915: Handle async cancellation in sentinel assert

2021-03-24 Thread Tvrtko Ursulin
From: Tvrtko Ursulin With the watchdog cancelling requests asynchronously to preempt-to-busy we need to relax one assert making it apply only to requests not in error. v2: * Check against the correct request! v3: * Simplify the check to avoid the question of when to sample the fence error

[PATCH 7/7] drm/i915: Allow configuring default request expiry via modparam

2021-03-24 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Module parameter is added (request_timeout_ms) to allow configuring the default request/fence expiry. Default value is inherited from CONFIG_DRM_I915_REQUEST_TIMEOUT. Signed-off-by: Tvrtko Ursulin Cc: Daniel Vetter Acked-by: Daniel Vetter --- drivers/gpu/drm/i915/gem/i9

[PATCH 5/7] drm/i915: Request watchdog infrastructure

2021-03-24 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Prepares the plumbing for setting request/fence expiration time. All code is put in place but is never activated due yet missing ability to actually configure the timer. Outline of the basic operation: A timer is started when request is ready for execution. If the request c

[PATCH 6/7] drm/i915: Fail too long user submissions by default

2021-03-24 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A new Kconfig option CONFIG_DRM_I915_REQUEST_TIMEOUT is added, defaulting to 20s, and this timeout is applied to all users contexts using the previously added watchdog facility. Result of this is that any user submission will simply fail after this timeout, either causing a

[PATCH] [v2] drm/imx: imx-ldb: fix out of bounds array access warning

2021-03-24 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_OF is disabled, building with 'make W=1' produces warnings about out of bounds array access: drivers/gpu/drm/imx/imx-ldb.c: In function 'imx_ldb_set_clock.constprop': drivers/gpu/drm/imx/imx-ldb.c:186:8: error: array subscript -22 is below array bounds of 'struct

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Extract active lookup engine to a helper

2021-03-24 Thread Matthew Auld
On Wed, 24 Mar 2021 at 12:13, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Move active engine lookup to exported i915_request_active_engine. > > Signed-off-by: Tvrtko Ursulin Reviewed-by: Matthew Auld ___ dri-devel mailing list dri-devel@lists.f

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-24 Thread Jason Gunthorpe
On Wed, Mar 24, 2021 at 10:56:43AM +0100, Daniel Vetter wrote: > On Tue, Mar 23, 2021 at 06:06:53PM +0100, Thomas Hellström (Intel) wrote: > > > > On 3/23/21 5:37 PM, Jason Gunthorpe wrote: > > > On Tue, Mar 23, 2021 at 05:34:51PM +0100, Thomas Hellström (Intel) wrote: > > > > > > > > > @@ -210,6

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-24 Thread Intel
On 3/24/21 1:24 PM, Jason Gunthorpe wrote: On Wed, Mar 24, 2021 at 10:56:43AM +0100, Daniel Vetter wrote: On Tue, Mar 23, 2021 at 06:06:53PM +0100, Thomas Hellström (Intel) wrote: On 3/23/21 5:37 PM, Jason Gunthorpe wrote: On Tue, Mar 23, 2021 at 05:34:51PM +0100, Thomas Hellström (Intel) wro

Re: [Intel-gfx] [PATCH v9 25/70] drm/i915: Take reservation lock around i915_vma_pin.

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 04:50:14PM +0100, Maarten Lankhorst wrote: > We previously complained when ww == NULL. > > This function is now only used in selftests to pin an object, > and ww locking is now fixed. > > Signed-off-by: Maarten Lankhorst > Reviewed-by: Thomas Hellström > --- > .../i915/

Re: [Intel-gfx] [PATCH v9 27/70] drm/i915: Make __engine_unpark() compatible with ww locking.

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 04:50:16PM +0100, Maarten Lankhorst wrote: > Take the ww lock around engine_unpark. Because of the > many many places where rpm is used, I chose the safest option > and used a trylock to opportunistically take this lock for > __engine_unpark. Correct choice, runtime pm resu

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-24 Thread Jason Gunthorpe
On Wed, Mar 24, 2021 at 01:35:17PM +0100, Thomas Hellström (Intel) wrote: > > On 3/24/21 1:24 PM, Jason Gunthorpe wrote: > > On Wed, Mar 24, 2021 at 10:56:43AM +0100, Daniel Vetter wrote: > > > On Tue, Mar 23, 2021 at 06:06:53PM +0100, Thomas Hellström (Intel) wrote: > > > > On 3/23/21 5:37 PM, Ja

Re: [PATCH 3/3] mm: unexport follow_pfn

2021-03-24 Thread Jason Gunthorpe
On Tue, Mar 16, 2021 at 04:33:03PM +0100, Daniel Vetter wrote: > Both kvm (in bd2fae8da794 ("KVM: do not assume PTE is writable after > follow_pfn")) and vfio (in 07956b6269d3 ("vfio/type1: Use > follow_pte()")) have lost their callsites of follow_pfn(). All the > other ones have been switched over

Re: [PATCH] amdgpu: fix gcc -Wrestrict warning

2021-03-24 Thread Arnd Bergmann
On Tue, Mar 23, 2021 at 4:57 PM Rasmus Villemoes wrote: > On 23/03/2021 14.04, Arnd Bergmann wrote: > > if (securedisplay_cmd->status == > > TA_SECUREDISPLAY_STATUS__SUCCESS) { > > + int pos = 0; > > memset(i2c_output

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-24 Thread Intel
On 3/24/21 1:41 PM, Jason Gunthorpe wrote: On Wed, Mar 24, 2021 at 01:35:17PM +0100, Thomas Hellström (Intel) wrote: On 3/24/21 1:24 PM, Jason Gunthorpe wrote: On Wed, Mar 24, 2021 at 10:56:43AM +0100, Daniel Vetter wrote: On Tue, Mar 23, 2021 at 06:06:53PM +0100, Thomas Hellström (Intel) wro

[PATCH] amdgpu: securedisplay: simplify i2c hexdump output

2021-03-24 Thread Arnd Bergmann
From: Arnd Bergmann A previous fix I did left a rather complicated loop in amdgpu_securedisplay_debugfs_write() for what could be expressed in a simple sprintf, as Rasmus pointed out. This drops the leading 0x for each byte, but is otherwise much nicer. Suggested-by: Rasmus Villemoes Signed-of

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-24 Thread Jason Gunthorpe
On Wed, Mar 24, 2021 at 02:35:38PM +0100, Thomas Hellström (Intel) wrote: > > In an ideal world the creation/destruction of page table levels would > > by dynamic at this point, like THP. > > Hmm, but I'm not sure what problem we're trying to solve by changing the > interface in this way? We are

[PATCH] drm/ttm: switch back to static allocation limits for now

2021-03-24 Thread Christian König
The shrinker based approach still has some flaws. Especially that we need temporary pages to free up the pages allocated to the driver is problematic in a shrinker. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_device.c | 14 ++-- drivers/gpu/drm/ttm/ttm_tt.c | 112

[PATCH] drm/radeon/r600_cs: Couple of typo fixes

2021-03-24 Thread Bhaskar Chowdhury
s/miror/mirror/ s/needind/needing/ Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/radeon/r600_cs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r600_cs.c index 34b7c6f16479..aded1f2264e0 100644 --- a/dri

Re: [Intel-gfx] [PATCH v9 11/70] drm/i915: Disable userptr pread/pwrite support.

2021-03-24 Thread Jason Ekstrand
Never used by Mesa AFAIK Acked-by: Jason Ekstrand On Tue, Mar 23, 2021 at 10:51 AM Maarten Lankhorst wrote: > > Userptr should not need the kernel for a userspace memcpy, userspace > needs to call memcpy directly. > > Specifically, disable i915_gem_pwrite_ioctl() and i915_gem_pread_ioctl(). > >

Re: [Intel-gfx] [PATCH resend 2/2] drm/i915/display: Make vlv_find_free_pps() skip pipes which are in use for non DP purposes

2021-03-24 Thread Ville Syrjälä
On Tue, Mar 23, 2021 at 11:39:09AM +0100, Hans de Goede wrote: > Hi, > > On 3/2/21 3:51 PM, Ville Syrjälä wrote: > > On Tue, Mar 02, 2021 at 01:00:40PM +0100, Hans de Goede wrote: > >> As explained by a long comment block, on VLV intel_setup_outputs() > >> sometimes thinks there might be an eDP pa

Re: [Intel-gfx] [PATCH resend 2/2] drm/i915/display: Make vlv_find_free_pps() skip pipes which are in use for non DP purposes

2021-03-24 Thread Hans de Goede
Hi, On 3/24/21 3:02 PM, Ville Syrjälä wrote: > On Tue, Mar 23, 2021 at 11:39:09AM +0100, Hans de Goede wrote: >> Hi, >> >> On 3/2/21 3:51 PM, Ville Syrjälä wrote: >>> On Tue, Mar 02, 2021 at 01:00:40PM +0100, Hans de Goede wrote: As explained by a long comment block, on VLV intel_setup_output

Re: [Intel-gfx] [PATCH v9 28/70] drm/i915: Take obj lock around set_domain ioctl

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 04:50:17PM +0100, Maarten Lankhorst wrote: > We need to lock the object to move it to the correct domain, > add the missing lock. > > Signed-off-by: Maarten Lankhorst > Reviewed-by: Thomas Hellström This conflicted real bad with the in-flight -gt-next stuff that wasn't r

Re: [PATCH] amdgpu: fix gcc -Wrestrict warning

2021-03-24 Thread Rasmus Villemoes
On 24/03/2021 14.33, Arnd Bergmann wrote: > On Tue, Mar 23, 2021 at 4:57 PM Rasmus Villemoes > wrote: >> On 23/03/2021 14.04, Arnd Bergmann wrote: >>> if (securedisplay_cmd->status == >>> TA_SECUREDISPLAY_STATUS__SUCCESS) { >>> + int pos = 0; >>>

Re: [PATCH] [v2] drm/imx: imx-ldb: fix out of bounds array access warning

2021-03-24 Thread Joe Perches
On Wed, 2021-03-24 at 13:17 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_OF is disabled, building with 'make W=1' produces warnings > about out of bounds array access: > > drivers/gpu/drm/imx/imx-ldb.c: In function 'imx_ldb_set_clock.constprop': > drivers/gpu/drm/imx/imx-ldb

Re: RE: [PATCH] video/fbdev: Fix a double free in hvfb_probe

2021-03-24 Thread lyl2019
> -原始邮件- > 发件人: "Michael Kelley" > 发送时间: 2021-03-24 02:52:07 (星期三) > 收件人: "Lv Yunlong" , "KY Srinivasan" > , "Haiyang Zhang" , "Stephen > Hemminger" , "wei@kernel.org" > 抄送: "linux-hyp...@vger.kernel.org" , > "dri-devel@lists.freedesktop.org" , > "linux-fb...@vger.kernel.org" ,

Re: [PATCH 3/3] mm: unexport follow_pfn

2021-03-24 Thread Paolo Bonzini
On 24/03/21 13:52, Jason Gunthorpe wrote: I think this is the right thing to do. Alex is working on fixing VFIO and while kvm is still racy using follow pte, I think they are working on it too? Yeah, or at least we have a plan. Paolo ___ dri-devel

Re: [PATCH] amdgpu: fix gcc -Wrestrict warning

2021-03-24 Thread Joe Perches
On Tue, 2021-03-23 at 14:04 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc warns about an sprintf() that uses the same buffer as source > and destination, which is undefined behavior in C99: > > drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c: In function > 'amdgpu_securedisplay_de

Re: [Intel-gfx] [PATCH resend 2/2] drm/i915/display: Make vlv_find_free_pps() skip pipes which are in use for non DP purposes

2021-03-24 Thread Ville Syrjälä
On Wed, Mar 24, 2021 at 03:10:59PM +0100, Hans de Goede wrote: > Hi, > > On 3/24/21 3:02 PM, Ville Syrjälä wrote: > > On Tue, Mar 23, 2021 at 11:39:09AM +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 3/2/21 3:51 PM, Ville Syrjälä wrote: > >>> On Tue, Mar 02, 2021 at 01:00:40PM +0100, Hans de Go

[PATCH v2] video: hyperv_fb: Fix a double free in hvfb_probe

2021-03-24 Thread Lv Yunlong
In function hvfb_probe in hyperv_fb.c, it calls hvfb_getmem(hdev, info) and return err when info->apertures is freed. In the error1 label of hvfb_probe, info->apertures will be freed for the second time in framebuffer_release(info). My patch removes all kfree(info->apertures) instead of set info-

Re: [PATCH 6/9] drm/tegra: gem: Add a clarifying comment

2021-03-24 Thread Dmitry Osipenko
23.03.2021 18:54, Thierry Reding пишет: > From: Thierry Reding > > Clarify when a fixed IOV address can be used and when a buffer has to > be mapped before the IOVA can be used. > > Signed-off-by: Thierry Reding > --- > drivers/gpu/drm/tegra/plane.c | 8 > 1 file changed, 8 insertions

Re: [Intel-gfx] [PATCH v9 30/70] drm/i915: Fix pread/pwrite to work with new locking rules.

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 04:50:19PM +0100, Maarten Lankhorst wrote: > We are removing obj->mm.lock, and need to take the reservation lock > before we can pin pages. Move the pinning pages into the helper, and > merge gtt pwrite/pread preparation and cleanup paths. > > The fence lock is also removed

Re: [PATCH 3/6] drm/rockchip: dsi: add ability to work as a phy instead of full dsi

2021-03-24 Thread Heiko Stübner
Am Montag, 15. Februar 2021, 15:33:19 CET schrieb Helen Koike: > > From: Heiko Stuebner > > diff --git a/drivers/gpu/drm/rockchip/Kconfig > > b/drivers/gpu/drm/rockchip/Kconfig > > index cb25c0e8fc9b..3094d4533ad6 100644 > > --- a/drivers/gpu/drm/rockchip/Kconfig > > +++ b/drivers/gpu/drm/rockchi

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-24 Thread Mark Yacoub
On Wed, Mar 24, 2021 at 8:10 AM Daniel Stone wrote: > > On Wed, 24 Mar 2021 at 10:53, Bas Nieuwenhuizen > wrote: >> >> On Wed, Mar 24, 2021 at 11:13 AM Michel Dänzer wrote: >>> >>> No modifier support does not imply linear. It's generally signalled via >>> DRM_FORMAT_MOD_INVALID, which roughly

[PATCH 01/21] drm/msm/dpu: enable DPU_SSPP_QOS_8LVL for SM8250

2021-03-24 Thread Dmitry Baryshkov
SM8250 platform has a 8-Levels VIG QoS setting. This setting was missed due to bad interaction with b8dab65b5ac3 ("drm/msm/dpu: Move DPU_SSPP_QOS_8LVL bit to SDM845 and SC7180 masks"), which was applied in parallel. Fixes: d21fc5dfc3df ("drm/msm/dpu1: add support for qseed3lite used on sm8250") Si

[PATCH 06/21] drm/msm/dpu: get PINGPONG blocks directly rather than through RM

2021-03-24 Thread Dmitry Baryshkov
Each PINGPONG block is tied to a single LM. No LMs can share single PINGPONG block. So there is no need to handle PINGPONG blocks through all resource allocation/deallocation/assignment, just receive PINGPONG block as a part of LM hardware instance. Signed-off-by: Dmitry Baryshkov --- drivers/gp

[PATCH 03/21] drm/msm/dpu: drop dpu_hw_blk_destroy function

2021-03-24 Thread Dmitry Baryshkov
The dpu_hw_blk_destroy() function is empty, so we can drop it now. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 13 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.h | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 2 -- drivers/gpu/

[PATCH 04/21] drm/msm/dpu: get DSPP blocks directly rather than through RM

2021-03-24 Thread Dmitry Baryshkov
Each DSPP block is tied to a single LM. No LMs can share single DSPP block. So there is no need to handle DSPP blocks through all resource allocation/deallocation/assignment, just receive DSPP block as a part of LM hardware instance. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/d

[PATCH 07/21] drm/msm/dpu: drop unused lm_max_width from RM

2021-03-24 Thread Dmitry Baryshkov
No code uses lm_max_width from resource manager, so drop it. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 12 drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 4 2 files changed, 16 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/dr

[PATCH 13/21] drm/msm/dpu: hw_pp: make setup_dither mandatory

2021-03-24 Thread Dmitry Baryshkov
All supported hardware instances feature DPU_PINGPONG_DITHER option, so just mark setup_dither as mandatory rather than optional callback. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 3 +-- 2 files

[PATCH 08/21] drm/msm/dpu: simplify peer LM handling

2021-03-24 Thread Dmitry Baryshkov
For each LM there is at max 1 peer LM which can be driven by the same CTL, so there no need to have a mask instead of just an ID of the peer LM. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 2 +- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 4 +-- driv

[PATCH 05/21] drm/msm/dpu: get MERGE_3D blocks directly rather than through RM

2021-03-24 Thread Dmitry Baryshkov
MERGE_3D blocks are not really handled by resource manager, they are used by corresponding PP blocks directly, each merge_3d is used by two known PP blocks. So allocate them outside of RM and use them directly. Signed-off-by: Dmitry Baryshkov --- .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 1

[PATCH 12/21] drm/msm/dpu: call hw_dspp ops directly

2021-03-24 Thread Dmitry Baryshkov
Replace dpu_hw_dspp callbacks with direct functions calls. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 6 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 15 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h | 19 ++- 3 files

[PATCH 00/21] drm/msm/dpu: cleanup callbacks, resource manager

2021-03-24 Thread Dmitry Baryshkov
In the DPU driver each and every component would provide callbacks, which are mostly static. Other components would use callbacks to receive functionality instead of calling functions directly. Drop (most) of this indirection, replacing with direct function calls. CTL and SSPP blocks are left uncon

  1   2   3   >