[PATCH v2, 16/17] drm/mediatek: add support for mediatek SOC MT8192

2020-12-14 Thread Yongqiang Niu
add support for mediatek SOC MT8192 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 6 drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 20 + drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 drivers/gpu/drm/mediatek/mtk_drm_ddp.c| 35

Re: [PATCH v4 0/5] Thermal devfreq cooling improvements with Energy Model

2020-12-14 Thread Lukasz Luba
Hi Daniel, Do you think it has chance to go to as material for v5.11? Regards, Lukasz On 12/10/20 2:30 PM, Lukasz Luba wrote: Hi all, This patch set is a continuation of my previous work, which aimed to add Energy Model to all devices [1]. This series is a follow up for the patches which got

[PATCH -next] drm/rockchip: cdn-dp-core: fix function not used when not PM_SLEEP

2020-12-14 Thread Randy Dunlap
Fix build warning when CONFIG_PM_SLEEP is not enabled. ../drivers/gpu/drm/rockchip/cdn-dp-core.c:1124:12: warning: ‘cdn_dp_resume’ defined but not used [-Wunused-function] static int cdn_dp_resume(struct device *dev) Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/res

[PATCH v2, 00/17] drm/mediatek: add support for mediatek SOC MT8192

2020-12-14 Thread Yongqiang Niu
This series are based on 5.10-rc1 and provid 17 patch to support mediatek SOC MT8192 Changes in v2: - base mmsys https://patchwork.kernel.org/project/linux-mediatek/cover/1607506379-10998-1-git-send-email-yongqiang@mediatek.com/ - base mt8192 gce dtbinding file https://patchwork.kernel.org/pro

Re: [patch 14/30] drm/i915/pmu: Replace open coded kstat_irqs() copy

2020-12-14 Thread Thomas Gleixner
On Fri, Dec 11 2020 at 10:13, Tvrtko Ursulin wrote: > On 10/12/2020 19:25, Thomas Gleixner wrote: >> >> Aside of that the count is per interrupt line and therefore takes >> interrupts from other devices into account which share the interrupt line >> and are not handled by the graphics driver. >>

RE: [patch 14/30] drm/i915/pmu: Replace open coded kstat_irqs() copy

2020-12-14 Thread Thomas Gleixner
On Fri, Dec 11 2020 at 14:19, David Laight wrote: > From: Thomas Gleixner >> You can't catch that. If this really becomes an issue you need a >> sequence counter around it. > > Or just two copies of the high word. > Provided the accesses are sequenced: > writer: > load high:low > add sm

[PATCH v2, 12/17] drm/mediatek: fix gamma size config

2020-12-14 Thread Yongqiang Niu
fix gamma size config Fixes: e0a5d3370245 (drm/mediatek: Add GAMMA engine basic function) Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/dr

RE: [patch 14/30] drm/i915/pmu: Replace open coded kstat_irqs() copy

2020-12-14 Thread David Laight
From: Thomas Gleixner > Sent: 11 December 2020 12:58 .. > > After my failed hasty sketch from last night I had a different one which > > was kind of heuristics based (re-reading the upper dword and retrying if > > it changed on 32-bit). > > The problem is that there will be two seperate modificati

[PATCH v2, 06/17] drm/mediatek: add component RDMA4

2020-12-14 Thread Yongqiang Niu
This patch add component RDMA4 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + include/linux/soc/mediatek/mtk-mmsys.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp

Re: [PATCH v4 0/5] Thermal devfreq cooling improvements with Energy Model

2020-12-14 Thread Daniel Lezcano
On 11/12/2020 16:11, Lukasz Luba wrote: > Hi Daniel, > > Do you think it has chance to go to as material for v5.11? Yes, it is in the thermal/linux-next material ATM. > On 12/10/20 2:30 PM, Lukasz Luba wrote: >> Hi all, >> >> This patch set is a continuation of my previous work, which aimed >>

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-14 Thread Thomas Gleixner
On Fri, Dec 11 2020 at 09:29, boris ostrovsky wrote: > On 12/11/20 7:37 AM, Thomas Gleixner wrote: >> On Fri, Dec 11 2020 at 13:10, Jürgen Groß wrote: >>> On 11.12.20 00:20, boris.ostrov...@oracle.com wrote: On 12/10/20 2:26 PM, Thomas Gleixner wrote: > Change the implementation so that t

Re: Fence wait in mmu_interval_notifier_ops::invalidate

2020-12-14 Thread Jason Gunthorpe
On Fri, Dec 11, 2020 at 08:50:53AM +0100, Thomas Hellström (Intel) wrote: > My understanding of this particular case is that hardware would continue to > DMA to orphaned pages that are pinned until the driver is done with > DMA, mmu notifier replaces pinning as the locking mechanism. Drivers usin

[PATCH v2, 09/17] drm/mediatek: check if fb is null

2020-12-14 Thread Yongqiang Niu
It's possible that state->base.fb is null. Add a check before access its format. Fixes: b6b1bb980ec4 ( drm/mediatek: Turn off Alpha bit when plane format has no alpha) Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2, 07/17] drm/mediatek: add disp config and mm 26mhz clock into mutex device

2020-12-14 Thread Yongqiang Niu
there are 2 more clock need enable for display. parser these clock when mutex device probe, enable and disable when mutex on/off Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 49 -- 1 file changed, 41 insertions(+), 8 deletions(-) diff

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-14 Thread Thomas Gleixner
On Fri, Dec 11 2020 at 13:10, Jürgen Groß wrote: > On 11.12.20 00:20, boris.ostrov...@oracle.com wrote: >> >> On 12/10/20 2:26 PM, Thomas Gleixner wrote: >>> All event channel setups bind the interrupt on CPU0 or the target CPU for >>> percpu interrupts and overwrite the affinity mask with the cor

Re: [patch 21/30] net/mlx4: Use effective interrupt affinity

2020-12-14 Thread Tariq Toukan
On 12/10/2020 9:25 PM, Thomas Gleixner wrote: Using the interrupt affinity mask for checking locality is not really working well on architectures which support effective affinity masks. The affinity mask is either the system wide default or set by user space, but the architecture can or even

[PATCH v2, 04/17] drm/mediatek: add component OVL_2L2

2020-12-14 Thread Yongqiang Niu
This patch add component OVL_2L2 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + include/linux/soc/mediatek/mtk-mmsys.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_d

[PATCH v2, 02/17] dt-bindings: mediatek: add CLK_MM_DISP_CONFIG control description for mt8192 display

2020-12-14 Thread Yongqiang Niu
add CLK_MM_DISP_CONFIG control description for mt8192 displa Signed-off-by: Yongqiang Niu --- Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Docum

Re: [PATCH v4 0/5] Thermal devfreq cooling improvements with Energy Model

2020-12-14 Thread Lukasz Luba
On 12/11/20 3:15 PM, Daniel Lezcano wrote: On 11/12/2020 16:11, Lukasz Luba wrote: Hi Daniel, Do you think it has chance to go to as material for v5.11? Yes, it is in the thermal/linux-next material ATM. Thank you! Regards, Lukasz ___ dri-deve

Re: [PATCH 2/9] misc: Add Xilinx AI engine device driver

2020-12-14 Thread Jiaying Liang
On 12/9/20 4:47 AM, Daniel Vetter wrote: On Tue, Dec 08, 2020 at 11:54:57AM -0800, Jiaying Liang wrote: On 12/8/20 9:12 AM, Nicolas Dufresne wrote: Le mercredi 18 novembre 2020 à 00:06 -0800, Wendy Liang a écrit : Create AI engine device/partition hierarchical structure. Each AI engine devic

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-14 Thread Thomas Gleixner
Andrew, On Fri, Dec 11 2020 at 22:21, Andrew Cooper wrote: > On 11/12/2020 21:27, Thomas Gleixner wrote: >> It's not any different from the hardware example at least not as far as >> I understood the code. > > Xen's event channels do have a couple of quirks. Why am I not surprised? > Binding an

[PATCH v2, 08/17] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

2020-12-14 Thread Yongqiang Niu
enable OVL_LAYER_SMI_ID_EN for multi-layer usecase Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c index 8cf9f3b..97f8380

[PATCH linux-next] drm/amd/display: Adding prototype for dccg21_update_dpp_dto()

2020-12-14 Thread Souptick Joarder
Kernel test robot throws below warning -> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_dccg.c:46:6: warning: no previous prototype for 'dccg21_update_dpp_dto' [-Wmissing-prototypes] Adding prototype for dccg21_update_dpp_dto(). Reported-by: kernel test robot Signed-off-by: Souptick Joar

RE: [patch 14/30] drm/i915/pmu: Replace open coded kstat_irqs() copy

2020-12-14 Thread David Laight
From: Thomas Gleixner > Sent: 11 December 2020 21:11 > > On Fri, Dec 11 2020 at 14:19, David Laight wrote: > > From: Thomas Gleixner > >> You can't catch that. If this really becomes an issue you need a > >> sequence counter around it. > > > > Or just two copies of the high word. > > Provided the

[PATCH v2, 14/17] soc: mediatek: mmsys: Use function call for setting mmsys ovl mout register

2020-12-14 Thread Yongqiang Niu
Use function call for setting mmsys ovl mout register Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mmsys/mtk-mmsys.c | 18 ++ include/linux/soc/mediatek/mtk-mmsys.h | 3 +++ 2 files changed, 21 insertions(+) diff --git a/drivers/soc/mediatek/mmsys/mtk-mmsys.c b/driver

[PATCH v2, 15/17] soc: mediatek: mmsys: add mt8192 mmsys support

2020-12-14 Thread Yongqiang Niu
add mt8192 mmsys support Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mmsys/Makefile | 1 + drivers/soc/mediatek/mmsys/mt8192-mmsys.c | 119 ++ include/linux/soc/mediatek/mtk-mmsys.h| 1 + 3 files changed, 121 insertions(+) create mode 100644 d

[PATCH] drm/rockchip: dsi: remove extra component_del() call

2020-12-14 Thread Thomas Hebb
commit cf6d100dd238 ("drm/rockchip: dsi: add dual mipi support") added this devcnt field and call to component_del(). However, these both appear to be erroneous changes left over from an earlier version of the patch. In the version merged, nothing ever modifies devcnt, meaning component_del() runs

Re: [patch 22/30] net/mlx5: Replace irq_to_desc() abuse

2020-12-14 Thread Tariq Toukan
On 12/10/2020 9:25 PM, Thomas Gleixner wrote: No driver has any business with the internals of an interrupt descriptor. Storing a pointer to it just to use yet another helper at the actual usage site to retrieve the affinity mask is creative at best. Just because C does not allow encapsulation

Re: [patch 23/30] net/mlx5: Use effective interrupt affinity

2020-12-14 Thread Tariq Toukan
On 12/10/2020 9:25 PM, Thomas Gleixner wrote: Using the interrupt affinity mask for checking locality is not really working well on architectures which support effective affinity masks. The affinity mask is either the system wide default or set by user space, but the architecture can or even

[PATCH v2, 10/17] drm/mediatek: fix aal size config

2020-12-14 Thread Yongqiang Niu
fix aal size config Fixes: 0664d1392c26 (drm/mediatek: Add AAL engine basic function) Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/driver

Re: [patch 03/30] genirq: Move irq_set_lockdep_class() to core

2020-12-14 Thread Thomas Gleixner
On Fri, Dec 11 2020 at 19:53, Andy Shevchenko wrote: > On Thu, Dec 10, 2020 at 10:14 PM Thomas Gleixner wrote: >> >> irq_set_lockdep_class() is used from modules and requires irq_to_desc() to >> be exported. Move it into the core code which lifts another requirement for >> the export. > > ... > >

[PATCH v2, 17/17] arm64: dts: mt8192: add display node

2020-12-14 Thread Yongqiang Niu
add display node Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 130 +++ 1 file changed, 130 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index 7c0c233..da681b0 100644 ---

[PATCH v2, 11/17] drm/mediatek: fix dither size config

2020-12-14 Thread Yongqiang Niu
fix dither size config Fixes: 450aa87c7353 (drm/mediatek: add component DITHER) Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek

Re: [patch 20/30] net/mlx4: Replace irq_to_desc() abuse

2020-12-14 Thread Tariq Toukan
On 12/10/2020 9:25 PM, Thomas Gleixner wrote: No driver has any business with the internals of an interrupt descriptor. Storing a pointer to it just to use yet another helper at the actual usage site to retrieve the affinity mask is creative at best. Just because C does not allow encapsulation

[PATCH] drm/amd/display: Fixed kernel test robot warning

2020-12-14 Thread Souptick Joarder
Kernel test robot throws below warning -> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5349:5: warning: no previous prototype for 'amdgpu_dm_crtc_atomic_set_property' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5349:5: warning: no previous prot

[PATCH] drm/rockchip: dsi: move all lane config except LCDC mux to bind()

2020-12-14 Thread Thomas Hebb
When we first enable the DSI encoder, we currently program some per-chip configuration that we look up in rk3399_chip_data based on the device tree compatible we match. This data configures various parameters of the MIPI lanes, including on RK3399 whether DSI1 is slaved to DSI0 in a dual-mode confi

[PATCH v2, 03/17] dt-bindings: mediatek: add description for mt8192 display

2020-12-14 Thread Yongqiang Niu
add description for mt8192 display Signed-off-by: Yongqiang Niu --- Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devi

[PATCH v2, 05/17] drm/mediatek: add component POSTMASK

2020-12-14 Thread Yongqiang Niu
This patch add component POSTMASK Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 31 + drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 + include/linux/soc/mediatek/mtk-mmsys.h | 1 + 3 files changed, 33 insertions(+) diff --git

[PATCH v2, 13/17] drm/mediatek: fix ccorr size config

2020-12-14 Thread Yongqiang Niu
fix ccorr size config Fixes: cefb6abfcc1c (drm/mediatek: add ddp component CCORR) Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediat

[PATCH v2, 01/17] dt-bindings: mediatek: add description for postmask

2020-12-14 Thread Yongqiang Niu
add description for postmask Signed-off-by: Yongqiang Niu --- Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/displa

Re: [PATCH v2, 15/17] soc: mediatek: mmsys: add mt8192 mmsys support

2020-12-14 Thread Yongqiang Niu
On Mon, 2020-12-14 at 00:02 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu 於 2020年12月12日 週六 下午12:22寫道: > > > > add mt8192 mmsys support > > > > Signed-off-by: Yongqiang Niu > > --- > > drivers/soc/mediatek/mmsys/Makefile | 1 + > > drivers/soc/mediatek/mmsys/mt8192-mmsys

Re: [patch 03/30] genirq: Move irq_set_lockdep_class() to core

2020-12-14 Thread Thomas Gleixner
On Fri, Dec 11 2020 at 22:08, Thomas Gleixner wrote: > On Fri, Dec 11 2020 at 19:53, Andy Shevchenko wrote: > >> On Thu, Dec 10, 2020 at 10:14 PM Thomas Gleixner wrote: >>> >>> irq_set_lockdep_class() is used from modules and requires irq_to_desc() to >>> be exported. Move it into the core code w

Re: [PATCH v3 4/4] drm: require each CRTC to have a unique primary plane

2020-12-14 Thread Pekka Paalanen
On Fri, 11 Dec 2020 14:39:35 + Simon Ser wrote: > On Friday, December 11th, 2020 at 2:50 PM, Pekka Paalanen > wrote: > > > is there a reason why one cannot have more primary planes than CRTCs in > > existence? > > > > Daniel implied that in <20201209003637.GK401619@phenom.ffwll.local>, > >

Re: [PATCH v5 1/6] drm/damage_helper: Check if damage clips has valid values

2020-12-14 Thread Simon Ser
> Userspace can set a damage clip with a negative coordinate, negative > width or height or larger than the plane. > This invalid values could cause issues in some HW or even worst enable > security flaws. > > v2: > - add debug messages to let userspace know why atomic commit failed > due invalid d

Re: [PATCH 1/1] drm/scheduler: Job timeout handler returns status (v2)

2020-12-14 Thread Steven Price
On 11/12/2020 21:44, Luben Tuikov wrote: On 2020-12-10 4:46 a.m., Steven Price wrote: On 10/12/2020 02:14, Luben Tuikov wrote: This patch does not change current behaviour. The driver's job timeout handler now returns status indicating back to the DRM layer whether the task (job) was successfu

Re: [PATCH 1/1] drm/scheduler: Job timeout handler returns status (v2)

2020-12-14 Thread Christian König
Am 11.12.20 um 21:44 schrieb Luben Tuikov: On 2020-12-10 4:41 a.m., Christian König wrote: Am 10.12.20 um 10:31 schrieb Lucas Stach: Hi Luben, Am Mittwoch, den 09.12.2020, 21:14 -0500 schrieb Luben Tuikov: [SNIP] -static void etnaviv_sched_timedout_job(struct drm_sched_job *sched_job) +static

Re: [PATCH 2/4] drm/amdgpu/ttm: use multihop

2020-12-14 Thread Daniel Vetter
On Sun, Dec 13, 2020 at 2:44 AM Mike Lothian wrote: > > Hi > > This patch is causing issues for me on both a Raven system and a Tonga > (PRIME) system > > https://gitlab.freedesktop.org/drm/amd/-/issues/1405 > > It's only recently been merged into agd5f's tree - which is why I'm > only just notici

Re: [PATCH v5 1/6] drm/damage_helper: Check if damage clips has valid values

2020-12-14 Thread Mun, Gwan-gyeong
On Mon, 2020-12-14 at 08:55 +, Simon Ser wrote: > > Userspace can set a damage clip with a negative coordinate, > > negative > > width or height or larger than the plane. > > This invalid values could cause issues in some HW or even worst > > enable > > security flaws. > > > > v2: > > - add de

Re: [PATCH AUTOSEL 4.14 2/8] drm/nouveau: make sure ret is initialized in nouveau_ttm_io_mem_reserve

2020-12-14 Thread Christian König
Hi Sasha, please don't apply this patch to any older kernel. The fix was only needed for a patch which went in with the 5.10 pull request. Thanks, Christian. Am 12.12.20 um 17:08 schrieb Sasha Levin: From: Christian König [ Upstream commit aea656b0d05ec5b8ed5beb2f94c4dd42ea834e9d ] This

Re: [PATCH 2/9] misc: Add Xilinx AI engine device driver

2020-12-14 Thread Daniel Vetter
On Fri, Dec 11, 2020 at 06:27:05PM -0800, Jiaying Liang wrote: > > On 12/9/20 4:47 AM, Daniel Vetter wrote: > > On Tue, Dec 08, 2020 at 11:54:57AM -0800, Jiaying Liang wrote: > > > On 12/8/20 9:12 AM, Nicolas Dufresne wrote: > > > > Le mercredi 18 novembre 2020 à 00:06 -0800, Wendy Liang a écrit :

Re: Fence wait in mmu_interval_notifier_ops::invalidate

2020-12-14 Thread Daniel Vetter
On Sun, Dec 13, 2020 at 04:09:25PM +0100, Thomas Hellström (Intel) wrote: > > On 12/11/20 1:46 PM, Jason Gunthorpe wrote: > > On Fri, Dec 11, 2020 at 08:50:53AM +0100, Thomas Hellström (Intel) wrote: > > > > > My understanding of this particular case is that hardware would continue > > > to > >

Re: [Intel-gfx] [PATCH v5 1/6] drm/damage_helper: Check if damage clips has valid values

2020-12-14 Thread Daniel Vetter
On Mon, Dec 14, 2020 at 09:27:30AM +, Mun, Gwan-gyeong wrote: > On Mon, 2020-12-14 at 08:55 +, Simon Ser wrote: > > > Userspace can set a damage clip with a negative coordinate, > > > negative > > > width or height or larger than the plane. > > > This invalid values could cause issues in so

Re: [PATCH 2/9] drm: rcar-du: Release vsp device reference in all error paths

2020-12-14 Thread Jacopo Mondi
Hi Laurent, On Sat, Dec 05, 2020 at 12:01:32AM +0200, Laurent Pinchart wrote: > Use drmm_add_action_or_reset() instead of drmm_add_action() to ensure > the vsp device reference is released in case the function call fails. > > Signed-off-by: Laurent Pinchart Just in case... better safe than sorry

Re: [PATCH 1/9] drm: rcar-du: Fix crash when using LVDS1 clock for CRTC

2020-12-14 Thread Jacopo Mondi
Hi Laurent, On Sat, Dec 05, 2020 at 12:01:31AM +0200, Laurent Pinchart wrote: > On D3 and E3 platforms, the LVDS encoder includes a PLL that can > generate a clock for the corresponding CRTC, used even when the CRTC > output to a non-LVDS port. This mechanism is supported by the driver, > but the

Re: [PATCH 3/9] drm: rcar-du: Drop unneeded encoder cleanup in error path

2020-12-14 Thread Jacopo Mondi
Hi Laurent, On Sat, Dec 05, 2020 at 12:01:33AM +0200, Laurent Pinchart wrote: > The encoder->name field can never be non-null in the error path, as that > can only be possible after a successful call to > drm_simple_encoder_init(). Drop the cleanup. > > Signed-off-by: Laurent Pinchart > --- > dr

Re: Fence wait in mmu_interval_notifier_ops::invalidate

2020-12-14 Thread Christian König
Am 14.12.20 um 10:52 schrieb Daniel Vetter: On Sun, Dec 13, 2020 at 04:09:25PM +0100, Thomas Hellström (Intel) wrote: On 12/11/20 1:46 PM, Jason Gunthorpe wrote: On Fri, Dec 11, 2020 at 08:50:53AM +0100, Thomas Hellström (Intel) wrote: My understanding of this particular case is that hardware

Re: [PATCH 1/4] dma-buf: Remove kmap kerneldoc vestiges

2020-12-14 Thread Christian König
Am 11.12.20 um 16:58 schrieb Daniel Vetter: Also try to clarify a bit when dma_buf_begin/end_cpu_access should be called. Signed-off-by: Daniel Vetter Cc: Thomas Zimmermann Cc: Sumit Semwal Cc: "Christian König" Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org --- drivers

Re: [PATCH 3/4] dma-buf: begin/end_cpu might lock the dma_resv lock

2020-12-14 Thread Christian König
Am 11.12.20 um 16:58 schrieb Daniel Vetter: At least amdgpu and i915 do, so lets just document this as the rule. Signed-off-by: Daniel Vetter Cc: Thomas Zimmermann Cc: Sumit Semwal Cc: "Christian König" Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org Reviewed-by: Christi

Re: [PATCH 5/9] drm: rcar-du: Use DRM-managed allocation for encoders

2020-12-14 Thread Jacopo Mondi
Hi Laurent, On Sat, Dec 05, 2020 at 12:01:35AM +0200, Laurent Pinchart wrote: > devm_kzalloc() is the wrong API to allocate encoders, as the lifetime of > the encoders is tied to the DRM device, not the device to driver > binding. drmm_kzalloc() isn't a good option either, as it would result > in

Re: [PATCH 6/9] drm: rcar-du: Embed drm_device in rcar_du_device

2020-12-14 Thread Jacopo Mondi
Hi Laurent, On Sat, Dec 05, 2020 at 12:01:36AM +0200, Laurent Pinchart wrote: > Embedding drm_device in rcar_du_device allows usage of the DRM managed > API to allocate both structures in one go, simplifying error handling. > > Signed-off-by: Laurent Pinchart Looks good to me (re-sorting the hea

Re: [PATCH 7/9] drm: rcar-du: Replace dev_private with container_of

2020-12-14 Thread Jacopo Mondi
Hi Laurent, On Sat, Dec 05, 2020 at 12:01:37AM +0200, Laurent Pinchart wrote: > Now that drm_device is embedded in rcar_du_device, we can use > container_of to get the rcar_du_device pointer from the drm_device, > instead of using the drm_device.dev_private field. > > Signed-off-by: Laurent Pincha

Re: [PATCH 8/9] drm: rcar-du: Skip encoder allocation for LVDS1 in dual-link mode

2020-12-14 Thread Jacopo Mondi
Hi Laurent, On Sat, Dec 05, 2020 at 12:01:38AM +0200, Laurent Pinchart wrote: > The rcar-du driver skips registration of the encoder for the LVDS1 > output when LVDS is used in dual-link mode, as the LVDS0 and LVDS1 links > are bundled and handled through the LVDS0 output. It however still > alloc

Re: [PATCH 9/9] drm: rcar-du: Drop local encoder variable

2020-12-14 Thread Jacopo Mondi
Hi Laurent, On Sat, Dec 05, 2020 at 12:01:39AM +0200, Laurent Pinchart wrote: > The local encoder variable is an alias for &renc->base, and is only use > twice. It doesn't help much, drop it, along with the > rcar_encoder_to_drm_encoder() macro that is then unused. > > Signed-off-by: Laurent Pinch

Re: [PATCH] drm/hisilicon: Fix use-after-free

2020-12-14 Thread Thomas Zimmermann
Hi Am 14.12.20 um 11:32 schrieb Tian Tao: Fix the problem of dev being released twice. [ cut here ] refcount_t: underflow; use-after-free. WARNING: CPU: 75 PID: 15700 at lib/refcount.c:28 refcount_warn_saturate+0xd4/0x150 CPU: 75 PID: 15700 Comm: rmmod Tainted: G

Re: [PATCH v3] drm: rockchip: hdmi: enable higher resolutions than FHD

2020-12-14 Thread Robin Murphy
On 2020-12-14 11:03, Vicente Bergas wrote: On Tue, Dec 1, 2020 at 5:06 PM Vicente Bergas wrote: This patch enables a QHD HDMI monitor to work at native resolution. Please, anybody? Has anyone been able to validate this on other SoCs? I guess that's still the main concern - empirically I've

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-14 Thread Andrew Cooper
On 11/12/2020 21:27, Thomas Gleixner wrote: > On Fri, Dec 11 2020 at 09:29, boris ostrovsky wrote: > >> On 12/11/20 7:37 AM, Thomas Gleixner wrote: >>> On Fri, Dec 11 2020 at 13:10, Jürgen Groß wrote: On 11.12.20 00:20, boris.ostrov...@oracle.com wrote: > On 12/10/20 2:26 PM, Thomas Gleixn

Re: [PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-14 Thread Hridya Valsaraju
Thank you Christian! On Fri, Dec 11, 2020 at 12:03 AM Christian König wrote: > > Am 10.12.20 um 23:41 schrieb Hridya Valsaraju: > > Thanks again for the reviews! > > > > On Thu, Dec 10, 2020 at 3:03 AM Christian König > > wrote: > >> Am 10.12.20 um 11:56 schrieb Greg KH: > >>> On Thu, Dec 10, 20

Re: [PATCH v4 50/80] drm/omap: squash omapdrm sub-modules into one

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:08PM +0200, Tomi Valkeinen wrote: > At the moment we have three different modules: omapdss-base, omapdss, > omapdrm. This setup is finally obsolete, as the last omapdrm specific > panel has been converted to DRM panel. > > We can thus remove omapdss-base and omap

Re: [PATCH v4 51/80] drm/omap: remove unused display.c

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:09PM +0200, Tomi Valkeinen wrote: > The functions in display.c are not used, so drop the file. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/Makefile | 2

Re: [PATCH v4 52/80] drm/omap: drop unused owner field

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:10PM +0200, Tomi Valkeinen wrote: > dssdev->owner is set, but never used. We can drop the field. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dpi.c | 1

Re: [PATCH v4 53/80] drm/omap: remove dispc_ops

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:11PM +0200, Tomi Valkeinen wrote: > dispc_ops was created to help with the multi-module architecture and > giving us the possibility of multiple dispc implementations. Neither of > these is valid anymore, and we can remove dispc_ops and use direct > calls to dispc

Re: [PATCH v4 54/80] drm/omap: remove dss_mgr_ops

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:12PM +0200, Tomi Valkeinen wrote: > dss_mgr_ops was needed with the multi-module architecture, but is no > longer needed. We can thus remove it and use direct calls. > > Signed-off-by: Tomi Valkeinen > Acked-by: Laurent Pinchart > --- Reviewed-by: Sebastian Re

Re: [PATCH v4 55/80] drm/panel: panel-dsi-cm: use MIPI_DCS_GET_ERROR_COUNT_ON_DSI

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:13PM +0200, Tomi Valkeinen wrote: > Use the common MIPI_DCS_GET_ERROR_COUNT_ON_DSI define instead of > driver's own. > > Signed-off-by: Tomi Valkeinen > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/panel/panel-dsi-cm.c | 3 +-- > 1 file

Re: [PATCH v4 56/80] drm/panel: panel-dsi-cm: cleanup tear enable

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:14PM +0200, Tomi Valkeinen wrote: > Simplify the code by moving code from _dsicm_enable_te() into > dsicm_power_on(). > > Signed-off-by: Tomi Valkeinen > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/panel/panel-dsi-cm.c | 23 ---

Re: [PATCH v4 57/80] ARM: dts: omap5: add address-cells & size-cells to dsi

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:15PM +0200, Tomi Valkeinen wrote: > Add address-cells & size-cells to DSI nodes so that board files do not > need to define them. > > Signed-off-by: Tomi Valkeinen > Cc: Tony Lindgren > --- Reviewed-by: Sebastian Reichel -- Sebastian > arch/arm/boot/dts/om

Re: [PATCH v4 58/80] drm/omap: pll: fix iteration loop check

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:16PM +0200, Tomi Valkeinen wrote: > If the PLL calc function is given bad parameters, n_start/m_start may be > higher than n_stop/m_stop, which leads to the loops iterating through > the whole u32 number space. > > Fix this by failing early on such cases. > > Si

Re: [PATCH v4 59/80] drm/omap: dsi: set trans_mode according to client mode_flags

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:17PM +0200, Tomi Valkeinen wrote: > The DSI host driver currently ignores the video mode flags in > client->mode_flags. Add the code to take the transfer mode from client's > mode_flags. > > Signed-off-by: Tomi Valkeinen > --- Reviewed-by: Sebastian Reichel -

Re: [PATCH v4 60/80] drm/panel: panel-dsi-cm: set column & page at setup

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:18PM +0200, Tomi Valkeinen wrote: > Set the column & page address once during setup, instead of relying the > DSI host driver to set those. > > Signed-off-by: Tomi Valkeinen > --- I'm fine with or without removal of the variables: Reviewed-by: Sebastian Reiche

Re: Using Etnaviv with mxsfb-drm

2020-12-14 Thread Lucas Stach
Hi Frieder, Am Montag, den 14.12.2020, 13:33 +0100 schrieb Frieder Schrempf: > Hi Lucas, hi Marek, > > while doing some tests on i.MX8MM with Etnaviv and mxsfb-drm (using the > patches for DSIM, GPC, BLK-CTL, etc., see branch at [1]), I noticed that > I don't seem to be able to run glmark2: >

[Bug 210683] New: Nasty gpu powersave regression Navi14

2020-12-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210683 Bug ID: 210683 Summary: Nasty gpu powersave regression Navi14 Product: Drivers Version: 2.5 Kernel Version: 5.10-rc7 Hardware: All OS: Linux Tree: Mainline

Re: [PATCH v5 01/29] drm/panel: panel-dsi-cm: cleanup tear enable

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Dec 08, 2020 at 02:28:27PM +0200, Tomi Valkeinen wrote: > Simplify the code by moving code from _dsicm_enable_te() into > dsicm_power_on(). > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Sam Ravnborg > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebas

Re: [PATCH v5 02/29] ARM: dts: omap5: add address-cells & size-cells to dsi

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Dec 08, 2020 at 02:28:28PM +0200, Tomi Valkeinen wrote: > Add address-cells & size-cells to DSI nodes so that board files do not > need to define them. > > Signed-off-by: Tomi Valkeinen > Cc: Tony Lindgren > Acked-by: Tony Lindgren > --- Reviewed-by: Sebastian Reichel -- Sebasti

[Bug 210683] Nasty gpu powersave regression Navi14

2020-12-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210683 siyia (eutychio...@gmail.com) changed: What|Removed |Added Hardware|All |x86-64 Regression

Re: [PATCH v5 04/29] drm/omap: dsi: set trans_mode according to client mode_flags

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Dec 08, 2020 at 02:28:30PM +0200, Tomi Valkeinen wrote: > The DSI host driver currently ignores the video mode flags in > client->mode_flags. Add the code to take the transfer mode from client's > mode_flags. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- R

Re: [PATCH v5 03/29] drm/omap: pll: fix iteration loop check

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Dec 08, 2020 at 02:28:29PM +0200, Tomi Valkeinen wrote: > If the PLL calc function is given bad parameters, n_start/m_start may be > higher than n_stop/m_stop, which leads to the loops iterating through > the whole u32 number space. > > Fix this by failing early on such cases. > > Si

Re: [PATCH v5 05/29] drm/panel: panel-dsi-cm: set column & page at setup

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Dec 08, 2020 at 02:28:31PM +0200, Tomi Valkeinen wrote: > Set the column & page address once during setup, instead of relying the > DSI host driver to set those. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Sam Ravnborg > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebast

Re: [PATCH] drm/amdgpu: fix check oder in amdgpu_bo_move

2020-12-14 Thread Mike Lothian
Tested-by: Mike Lothian Fixes https://gitlab.freedesktop.org/drm/amd/-/issues/1405 Can we make sure this gets into rc1? On Tue, 17 Nov 2020 at 15:02, Nirmoy wrote: > > Tested-by: Nirmoy Das > Tested on commit 96fb3cbef165db97c999a02efe2287ba4b8c1ceb (HEAD, > drm-misc/drm-misc-next) > > > > O

[Bug 210683] Nasty amdgpu powersave regression Navi14

2020-12-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210683 siyia (eutychio...@gmail.com) changed: What|Removed |Added Summary|Nasty gpu powersave |Nasty amdgpu powersave

Re: [PATCH v4 07/16] drm/dp_helper: Add helpers to configure PCONs RGB-YCbCr Conversion

2020-12-14 Thread Nautiyal, Ankit K
Hi Uma Shankar, Thanks for the comments and suggestions. Please find my response inline. On 12/13/2020 12:40 PM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Tuesday, December 8, 2020 1:22 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop

Re: [PATCH 3/9] drm: rcar-du: Drop unneeded encoder cleanup in error path

2020-12-14 Thread Laurent Pinchart
Hi Jacopo, On Mon, Dec 14, 2020 at 11:11:08AM +0100, Jacopo Mondi wrote: > On Sat, Dec 05, 2020 at 12:01:33AM +0200, Laurent Pinchart wrote: > > The encoder->name field can never be non-null in the error path, as that > > can only be possible after a successful call to > > drm_simple_encoder_init(

[Bug 210683] Nasty amdgpu powersave regression Navi14

2020-12-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210683 --- Comment #1 from siyia (eutychio...@gmail.com) --- Just tested kernel 5.10 stable and idle powersave is still broken on the gpu compared to kernel 5.9 -- You are receiving this mail because: You are watching the assignee of the bug. _

Re: [PATCH v8 19/19] drm/i915/hdcp: Enable HDCP 2.2 MST support

2020-12-14 Thread Ramalingam C
On 2020-12-11 at 19:12:44 +0530, Anshuman Gupta wrote: > Enable HDCP 2.2 MST support till Gen12. > > Cc: Ramalingam C Reviewed-by: Ramalingam C > Tested-by: Karthik B S > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- > 1 file changed, 1 insertion(+)

Re: [PATCH v4 15/16] drm/i915: Let PCON convert from RGB to YUV if it can

2020-12-14 Thread Nautiyal, Ankit K
On 12/13/2020 12:53 PM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Tuesday, December 8, 2020 1:22 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; airl...@linux.ie; jani.nik...@linux.intel.com; ville.syrj...@linux.in

Re: [PATCH 5/9] drm: rcar-du: Use DRM-managed allocation for encoders

2020-12-14 Thread Laurent Pinchart
Hi Jacopo, On Mon, Dec 14, 2020 at 11:37:50AM +0100, Jacopo Mondi wrote: > On Sat, Dec 05, 2020 at 12:01:35AM +0200, Laurent Pinchart wrote: > > devm_kzalloc() is the wrong API to allocate encoders, as the lifetime of > > the encoders is tied to the DRM device, not the device to driver > > binding

Re: [PATCH 8/9] drm: rcar-du: Skip encoder allocation for LVDS1 in dual-link mode

2020-12-14 Thread Laurent Pinchart
Hi Jacopo, On Mon, Dec 14, 2020 at 12:04:49PM +0100, Jacopo Mondi wrote: > On Sat, Dec 05, 2020 at 12:01:38AM +0200, Laurent Pinchart wrote: > > The rcar-du driver skips registration of the encoder for the LVDS1 > > output when LVDS is used in dual-link mode, as the LVDS0 and LVDS1 links > > are b

Re: [PATCH v8 17/19] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks

2020-12-14 Thread Ramalingam C
On 2020-12-11 at 19:12:42 +0530, Anshuman Gupta wrote: > Add support for HDCP 2.2 DP MST shim callback. > This adds existing DP HDCP shim callback for Link Authentication > and Encryption and HDCP 2.2 stream encryption > callback. > > v2: > - Added a WARN_ON() instead of drm_err. [Uma] > - Cosmeti

Re: [PATCH v8 18/19] drm/i915/hdcp: Configure HDCP2.2 MST steram encryption status

2020-12-14 Thread Ramalingam C
On 2020-12-11 at 19:12:43 +0530, Anshuman Gupta wrote: > Authenticate and enable port encryption only once for > an active HDCP 2.2 session, once port is authenticated > and encrypted enable encryption for each stream that > requires encryption on this port. > > Similarly disable the stream encryp

Re: [PATCH] drm/amdgpu: fix check oder in amdgpu_bo_move

2020-12-14 Thread Daniel Vetter
Christian, can you pls push this to drm-misc-next-fixes? Adding Thomas as fyi so the pull goes out. -Daniel On Mon, Dec 14, 2020 at 2:12 PM Mike Lothian wrote: > > Tested-by: Mike Lothian > > Fixes https://gitlab.freedesktop.org/drm/amd/-/issues/1405 > > Can we make sure this gets into rc1? > >

[Bug 210683] Nasty amdgpu powersave regression Navi14

2020-12-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210683 --- Comment #2 from siyia (eutychio...@gmail.com) --- vddgfx also plays between 6.00mv-700mv compared to a steady 6.00 mv in kernel 5.9 at idle -- You are receiving this mail because: You are watching the assignee of the bug. ___

[Bug 210683] Nasty amdgpu powersave regression Navi14

2020-12-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210683 siyia (eutychio...@gmail.com) changed: What|Removed |Added Kernel Version|5.10-rc7|5.10 -- You are receivin

  1   2   3   >