Re: [PATCH] drm/amdgpu/display: remove trailing semicolon in macro definition

2020-11-30 Thread Christian König
Am 27.11.20 um 17:26 schrieb t...@redhat.com: From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/

[PATCH v1 0/3] drm/mipi-dbi: Type B bus support, drm/tiny: MRB2801

2020-11-30 Thread mdurnev
From: Mikhail Durnev Hi All, This patch series is aiming at extending the mipi-dbi bus driver to support Intel 8080 type parallel bus (Type B) over GPIO and adding a new driver for ILI9341 display panels with 8- or 16-bit parallel interface. It was tested with the MRB2801 display module [1] tha

[PATCH v3 6/9] misc: xilinx-ai-engine: add request and release tiles

2020-11-30 Thread Wendy Liang
Add request/release and related clock gating functions to AI engine driver: * scanning when the partition is being requested to know which tiles are in use. * check if a tile is gated or not * tiles requesting and releasing ioctl so that user application can enable/disable tiles at runtime. Si

[PATCH v3 9/9] misc: xilinx-ai-engine: Add support for servicing error interrupts

2020-11-30 Thread Wendy Liang
From: Nishad Saraf AI engine errors events can be routed to generate interrupt. The errors events routing will be done during AI engine configuration. At runtime, Linux kernel AI engine driver monitors the interrupt and backtracks errors events. As error events from 400 AIE tiles and 50 shim tile

[PATCH v3 5/9] misc: xilinx-ai-engine: add setting shim dma bd operation

2020-11-30 Thread Wendy Liang
Add operation to set SHIM DMA buffer descriptor. The following operations are added to set the buffer descriptors: * attach DMA buffer which enables AI engine device to access the DMA buffer memory * detach DMA buffer which disables AI engine device to access the DMA buffer memory * set DMA bu

[PATCH v1 1/3] drm/mipi-dbi: Add support for Type B

2020-11-30 Thread mdurnev
From: Mikhail Durnev Intel 8080 type (Type B) parallel bus over GPIO. The parallel bus is implemented partially. It supports only write operations from the host to the display. Read operations would require switching GPIO mode between input and output back and forth. But this implementation is v

[PATCH v3 1/9] dt-binding: soc: xilinx: ai-engine: Add AI engine binding

2020-11-30 Thread Wendy Liang
Xilinx AI engine array can be partitioned statically for different applications. In the device tree, there will be device node for the AI engine device, and device nodes for the statically configured AI engine partitions. Each of the statically configured partition has a partition ID in the system.

[PATCH v1 3/3] dt-bindings: panel: Add bindings for MRB2801

2020-11-30 Thread mdurnev
From: Mikhail Durnev Add binding for Ronbo MRB2801 display module. This binding is for display panels using an Ilitek ILI9341 controller in parallel mode. Signed-off-by: Mikhail Durnev --- .../devicetree/bindings/display/ronbo,mrb2801.txt | 42 ++ 1 file changed, 42 inser

[PATCH] drm/gma500: Fix error return code in psb_driver_load()

2020-11-30 Thread Jialin Zhang
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 5c49fd3aa0ab ("gma500: Add the core DRM files and headers") Reported-by: Hulk Robot Signed-off-by: Jialin Zhang --- drivers/gpu/drm/gma500/psb_drv.c | 2 ++ 1 file changed,

[PATCH v3 0/9] Xilinx AI engine kernel driver

2020-11-30 Thread Wendy Liang
AI engine is the acceleration engine provided by Xilinx. These engines provide high compute density for vector-based algorithms, and flexible custom compute and data movement. It has core tiles for compute and shim tiles to interface the FPGA fabric. You can check the AI engine architecture docume

[PATCH v3 8/9] firmware: xilinx: Add IOCTL support for AIE ISR Clear

2020-11-30 Thread Wendy Liang
From: Izhar Ameer Shaikh Latching of AIE NPI Interrupts is present in Versal ES1 Silicon Rev, however it has been removed from ES2 rev. As a result on ES1, in order to use the interrupt, a client needs to request PMC to clear/ack the interrupt. Provide an EEMI IOCTL to serve the same purpose. No

[PATCH v3 3/9] misc: xilinx-ai-engine: Implement AI engine cleanup sequence

2020-11-30 Thread Wendy Liang
When AI engine partition is released, that is if no one is using the AI engine partition, by default, it will cleanup the partition by doing the following: * reset the columns * reset the SHIMs * clear data and program memory * gate all the tiles If user doesn't want the partition is reset when th

[PATCH v3 7/9] misc: xilinx-ai-engine: Add support to request device management services

2020-11-30 Thread Wendy Liang
From: Nishad Saraf Platform management services like device control, resets, power management, etc. are provided by Platform, Loader and Manager(PLM) through firmware driver APIs. For requesting some of these services, this change reads AI Engine platform management node ID from DT node. Some oth

[PATCH v3 2/9] misc: Add Xilinx AI engine device driver

2020-11-30 Thread Wendy Liang
Create AI engine device/partition hierarchical structure. Each AI engine device can have multiple logical partitions(groups of AI engine tiles). Each partition is column based and has its own node ID in the system. AI engine device driver manages its partitions. Applications can access AI engine

[PATCH v1 2/3] drm/tiny: Add driver for ili9341 with parallel bus

2020-11-30 Thread mdurnev
From: Mikhail Durnev MRB2801 display module [1] is an example of ILI9341 display that connects to Intel 8080 parallel bus. Its connector is compatible with the ALIENTEK STM32 development board. It can be used with the drm/mipi-dbi bus driver if the bus is emulated with GPIO. [1] http://www.lcdw

[PATCH v3 4/9] misc: xilinx-ai-engine: expose AI engine tile memories to userspace

2020-11-30 Thread Wendy Liang
There is no concern to have userspace to directly access AI engine program and data memories. It will be much faster to directly copy data to and from these memories from userspace. We choose to use DMA buf for the data and program memory because of the DMA buf features. DMA buf can share the DMA

Re: [PATCH v10 00/19] Introduce memory interconnect for NVIDIA Tegra SoCs

2020-11-30 Thread Chanwoo Choi
Hi Dmitry, The v5.10-rc6 was released from linus git tree. Generally, I will send the pull-quest about devfreq to linux-pm.git maintainer after releasing the v5.1-rc7 for the integration test on linux-pm.git. The icc patches in this patch have not yet merged. If these patches are not merged befor

Re: [PATCH v10 00/19] Introduce memory interconnect for NVIDIA Tegra SoCs

2020-11-30 Thread Krzysztof Kozlowski
On Mon, Nov 30, 2020 at 05:44:39PM +0900, Chanwoo Choi wrote: > Hi Dmitry, > > The v5.10-rc6 was released from linus git tree. > Generally, I will send the pull-quest about devfreq to linux-pm.git maintainer > after releasing the v5.1-rc7 for the integration test on linux-pm.git. > > The icc patc

Re: [PATCH v10 00/19] Introduce memory interconnect for NVIDIA Tegra SoCs

2020-11-30 Thread Chanwoo Choi
On 11/30/20 5:36 PM, Krzysztof Kozlowski wrote: > On Mon, Nov 30, 2020 at 05:44:39PM +0900, Chanwoo Choi wrote: >> Hi Dmitry, >> >> The v5.10-rc6 was released from linus git tree. >> Generally, I will send the pull-quest about devfreq to linux-pm.git >> maintainer >> after releasing the v5.1-rc7 f

Re: [PATCH v2 04/28] video: fbdev: aty: Delete unused variable in radeon_monitor

2020-11-30 Thread Thomas Zimmermann
Am 28.11.20 um 23:40 schrieb Sam Ravnborg: Fix warning about variable that is asssigned a value but never used. The variable was indeed never used so delete it. Keep the call to radeon_probe_i2c_connector() as it may have side-effects. It is unlikely but I could not verify that is was safe to

Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon

2020-11-30 Thread Peilin Ye
On Mon, Nov 30, 2020 at 08:56:45AM +0100, Sam Ravnborg wrote: > Please just keep up the good work cleaning up fbcon and related stuff. > This is an area that needs some love and care and there is work for many > long nights yet to do. Thanks! I will see what I can do, Peilin Ye _

Re: [PATCH v2 05/28] video: fbdev: aty: Fix set but not used warnings

2020-11-30 Thread Thomas Zimmermann
Am 28.11.20 um 23:40 schrieb Sam Ravnborg: Fix W=1 warnings about variables assigned but never used. - Drop variables that was set but never used s/that was/that were - Make variable definition conditional om ATARI s/om/on v2: - Fix m68k build error (kernel test robot) - Improve

Re: [PATCH v1 2/3] drm/tiny: Add driver for ili9341 with parallel bus

2020-11-30 Thread kernel test robot
ny-MRB2801/20201130-142812 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 09162bc32c880a791c6c0668ce0745cf7958f576 config: arm64-randconfig-r024-20201130 (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): w

Re: [PATCH v2 06/28] video: fbdev: aty: Fix set but not used warnings in mach64_ct

2020-11-30 Thread Thomas Zimmermann
Am 28.11.20 um 23:40 schrieb Sam Ravnborg: Fix W=1 warnings about variables assigned but never used. - One variable is only used when CONFIG_FB_ATY_GENERIC_LCD is defined Fix so variable is only defined with CONFIG_FB_ATY_GENERIC_LCD - Several variables was only assigned by a call to aty_ld_

Re: [PATCH v2 07/28] video: fbdev: sis: Fix defined but not used warnings

2020-11-30 Thread Thomas Zimmermann
Am 28.11.20 um 23:40 schrieb Sam Ravnborg: init.h define static symbols, so should only be included s/define/defines s/so should/so it should once. Drop the include from sis.h as it is not needed. This fixes a lot of warnings seen with a W=1 build. v2: - Update subject (Lee) Signed-off

[PATCH] drm: document that user-space should force-probe connectors

2020-11-30 Thread Simon Ser
It seems like we can't have nice things, so let's just document the disappointing behaviour instead. Signed-off-by: Simon Ser Fixes: 2ac5ef3b2362 ("drm: document drm_mode_get_connector") Cc: Daniel Vetter Cc: Pekka Paalanen Cc: Ville Syrjala --- include/uapi/drm/drm_mode.h | 11 +++ 1

Re: [PATCH v2 08/28] video: fbdev: sis: Fix defined but not used warning of SiS_TVDelay

2020-11-30 Thread Thomas Zimmermann
Am 28.11.20 um 23:40 schrieb Sam Ravnborg: Fix W=1 warning by commenting unused SiS_TVDelay* variables. The SiS_TVDelay* variables seem to contain some magic numbers so looks like data worth keeping around but not as code we build. I would remove it. sisfb is broken beyond repair and no one'

Re: [PATCH v2 09/28] video: fbdev: sis: Fix set but not used warnings in init.c

2020-11-30 Thread Thomas Zimmermann
Am 28.11.20 um 23:40 schrieb Sam Ravnborg: Fix set bit not used warnings by removing the code the assign the s/bit/but Actually, I think the correct way of writing this would be with dashes: Fix set-but-not-used warnings In the current sentence, you're setting a 'but not used variable.'

Re: [PATCH v3 1/6] drm: bridge: Propagate the bus flags from bridge->timings

2020-11-30 Thread Laurent Pinchart
Hi Nikhil, Thank you for the patch. On Thu, Nov 19, 2020 at 09:31:29PM +0530, Nikhil Devshatwar wrote: > bus_flags can be specified by a bridge in the timings. > If the bridge provides it, Override the bus_flags when propagating > from next bridge. > > Signed-off-by: Nikhil Devshatwar > Reviewe

Re: [PATCH v3 2/6] drm/bridge: tfp410: Support format negotiation hooks

2020-11-30 Thread Laurent Pinchart
Hi Nikhil, Thank you for the patch. On Thu, Nov 19, 2020 at 09:31:30PM +0530, Nikhil Devshatwar wrote: > With new connector model, tfp410 will not create the connector and > SoC driver will rely on format negotiation to setup the encoder format. > > Support format negotiations hooks in the drm_b

Re: [PATCH v3 4/6] drm/tidss: Set bus_format correctly from bridge/connector

2020-11-30 Thread Laurent Pinchart
Hi Nikhil, Thank you for the patch. On Thu, Nov 19, 2020 at 09:31:32PM +0530, Nikhil Devshatwar wrote: > Remove the old code to iterate over the bridge chain, as this is > already done by the framework. > The bridge state should have the negotiated bus format and flags. > Use these from the bridg

Re: [PATCH v3 4/6] drm/tidss: Set bus_format correctly from bridge/connector

2020-11-30 Thread Laurent Pinchart
Hi Nikhil, On Mon, Nov 30, 2020 at 12:05:03PM +0530, Nikhil Devshatwar wrote: > On 14:51-20201125, Tomi Valkeinen wrote: > > On 19/11/2020 18:01, Nikhil Devshatwar wrote: > > > Remove the old code to iterate over the bridge chain, as this is > > > already done by the framework. > > > The bridge st

Re: [PATCH v3 1/6] drm: bridge: Propagate the bus flags from bridge->timings

2020-11-30 Thread Laurent Pinchart
Hi Tomi, On Mon, Nov 30, 2020 at 11:46:31AM +0200, Tomi Valkeinen wrote: > On 30/11/2020 11:36, Laurent Pinchart wrote: > > On Thu, Nov 19, 2020 at 09:31:29PM +0530, Nikhil Devshatwar wrote: > >> bus_flags can be specified by a bridge in the timings. > >> If the bridge provides it, Override the bu

Re: [PATCH v4 55/80] drm/panel: panel-dsi-cm: use MIPI_DCS_GET_ERROR_COUNT_ON_DSI

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:13PM +0200, Tomi Valkeinen wrote: > Use the common MIPI_DCS_GET_ERROR_COUNT_ON_DSI define instead of > driver's own. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/panel/panel-dsi-cm.c |

Re: [PATCH v4 56/80] drm/panel: panel-dsi-cm: cleanup tear enable

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:14PM +0200, Tomi Valkeinen wrote: > Simplify the code by moving code from _dsicm_enable_te() into > dsicm_power_on(). > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/panel/panel-dsi-cm.c

Re: [PATCH v4 57/80] ARM: dts: omap5: add address-cells & size-cells to dsi

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:15PM +0200, Tomi Valkeinen wrote: > Add address-cells & size-cells to DSI nodes so that board files do not > need to define them. How about adding ports too, while at it ? It would also be nice to convert the DT bindings to YAML :-

Re: [PATCH v4 58/80] drm/omap: pll: fix iteration loop check

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:16PM +0200, Tomi Valkeinen wrote: > If the PLL calc function is given bad parameters, n_start/m_start may be > higher than n_stop/m_stop, which leads to the loops iterating through > the whole u32 number space. > > Fix this by faili

Re: [PATCH v4 59/80] drm/omap: dsi: set trans_mode according to client mode_flags

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:17PM +0200, Tomi Valkeinen wrote: > The DSI host driver currently ignores the video mode flags in > client->mode_flags. Add the code to take the transfer mode from client's > mode_flags. > > Signed-off-by: Tomi Valkeinen Reviewed-

Re: [PATCH v4 60/80] drm/panel: panel-dsi-cm: set column & page at setup

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:18PM +0200, Tomi Valkeinen wrote: > Set the column & page address once during setup, instead of relying the > DSI host driver to set those. > > Signed-off-by: Tomi Valkeinen With Sam's comments addressed, Reviewed-by: Laurent Pin

Re: [PATCH v4 61/80] drm/omap: dsi: send nop instead of page & column

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:19PM +0200, Tomi Valkeinen wrote: > The OMAP DSI command mode panel driver used to send page & column > address before each frame update, and this code was moved into the DSI > host driver when converting it to the DRM bridge model.

Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2020-11-30 Thread Jani Nikula
On Fri, 27 Nov 2020, Daniel Vetter wrote: > On Fri, Nov 27, 2020 at 04:31:00PM +0200, Imre Deak wrote: >> Hi Daniel, Jani, >> >> is it ok to merge this patch along with 2/2 via the i915 tree? > > Ack from mesa (userspace in general, but mesa is kinda mandatory) is > missing I think. With that > >

Re: [PATCH v4 62/80] drm/omap: dsi: simplify VC handling

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:20PM +0200, Tomi Valkeinen wrote: > The VC handling has gotten quite tangled up. As the first step to clean > it up, lets define that we only support a single DSI peripheral (which > was really already the case), and we always use VC

Re: [PATCH RESEND v3 1/2] dt-bindings: dp-connector: add binding for DisplayPort connector

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 09:11:54AM +0200, Tomi Valkeinen wrote: > Add binding for DisplayPort connector. A few notes: > > * Similar to hdmi-connector, it has hpd-gpios as an optional property, > as the HPD could also be handled by, e.g., the DP bridge. > > *

Re: [PATCH v2 10/28] video: fbdev: sis: Fix set but not used warnings in sis_main

2020-11-30 Thread Thomas Zimmermann
Am 28.11.20 um 23:40 schrieb Sam Ravnborg: Fix warnings by dropping unused variable and the unused assignments. v2: - Update subject (Lee) Signed-off-by: Sam Ravnborg Cc: Thomas Winischhofer Cc: Lee Jones Acked-by: Thomas Zimmermann --- drivers/video/fbdev/sis/sis_main.c | 9

Re: [RFC PATCH 096/162] drm/i915: setup the LMEM region

2020-11-30 Thread Jani Nikula
On Fri, 27 Nov 2020, Matthew Auld wrote: > + /* Enables Local Memory functionality in GAM */ > + I915_WRITE(GEN12_LMEM_CFG_ADDR, I915_READ(GEN12_LMEM_CFG_ADDR) | > LMEM_ENABLE); Please use intel_uncore_read/write and intel_de_read/write throughout the series. We don't want any new users

Re: [Intel-gfx] [RFC PATCH 119/162] drm/i915/dg1: Read OPROM via SPI controller

2020-11-30 Thread Jani Nikula
On Fri, 27 Nov 2020, Matthew Auld wrote: > + DRM_DEBUG_KMS("Found valid VBT in SPI flash\n"); Please use drm_dbg_kms() and friends throughout the series. We don't want new users of DRM_DEBUG* in the driver. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___

Re: [PATCH RESEND v3 2/2] drm/bridge: display-connector: add DP support

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 09:11:55AM +0200, Tomi Valkeinen wrote: > Add DP support to display-connector driver. The driver will support HPD > via a GPIO and DP PWR. > > DP PWR will be enabled at probe, which is not optimal, but I'm not sure > what would be a good

Re: [PATCH] drm/vkms: detect modes during output initialization

2020-11-30 Thread Simon Ser
On Monday, November 30, 2020 2:03 AM, Leandro Ribeiro wrote: > In userspace we can use drmGetConnector() or drmGetConnectorCurrent() in > order to retrieve connector information. The difference between both is > that the former retrieves the complete set of modes and encoders > associated with t

Re: [Intel-gfx] [RFC PATCH 120/162] drm/i915/oprom: Basic sanitization

2020-11-30 Thread Jani Nikula
On Fri, 27 Nov 2020, Matthew Auld wrote: > From: Anshuman Gupta > > Sanitize OPROM header, CPD signature and OPROM PCI version. > OPROM_HEADER, EXPANSION_ROM_HEADER and OPROM_MEU_BLOB structures > and PCI struct offsets are provided by GSC counterparts. > These are yet to be Documented in B.Spec.

Re: [RESEND PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder

2020-11-30 Thread Vinod Koul
On 17-11-20, 07:14, Chun-Kuang Hu wrote: > mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's > more suitable to place a phy driver into phy driver folder, so move > mtk_mipi_dsi_phy driver into phy driver folder. Acked-By: Vinod Koul I am thinking this would go thru drm-t

Re: [PATCH v3 4/6] drm/tidss: Set bus_format correctly from bridge/connector

2020-11-30 Thread Nikhil Devshatwar
On 14:51-20201125, Tomi Valkeinen wrote: > Hi Nikhil, > > On 19/11/2020 18:01, Nikhil Devshatwar wrote: > > Remove the old code to iterate over the bridge chain, as this is > > already done by the framework. > > The bridge state should have the negotiated bus format and flags. > > Use these from t

Re: [Intel-gfx] [RFC PATCH 157/162] drm/i915: Improve accuracy of eviction stats

2020-11-30 Thread Tvrtko Ursulin
On 27/11/2020 14:40, Chris Wilson wrote: Quoting Matthew Auld (2020-11-27 12:07:13) From: Tvrtko Ursulin Current code uses jiffie time to do the accounting and then does: diff = jiffies - start; msec = diff * 1000 / HZ; ... atomic_long_add(msec, &i915->time_swap_out_ms); If we

Re: [PATCH v2 1/5] drm: add legacy support for using degamma for gamma

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 03, 2020 at 10:03:06AM +0200, Tomi Valkeinen wrote: > We currently have drm_atomic_helper_legacy_gamma_set() helper which can > be used to handle legacy gamma-set ioctl. > drm_atomic_helper_legacy_gamma_set() sets GAMMA_LUT, and clears > CTM and DEGAM

Re: [PATCH v2 2/5] drm/omap: use degamma property for gamma table

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 03, 2020 at 10:03:07AM +0200, Tomi Valkeinen wrote: > omapdrm supports gamma via GAMMA_LUT property. However, the HW we have > is: > > gamma -> ctm -> out > > instead of what the model DRM framework uses: > > ctm -> gamma -> out > > As the followi

Re: [PATCH v2 3/5] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2020-11-30 Thread Laurent Pinchart
Hi Tomi and Jyri, Thank you for the patch. On Tue, Nov 03, 2020 at 10:03:08AM +0200, Tomi Valkeinen wrote: > From: Jyri Sarha > > Implement CTM color management property for OMAP CRTC using DSS > overlay manager's Color Phase Rotation matrix. The CPR matrix does not > exactly match the CTM prop

Re: [PATCH v2 4/5] drm/omap: rearrange includes in omapdss.h

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 03, 2020 at 10:03:09AM +0200, Tomi Valkeinen wrote: > Drop "uapi/" and rearrange alphabetically. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/dss/omapdss.h | 8 > 1 file changed, 4 inse

Re: [PATCH v2 5/5] drm/omap: Enable COLOR_ENCODING and COLOR_RANGE properties for planes

2020-11-30 Thread Laurent Pinchart
Hi Tomi and Jyri, Thank you for the patch. On Tue, Nov 03, 2020 at 10:03:10AM +0200, Tomi Valkeinen wrote: > From: Jyri Sarha > > Adds support for COLOR_ENCODING and COLOR_RANGE properties to > omap_plane.c and dispc.c. The supported encodings and ranges are > presets are: > > For COLOR_ENCODI

Re: [Intel-gfx] [RFC PATCH 118/162] drm/i915/dg1: Reserve first 1MB of local memory

2020-11-30 Thread Matthew Auld
On 27/11/2020 13:52, Chris Wilson wrote: Quoting Matthew Auld (2020-11-27 12:06:34) From: Imre Deak On DG1 A0/B0 steppings the first 1MB of local memory must be reserved. One reason for this is that the 0xA-0xB range is not accessible by the display, probably since this region is redir

Re: [PATCH] drm/vkms: detect modes during output initialization

2020-11-30 Thread Pekka Paalanen
On Mon, 30 Nov 2020 10:23:04 + Simon Ser wrote: > On Monday, November 30, 2020 2:03 AM, Leandro Ribeiro > wrote: > > > In userspace we can use drmGetConnector() or drmGetConnectorCurrent() in > > order to retrieve connector information. The difference between both is > > that the former re

Re: [PATCH] drm/vkms: detect modes during output initialization

2020-11-30 Thread Simon Ser
On Monday, November 30, 2020 12:13 PM, Pekka Paalanen wrote: > where is the discussion? https://dri.freedesktop.org/~cbrill/dri-log/?channel=intel-gfx&date=2020-11-26 > Please record the justitication for that patch in its commit message. > "Can't" does not explain anything. Yeah, sorry about

Re: [RFC PATCH 107/162] drm/i915: setup GPU device lmem region

2020-11-30 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:23) > From: CQ Tang > > The lmem region needs to remove the stolen part. > > Cc: Joonas Lahtinen > Cc: Matthew Auld > Cc: Abdiel Janulgue > Cc: Chris P Wilson > Cc: Balestrieri, Francesco > Cc: Niranjana Vishwanathapura > Cc: Venkata S Dhanalakota >

Re: [Intel-gfx] [RFC PATCH 118/162] drm/i915/dg1: Reserve first 1MB of local memory

2020-11-30 Thread Chris Wilson
Quoting Matthew Auld (2020-11-30 11:09:57) > On 27/11/2020 13:52, Chris Wilson wrote: > > Quoting Matthew Auld (2020-11-27 12:06:34) > >> From: Imre Deak > >> > >> On DG1 A0/B0 steppings the first 1MB of local memory must be reserved. > >> One reason for this is that the 0xA-0xB range is n

Re: [PATCH] drm/vkms: detect modes during output initialization

2020-11-30 Thread Pekka Paalanen
On Mon, 30 Nov 2020 11:16:56 + Simon Ser wrote: > On Monday, November 30, 2020 12:13 PM, Pekka Paalanen > wrote: > > > where is the discussion? > > https://dri.freedesktop.org/~cbrill/dri-log/?channel=intel-gfx&date=2020-11-26 Thanks, I read that. > > Please record the justitication f

[GIT PULL] etnaviv-next for 5.11

2020-11-30 Thread Lucas Stach
Hi Dave, hi Daniel, please pull the following etnaviv updates for 5.11. Again, nothing big this time. Mostly a new performance counter from Christian, some more lockdep annotations from Guido and removal of functionality that duplicates driver core from Robin. Regards, Lucas The following cha

[PATCH 0/8] drm/vram-helper: Lock GEM BOs while they are mapped

2020-11-30 Thread Thomas Zimmermann
GEM VRAM helpers used to pin the BO in their implementation of vmap, so that they could not be relocated. In a recent discussion, [1] it became clear that this is incorrect and that vmap should rather repend on the reservation lock to prevent relocation. This patchset addresses the issue. Besides t

[PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-11-30 Thread Thomas Zimmermann
Mapping a GEM object's buffer into kernel address space prevents the buffer from being evicted from VRAM, which in turn may result in out-of-memory errors. It's therefore required to only vmap GEM BOs for short periods of time; unless the GEM implementation provides additional guarantees. Signed-o

[PATCH 2/8] drm/ast: Only map cursor BOs during updates

2020-11-30 Thread Thomas Zimmermann
The HW cursor's BO used to be mapped permanently into the kernel's address space. GEM's vmap operation will be protected by locks, and we don't want to lock the BO's for an undefinate period of time. Change the cursor code to map the HW BOs only during updates. The vmap operation in VRAM helpers i

[PATCH 4/8] drm/ast: Use drm_gem_vram_vmap_unlocked() in ast_cursor_show()

2020-11-30 Thread Thomas Zimmermann
This change avoids to pin the source BO when showing the cursor, and instead acquires the BO's reservation lock. Prevents concurrent access during the buffer update. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_cursor.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH 6/8] drm/vram-helper: Remove pinning and locking from drm_gem_vram_vmap()

2020-11-30 Thread Thomas Zimmermann
BO pinning was never meant to be part of a GEM object's vmap operation. Remove it from the related code in VRAM helpers. Pinning requires a locking operation in the vmap code, which we also remove. Callers of drm_gem_vram_vmap()/_vunmap() are now responsible for acquiring the GEM object's reservati

[PATCH 7/8] drm/vram-helper: Remove vmap reference counting

2020-11-30 Thread Thomas Zimmermann
Overlapping or nested mappings of the same BO are not allowed by the semantics of the GEM vmap/vunmap operations. Concurent access to the GEM object is prevented by reservation locks. So we don't need the reference counter in the GEM VRAM object. Remove it. Signed-off-by: Thomas Zimmermann ---

[PATCH 8/8] drm/vram-helper: Simplify vmap implementation

2020-11-30 Thread Thomas Zimmermann
After removing the pinning operations, the vmap/vunmap code as been reduced to what used to be an internal helper. Inline the helper to simplify the implementation. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_vram_helper.c | 57 +++ 1 file changed, 23 ins

[PATCH 5/8] drm/vboxvideo: Use drm_gem_vram_vmap_unlocked() in cursor update

2020-11-30 Thread Thomas Zimmermann
This change avoids to pin the source BO and instead acquires the BO's reservations lock. Prevents concurrent access during the buffer update. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vboxvideo/vbox_mode.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/driv

[PATCH 3/8] drm/vram-helper: Provide drm_gem_vram_vmap_unlocked()

2020-11-30 Thread Thomas Zimmermann
The new interface drm_gem_vram_vmap_unlocked() acquires a GEM object's reservation lock and vmaps the buffer into the kernel address space. In contract to the existing vmap implementation, it does not pin the buffer. The function will be helpful for code that needs to vmap and vunmap single GEM obj

Re: [PATCH v2 11/28] video: fbdev: via: Fix set but not used warning for mode_crt_table

2020-11-30 Thread Thomas Zimmermann
Am 28.11.20 um 23:40 schrieb Sam Ravnborg: Fix warning by deleting the variable. The function call viafb_get_best_mode() were verified to have no side-effects, s/were/was and thus could be dropped too. v2: - Update subject (Lee) Signed-off-by: Sam Ravnborg Cc: Florian Tobias Schandina

Re: [PATCH v2 12/28] video: fbdev: tdfx: Fix set but not used warning in att_outb()

2020-11-30 Thread Thomas Zimmermann
Am 28.11.20 um 23:40 schrieb Sam Ravnborg: The tmp variable were assigned but the result was never used, s/were/was so delete the tmp variable. v2: - Update subject (Lee) Signed-off-by: Sam Ravnborg Cc: "Gustavo A. R. Silva" Cc: Sam Ravnborg Cc: Jani Nikula Cc: Daniel Vetter Cc: A

Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings

2020-11-30 Thread Thomas Zimmermann
Am 28.11.20 um 23:40 schrieb Sam Ravnborg: Fix W=1 warnings: - Fix kernel-doc - Drop unused variables/code v2: - Updated subject (Lee) Signed-off-by: Sam Ravnborg Cc: Antonino Daplas Cc: linux-fb...@vger.kernel.org Cc: Lee Jones --- drivers/video/fbdev/riva/fbdev.c | 9 -

Re: [PATCH v2 14/28] video: fbdev: pm2fb: Fix kernel-doc warnings

2020-11-30 Thread Thomas Zimmermann
Am 28.11.20 um 23:41 schrieb Sam Ravnborg: Fixed a few kernel-doc issues to fix the warnings. v2: - Updated subject (Lee) Signed-off-by: Sam Ravnborg Cc: Sam Ravnborg Cc: "Gustavo A. R. Silva" Cc: Randy Dunlap Cc: Arnd Bergmann Cc: Bartlomiej Zolnierkiewicz Cc: Jani Nikula Cc: Lee J

Re: [PATCH v2 15/28] video: fbdev: neofb: Fix set but not used warning for CursorMem

2020-11-30 Thread Thomas Zimmermann
Am 28.11.20 um 23:41 schrieb Sam Ravnborg: Fix W=1 warnings by removing unused code v2: - Updated subject (Lee) Signed-off-by: Sam Ravnborg Cc: Bartlomiej Zolnierkiewicz Cc: Sam Ravnborg Cc: Andrew Morton Cc: Evgeny Novikov Cc: Jani Nikula Cc: Mike Rapoport Cc: Lee Jones Acked-by

Re: [PATCH] drm/vkms: detect modes during output initialization

2020-11-30 Thread Simon Ser
CC Daniel and Ville On Monday, November 30, 2020 12:24 PM, Pekka Paalanen wrote: > > > Please record the justitication for that patch in its commit message. > > > "Can't" does not explain anything. > > > > Yeah, sorry about that. I'm just annoyed by all of this get_connector > > uAPI, so I don'

Re: [RFC PATCH 131/162] drm/i915/dg1: Add enable_eviction modparam

2020-11-30 Thread Jani Nikula
On Fri, 27 Nov 2020, Matthew Auld wrote: > From: CQ Tang > > enable_eviction is used to tune if eviction is enabled (default) or not. > > Signed-off-by: Sudeep Dutt > Signed-off-by: CQ Tang > --- > drivers/gpu/drm/i915/gem/i915_gem_object.c | 1 + > drivers/gpu/drm/i915/gem/i915_gem_region.c |

Re: [PATCH 0/8] drm/vram-helper: Lock GEM BOs while they are mapped

2020-11-30 Thread Christian König
Am 30.11.20 um 13:04 schrieb Thomas Zimmermann: GEM VRAM helpers used to pin the BO in their implementation of vmap, so that they could not be relocated. In a recent discussion, [1] it became clear that this is incorrect and that vmap should rather repend on the reservation lock to prevent reloca

Re: [PATCH 0/8] drm/vram-helper: Lock GEM BOs while they are mapped

2020-11-30 Thread Thomas Zimmermann
Hi Am 30.11.20 um 13:04 schrieb Thomas Zimmermann: GEM VRAM helpers used to pin the BO in their implementation of vmap, so that they could not be relocated. In a recent discussion, [1] it became [1] was supposed to point to the discussion at https://patchwork.freedesktop.org/patch/400054/?s

[PATCH] fbdev: Remove udlfb driver

2020-11-30 Thread Thomas Zimmermann
Udlfb has been superseded by DRM's udl. The DRM driver is better by any means and actively maintained. Remove udlfb. Signed-off-by: Thomas Zimmermann --- CREDITS |5 + Documentation/fb/index.rst |1 - Documentation/fb/udlfb.rst | 162 --- MAINTAINERS

Re: [PATCH v2 17/28] video: fbdev: tgafb: Fix kernel-doc and set but not used warnings

2020-11-30 Thread Thomas Zimmermann
Am 28.11.20 um 23:41 schrieb Sam Ravnborg: Fix W=1 warnings: - Fix kernel-doc - Drop unused code v2: - Updated subject (Lee) Signed-off-by: Sam Ravnborg Cc: Sam Ravnborg Cc: Jani Nikula Cc: Bartlomiej Zolnierkiewicz Cc: Daniel Vetter Cc: Arnd Bergmann Cc: Joe Perches Cc: Lee Jones

Re: [PATCH v2 18/28] video: fbdev: mx3fb: Fix kernel-doc, set but not used and string warnings

2020-11-30 Thread Thomas Zimmermann
Am 28.11.20 um 23:41 schrieb Sam Ravnborg: Fix W=1 warnings: - Fix kernel-doc - Drop unused code/variables - Use memcpy to copy a string without zero-termination strncpy() generates a warning v2: - Updated subject (Lee) Signed-off-by: Sam Ravnborg Cc: Sam Ravnborg Cc: Jani Nikula Cc:

Re: [PATCH] drm/omap: sdi: fix bridge enable/disable

2020-11-30 Thread Tomi Valkeinen
On 28/11/2020 19:45, Aaro Koskinen wrote: > Hi, > > On Fri, Nov 27, 2020 at 10:52:41AM +0200, Tomi Valkeinen wrote: >> When the SDI output was converted to DRM bridge, the atomic versions of >> enable and disable funcs were used. This was not intended, as that would >> require implementing other a

[PATCH v4 81/80] drm/omap: dsi: allow DSI commands to be sent early

2020-11-30 Thread Tomi Valkeinen
Panel drivers can send DSI commands in panel's prepare(), which happens before the bridge's enable() is called. The OMAP DSI driver currently only sets up the DSI interface at bridge's enable(), so prepare() cannot be used to send DSI commands. This patch fixes the issue by making it possible to e

Re: [PATCH v3 1/6] drm: bridge: Propagate the bus flags from bridge->timings

2020-11-30 Thread Tomi Valkeinen
On 30/11/2020 11:36, Laurent Pinchart wrote: > Hi Nikhil, > > Thank you for the patch. > > On Thu, Nov 19, 2020 at 09:31:29PM +0530, Nikhil Devshatwar wrote: >> bus_flags can be specified by a bridge in the timings. >> If the bridge provides it, Override the bus_flags when propagating >> from nex

Re: [PATCH v3 1/6] drm: bridge: Propagate the bus flags from bridge->timings

2020-11-30 Thread Tomi Valkeinen
On 30/11/2020 11:47, Laurent Pinchart wrote: >>> Hasn't Boris commented in his review of v1 that bus flags should be set >>> in atomic_check, even when they're static ? We're moving towards >>> removing timings->input_bus_flags, so this patch goes in the wrong >>> direction :-S >> >> We have atomi

Re: [PATCH v3 1/6] drm: bridge: Propagate the bus flags from bridge->timings

2020-11-30 Thread Tomi Valkeinen
On 30/11/2020 12:02, Tomi Valkeinen wrote: > On 30/11/2020 11:47, Laurent Pinchart wrote: > Hasn't Boris commented in his review of v1 that bus flags should be set in atomic_check, even when they're static ? We're moving towards removing timings->input_bus_flags, so this patch goes

Re: [PATCH v2 1/5] drm: add legacy support for using degamma for gamma

2020-11-30 Thread Daniel Vetter
On Mon, Nov 30, 2020 at 02:12:39PM +0200, Tomi Valkeinen wrote: > On 30/11/2020 12:38, Laurent Pinchart wrote: > > >> + * can be used when the driver exposes either only GAMMA_LUT or both > >> GAMMA_LUT > >> + * and DEGAMMA_LUT. > >> + */ > >> +int drm_atomic_helper_legacy_gamma_set(struct drm_cr

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-11-30 Thread Daniel Vetter
On Fri, Nov 27, 2020 at 11:04:55AM -0500, Andrey Grodzovsky wrote: > > On 11/27/20 9:59 AM, Daniel Vetter wrote: > > On Wed, Nov 25, 2020 at 02:34:44PM -0500, Andrey Grodzovsky wrote: > > > On 11/25/20 11:36 AM, Daniel Vetter wrote: > > > > On Wed, Nov 25, 2020 at 01:57:40PM +0100, Christian König

Re: [PATCH v2 5/5] drm/omap: Enable COLOR_ENCODING and COLOR_RANGE properties for planes

2020-11-30 Thread Laurent Pinchart
Hi Tomi, On Mon, Nov 30, 2020 at 01:53:25PM +0200, Tomi Valkeinen wrote: > On 30/11/2020 12:50, Laurent Pinchart wrote: > > On Tue, Nov 03, 2020 at 10:03:10AM +0200, Tomi Valkeinen wrote: > >> From: Jyri Sarha > >> > >> Adds support for COLOR_ENCODING and COLOR_RANGE properties to > >> omap_plane

Re: [PATCH v2 19/28] video: fbdev: sstfb: Updated logging to fix set but not used warnings

2020-11-30 Thread Thomas Zimmermann
Am 28.11.20 um 23:41 schrieb Sam Ravnborg: Fix set but not used warnings by introducing no_printk variants for the internal logging system for this driver. Fix a new warning that popped up now that logging was checked for correct printf format strings. A more invasive fix had been to replace

Re: [PATCH v7 17/17] mm: add mmu_notifier argument to follow_pfn

2020-11-30 Thread Daniel Vetter
So I guess kvm platforms that don't set KVM_ARCH_WANT_MMU_NOTIFIER exist, and at least on powerpc they're consistent with KVM_CAP_SYNC_MMU signalling that the guest pagetables stays in sync automatically with any updates. So for that case I guess we could use unsafe_follow_pfn. But on s390 this se

Re: [PATCH] fbdev: Remove udlfb driver

2020-11-30 Thread Mikulas Patocka
On Mon, 30 Nov 2020, Thomas Zimmermann wrote: > Udlfb has been superseded by DRM's udl. The DRM driver is better by > any means and actively maintained. Remove udlfb. Hi I am using udlfb and it's definitely better than the DRM driver. The DRM driver will crash the kernel if you unplug the de

Re: [PATCH] drm/gma500: Fix error return code in psb_driver_load()

2020-11-30 Thread Daniel Vetter
On Mon, Nov 30, 2020 at 10:02:16AM +0800, Jialin Zhang wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 5c49fd3aa0ab ("gma500: Add the core DRM files and headers") > Reported-by: Hulk Robot > Signed-off-by: Ji

Re: [PATCH 2/4] dt-bindings: display: Add ABT Y030XX067A panel bindings

2020-11-30 Thread Rob Herring
On Mon, Nov 2, 2020 at 3:19 AM Paul Cercueil wrote: > > > > Le dim. 1 nov. 2020 à 13:29, Sam Ravnborg a écrit : > > On Sun, Nov 01, 2020 at 09:31:48AM +, Paul Cercueil wrote: > >> The Asia Better Technology (ABT) Y030XX067A panel is a 3.0" 320x480 > >> 24-bit IPS LCD panel. Its particularit

Re: [PATCH v2 20/28] video: fbdev: nvidia: Fix set but not used warnings

2020-11-30 Thread Thomas Zimmermann
Hi Am 28.11.20 um 23:41 schrieb Sam Ravnborg: Fix warnings by deleting unused code. The register reads are kept as it is unknown if there are any hidden side-effects. v2: - Update subject (Lee) Signed-off-by: Sam Ravnborg Cc: Antonino Daplas Cc: linux-fb...@vger.kernel.org Cc: Lee Jones

Re: [PATCH v2 21/28] video: fbdev: tmiofb: Fix set but not used warnings

2020-11-30 Thread Thomas Zimmermann
Am 28.11.20 um 23:41 schrieb Sam Ravnborg: Fix W=1 warnings by avoiding local variables and use direct references. What's the bug here? v2: - Updated subject (Lee) Signed-off-by: Sam Ravnborg Cc: Daniel Vetter Cc: Sam Ravnborg Cc: Jani Nikula Cc: Lee Jones --- drivers/video/fbde

  1   2   3   >