Re: [PATCH v2 08/28] video: fbdev: sis: Fix defined but not used warning of SiS_TVDelay

[Thomas Zimmermann]

Am 28.11.20 um 23:40 schrieb Sam Ravnborg:

Fix W=1 warning by commenting unused SiS_TVDelay* variables.

The SiS_TVDelay* variables seem to contain some magic numbers
so looks like data worth keeping around but not as code we build.

Acked-by: Thomas Zimemrmann <tzimmerm...@suse.de>

I would remove it. sisfb is broken beyond repair and no one's going to try to use it anyway. In any case

v2:
   - Update subject (Lee)

Signed-off-by: Sam Ravnborg <s...@ravnborg.org>
Cc: Thomas Winischhofer <tho...@winischhofer.net>
Cc: Lee Jones <lee.jo...@linaro.org>
---
  drivers/video/fbdev/sis/oem310.h | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/video/fbdev/sis/oem310.h b/drivers/video/fbdev/sis/oem310.h
index 8fce56e4482c..ed28755715ce 100644
--- a/drivers/video/fbdev/sis/oem310.h
+++ b/drivers/video/fbdev/sis/oem310.h
@@ -200,6 +200,7 @@ static const unsigned char 
SiS310_TVDelayCompensation_651302LV[] =  /* M650, 651,
        0x33,0x33
  };

  static const unsigned char SiS_TVDelay661_301[] =                     /* 661, 
301 */
  {
        0x44,0x44,
@@ -219,6 +220,7 @@ static const unsigned char SiS_TVDelay661_301B[] =          
        /* 661, 301B et al */
        0x44,0x44,
        0x44,0x44
  };
+#endif

  {

+#if 0 /* Not used */ static const unsigned char SiS310_TVDelayCompensation_LVDS[] = /* LVDS */

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

OpenPGP_signature
Description: OpenPGP digital signature

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel