Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-24 Thread Miguel Ojeda
On Mon, Nov 23, 2020 at 4:58 PM James Bottomley wrote: > > Well, I used git. It says that as of today in Linus' tree we have 889 > patches related to fall throughs and the first series went in in > october 2017 ... ignoring a couple of outliers back to February. I can see ~10k insertions over ~1

Re: [drm/fb] 6a1b34c0a3: WARNING:at_drivers/gpu/drm/drm_fb_helper.c:#drm_fb_helper_damage_work

2020-11-24 Thread Xing Zhengjun
On 11/23/2020 4:04 PM, Thomas Zimmermann wrote: Hi Am 22.11.20 um 15:18 schrieb kernel test robot: Greeting, FYI, we noticed the following commit (built with gcc-9): commit: 6a1b34c0a339fdc75d7932ad5702f2177c9d7a1c ("drm/fb-helper: Move damage blit code and its setup into separate routin

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-24 Thread Finn Thain
On Mon, 23 Nov 2020, Joe Perches wrote: > On Tue, 2020-11-24 at 11:58 +1100, Finn Thain wrote: > > it's not for me to prove that such patches don't affect code > > generation. That's for the patch author and (unfortunately) for > > reviewers. > > Ideally, that proof would be provided by the c

Re: [PATCH 0/2] drm/cma-helper: Move mmap to object functions

2020-11-24 Thread Maxime Ripard
On Mon, Nov 23, 2020 at 12:56:44PM +0100, Thomas Zimmermann wrote: > This patchset moves CMA's mmap into a GEM object function. This change > allows for removing CMA's mmap and gem_prime_mmap callbacks in favor of > the default implementation. > > Tested with vc4 on RPi3. For both patches, Acked-

[PATCH] drm/nouveau/fb/gp102-: use flexible-array member instead of zero-length array

2020-11-24 Thread Tian Tao
fixed the coccicheck: drivers/gpu/drm/nouveau/include/nvfw/hs.h:26:5-9: WARNING use flexible-array member instead. Signed-off-by: Tian Tao --- drivers/gpu/drm/nouveau/include/nvfw/hs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/include/nvfw/hs.h

Re: [PATCH v2 9/9] misc: xilinx-ai-engine: Add support for servicing error interrupts

2020-11-24 Thread Wendy Liang
On 11/19/20 12:36 AM, Hillf Danton wrote: On Wed, 18 Nov 2020 15:48:09 -0800 Wendy Liang wrote: +/** + * aie_interrupt() - interrupt handler for AIE. + * @irq: Interrupt number. + * @data: AI engine device structure. + * @return: IRQ_HANDLED. + * + * This thread function disables level 2 inte

Re: [PATCH v2 2/9] misc: Add Xilinx AI engine device driver

2020-11-24 Thread Wendy Liang
On Fri, Nov 20, 2020 at 06:12:10AM +1000, Dave Airlie wrote: > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 5cc595a..40e3351 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -19283,6 +19283,14 @@ T: git https://github.com/Xilinx/linux-xlnx.git > > F: Documentation/devicetree

Re: [PATCH rdma-core 2/5] mlx5: Support dma-buf based memory region

2020-11-24 Thread Jason Gunthorpe
On Mon, Nov 23, 2020 at 09:53:01AM -0800, Jianxin Xiong wrote: > +struct ibv_mr *mlx5_reg_dmabuf_mr(struct ibv_pd *pd, uint64_t offset, size_t > length, > + uint64_t iova, int fd, int acc) > +{ > + struct mlx5_mr *mr; > + int ret; > + enum ibv_access_flag

[PATCHv9 1/8] iommu/io-pgtable-arm: Add support to use system cache

2020-11-24 Thread Sai Prakash Ranjan
Add a quirk IO_PGTABLE_QUIRK_ARM_OUTER_WBWA to override the outer-cacheability attributes set in the TCR for a non-coherent page table walker when using system cache. Signed-off-by: Sai Prakash Ranjan --- drivers/iommu/io-pgtable-arm.c | 10 -- include/linux/io-pgtable.h | 4 2

Re: [PATCHv8 2/8] iommu/arm-smmu: Add domain attribute for pagetable configuration

2020-11-24 Thread Sai Prakash Ranjan
On 2020-11-23 20:48, Will Deacon wrote: On Tue, Nov 17, 2020 at 08:00:41PM +0530, Sai Prakash Ranjan wrote: Add iommu domain attribute for pagetable configuration which initially will be used to set quirks like for system cache aka last level cache to be used by client drivers like GPU to set ri

Re: [PATCH v1] drm/bridge: lt9611: Fix handling of 4k panels

2020-11-24 Thread Anibal Limon
I just tested on non 4k display. Looks good to me. On Mon, 23 Nov 2020 at 04:46, Robert Foss wrote: > 4k requires two dsi pipes, so don't report MODE_OK when only a > single pipe is configured. But rather report MODE_PANEL to > signal that requirements of the panel are not being met. > > Reporte

[PATCH v1] drm/bridge: lt9611: Fix handling of 4k panels

2020-11-24 Thread Robert Foss
4k requires two dsi pipes, so don't report MODE_OK when only a single pipe is configured. But rather report MODE_PANEL to signal that requirements of the panel are not being met. Reported-by: Peter Collingbourne Suggested-by: Peter Collingbourne Signed-off-by: Robert Foss Tested-by: John Stultz

Re: [PATCH v10 03/19] memory: tegra30: Support interconnect framework

2020-11-24 Thread Dmitry Osipenko
23.11.2020 09:32, Georgi Djakov пишет: > Hi Dmitry, > > On 23.11.20 2:27, Dmitry Osipenko wrote: >> Now Internal and External memory controllers are memory interconnection >> providers. This allows us to use interconnect API for tuning of memory >> configuration. EMC driver now supports OPPs and D

Re: [RFC] MAINTAINERS tag for cleanup robot

2020-11-24 Thread Lukas Bulwahn
On Mon, Nov 23, 2020 at 4:52 PM Jani Nikula wrote: > > On Sat, 21 Nov 2020, James Bottomley > wrote: > > On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote: > >> A difficult part of automating commits is composing the subsystem > >> preamble in the commit log. For the ongoing effort of a

[PATCHv9 2/8] iommu/arm-smmu: Add domain attribute for pagetable configuration

2020-11-24 Thread Sai Prakash Ranjan
Add iommu domain attribute for pagetable configuration which initially will be used to set quirks like for system cache aka last level cache to be used by client drivers like GPU to set right attributes for caching the hardware pagetables into the system cache and later can be extended to include o

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-24 Thread Finn Thain
On Mon, 23 Nov 2020, Miguel Ojeda wrote: > On Mon, 23 Nov 2020, Finn Thain wrote: > > > On Sun, 22 Nov 2020, Miguel Ojeda wrote: > > > > > > > > It isn't that much effort, isn't it? Plus we need to take into > > > account the future mistakes that it might prevent, too. > > > > We should als

[PATCHv9 8/8] iommu: arm-smmu-impl: Add a space before open parenthesis

2020-11-24 Thread Sai Prakash Ranjan
Fix the checkpatch warning for space required before the open parenthesis. Signed-off-by: Sai Prakash Ranjan Acked-by: Will Deacon --- drivers/iommu/arm/arm-smmu/arm-smmu-impl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c b/dri

[PATCHv9 0/8] System Cache support for GPU and required SMMU support

2020-11-24 Thread Sai Prakash Ranjan
Some hardware variants contain a system cache or the last level cache(llc). This cache is typically a large block which is shared by multiple clients on the SOC. GPU uses the system cache to cache both the GPU data buffers(like textures) as well the SMMU pagetables. This helps with improved render

Re: [PATCH v4 2/2] drm/vc4: kms: Don't disable the muxing of an active CRTC

2020-11-24 Thread Maxime Ripard
On Mon, Nov 23, 2020 at 08:50:49AM +0100, Thomas Zimmermann wrote: > > > Am 20.11.20 um 15:42 schrieb Maxime Ripard: > > The current HVS muxing code will consider the CRTCs in a given state to > > setup their muxing in the HVS, and disable the other CRTCs muxes. > > > > However, it's valid to on

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-24 Thread Jason Gunthorpe
On Fri, Nov 20, 2020 at 12:21:39PM -0600, Gustavo A. R. Silva wrote: > IB/hfi1: Fix fall-through warnings for Clang > IB/mlx4: Fix fall-through warnings for Clang > IB/qedr: Fix fall-through warnings for Clang > RDMA/mlx5: Fix fall-through warnings for Clang I picked these four to the rdm

Re: [PATCHv8 0/8] System Cache support for GPU and required SMMU support

2020-11-24 Thread Sai Prakash Ranjan
On 2020-11-24 00:52, Rob Clark wrote: On Mon, Nov 23, 2020 at 9:01 AM Sai Prakash Ranjan wrote: On 2020-11-23 20:51, Will Deacon wrote: > On Tue, Nov 17, 2020 at 08:00:39PM +0530, Sai Prakash Ranjan wrote: >> Some hardware variants contain a system cache or the last level >> cache(llc). This c

Re: [PATCHv8 0/8] System Cache support for GPU and required SMMU support

2020-11-24 Thread Sai Prakash Ranjan
On 2020-11-23 20:51, Will Deacon wrote: On Tue, Nov 17, 2020 at 08:00:39PM +0530, Sai Prakash Ranjan wrote: Some hardware variants contain a system cache or the last level cache(llc). This cache is typically a large block which is shared by multiple clients on the SOC. GPU uses the system cache

Re: [PATCH v2 9/9] misc: xilinx-ai-engine: Add support for servicing error interrupts

2020-11-24 Thread Wendy Liang
On Thu, Nov 19, 2020 at 04:36:45PM +0800, Hillf Danton wrote: > On Wed, 18 Nov 2020 15:48:09 -0800 Wendy Liang wrote: > > +/** > > + * aie_interrupt() - interrupt handler for AIE. > > + * @irq: Interrupt number. > > + * @data: AI engine device structure. > > + * @return: IRQ_HANDLED. > > + * > > +

Re: [PATCH v2 00/10] drm/fb-helper: Various fixes and cleanups

2020-11-24 Thread Maxime Ripard
On Fri, Nov 20, 2020 at 11:25:35AM +0100, Thomas Zimmermann wrote: > Here's a number of fb-helper patches that have been piling up recently. > > Patches 1 to 3 fix bugs that I spotted while going through the code. > Because of the way the fbdev code works, they have been avoided so far. > > Patch

Re: [PATCHv8 3/8] iommu/arm-smmu: Move non-strict mode to use domain_attr_io_pgtbl_cfg

2020-11-24 Thread Sai Prakash Ranjan
On 2020-11-23 20:49, Will Deacon wrote: On Tue, Nov 17, 2020 at 08:00:42PM +0530, Sai Prakash Ranjan wrote: Now that we have a struct domain_attr_io_pgtbl_cfg with quirks, use that for non_strict mode as well thereby removing the need for more members of arm_smmu_domain in the future. Signed-of

[PATCHv9 7/8] iommu: arm-smmu-impl: Use table to list QCOM implementations

2020-11-24 Thread Sai Prakash Ranjan
Use table and of_match_node() to match qcom implementation instead of multiple of_device_compatible() calls for each QCOM SMMU implementation. Signed-off-by: Sai Prakash Ranjan Acked-by: Will Deacon --- drivers/iommu/arm/arm-smmu/arm-smmu-impl.c | 9 + drivers/iommu/arm/arm-smmu/arm-sm

Re: [PATCH v10 00/19] Introduce memory interconnect for NVIDIA Tegra SoCs

2020-11-24 Thread Dmitry Osipenko
23.11.2020 09:17, Viresh Kumar пишет: > On 23-11-20, 03:27, Dmitry Osipenko wrote: >> This series brings initial support for memory interconnect to Tegra20, >> Tegra30 and Tegra124 SoCs. >> >> For the starter only display controllers and devfreq devices are getting >> interconnect API support, othe

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-24 Thread Miguel Ojeda
On Sun, Nov 22, 2020 at 11:36 PM James Bottomley wrote: > > Well, it seems to be three years of someone's time plus the maintainer > review time and series disruption of nearly a thousand patches. Let's > be conservative and assume the producer worked about 30% on the series > and it takes about

[PATCHv9 5/8] drm/msm/a6xx: Add support for using system cache(LLC)

2020-11-24 Thread Sai Prakash Ranjan
From: Sharat Masetty The last level system cache can be partitioned to 32 different slices of which GPU has two slices preallocated. One slice is used for caching GPU buffers and the other slice is used for caching the GPU SMMU pagetables. This talks to the core system cache driver to acquire the

Re: [PATCH] Properly check tee_shm buffer mmap offset

2020-11-24 Thread Jens Wiklander
Hi, On Mon, Nov 23, 2020 at 8:10 AM gaoyusong wrote: > > The memmap options in tee_shm_op_mmap were not being checked for all > sets of possible crazy values. Fix this up by properly check tee_shm > buffer offsets. > > Signed-off-by: gaoyusong > --- > drivers/tee/tee_shm.c | 10 ++ > 1

[PATCHv9 6/8] drm/msm/a6xx: Add support for using system cache on MMU500 based targets

2020-11-24 Thread Sai Prakash Ranjan
From: Jordan Crouse GPU targets with an MMU-500 attached have a slightly different process for enabling system cache. Use the compatible string on the IOMMU phandle to see if an MMU-500 is attached and modify the programming sequence accordingly. Signed-off-by: Jordan Crouse Signed-off-by: Sai

Re: [PATCH rdma-core 1/5] verbs: Support dma-buf based memory region

2020-11-24 Thread Jason Gunthorpe
On Mon, Nov 23, 2020 at 09:53:00AM -0800, Jianxin Xiong wrote: > Add new API function and new provider method for registering dma-buf > based memory region. Update the man page and bump the API version. > > Signed-off-by: Jianxin Xiong > kernel-headers/rdma/ib_user_ioctl_cmds.h | 14

Re: [PATCH rdma-core 3/5] pyverbs: Add dma-buf based MR support

2020-11-24 Thread Jason Gunthorpe
On Mon, Nov 23, 2020 at 09:53:02AM -0800, Jianxin Xiong wrote: > +cdef class DmaBuf: > +def __init__(self, size, unit=0): > +""" > +Allocate DmaBuf object from a GPU device. This is done through the > +DRI device interface (/dev/dri/card*). Usually this requires the > +

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-24 Thread Miguel Ojeda
On Sun, Nov 22, 2020 at 11:54 PM Finn Thain wrote: > > We should also take into account optimisim about future improvements in > tooling. Not sure what you mean here. There is no reliable way to guess what the intention was with a missing fallthrough, even if you parsed whitespace and indentation

[PATCHv9 3/8] iommu/arm-smmu: Move non-strict mode to use io_pgtable_domain_attr

2020-11-24 Thread Sai Prakash Ranjan
Now that we have a struct io_pgtable_domain_attr with quirks, use that for non_strict mode as well thereby removing the need for more members of arm_smmu_domain in the future. Signed-off-by: Sai Prakash Ranjan --- drivers/iommu/arm/arm-smmu/arm-smmu.c | 8 +++- drivers/iommu/arm/arm-smmu/arm

[PATCHv9 4/8] drm/msm: rearrange the gpu_rmw() function

2020-11-24 Thread Sai Prakash Ranjan
From: Sharat Masetty The register read-modify-write construct is generic enough that it can be used by other subsystems as needed, create a more generic rmw() function and have the gpu_rmw() use this new function. Signed-off-by: Sharat Masetty Reviewed-by: Jordan Crouse Signed-off-by: Sai Prak

Re: [PATCHv8 1/8] iommu/io-pgtable-arm: Add support to use system cache

2020-11-24 Thread Sai Prakash Ranjan
On 2020-11-23 20:36, Will Deacon wrote: On Tue, Nov 17, 2020 at 08:00:40PM +0530, Sai Prakash Ranjan wrote: Add a quirk IO_PGTABLE_QUIRK_ARM_OUTER_WBWA to override the attributes set in TCR for the page table walker when using system cache. Signed-off-by: Sai Prakash Ranjan --- drivers/iommu/

Re: [PATCH v3 0/2] Default to cachable mappings for GEM SHMEM

2020-11-24 Thread Maxime Ripard
On Tue, Nov 17, 2020 at 02:31:54PM +0100, Thomas Zimmermann wrote: > By default, SHMEM GEM helpers map pages using writecombine. Only a few > drivers require this setting. Others revert it to default mappings > flags. Some could benefit from caching, but don't care. > > Unify the behaviour by swit

Re: [PATCH v10 09/19] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

2020-11-24 Thread Dmitry Osipenko
23.11.2020 10:02, Chanwoo Choi пишет: > Hi Dmitry, > > On 11/23/20 9:27 AM, Dmitry Osipenko wrote: >> This patch moves ACTMON driver away from generating OPP table by itself, >> transitioning it to use the table which comes from device-tree. This >> change breaks compatibility with older device-tr

Re: [PATCH v2 0/6] drm/panel: mantix and st7703 fixes and additions

2020-11-24 Thread Guido Günther
Hi, On Mon, Nov 23, 2020 at 10:48:26PM +0100, Sam Ravnborg wrote: > Hi Guido, > > On Wed, Nov 18, 2020 at 09:29:47AM +0100, Guido Günther wrote: > > This adds new panel type to the mantix driver as found on the Librem 5 and > > fixes a glitch in the init sequence (affecting both panels). The fix i

Re: [PATCH] drm/i915/dsi: Use unconditional msleep for the panel_on_delay when there is no reset-deassert MIPI-sequence

2020-11-24 Thread Hans de Goede
Hi, On 11/18/20 1:40 PM, Hans de Goede wrote: > Commit 25b4620ee822 ("drm/i915/dsi: Skip delays for v3 VBTs in vid-mode") > added an intel_dsi_msleep() helper which skips sleeping if the > MIPI-sequences have a version of 3 or newer and the panel is in vid-mode; > and it moved a bunch of msleep-s

Re: [PATCH 2/2] drm: panel: add Khadas TS050 panel driver

2020-11-24 Thread Neil Armstrong
Hi Sam, On 23/11/2020 22:05, Sam Ravnborg wrote: > Hi Neil. > > Looks good but a few comments in the following that needs some attention. > > Sam > > On Mon, Nov 23, 2020 at 03:33:54PM +0100, Neil Armstrong wrote: >> This add support for the Khadas TS050 1080x1920 5" LCD DSI panel designe

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-24 Thread Thomas Zimmermann
Hi Christian Am 16.11.20 um 12:28 schrieb Christian König: Am 13.11.20 um 08:59 schrieb Thomas Zimmermann: Hi Christian Am 12.11.20 um 18:16 schrieb Christian König: Am 12.11.20 um 14:21 schrieb Thomas Zimmermann: In order to avoid eviction of vmap'ed buffers, pin them in their GEM object's

Re: [PATCH v2 05/10] drm/fb-helper: Return early in dirty worker

2020-11-24 Thread Thomas Zimmermann
Hi Am 23.11.20 um 20:23 schrieb Sam Ravnborg: On Fri, Nov 20, 2020 at 11:25:40AM +0100, Thomas Zimmermann wrote: Returning early in the dirty worker if no update is required makes the code more readable. No functional changes are made. Signed-off-by: Thomas Zimmermann It is a damage worker

Re: [drm/fb] 6a1b34c0a3: WARNING:at_drivers/gpu/drm/drm_fb_helper.c:#drm_fb_helper_damage_work

2020-11-24 Thread Thomas Zimmermann
Hi Am 24.11.20 um 02:58 schrieb Xing Zhengjun: On 11/23/2020 4:04 PM, Thomas Zimmermann wrote: Hi Am 22.11.20 um 15:18 schrieb kernel test robot: Greeting, FYI, we noticed the following commit (built with gcc-9): commit: 6a1b34c0a339fdc75d7932ad5702f2177c9d7a1c ("drm/fb-helper: Move dam

Re: [PATCH] video: hyperv_fb: Directly use the MMIO VRAM

2020-11-24 Thread Wei Liu
On Tue, Nov 24, 2020 at 08:33:32AM +, Dexuan Cui wrote: > Hi Wei Liu, > Please do not pick up this patch, because actually MMIO VRAM can not work > with fb_deferred_io. > No problem. Thanks for the heads-up. Wei. ___ dri-devel mailing list dri-deve

Re: [Intel-gfx] [PATCH v5 00/17] HDCP 2.2 and HDCP 1.4 Gen12 DP MST support

2020-11-24 Thread Karthik B S
On 11/11/2020 11:50 AM, Anshuman Gupta wrote: This is v5 version to test with IGT https://patchwork.freedesktop.org/series/82987/ This has addressed the review comments from Ram. It has been also tested manually with above IGT series. As we currently do not have a setup for HDCP over DP MST on

Re: [PATCHv8 0/8] System Cache support for GPU and required SMMU support

2020-11-24 Thread Will Deacon
On Tue, Nov 24, 2020 at 09:32:54AM +0530, Sai Prakash Ranjan wrote: > On 2020-11-24 00:52, Rob Clark wrote: > > On Mon, Nov 23, 2020 at 9:01 AM Sai Prakash Ranjan > > wrote: > > > > > > On 2020-11-23 20:51, Will Deacon wrote: > > > > On Tue, Nov 17, 2020 at 08:00:39PM +0530, Sai Prakash Ranjan wr

[PATCH RESEND v3 2/2] drm/bridge: display-connector: add DP support

2020-11-24 Thread Tomi Valkeinen
Add DP support to display-connector driver. The driver will support HPD via a GPIO and DP PWR. DP PWR will be enabled at probe, which is not optimal, but I'm not sure what would be a good place to enable and disable DP PWR. Perhaps attach/detach, but I don't know if enabling HW is something that a

[PATCH RESEND v3 1/2] dt-bindings: dp-connector: add binding for DisplayPort connector

2020-11-24 Thread Tomi Valkeinen
Add binding for DisplayPort connector. A few notes: * Similar to hdmi-connector, it has hpd-gpios as an optional property, as the HPD could also be handled by, e.g., the DP bridge. * dp-pwr-supply, which provides 3.3V on DP_PWR pin, is optional, as it is not strictly required: standard DP cab

[PATCH RESEND v3 0/2] drm: add DisplayPort connector

2020-11-24 Thread Tomi Valkeinen
Hi, This series adds the DT bindings and a driver for DisplayPort connector. This is a resend of https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg326794.html with no changes (rebased on top of latest drm-misc). Tomi Tomi Valkeinen (2): dt-bindings: dp-connector: add binding fo

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-24 Thread Christian König
Am 24.11.20 um 10:16 schrieb Thomas Zimmermann: Hi Christian Am 16.11.20 um 12:28 schrieb Christian König: Am 13.11.20 um 08:59 schrieb Thomas Zimmermann: Hi Christian Am 12.11.20 um 18:16 schrieb Christian König: Am 12.11.20 um 14:21 schrieb Thomas Zimmermann: In order to avoid eviction of

[PATCH 02/15] drm/ast: Remove references to struct drm_device.pdev

2020-11-24 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert ast to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.c | 4 ++-- drivers/gpu/drm/ast/ast_main.c | 25 + drivers/gpu/drm/ast/ast_mm.c | 17 +

[PATCH 03/15] drm/bochs: Remove references to struct drm_device.pdev

2020-11-24 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert bochs to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_drv.c | 1 - drivers/gpu/drm/bochs/bochs_hw.c | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-)

[PATCH 00/15] drm: Move struct drm_device.pdev to legacy

2020-11-24 Thread Thomas Zimmermann
The pdev field in struct drm_device points to a PCI device structure and goes back to UMS-only days when all DRM drivers where for PCI devices. Meanwhile we also support USB, SPI and platform devices. Each of those uses the generic device stored in struct drm_device.dev. To reduce duplications and

[PATCH 01/15] drm/amdgpu: Remove references to struct drm_device.pdev

2020-11-24 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert amdgpu to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 23 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_displa

[PATCH 10/15] drm/qxl: Remove references to struct drm_device.pdev

2020-11-24 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert qxl to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_drv.c | 2 +- drivers/gpu/drm/qxl/qxl_ioctl.c | 3 ++- drivers/gpu/drm/qxl/qxl_irq.c | 3 ++- drivers/gpu/d

[PATCH 04/15] drm/cirrus: Remove references to struct drm_device.pdev

2020-11-24 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert cirrus to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Gerd Hoffmann --- drivers/gpu/drm/tiny/cirrus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/tiny/cirrus.c b/drivers/gpu/drm/tin

[PATCH 09/15] drm/nouveau: Remove references to struct drm_device.pdev

2020-11-24 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert nouveau to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Ben Skeggs --- drivers/gpu/drm/nouveau/dispnv04/arb.c | 12 +++- drivers/gpu/drm/nouveau/dispnv04/disp.h | 14 -- driver

[PATCH 06/15] drm/hibmc: Remove references to struct drm_device.pdev

2020-11-24 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert hibmc to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Xinliang Liu Cc: Tian Tao Cc: John Stultz Cc: Xinwei Kong Cc: Chen Feng --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 10 +- drive

[PATCH 07/15] drm/i915: Remove references to struct drm_device.pdev

2020-11-24 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert i915 to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi --- drivers/gpu/drm/i915/display/intel_bios.c | 2 +- drivers/gpu/drm/i915/display/intel_cdclk.c

[PATCH 08/15] drm/mgag200: Remove references to struct drm_device.pdev

2020-11-24 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert mgag200 to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.c | 20 +++- drivers/gpu/drm/mgag200/mgag200_i2c.c | 2 +- drivers/gpu/drm/mgag200/mgag200_mm.c

[PATCH 05/15] drm/gma500: Remove references to struct drm_device.pdev

2020-11-24 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert gma500 to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_device.c| 30 +++--- drivers/gpu/drm/gma500/cdv_intel_crt.c | 3 +- drivers/g

[PATCH 11/15] drm/radeon: Remove references to struct drm_device.pdev

2020-11-24 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert radeon to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: Christian König --- drivers/gpu/drm/radeon/atombios_encoders.c| 6 +- drivers/gpu/drm/radeon/r100.c | 27 +++---

[PATCH 15/15] drm: Upcast struct drm_device.dev to struct pci_device; replace pdev

2020-11-24 Thread Thomas Zimmermann
We have DRM drivers based on USB, SPI and platform devices. All of them are fine with storing their device reference in struct drm_device.dev. PCI devices should be no exception. Therefore struct drm_device.pdev is deprecated. Instead upcast from struct drm_device.dev with to_pci_dev(). PCI-specif

[PATCH 13/15] drm/virtgpu: Remove references to struct drm_device.pdev

2020-11-24 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert virtgpu to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c b/dri

[PATCH 12/15] drm/vboxvideo: Remove references to struct drm_device.pdev

2020-11-24 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert vboxvideo to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Hans de Goede --- drivers/gpu/drm/vboxvideo/vbox_drv.c | 11 ++- drivers/gpu/drm/vboxvideo/vbox_irq.c | 4 +++- drivers/gpu/drm/vboxvide

[PATCH 14/15] drm/vmwgfx: Remove references to struct drm_device.pdev

2020-11-24 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert vmwgfx to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 8 drivers/gpu/drm/vmwgfx/vmwgfx_drv.c| 27 +- d

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-24 Thread Thomas Zimmermann
Hi Am 24.11.20 um 12:30 schrieb Christian König: Am 24.11.20 um 10:16 schrieb Thomas Zimmermann: Hi Christian Am 16.11.20 um 12:28 schrieb Christian König: Am 13.11.20 um 08:59 schrieb Thomas Zimmermann: Hi Christian Am 12.11.20 um 18:16 schrieb Christian König: Am 12.11.20 um 14:21 schrie

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-24 Thread Christian König
Am 24.11.20 um 12:44 schrieb Thomas Zimmermann: Hi Am 24.11.20 um 12:30 schrieb Christian König: Am 24.11.20 um 10:16 schrieb Thomas Zimmermann: Hi Christian Am 16.11.20 um 12:28 schrieb Christian König: Am 13.11.20 um 08:59 schrieb Thomas Zimmermann: Hi Christian Am 12.11.20 um 18:16 schr

[PATCH] dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.

2020-11-24 Thread Maarten Lankhorst
We hardcode the maximum number of shared fences to 4, instead of respecting num_fences. Use a minimum of 4, but more if num_fences is higher. This seems to have been an oversight when first implementing the api. Fixes: 04a5faa8cbe5 ("reservation: update api and add some helpers") Cc: # v3.17+ Re

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-24 Thread Thomas Zimmermann
Hi Am 24.11.20 um 12:54 schrieb Christian König: Am 24.11.20 um 12:44 schrieb Thomas Zimmermann: Hi Am 24.11.20 um 12:30 schrieb Christian König: Am 24.11.20 um 10:16 schrieb Thomas Zimmermann: Hi Christian Am 16.11.20 um 12:28 schrieb Christian König: Am 13.11.20 um 08:59 schrieb Thomas Z

[PATCH][next] drm/mcde: fix masking and bitwise-or on variable val

2020-11-24 Thread Colin King
From: Colin Ian King The masking of val with ~MCDE_CRX1_CLKSEL_MASK is currently being ignored because there seems to be a missing bitwise-or of val in the following statement. Fix this by replacing the assignment of val with a bitwise-or. Addresses-Coverity: ("Unused valued") Fixes: d795fd3220

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-24 Thread Christian König
Am 24.11.20 um 13:15 schrieb Thomas Zimmermann: [SNIP] First I wanted to put this into drm_gem_ttm_vmap/vunmap(), but then wondered why ttm_bo_vmap() doe not acquire the lock internally? I'd expect that vmap/vunmap are close together and do not overlap for the same BO. We have use cases lik

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-24 Thread Thomas Zimmermann
Hi Am 24.11.20 um 14:36 schrieb Christian König: Am 24.11.20 um 13:15 schrieb Thomas Zimmermann: [SNIP] First I wanted to put this into drm_gem_ttm_vmap/vunmap(), but then wondered why ttm_bo_vmap() doe not acquire the lock internally? I'd expect that vmap/vunmap are close together and do no

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-24 Thread Christian König
Am 24.11.20 um 14:56 schrieb Thomas Zimmermann: Hi Am 24.11.20 um 14:36 schrieb Christian König: Am 24.11.20 um 13:15 schrieb Thomas Zimmermann: [SNIP] First I wanted to put this into drm_gem_ttm_vmap/vunmap(), but then wondered why ttm_bo_vmap() doe not acquire the lock internally? I'd expe

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-24 Thread Daniel Vetter
On Tue, Nov 24, 2020 at 02:56:51PM +0100, Thomas Zimmermann wrote: > Hi > > Am 24.11.20 um 14:36 schrieb Christian König: > > Am 24.11.20 um 13:15 schrieb Thomas Zimmermann: > > > [SNIP] > > > > > > > First I wanted to put this into > > > > > > > drm_gem_ttm_vmap/vunmap(), but then wondered why >

Re: [PATCH v5 07/17] drm/i915/hdcp: Enable HDCP 1.4 stream encryption

2020-11-24 Thread Ramalingam C
On 2020-11-11 at 11:50:41 +0530, Anshuman Gupta wrote: > Enable HDCP 1.4 DP MST stream encryption. > > Enable stream encryption once encryption is enabled on > the DP transport driving the link for each stream which > has requested encryption. > > Disable stream encryption for each stream that no

Re: [PATCH v6 09/17] media/videbuf1|2: Mark follow_pfn usage as unsafe

2020-11-24 Thread Daniel Vetter
On Fri, Nov 20, 2020 at 09:23:12PM +0900, Tomasz Figa wrote: > On Fri, Nov 20, 2020 at 9:08 PM Hans Verkuil wrote: > > > > On 20/11/2020 11:51, Daniel Vetter wrote: > > > On Fri, Nov 20, 2020 at 11:39 AM Hans Verkuil wrote: > > >> > > >> On 20/11/2020 10:18, Daniel Vetter wrote: > > >>> On Fri, N

Re: [PATCH v5 08/17] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-11-24 Thread Ramalingam C
On 2020-11-11 at 11:50:42 +0530, Anshuman Gupta wrote: > Enable HDCP 1.4 over DP MST for Gen12. > > Cc: Ramalingam C > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/g

Re: [PATCH v6 17/17] RFC: mm: add mmu_notifier argument to follow_pfn

2020-11-24 Thread Daniel Vetter
On Fri, Nov 20, 2020 at 02:30:29PM -0400, Jason Gunthorpe wrote: > On Thu, Nov 19, 2020 at 03:41:46PM +0100, Daniel Vetter wrote: > > @@ -4805,21 +4824,15 @@ EXPORT_SYMBOL(follow_pte_pmd); > > * Return: zero and the pfn at @pfn on success, -ve otherwise. > > */ > > int follow_pfn(struct vm_are

Re: [PATCH 2/3] mm: Extract might_alloc() debug check

2020-11-24 Thread Daniel Vetter
On Fri, Nov 20, 2020 at 02:07:19PM -0400, Jason Gunthorpe wrote: > On Fri, Nov 20, 2020 at 10:54:43AM +0100, Daniel Vetter wrote: > > diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h > > index d5ece7a9a403..f94405d43fd1 100644 > > --- a/include/linux/sched/mm.h > > +++ b/include/lin

Re: [PATCH 084/141] drm/via: Fix fall-through warnings for Clang

2020-11-24 Thread Gustavo A. R. Silva
On Sun, Nov 22, 2020 at 11:03:58PM +0100, Sam Ravnborg wrote: > On Fri, Nov 20, 2020 at 12:35:54PM -0600, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > by explicitly adding a break statement instead of letting the code fall > > through t

Re: [PATCH] drm: fix kernel-doc warnings for SCALING_FILTER

2020-11-24 Thread Daniel Vetter
On Fri, Nov 20, 2020 at 11:06:22AM +, Simon Ser wrote: > This patch fixes the following kernel-doc warnings: > > /home/simon/src/linux/Documentation/gpu/drm-kms:466: > ./drivers/gpu/drm/drm_crtc.c:236: WARNING: Unexpected indentation. > /home/simon/src/linux/Documentation/gpu/drm-kms:

Re: [BUG] drm/vkms: Failure when using drmGetConnectorCurrent()

2020-11-24 Thread Daniel Vetter
On Fri, Nov 20, 2020 at 01:19:04PM -0300, Leandro Ribeiro wrote: > Hello, > > We have a patch in Weston to replace drmGetConnector() calls with > drmGetConnectorCurrent(): > > https://gitlab.freedesktop.org/wayland/weston/-/issues/437 > https://gitlab.freedesktop.org/wayland/weston/-/merge_reques

Re: [PATCH 134/141] video: fbdev: lxfb_ops: Fix fall-through warnings for Clang

2020-11-24 Thread Gustavo A. R. Silva
Hi Sam, On Sun, Nov 22, 2020 at 11:05:40PM +0100, Sam Ravnborg wrote: > Hi Gustavo, > On Fri, Nov 20, 2020 at 12:40:32PM -0600, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > by explicitly adding a break statement instead of letting the

Re: [PATCH v3 02/12] drm: Unamp the entire device address space on device unplug

2020-11-24 Thread Daniel Vetter
On Sat, Nov 21, 2020 at 03:16:15PM +0100, Christian König wrote: > Am 21.11.20 um 06:21 schrieb Andrey Grodzovsky: > > Invalidate all BOs CPU mappings once device is removed. > > > > v3: Move the code from TTM into drm_dev_unplug > > > > Signed-off-by: Andrey Grodzovsky > > Reviewed-by: Christi

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-24 Thread Gustavo A. R. Silva
On Mon, Nov 23, 2020 at 04:03:45PM -0400, Jason Gunthorpe wrote: > On Fri, Nov 20, 2020 at 12:21:39PM -0600, Gustavo A. R. Silva wrote: > > > IB/hfi1: Fix fall-through warnings for Clang > > IB/mlx4: Fix fall-through warnings for Clang > > IB/qedr: Fix fall-through warnings for Clang > > R

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-24 Thread Gustavo A. R. Silva
On Mon, Nov 23, 2020 at 08:38:46PM +, Mark Brown wrote: > On Fri, 20 Nov 2020 12:21:39 -0600, Gustavo A. R. Silva wrote: > > This series aims to fix almost all remaining fall-through warnings in > > order to enable -Wimplicit-fallthrough for Clang. > > > > In preparation to enable -Wimplicit-f

Re: [PATCH v3 10/12] drm/amdgpu: Avoid sysfs dirs removal post device unplug

2020-11-24 Thread Daniel Vetter
On Sat, Nov 21, 2020 at 12:21:20AM -0500, Andrey Grodzovsky wrote: > Avoids NULL ptr due to kobj->sd being unset on device removal. > > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 +++- > drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 4 +++- > 2 files cha

Re: [PATCH v3 08/12] drm/amdgpu: Split amdgpu_device_fini into early and late

2020-11-24 Thread Daniel Vetter
On Sat, Nov 21, 2020 at 12:21:18AM -0500, Andrey Grodzovsky wrote: > Some of the stuff in amdgpu_device_fini such as HW interrupts > disable and pending fences finilization must be done right away on > pci_remove while most of the stuff which relates to finilizing and > releasing driver data struct

[Bug 205675] Display locks up. AMDGPU timeout

2020-11-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205675 srwretryt (wihejo6...@bcpfm.com) changed: What|Removed |Added CC||wihejo6...@bcpfm.com -

Re: [PATCH v5 08/17] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-11-24 Thread Anshuman Gupta
On 2020-11-24 at 19:50:17 +0530, Ramalingam C wrote: > On 2020-11-11 at 11:50:42 +0530, Anshuman Gupta wrote: > > Enable HDCP 1.4 over DP MST for Gen12. > > > > Cc: Ramalingam C > > Signed-off-by: Anshuman Gupta > > --- > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 10 +++--- > > 1 file

Re: [PATCH rdma-core 3/5] pyverbs: Add dma-buf based MR support

2020-11-24 Thread Daniel Vetter
On Mon, Nov 23, 2020 at 02:05:04PM -0400, Jason Gunthorpe wrote: > On Mon, Nov 23, 2020 at 09:53:02AM -0800, Jianxin Xiong wrote: > > > +cdef class DmaBuf: > > +def __init__(self, size, unit=0): > > +""" > > +Allocate DmaBuf object from a GPU device. This is done through the >

Re: [PATCH v5 07/17] drm/i915/hdcp: Enable HDCP 1.4 stream encryption

2020-11-24 Thread Anshuman Gupta
On 2020-11-24 at 19:44:59 +0530, Ramalingam C wrote: > On 2020-11-11 at 11:50:41 +0530, Anshuman Gupta wrote: > > Enable HDCP 1.4 DP MST stream encryption. > > > > Enable stream encryption once encryption is enabled on > > the DP transport driving the link for each stream which > > has requested e

[Bug 205675] Display locks up. AMDGPU timeout

2020-11-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205675 --- Comment #38 from srwretryt (wihejo6...@bcpfm.com) --- https://gitlab.com/gitlab-org/gitlab/-/issues/287829 https://gitlab.com/gitlab-org/gitlab/-/issues/287830 https://gitlab.com/gitlab-org/gitlab/-/issues/287831 https://gitlab.com/gitlab-org/

Re: [PATCH 02/40] drm/amd/amdgpu/amdgpu_ttm: Add description for 'page_flags'

2020-11-24 Thread Alex Deucher
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:1214: warning: Function parameter or > member 'page_flags' not described in 'amdgpu_ttm_tt_create' > > Cc: Alex Deucher > Cc: "Christian König" > Cc

Re: [PATCH] drm/i915/dsi: Use unconditional msleep for the panel_on_delay when there is no reset-deassert MIPI-sequence

2020-11-24 Thread Ville Syrjälä
On Wed, Nov 18, 2020 at 01:40:58PM +0100, Hans de Goede wrote: > Commit 25b4620ee822 ("drm/i915/dsi: Skip delays for v3 VBTs in vid-mode") > added an intel_dsi_msleep() helper which skips sleeping if the > MIPI-sequences have a version of 3 or newer and the panel is in vid-mode; > and it moved a bu

Re: [PATCH 03/40] drm/amd/amdgpu/amdgpu_ib: Provide docs for 'amdgpu_ib_schedule()'s 'job' param

2020-11-24 Thread Alex Deucher
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c:127: warning: Function parameter or > member 'job' not described in 'amdgpu_ib_schedule' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Air

Re: [PATCH 05/40] drm/amd/amdgpu/cik_ih: Supply description for 'ih' in 'cik_ih_{get, set}_wptr()'

2020-11-24 Thread Alex Deucher
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/cik_ih.c:189: warning: Function parameter or > member 'ih' not described in 'cik_ih_get_wptr' > drivers/gpu/drm/amd/amdgpu/cik_ih.c:274: warning: Function paramet

  1   2   3   4   >