Re: [PATCH v4 07/15] drm/bridge: tc358767: add drm_panel_bridge support

2020-07-27 Thread Sam Ravnborg
Hi Laurent. Thanks for the prompt review. On Mon, Jul 27, 2020 at 12:48:32AM +0300, Laurent Pinchart wrote: > Hi Sam, > > Thank you for the patch. > > On Sun, Jul 26, 2020 at 10:33:16PM +0200, Sam Ravnborg wrote: > > With the bridge operations implemented the last step to prepare > > this drive

Re: [PATCH 1/2] drm/fourcc: fix Amlogic Video Framebuffer Compression macro

2020-07-27 Thread Neil Armstrong
On 26/07/2020 19:25, Sam Ravnborg wrote: > Hi Neil. > > On Thu, Jul 23, 2020 at 11:05:50AM +0200, Neil Armstrong wrote: >> Fix the Amlogic Video Framebuffer Compression modifier macro to >> correctly add the layout options, a pair of parenthesis was missing. >> >> Fixes: d6528ec88309 ("drm/fourcc:

[PATCH 2/3] drm/ast: Store image size in HW cursor info

2020-07-27 Thread Thomas Zimmermann
Store the image size as part of the HW cursor info, so that the cursor show function doesn't require the information from the caller. No functional changes. Signed-off-by: Thomas Zimmermann Fixes: 4961eb60f145 ("drm/ast: Enable atomic modesetting") Cc: Thomas Zimmermann Cc: Gerd Hoffmann Cc: Da

[PATCH 1/3] drm/ast: Do full modeset if the primary plane's format changes

2020-07-27 Thread Thomas Zimmermann
The atomic modesetting code tried to distinguish format changes from full modesetting operations. In practice, this was buggy and the format registers were often updated even for simple pageflips. Instead do a full modeset if the primary plane changes formats. It's just as rare as an actual mode c

[PATCH 0/3] drm/ast: Disable HW cursor when switching modes

2020-07-27 Thread Thomas Zimmermann
Since converting the ast driver to atomic modesettting, modesetting occationally locks up the graphics hardware and turns the display permanently dark. This happens once or twice per 10 modeswitches. Investigation shows that the ast hardware presumably requires the HW cursor to be disabled while th

[PATCH 3/3] drm/ast: Disable cursor while switching display modes

2020-07-27 Thread Thomas Zimmermann
The ast's HW cursor requires the primary plane and CRTC to display at a correct mode and format. This is not the case while switching display modes, which can lead to the screen turing permanently dark. As a workaround, the ast driver now disables active HW cursors while the mode switch takes plac

Re: [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-07-27 Thread Thierry Reding
On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote: > Hi All, > > Here is v5 of my patch series converting the i915 driver's code for > controlling the panel's backlight with an external PWM controller to > use the atomic PWM API. See below for the changelog. > > This series consists o

[PATCH v3 2/2] drm: panel: Add tianma nt36672a panel driver

2020-07-27 Thread Sumit Semwal
Some Poco F1 phones have an LCD panel from Tianma, model nt36672a, with a resolution of 1080x2246 that operates in DSI video mode. Add the drm panel driver for it. During testing, Benni Steini helped us fix the reset sequence timing (from 10ms to 20ms), to get the bootanimation to work on Androi

[PATCH v3 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel

2020-07-27 Thread Sumit Semwal
The nt36672a panel from Tianma is a FHD+ panel with a resolution of 1080x2246 and 6.18 inches size. It is found in some of the Poco F1 phones. Signed-off-by: Sumit Semwal --- v2: remove ports node, making port@0 directly under panel@0 node. v3: updated to replace port@0 to just 'port'. --- .../

[PATCH v3 0/2] Add support for Tianma nt36672a video mode panel

2020-07-27 Thread Sumit Semwal
Some Poco F1 phones from Xiaomi have an nt36672a video mode panel; add support for the same. Most of the panel data is taken from downstream panel dts, and is converted to drm-panel based driver by me. It has been validated with v5.8-rc5 on Poco F1 phone; my tree with other dependent patches is her

Re: [PATCH v2 11/22] drm: mxsfb: Stop using DRM simple display pipeline helper

2020-07-27 Thread Stefan Agner
On 2020-07-26 20:28, Laurent Pinchart wrote: > Hi Stefan, > > On Fri, Jul 17, 2020 at 05:06:55AM +0300, Laurent Pinchart wrote: >> On Thu, Jul 09, 2020 at 12:25:42PM +0200, Stefan Agner wrote: >> > On 2020-06-16 03:50, Laurent Pinchart wrote: >> >> On Thu, Jun 11, 2020 at 09:33:11PM +0200, Stefan

Re: [PATCH v2 4/4] xen: add helpers to allocate unpopulated memory

2020-07-27 Thread David Hildenbrand
On 24.07.20 18:36, Boris Ostrovsky wrote: > On 7/24/20 10:34 AM, David Hildenbrand wrote: >> CCing Dan >> >> On 24.07.20 14:42, Roger Pau Monne wrote: >>> diff --git a/drivers/xen/unpopulated-alloc.c >>> b/drivers/xen/unpopulated-alloc.c >>> new file mode 100644 >>> index ..aaa91cefbbf

Re: [PATCH v2] drm/drm_fb_helper: fix fbdev with sparc64

2020-07-27 Thread Daniel Vetter
On Sat, Jul 25, 2020 at 9:10 PM Sam Ravnborg wrote: > > From 1323a7433691aee112a9b2df8041b5024895a77e Mon Sep 17 00:00:00 2001 > From: Sam Ravnborg > Date: Thu, 9 Jul 2020 21:30:16 +0200 > Subject: [PATCH v2 1/1] drm/drm_fb_helper: fix fbdev with sparc64 > > Recent kernels have been reported to p

Re: [PATCH] video: fbdev: added driver for sharp memory lcd displays

2020-07-27 Thread Daniel Vetter
On Sun, Jul 26, 2020 at 7:22 PM Sam Ravnborg wrote: > > Hi Rodrigo. > > On Fri, Jul 24, 2020 at 05:34:04PM -0300, Rodrigo Alencar wrote: > > The supported displays are ls027b7dh01 (tested), ls044q7dh01, > > ls013b7dh05, ls013b7dh03 > > > > Signed-off-by: Rodrigo Alencar <455.rodrigo.alen...@gmail.

Re: [PATCH -next 1/2] drm: Remove redundant NULL check

2020-07-27 Thread daniel
On Thu, Jul 23, 2020 at 11:27:42AM +0800, Li Heng wrote: > Fix below warnings reported by coccicheck: > ./drivers/gpu/drm/drm_drv.c:819:2-7: WARNING: NULL check before some freeing > functions is not needed. > > Fixes: 5dad34f3c444 ("drm: Cleanups after drmm_add_final_kfree rollout") > Signed-off

Re: [PATCH 1/9] drm/ttm: initialize the system domain with defaults

2020-07-27 Thread daniel
On Thu, Jul 23, 2020 at 05:16:13PM +0200, Christian König wrote: > Instead of repeating that in each driver. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 3 --- > drivers/gpu/drm/drm_gem_vram_helper.c | 3 --- > drivers/gpu/drm/nouveau/nouveau_bo.c

Re: [PATCH 2/9] drm/ttm: remove TTM_MEMTYPE_FLAG_FIXED

2020-07-27 Thread daniel
On Thu, Jul 23, 2020 at 05:16:14PM +0200, Christian König wrote: > Instead use a boolean field in the memory manager structure. > > Also invert the meaning of the field since the use of a TT > structure is the special case here. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amd

Re: [PATCH 2/9] drm/ttm: remove TTM_MEMTYPE_FLAG_FIXED

2020-07-27 Thread Christian König
Am 27.07.20 um 11:48 schrieb dan...@ffwll.ch: On Thu, Jul 23, 2020 at 05:16:14PM +0200, Christian König wrote: Instead use a boolean field in the memory manager structure. Also invert the meaning of the field since the use of a TT structure is the special case here. Signed-off-by: Christian Kö

Re: [PATCH 2/9] drm/ttm: remove TTM_MEMTYPE_FLAG_FIXED

2020-07-27 Thread daniel
On Mon, Jul 27, 2020 at 11:54:41AM +0200, Christian König wrote: > Am 27.07.20 um 11:48 schrieb dan...@ffwll.ch: > > On Thu, Jul 23, 2020 at 05:16:14PM +0200, Christian König wrote: > > > Instead use a boolean field in the memory manager structure. > > > > > > Also invert the meaning of the field

Re: [PATCH 3/9] drm/radeon: stop implementing init_mem_type

2020-07-27 Thread daniel
On Thu, Jul 23, 2020 at 05:16:15PM +0200, Christian König wrote: > Instead just initialize the memory type parameters > before calling ttm_bo_init_mm. > > Signed-off-by: Christian König Hm what's the motivation here? I do agree that the init_mem_type callback is rather midlayer-y (having a per-t

Re: [PATCH 3/9] drm/radeon: stop implementing init_mem_type

2020-07-27 Thread daniel
On Mon, Jul 27, 2020 at 12:30:00PM +0200, dan...@ffwll.ch wrote: > On Thu, Jul 23, 2020 at 05:16:15PM +0200, Christian König wrote: > > Instead just initialize the memory type parameters > > before calling ttm_bo_init_mm. > > > > Signed-off-by: Christian König > > Hm what's the motivation here?

Re: [RFC][PATCH] dma-heap: Add proper kref handling on dma-buf heaps

2020-07-27 Thread daniel
On Sat, Jul 25, 2020 at 03:26:33AM +, John Stultz wrote: > Add proper refcounting on the dma_heap structure. > While existing heaps are built-in, we may eventually > have heaps loaded from modules, and we'll need to be > able to properly handle the references to the heaps Uh I kinda want to wa

Re: [PATCH 1/9] drm/ttm: initialize the system domain with defaults

2020-07-27 Thread Christian König
Am 27.07.20 um 11:42 schrieb dan...@ffwll.ch: On Thu, Jul 23, 2020 at 05:16:13PM +0200, Christian König wrote: Instead of repeating that in each driver. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 3 --- drivers/gpu/drm/drm_gem_vram_helper.c | 3 ---

Re: [PATCH 1/3] drm/ast: Do full modeset if the primary plane's format changes

2020-07-27 Thread daniel
On Mon, Jul 27, 2020 at 09:37:05AM +0200, Thomas Zimmermann wrote: > The atomic modesetting code tried to distinguish format changes from > full modesetting operations. In practice, this was buggy and the format > registers were often updated even for simple pageflips. Nah it's not buggy, it's int

Re: [PATCH 2/3] drm/ast: Store image size in HW cursor info

2020-07-27 Thread daniel
On Mon, Jul 27, 2020 at 09:37:06AM +0200, Thomas Zimmermann wrote: > Store the image size as part of the HW cursor info, so that the > cursor show function doesn't require the information from the > caller. No functional changes. Uh just pass the state structure and done? All these "store random s

Re: [PATCH 3/3] drm/ast: Disable cursor while switching display modes

2020-07-27 Thread daniel
On Mon, Jul 27, 2020 at 09:37:07AM +0200, Thomas Zimmermann wrote: > The ast's HW cursor requires the primary plane and CRTC to display > at a correct mode and format. This is not the case while switching > display modes, which can lead to the screen turing permanently dark. > > As a workaround, t

Re: [PATCH 1/9] drm/ttm: initialize the system domain with defaults

2020-07-27 Thread Hellstrom, Thomas
On Mon, 2020-07-27 at 12:39 +0200, Christian König wrote: > Am 27.07.20 um 11:42 schrieb dan...@ffwll.ch: > > On Thu, Jul 23, 2020 at 05:16:13PM +0200, Christian König wrote: > > > Instead of repeating that in each driver. > > > > > > Signed-off-by: Christian König > > > --- > > > drivers/gpu/d

Re: [PATCH 3/9] drm/radeon: stop implementing init_mem_type

2020-07-27 Thread Christian König
Am 27.07.20 um 12:30 schrieb dan...@ffwll.ch: On Thu, Jul 23, 2020 at 05:16:15PM +0200, Christian König wrote: Instead just initialize the memory type parameters before calling ttm_bo_init_mm. Signed-off-by: Christian König Hm what's the motivation here? I do agree that the init_mem_type call

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

2020-07-27 Thread Mazin Rezk
On Monday, July 27, 2020 1:40 AM, Mazin Rezk wrote: > This patch fixes a race condition that causes a use-after-free during > amdgpu_dm_atomic_commit_tail. This can occur when 2 non-blocking commits > are requested and the second one finishes before the first. Essentially, > this bug occurs when t

[PATCH] drm/amd/display: Clear dm_state for fast updates

2020-07-27 Thread Mazin Rezk
This patch fixes a race condition that causes a use-after-free during amdgpu_dm_atomic_commit_tail. This can occur when 2 non-blocking commits are requested and the second one finishes before the first. Essentially, this bug occurs when the following sequence of events happens: 1. Non-blocking com

[bug report] drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem

2020-07-27 Thread dan.carpenter
Hello Hyun Kwon, The patch d76271d22694: "drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem" from Jul 7, 2018, leads to the following static checker warning: drivers/gpu/drm/xlnx/zynqmp_dp.c:594 zynqmp_dp_mode_configure() error: iterator underflow 'bws' (-1)-2 dri

Re: [PATCH 1/3] drm/ast: Do full modeset if the primary plane's format changes

2020-07-27 Thread Thomas Zimmermann
Hi Am 27.07.20 um 12:40 schrieb dan...@ffwll.ch: > On Mon, Jul 27, 2020 at 09:37:05AM +0200, Thomas Zimmermann wrote: >> The atomic modesetting code tried to distinguish format changes from >> full modesetting operations. In practice, this was buggy and the format >> registers were often updated e

Re: [PATCH 2/3] drm/ast: Store image size in HW cursor info

2020-07-27 Thread Thomas Zimmermann
Hi Am 27.07.20 um 12:42 schrieb dan...@ffwll.ch: > On Mon, Jul 27, 2020 at 09:37:06AM +0200, Thomas Zimmermann wrote: >> Store the image size as part of the HW cursor info, so that the >> cursor show function doesn't require the information from the >> caller. No functional changes. > > Uh just p

Re: [PATCH 1/9] drm/ttm: initialize the system domain with defaults

2020-07-27 Thread Christian König
Am 27.07.20 um 12:50 schrieb Hellstrom, Thomas: On Mon, 2020-07-27 at 12:39 +0200, Christian König wrote: Am 27.07.20 um 11:42 schrieb dan...@ffwll.ch: On Thu, Jul 23, 2020 at 05:16:13PM +0200, Christian König wrote: Instead of repeating that in each driver. Signed-off-by: Christian König --

Re: [PATCH v5 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-07-27 Thread Michel Dänzer
On 2020-07-25 1:26 a.m., Paulo Zanoni wrote: > Em seg, 2020-07-20 às 17:01 +0530, Karthik B S escreveu: >> >> diff --git a/drivers/gpu/drm/i915/i915_irq.c >> b/drivers/gpu/drm/i915/i915_irq.c >> index 1fa67700d8f4..95953b393941 100644 >> --- a/drivers/gpu/drm/i915/i915_irq.c >> +++ b/drivers/gpu/d

Re: [PATCH 1/9] drm/ttm: initialize the system domain with defaults

2020-07-27 Thread Hellstrom, Thomas
On Mon, 2020-07-27 at 14:23 +0200, Christian König wrote: > Am 27.07.20 um 12:50 schrieb Hellstrom, Thomas: > > On Mon, 2020-07-27 at 12:39 +0200, Christian König wrote: > > > Am 27.07.20 um 11:42 schrieb dan...@ffwll.ch: > > > > On Thu, Jul 23, 2020 at 05:16:13PM +0200, Christian König > > > > wro

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

2020-07-27 Thread Kazlauskas, Nicholas
On 2020-07-27 1:40 a.m., Mazin Rezk wrote: This patch fixes a race condition that causes a use-after-free during amdgpu_dm_atomic_commit_tail. This can occur when 2 non-blocking commits are requested and the second one finishes before the first. Essentially, this bug occurs when the following seq

linux-next: Fixes tag needs some work in the drm-fixes tree

2020-07-27 Thread Stephen Rothwell
Hi all, In commit 163d5446c37a ("drm/nouveau/disp/gm200-: fix regression from HDA SOR selection changes") Fixes tag Fixes: 9b5ca547bb8 ("drm/nouveau/disp/gm200-: detect and potentially disable HDA support on some SORs") has these problem(s): - SHA1 should be at least 12 digits long

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

2020-07-27 Thread Christian König
Am 27.07.20 um 07:40 schrieb Mazin Rezk: This patch fixes a race condition that causes a use-after-free during amdgpu_dm_atomic_commit_tail. This can occur when 2 non-blocking commits are requested and the second one finishes before the first. Essentially, this bug occurs when the following seque

Re: [PATCH 2/2] drm/radeon: avoid a useless memset

2020-07-27 Thread Christian König
Am 27.07.20 um 12:34 schrieb Christophe JAILLET: Avoid a memset after a call to 'dma_alloc_coherent()'. This is useless since commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*") Signed-off-by: Christophe JAILLET Reviewed-by: Christian König --- drivers/gpu/drm/rade

Re: [PATCH 1/2] drm/radeon: switch from 'pci_' to 'dma_' API

2020-07-27 Thread Christian König
Am 27.07.20 um 12:34 schrieb Christophe JAILLET: The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in '

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

2020-07-27 Thread Kazlauskas, Nicholas
On 2020-07-27 9:39 a.m., Christian König wrote: Am 27.07.20 um 07:40 schrieb Mazin Rezk: This patch fixes a race condition that causes a use-after-free during amdgpu_dm_atomic_commit_tail. This can occur when 2 non-blocking commits are requested and the second one finishes before the first. Esse

[Bug 208661] Backlight doesn't work with both nv_backlight and acpi_video

2020-07-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208661 --- Comment #6 from Ilia Mirkin (imir...@alum.mit.edu) --- After a lot of debugging on IRC, here are a few facts that are worth recording: 1. The nv_backlight "method" works -- i.e. the backlight is hooked up to the GPU. Adjusting brightness via

Re: [v7, PATCH 7/7] drm/mediatek: add support for mediatek SOC MT8183

2020-07-27 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年7月27日 週一 下午3:54寫道: > > On Sat, 2020-07-25 at 07:24 +0800, Chun-Kuang Hu wrote: > > Hi Yongqiang: > > > > Yongqiang Niu 於 2020年7月23日 週四 上午10:15寫道: > > > > > > This patch add support for mediatek SOC MT8183 > > > 1.ovl_2l share driver with ovl > > > > I think th

Re: [PATCH v2] drm/drm_fb_helper: fix fbdev with sparc64

2020-07-27 Thread Sam Ravnborg
Hi Daniel On Mon, Jul 27, 2020 at 11:20:13AM +0200, Daniel Vetter wrote: > On Sat, Jul 25, 2020 at 9:10 PM Sam Ravnborg wrote: > > > > From 1323a7433691aee112a9b2df8041b5024895a77e Mon Sep 17 00:00:00 2001 > > From: Sam Ravnborg > > Date: Thu, 9 Jul 2020 21:30:16 +0200 > > Subject: [PATCH v2 1/1

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-27 Thread Jürgen Groß
On 27.07.20 11:13, Roger Pau Monne wrote: To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels with

[Bug 208661] Backlight doesn't work with both nv_backlight and acpi_video

2020-07-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208661 --- Comment #7 from Shannon Gaines (iknstu...@protonmail.com) --- Created attachment 290619 --> https://bugzilla.kernel.org/attachment.cgi?id=290619&action=edit Patch to add NvForceGpioReset config option I created a patch that allows users to

Re: [PATCH v4 08/15] drm/bridge: parade-ps8622: add drm_panel_bridge support

2020-07-27 Thread Sam Ravnborg
Hi Laurent. On Mon, Jul 27, 2020 at 12:54:08AM +0300, Laurent Pinchart wrote: > Hi Sam, > > Thank you for the patch. > > On Sun, Jul 26, 2020 at 10:33:17PM +0200, Sam Ravnborg wrote: > > Prepare the bridge driver for use in a chained setup by > > replacing direct use of drm_panel with drm_panel_

[Bug 207901] Nouveau: In a 4 monitor setup, 1-2 displays remains black after boot

2020-07-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207901 --- Comment #26 from Maurice Gale (mauricega...@gmail.com) --- Sorry for the delay and the mistake. It loaded the 5.3 kernel by default. I recreated the log using 5.7-rc5 with the i2c timeout patch. I also added the new grub options. The file size

[Bug 207901] Nouveau: In a 4 monitor setup, 1-2 displays remains black after boot

2020-07-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207901 --- Comment #27 from Ilia Mirkin (imir...@alum.mit.edu) --- DP -> HDMI is, most likely, just passive, so the displays are being driven as HDMI rather than as DP. DP is the problematic protocol... -- You are receiving this mail because: You are w

[Bug 204241] amdgpu fails to resume from suspend

2020-07-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204241 felipejfc (fjfcavalca...@gmail.com) changed: What|Removed |Added CC||fjfcavalca...@gmail.

[Bug 204241] amdgpu fails to resume from suspend

2020-07-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204241 --- Comment #64 from felipejfc (fjfcavalca...@gmail.com) --- (In reply to felipejfc from comment #63) > I'm having the same issue with an AMD RX5700 and kernel version 5.7.9-1 on > manjaro linux. > > for me adding kernel params 'amd_iommu=on iomm

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #101 from Duncan (1i5t5.dun...@cox.net) --- (In reply to Nicholas Kazlauskas from comment #95) > Created attachment 290583 [details] > 0001-drm-amd-display-Force-add-all-CRTCs-to-state-when-us.patch Just booted to 5.8-rc7 with this pa

Re: [PATCH v4 0/15] drm/bridge: support chained bridges + panel updates

2020-07-27 Thread Sam Ravnborg
Hi Laurent/all. On Sun, Jul 26, 2020 at 10:33:09PM +0200, Sam Ravnborg wrote: > The objective is that all bridge drivers shall support a chained setup > connector creation is moved to the display drivers. > This is just one step on this path. > > The general approach for the bridge drivers: > - I

Re: [PATCH 2/6] drm: dsi: Let host and device specify supported bus

2020-07-27 Thread Laurent Pinchart
Hi Paul, Thank you for the patch. On Mon, Jul 27, 2020 at 06:46:09PM +0200, Paul Cercueil wrote: > The current MIPI DSI framework can very well be used to support MIPI DBI > panels. In order to add support for the various bus types supported by > DBI, the DRM panel drivers should specify the bus

[PATCH v5 1/5] drm/bridge: tc358767: add detect bridge operation

2020-07-27 Thread Sam Ravnborg
Prepare the bridge driver for chained operation by adding support for the detect operation. v3: - Fix code to make it readable (Laurent) v2: - Do not announce detect operation if there is no hpd pin (Laurent) Signed-off-by: Sam Ravnborg Reviewed-by: Laurent Pinchart Cc: Andrzej Hajda Cc:

[PATCH v5 4/5] drm/bridge: nxp-ptn3460: add get_edid bridge operation

2020-07-27 Thread Sam Ravnborg
Add the get_edid() bridge operation to prepare for use as a chained bridge. Add helper function that is also used by the connector. v2: - Fix memory leak (Laurent) - Do not save a copy of edid, read it when needed Signed-off-by: Sam Ravnborg Reviewed-by: Laurent Pinchart Cc: Andrzej Hajda

[PATCH v5 3/5] drm/bridge: tc358767: add drm_panel_bridge support

2020-07-27 Thread Sam Ravnborg
With the bridge operations implemented the last step to prepare this driver for a chained setup is the use of the bridge panel driver. The bridge panel driver is only used when a port@2 is present in the DT. So when the display driver requests a connector support both situations: - connector creat

[PATCH v5 0/5] drm/bridge: Update tc358767 and nxp-ptn3460 to support chained bridges

2020-07-27 Thread Sam Ravnborg
This patch-set aims to make connector creation optional and prepare the bridge drivers for use in a chained setup. The objective is that all bridge drivers shall support a chained setup connector creation is moved to the display drivers. This is just one step on this path. The general approach fo

[PATCH v5 5/5] drm/bridge: nxp-ptn3460: add drm_panel_bridge support

2020-07-27 Thread Sam Ravnborg
Prepare the bridge driver for use in a chained setup. - Replacing direct use of drm_panel with drm_panel_bridge support. - Make the connector creation optional Note: the bridge panel will use the connector type from the panel. v3: - Fix wrong logic in connector creation (Laurent) v2: - Use

[PATCH v5 2/5] drm/bridge: tc358767: add get_edid bridge operation

2020-07-27 Thread Sam Ravnborg
Prepare for chained bridge with the addition of get_edid support. v2: - Fixed handling of edid storage (Laurent) Signed-off-by: Sam Ravnborg Reviewed-by: Laurent Pinchart Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec --- drivers/gpu/drm/b

Re: [PATCH 3/6] drm/bridge: Add SPI DBI host driver

2020-07-27 Thread Laurent Pinchart
Hi Paul, Thank you for the patch. On Mon, Jul 27, 2020 at 06:46:10PM +0200, Paul Cercueil wrote: > This driver will register a DBI host driver for panels connected over > SPI. > > DBI types c1 and c3 are supported. C1 is a SPI protocol with 9 bits per > word, with the data/command information in

Re: [PATCH v5 3/5] drm/bridge: tc358767: add drm_panel_bridge support

2020-07-27 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Mon, Jul 27, 2020 at 07:03:18PM +0200, Sam Ravnborg wrote: > With the bridge operations implemented the last step to prepare > this driver for a chained setup is the use of the bridge panel driver. > > The bridge panel driver is only used when a port@2 is pres

Re: [PATCH v5 5/5] drm/bridge: nxp-ptn3460: add drm_panel_bridge support

2020-07-27 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Mon, Jul 27, 2020 at 07:03:20PM +0200, Sam Ravnborg wrote: > Prepare the bridge driver for use in a chained setup. > > - Replacing direct use of drm_panel with drm_panel_bridge support. > - Make the connector creation optional > > Note: the bridge panel will

Re: [PATCH v5 0/5] drm/bridge: Update tc358767 and nxp-ptn3460 to support chained bridges

2020-07-27 Thread Sam Ravnborg
Hi all. On Mon, Jul 27, 2020 at 07:03:15PM +0200, Sam Ravnborg wrote: > This patch-set aims to make connector creation optional > and prepare the bridge drivers for use in a chained setup. > > The objective is that all bridge drivers shall support a chained setup > connector creation is moved to

Re: [PATCH -next] crc:Fix build errors

2020-07-27 Thread Lyude Paul
Hi, I actually already sent a patch for this: https://patchwork.freedesktop.org/patch/378202/ I'm guessing it hasn't gotten picked up upstream yet? On Mon, 2020-07-27 at 12:00 +0800, Peng Wu wrote: > If CONFIG_DRM_NOUVEAU=y,the following errors > are seen while building crc.h. > > In file inclu

Re: [PATCH 1/2] dt-bindings: Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge

2020-07-27 Thread Rob Herring
On Sat, 25 Jul 2020 23:14:56 +0200, Marek Vasut wrote: > Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge, this > one is used in the Raspberry Pi 7" touchscreen display unit. > > Signed-off-by: Marek Vasut > To: dri-devel@lists.freedesktop.org > Cc: Eric Anholt > Cc: Rob Herring > Cc: Sam

Re: [PATCH 2/3] dt-bindings: Add DT bindings for Powertip PH800480T013

2020-07-27 Thread Rob Herring
On Sat, 25 Jul 2020 23:13:34 +0200, Marek Vasut wrote: > Add DT bindings for Powertip PH800480T013 800x480 parallel LCD, > this one is used in the Raspberry Pi 7" touchscreen display unit. > > Signed-off-by: Marek Vasut > To: dri-devel@lists.freedesktop.org > Cc: Eric Anholt > Cc: Rob Herring >

Re: [PATCH 2/2] drm/radeon: avoid a useless memset

2020-07-27 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Jul 27, 2020 at 9:41 AM Christian König wrote: > > Am 27.07.20 um 12:34 schrieb Christophe JAILLET: > > Avoid a memset after a call to 'dma_alloc_coherent()'. > > This is useless since > > commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*") >

Re: [PATCH 9/9] soc/qcom: Add REVID driver

2020-07-27 Thread Rob Herring
On Sun, 26 Jul 2020 13:12:06 +0200, Konrad Dybcio wrote: > From: Xiaozhe Shi > > Add the REVID device driver. The REVID driver will print out the PMIC > revision at probe time. > > Signed-off-by: Xiaozhe Shi > [konradyb...@gmail.com: Fast-forward the driver from kernel 4.14 to 5.8, > convert bi

Re: [PATCH 9/9] soc/qcom: Add REVID driver

2020-07-27 Thread Rob Herring
On Sun, Jul 26, 2020 at 01:12:06PM +0200, Konrad Dybcio wrote: > From: Xiaozhe Shi > > Add the REVID device driver. The REVID driver will print out the PMIC > revision at probe time. > > Signed-off-by: Xiaozhe Shi > [konradyb...@gmail.com: Fast-forward the driver from kernel 4.14 to 5.8, > conv

Re: [PATCH 1/2] drm/radeon: switch from 'pci_' to 'dma_' API

2020-07-27 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Jul 27, 2020 at 9:42 AM Christian König wrote: > > Am 27.07.20 um 12:34 schrieb Christophe JAILLET: > > The wrappers in include/linux/pci-dma-compat.h should go away. > > > > The patch has been generated with the coccinelle script below and has been > > hand modifi

Re: [PATCH 1/3] drm/ast: Do full modeset if the primary plane's format changes

2020-07-27 Thread Daniel Vetter
On Mon, Jul 27, 2020 at 1:24 PM Thomas Zimmermann wrote: > > Hi > > Am 27.07.20 um 12:40 schrieb dan...@ffwll.ch: > > On Mon, Jul 27, 2020 at 09:37:05AM +0200, Thomas Zimmermann wrote: > >> The atomic modesetting code tried to distinguish format changes from > >> full modesetting operations. In pr

Re: [PATCH 2/3] drm/ast: Store image size in HW cursor info

2020-07-27 Thread Daniel Vetter
On Mon, Jul 27, 2020 at 1:37 PM Thomas Zimmermann wrote: > > Hi > > Am 27.07.20 um 12:42 schrieb dan...@ffwll.ch: > > On Mon, Jul 27, 2020 at 09:37:06AM +0200, Thomas Zimmermann wrote: > >> Store the image size as part of the HW cursor info, so that the > >> cursor show function doesn't require th

Re: [PATCH] drm/dbi: Fix SPI Type 1 (9-bit) transfer

2020-07-27 Thread Sam Ravnborg
Hi Paul. On Fri, Jul 03, 2020 at 04:23:57PM +0200, Sam Ravnborg wrote: > On Fri, Jul 03, 2020 at 04:13:41PM +0200, Paul Cercueil wrote: > > The function mipi_dbi_spi1_transfer() will transfer its payload as 9-bit > > data, the 9th (MSB) bit being the data/command bit. In order to do that, > > it u

Re: [Nouveau] [PATCH v2] drm/nouveau: Accept 'legacy' format modifiers

2020-07-27 Thread James Jones
On 7/23/20 9:06 PM, Ben Skeggs wrote: On Sat, 18 Jul 2020 at 13:34, James Jones wrote: Accept the DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK() family of modifiers to handle broken userspace Xorg modesetting and Mesa drivers. Existing Mesa drivers are still aware of only these older format modifiers whi

Re: [PATCH 1/6] dt-bindings: display: Document NewVision NV3052C DT node

2020-07-27 Thread Sam Ravnborg
Hi Paul. On Mon, Jul 27, 2020 at 06:46:08PM +0200, Paul Cercueil wrote: > Add documentation for the Device Tree node for LCD panels based on the > NewVision NV3052C controller. > > Signed-off-by: Paul Cercueil Very happy to see work on RG-350 :-) Some feedback below. Sam > --- > .../

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

2020-07-27 Thread Christian König
Am 27.07.20 um 16:05 schrieb Kazlauskas, Nicholas: On 2020-07-27 9:39 a.m., Christian König wrote: Am 27.07.20 um 07:40 schrieb Mazin Rezk: This patch fixes a race condition that causes a use-after-free during amdgpu_dm_atomic_commit_tail. This can occur when 2 non-blocking commits are request

Re: [PATCH 1/3] drm: Restore driver.preclose() for all to use

2020-07-27 Thread Daniel Vetter
On Thu, Jul 23, 2020 at 7:21 PM Chris Wilson wrote: > > An unfortunate sequence of events, but it turns out there is a valid > usecase for being able to free/decouple the driver objects before they > are freed by the DRM core. In particular, if we have a pointer into a > drm core object from insid

Re: [PATCH 8/9] clk: qcom: gcc-sdm660: Fix up gcc_mss_mnoc_bimc_axi_clk

2020-07-27 Thread Stephen Boyd
Quoting Konrad Dybcio (2020-07-26 04:12:05) > Add missing halt_check, hwcg_reg and hwcg_bit properties. > These were likely omitted when porting the driver upstream. > > Signed-off-by: Konrad Dybcio > --- Fixes tag? ___ dri-devel mailing list dri-devel

Re: [v6] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings

2020-07-27 Thread Rob Herring
On Thu, Jul 16, 2020 at 08:15:28PM +0530, Krishna Manikandan wrote: > MSM Mobile Display Subsytem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI etc. Add YAML schema > for the device tree bindings for the same. > > Signed-off-by: Krishna Manikandan > > Changes in v2: > - C

Re: [PATCH 1/9] clk: qcom: gcc-sdm660: Add missing modem reset

2020-07-27 Thread Stephen Boyd
Quoting Konrad Dybcio (2020-07-26 04:11:58) > This will be required in order to support the > modem upstream. > > Signed-off-by: Konrad Dybcio > --- Should have a fixes tag too. > drivers/clk/qcom/gcc-sdm660.c | 1 + > include/dt-bindings/clock/qcom,gcc-sdm660.h | 1 + > 2 files

Re: [PATCH V2] drm: hold gem reference until object is no longer accessed

2020-07-27 Thread Greg KH
On Mon, Jul 20, 2020 at 06:30:50PM -0400, Steve Cohen wrote: > A use-after-free in drm_gem_open_ioctl can happen if the > GEM object handle is closed between the idr lookup and > retrieving the size from said object since a local reference > is not being held at that point. Hold the local reference

Re: [PATCH 2/6] drm: dsi: Let host and device specify supported bus

2020-07-27 Thread Sam Ravnborg
Hi Paul. On Mon, Jul 27, 2020 at 06:46:09PM +0200, Paul Cercueil wrote: > The current MIPI DSI framework can very well be used to support MIPI DBI > panels. In order to add support for the various bus types supported by > DBI, the DRM panel drivers should specify the bus type they will use, > and

RE: [PATCH 1/3] drm: Restore driver.preclose() for all to use

2020-07-27 Thread Tang, CQ
> -Original Message- > From: Daniel Vetter > Sent: Monday, July 27, 2020 12:33 PM > To: Chris Wilson ; Dave Airlie > Cc: intel-gfx ; stable > ; Gustavo Padovan > ; Tang, CQ ; dri- > devel ; Vetter, Daniel > > Subject: Re: [PATCH 1/3] drm: Restore driver.preclose() for all to use > >

Re: [PATCH V2] drm: hold gem reference until object is no longer accessed

2020-07-27 Thread daniel
On Mon, Jul 27, 2020 at 09:55:07PM +0200, Greg KH wrote: > On Mon, Jul 20, 2020 at 06:30:50PM -0400, Steve Cohen wrote: > > A use-after-free in drm_gem_open_ioctl can happen if the > > GEM object handle is closed between the idr lookup and > > retrieving the size from said object since a local refe

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

2020-07-27 Thread Daniel Vetter
On Mon, Jul 27, 2020 at 9:28 PM Christian König wrote: > > Am 27.07.20 um 16:05 schrieb Kazlauskas, Nicholas: > > On 2020-07-27 9:39 a.m., Christian König wrote: > >> Am 27.07.20 um 07:40 schrieb Mazin Rezk: > >>> This patch fixes a race condition that causes a use-after-free during > >>> amdgpu_d

Re: [PATCH 3/6] drm/bridge: Add SPI DBI host driver

2020-07-27 Thread Sam Ravnborg
Hi Paul. On Mon, Jul 27, 2020 at 06:46:10PM +0200, Paul Cercueil wrote: > This driver will register a DBI host driver for panels connected over > SPI. So this is actually a MIPI DBI host driver. I personally would love to have added mipi_ in the names - to make it all more explicit. But maybe tha

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel

2020-07-27 Thread Rob Herring
On Mon, 27 Jul 2020 13:13:47 +0530, Sumit Semwal wrote: > The nt36672a panel from Tianma is a FHD+ panel with a resolution of > 1080x2246 and 6.18 inches size. It is found in some of the Poco F1 > phones. > > Signed-off-by: Sumit Semwal > > --- > v2: remove ports node, making port@0 directly und

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

2020-07-27 Thread Daniel Vetter
On Mon, Jul 27, 2020 at 10:29 PM Daniel Vetter wrote: > > On Mon, Jul 27, 2020 at 9:28 PM Christian König > wrote: > > > > Am 27.07.20 um 16:05 schrieb Kazlauskas, Nicholas: > > > On 2020-07-27 9:39 a.m., Christian König wrote: > > >> Am 27.07.20 um 07:40 schrieb Mazin Rezk: > > >>> This patch fi

Re: [PATCH 3/3] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex

2020-07-27 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.7.10, v5.4.53, v4.19.134, v4.14.189, v4.9.231, v4.4.231. v5.7.10: Build OK! v5.4

Re: [PATCH 1/3] drm: Restore driver.preclose() for all to use

2020-07-27 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: 4.12+ The bot has tested the following trees: v5.7.10, v5.4.53, v4.19.134, v4.14.189. v5.7.10: Build OK! v5.4.53: Build OK! v4.1

[PATCH] drm/amdgpu/dc: Stop dma_resv_lock inversion in commit_tail

2020-07-27 Thread Daniel Vetter
Trying to grab dma_resv_lock while in commit_tail before we've done all the code that leads to the eventual signalling of the vblank event (which can be a dma_fence) is deadlock-y. Don't do that. Here the solution is easy because just grabbing locks to read something races anyway. We don't need to

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

2020-07-27 Thread Daniel Vetter
On Mon, Jul 27, 2020 at 11:11 PM Mazin Rezk wrote: > > On Monday, July 27, 2020 4:29 PM, Daniel Vetter wrote: > > > On Mon, Jul 27, 2020 at 9:28 PM Christian König > > wrote: > > > > > > Am 27.07.20 um 16:05 schrieb Kazlauskas, Nicholas: > > > > On 2020-07-27 9:39 a.m., Christian König wrote: >

Re: [PATCH v5 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-07-27 Thread Daniel Vetter
On Mon, Jul 27, 2020 at 2:27 PM Michel Dänzer wrote: > > On 2020-07-25 1:26 a.m., Paulo Zanoni wrote: > > Em seg, 2020-07-20 às 17:01 +0530, Karthik B S escreveu: > >> > >> diff --git a/drivers/gpu/drm/i915/i915_irq.c > >> b/drivers/gpu/drm/i915/i915_irq.c > >> index 1fa67700d8f4..95953b393941 10

Re: [PATCH 1/9] clk: qcom: gcc-sdm660: Add missing modem reset

2020-07-27 Thread Stephen Boyd
Quoting Konrad Dybcio (2020-07-26 04:11:58) > This will be required in order to support the > modem upstream. > > Signed-off-by: Konrad Dybcio > --- Applied to clk-next ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedeskto

Re: [PATCH 8/9] clk: qcom: gcc-sdm660: Fix up gcc_mss_mnoc_bimc_axi_clk

2020-07-27 Thread Stephen Boyd
Quoting Konrad Dybcio (2020-07-26 04:12:05) > Add missing halt_check, hwcg_reg and hwcg_bit properties. > These were likely omitted when porting the driver upstream. > > Signed-off-by: Konrad Dybcio > --- Applied to clk-next ___ dri-devel mailing list

[PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-27 Thread Roger Pau Monne
To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels without support for ZONE_DEVICE Xen will fallbac

Re: divide error in fbcon_switch

2020-07-27 Thread syzbot
syzbot suspects this issue was fixed by commit: commit ce684552a266cb1c7cc2f7e623f38567adec6653 Author: Tetsuo Handa Date: Sun Jul 12 11:10:12 2020 + vt: Reject zero-sized screen buffer size. bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=155549c490 start commit: 7

[PATCH 1/6] dt-bindings: display: Document NewVision NV3052C DT node

2020-07-27 Thread Paul Cercueil
Add documentation for the Device Tree node for LCD panels based on the NewVision NV3052C controller. Signed-off-by: Paul Cercueil --- .../display/panel/newvision,nv3052c.yaml | 69 +++ 1 file changed, 69 insertions(+) create mode 100644 Documentation/devicetree/bindings/di

  1   2   >