[Bug 206987] [drm] [amdgpu] Whole system crashes when the driver is in mode_support_and_system_configuration

2020-04-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206987 farmb...@googlemail.com changed: What|Removed |Added CC||farmb...@googlemail.com --- Com

[Bug 206987] [drm] [amdgpu] Whole system crashes when the driver is in mode_support_and_system_configuration

2020-04-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206987 --- Comment #8 from farmb...@googlemail.com --- Created attachment 288615 --> https://bugzilla.kernel.org/attachment.cgi?id=288615&action=edit smesg output -- You are receiving this mail because: You are watching the assignee of the bug. _

Re: [PATCH v2] dt-bindings: display: convert rockchip rk3066 hdmi bindings to yaml

2020-04-19 Thread Heiko Stuebner
Hi Johan, Am Freitag, 3. April 2020, 15:36:30 CEST schrieb Johan Jonker: > Current dts files with 'hdmi' nodes for rk3066 are manually verified. > In order to automate this process rockchip,rk3066-hdmi.txt > has to be converted to yaml. > > Signed-off-by: Johan Jonker > +++ > b/Documentation/d

Re: [PATCH v2] dt-bindings: display: convert rockchip rk3066 hdmi bindings to yaml

2020-04-19 Thread Heiko Stuebner
On Fri, 3 Apr 2020 15:36:30 +0200, Johan Jonker wrote: > Current dts files with 'hdmi' nodes for rk3066 are manually verified. > In order to automate this process rockchip,rk3066-hdmi.txt > has to be converted to yaml. > > Signed-off-by: Johan Jonker > Reviewed-by: Rob Herring > > [...] Applie

[Bug 207331] commit "drm/amdgpu: fix gfx hang during suspend with video playback" breaks reboot/shutdown

2020-04-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207331 hagar-du...@wanadoo.fr changed: What|Removed |Added CC||hagar-du...@wanadoo.fr --- Comme

Re: [PATCH 3/3] drm: pl111: Move VExpress setup into versatile init

2020-04-19 Thread Rob Herring
On Fri, Apr 17, 2020 at 3:27 PM Linus Walleij wrote: > > On Thu, Apr 9, 2020 at 3:39 AM Rob Herring wrote: > > > Since the VExpress setup in pl111_vexpress.c is now just a single > > function call, let's move it into pl111_versatile.c and we can further > > simplify pl111_versatile_init() by movi

Re: [PATCH 2/2] dt-bindings: Remove cases of 'allOf' containing a '$ref'

2020-04-19 Thread Stephen Boyd
Quoting Rob Herring (2020-04-15 17:55:49) > json-schema versions draft7 and earlier have a weird behavior in that > any keywords combined with a '$ref' are ignored (silently). The correct > form was to put a '$ref' under an 'allOf'. This behavior is now changed > in the 2019-09 json-schema spec and

Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers

2020-04-19 Thread Stephen Boyd
Quoting Hadar Gat (2020-04-16 02:49:03) > Both of_platform.h and of_device.h were included each other. > In of_device.h, removed unneeded #include to of_platform.h > and added include to of_platform.h in the files that needs it. > > Signed-off-by: Hadar Gat > --- Acked-by: Stephen Boyd # clk __

[Bug 205291] Cannot switch off Radeon HD 4330/4350/4550 with vgaswitcheroo

2020-04-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205291 Zhang Rui (rui.zh...@intel.com) changed: What|Removed |Added CC||rui.zh...@intel.com

linux-next: build failure after merge of the drm-misc tree

2020-04-19 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/video/fbdev/controlfb.c: In function 'controlfb_mmap': drivers/video/fbdev/controlfb.c:756:23: error: implicit declaration of function 'pgprot_cached_wthru'; did you mean 'pgprot_ca

Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers

2020-04-19 Thread kbuild test robot
Hi Hadar, Thank you for the patch! Yet something to improve: [auto build test ERROR on stm32/stm32-next] [also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1 next-20200416] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we

[drm-intel:topic/core-for-CI 18/20] init/Kconfig:80: symbol BROKEN is selected by DRM_I915_DEBUG

2020-04-19 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel topic/core-for-CI head: d0435a9b45070b945578c093dcd363b6b73a502c commit: 198db0fc276cdf8e1bb66a4a03473dbea1400d18 [18/20] Revert "drm/i915: Don't select BROKEN" config: powerpc-mvme5100_defconfig compiler: powerpc-linux-gcc (GCC) 9.3.0 reproduce:

Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers

2020-04-19 Thread kbuild test robot
Hi Hadar, Thank you for the patch! Yet something to improve: [auto build test ERROR on stm32/stm32-next] [also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1 next-20200416] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we

Re: [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

2020-04-19 Thread Philipp Rossak
Hi Nikolaus, Hi Maxime, TI SoC seem to be the broadest number of available users of sgx5xx in the past and nowadays. Others are more the exception. And maybe TI has some complicated stuff around the GPU that others don't have? Looks so. I can only agree on this. What I also assume is

[PATCH] drm/mediatek: stop iterating dma addresses when sg_dma_len() == 0

2020-04-19 Thread Anand K Mistry
If dma_map_sg() merges pages when creating the mapping, only the first entries will have a valid sg_dma_address() and sg_dma_len(), followed by entries with sg_dma_len() == 0. Signed-off-by: Anand K Mistry --- drivers/gpu/drm/mediatek/mtk_drm_gem.c | 3 +++ 1 file changed, 3 insertions(+) diff

[RESEND PATCH v4 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2020-04-19 Thread Lubomir Rintel
This is a driver for video encoder with VGA and DVI/HDMI outputs. There is no documentation for the chip -- the operation was guessed from what was sniffed on a Dell Wyse 3020 ThinOS terminal, the register names come from the ch7035 driver in Mediatek's GPL code dump. Only bare minimum is impleme

Re: [PATCH 2/8] fbdev/ARM: pxa: avoid selecting CONFIG_FB

2020-04-19 Thread Robert Jarzmik
Arnd Bergmann writes: > In order to add more compile-time dependencies to CONFIG_FB, remove the > last few instances of selecting it from platform code. > > This was originally written to allow a modular driver, but that never > worked because vmlinux cannot call exported functions from a loadabl

Re: [PATCH] drm/amdgpu: Reduce a lock scope in amdgpu_amdkfd_gpuvm_free_memory_of_gpu()

2020-04-19 Thread Markus Elfring
> Maybe we could reduce the mutex_lock(&mem->lock)`s protected code area, > and noneed to protect pr_debug. I suggest to improve the commit message. Would you like to adjust the patch subject? Do you imagine that data synchronisation should evolve in other ways? Regards, Markus _

Re: [PATCH 1/8] fbdev: w100fb: clean up mach-pxa compile-time dependency

2020-04-19 Thread Robert Jarzmik
Arnd Bergmann writes: Hi Arnd, > diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig > index f60bc29aef68..8444d40df1b3 100644 > --- a/arch/arm/mach-pxa/Kconfig > +++ b/arch/arm/mach-pxa/Kconfig > @@ -549,9 +549,6 @@ config MACH_ICONTROL > > config ARCH_PXA_ESERIES > bool

[PATCH v5 0/6] Support DRM bridges on NVIDIA Tegra

2020-04-19 Thread Dmitry Osipenko
Hello, This series adds initial support for the DRM bridges to NVIDIA Tegra DRM driver. This is required by newer device-trees where we model the LVDS encoder bridge properly. Changelog: v5: - Added new patches that make drm_of_find_panel_or_bridge() more usable if graph isn't defined in a

[PATCH v5 6/6] drm/tegra: output: rgb: Wrap directly-connected panel into DRM bridge

2020-04-19 Thread Dmitry Osipenko
Currently Tegra DRM driver manually manages display panel, but this management could be moved out into DRM core if we'll wrap panel into DRM bridge. This patch wraps RGB panel into a DRM bridge and removes manual handling of the panel from the RGB output code. Suggested-by: Laurent Pinchart Signe

[PATCH] drm/amd/display: remove unneeded conversion to bool

2020-04-19 Thread Jason Yan
The '==' expression itself is bool, no need to convert it to bool again. This fixes the following coccicheck warning: drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dpp_cm.c:485:66-71: WARNING: conversion to bool not needed here drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dpp_cm.c:896:68-73: WARNING: c

[PATCH v5 2/6] drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence

2020-04-19 Thread Dmitry Osipenko
When graph isn't defined in a device-tree, the of_graph_get_remote_node() prints a noisy error message, telling that port node is not found. This is undesirable behaviour in our case because absence of a panel/bridge graph is a valid case. Let's check presence of the local port in a device-tree bef

Re: Multiple regulators for one device [was drm/panfrost: add devfreq regulator support]

2020-04-19 Thread Clément Péron
Hi, On Fri, 17 Apr 2020 at 14:33, Clément Péron wrote: > > Hi Robin, > > On Fri, 17 Apr 2020 at 13:10, Robin Murphy wrote: > > > > On 2020-04-16 2:42 pm, Steven Price wrote: > > [...] > > > Perhaps a better approach would be for Panfrost to hand over the struct > > > regulator objects it has alr

Re: [PATCH v4] drm/i915: Synchronize active and retire callbacks

2020-04-19 Thread Sultan Alsawaf
Chris, Could you please look at this in earnest? This is a real bug that crashes my laptop without any kind of provocation. It is undeniably a bug in i915, and I've clearly described it in my patch. If you dont like the patch, I'm open to any suggestions you have for an alternative solution. My go

[PATCH] drm: amdgpu: fix kernel-doc struct warning

2020-04-19 Thread Randy Dunlap
Fix a kernel-doc warning of missing struct field desription: ../drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:92: warning: Function parameter or member 'vm' not described in 'amdgpu_vm_eviction_lock' Fixes: a269e44989f3 ("drm/amdgpu: Avoid reclaim fs while eviction lock") Signed-off-by: Randy Dunlap C

Re: [PATCH v2] dt-bindings: display: convert rockchip rk3066 hdmi bindings to yaml

2020-04-19 Thread Johan Jonker
Hi Heiko, On 4/19/20 2:08 PM, Heiko Stuebner wrote: > Hi Johan, > > Am Freitag, 3. April 2020, 15:36:30 CEST schrieb Johan Jonker: >> Current dts files with 'hdmi' nodes for rk3066 are manually verified. >> In order to automate this process rockchip,rk3066-hdmi.txt >> has to be converted to yaml.

Re:Re: [PATCH] drm/amdgpu: Reduce a lock scope in amdgpu_amdkfd_gpuvm_free_memory_of_gpu()

2020-04-19 Thread 赵军奎
From: Markus Elfring Date: 2020-04-19 17:05:07 To: Bernard Zhao ,amd-...@lists.freedesktop.org,dri-devel@lists.freedesktop.org,Alex Deucher ,"Christian König" ,Chunming Zhou ,"Felix Kühling" Cc: ker...@vivo.com,linux-ker...@vger.kernel.org,Daniel Vetter ,David Airlie Subject: Re: [PATCH

[PATCH] drm: amd: display: fix kernel-doc struct warning

2020-04-19 Thread Randy Dunlap
Fix a kernel-doc warning of missing struct field desription: ../drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:331: warning: Function parameter or member 'hdcp_workqueue' not described in 'amdgpu_display_manager' Fixes: 52704fcaf74b ("drm/amd/display: Initialize HDCP work queue") Signed-off-b

[PATCH v5 5/6] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-19 Thread Dmitry Osipenko
Newer Tegra device-trees will specify a video output graph, which involves LVDS encoder bridge. This patch adds support for the LVDS encoder bridge to the RGB output, allowing us to model the display hardware properly. Reviewed-by: Laurent Pinchart Signed-off-by: Dmitry Osipenko --- drivers/gpu

[RESEND PATCH v4 1/3] dt-bindings: Add vendor prefix for Chrontel, Inc.

2020-04-19 Thread Lubomir Rintel
Chrontel makes encoders for video displays and perhaps other stuff. Their web site is http://www.chrontel.com/. Signed-off-by: Lubomir Rintel Acked-by: Rob Herring --- Changes since v1: - Collect Rob's ack Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insert

Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()

2020-04-19 Thread Markus Elfring
> The "if(!encoder)" branch return the same value 0 of the success > branch, maybe return -EINVAL is more better. I suggest to improve the commit message. * Would you like to adjust the patch subject? * How do you think about to add the tag “Fixes” because of adjustments for the exception hand

Re: [PATCH] drm/amdgpu: Remove an unnecessary null pointer check in amdgpu_cs_bo_handles_chunk()

2020-04-19 Thread Markus Elfring
> kvfree ensure that the null pointer will do nothing. I suggest to improve the commit message. Would you like to adjust the patch subject? Are you looking for further questionable condition checks? … > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > @@ -98,8 +98,7 @@ static int amdgpu_cs_bo_han

Re:Re: [PATCH] drm/amdgpu: Remove an unnecessary condition check in reserve_bo_and_cond_vms()

2020-04-19 Thread 赵军奎
发件人:Markus Elfring 发送日期:2020-04-19 02:18:06 收件人:Bernard Zhao ,Alex Deucher ,"Christian König" ,amd-...@lists.freedesktop.org,dri-devel@lists.freedesktop.org 抄送人:"Felix Kühling" ,linux-ker...@vger.kernel.org,opensource.ker...@vivo.com,Chunming Zhou ,Daniel Vetter ,David Airlie 主题:Re: [PAT

[RESEND PATCH v4 2/3] dt-bindings: display: Add Chrontel CH7033 Video Encoder binding

2020-04-19 Thread Lubomir Rintel
Add binding document for the Chrontel CH7033 VGA/DVI/HDMI Encoder. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v3: - Fixed the example so that it validates Changes since v1: - Dual licensed with BSD-2-Clause - Collected Rob's reviewed-by tag .../display/bridge/ch

[RESEND PATCH v4 0/3] drm: Add support for Chrontel CH7033 VGA/DVI Encoder

2020-04-19 Thread Lubomir Rintel
Hi, chained to this message is resend of v4 [1] of a driver for CH7033. Please consider enqueing it for 5.8. [1] https://lore.kernel.org/lkml/20200324151931.449985-1-lkund...@v3.sk/ Thanks, Lubo ___ dri-devel mailing list dri-devel@lists.freedeskto

Re: [PATCH] drm/amdgpu: Remove an unnecessary condition check in reserve_bo_and_cond_vms()

2020-04-19 Thread Markus Elfring
> There is no need to if check again, Thanks for this information. * Should the function name be mentioned in this change description? * Would you like to adjust the patch subject? > maybe we could merge into the above else branch. I suggest to reconsider this wording. … > +++ b/drivers/gpu

[PATCH v5 1/6] of_graph: add of_graph_get_local_port()

2020-04-19 Thread Dmitry Osipenko
In some case, like a DRM display code for example, it's useful to silently check whether port node exists at all in a device-tree before proceeding with parsing the graph. This patch adds of_graph_get_local_port() which returns pointer to a local port node, or NULL if graph isn't specified in a de

[PATCH v5 3/6] drm/tegra: output: Don't leak OF node on error

2020-04-19 Thread Dmitry Osipenko
The OF node should be put before returning error in tegra_output_probe(), otherwise node's refcount will be leaked. Reviewed-by: Laurent Pinchart Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/output.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/driver

[PATCH] amdgpu_cs_bo_handles_chunk, remove check info NULL branch

2020-04-19 Thread Bernard Zhao
kvfree ensure that the null pointer will do nothing. If addr is NULL, first is_vmalloc_addr will not enter, and kfree function just return when addr is NULL. There will be no risk here. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 +-- 1 file changed, 1 insertion(+)

Re:Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()

2020-04-19 Thread 赵军奎
发件人:Markus Elfring 发送日期:2020-04-19 17:34:47 收件人:Bernard Zhao ,amd-...@lists.freedesktop.org,dri-devel@lists.freedesktop.org,Alex Deucher ,"Christian König" ,Chunming Zhou 抄送人:Andrzej Pietrasiewicz ,Daniel Vetter ,David Airlie ,Dhinakaran Pandiyan ,"José Roberto de Souza" ,Lyude Paul ,Neil

[PATCH v5 4/6] drm/tegra: output: Support DRM bridges

2020-04-19 Thread Dmitry Osipenko
Newer Tegra device-trees will specify a video output graph which involves a bridge. This patch adds initial support for the DRM bridges to the Tegra DRM output. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/drm.h| 2 ++ drivers/gpu/drm/tegra/output.c | 12 2 files ch

Re: [PATCH v4 2/3] drm/tegra: output: Support DRM bridges

2020-04-19 Thread Dmitry Osipenko
17.04.2020 23:58, Laurent Pinchart пишет: > Hi Dmitry, > > On Fri, Apr 17, 2020 at 11:52:11PM +0300, Dmitry Osipenko wrote: >> 17.04.2020 23:31, Laurent Pinchart пишет: >>> On Fri, Apr 17, 2020 at 10:41:59PM +0300, Dmitry Osipenko wrote: 17.04.2020 22:30, Laurent Pinchart пишет: ...