发件人：Markus Elfring <markus.elfr...@web.de> 发送日期：2020-04-19 17:34:47 收件人：Bernard Zhao <bern...@vivo.com>,amd-...@lists.freedesktop.org,dri-devel@lists.freedesktop.org,Alex Deucher <alexander.deuc...@amd.com>,"Christian König" <christian.koe...@amd.com>,Chunming Zhou <david1.z...@amd.com> 抄送人：Andrzej Pietrasiewicz <andrze...@collabora.com>,Daniel Vetter <dan...@ffwll.ch>,David Airlie <airl...@linux.ie>,Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com>,"José Roberto de Souza" <jose.so...@intel.com>,Lyude Paul <ly...@redhat.com>,Neil Armstrong <narmstr...@baylibre.com>,Sam Ravnborg <s...@ravnborg.org>,linux-ker...@vger.kernel.org,opensource.ker...@vivo.com 主题：Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()>> The "if(!encoder)" branch return the same value 0 of the success >> branch, maybe return -EINVAL is more better. > >I suggest to improve the commit message.
Sure. > >* Would you like to adjust the patch subject? > >* How do you think about to add the tag “Fixes” > because of adjustments for the exception handling? This is a good idea, the code will be more in line with the Linux specifications. I will adjust this patch commit message and modify the code. I will submit it again. > >Regards, >Markus _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
