Re: [PATCH v2 05/18] mm/gup: introduce pin_user_pages*() and FOLL_PIN

2019-11-07 Thread Mike Rapoport
On Tue, Nov 05, 2019 at 11:00:06AM -0800, John Hubbard wrote: > On 11/5/19 5:10 AM, Mike Rapoport wrote: > ... > >> --- > >> Documentation/vm/index.rst | 1 + > >> Documentation/vm/pin_user_pages.rst | 212 ++ > > > > I think it belongs to Documentation/core-api. >

[PULL] drm-misc-fixes

2019-11-07 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week PR for drm-misc-fixes. Thanks! Maxime drm-misc-fixes-2019-11-07-1: - Some new documentation for GEM shmem madvise helpers - Fix for a state dereference in atomic self-refresh helpers - One compilation fix for c2p fbdev helpers The following changes since comm

Re: [PATCHv2 1/4] drm/arm: Factor out generic afbc helpers

2019-11-07 Thread Daniel Vetter
On Wed, Nov 06, 2019 at 01:45:05PM +0100, Andrzej Pietrasiewicz wrote: > Hi Daniel, > > Thank you for review, > > W dniu 05.11.2019 o 10:22, Daniel Vetter pisze: > > On Mon, Nov 04, 2019 at 11:12:25PM +0100, Andrzej Pietrasiewicz wrote: > > > These are useful for other users of afbc, e.g. rockchi

Re: [PATCH 2/2] drm/gma500: Add page flip support on psb/cdv

2019-11-07 Thread Daniel Vetter
On Wed, Nov 06, 2019 at 04:24:59PM +0100, Patrik Jakobsson wrote: > On Wed, Nov 6, 2019 at 10:44 AM Paul Kocialkowski > wrote: > > > > Legacy (non-atomic) page flip support is added to the driver by using the > > mode_set_base CRTC function, that allows configuring a new framebuffer for > > displa

[PATCH v2 3/9] drm/ast: Don't clear base address and offset with default values

2019-11-07 Thread Thomas Zimmermann
The content of the base-address and offset registers are state of the primary plane. Clearing it to default values will interfere with plane functions for atomic mode setting. Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/ast/ast_mode.c | 8 ++-- 1 file change

[PATCH v2 4/9] drm/ast: Split ast_set_ext_reg() into color and threshold function

2019-11-07 Thread Thomas Zimmermann
In ast_set_ext_reg() sets several framebuffer options and CRT threshold parameters. The former is mostly state of the primary plane; the latter is constant. Hence, split the function in two and make it work with atomic modesetting. Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- dr

Re: [RFC PATCH 05/12] video: fbdev: matrox: convert to i2c_new_scanned_device

2019-11-07 Thread Daniel Vetter
On Wed, Nov 06, 2019 at 10:50:23AM +0100, Wolfram Sang wrote: > Move from the deprecated i2c_new_probed_device() to the new > i2c_new_scanned_device(). Make use of the new ERRPTR if suitable. > > Signed-off-by: Wolfram Sang Ack for merging through whatever tree you think this should best land th

[PATCH v2 7/9] drm/ast: Add CRTC helpers for atomic modesetting

2019-11-07 Thread Thomas Zimmermann
As the CRTC code has already been prepared for a split between mode setting and plane handling, most of the CRTC's atomic modesetting is build upon primitives of the non-atomic implementation. Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/ast/ast_mode.c | 105

[PATCH v2 9/9] drm/ast: Enable atomic modesetting

2019-11-07 Thread Thomas Zimmermann
This commit sets the remaining atomic-modesetting helpers and the flag DRIVER_ATOMIC. Legacy cursor functions are removed in favor of the cursor plane. For power management, atomic helpers replace the indvidual operations that the driver currently runs. Atomic modesetting is enabled with this comm

[PATCH v2 5/9] drm/ast: Split ast_set_vbios_mode_info()

2019-11-07 Thread Thomas Zimmermann
The implementation of ast_set_vbios_mode() converts a DRM display mode and framebuffer into an adjusted mode and stores information for the video BIOS to several scratch regsiters. Here we split the function into individual functions that do the conversion, set the VBIOS mode information and forma

[PATCH v2 6/9] drm/ast: Add primary plane

2019-11-07 Thread Thomas Zimmermann
Like the original mode-setting code, the primary plane supports XRGB888, RGB565 and C8. The plane itself only pins BOs and sets the base address and scanline offset. The mode-setting code will be located in the CRTC's atomic helpers. v2: * don't set plane call-back functions to NULL explic

[PATCH v2 2/9] drm/ast: Check video-mode requirements against VRAM size

2019-11-07 Thread Thomas Zimmermann
Each video mode's primary plane requires a minimum amount of video memory. For double buffering, this is at most half the available VRAM. Check this constraint. Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/ast/ast_main.c | 25 - 1 file cha

[PATCH v2 8/9] drm/ast: Add cursor plane

2019-11-07 Thread Thomas Zimmermann
The cursor plane uses an internal format of ARGB. To userspace, we announce ARGB and do the transformation internally. v2: * don't set plane call-back functions to NULL explicitly * define plane format array in global scope Signed-off-by: Thomas Zimmermann --- drivers/gp

[PATCH v2 1/9] drm/ast: Remove last traces of struct ast_gem_object

2019-11-07 Thread Thomas Zimmermann
The ast driver has switched to struct drm_vram_gem_object a while ago. This patch removes a function and forward declaration that were forgotten before. Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/ast/ast_drv.h | 6 -- drivers/gpu/drm/ast/ast_main.c | 24 -

[PATCH v2 0/9] drm/ast: Convert to atomic modesetting

2019-11-07 Thread Thomas Zimmermann
This patch set adds universal planes to ast and converts the driver to atomic modesetting. The first patch is purely for clean-up. Patches 2 to 5 prepare the ast modesetting code for universal planes and atomic modesetting. The size calculation for each mode has to take double buffering into acco

Re: [PATCH v3 1/5] drm: Move EXPORT_SYMBOL_FOR_TESTS_ONLY under a separate Kconfig

2019-11-07 Thread Daniel Vetter
On Wed, Nov 06, 2019 at 02:24:28PM +, Chris Wilson wrote: > Currently, we only export symbols for drm-selftests which are either > compiled as modules or into the main drm builtin. However, if we want to > export symbols from drm.ko for the drivers' selftests, we require a > means of controllin

Re: [PATCH v3 2/5] drm: Expose a method for creating anonymous struct file around drm_minor

2019-11-07 Thread Daniel Vetter
On Wed, Nov 06, 2019 at 02:24:29PM +, Chris Wilson wrote: > Sometimes we need to create a struct file to wrap a drm_device, as it > the user were to have opened /dev/dri/card0 but to do so anonymously > (i.e. for internal use). Provide a utility method to create a struct > file with the drm_dev

Re: [Intel-gfx] [PATCH v3 3/5] drm/i915/selftests: Replace mock_file hackery with drm's true fake

2019-11-07 Thread Daniel Vetter
On Wed, Nov 06, 2019 at 02:24:30PM +, Chris Wilson wrote: > As drm now exports a method to create an anonymous struct file around a > drm_device for internal use, make use of it to avoid our horrible hacks. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/Kconfig.debug

[PATCH v7 4/8] mm: Add write-protect and clean utilities for address space ranges

2019-11-07 Thread VMware
From: Thomas Hellstrom Add two utilities to 1) write-protect and 2) clean all ptes pointing into a range of an address space. The utilities are intended to aid in tracking dirty pages (either driver-allocated system memory or pci device memory). The write-protect utility should be used in conjunc

[PATCH v7 1/8] mm: Remove BUG_ON mmap_sem not held from xxx_trans_huge_lock()

2019-11-07 Thread VMware
From: Thomas Hellstrom The caller needs to make sure that the vma is not torn down during the lock operation and can also use the i_mmap_rwsem for file-backed vmas. Remove the BUG_ON. We could, as an alternative, add a test that either vma->vm_mm->mmap_sem or vma->vm_file->f_mapping->i_mmap_rwsem

[PATCH v7 3/8] mm: Add a walk_page_mapping() function to the pagewalk code

2019-11-07 Thread VMware
From: Thomas Hellstrom For users that want to travers all page table entries pointing into a region of a struct address_space mapping, introduce a walk_page_mapping() function. The walk_page_mapping() function will be initially be used for dirty- tracking in virtual graphics drivers. Cc: Andrew

[PATCH v7 2/8] mm: pagewalk: Take the pagetable lock in walk_pte_range()

2019-11-07 Thread VMware
From: Thomas Hellstrom Without the lock, anybody modifying a pte from within this function might have it concurrently modified by someone else. Cc: Matthew Wilcox Cc: Will Deacon Cc: Peter Zijlstra Cc: Rik van Riel Cc: Minchan Kim Cc: Michal Hocko Cc: Huang Ying Cc: Jérôme Glisse Cc: Kir

[PATCH v7 7/8] drm/vmwgfx: Implement an infrastructure for read-coherent resources

2019-11-07 Thread VMware
From: Thomas Hellstrom Similar to write-coherent resources, make sure that from the user-space point of view, GPU rendered contents is automatically available for reading by the CPU. Cc: Andrew Morton Cc: Matthew Wilcox Cc: Will Deacon Cc: Peter Zijlstra Cc: Rik van Riel Cc: Minchan Kim Cc

[PATCH v7 6/8] drm/vmwgfx: Use an RBtree instead of linked list for MOB resources

2019-11-07 Thread VMware
From: Thomas Hellstrom With emulated coherent memory we need to be able to quickly look up a resource from the MOB offset. Instead of traversing a linked list with O(n) worst case, use an RBtree with O(log n) worst case complexity. Cc: Andrew Morton Cc: Matthew Wilcox Cc: Will Deacon Cc: Pete

[PATCH v7 8/8] drm/vmwgfx: Add surface dirty-tracking callbacks

2019-11-07 Thread VMware
From: Thomas Hellstrom Add the callbacks necessary to implement emulated coherent memory for surfaces. Add a flag to the gb_surface_create ioctl to indicate that surface memory should be coherent. Also bump the drm minor version to signal the availability of coherent surfaces. Cc: Andrew Morton

[PATCH v7 5/8] drm/vmwgfx: Implement an infrastructure for write-coherent resources

2019-11-07 Thread VMware
From: Thomas Hellstrom This infrastructure will, for coherent resources, make sure that from the user-space point of view, data written by the CPU is immediately automatically available to the GPU at resource validation time. Cc: Andrew Morton Cc: Matthew Wilcox Cc: Will Deacon Cc: Peter Zijl

[PATCH v7 0/8] Emulated coherent graphics memory take 2

2019-11-07 Thread VMware
From: Thomas Hellström Graphics APIs like OpenGL 4.4 and Vulkan require the graphics driver to provide coherent graphics memory, meaning that the GPU sees any content written to the coherent memory on the next GPU operation that touches that memory, and the CPU sees any content written by the GPU

Re: [PATCH V9 0/6] mdev based hardware virtio offloading support

2019-11-07 Thread Michael S. Tsirkin
On Wed, Nov 06, 2019 at 03:05:42PM +0800, Jason Wang wrote: > Hi all: > > There are hardwares that can do virtio datapath offloading while > having its own control path. This path tries to implement a mdev based > unified API to support using kernel virtio driver to drive those > devices. This is

Re: [PATCH 2/2] drm/gma500: Add page flip support on psb/cdv

2019-11-07 Thread Patrik Jakobsson
On Thu, Nov 7, 2019 at 9:31 AM Daniel Vetter wrote: > > On Wed, Nov 06, 2019 at 04:24:59PM +0100, Patrik Jakobsson wrote: > > On Wed, Nov 6, 2019 at 10:44 AM Paul Kocialkowski > > wrote: > > > > > > Legacy (non-atomic) page flip support is added to the driver by using the > > > mode_set_base CRTC

Re: [PATCH V10 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-07 Thread Michael S. Tsirkin
On Wed, Nov 06, 2019 at 09:35:31PM +0800, Jason Wang wrote: > This sample driver creates mdev device that simulate virtio net device > over virtio mdev transport. The device is implemented through vringh > and workqueue. A device specific dma ops is to make sure HVA is used > directly as the IOVA.

Re: [PATCH V10 0/6] mdev based hardware virtio offloading support

2019-11-07 Thread Michael S. Tsirkin
On Wed, Nov 06, 2019 at 09:35:25PM +0800, Jason Wang wrote: > Hi all: > > There are hardwares that can do virtio datapath offloading while > having its own control path. This path tries to implement a mdev based > unified API to support using kernel virtio driver to drive those > devices. This is

Re: [PATCH v2 6/9] drm/ast: Add primary plane

2019-11-07 Thread Gerd Hoffmann
On Thu, Nov 07, 2019 at 09:34:01AM +0100, Thomas Zimmermann wrote: > Like the original mode-setting code, the primary plane supports XRGB888, > RGB565 and C8. The plane itself only pins BOs and sets the base address > and scanline offset. The mode-setting code will be located in the CRTC's > atomic

Re: [PATCH 2/2] drm/gma500: Add page flip support on psb/cdv

2019-11-07 Thread Daniel Vetter
On Thu, Nov 7, 2019 at 10:08 AM Patrik Jakobsson wrote: > > On Thu, Nov 7, 2019 at 9:31 AM Daniel Vetter wrote: > > > > On Wed, Nov 06, 2019 at 04:24:59PM +0100, Patrik Jakobsson wrote: > > > On Wed, Nov 6, 2019 at 10:44 AM Paul Kocialkowski > > > wrote: > > > > > > > > Legacy (non-atomic) page

Re: [PATCH v2 8/9] drm/ast: Add cursor plane

2019-11-07 Thread Gerd Hoffmann
On Thu, Nov 07, 2019 at 09:34:03AM +0100, Thomas Zimmermann wrote: > The cursor plane uses an internal format of ARGB. To userspace, we > announce ARGB and do the transformation internally. > > v2: > * don't set plane call-back functions to NULL explicitly > * define plane form

Re: [PATCH 1/4] Revert "drm/amdgpu: dont schedule jobs while in reset"

2019-11-07 Thread Koenig, Christian
Am 06.11.19 um 18:51 schrieb Andrey Grodzovsky: > This reverts commit 3cdf9bd0089723c468d5f6240e54d1afa52e9a04. > > We will do a proper fix in next patch. > > Signed-off-by: Andrey Grodzovsky The order of this one and patch #2 needs to be swapped, or otherwise we have the bug in between those tw

Re: [PATCH v2 4/4] drm/udl: Remove struct udl_gem_object and functions

2019-11-07 Thread Thomas Zimmermann
Hi Noralf Am 06.11.19 um 12:48 schrieb Noralf Trønnes: > > > Den 06.11.2019 11.47, skrev Thomas Zimmermann: >> Simply removes all the obsolete GEM code from udl. No functional >> changes. >> >> Signed-off-by: Thomas Zimmermann >> --- >> drivers/gpu/drm/udl/Makefile | 2 +- >> drivers/gpu

Re: [PATCH v2 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER

2019-11-07 Thread Jürgen Groß
On 28.10.19 21:10, Jason Gunthorpe wrote: From: Jason Gunthorpe DMA_SHARED_BUFFER can not be enabled by the user (it represents a library set in the kernel). The kconfig convention is to use select for such symbols so they are turned on implicitly when the user enables a kconfig that needs them

[PATCH v3 1/4] drm/udl: Remove flags field from struct udl_gem_object

2019-11-07 Thread Thomas Zimmermann
The flags field in struct udl_gem controls mapping parameters: cached access for local buffers, write-combined access for imported buffers. We can drop the field and distinguish both cases by testing whether struct drm_gem_object.import_attach is NULL. Signed-off-by: Thomas Zimmermann Acked-by:

[PATCH v3 3/4] drm/udl: Switch to SHMEM

2019-11-07 Thread Thomas Zimmermann
Udl's GEM code and the generic SHMEM are almost identical. Replace the former with SHMEM. The dmabuf support in udl is being replaced with generic GEM PRIME functions. The main difference is in the caching flags for mmap pages. By default, SHMEM always sets (uncached) write combining. In udl's mem

[PATCH v3 2/4] drm/udl: Allocate GEM object via struct drm_driver.gem_create_object

2019-11-07 Thread Thomas Zimmermann
In preparation of a switch to SHMEM, udl now allocates its GEM objects via struct drm_driver.gem_create_object. No functional changes are made. For SHMEM GEM objects, udl will require the use of a special mmap function, which we set though the create-object function. Signed-off-by: Thomas Zimmerm

[PATCH v3 0/4] drm/udl: Convert to SHMEM

2019-11-07 Thread Thomas Zimmermann
Udl's GEM implementation is mostly SHMEM and we should attempt to replace it with the latter. Patches #1 and #2 update udl to simplify the conversion. In patch #3 the udl code is being replaced by SHMEM. The GEM object's mmap() and free_object() functions are wrappers around their SHMEM counterpar

[PATCH v3 4/4] drm/udl: Remove struct udl_gem_object and functions

2019-11-07 Thread Thomas Zimmermann
Simply removes all the obsolete GEM code from udl. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/udl/Makefile | 2 +- drivers/gpu/drm/udl/udl_dmabuf.c | 254 --- drivers/gpu/drm/udl/udl_drv.h| 29

Re: [PATCH 2/2] drm/gma500: Add page flip support on psb/cdv

2019-11-07 Thread Patrik Jakobsson
On Thu, Nov 7, 2019 at 10:21 AM Daniel Vetter wrote: > > On Thu, Nov 7, 2019 at 10:08 AM Patrik Jakobsson > wrote: > > > > On Thu, Nov 7, 2019 at 9:31 AM Daniel Vetter wrote: > > > > > > On Wed, Nov 06, 2019 at 04:24:59PM +0100, Patrik Jakobsson wrote: > > > > On Wed, Nov 6, 2019 at 10:44 AM Pau

Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output

2019-11-07 Thread Joe Perches
On Thu, 2019-11-07 at 12:29 +0300, Wambui Karuga wrote: > Replace the use of the dev_err macro with the DRM_DEV_ERROR > DRM helper macro. The commit message should show the reason _why_ you are doing this instead of just stating that you are doing this. It's not that dev_err is uncommon in driver

Re: [PATCH v2] drm: atomic helper: fix W=1 warnings

2019-11-07 Thread Benjamin Gaignard
Le mar. 22 oct. 2019 à 10:37, Daniel Vetter a écrit : > > On Tue, Oct 08, 2019 at 02:42:54PM +0200, Benjamin Gaignard wrote: > > Few for_each macro set variables that are never used later which led > > to generate unused-but-set-variable warnings. > > Add (void)(foo) inside the macros to remove th

Re: [PATCH V10 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-07 Thread Jason Wang
On 2019/11/7 下午5:08, Michael S. Tsirkin wrote: On Wed, Nov 06, 2019 at 09:35:31PM +0800, Jason Wang wrote: This sample driver creates mdev device that simulate virtio net device over virtio mdev transport. The device is implemented through vringh and workqueue. A device specific dma ops is to m

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #132 from har...@gmx.de --- (In reply to Wilko Bartels from comment #131) > Thank you. I already tried exactly that. And the unit unable to autostart > (permission denied). Only manual systemctl start works. Dont know why. If you do

Re: [GIT PULL FOR v5.5 - 2nd try] R-Car DU CMM support

2019-11-07 Thread Jacopo Mondi
Hi Laurent, On Wed, Nov 06, 2019 at 02:56:53PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > On Wed, Nov 06, 2019 at 02:52:25PM +0200, Laurent Pinchart wrote: > > On Wed, Nov 06, 2019 at 11:46:28AM +0100, Jacopo Mondi wrote: > > > On Wed, Nov 06, 2019 at 12:02:05PM +0200, Laurent Pinchart wrote:

Re: [PATCH libdrm v2] modetest: Add support for setting mode having floating vertical refresh rate

2019-11-07 Thread Ville Syrjälä
On Wed, Nov 06, 2019 at 07:35:36AM -0800, Devarsh Thakkar wrote: > For the scenario where user may require to modeset with a mode > supporting a fractional value for vertical refresh-rate, > appropriate mode can be selected by searching for mode > having matching fractional vertical refresh rate us

Re: [PATCH V10 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-07 Thread Michael S. Tsirkin
On Thu, Nov 07, 2019 at 06:18:45PM +0800, Jason Wang wrote: > > On 2019/11/7 下午5:08, Michael S. Tsirkin wrote: > > On Wed, Nov 06, 2019 at 09:35:31PM +0800, Jason Wang wrote: > > > This sample driver creates mdev device that simulate virtio net device > > > over virtio mdev transport. The device i

Re: [PATCH] drm/i915: Try to re-use GOP / previous M-N-P settings for vlv DSI PLL

2019-11-07 Thread Ville Syrjälä
On Sun, Oct 20, 2019 at 08:21:32PM +0200, Hans de Goede wrote: > Fastboot is not working on an Asus T100HA, it gives the following > relevant messages / errors: > > dsi pll div 000201e6, ctrl 80080100 > fastset mismatch in dsi_pll.ctrl (expected 0x80100100, found 0x80080100) > fastset mismatch

Re: [Intel-gfx] [PATCH] drm/i915: Try to re-use GOP / previous M-N-P settings for vlv DSI PLL

2019-11-07 Thread Daniel Vetter
On Thu, Nov 7, 2019 at 12:24 PM Ville Syrjälä wrote: > > On Sun, Oct 20, 2019 at 08:21:32PM +0200, Hans de Goede wrote: > > Fastboot is not working on an Asus T100HA, it gives the following > > relevant messages / errors: > > > > dsi pll div 000201e6, ctrl 80080100 > > fastset mismatch in dsi_pl

[PATCH v2 2/5] drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT

2019-11-07 Thread Mihail Atanassov
Now that there's a debugfs node to control the same, remove the config option. Reviewed-by: James Qian Wang (Arm Technology China) Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/display/Kconfig | 6 -- drivers/gpu/drm/arm/display/komeda/Makefile | 5 ++--- drivers/g

[PATCH v2 1/5] drm/komeda: Add debugfs node to control error verbosity

2019-11-07 Thread Mihail Atanassov
Named 'err_verbosity', currently with only 1 active bit in that replicates the existing level - print error events once per flip. Reviewed-by: James Qian Wang (Arm Technology China) Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 4 drivers/gpu/drm/

[PATCH v2 0/5] drm/komeda: Improve IRQ error event prints

2019-11-07 Thread Mihail Atanassov
Hi everyone, Sending out a v2 of the series since I had missed out a couple of issues checkpatch caught. Changes since v1 [https://patchwork.freedesktop.org/series/68325/]: - Fixed a couple of checkpatch issues in 2/5 and 5/5 v1's cover letter: This is a smallish series that tries to remove so

[PATCH v2 5/5] drm/komeda: add rate limiting disable to err_verbosity

2019-11-07 Thread Mihail Atanassov
It's possible to get multiple events in a single frame/flip, so add an option to print them all. Reviewed-by: James Qian Wang (Arm Technology China) Signed-off-by: Mihail Atanassov --- v2: Clean up continuation line warning from checkpatch. drivers/gpu/drm/arm/display/komeda/komeda_dev.h |

[PATCH v2 4/5] drm/komeda: Add option to print WARN- and INFO-level IRQ events

2019-11-07 Thread Mihail Atanassov
Extra detail (normally off) almost never hurts. Reviewed-by: James Qian Wang (Arm Technology China) Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 11 +++ drivers/gpu/drm/arm/display/komeda/komeda_event.c | 4 2 files changed, 15 insertions

[PATCH v2 3/5] drm/komeda: Optionally dump DRM state on interrupts

2019-11-07 Thread Mihail Atanassov
It's potentially useful information when diagnosing error/warn IRQs, so dump it to dmesg with a drm_info_printer. Hide this extra debug dumping behind another komeda_dev->err_verbosity bit. Note that there's not much sense in dumping it for INFO events, since the VSYNC event will swamp the log. R

[PATCH 2/2] drm/radeon: finally fix the racy VMA setup

2019-11-07 Thread Christian König
From: Christian König Finally clean up the VMA setup for radeon now that TTM exports the necessary functions. No functional change, but only compile tested. Signed-off-by: Christian König Reviewed-by: Huang Rui --- drivers/gpu/drm/radeon/radeon_ttm.c | 29 ++--- 1 fil

[PATCH 1/2] drm/ttm: also export ttm_bo_vm_fault v2

2019-11-07 Thread Christian König
From: Christian König That is needed by at least a cleanup in radeon. v2: also export ttm_bo_vm_access Signed-off-by: Christian König Reviewed-by: Huang Rui --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 8 +--- include/drm/ttm/ttm_bo_api.h| 6 ++ 2 files changed, 11 insertions(+), 3 dele

Re: [PATCH 2/2] drm/radeon: finally fix the racy VMA setup

2019-11-07 Thread Christian König
Hey Alex, any objections that I merge those two patches through drm-misc-next? It's a cleanup I wanted to do for years and Thomas finally fixed up TTM for this. Cheers, Christian. Am 07.11.19 um 13:01 schrieb Christian König: From: Christian König Finally clean up the VMA setup for radeon

[Bug 110823] [Intel-GFX-CI][BAT] igt@amdgpu/amd_basic@userptr - fail - Failed assertion: r == 0

2019-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110823 Chris Wilson changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH V10 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-07 Thread Jason Wang
On 2019/11/7 下午7:21, Michael S. Tsirkin wrote: On Thu, Nov 07, 2019 at 06:18:45PM +0800, Jason Wang wrote: On 2019/11/7 下午5:08, Michael S. Tsirkin wrote: On Wed, Nov 06, 2019 at 09:35:31PM +0800, Jason Wang wrote: This sample driver creates mdev device that simulate virtio net device over vir

Re: [PATCH V10 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-07 Thread Jason Wang
On 2019/11/7 下午8:43, Jason Wang wrote: On 2019/11/7 下午7:21, Michael S. Tsirkin wrote: On Thu, Nov 07, 2019 at 06:18:45PM +0800, Jason Wang wrote: On 2019/11/7 下午5:08, Michael S. Tsirkin wrote: On Wed, Nov 06, 2019 at 09:35:31PM +0800, Jason Wang wrote: This sample driver creates mdev device

Re: [PATCH V10 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-07 Thread Michael S. Tsirkin
On Thu, Nov 07, 2019 at 08:47:06PM +0800, Jason Wang wrote: > > On 2019/11/7 下午8:43, Jason Wang wrote: > > > > On 2019/11/7 下午7:21, Michael S. Tsirkin wrote: > > > On Thu, Nov 07, 2019 at 06:18:45PM +0800, Jason Wang wrote: > > > > On 2019/11/7 下午5:08, Michael S. Tsirkin wrote: > > > > > On Wed,

Re: [PATCH V10 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-07 Thread Michael S. Tsirkin
On Thu, Nov 07, 2019 at 08:43:29PM +0800, Jason Wang wrote: > > On 2019/11/7 下午7:21, Michael S. Tsirkin wrote: > > On Thu, Nov 07, 2019 at 06:18:45PM +0800, Jason Wang wrote: > > > On 2019/11/7 下午5:08, Michael S. Tsirkin wrote: > > > > On Wed, Nov 06, 2019 at 09:35:31PM +0800, Jason Wang wrote: >

Re: Drm: mgag200. Video adapter issue with 5.4.0-rc3 ; no graphics

2019-11-07 Thread John Donnelly
Hi Thomas ; Thank you for reaching out. See inline: > On Nov 7, 2019, at 1:54 AM, Thomas Zimmermann wrote: > > Hi John, > > apparently the vgaarb was not the problem. > > Am 07.11.19 um 03:29 schrieb John Donnelly: >> Hi, >> >> I am investigating an issue where we lose video activity wh

Re: [GIT PULL FOR v5.5 - 2nd try] R-Car DU CMM support

2019-11-07 Thread Laurent Pinchart
Hi Jacopo, On Thu, Nov 07, 2019 at 12:13:35PM +0100, Jacopo Mondi wrote: > On Wed, Nov 06, 2019 at 02:56:53PM +0200, Laurent Pinchart wrote: > > On Wed, Nov 06, 2019 at 02:52:25PM +0200, Laurent Pinchart wrote: > >> On Wed, Nov 06, 2019 at 11:46:28AM +0100, Jacopo Mondi wrote: > >>> On Wed, Nov 06

Re: [PATCH v2 1/5] drm/dsi: clean up DSI data type definitions

2019-11-07 Thread Jani Nikula
On Mon, 04 Nov 2019, Jani Nikula wrote: > Hi all, I'd really appreciate some (non-Intel) acks or reviews on this > series. Don't feel comfortable merging it otherwise. It should be fairly > straightforward stuff as long as you have some DSI specs handy. Thanks for the reviews. I've pushed the pat

Re: [PATCH V10 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-07 Thread Jason Wang
On 2019/11/7 下午9:08, Michael S. Tsirkin wrote: On Thu, Nov 07, 2019 at 08:43:29PM +0800, Jason Wang wrote: On 2019/11/7 下午7:21, Michael S. Tsirkin wrote: On Thu, Nov 07, 2019 at 06:18:45PM +0800, Jason Wang wrote: On 2019/11/7 下午5:08, Michael S. Tsirkin wrote: On Wed, Nov 06, 2019 at 09:35:3

Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output

2019-11-07 Thread Sean Paul
On Thu, Nov 07, 2019 at 01:54:22AM -0800, Joe Perches wrote: > On Thu, 2019-11-07 at 12:29 +0300, Wambui Karuga wrote: > > Replace the use of the dev_err macro with the DRM_DEV_ERROR > > DRM helper macro. > > The commit message should show the reason _why_ you are doing > this instead of just stat

Re: [PATCH V10 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-07 Thread Jason Wang
On 2019/11/7 下午9:08, Michael S. Tsirkin wrote: On Thu, Nov 07, 2019 at 08:47:06PM +0800, Jason Wang wrote: On 2019/11/7 下午8:43, Jason Wang wrote: On 2019/11/7 下午7:21, Michael S. Tsirkin wrote: On Thu, Nov 07, 2019 at 06:18:45PM +0800, Jason Wang wrote: On 2019/11/7 下午5:08, Michael S. Tsirkin

Re: Drm: mgag200. Video adapter issue with 5.4.0-rc3 ; no graphics

2019-11-07 Thread Thomas Zimmermann
Hi John Am 07.11.19 um 14:12 schrieb John Donnelly: > Hi Thomas ; Thank you for reaching out. > > See inline: > >> On Nov 7, 2019, at 1:54 AM, Thomas Zimmermann wrote: >> >> Hi John, >> >> apparently the vgaarb was not the problem. >> >> Am 07.11.19 um 03:29 schrieb John Donnelly: >>> Hi,

[PATCH v5 0/7][rebased] Add anx6345 DP/eDP bridge for Olimex Teres-I

2019-11-07 Thread Torsten Duwe
On Wed, Nov 06, 2019 at 04:21:31PM +0100, Maxime Ripard wrote: > > Please resend the whole series rebased on top of either linux-next or > drm-misc-next. Here it is. Applies cleanly to both, modulo those patches already in. Torsten --- ANX6345 LVTTL->eDP video bridge, driver with device

Re: [PATCH V10 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-07 Thread Michael S. Tsirkin
On Thu, Nov 07, 2019 at 09:32:29PM +0800, Jason Wang wrote: > > On 2019/11/7 下午9:08, Michael S. Tsirkin wrote: > > On Thu, Nov 07, 2019 at 08:43:29PM +0800, Jason Wang wrote: > > > On 2019/11/7 下午7:21, Michael S. Tsirkin wrote: > > > > On Thu, Nov 07, 2019 at 06:18:45PM +0800, Jason Wang wrote: >

Re: [PATCH V10 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-07 Thread Michael S. Tsirkin
On Thu, Nov 07, 2019 at 09:40:09PM +0800, Jason Wang wrote: > > On 2019/11/7 下午9:08, Michael S. Tsirkin wrote: > > On Thu, Nov 07, 2019 at 08:47:06PM +0800, Jason Wang wrote: > > > On 2019/11/7 下午8:43, Jason Wang wrote: > > > > On 2019/11/7 下午7:21, Michael S. Tsirkin wrote: > > > > > On Thu, Nov 0

[PATCH v5 2/7] drm/bridge: split some definitions of ANX78xx to dedicated headers

2019-11-07 Thread Torsten Duwe
From: Icenowy Zheng Some definitions currently in analogix-anx78xx.h are not restricted to the ANX78xx series, but also applicable to other DisplayPort transmitters by Analogix. Split out them to dedicated headers, and make analogix-anx78xx.h include them. Signed-off-by: Icenowy Zheng Signed-o

[PATCH v5 4/7] drm/bridge: Prepare Analogix anx6345 support

2019-11-07 Thread Torsten Duwe
Add bit definitions required for the anx6345 and add a sanity check in anx_dp_aux_transfer. Signed-off-by: Icenowy Zheng Signed-off-by: Vasily Khoruzhick Signed-off-by: Torsten Duwe Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c | 2 +- drivers/gpu/drm/

[PATCH v5 7/7] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-11-07 Thread Torsten Duwe
Teres-I has an anx6345 bridge connected to the RGB666 LCD output, and the I2C controlling signals are connected to I2C0 bus. Enable it in the device tree, and enable the display engine, video mixer and tcon0 as well. Signed-off-by: Icenowy Zheng Signed-off-by: Torsten Duwe --- .../boot/dts/all

[PATCH v5 5/7] drm/bridge: Add Analogix anx6345 support

2019-11-07 Thread Torsten Duwe
From: Icenowy Zheng The ANX6345 is an ultra-low power DisplayPower/eDP transmitter designed for portable devices. This driver adds initial support for RGB to eDP mode, without HPD and interrupts. This is a configuration usually seen in eDP applications. Signed-off-by: Icenowy Zheng Signed-off-

[PATCH v5 6/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding

2019-11-07 Thread Torsten Duwe
The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed for portable devices. Add a binding document for it. Signed-off-by: Icenowy Zheng Signed-off-by: Vasily Khoruzhick Reviewed-by: Rob Herring Signed-off-by: Torsten Duwe Reviewed-by: Laurent Pinchart --- .../bindings/displ

[PATCH v5 3/7] drm/bridge: extract some Analogix I2C DP common code

2019-11-07 Thread Torsten Duwe
From: Icenowy Zheng Some code can be shared within different DP bridges by Analogix. Extract them to analogix_dp. Signed-off-by: Icenowy Zheng Signed-off-by: Vasily Khoruzhick Signed-off-by: Torsten Duwe Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/analogix/Makefile | 2

[PATCH v5 1/7] drm/bridge: move ANA78xx driver to analogix subdirectory

2019-11-07 Thread Torsten Duwe
From: Icenowy Zheng As ANA78xx chips are designed and produced by Analogix Semiconductor, Inc, move their driver codes into analogix subdirectory. Signed-off-by: Icenowy Zheng Signed-off-by: Vasily Khoruzhick Reviewed-by: Laurent Pinchart Signed-off-by: Torsten Duwe Reviewed-by: Andrzej Hajd

[Bug 112226] [HadesCanyon] GPU hangs don't anymore recover (although kernel still claims that they do)

2019-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=112226 Bug ID: 112226 Summary: [HadesCanyon] GPU hangs don't anymore recover (although kernel still claims that they do) Product: DRI Version: DRI git Hardware: x86-64 (AMD64)

[Bug 112226] [HadesCanyon] GPU hangs don't anymore recover (although kernel still claims that they do)

2019-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=112226 Eero Tamminen changed: What|Removed |Added See Also||https://bugs.freedesktop.or

[Bug 108898] (Recoverable) GPU hangs with GfxBench Manhattan GL tests

2019-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108898 Eero Tamminen changed: What|Removed |Added See Also||https://bugs.freedesktop.or

[Bug 112226] [HadesCanyon] GPU hangs don't anymore recover (although kernel still claims that they do)

2019-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=112226 --- Comment #1 from Alex Deucher --- Please attach your dmesg output and xorg log is using X. Please note that after a GPU reset, in most cases you need to restart your desktop environment because no desktop environments properly handle the los

[Bug 112221] RX 580 fails to resume sometimes with 5.3 kernel (Ubuntu 19.10)

2019-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=112221 Alex Deucher changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [PATCH 2/2] drm/radeon: finally fix the racy VMA setup

2019-11-07 Thread Alex Deucher
On Thu, Nov 7, 2019 at 7:03 AM Christian König wrote: > > Hey Alex, > > any objections that I merge those two patches through drm-misc-next? > > It's a cleanup I wanted to do for years and Thomas finally fixed up TTM > for this. Fine with me. Series is: Acked-by: Alex Deucher > > Cheers, > Chr

[Bug 112221] RX 580 fails to resume sometimes with 5.3 kernel (Ubuntu 19.10)

2019-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=112221 --- Comment #2 from Kai Groner --- With the 5.4-rc6 kernel I was able to run a suspend/resume cycle 50 times without anything breaking. -- You are receiving this mail because: You are the assignee for the bug.__

Re: [PATCH V10 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-07 Thread Jason Wang
On 2019/11/7 下午9:50, Michael S. Tsirkin wrote: On Thu, Nov 07, 2019 at 09:32:29PM +0800, Jason Wang wrote: On 2019/11/7 下午9:08, Michael S. Tsirkin wrote: On Thu, Nov 07, 2019 at 08:43:29PM +0800, Jason Wang wrote: On 2019/11/7 下午7:21, Michael S. Tsirkin wrote: On Thu, Nov 07, 2019 at 06:18:4

[PATCH 1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co.

2019-11-07 Thread Ville Syrjala
From: Ville Syrjälä Annoyingly __drm_atomic_helper_crtc_reset() does two totally separate things: a) reset the state to defaults values b) assign the crtc->state pointer I just want a) without the b) so let's split out part a) into __drm_atomic_helper_crtc_state_reset(). And of course we'll do t

[PATCH 2/5] drm/i915: s/intel_crtc/crtc/ in intel_crtc_init()

2019-11-07 Thread Ville Syrjala
From: Ville Syrjälä Let's get rid of the redundant intel_ prefix on our variables. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 32 ++-- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display

[PATCH 4/5] drm/i915: Introduce intel_crtc_state_reset()

2019-11-07 Thread Ville Syrjala
From: Ville Syrjälä We have a few places where we want to reset a crtc state to its default values. Let's add a helper for that. We'll need the new __drm_atomic_helper_crtc_state_reset() helper for this to allow us to just reset the state itself without clobbering the crtc->state pointer. And wh

[PATCH 3/5] drm/i915: Introduce intel_crtc_{alloc,free}()

2019-11-07 Thread Ville Syrjala
From: Ville Syrjälä We already have alloc/free helpers for planes, add the same for crtcs. The main benefit is we get to move all the annoying state initialization out of the main crtc_init() flow. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 74 ++---

[PATCH 5/5] drm/i915: Introduce intel_plane_state_reset()

2019-11-07 Thread Ville Syrjala
From: Ville Syrjälä For the sake of symmetry with the crtc stuff let's add a helper to reset the plane state to sane default values. For the moment this only gets caller from the plane init. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 15 +--

[Bug 112226] [HadesCanyon] GPU hangs don't anymore recover (although kernel still claims that they do)

2019-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=112226 --- Comment #2 from Eero Tamminen --- Created attachment 145908 --> https://bugs.freedesktop.org/attachment.cgi?id=145908&action=edit dmesg -- You are receiving this mail because: You are the assignee for the bug.

Re: [PATCH 1/2] drm/gma500: Add missing call to allow enabling vblank on psb/cdv

2019-11-07 Thread Paul Kocialkowski
Hi, On Wed 06 Nov 19, 16:23, Patrik Jakobsson wrote: > On Wed, Nov 6, 2019 at 10:44 AM Paul Kocialkowski > wrote: > > > > This adds a missing call to drm_crtc_vblank_on to the common DPMS helper > > (used by poulsbo and cedartrail), which is called in the CRTC enable path. > > > > With that call,

Re: [PATCH V9 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-07 Thread Jason Wang
On 2019/11/7 上午6:58, Alex Williamson wrote: On Wed, 6 Nov 2019 14:50:30 -0800 Randy Dunlap wrote: On 11/5/19 11:05 PM, Jason Wang wrote: diff --git a/samples/Kconfig b/samples/Kconfig index c8dacb4dda80..13a2443e18e0 100644 --- a/samples/Kconfig +++ b/samples/Kconfig @@ -131,6 +131,16 @@ con

Re: [PATCH v2 1/8] RFC: dt-bindings: add img,pvrsgx.yaml for Imagination GPUs

2019-11-07 Thread Rob Herring
On Thu, Nov 7, 2019 at 5:06 AM H. Nikolaus Schaller wrote: > > The Imagination PVR/SGX GPU is part of several SoC from > multiple vendors, e.g. TI OMAP, Ingenic JZ4780, Intel Poulsbo > and others. > > With this binding, we describe how the SGX processor is > interfaced to the SoC (registers, inter

  1   2   3   >