Re: [PATCH] drm/amdkfd: add missing void argument to function kgd2kfd_init

2019-10-07 Thread Randy Dunlap
On 10/5/19 10:58 AM, Colin King wrote: > From: Colin Ian King > > Function kgd2kfd_init is missing a void argument, add it > to clean up the non-ANSI function declaration. > > Signed-off-by: Colin Ian King Acked-by: Randy Dunlap sparse reports 2 such warnings in amdgpu: ../drivers/gpu/drm/a

Re: [PATCH v19 0/2] PS8640 MIPI-to-eDP bridge

2019-10-07 Thread Ulrich Hecht
> On October 5, 2019 at 1:16 PM Matthias Brugger wrote: > > > Hi Uli, > > On 04/10/2019 21:09, Ulrich Hecht wrote: > > Hi! > > > > This driver seems to have fallen by the wayside because, while otherwise > > fine, it has a firmware update feature that requires a blob that is not in > > the li

Re: [PATCH] drm/amdkfd: add missing void argument to function kgd2kfd_init

2019-10-07 Thread Randy Dunlap
On 10/5/19 11:23 AM, Colin Ian King wrote: > On 05/10/2019 19:10, Randy Dunlap wrote: >> On 10/5/19 10:58 AM, Colin King wrote: >>> From: Colin Ian King >>> >>> Function kgd2kfd_init is missing a void argument, add it >>> to clean up the non-ANSI function declaration. >>> >>> Signed-off-by: Colin

dri-devel@lists.freedesktop.org

2019-10-07 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Instead of dereferencing pdev each time, use a helper variable for the associated device pointer. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij Reviewed-by: Daniel Thompson Reviewed-by: Andy Shevchenko --- drivers/video/backlight/gpio_backlight.c |

[PATCH v5 5/7] backlight: gpio: remove unused fields from platform data

2019-10-07 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Remove the platform data fields that nobody uses. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Reviewed-by: Linus Walleij Reviewed-by: Daniel Thompson --- include/linux/platform_data/gpio_backlight.h | 3 --- 1 file changed, 3 deletions(-) diff

[PATCH -next] drm/amd/display: remove set but not used variable 'core_freesync'

2019-10-07 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: rivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c: In function mod_freesync_get_settings: drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:984:24: warning: variable core_freesync set but not used [-Wunused-but-set-var

[PATCH v5 4/7] sh: ecovec24: don't set unused fields in platform data

2019-10-07 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Platform data fields other than fbdev are no longer used by the backlight driver. Remove them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Reviewed-by: Linus Walleij --- arch/sh/boards/mach-ecovec24/setup.c | 3 --- 1 file changed, 3 deletions(-)

[PATCH -next] drm/amdgpu: remove duplicated include from mmhub_v1_0.c

2019-10-07 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c index 4c7e8c64a94e..6965e1e6fa9e 100644 --- a/drivers/gpu/drm/amd

[PATCH v5 3/7] backlight: gpio: simplify the platform data handling

2019-10-07 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Now that the last user of platform data (sh ecovec24) defines a proper GPIO lookup and sets the 'default-on' device property, we can drop the platform_data-specific GPIO handling and unify a big chunk of code. The only field used from the platform data is now the fbdev

[PATCH v5 7/7] backlight: gpio: pull gpio_backlight_initial_power_state() into probe

2019-10-07 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The probe function in the gpio-backlight driver is quite short. If we pull gpio_backlight_initial_power_state() into probe we can drop two more fields from struct gpio_backlight and shrink the driver code. Signed-off-by: Bartosz Golaszewski --- drivers/video/backlight

Re: drm/imx: Checking a kmemdup() call in imx_pd_bind()

2019-10-07 Thread Markus Elfring
> I agree with you, kmemdup may fail so a null check seems necessary there. Would this place (and similar ones) be pointed out for further considerations also by the source code analysis tool which your software research group seems to be developing? https://github.com/umnsec/cheq/ Regards, Marku

[Bug 109628] WARNING at dcn10_hw_sequencer.c:868 dcn10_verify_allow_pstate_change_high()

2019-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109628 --- Comment #29 from Michel Dänzer --- (In reply to Mirek Kratochvil from comment #27) > Anyway, the latest X driver from git is broken as well. Should the issue be > reported there, or is it better to fix it in kernel layer? It should be fixed

[Bug 111913] AMD Navi10 GPU powerplay issues when using two DisplayPort connectors

2019-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111913 Bug ID: 111913 Summary: AMD Navi10 GPU powerplay issues when using two DisplayPort connectors Product: DRI Version: DRI git Hardware: All OS: Linux (All)

Re: [PATCH v18 00/19] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-10-07 Thread Brendan Higgins
On Sun, Oct 6, 2019 at 9:55 AM Theodore Y. Ts'o wrote: > > On Fri, Oct 04, 2019 at 06:18:04PM -0700, Brendan Higgins wrote: > > > Let's talk about current state. Right now kunit is in linux-next and > > > we want to add a few more tests. We will have to coordinate the effort. > > > Once kunit get

[Bug 111913] AMD Navi10 GPU powerplay issues when using two DisplayPort connectors

2019-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111913 --- Comment #1 from Timur Kristóf --- After a looking at the problem a bit further, it seems that the problem occurs when using any two DisplayPort connectors, but does not happen when using just one DisplayPort and the HDMI connector. -- You

Re: [RESEND TRIVIAL 3/3] treewide: arch: Fix Kconfig indentation

2019-10-07 Thread Geert Uytterhoeven
On Fri, Oct 4, 2019 at 4:57 PM Krzysztof Kozlowski wrote: > Adjust indentation from spaces to tab (+optional two spaces) as in > coding style with command like: > $ sed -e 's/^/\t/' -i */Kconfig > > Signed-off-by: Krzysztof Kozlowski > arch/m68k/Kconfig.bus | 2 +-

[Bug 111913] AMD Navi10 GPU powerplay issues when using two DisplayPort connectors

2019-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111913 --- Comment #2 from Timur Kristóf --- Forgot to mention, this happened with kernel 5.4-rc1 and mesa 19.2 -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing

[Bug 111482] Sapphire Pulse RX 5700 XT power consumption

2019-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111482 --- Comment #26 from Andrew Sheldon --- (In reply to Eduardo from comment #25) > I have a PowerColor RedDevil 5700XT and for me, Kernel 5.4-rc1 just works. > Memory clocks always at 100Mhz when idle, even using KDE (Plasma 5.16). > I'm using

Re: [PATCH v18 00/19] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-10-07 Thread Brendan Higgins
On Sun, Oct 6, 2019 at 10:18 AM Linus Torvalds wrote: > > On Sun, Oct 6, 2019 at 9:55 AM Theodore Y. Ts'o wrote: > > > > Well, one thing we *can* do is if (a) if we can create a kselftest > > branch which we know is stable and won't change, and (b) we can get > > assurances that Linus *will* acce

[PATCH] drm/amdkfd: Fix a && vs || typo

2019-10-07 Thread Dan Carpenter
In the current code if "device_info" is ever NULL then the kernel will Oops so probably || was intended instead of &&. Fixes: e392c887df97 ("drm/amdkfd: Use array to probe kfd2kgd_calls") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +- 1 file changed, 1 insertion

Re: New sysfs interface for privacy screens

2019-10-07 Thread Jani Nikula
On Sun, 06 Oct 2019, Rajat Jain wrote: > Hi, > > Me and Mat are working on this together, and I had a followup to > something Mat asked earlier. > > On Thu, Oct 3, 2019 at 12:57 PM Mat King wrote: >> >> On Thu, Oct 3, 2019 at 2:59 AM Jani Nikula >> wrote: >> > >> > On Wed, 02 Oct 2019, Mat King

[PATCH] drm/amd/powerplay: Fix error handling in smu_init_fb_allocations()

2019-10-07 Thread Dan Carpenter
The error handling is off by one. We should not free the first "tables[i].bo" without decrementing "i" because that might result in a double free. The second problem is that when an error occurs, then the zeroth element "tables[0].bo" isn't freed. I had make "i" signed int for the error handling

[PATCH] drm/amd/powerplay: unlock on error in smu_resume()

2019-10-07 Thread Dan Carpenter
This function needs to drop the mutex before returning. Fixes: f7e3a5776fa6 ("drm/amd/powerplay: check SMU engine readiness before proceeding on S3 resume") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

RE: [PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-10-07 Thread Jani Nikula
On Mon, 07 Oct 2019, "Lee, Shawn C" wrote: > On Fri, 04 Oct 2019, Jani Nikula wrote: >>On Fri, 04 Oct 2019, Adam Jackson wrote: >>> On Sat, 2019-10-05 at 05:58 +0800, Lee Shawn C wrote: This panel (manufacturer is SDC, product ID is 0x4141) used manufacturer defined DPCD register to c

Re: [PATCH v10 1/6] dt-bindings: sun6i-dsi: Add A64 MIPI-DSI compatible

2019-10-07 Thread Maxime Ripard
On Sat, Oct 05, 2019 at 07:49:08PM +0530, Jagan Teki wrote: > The MIPI DSI controller in Allwinner A64 is similar to A33. > > But unlike A33, A64 doesn't have DSI_SCLK gating so it is valid > to with separate compatible for A64 on the same driver. > > Signed-off-by: Jagan Teki > --- > .../binding

RE: [PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-10-07 Thread Lee, Shawn C
On Mon, 07 Oct 2019, "Jani Nikula" wrote: >On Mon, 07 Oct 2019, "Lee, Shawn C" wrote: >> On Fri, 04 Oct 2019, Jani Nikula wrote: >>>On Fri, 04 Oct 2019, Adam Jackson wrote: On Sat, 2019-10-05 at 05:58 +0800, Lee Shawn C wrote: > This panel (manufacturer is SDC, product ID is 0x4141) u

RE: RE: [PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-10-07 Thread Lee, Shawn C
On Mon, 07 Oct 2019, "Jani Nikula" mailto:jani.nik...@intel.com>> wrote: >On Mon, 07 Oct 2019, "Lee, Shawn C" >mailto:shawn.c@intel.com>> wrote: >> On Fri, 04 Oct 2019, Jani Nikula >> mailto:jani.nik...@intel.com>> wrote: >>>On Fri, 04 Oct 2019, Adam Jackson mailto:a...@redhat.com>> >>>wro

Re: [PATCH] cec: add cec_adapter to cec_notifier_cec_adap_unregister()

2019-10-07 Thread Mauro Carvalho Chehab
Em Fri, 4 Oct 2019 13:04:24 +0200 Hans Verkuil escreveu: > It is possible for one HDMI connector to have multiple CEC adapters. The > typical real-world scenario is that where one adapter is used when the device > is in standby, and one that's better/smarter when the device is powered up. > > Th

[Bug 111482] Sapphire Pulse RX 5700 XT power consumption

2019-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111482 --- Comment #27 from Andrew Sheldon --- A bit of a hacky workaround to 144hz (and multi-monitor issues) on Navi: - Bootup to X - Suspend to ram - Notice that clocks have dropped (even in multi-monitor configuration) - I get flickering in the au

[PATCH v2] drm: bridge: adv7511: Enable SPDIF DAI

2019-10-07 Thread Bogdan Togorean
ADV7511 support I2S or SPDIF as audio input interfaces. This commit enable support for SPDIF. Signed-off-by: Bogdan Togorean --- Changes in v2: - add forgotten break statement drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/dri

[Bug 204241] amdgpu fails to resume from suspend

2019-10-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204241 --- Comment #16 from m...@cschwarz.com --- Can confirm the patch 'drm/amdgpu: Move IB pool init after ucode bo creation' fixed the issue for me (96h and counting, failure normally within 24h, with ~2 suspend/resume cycles per day). -- You are re

[Bug 111848] AMDGPU and display fails after resume from suspend

2019-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111848 --- Comment #19 from m...@cschwarz.com --- Potential fix (and kernel Bugzilla bug): https://bugzilla.kernel.org/show_bug.cgi?id=204241 -- You are receiving this mail because: You are the assignee for the bug.

[Bug 111729] RX480 : random NULL pointer dereference on resume from suspend

2019-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111729 --- Comment #9 from m...@cschwarz.com --- Potential fix (and kernel Bugzilla bug): https://bugzilla.kernel.org/show_bug.cgi?id=204241 -- You are receiving this mail because: You are the assignee for the bug._

Re: [PATCH] drm/amd/powerplay: unlock on error in smu_resume()

2019-10-07 Thread Wang, Kevin(Yang)
Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Dan Carpenter Sent: Monday, October 7, 2019 5:04 PM To: Rex Zhu ; Quan, Evan Cc: Zhou, David(ChunMing) ; David Airlie ; kernel-janit...@vger.kernel.org ; amd-...@lists.freedesktop.org ;

Re: [PATCH] drm/amd/powerplay: Fix error handling in smu_init_fb_allocations()

2019-10-07 Thread Wang, Kevin(Yang)
thanks correct it. Reviewed-by: Kevin Wang Best Regards, Kevin From: Dan Carpenter Sent: Monday, October 7, 2019 5:02 PM To: Rex Zhu ; Wang, Kevin(Yang) Cc: Quan, Evan ; Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; David Airlie ; Daniel V

Re: [PATCH v10 5/6] arm64: dts: allwinner: a64: Add MIPI DSI pipeline

2019-10-07 Thread Maxime Ripard
On Sat, Oct 05, 2019 at 07:49:12PM +0530, Jagan Teki wrote: > Add MIPI DSI pipeline for Allwinner A64. > > - dsi node, with A64 compatible since it doesn't support > DSI_SCLK gating unlike A33 > - dphy node, with A64 compatible with A33 fallback since > DPHY on A64 and A33 is similar > - finall

Re: [PATCH v20 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-10-07 Thread Matthias Brugger
On 07/10/2019 10:22, Ulrich Hecht wrote: > From: Jitao Shi > > This patch adds drm_bridge driver for parade DSI to eDP bridge chip. > > Signed-off-by: Jitao Shi > Reviewed-by: Daniel Kurtz > Reviewed-by: Enric Balletbo i Serra > [uli: followed API changes, removed FW update feature] > Signe

Re: [PATCH v11 1/7] drm/sun4i: dsi: Fix TCON DRQ set bits

2019-10-07 Thread Maxime Ripard
On Thu, Oct 03, 2019 at 08:46:31PM +0530, Jagan Teki wrote: > On Thu, Oct 3, 2019 at 6:47 PM Maxime Ripard wrote: > > > > On Thu, Oct 03, 2019 at 12:15:21PM +0530, Jagan Teki wrote: > > > The LCD timing definitions between Linux DRM vs Allwinner are different, > > > below diagram shows this clear

[Bug 205049] garbled graphics

2019-10-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205049 --- Comment #3 from le...@onet.pl --- Booting with amdgpu.ppfeaturemask=0x3fff and the other options gives "error: ../../grub-core/kern/fs.c:167:invalid file name `amdgpu.ppfeaturemask=0x3fff Press any key to continue..." -- You are re

[PATCH v3 3/8] drm/omap: accept NULL for dma_addr in omap_gem_pin

2019-10-07 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Allow NULL to be passed in 'dma_addr' for omap_gem_pin(), in case the caller does not need the dma_addr. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/o

[PATCH v3 7/8] drm/omap: add omap_gem_validate_flags()

2019-10-07 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Add a helper function omap_gem_validate_flags() which validates the omap_bo flags passed from the userspace. Also drop the dev_err() message, as the userspace can cause that at will. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 40 +++

[PATCH v3 5/8] drm/omap: remove OMAP_BO_TILED define

2019-10-07 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen OMAP_BO_TILED does not make sense, as OMAP_BO_TILED_* values are not bitmasks but normal values. As we already have OMAP_BO_TILED_MASK for the mask, we can remove OMAP_BO_TILED and use OMAP_BO_TILED_MASK instead. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/om

[PATCH v3 2/8] drm/omap: add omap_gem_unpin_locked()

2019-10-07 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Add omap_gem_unpin_locked() which is a version of omap_gem_unpin() that expects the caller to hold the omap_obj lock. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff

[PATCH v3 8/8] drm/omap: add OMAP_BO flags to affect buffer allocation

2019-10-07 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen On SoCs with DMM/TILER, we have two ways to allocate buffers: normal dma_alloc or via DMM (which basically functions as an IOMMU). DMM can map 128MB at a time, and we only map the DMM buffers when they are used (i.e. not at alloc time). If DMM is present, omapdrm always uses

[PATCH v3 0/8] drm/omap: OMAP_BO flags

2019-10-07 Thread Jean-Jacques Hiblot
A first version of this work had been sent by Tomi Valkeinen in may 2017 (https://www.spinics.net/lists/dri-devel/msg140663.html). This series adds a few new OMAP_BO flags to help the userspace manage situations where it needs to use lots of buffers, and would currently run out of TILER space. Th

[PATCH v3 6/8] drm/omap: cleanup OMAP_BO_SCANOUT use

2019-10-07 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen omap_gem_new() has a comment about OMAP_BO_SCANOUT which does not make sense. Also, for the TILER case, we drop OMAP_BO_SCANOUT flag for some reason. It's not clear what the original purpose of OMAP_BO_SCANOUT is, but presuming it means "scanout buffer, something that can be

[PATCH v3 4/8] drm/omap: cleanup OMAP_BO flags

2019-10-07 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Reorder OMAP_BO flags and improve the comments. Signed-off-by: Tomi Valkeinen --- include/uapi/drm/omap_drm.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/include/uapi/drm/omap_drm.h b/include/uapi/drm/omap_drm.h index 1fccffef9e27.

[PATCH v3 1/8] drm/omap: use refcount API to track the number of users of dma_addr

2019-10-07 Thread Jean-Jacques Hiblot
This would give us a WARN_ON() if the pin/unpin calls are unbalanced. Proposed-by: Laurent Pinchart Signed-off-by: Jean-Jacques Hiblot Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 45 +++--- 1 file changed, 23 insertions(+), 22 deletions(-) diff

Re: [PATCH TRIVIAL v2] gpu: Fix Kconfig indentation

2019-10-07 Thread Jani Nikula
On Fri, 04 Oct 2019, Krzysztof Kozlowski wrote: > drivers/gpu/drm/i915/Kconfig | 12 +- > drivers/gpu/drm/i915/Kconfig.debug | 144 +++ Please split these out to a separate patch. Can't speak for others, but the patch looks like it'll be conflicts galore and

[PATCH 3/3] drm/i915: Refactor timestamping constants update

2019-10-07 Thread Ville Syrjala
From: Ville Syrjälä Once we do the hw vs. uapi split we can no longer use drm_atomic_helper_calc_timestamping_constants() as it'll consult the uapi state instead of the hw state. So let's just update the vblank timestamping constants whenever we update the scanline offset. We use both to convert

[PATCH 1/3] drm/atomic-helper: Extract drm_atomic_helper_calc_timestamping_constants()

2019-10-07 Thread Ville Syrjala
From: Ville Syrjälä Put the vblank timestamping constants update loop into its own function. It has no business living inside drm_atomic_helper_update_legacy_modeset_state() so we'll be wanting to move it out entirely. As a first step we'll still call it from drm_atomic_helper_update_legacy_modes

Re: [PATCH v2 1/3] drm/sun4i: dsi: Fix video start delay computation

2019-10-07 Thread Maxime Ripard
On Mon, Oct 07, 2019 at 12:03:00AM +0800, Icenowy Zheng wrote: > From: Jagan Teki > > The LCD timing definitions between Linux DRM vs Allwinner are different, > below diagram shows this clear differences. > >Active Front Sync Back >Region

[PATCH 2/3] drm/atomic-helper: Remove the timestamping constant update from drm_atomic_helper_update_legacy_modeset_state()

2019-10-07 Thread Ville Syrjala
From: Ville Syrjälä The timestamping constants have nothing to do with any legacy state so should not be updated from drm_atomic_helper_update_legacy_modeset_state(). Let's make everyone call drm_atomic_helper_calc_timestamping_constants() directly instead of relying on drm_atomic_helper_update_

Re: [PATCH v2] drm/bridge: dw-hdmi: Refuse DDC/CI transfers on the internal I2C controller

2019-10-07 Thread Neil Armstrong
Hi Matthias, On 02/10/2019 21:44, Matthias Kaehlcke wrote: > The DDC/CI protocol involves sending a multi-byte request to the > display via I2C, which is typically followed by a multi-byte > response. The internal I2C controller only allows single byte > reads/writes or reads of 8 sequential bytes

Re: [PATCH v2 RESEND] drm/bridge: dw-hdmi: Restore audio when setting a mode

2019-10-07 Thread Neil Armstrong
Hi, On 03/10/2019 06:14, Cheng-Yi Chiang wrote: > From: Daniel Kurtz > > When setting a new display mode, dw_hdmi_setup() calls > dw_hdmi_enable_video_path(), which disables all hdmi clocks, including > the audio clock. > > We should only (re-)enable the audio clock if audio was already enabled

Re: [PATCH v2 2/3] drm/sun4i: dsi: fix the overhead of the horizontal front porch

2019-10-07 Thread Maxime Ripard
On Mon, Oct 07, 2019 at 12:03:01AM +0800, Icenowy Zheng wrote: > The formula in the BSP kernel indicates that a 16-byte overhead is used > when sending the HFP. However, this value is currently set to 6 in the > sun6i_mipi_dsi driver, which makes some panels flashing. > > Fix this overhead value. >

Re: [PATCH v2 3/3] drm/sun4i: sun6i_mipi_dsi: fix DCS long write packet length

2019-10-07 Thread Maxime Ripard
On Mon, Oct 07, 2019 at 12:03:02AM +0800, Icenowy Zheng wrote: > The packet length of DCS long write packet should not be added with 1 > when constructing long write packet. > > Fix this. > > Signed-off-by: Icenowy Zheng Applied, thanks Maxime signature.asc Description: PGP signature _

Re: [PATCH v3 0/8] drm/omap: OMAP_BO flags

2019-10-07 Thread Tomi Valkeinen
On 07/10/2019 14:25, Jean-Jacques Hiblot wrote: A first version of this work had been sent by Tomi Valkeinen in may 2017 (https://www.spinics.net/lists/dri-devel/msg140663.html). This series adds a few new OMAP_BO flags to help the userspace manage situations where it needs to use lots of buffer

[PATCH v9 4/5] dt-bindings: backlight: Add led-backlight binding

2019-10-07 Thread Jean-Jacques Hiblot
Add DT binding for led-backlight. Signed-off-by: Jean-Jacques Hiblot Reviewed-by: Daniel Thompson Reviewed-by: Sebastian Reichel --- .../bindings/leds/backlight/led-backlight.txt | 28 +++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/l

[PATCH v9 5/5] backlight: add led-backlight driver

2019-10-07 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen This patch adds a led-backlight driver (led_bl), which is similar to pwm_bl except the driver uses a LED class driver to adjust the brightness in the HW. Multiple LEDs can be used for a single backlight. Signed-off-by: Tomi Valkeinen Signed-off-by: Jean-Jacques Hiblot Acke

[PATCH v9 3/5] leds: Add managed API to get a LED from a device driver

2019-10-07 Thread Jean-Jacques Hiblot
If the LED is acquired by a consumer device with devm_led_get(), it is automatically released when the device is detached. Signed-off-by: Jean-Jacques Hiblot Acked-by: Pavel Machek --- drivers/leds/led-class.c | 49 include/linux/leds.h | 2 ++ 2 fi

[PATCH v9 2/5] leds: Add of_led_get() and led_put()

2019-10-07 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen This patch adds basic support for a kernel driver to get a LED device. This will be used by the led-backlight driver. Only OF version is implemented for now, and the behavior is similar to PWM's of_pwm_get() and pwm_put(). Signed-off-by: Tomi Valkeinen Signed-off-by: Jean-

[PATCH v9 0/5] Add a generic driver for LED-based backlight

2019-10-07 Thread Jean-Jacques Hiblot
This series aims to add a led-backlight driver, similar to pwm-backlight, but using a LED class device underneath. A few years ago (2015), Tomi Valkeinen posted a series implementing a backlight driver on top of a LED device: https://patchwork.kernel.org/patch/7293991/ https://patchwork.kernel.org

[PATCH v9 1/5] leds: populate the device's of_node

2019-10-07 Thread Jean-Jacques Hiblot
If initialization data is available and its fwnode is actually a of_node, store this information in the led device's structure. This will allow the device to use or provide OF-based API such (devm_xxx). Signed-off-by: Jean-Jacques Hiblot --- drivers/leds/led-class.c | 4 +++- 1 file changed, 3 i

Re: drm_sched with panfrost crash on T820

2019-10-07 Thread Steven Price
On 04/10/2019 17:33, Koenig, Christian wrote: > > > Am 04.10.2019 18:02 schrieb Steven Price : > On 04/10/2019 16:34, Koenig, Christian wrote: >> Am 04.10.19 um 17:27 schrieb Steven Price: >>> On 04/10/2019 16:03, Neil Armstrong wrote: On 04/10/2019 16:53, Grodzovsky, Andrey wrote: > On

[PATCH] drm/panfrost: Handle resetting on timeout better

2019-10-07 Thread Steven Price
Panfrost uses multiple schedulers (one for each slot, so 2 in reality), and on a timeout has to stop all the schedulers to safely perform a reset. However more than one scheduler can trigger a timeout at the same time. This race condition results in jobs being freed while they are still in use. Wh

Re: [PATCH v5 7/7] backlight: gpio: pull gpio_backlight_initial_power_state() into probe

2019-10-07 Thread Daniel Thompson
On Mon, Oct 07, 2019 at 05:32:00AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The probe function in the gpio-backlight driver is quite short. If we > pull gpio_backlight_initial_power_state() into probe we can drop two > more fields from struct gpio_backlight and shrink the

Re: [PATCH v2 RESEND] drm/bridge: dw-hdmi: Restore audio when setting a mode

2019-10-07 Thread Cheng-yi Chiang
On Mon, Oct 7, 2019 at 7:57 PM Neil Armstrong wrote: > > Hi, > > On 03/10/2019 06:14, Cheng-Yi Chiang wrote: > > From: Daniel Kurtz > > > > When setting a new display mode, dw_hdmi_setup() calls > > dw_hdmi_enable_video_path(), which disables all hdmi clocks, including > > the audio clock. > > >

Re: New sysfs interface for privacy screens

2019-10-07 Thread Sean Paul
On Thu, Oct 3, 2019 at 3:57 PM Mat King wrote: > > On Thu, Oct 3, 2019 at 2:59 AM Jani Nikula > wrote: > > > > On Wed, 02 Oct 2019, Mat King wrote: > > > On Wed, Oct 2, 2019 at 4:46 AM Jani Nikula > > > wrote: > > >> > > >> On Wed, 02 Oct 2019, Daniel Thompson wrote: > > >> > On Wed, Oct 02,

Re: [PATCH] drm/panfrost: Handle resetting on timeout better

2019-10-07 Thread Neil Armstrong
Hi Steven, On 07/10/2019 14:50, Steven Price wrote: > Panfrost uses multiple schedulers (one for each slot, so 2 in reality), > and on a timeout has to stop all the schedulers to safely perform a > reset. However more than one scheduler can trigger a timeout at the same > time. This race condition

[Bug 205049] garbled graphics

2019-10-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205049 --- Comment #4 from Alex Deucher (alexdeuc...@gmail.com) --- Just append: amdgpu.ppfeaturemask=0x3fff to the end of the kernel command line in grub. Replace 0x3fff with 0xfffdbfff to try the other option. Repeat with 0xfffd3fff if necessa

Re: [PATCH][next] drm/komeda: remove redundant assignment to pointer disable_done

2019-10-07 Thread Dan Carpenter
On Fri, Oct 04, 2019 at 10:53:44PM +0100, Colin Ian King wrote: > On 04/10/2019 20:27, Liviu Dudau wrote: > > On Fri, Oct 04, 2019 at 05:21:56PM +0100, Colin King wrote: > >> From: Colin Ian King > >> > >> The pointer disable_done is being initialized with a value that > >> is never read and is be

[PULL] drm-intel-next

2019-10-07 Thread Joonas Lahtinen
6fe7864acc33f0c62bd9d866b722: drm/i915: Update DRIVER_DATE to 20191007 (2019-10-07 15:24:47 +0300) UAPI Changes: - Never allow userptr into the mappable GGTT (Chris) No existing users. Avoid anyone from even trying to spare a d

Re: [PATCH -next] drm/amd/display: remove set but not used variable 'core_freesync'

2019-10-07 Thread Harry Wentland
On 2019-10-06 6:57 a.m., YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > rivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c: > In function mod_freesync_get_settings: > drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:984:24: > warning: variab

Re: [PATCH] drm/amd/display: Fix typo in some comments

2019-10-07 Thread Harry Wentland
On 2019-10-05 7:32 a.m., Christophe JAILLET wrote: > p and g are switched in 'amdpgu_dm' > > Signed-off-by: Christophe JAILLET Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --g

Re: [PATCH 0/5] drm/amd/display: some fixes for gcc warning

2019-10-07 Thread Harry Wentland
Series is Reviewed-by: Harry Wentland Harry On 2019-10-04 10:44 p.m., zhengbin wrote: > zhengbin (5): > drm/amd/display: Make function wait_for_alt_mode static > drm/amd/display: Remove set but not used variable 'source_bpp' > drm/amd/display: Remove set but not used variables > 'h_rat

[Bug 204725] black screen

2019-10-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204725 --- Comment #54 from Alex Deucher (alexdeuc...@gmail.com) --- (In reply to Dmitri Seletski from comment #48) > (In reply to Mike Lothian from comment #47) > > It's selected automatically if you set DRM_FBDEV_EMULATION - which is > > "Enable legacy

Re: [PULL] drm-misc-fixes

2019-10-07 Thread Daniel Vetter
On Thu, Oct 3, 2019 at 9:26 AM Maxime Ripard wrote: > > Hi, > > On Wed, Oct 02, 2019 at 10:06:04PM +0200, Maxime Ripard wrote: > > Hi Dave, Daniel, > > > > I hope that you enjoy XDC if you could make it this year :) > > > > Here's the first round of fixes for drm-misc > > > > Maxime > > > > drm-mi

Re: [PATCH v18 00/19] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-10-07 Thread shuah
On 10/7/19 2:40 AM, Brendan Higgins wrote: On Sun, Oct 6, 2019 at 10:18 AM Linus Torvalds wrote: On Sun, Oct 6, 2019 at 9:55 AM Theodore Y. Ts'o wrote: Well, one thing we *can* do is if (a) if we can create a kselftest branch which we know is stable and won't change, and (b) we can get assu

Re: [PATCH v18 00/19] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-10-07 Thread Steven Rostedt
On Sun, 6 Oct 2019 10:18:11 -0700 Linus Torvalds wrote: > On Sun, Oct 6, 2019 at 9:55 AM Theodore Y. Ts'o wrote: > > > > Well, one thing we *can* do is if (a) if we can create a kselftest > > branch which we know is stable and won't change, and (b) we can get > > assurances that Linus *will* acc

Re: [PATCH v18 00/19] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-10-07 Thread shuah
On 10/7/19 8:40 AM, Steven Rostedt wrote: On Sun, 6 Oct 2019 10:18:11 -0700 Linus Torvalds wrote: On Sun, Oct 6, 2019 at 9:55 AM Theodore Y. Ts'o wrote: Well, one thing we *can* do is if (a) if we can create a kselftest branch which we know is stable and won't change, and (b) we can get ass

Re: [PATCH 1/5] backlight: pwm_bl: fix cie1913 comments and constant

2019-10-07 Thread Daniel Thompson
On Thu, Sep 19, 2019 at 04:06:16PM +0200, Rasmus Villemoes wrote: > The "break-even" point for the two formulas is L==8, which is also > what the code actually implements. [Incidentally, at that point one > has Y=0.008856, not 0.08856]. > > Moreover, all the sources I can find say the linear facto

Re: [PATCH 2/5] backlight: pwm_bl: eliminate a 64/32 division

2019-10-07 Thread Daniel Thompson
On Thu, Sep 19, 2019 at 04:06:17PM +0200, Rasmus Villemoes wrote: > lightness*1000 is nowhere near overflowing 32 bits, so we can just use > an ordinary 32/32 division, which is much cheaper than the 64/32 done > via do_div(). > > Signed-off-by: Rasmus Villemoes Reviewed-by: Daniel Thompson >

[PATCH] Documentation: Fix warning in drm-kmsc-helpers.rst

2019-10-07 Thread Sean Paul
From: Sean Paul Fixes the following warning: ../include/drm/drm_atomic_state_helper.h:1: warning: no structured comments found Fixes: 9ef8a9dc4b21 ("drm: Extract drm_atomic_state_helper.[hc]") Cc: Ville Syrjälä Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Sean Paul Cc: Dav

Re: [PATCH 3/5] backlight: pwm_bl: drop use of int_pow()

2019-10-07 Thread Daniel Thompson
On Thu, Sep 19, 2019 at 04:06:18PM +0200, Rasmus Villemoes wrote: > The scheduler uses a (currently private) fixed_power_int() in its load > average computation for computing powers of numbers 0 < x < 1 > expressed as fixed-point numbers, which is also what we want here. But > that requires the sca

Re: [PATCH 4/5] backlight: pwm_bl: switch to power-of-2 base for fixed-point math

2019-10-07 Thread Daniel Thompson
On Thu, Sep 19, 2019 at 04:06:19PM +0200, Rasmus Villemoes wrote: > Using a power-of-2 instead of power-of-10 base makes the computations > much cheaper. 2^16 is safe; retval never becomes more than 2^48 + > 2^16/2. On a 32 bit platform, the very expensive 64/32 division at the > end of cie1931() i

Re: [PATCH 11/11] x86/mm, pat: convert pat tree to generic interval tree

2019-10-07 Thread Ingo Molnar
* Davidlohr Bueso wrote: > With some considerations, the custom pat_rbtree implementation can be > simplified to use most of the generic interval_tree machinery. > > o The tree inorder traversal can slightly differ when there are key > ('start') collisions in the tree due to one going left and

[PATCH] drm/i915: make array hw_engine_mask static, makes object smaller

2019-10-07 Thread Colin King
From: Colin Ian King Don't populate the array hw_engine_mask on the stack but instead make it static. Makes the object code smaller by 316 bytes. Before: textdata bss dec hex filename 340044388 320 387129738 gpu/drm/i915/gt/intel_reset.o After: textdata

Re: [PATCH] drm/amd/display: Fix typo in some comments

2019-10-07 Thread Alex Deucher
On Mon, Oct 7, 2019 at 10:13 AM Harry Wentland wrote: > > On 2019-10-05 7:32 a.m., Christophe JAILLET wrote: > > p and g are switched in 'amdpgu_dm' > > > > Signed-off-by: Christophe JAILLET > > Reviewed-by: Harry Wentland Applied. thanks! Alex > > Harry > > > --- > > drivers/gpu/drm/amd/di

Re: [PATCH -next] drm/amd/display: remove set but not used variable 'core_freesync'

2019-10-07 Thread Alex Deucher
On Mon, Oct 7, 2019 at 10:06 AM Harry Wentland wrote: > > On 2019-10-06 6:57 a.m., YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > rivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c: > > In function mod_freesync_get_settings: > > drivers/gpu/drm/amd/amdg

Re: [PATCH -next] drm/amdgpu: remove duplicated include from mmhub_v1_0.c

2019-10-07 Thread Alex Deucher
Applied. thanks! Alex On Sun, Oct 6, 2019 at 11:05 PM YueHaibing wrote: > > Remove duplicated include. > > Signed-off-by: YueHaibing > --- > drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c > b/drivers/gpu

Re: [PATCH] drm/amdkfd: add missing void argument to function kgd2kfd_init

2019-10-07 Thread Alex Deucher
On Sat, Oct 5, 2019 at 1:58 PM Colin King wrote: > > From: Colin Ian King > > Function kgd2kfd_init is missing a void argument, add it > to clean up the non-ANSI function declaration. > > Signed-off-by: Colin Ian King Applied. thanks! Alex > --- > drivers/gpu/drm/amd/amdkfd/kfd_module.c | 2

Re: [PATCH TRIVIAL v2] gpu: Fix Kconfig indentation

2019-10-07 Thread Alex Deucher
On Mon, Oct 7, 2019 at 7:39 AM Jani Nikula wrote: > > On Fri, 04 Oct 2019, Krzysztof Kozlowski wrote: > > drivers/gpu/drm/i915/Kconfig | 12 +- > > drivers/gpu/drm/i915/Kconfig.debug | 144 +++ > > Please split these out to a separate patch. Can't speak for

[Bug 204725] black screen

2019-10-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204725 --- Comment #55 from Dmitri Seletski (drj...@gmail.com) --- (In reply to Alex Deucher from comment #54) > (In reply to Dmitri Seletski from comment #48) > > (In reply to Mike Lothian from comment #47) > > > It's selected automatically if you set D

Re: [PATCH] drm/panfrost: Handle resetting on timeout better

2019-10-07 Thread Tomeu Vizoso
On 10/7/19 6:09 AM, Neil Armstrong wrote: Hi Steven, On 07/10/2019 14:50, Steven Price wrote: Panfrost uses multiple schedulers (one for each slot, so 2 in reality), and on a timeout has to stop all the schedulers to safely perform a reset. However more than one scheduler can trigger a timeout

Re: [PATCH v9 4/5] dt-bindings: backlight: Add led-backlight binding

2019-10-07 Thread Rob Herring
Please send DT bindings to DT list or it's never in my queue. IOW, send patches to the lists that get_maintainers.pl tells you to. On Mon, Oct 7, 2019 at 7:45 AM Jean-Jacques Hiblot wrote: > > Add DT binding for led-backlight. > > Signed-off-by: Jean-Jacques Hiblot > Reviewed-by: Daniel Thompson

Re: New sysfs interface for privacy screens

2019-10-07 Thread Mat King
On Mon, Oct 7, 2019 at 7:09 AM Sean Paul wrote: > > On Thu, Oct 3, 2019 at 3:57 PM Mat King wrote: > > > > On Thu, Oct 3, 2019 at 2:59 AM Jani Nikula > > wrote: > > > > > > On Wed, 02 Oct 2019, Mat King wrote: > > > > On Wed, Oct 2, 2019 at 4:46 AM Jani Nikula > > > > wrote: > > > >> > > > >

Re: [PATCH 0/5] drm/amd/display: some fixes for gcc warning

2019-10-07 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Oct 7, 2019 at 10:19 AM Harry Wentland wrote: > > Series is > Reviewed-by: Harry Wentland > > Harry > > On 2019-10-04 10:44 p.m., zhengbin wrote: > > zhengbin (5): > > drm/amd/display: Make function wait_for_alt_mode static > > drm/amd/display: Remove set but

Re: [PATCH] drm/i915: make array hw_engine_mask static, makes object smaller

2019-10-07 Thread Chris Wilson
Quoting Colin King (2019-10-07 16:41:51) > From: Colin Ian King > > Don't populate the array hw_engine_mask on the stack but instead make it > static. Makes the object code smaller by 316 bytes. > > Before: >textdata bss dec hex filename > 340044388 320 387129

Re: [PATCH] drm/amd/powerplay: unlock on error in smu_resume()

2019-10-07 Thread Alex Deucher
Applied. thanks! Alex On Mon, Oct 7, 2019 at 6:29 AM Wang, Kevin(Yang) wrote: > > Reviewed-by: Kevin Wang > > Best Regards, > Kevin > > From: amd-gfx on behalf of Dan > Carpenter > Sent: Monday, October 7, 2019 5:04 PM > To: Rex Zhu ; Quan, Evan > Cc: Zhou,

  1   2   >