Re: [PATCH 0/6] drm/tinydrm: Move mipi_dbi

2019-07-23 Thread Daniel Vetter
On Mon, Jul 22, 2019 at 11:06:15AM -0700, Eric Anholt wrote: > Noralf Trønnes writes: > > > This series ticks off the last tinydrm todo entry and moves out mipi_dbi > > to be a core helper. > > > > It splits struct mipi_dbi into an interface part and a display pipeline > > part (upload framebuffe

Re: [PATCH 4/5] drm/panfrost: Add support for GPU heap allocations

2019-07-23 Thread Alyssa Rosenzweig
> #define PANFROST_BO_NOEXEC 1 > +#define PANFROST_BO_HEAP 2 Bikeshedding, but I don't like this name. There are, I think, multiple GPU-mapped buffers (at least in Panfrost -- I don't know how the blob manages memory) that can be considered heaps of sorts. Some of those are just regular old

Re: [PATCH 3/5] drm/panfrost: Add a no execute flag for BO allocations

2019-07-23 Thread Alyssa Rosenzweig
> Seems like almost 4GB executable > buffer should be enough for anyone(TM). (TM) indeed. For stats, Panfrost right now uses a single 16MB shader buffer per context and never reallocates. I have never seen it run out of space, not even once on a conformance test. Mali shader binaries are small (

Re: [PATCH 3/5] drm/panfrost: Add a no execute flag for BO allocations

2019-07-23 Thread Steven Price
On 19/07/2019 23:07, Rob Herring wrote: > On Fri, Jul 19, 2019 at 4:39 AM Steven Price wrote: >> >> On 18/07/2019 18:03, Rob Herring wrote: >>> On Thu, Jul 18, 2019 at 9:03 AM Steven Price wrote: On 17/07/2019 19:33, Rob Herring wrote: > Executable buffers have an alignment restrict

Re: [PATCH 1/6] mm: always return EBUSY for invalid ranges in hmm_range_{fault, snapshot}

2019-07-23 Thread Souptick Joarder
On Mon, Jul 22, 2019 at 3:14 PM Christoph Hellwig wrote: > > We should not have two different error codes for the same condition. In > addition this really complicates the code due to the special handling of > EAGAIN that drops the mmap_sem due to the FAULT_FLAG_ALLOW_RETRY logic > in the core vm

Re: [PATCH 1/5] drm/panfrost: Restructure the GEM object creation

2019-07-23 Thread Steven Price
On 19/07/2019 23:22, Rob Herring wrote: > On Thu, Jul 18, 2019 at 9:03 AM Steven Price wrote: >> >> On 17/07/2019 19:33, Rob Herring wrote: >>> Setting the GPU VA when creating the GEM object doesn't allow for any >>> conditional adjustments. In preparation to support adjusting the >>> mapping, re

Re: [PATCH 4/5] drm/panfrost: Add support for GPU heap allocations

2019-07-23 Thread Alyssa Rosenzweig
> A fair bit of the complexity of kbase comes from trying to avoid the > possibility of one process DoSing another by submitting malicious jobs. ...and yet it was still doable so easily (by accident, with buggy jobs instead of malicious jobs) sigh... Still is on the mainline kernel (e.g. runn

Re: hmm_range_fault related fixes and legacy API removal v2

2019-07-23 Thread Ralph Campbell
On 7/22/19 2:44 AM, Christoph Hellwig wrote: Hi Jérôme, Ben and Jason, below is a series against the hmm tree which fixes up the mmap_sem locking in nouveau and while at it also removes leftover legacy HMM APIs only used by nouveau. The first 4 patches are a bug fix for nouveau, which I suspec

Re: [PATCH] drm: fix out-of-bounds access with short VSDB blocks

2019-07-23 Thread Steven Price
On 22/07/2019 15:38, Simon Ser wrote: > From: Simon Ser > > The VSDB parsing code contains a few len >= N checks, accessing db[N] on > success. However if len == N, db[N] is out-of-bounds. I'm not familiar with VSDB parsing, but there's a comment before the function: > * @len: length of the CE

[PATCH 0/1] gpu: convert subsystem to i2c_new_dummy_device()

2019-07-23 Thread Wolfram Sang
This series is part of a tree-wide movement to replace the I2C API call 'i2c_new_dummy' which returns NULL with its new counterpart returning an ERRPTR. The series was generated with coccinelle (audited afterwards, of course) and build tested by me and by buildbot. No tests on HW have been perform

Re: [PATCH 4/5] drm/panfrost: Add support for GPU heap allocations

2019-07-23 Thread Alyssa Rosenzweig
> While I agree an executable heap is pretty weird, I'd prefer making this > explicit - i.e. failing the allocation if the flags don't make sense. The only use case for an executable heap I can think of is an attacker trying to exploit a GPU-side heap overflow, and that's seriously stretching it ;

Re: [PATCH 3/5] drm/panfrost: Add a no execute flag for BO allocations

2019-07-23 Thread Alyssa Rosenzweig
This patch is: Acked-by: Alyssa Rosenzweig On Wed, Jul 17, 2019 at 12:33:50PM -0600, Rob Herring wrote: > Executable buffers have an alignment restriction that they can't cross > 16MB boundary as the GPU program counter is 24-bits. This restriction is > currently not handled and we just

Re: [PATCH 3/5] drm/panfrost: Add a no execute flag for BO allocations

2019-07-23 Thread Steven Price
On 22/07/2019 10:50, Robin Murphy wrote: > On 19/07/2019 23:07, Rob Herring wrote: >> On Fri, Jul 19, 2019 at 4:39 AM Steven Price >> wrote: >>> >>> On 18/07/2019 18:03, Rob Herring wrote: On Thu, Jul 18, 2019 at 9:03 AM Steven Price wrote: > > On 17/07/2019 19:33, Rob Herring w

Re: Why is Thunderbolt 3 limited to 2.5 GT/s on Linux?

2019-07-23 Thread Timur Kristóf
> > > > 1. Why is the GTT->VRAM copy so much slower than the VRAM->GTT > > copy? > > > > 2. Why is the bus limited to 24 Gbit/sec? I would expect the > > Thunderbolt port to give me at least 32 Gbit/sec for PCIe traffic. > > That's unrealistic I'm afraid. As I said on IRC, from the GPU POV > th

Re: [PATCH 3/5] drm/panfrost: Add a no execute flag for BO allocations

2019-07-23 Thread Steven Price
On 22/07/2019 13:09, Robin Murphy wrote: > On 22/07/2019 11:07, Steven Price wrote: >> On 22/07/2019 10:50, Robin Murphy wrote: >>> On 19/07/2019 23:07, Rob Herring wrote: On Fri, Jul 19, 2019 at 4:39 AM Steven Price wrote: > > On 18/07/2019 18:03, Rob Herring wrote: >> On Th

Re: [PATCH 3/5] drm/panfrost: Add a no execute flag for BO allocations

2019-07-23 Thread Steven Price
On 22/07/2019 17:18, Rob Herring wrote: > On Mon, Jul 22, 2019 at 7:25 AM Robin Murphy wrote: >> >> On 22/07/2019 13:19, Steven Price wrote: >> [...] >>> Indeed, that case was just occurring to me too! How about: >>> >>> u64 next_seg = ALIGN(*start, PFN_4G); >>> >>> if (next_seg - *sta

[PATCH] drm/amd/display: readd -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines

2019-07-23 Thread Nick Desaulniers
arch/x86/Makefile disables SSE and SSE2 for the whole kernel. The AMDGPU drivers modified in this patch re-enable SSE but not SSE2. Turn on SSE2 to support emitting double precision floating point instructions rather than calls to non-existent (usually available from gcc_s or compiler_rt) floatin

Re: [PATCH 3/5] drm/panfrost: Add a no execute flag for BO allocations

2019-07-23 Thread Alyssa Rosenzweig
> User space shouldn't care too much - other than the size of buffers > allocated being rounded up to the CPU's page size. At least the Panfrost > user/kernel ABI has sizes in bytes not pages (unlike kbase). We've been rounding everything up to the nearest 4k in mesa, out of old habit from kbase.

[Bug 110313] [CI][SHARDS] igt@kms_lease@lease-uevent - fail - Failed assertion: igt_lease_change_detected(uevent_monitor, 1)

2019-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110313 --- Comment #7 from CI Bug Log --- A CI Bug Log filter associated to this bug has been updated: {- ICL: igt@kms_lease@lease-uevent - fail - Failed assertion: igt_lease_change_detected(uevent_monitor, 1) -} {+ SKL ICL: igt@kms_lease@lease-uevent

Re: [PATCH] drm: Add Grain Media GM12U320 driver v2

2019-07-23 Thread Sam Ravnborg
Hi Hans. Driver looks good. Nce to see so much functionality in a driver less than 1000 loc. Following some bike-shedding only - that should have been sent for v1 already. But I thought better late then never. Sam On Sun, Jul 21, 2019 at 03:25:25PM +0200, Hans de Goede wrote: > Add a mo

Re: [PATCH] drm: Add Grain Media GM12U320 driver v2

2019-07-23 Thread Daniel Vetter
On Sun, Jul 21, 2019 at 03:25:25PM +0200, Hans de Goede wrote: > Add a modesetting driver for Grain Media GM12U320 based devices > (primarily Acer C120 projector, but there may be compatible devices). > > This is based on the fb driver from Viacheslav Nurmekhamitov: > https://github.com/slavrn/gm1

Re: [PATCH] drm/komeda: Adds error event print functionality

2019-07-23 Thread Lowry Li (Arm Technology China)
On Mon, Jul 22, 2019 at 04:18:01PM +, Liviu Dudau wrote: > On Mon, Jul 22, 2019 at 11:15:12AM +, james qian wang (Arm Technology > China) wrote: > > On Fri, Jul 19, 2019 at 11:40:11AM +, Liviu Dudau wrote: > > > On Fri, Jul 19, 2019 at 09:09:30AM +, Lowry Li (Arm Technology China)

Re: [PATCH] vt: Grab console_lock around con_is_bound in show_bind

2019-07-23 Thread Daniel Vetter
Hi Greg, Do you plan to pick this up in your console/vt/whatever-fixes branch? There's no reason for me to route this through drm-fixes. -Daniel On Thu, Jul 18, 2019 at 10:09:03AM +0200, Daniel Vetter wrote: > Not really harmful not to, but also not harm in grabbing the lock. And > this shuts up

[PATCH 0/3] Fixes for mgag200 cursors

2019-07-23 Thread Thomas Zimmermann
This patch set fixes a number of bugs that where introduced by the recent changes to mgag200's handling of cursor BOs. Thomas Zimmermann (3): drm/mgag200: Pin displayed cursor BO to video memory drm/mgag200: Set cursor scanout address to correct BO drm/mgag200: Don't unpin the current cursor

[PATCH 1/3] drm/mgag200: Pin displayed cursor BO to video memory

2019-07-23 Thread Thomas Zimmermann
The cursor BO has to be pinned to video ram while it's being displayed. With the current code, the BO might be pinned to system memory instead. The patch fixes this problem. Signed-off-by: Thomas Zimmermann Fixes: 94dc57b10399 ("drm/mgag200: Rewrite cursor handling") Cc: Gerd Hoffmann Cc: Dave A

[PATCH 3/3] drm/mgag200: Don't unpin the current cursor image's buffer.

2019-07-23 Thread Thomas Zimmermann
Currently the displayed cursor buffer might be evicted from video memory. Not unpinning the BO fixes this problem. At this point, pixels_current also references the BO and it will be unpinned during the next cursor update. Signed-off-by: Thomas Zimmermann Fixes: 94dc57b10399 ("drm/mgag200: Rewrit

Re: [PATCH] vt: Grab console_lock around con_is_bound in show_bind

2019-07-23 Thread Greg Kroah-Hartman
On Tue, Jul 23, 2019 at 09:38:20AM +0200, Daniel Vetter wrote: > Hi Greg, > > Do you plan to pick this up in your console/vt/whatever-fixes branch? Yes, now that the merge window is closed, I will be picking this up. thanks, greg k-h ___ dri-devel mai

[PATCH 2/3] drm/mgag200: Set cursor scanout address to correct BO

2019-07-23 Thread Thomas Zimmermann
The hardware requires the correct memory address of the buffer. Currently the same BO's address is programmed unconditionally, so only every second cursor update actually becomes visible. Signed-off-by: Thomas Zimmermann Fixes: 94dc57b10399 ("drm/mgag200: Rewrite cursor handling") Cc: Gerd Hoffma

Re: Why is Thunderbolt 3 limited to 2.5 GT/s on Linux?

2019-07-23 Thread Michel Dänzer
On 2019-07-22 11:39 a.m., Timur Kristóf wrote: >>> >>> 1. Why is the GTT->VRAM copy so much slower than the VRAM->GTT >>> copy? >>> >>> 2. Why is the bus limited to 24 Gbit/sec? I would expect the >>> Thunderbolt port to give me at least 32 Gbit/sec for PCIe traffic. >> >> That's unrealistic I'm af

Re: [PATCH 4/4] video: amba-clcd: Spout an error if of_get_display_timing() gives an error

2019-07-23 Thread Linus Walleij
On Mon, Jul 22, 2019 at 8:25 PM Douglas Anderson wrote: > In the patch ("video: of: display_timing: Don't yell if no timing node > is present") we'll stop spouting an error directly in > of_get_display_timing() if no node is present. Presumably amba-clcd > should take charge of spouting its own

Re: [PATCH 0/4] video: of: display_timing: Adjust err printing of of_get_display_timing()

2019-07-23 Thread Sam Ravnborg
Hi Dough. On Mon, Jul 22, 2019 at 11:24:35AM -0700, Douglas Anderson wrote: > As reported by Sam Ravnborg [1], after commit b8a2948fa2b3 > ("drm/panel: simple: Add ability to override typical timing") we now > see a pointless error message printed on every boot for many systems. > Let's fix that b

Re: [PATCH 0/3] Fixes for mgag200 cursors

2019-07-23 Thread Sam Ravnborg
Hi Thomas. On Tue, Jul 23, 2019 at 09:54:22AM +0200, Thomas Zimmermann wrote: > This patch set fixes a number of bugs that where introduced by the > recent changes to mgag200's handling of cursor BOs. > > Thomas Zimmermann (3): > drm/mgag200: Pin displayed cursor BO to video memory > drm/mgag

[Bug 111198] System hang when running multiple GPU-heavy applications

2019-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98 Bug ID: 98 Summary: System hang when running multiple GPU-heavy applications Product: DRI Version: unspecified Hardware: Other OS: All Stat

Re: [PATCH] drm/komeda: Adds error event print functionality

2019-07-23 Thread Liviu Dudau
On Tue, Jul 23, 2019 at 07:37:42AM +, Lowry Li (Arm Technology China) wrote: > On Mon, Jul 22, 2019 at 04:18:01PM +, Liviu Dudau wrote: > > On Mon, Jul 22, 2019 at 11:15:12AM +, james qian wang (Arm Technology > > China) wrote: > > > On Fri, Jul 19, 2019 at 11:40:11AM +, Liviu Duda

Re: [PATCH v4 14/23] drm/tilcdc: Provide ddc symlink in connector sysfs directory

2019-07-23 Thread Sam Ravnborg
Hi Andrzej On Thu, Jul 11, 2019 at 01:26:41PM +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gp

Re: [PATCH v4 16/23] drm/mgag200: Provide ddc symlink in connector sysfs directory

2019-07-23 Thread Sam Ravnborg
Hi Andrzej. On Thu, Jul 11, 2019 at 01:26:43PM +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/mgag200/mgag200_mode.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) >

Re: [PATCH v4 17/23] drm/ast: Provide ddc symlink in connector sysfs directory

2019-07-23 Thread Sam Ravnborg
Hi Andrzej. On Thu, Jul 11, 2019 at 01:26:44PM +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/ast/ast_mode.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff

Re: [PATCH v2 -next] drm/komeda: remove set but not used variable 'old'

2019-07-23 Thread Daniel Vetter
On Mon, Jul 22, 2019 at 01:56:27PM +0800, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/arm/display/komeda/komeda_plane.c: > In function komeda_plane_atomic_duplicate_state: > drivers/gpu/drm/arm/display/komeda/komeda_plane.c:161:35: > warning: variable o

RE: [EXT] Re: [v2 1/3] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500

2019-07-23 Thread Wen He
> -Original Message- > From: Liviu Dudau > Sent: 2019年7月22日 17:33 > To: Wen He > Cc: dri-devel@lists.freedesktop.org; linux-ker...@vger.kernel.org; > brian.star...@arm.com; airl...@linux.ie; dan...@ffwll.ch; Leo Li > > Subject: Re: [EXT] Re: [v2 1/3] drm/arm/mali-dp: Add display QoS in

Re: [PATCH v7 2/4] drm/panel: set display info in panel attach

2019-07-23 Thread Sam Ravnborg
Hi Derek. On Tue, Jul 09, 2019 at 07:16:57PM -0700, Derek Basehore wrote: > Devicetree systems can set panel orientation via a panel binding, but > there's no way, as is, to propagate this setting to the connector, > where the property need to be added. > To address this, this patch sets orientati

Re: [PATCH] MAINTAINERS: Update my email address

2019-07-23 Thread Maxime Ripard
On Thu, Jul 18, 2019 at 09:24:55PM +0200, Maxime Ripard wrote: > Use my kernel.org address instead of the bootlin one. > > Signed-off-by: Maxime Ripard Applied through the sunxi tree Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Descr

Re: [PATCH 4/5] drm/panfrost: Add support for GPU heap allocations

2019-07-23 Thread Tomeu Vizoso
On Tue, 23 Jul 2019 at 09:14, Alyssa Rosenzweig wrote: > > > A fair bit of the complexity of kbase comes from trying to avoid the > > possibility of one process DoSing another by submitting malicious jobs. > > ...and yet it was still doable so easily (by accident, with buggy jobs > instead of mali

[PATCH] drm/ast: Use dev_get_drvdata where possible

2019-07-23 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/gpu/drm/ast/ast_drv.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c in

Re: [PATCH v2] drm/tegra: sor: Enable HDA interrupts at plugin

2019-07-23 Thread Viswanath L
Thanks for your comments, Dmitry. Please see my responses inline. On 7/23/2019 6:00 AM, Dmitry Osipenko wrote: 22.07.2019 12:27, Viswanath L пишет: HDMI plugout calls runtime suspend, which clears interrupt registers and causes audio functionality to break on subsequent plugin; setting interrup

[PATCH] drm/bochs: Use dev_get_drvdata

2019-07-23 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/gpu/drm/bochs/bochs_drv.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_dr

Re: [PATCH v2] drm/tegra: sor: Enable HDA interrupts at plugin

2019-07-23 Thread Dmitry Osipenko
23.07.2019 13:11, Viswanath L пишет: > Thanks for your comments, Dmitry. Please see my responses inline. > > On 7/23/2019 6:00 AM, Dmitry Osipenko wrote: >> 22.07.2019 12:27, Viswanath L пишет: >>> HDMI plugout calls runtime suspend, which clears interrupt registers >>> and causes audio functional

Re: [EXT] Re: [v1] gpu: ipu-v3: allow to build with ARCH_LAYERSCAPE

2019-07-23 Thread Philipp Zabel
On Tue, 2019-07-09 at 03:11 +, Wen He wrote: [...] > > Thank you for the patch, but this does not seem right. > > ipuv3-crtc.c is part of DRM_IMX, which already depends on IMX_IPUV3_CORE. > > How did you manage to make it try to compile imxdrm? I assume the answer to my question is that you ha

Re: [PATCH v3 10/10] [HACK] arm64: dts: renesas: ebisu: Enable LVDS dual-link operation

2019-07-23 Thread Jacopo Mondi
HI Fabrizio, On Mon, Jul 22, 2019 at 11:27:26AM +, Fabrizio Castro wrote: > Hello Jacopo, > > > From: linux-renesas-soc-ow...@vger.kernel.org > > On Behalf Of Laurent Pinchart > > Sent: 28 May 2019 15:13 > > Subject: [PATCH v3 10/10] [HACK] arm64: dts: renesas: ebisu: Enable LVDS > > dual-l

[PATCH] drm/hisilicon: Use dev_get_drvdata

2019-07-23 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/dr

[PATCH] drm/i915: Use dev_get_drvdata

2019-07-23 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/gpu/drm/i915/i915_drv.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_dr

[PATCH] drm/qxl: Use dev_get_drvdata where possible

2019-07-23 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/gpu/drm/qxl/qxl_drv.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c index f33

Re: [PATCH v2 1/4] drm/via: drop use of DRM(READ|WRITE) macros

2019-07-23 Thread Emil Velikov
On 2019/07/22, Sam Ravnborg wrote: > Hi Email. > > > > > IMHO a far better idea is to expand these macros as static inline > > > > functions. > > > > The extra bonus here is that the pseudo-magical VIA_BASE will also > > > > disappear. > > > > > > > > Since all the VIA_READ8 are used for masking

RE: [PATCH v3 10/10] [HACK] arm64: dts: renesas: ebisu: Enable LVDS dual-link operation

2019-07-23 Thread Fabrizio Castro
Hello Jacopo, Thank you for getting back to me! > From: linux-renesas-soc-ow...@vger.kernel.org > On Behalf Of Jacopo Mondi > Sent: 23 July 2019 11:30 > Subject: Re: [PATCH v3 10/10] [HACK] arm64: dts: renesas: ebisu: Enable LVDS > dual-link operation > > HI Fabrizio, > > On Mon, Jul 22, 201

[RFC PATCH 04/11] devfreq: exynos-bus: Clean up code

2019-07-23 Thread Artur Świgoń
This patch adds minor improvements to the exynos-bus driver. Signed-off-by: Artur Świgoń --- drivers/devfreq/exynos-bus.c | 49 1 file changed, 22 insertions(+), 27 deletions(-) diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c index 4

[RFC PATCH 03/11] devfreq: exynos-bus: Change goto-based logic to if-else logic

2019-07-23 Thread Artur Świgoń
This patch improves code readability by changing the following construct: >if (cond) >goto passive; >foo(); >goto out; >passive: >bar(); >out: into this: >if (cond) >bar(); >else >foo(); Signed-off-by: Artur Świgoń --- drivers/devfreq/exynos-bus

[RFC PATCH 09/11] devfreq: exynos-bus: Add interconnect functionality to exynos-bus

2019-07-23 Thread Artur Świgoń
This patch adds interconnect functionality to the exynos-bus devfreq driver. The SoC topology is a graph (or, more specifically, a tree) and most of its edges are taken from the devfreq parent-child hierarchy (cf. Documentation/devicetree/bindings/devfreq/exynos-bus.txt). The previous patch adds m

[RFC PATCH 05/11] icc: Export of_icc_get_from_provider()

2019-07-23 Thread Artur Świgoń
This patch makes the above function public (for use in exynos-bus devfreq driver). Signed-off-by: Artur Świgoń --- drivers/interconnect/core.c | 3 ++- include/linux/interconnect-provider.h | 6 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/interconnect/c

[RFC PATCH 07/11] icc: Relax condition in apply_constraints()

2019-07-23 Thread Artur Świgoń
The exynos-bus devfreq driver is extended with interconnect functionality by a subsequent patch. This patch removes a check from the interconnect framework that prevents interconnect from working on exynos-bus, in which every bus is a separate interconnect provider. Signed-off-by: Artur Świgoń --

[RFC PATCH 10/11] arm: dts: exynos: Add interconnects to Exynos4412 mixer

2019-07-23 Thread Artur Świgoń
This patch adds an 'interconnects' property to Exynos4412 DTS in order to declare the interconnect path used by the mixer. Please note that the 'interconnect-names' property is not needed when there is only one path in 'interconnects', in which case calling of_icc_get() with a NULL name simply retu

[RFC PATCH 11/11] drm: exynos: mixer: Add interconnect support

2019-07-23 Thread Artur Świgoń
From: Marek Szyprowski This patch adds interconnect support to exynos-mixer. Please note that the mixer works the same as before when CONFIG_INTERCONNECT is 'n'. Co-developed-by: Artur Świgoń Signed-off-by: Artur Świgoń Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos_mixer.

[RFC PATCH 02/11] devfreq: exynos-bus: Extract exynos_bus_profile_init_passive()

2019-07-23 Thread Artur Świgoń
This patch adds a new static function, exynos_bus_profile_init_passive(), extracted from exynos_bus_probe(). Signed-off-by: Artur Świgoń --- drivers/devfreq/exynos-bus.c | 70 +--- 1 file changed, 42 insertions(+), 28 deletions(-) diff --git a/drivers/devfreq/exy

[RFC PATCH 06/11] icc: Relax requirement in of_icc_get_from_provider()

2019-07-23 Thread Artur Świgoń
This patch relaxes the condition in of_icc_get_from_provider() so that it is no longer required to set #interconnect-cells = <1> in the DT. In case of the devfreq driver for exynos-bus, #interconnect-cells is always zero. Signed-off-by: Artur Świgoń --- drivers/interconnect/core.c | 2 +- 1 file

[RFC PATCH 08/11] arm: dts: exynos: Add parents and #interconnect-cells to Exynos4412

2019-07-23 Thread Artur Świgoń
This patch adds two fields tp the Exynos4412 DTS: - parent: to declare connections between nodes that are not in a parent-child relation in devfreq; - #interconnect-cells: required by the interconnect framework. Please note that #interconnect-cells is always zero and node IDs are not hardc

[RFC PATCH 01/11] devfreq: exynos-bus: Extract exynos_bus_profile_init()

2019-07-23 Thread Artur Świgoń
This patch adds a new static function, exynos_bus_profile_init(), extracted from exynos_bus_probe(). Signed-off-by: Artur Świgoń --- drivers/devfreq/exynos-bus.c | 106 --- 1 file changed, 60 insertions(+), 46 deletions(-) diff --git a/drivers/devfreq/exynos-bus.

[PATCH v3] drm/tegra: sor: Enable HDA interrupts at plug-in

2019-07-23 Thread Viswanath L
HDMI plugout calls runtime suspend, which clears interrupt registers and causes audio functionality to break on subsequent plug-in; setting interrupt registers in sor_audio_prepare() solves the issue. Signed-off-by: Viswanath L Fixes: 8e2988a76c26 ("drm/tegra: sor: Support for audio over HDMI") C

Re: [PATCH v4 14/23] drm/tilcdc: Provide ddc symlink in connector sysfs directory

2019-07-23 Thread Andrzej Pietrasiewicz
Hi Sam, W dniu 23.07.2019 o 11:05, Sam Ravnborg pisze: Hi Andrzej On Thu, Jul 11, 2019 at 01:26:41PM +0200, Andrzej Pietrasiewicz wrote: Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 + 1 file cha

Re: [PATCH 3/3] net/xdp: convert put_page() to put_user_page*()

2019-07-23 Thread Jason Gunthorpe
On Mon, Jul 22, 2019 at 09:41:34PM -0700, John Hubbard wrote: > * The leading underscores are often used for the more elaborate form of the > call (as oppposed to decorating the core function name with "_flags", for > example). IMHO usually the __ version of a public symbol means something like '

[PATCH] drm/vblank: Document and fix vblank count barrier semantics

2019-07-23 Thread Daniel Vetter
Noticed while reviewing code. I'm not sure whether this might or might not explain some of the missed vblank hilarity we've been seeing. I think those all go through the vblank completion event, which has unconditional barriers - it always takes the spinlock. Therefore no cc stable. v2: - Barrrier

[PATCH][next] drm/amd/display: remove duplicated comparison

2019-07-23 Thread Colin King
From: Colin Ian King The comparison of surface_pitch is duplicated and hence one of these comparisons is redundant and can be removed. Remove it. Addresses-Coverity: ("Same on both sides") Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual plane") Signed-off-by: Colin Ian King

[PATCH 0/3] RFT: PL111 DRM conversion of nspire

2019-07-23 Thread Linus Walleij
So this is a cold-coded attempt to move the TI nspire over to using DRM. It is more or less the last user of the old fbdev driver so it is a noble cause and interesting usecase. This can be applied on top of a vanilla Torvalds v5.3-rc1 kernel out since sunday. I do not expect these patches to "ju

[PATCH 1/3] RFT: drm/pl111: Support grayscale

2019-07-23 Thread Linus Walleij
Migrating the TI nspire calculators to use the PL111 driver for framebuffer requires grayscale support for the elder panel which uses 8bit grayscale only. DRM does not support 8bit grayscale framebuffers in memory, but by defining the bus format to be MEDIA_BUS_FMT_Y8_1X8 we can get the hardware t

[PATCH 2/3] RTF: drm/panel: simple: Add TI nspire panels

2019-07-23 Thread Linus Walleij
This adds support for the TI nspire panels to the simple panel roster. This code is based on arch/arm/mach-nspire/clcd.c. This includes likely the first grayscale panel supported. These panels will be used with the PL11x DRM driver. Cc: Daniel Tang Cc: Fabian Vogt Signed-off-by: Linus Walleij

[PATCH 3/3] RFT: ARM: nspire: Move CLCD set-up to device tree

2019-07-23 Thread Linus Walleij
This moves the nspire over to using the device tree to set-up and probe the PL111 DRM driver and use the panels from the simple-panel drivers. Cc: Daniel Tang Cc: Fabian Vogt Signed-off-by: Linus Walleij --- arch/arm/boot/dts/nspire-classic.dtsi | 19 - arch/arm/boot/dts/nspire-cx.dts

dri-devel@lists.freedesktop.org

2019-07-23 Thread Daniel Thompson
On Tue, Jul 23, 2019 at 08:29:52AM +0200, Bartosz Golaszewski wrote: > pon., 22 lip 2019 o 18:09 Andy Shevchenko > napisał(a): > > > > On Mon, Jul 22, 2019 at 05:03:02PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > Instead of dereferencing pdev each time, use a he

Re: [PATCH 0/6] drm/tinydrm: Move mipi_dbi

2019-07-23 Thread Noralf Trønnes
Den 23.07.2019 09.10, skrev Daniel Vetter: > On Mon, Jul 22, 2019 at 11:06:15AM -0700, Eric Anholt wrote: >> Noralf Trønnes writes: >> >>> This series ticks off the last tinydrm todo entry and moves out mipi_dbi >>> to be a core helper. >>> >>> It splits struct mipi_dbi into an interface part an

[PATCH][next] drm/amdgpu: remove redundant assignment to pointer 'ring'

2019-07-23 Thread Colin King
From: Colin Ian King The pointer 'ring' is being assigned a value that is never read, hence the assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 1 - 1 file changed, 1 deletion(-) diff --

Re: [PATCH] drm/syncobj: extend syncobj query ability

2019-07-23 Thread Koenig, Christian
Am 23.07.19 um 07:22 schrieb Chunming Zhou: > user space needs a flexiable query ability. > So that umd can get last signaled or submitted point. > > Change-Id: I6512b430524ebabe715e602a2bf5abb0a7e780ea > Signed-off-by: Chunming Zhou > Cc: Lionel Landwerlin > Cc: Christian König I've recently f

Re: [PATCH 07/10] drm/i915: Implement MST Aux device registration

2019-07-23 Thread Li, Sun peng (Leo)
On 2019-07-12 4:15 p.m., Ville Syrjälä wrote: > On Fri, Jul 12, 2019 at 11:05:59PM +0300, Ville Syrjälä wrote: >> On Fri, Jul 12, 2019 at 03:48:53PM -0400, Lyude Paul wrote: >>> BTW, I just tried these patches on my T450s (using i915) and I'm seeing some >>> kernel warnings with them when adding

Re: [PATCH] drm/syncobj: extend syncobj query ability

2019-07-23 Thread Lionel Landwerlin
On 23/07/2019 08:22, Chunming Zhou wrote: user space needs a flexiable query ability. So that umd can get last signaled or submitted point. Change-Id: I6512b430524ebabe715e602a2bf5abb0a7e780ea Signed-off-by: Chunming Zhou Cc: Lionel Landwerlin Cc: Christian König --- drivers/gpu/drm/drm_syn

Re: [PATCH] drm/syncobj: extend syncobj query ability

2019-07-23 Thread Chunming Zhou
在 2019/7/23 21:58, Koenig, Christian 写道: > Am 23.07.19 um 07:22 schrieb Chunming Zhou: >> user space needs a flexiable query ability. >> So that umd can get last signaled or submitted point. >> >> Change-Id: I6512b430524ebabe715e602a2bf5abb0a7e780ea >> Signed-off-by: Chunming Zhou >> Cc: Lionel L

Re: [PATCH] drm/syncobj: extend syncobj query ability

2019-07-23 Thread Koenig, Christian
Am 23.07.19 um 16:07 schrieb Zhou, David(ChunMing): > 在 2019/7/23 21:58, Koenig, Christian 写道: >> Am 23.07.19 um 07:22 schrieb Chunming Zhou: >>> user space needs a flexiable query ability. >>> So that umd can get last signaled or submitted point. >>> >>> Change-Id: I6512b430524ebabe715e602a2bf5abb

Re: [PATCH v2 00/11] drm/tinydrm: Remove tinydrm.ko

2019-07-23 Thread Noralf Trønnes
Den 19.07.2019 17.59, skrev Noralf Trønnes: > This series removes the remaining bits of tinydrm.ko. > > Changes: > - Split SPI connector type patch in core and driver changes, expand > commit message (Daniel) > - Drop moving the mipi_dbi_spi_init() declaration (Sam) > - st7586: Forgot to remov

Re: [PATCH] fbdev: Ditch fb_edid_add_monspecs

2019-07-23 Thread Bartlomiej Zolnierkiewicz
On 7/22/19 3:52 PM, Bartlomiej Zolnierkiewicz wrote: > > On 7/21/19 10:38 PM, Linus Torvalds wrote: >> On Sun, Jul 21, 2019 at 1:20 PM Daniel Vetter wrote: >>> >>> It's dead code ever since >> >> Lovely. Ack. > > Good catch indeed. > > Thanks Daniel, I'll queue it for v5.4 later. Patch queued

[PATCH] drm/syncobj: extend syncobj query ability v2

2019-07-23 Thread Chunming Zhou
user space needs a flexiable query ability. So that umd can get last signaled or submitted point. v2: add sanitizer checking. Change-Id: I6512b430524ebabe715e602a2bf5abb0a7e780ea Signed-off-by: Chunming Zhou Cc: Lionel Landwerlin Cc: Christian König --- drivers/gpu/drm/drm_syncobj.c | 34 +

[PATCH][next] drm/amd/display: fix a missing null check on a failed kzalloc

2019-07-23 Thread Colin King
From: Colin Ian King Currently the allocation of config may fail and a null pointer dereference on config can occur. Fix this by added a null check on a failed allocation of config. Addresses-Coverity: ("Dereference null return") Fixes: c2cd9d04ecf0 ("drm/amd/display: Hook up calls to do stereo

[PATCH] MAINTAINERS: handle fbdev changes through drm-misc tree

2019-07-23 Thread Bartlomiej Zolnierkiewicz
fbdev patches will now go to upstream through drm-misc tree (IOW starting with v5.4 merge window fbdev changes will be included in DRM pull request) for improved maintainership and better integration testing. Update MAINTAINERS file accordingly. Cc: Daniel Vetter Signed-off-by: Bartlomiej Zolnier

[Bug 111099] Green video when playing a hevc video with vdpau

2019-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111099 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH v4 14/23] drm/tilcdc: Provide ddc symlink in connector sysfs directory

2019-07-23 Thread Sam Ravnborg
Hi Andrej. On Tue, Jul 23, 2019 at 02:44:50PM +0200, Andrzej Pietrasiewicz wrote: > Hi Sam, > > W dniu 23.07.2019 o 11:05, Sam Ravnborg pisze: > > Hi Andrzej > > > > On Thu, Jul 11, 2019 at 01:26:41PM +0200, Andrzej Pietrasiewicz wrote: > > > Use the ddc pointer provided by the generic connector

Re: [PATCH v2 2/7] backlight: gpio: simplify the platform data handling

2019-07-23 Thread Andy Shevchenko
On Tue, Jul 23, 2019 at 08:28:00AM +0200, Bartosz Golaszewski wrote: > pon., 22 lip 2019 o 18:06 Andy Shevchenko > napisał(a): > > > > On Mon, Jul 22, 2019 at 05:02:57PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > Now that the last user of platform data (sh ecove

dri-devel@lists.freedesktop.org

2019-07-23 Thread Andy Shevchenko
On Tue, Jul 23, 2019 at 08:29:52AM +0200, Bartosz Golaszewski wrote: > pon., 22 lip 2019 o 18:09 Andy Shevchenko > napisał(a): > > > > On Mon, Jul 22, 2019 at 05:03:02PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > Instead of dereferencing pdev each time, use a he

Re: [PATCH] drm: Add Grain Media GM12U320 driver v2

2019-07-23 Thread Noralf Trønnes
Den 23.07.2019 09.33, skrev Daniel Vetter: > On Sun, Jul 21, 2019 at 03:25:25PM +0200, Hans de Goede wrote: >> Add a modesetting driver for Grain Media GM12U320 based devices >> (primarily Acer C120 projector, but there may be compatible devices). >> >> This is based on the fb driver from Viaches

Re: [PATCH] fbmem: remove redundant assignment to err

2019-07-23 Thread Bartlomiej Zolnierkiewicz
On 6/25/19 12:37 AM, Colin King wrote: > From: Colin Ian King > > Variable err is initialized to a value that is never read and it > is re-assigned later. The initialization is redundant and can > be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Patch queu

Re: [PATCH] video: fbdev: nvidia: Remove extra return

2019-07-23 Thread Bartlomiej Zolnierkiewicz
On 7/22/19 10:26 AM, Souptick Joarder wrote: > On Wed, Jul 10, 2019 at 11:28 PM Souptick Joarder > wrote: >> >> Minor cleanup to remove extra return statement. >> > > Any comment on this patch ? > >> Signed-off-by: Souptick Joarder Patch queued for v5.4, thanks. Best regards, -- Bartlomiej

Re: [PATCH 1/3] mm/gup: introduce __put_user_pages()

2019-07-23 Thread Christoph Hellwig
On Mon, Jul 22, 2019 at 11:33:32PM -0700, John Hubbard wrote: > I'm seeing about 18 places where set_page_dirty() is used, in the call site > conversions so far, and about 20 places where set_page_dirty_lock() is > used. So without knowing how many of the former (if any) represent bugs, > you can s

Re: [PATCH] video: fbdev: nvidia: Remove dead code

2019-07-23 Thread Bartlomiej Zolnierkiewicz
On 7/22/19 10:26 AM, Souptick Joarder wrote: > On Wed, Jul 10, 2019 at 11:41 PM Souptick Joarder > wrote: >> >> This is dead code since 3.15. If there is no plan to use it >> further, this can be removed forever. > > Any comment on this patch ? > >> >> Signed-off-by: Souptick Joarder Patch q

Re: [PATCH v3 24/24] video: fbdev-MMP: Remove call to memset after dma_alloc_coherent

2019-07-23 Thread Bartlomiej Zolnierkiewicz
On 7/15/19 12:40 PM, Emil Velikov wrote: > On 2019/07/15, Fuqian Huang wrote: >> In commit 518a2f1925c3 >> ("dma-mapping: zero memory returned from dma_alloc_*"), >> dma_alloc_coherent has already zeroed the memory. >> So memset is not needed. >> >> Signed-off-by: Fuqian Huang >> --- >> Changes i

Re: [PATCH 0/6] video: ssd1307fb: Support more displays

2019-07-23 Thread Bartlomiej Zolnierkiewicz
On 6/18/19 9:41 AM, Marko Kohtala wrote: > The kernel driver for ssd1307fb did not allow for all proper > initialization for a Densitron 128x36 display. The trend in the driver > has been to add devicetree properties for the controller initialization > and these patches continue on that trend. >

Re: [PATCH] i2c: replace i2c_new_secondary_device with an ERR_PTR variant

2019-07-23 Thread Kieran Bingham
Hi Wolfram, On 22/07/2019 18:26, Wolfram Sang wrote: > In the general move to have i2c_new_*_device functions which return > ERR_PTR instead of NULL, this patch converts i2c_new_secondary_device(). > > There are only few users, so this patch converts the I2C core and all > users in one go. The fu

Re: [RFC PATCH] fbcon: fix ypos over boundary issue

2019-07-23 Thread Bartlomiej Zolnierkiewicz
On 7/12/19 5:13 AM, Zenghui Yu wrote: > From: Feng Tiantian > > While using "top" on a CentOS guest's VNC-client, then continuously press > "Shift+PgUp", the guest kernel will get panic! Backtrace is attached below. > We tested it on 5.2.0, and the issue remains. > > [ 66.946362] Unable to h

Re: [1/3] RFT: drm/pl111: Support grayscale

2019-07-23 Thread David Lechner
On 7/23/19 8:37 AM, Linus Walleij wrote: Migrating the TI nspire calculators to use the PL111 driver for framebuffer requires grayscale support for the elder panel which uses 8bit grayscale only. DRM does not support 8bit grayscale framebuffers in memory, but by defining the bus format to be MED

  1   2   3   >