Re: [PATCH] gpu: i915: fix a missing check of get_free_page

2019-03-09 Thread Chris Wilson
Quoting Kangjie Lu (2019-03-09 04:24:50) > If the allocation fails, return false to avoid potential > NULL pointer dereference No. If we fail to allocate c->tmp, we do uncached reads instead. -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.

Re: WARNING in __flush_work (2)

2019-03-09 Thread Tetsuo Handa
Commit b30b61ff6b1dc37f in linux-next.git did not get in time for closing previous report. I assume that a pull request will be sent shortly from Daniel Vetter. #syz fix: drm/vkms: Fix flush_work() without INIT_WORK(). ___ dri-devel mailing list dri-dev

[PATCH] drm: rockchip: add shutdown function to poweroff VOP and HDMI TX

2019-03-09 Thread Johan Jonker
When a MK808 TV-stick with RK3066 processor is given a poweroff command, the monitor doesn't turn blank, but freezes. The VOP and HDMI share the same power domain, so that means that both there clocks were never turned off. Fix the disable of the VOP and HDMI TX by adding an extra shutdown function

Re: [Intel-gfx] [PATCH] drm/i915: Zero initialize this_cpu in busywait_stop

2019-03-09 Thread Nick Desaulniers
On Fri, Mar 8, 2019 at 12:27 AM Chris Wilson wrote: > > Quoting Nathan Chancellor (2019-03-08 01:20:24) > > When building with -Wsometimes-uninitialized, Clang warns: > > > > drivers/gpu/drm/i915/i915_request.c:1032:6: warning: variable 'this_cpu' > > is used uninitialized whenever '&&' condition

[PATCH] gpu: amdkfd: fix a missing check of kmemdup

2019-03-09 Thread Kangjie Lu
kmemdup could fail and return NULL. To avoid null pointer dereference, the fix checkes its return value and returns ENOMEM upon failures. Signed-off-by: Kangjie Lu --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat

[PATCH] drm: vkms: check status of alloc_ordered_workqueue

2019-03-09 Thread Kangjie Lu
alloc_ordered_workqueue may fail and return NULL. The fix returns ENOMEM when it fails to avoid potential NULL pointer dereference. Signed-off-by: Kangjie Lu --- drivers/gpu/drm/vkms/vkms_crtc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-09 Thread Alyssa Rosenzweig
> bitmasks in the kernel use unsigned long arrays. A strange choice > which I guess was either because it predated 64-bit or enables atomic > ops which tend to be on the native size. So this just fixes the size > to 64-bits for 32 and 64 bit systems. Bizarre, but if that's the standard, then OK.

[PATCH] drm/udl: Bugfix in EDID reading routine

2019-03-09 Thread Robert Tarasov
Fixed bug with reading of last EDID extra block in drm/udl driver. Previouse approach read all the blocks except the last one. Signed-off-by: Robert Tarasov --- drivers/gpu/drm/udl/udl_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/udl/udl_connect

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-09 Thread Alyssa Rosenzweig
> It was given to me and a bunch of other ARM kernel devs, but I think > it was in production by then. It's an A01 rev which matches this: > > https://www.notebookcheck.net/Samsung-Chromebook-XE303C12-A01US.84022.0.html > > The only other rev is a UK version. Wacky. Something seems decidedly odd

[PATCH] drm/udl: Cut >165 MHz modes for DVI

2019-03-09 Thread Robert Tarasov
Filter out all modes with clock higher than 165 MHz for DVI connector in drm/udl driver. Signed-off-by: Robert Tarasov --- drivers/gpu/drm/udl/udl_connector.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c in

Re: Is it possible to reset graphics controller on reboot in a framebuffer driver?

2019-03-09 Thread Tom Li
On Fri, Mar 08, 2019 at 10:13:58AM +0100, Geert Uytterhoeven wrote: > Hi Tom, > > If the kernel just crashes, of course all of that doesn't happen. > Is your graphics card reset when the reset button is pressed, or only on > cold power on? It's a laptop, so it doesn't have a reset button. I've tr

Re: [PATCH v3 3/3] drm/v3d: Make sure the GPU is on when measuring clocks.

2019-03-09 Thread Dave Emett
On Wed, 20 Feb 2019 at 23:37, Eric Anholt wrote: > > You'll get garbage measurements if the registers always read back > 0xdeadbeef > > Signed-off-by: Eric Anholt Reviewed-by: Dave Emett > --- > drivers/gpu/drm/v3d/v3d_debugfs.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a

[PATCH] [v5,2/2] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

2019-03-09 Thread Jerry Han
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel. v5: - Added changelog v4: - Frefix all function maes with boe_ (Sam) - Fsed "enable_gpio" replace "reset_gpio", Make it look clearer (Sam) - Sort include lines alphabetically (Sam) - Fixed entries in the makefile must be

Re: [PATCH v4 1/2] drm/v3d: Handle errors from IRQ setup.

2019-03-09 Thread Dave Emett
On Fri, 8 Mar 2019 at 17:43, Eric Anholt wrote: > > Noted in review by Dave Emett for V3D 4.2 support. > > Signed-off-by: Eric Anholt Reviewed-by: Dave Emett > --- > drivers/gpu/drm/v3d/v3d_drv.c | 8 ++-- > drivers/gpu/drm/v3d/v3d_drv.h | 2 +- > drivers/gpu/drm/v3d/v3d_irq.c | 13

Re: [PATCH v3 2/3] drm/v3d: Don't try to set OVRTMUOUT on V3D 4.x.

2019-03-09 Thread Dave Emett
On Wed, 20 Feb 2019 at 23:37, Eric Anholt wrote: > > The old field is gone and the register now has a different field, > QRMAXCNT for how many TMU requests get serviced before thread switch. > We were accidentally reducing it from its default of 0x3 (4 requests) > to 0x0 (1). > > v2: Skip setting

[PATCH] gpu: i915: fix a missing check of get_free_page

2019-03-09 Thread Kangjie Lu
If the allocation fails, return false to avoid potential NULL pointer dereference Signed-off-by: Kangjie Lu --- drivers/gpu/drm/i915/i915_gpu_error.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_err

[PATCH] drm: check if alloc_workqueue fails

2019-03-09 Thread Kangjie Lu
alloc_workqueue may fail. The fix checks its status. We probably need to add a return value for radeon_crtc_init, so that we can pass an error code upstream. Signed-off-by: Kangjie Lu --- drivers/gpu/drm/radeon/radeon_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/dr

Re: [PATCH v4 2/2] drm/v3d: Add support for V3D v4.2.

2019-03-09 Thread Dave Emett
On Fri, 8 Mar 2019 at 17:43, Eric Anholt wrote: > > No compatible string for it yet, just the version-dependent changes. > They've now tied the hub and the core interrupt lines into a single > interrupt line coming out of the block. It also turns out I made a > mistake in modeling the V3D v3.3 an

Re: [PATCH v3 1/3] drm/v3d: Add support for V3D v4.2.

2019-03-09 Thread Dave Emett
On Wed, 20 Feb 2019 at 23:37, Eric Anholt wrote: > > No compatible string for it yet, just the version-dependent changes. > They've now tied the hub and the core interrupt lines into a single > interrupt line coming out of the block. It also turns out I made a > mistake in modeling the V3D v3.3 a

Re: [PATCH v3 1/3] drm/v3d: Add support for V3D v4.2.

2019-03-09 Thread Dave Emett
On Fri, 8 Mar 2019 at 16:51, Eric Anholt wrote: > > Dave Emett writes: > > > Sorry, a few things I thought of after sending the Reviewed-by email... > > > >> + v3d->reset = devm_reset_control_get_exclusive(dev, NULL); > >> + if (IS_ERR(v3d->reset)) { > >> + ret = PTR_ERR

Re: [PATCH v3 1/3] drm/v3d: Add support for V3D v4.2.

2019-03-09 Thread Dave Emett
Sorry, a few things I thought of after sending the Reviewed-by email... > + v3d->reset = devm_reset_control_get_exclusive(dev, NULL); > + if (IS_ERR(v3d->reset)) { > + ret = PTR_ERR(v3d->reset); > + > + if (ret == -EPROBE_DEFER) > + got

[PATCH] [v5, 1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel

2019-03-09 Thread Jerry Han
The Boe Himax8279d is a 8.0" panel with a 1200x1920 resolution and connected to DSI using four lanes. V5: - Added changelog V4: - None V3: - None V2: - Add compatible device "boe,himax8279d10p" (Sam) - Add the necessary property descriptions (Sam) Signed-off-by: Jerry Han Cc: Jitao Shi Cc: D

[Bug 105733] Amdgpu randomly hangs and only ssh works. Mouse cursor moves sometimes but does nothing. Keyboard stops working.

2019-03-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105733 --- Comment #74 from Mauro Gaspari --- Quick update. After latest updates on my Kubuntu 18.10 with Padoka unstable PPA, I am noticing great improvements. Performance using DXVK with DX11 is greatly improved with LLVM9.0.0, mesa 19.0.1-devel seem

Re: [PATCH] [v5, 1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel

2019-03-09 Thread Sam Ravnborg
Hi Jerry Thanks for addign the changelog, it makes it easier to follow the evolution of the patch. Looks good now. On Sat, Mar 09, 2019 at 10:41:21AM +0800, Jerry Han wrote: > The Boe Himax8279d is a 8.0" panel with a 1200x1920 resolution and > connected to DSI using four lanes. > > V5: > - Add

Re: [PATCH] [v5, 2/2] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

2019-03-09 Thread Sam Ravnborg
Hi Jerry. I am missing a little intro to the patch - other than the subject. With this, and the few comments addrerssed that follows you can add: Reviewed-by: Sam Ravnborg On Sat, Mar 09, 2019 at 10:46:50AM +0800, Jerry Han wrote: > Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a M

Re: [PATCH/RFC 11/15] drm: rcar-du: lvds: Add support for dual-link mode

2019-03-09 Thread Jacopo Mondi
Hi Laurent, On Fri, Mar 08, 2019 at 08:12:39PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > On Fri, Mar 08, 2019 at 06:20:23PM +0100, Jacopo Mondi wrote: > > On Thu, Mar 07, 2019 at 01:23:41AM +0200, Laurent Pinchart wrote: > > > In dual-link mode the LVDS0 encoder transmits even-numbered pixel

Re: [PATCH/RFC 05/15] dt-bindings: display: bridge: thc63lvd1024: Document dual-link operation

2019-03-09 Thread Jacopo Mondi
HI Laurent, On Fri, Mar 08, 2019 at 07:57:39PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > On Fri, Mar 08, 2019 at 05:49:25PM +0100, Jacopo Mondi wrote: > > On Thu, Mar 07, 2019 at 01:23:35AM +0200, Laurent Pinchart wrote: > > > The THC63LVD1024 LVDS decoder can operate in two modes, single-li

Re: [PATCH/RFC 06/15] drm: bridge: thc63: Report input bus mode through bridge timings

2019-03-09 Thread Jacopo Mondi
Hi Laurent On Fri, Mar 08, 2019 at 08:00:28PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > On Fri, Mar 08, 2019 at 06:32:59PM +0100, Jacopo Mondi wrote: > > On Thu, Mar 07, 2019 at 01:23:36AM +0200, Laurent Pinchart wrote: > > > Set a drm_bridge_timings in the drm_bridge, and use it to report t

Re: [PATCH/RFC 11/15] drm: rcar-du: lvds: Add support for dual-link mode

2019-03-09 Thread Laurent Pinchart
Hi Jacopo, On Sat, Mar 09, 2019 at 12:11:32PM +0100, Jacopo Mondi wrote: > On Fri, Mar 08, 2019 at 08:12:39PM +0200, Laurent Pinchart wrote: > > On Fri, Mar 08, 2019 at 06:20:23PM +0100, Jacopo Mondi wrote: > >> On Thu, Mar 07, 2019 at 01:23:41AM +0200, Laurent Pinchart wrote: > >>> In dual-link m

Re: [PATCH/RFC 06/15] drm: bridge: thc63: Report input bus mode through bridge timings

2019-03-09 Thread Laurent Pinchart
Hi Jacopo, On Sat, Mar 09, 2019 at 12:24:08PM +0100, Jacopo Mondi wrote: > On Fri, Mar 08, 2019 at 08:00:28PM +0200, Laurent Pinchart wrote: > > On Fri, Mar 08, 2019 at 06:32:59PM +0100, Jacopo Mondi wrote: > >> On Thu, Mar 07, 2019 at 01:23:36AM +0200, Laurent Pinchart wrote: > >>> Set a drm_brid

Re: [PATCH/RFC 05/15] dt-bindings: display: bridge: thc63lvd1024: Document dual-link operation

2019-03-09 Thread Laurent Pinchart
Hi Jacopo, On Sat, Mar 09, 2019 at 12:23:08PM +0100, Jacopo Mondi wrote: > On Fri, Mar 08, 2019 at 07:57:39PM +0200, Laurent Pinchart wrote: > > On Fri, Mar 08, 2019 at 05:49:25PM +0100, Jacopo Mondi wrote: > >> On Thu, Mar 07, 2019 at 01:23:35AM +0200, Laurent Pinchart wrote: > >>> The THC63LVD10

[Bug 109534] Crash in Minecraft due to a swp[chan] assertion fail in src/gallium/drivers/r600/sb/sb_ir.cpp alu_packed_node::update_packed_items

2019-03-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109534 --- Comment #3 from vanyasm...@gmail.com --- FYI: I've tried to rebuild Mesa packages for Ubuntu 18.04 from x-swat-team ppa, but on codebase of Mesa 18.3.4 (instead of 18.3.3 used there), and even with mesa 18.3.4 this problem has not gone. --

[PATCH v2] drm/fourcc: add ARM GPU tile format

2019-03-09 Thread Qiang Yu
v2: seperate AFBC and GPU encoding Cc: Brian Starkey Cc: Rob Herring Cc: Alyssa Rosenzweig Signed-off-by: Qiang Yu --- include/uapi/drm/drm_fourcc.h | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi

[Bug 108487] Wayland compositors are unable to use hardware acceleration on i915

2019-03-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108487 --- Comment #15 from Number Nine --- I have the same exact problem on HP Pavilion DV4000 and I do confirm that undefining HAVE_GBM_MODIFIERS (5c8eef147c27a95ebb8ba79e19ebb190b025cbe0) allows Weston to run without --use-pixman. -- You are recei

[Bug 108487] Wayland compositors are unable to use hardware acceleration on i915

2019-03-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108487 --- Comment #16 from Number Nine --- (In reply to magiblot from comment #14) > Created attachment 143267 [details] > Stderr output of weston when run on i915 (with patch from comment #13) > > (In reply to Daniel Stone from comment #13) > > Tha

Re: [PATCH v8] drm/lima: driver for ARM Mali4xx GPUs

2019-03-09 Thread kbuild test robot
Hi Qiang, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.0 next-20190306] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH v8] drm/lima: driver for ARM Mali4xx GPUs

2019-03-09 Thread kbuild test robot
Hi Qiang, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.0 next-20190306] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH v2] drm/fourcc: add ARM GPU tile format

2019-03-09 Thread Qiang Yu
On Sun, Mar 10, 2019 at 10:08 AM Alyssa Rosenzweig wrote: > > > +/* > > + * Arm Device code > > + * > > + * Arm has multiple devices which do not share buffer format, > > + * so add a device field at the MSB of the format field to seperate > > + * each device's encoding. > > + */ > > +#define DRM_

Re: [PATCH v8] drm/lima: driver for ARM Mali4xx GPUs

2019-03-09 Thread Qiang Yu
Hi, This patch should be applied to the drm-misc-next branch: https://github.com/freedesktop/drm-misc/tree/drm-misc-next Regards, Qiang On Sun, Mar 10, 2019 at 10:00 AM kbuild test robot wrote: > > Hi Qiang, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on li

Re: [PATCH v2] drm/fourcc: add ARM GPU tile format

2019-03-09 Thread Qiang Yu
On Sun, Mar 10, 2019 at 10:53 AM Alyssa Rosenzweig wrote: > > > If you think Midgard/Bifrost is compatible with AFBC and don't have it's > > own format, and name "device" is improper, I can rename > > DRM_FORMAT_MOD_ARM_DEVICE_AFBC to DRM_FORMAT_MOD_ARM_TYPE_AFBC > > DRM_FORMAT_MOD_ARM_DEVICE_GPU

Re: [Freedreno] [DPU PATCH 2/3] drm/msm/dp: add displayPort driver support

2019-03-09 Thread chandanu
On 2019-02-14 04:28, chand...@codeaurora.org wrote: Hello Sean I had few more queries regarding your comments. Can you please provide your feedback? (Queries/responses are present below) thanks Chandan On 2018-10-23 09:28, Sean Paul wrote: On Wed, Oct 10, 2018 at 10:15:58AM -0700, Chandan Ud

[Bug 107731] radeon (amdgpu) DisplayPort loss of max-resolution on DP monitor (after monitor power saving / idle)

2019-03-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107731 --- Comment #1 from L.S.S. --- Having similar issues with Manjaro Linux (4.20 Kernel) and AMD video cards. I've a 4K@60Hz capable monitor (Lenovo ThinkVision P27) and an ATEN CS1924 KVM behind it (as I need to use this monitor for 4 different P

[Bug 107731] radeon (amdgpu) DisplayPort loss of max-resolution on DP monitor (after monitor power saving / idle)

2019-03-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107731 --- Comment #2 from L.S.S. --- Some extra information. uname -r 4.20.11-1-MANJARO The correct xrandr output: Screen 0: minimum 320 x 200, current 3840 x 2160, maximum 16384 x 16384 DisplayPort-0 connected primary 3840x2160+0+0 (normal left in

[Bug 107731] radeon (amdgpu) DisplayPort loss of max-resolution on DP monitor (after monitor power saving / idle)

2019-03-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107731 --- Comment #3 from L.S.S. --- Forgot to mention this. Regardless of the circumstances, the EDID I got using "xrandr --prop" is identical to the one when the screen resolution is correct (4K@60Hz), so in my case, the monitor is always correctly