Re: [PATCH libdrm] amdgpu/test: Add illegal register and memory access test.

2018-11-02 Thread Christian König
Am 01.11.18 um 02:44 schrieb Alex Deucher: On Wed, Oct 31, 2018 at 4:05 PM Grodzovsky, Andrey wrote: On 10/31/2018 03:49 PM, Alex Deucher wrote: On Wed, Oct 31, 2018 at 2:33 PM Andrey Grodzovsky wrote: Illegal access will cause CP hang followed by job timeout and recovery kicking in. Also,

[PATCH 1/5] drm: add support of syncobj timeline point wait v4

2018-11-02 Thread Chunming Zhou
points array is one-to-one match with syncobjs array. v2: add seperate ioctl for timeline point wait, otherwise break uapi. v3: userspace can specify two kinds waits:: a. Wait for time point to be completed. b. and wait for time point to become available v4: rebase Signed-off-by: Chunming Zhou Cc

[PATCH 2/5] drm: add timeline syncobj payload query ioctl v2

2018-11-02 Thread Chunming Zhou
user mode can query timeline payload. v2: check return value of copy_to_user Signed-off-by: Chunming Zhou Cc: Daniel Rakos Cc: Jason Ekstrand Cc: Bas Nieuwenhuizen Cc: Dave Airlie Cc: Christian König Cc: Chris Wilson --- drivers/gpu/drm/drm_internal.h | 2 ++ drivers/gpu/drm/drm_ioctl.c

[PATCH 3/5] drm: add timeline support for syncobj export/import

2018-11-02 Thread Chunming Zhou
user space can specify timeline point fence to export/import. Signed-off-by: Chunming Zhou Cc: Daniel Rakos Cc: Jason Ekstrand Cc: Bas Nieuwenhuizen Cc: Dave Airlie Cc: Christian König Cc: Chris Wilson --- drivers/gpu/drm/drm_internal.h | 4 ++ drivers/gpu/drm/drm_ioctl.c| 4 ++ driv

[PATCH 4/5] drm/amdgpu: add timeline support in amdgpu CS v2

2018-11-02 Thread Chunming Zhou
syncobj wait/signal operation is appending in command submission. v2: separate to two kinds in/out_deps functions Signed-off-by: Chunming Zhou Cc: Daniel Rakos Cc: Jason Ekstrand Cc: Bas Nieuwenhuizen Cc: Dave Airlie Cc: Christian König Cc: Chris Wilson --- drivers/gpu/drm/amd/amdgpu/amdgp

[PATCH 5/5] drm/amdgpu: update version for timeline syncobj support in amdgpu

2018-11-02 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 28781414d71c..dba529d65ccd 100644 --- a/drivers/gpu/drm/amd/amdgp

[PATCH libdrm 2/5] addr cs chunk for syncobj timeline

2018-11-02 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- include/drm/amdgpu_drm.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index 1ceec56d..a3c067dd 100644 --- a/include/drm/amdgpu_drm.h +++ b/include/drm/amdgpu_drm.h @@ -517,6 +517,8 @@ struct drm_a

[PATCH libdrm 1/5] [libdrm] new syncobj extension

2018-11-02 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- include/drm/drm.h | 38 ++ 1 file changed, 38 insertions(+) diff --git a/include/drm/drm.h b/include/drm/drm.h index 85c685a2..43d7420a 100644 --- a/include/drm/drm.h +++ b/include/drm/drm.h @@ -711,6 +711,7 @@ struct drm_prime

[PATCH libdrm 3/5] [libdrm]: add timeline wait/query/export/import ioctl

2018-11-02 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- xf86drm.c | 78 +++ xf86drm.h | 8 ++ 2 files changed, 86 insertions(+) diff --git a/xf86drm.c b/xf86drm.c index 49150d74..13f36b04 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -4212,6 +4212,40 @@ drm_public i

[PATCH libdrm 4/5] [libdrm]: wrap syncobj timeline query/wait/export/import APIs for amdgpu v2

2018-11-02 Thread Chunming Zhou
v2: symbos are stored in lexical order. Signed-off-by: Chunming Zhou --- amdgpu/amdgpu-symbol-check | 4 +++ amdgpu/amdgpu.h| 73 ++ amdgpu/amdgpu_cs.c | 62 3 files changed, 139 insertions(+) diff --git a

[PATCH libdrm 5/5] [libdrm] add syncobj timeline tests

2018-11-02 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- tests/amdgpu/Makefile.am | 3 +- tests/amdgpu/amdgpu_test.c | 12 ++ tests/amdgpu/amdgpu_test.h | 21 +++ tests/amdgpu/meson.build | 2 +- tests/amdgpu/syncobj_tests.c | 263 +++ 5 files changed, 299 insertions(+),

Re: [PATCH 1/5] drm: add support of syncobj timeline point wait v4

2018-11-02 Thread Christian König
Am 02.11.18 um 09:25 schrieb Chunming Zhou: points array is one-to-one match with syncobjs array. v2: add seperate ioctl for timeline point wait, otherwise break uapi. v3: userspace can specify two kinds waits:: a. Wait for time point to be completed. b. and wait for time point to become availabl

Re: [PATCH 2/5] drm: add timeline syncobj payload query ioctl v2

2018-11-02 Thread Christian König
Am 02.11.18 um 09:25 schrieb Chunming Zhou: user mode can query timeline payload. v2: check return value of copy_to_user Signed-off-by: Chunming Zhou Cc: Daniel Rakos Cc: Jason Ekstrand Cc: Bas Nieuwenhuizen Cc: Dave Airlie Cc: Christian König Cc: Chris Wilson --- drivers/gpu/drm/drm_in

[Bug 108579] Request new account for IGT

2018-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108579 Daniel Vetter changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

Re: [PATCH 3/5] drm: add timeline support for syncobj export/import

2018-11-02 Thread Christian König
Am 02.11.18 um 09:25 schrieb Chunming Zhou: user space can specify timeline point fence to export/import. Signed-off-by: Chunming Zhou Cc: Daniel Rakos Cc: Jason Ekstrand Cc: Bas Nieuwenhuizen Cc: Dave Airlie Cc: Christian König Cc: Chris Wilson From the coding it looks good to me, but

[Bug 108496] Non functional -d, --dry-run option for the igt_runner

2018-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108496 Petri Latvala changed: What|Removed |Added Assignee|dri-devel@lists.freedesktop |petri.latv...@intel.com

[Bug 108075] [CI][BAT] igt_runner: abort on TAINT_PAGE, TAINT_DIE, and TAINT_OOPS

2018-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108075 Martin Peres changed: What|Removed |Added Summary|[CI][BAT] |[CI][BAT] igt_runner: abort

Re: [Intel-gfx] [v2 1/2] drm: Add colorspace property

2018-11-02 Thread Maarten Lankhorst
Op 31-10-18 om 13:05 schreef Uma Shankar: > This patch adds a colorspace property enabling > userspace to switch to various supported colorspaces. > This will help enable BT2020 along with other colorspaces. > > v2: Addressed Maarten and Ville's review comments. Enhanced > the colorspace enum to in

Re: [Intel-gfx] [v2 2/2] drm/i915: Attach colorspace property and enable modeset

2018-11-02 Thread Maarten Lankhorst
Op 31-10-18 om 13:05 schreef Uma Shankar: > This patch attaches the colorspace connector property to the > hdmi connector. Based on colorspace change, modeset will be > triggered to switch to new colorspace. > > Based on colorspace property value create an infoframe > with appropriate colorspace. T

Re: [PATCH 3/5] drm: add timeline support for syncobj export/import

2018-11-02 Thread zhoucm1
On 2018年11月02日 16:46, Christian König wrote: Am 02.11.18 um 09:25 schrieb Chunming Zhou: user space can specify timeline point fence to export/import. Signed-off-by: Chunming Zhou Cc: Daniel Rakos Cc: Jason Ekstrand Cc: Bas Nieuwenhuizen Cc: Dave Airlie Cc: Christian König Cc: Chris Wil

Re: [Freedreno] [PATCH] drm/msm: Optimize GPU crashstate capture read path

2018-11-02 Thread Sharat Masetty
Thanks for the comments Jordan - On 11/1/2018 8:34 PM, Jordan Crouse wrote: On Thu, Nov 01, 2018 at 02:05:41PM +0530, Sharat Masetty wrote: When the userspace tries to read the crashstate dump, the read side implementation in the driver currently ascii85 encodes all the binary buffers and it do

Re: [PATCH 3/5] drm: add timeline support for syncobj export/import

2018-11-02 Thread Koenig, Christian
Am 02.11.18 um 10:42 schrieb zhoucm1: > > > On 2018年11月02日 16:46, Christian König wrote: >> Am 02.11.18 um 09:25 schrieb Chunming Zhou: >>> user space can specify timeline point fence to export/import. >>> >>> Signed-off-by: Chunming Zhou >>> Cc: Daniel Rakos >>> Cc: Jason Ekstrand >>> Cc: Bas N

[PULL] drm-intel-next for v4.21/v5.1

2018-11-02 Thread Jani Nikula
://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-next-2018-11-02 for you to fetch changes up to 5468a543409653a94344671371ff784703fdcb26: drm/i915: Update DRIVER_DATE to 20181102 (2018-11-02 12:04:11 +0200) The first

[PATCH 1/2] drm/scheduler: Set sched->thread to NULL on failure

2018-11-02 Thread Sharat Masetty
In cases where the scheduler instance is used as a base object of another driver object, it's not clear if the driver can call scheduler cleanup on the fail path. So, Set the sched->thread to NULL, so that the driver can safely call drm_sched_fini() during cleanup. Signed-off-by: Sharat Masetty -

[PATCH 2/2] drm/scheduler: Add a start_timeout_notify() backend function

2018-11-02 Thread Sharat Masetty
Add an optional backend function op which will let the scheduler clients know when the timeout got scheduled on the scheduler instance. This will help drivers with multiple schedulers(one per ring) measure time spent on the ring accurately, eventually helping with better timeout detection. Signed-

Re: [PATCH 3/5] drm: add timeline support for syncobj export/import

2018-11-02 Thread zhoucm1
On 2018年11月02日 17:54, Koenig, Christian wrote: Am 02.11.18 um 10:42 schrieb zhoucm1: On 2018年11月02日 16:46, Christian König wrote: Am 02.11.18 um 09:25 schrieb Chunming Zhou: user space can specify timeline point fence to export/import. Signed-off-by: Chunming Zhou Cc: Daniel Rakos Cc: Jas

Re: [PATCH 2/2] drm/scheduler: Add a start_timeout_notify() backend function

2018-11-02 Thread Koenig, Christian
Am 02.11.18 um 11:31 schrieb Sharat Masetty: > Add an optional backend function op which will let the scheduler clients > know when the timeout got scheduled on the scheduler instance. This will > help drivers with multiple schedulers(one per ring) measure time spent on > the ring accurately, event

[Bug 106175] amdgpu.dc=1 shows performance issues with Xorg compositors when moving windows

2018-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106175 Michel Dänzer changed: What|Removed |Added CC||nicholas.kazlaus...@amd.com --- Comment

Re: [Intel-gfx] [v2 1/2] drm: Add colorspace property

2018-11-02 Thread Ville Syrjälä
On Fri, Nov 02, 2018 at 10:19:10AM +0100, Maarten Lankhorst wrote: > Op 31-10-18 om 13:05 schreef Uma Shankar: > > This patch adds a colorspace property enabling > > userspace to switch to various supported colorspaces. > > This will help enable BT2020 along with other colorspaces. > > > > v2: Addr

[PATCH v2] drm/msm: Move fence put to where failure occurs

2018-11-02 Thread Robert Foss
If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert Foss --- Changes since v1: - Chris Wilson: Make sure that dma_fence_put() is always executed drive

[Bug 108625] AMDGPU - Can't even get Xorg to start - Kernel driver hangs with ring buffer timeout on ARM64

2018-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108625 --- Comment #2 from Carsten Haitzler --- Created attachment 142337 --> https://bugs.freedesktop.org/attachment.cgi?id=142337&action=edit log - dmesg -- You are receiving this mail because: You are the assignee for the bug.___

[Bug 108625] AMDGPU - Can't even get Xorg to start - Kernel driver hangs with ring buffer timeout on ARM64

2018-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108625 --- Comment #3 from Carsten Haitzler --- Created attachment 142338 --> https://bugs.freedesktop.org/attachment.cgi?id=142338&action=edit log - xorg -- You are receiving this mail because: You are the assignee for the bug.

[Bug 108625] AMDGPU - Can't even get Xorg to start - Kernel driver hangs with ring buffer timeout on ARM64

2018-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108625 --- Comment #4 from Carsten Haitzler --- Created attachment 142339 --> https://bugs.freedesktop.org/attachment.cgi?id=142339&action=edit log - xorg - gdb attach + bt -- You are receiving this mail because: You are the assignee for the bug.__

[Bug 108625] AMDGPU - Can't even get Xorg to start - Kernel driver hangs with ring buffer timeout on ARM64

2018-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108625 --- Comment #5 from Carsten Haitzler --- Attached them (too big to put inline as comments). -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-dev

Re: [PATCH v2] drm/msm: Move fence put to where failure occurs

2018-11-02 Thread Chris Wilson
Quoting Robert Foss (2018-11-02 12:13:13) > If dma_fence_wait fails to wait for a supplied in-fence in > msm_ioctl_gem_submit, make sure we release that in-fence. > > Also remove this dma_fence_put() from the 'out' label. > > Signed-off-by: Robert Foss Reviewed-by: Chris Wilson Rob, this prob

Re: [PATCH v2] drm/msm: Move fence put to where failure occurs

2018-11-02 Thread Robert Foss
+stable On 2018-11-02 13:13, Robert Foss wrote: If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert Foss --- Changes since v1: - Chris Wilson: Make s

Re: [PATCH v2] drm/msm: Move fence put to where failure occurs

2018-11-02 Thread Robert Foss
Hey Chris, On 2018-11-02 13:16, Chris Wilson wrote: Quoting Robert Foss (2018-11-02 12:13:13) If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert Foss

[PATCH] drm/selftests: Fix build warning -Wframe-larger-than

2018-11-02 Thread Alexandru-Cosmin Gheorghe
It seems for some random configuration drm_device is bigger than 2048 bytes. The fix is to make the mock objects static variables. Bug reported by 0-DAY Kernel test infrastructure here: https://lists.01.org/pipermail/kbuild-all/2018-November/054431.html Fixes: 6ff3d9ffdcbb ("drm/selftests: Add te

Re: [PATCH v2] drm/msm: Move fence put to where failure occurs

2018-11-02 Thread Greg KH
On Fri, Nov 02, 2018 at 01:29:25PM +0100, Robert Foss wrote: > +stable This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. _

Re: [PATCH v2] drm/msm/dpu: Correct dpu destroy and disable order

2018-11-02 Thread Sean Paul
On Fri, Nov 02, 2018 at 06:19:17PM +0530, Jayant Shekhar wrote: > In case of msm drm bind failure, dpu_mdss_destroy is triggered. > In this function, resources are freed and pm runtime disable is > called, which triggers dpu_mdss_disable. Now in dpu_mdss_disable, > driver tries to access a memory w

Re: [Freedreno] [PATCH 2/2] drm/scheduler: Add a start_timeout_notify() backend function

2018-11-02 Thread Sharat Masetty
On 11/2/2018 4:09 PM, Koenig, Christian wrote: Am 02.11.18 um 11:31 schrieb Sharat Masetty: Add an optional backend function op which will let the scheduler clients know when the timeout got scheduled on the scheduler instance. This will help drivers with multiple schedulers(one per ring) meas

[PATCH 2/3] drm/file: Uncompact the feature flags

2018-11-02 Thread Daniel Vetter
This essentially undoes commit 39868bd7668bd47308b1dfd97c212757caee764f Author: Chris Wilson Date: Tue Oct 29 08:55:58 2013 + drm: Compact booleans within struct drm_file We do lockless access to these flags everywhere, and it's kinda not a great idea to mix lockless and bitfields. As

[PATCH 3/3] drm/lease: look at ->universal_planes only once

2018-11-02 Thread Daniel Vetter
It's lockless, and userspace might chance it underneath us. That's not really a problem, all userspace gets is a slightly dysfunctional lease with the current code. But this might change, and gcc might decide to reload a few too many times, and then boom. So better safe than sorry. Cc: Keith Packa

[PATCH 1/3] drm/lease: debug output for lease creation

2018-11-02 Thread Daniel Vetter
I spent a bit of time scratching heads and figuring out why the igts don't work. Probably useful to keep this work. Cc: Keith Packard Cc: Dave Airlie Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_lease.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --g

Re: [PATCH] drm/selftests: Fix build warning -Wframe-larger-than

2018-11-02 Thread Maarten Lankhorst
Op 02-11-18 om 14:01 schreef Alexandru-Cosmin Gheorghe: > It seems for some random configuration drm_device is bigger than 2048 > bytes. > The fix is to make the mock objects static variables. > > Bug reported by 0-DAY Kernel test infrastructure here: > https://lists.01.org/pipermail/kbuild-all/201

Re: [PATCH 2/5] drm/virtio: add uapi for in and out explicit fences

2018-11-02 Thread Emil Velikov
On Thu, 1 Nov 2018 at 12:56, Robert Foss wrote: > On 2018-10-31 10:38, Emil Velikov wrote: > > Hi Rob, > > > > On Thu, 25 Oct 2018 at 19:38, Robert Foss wrote: > >> > >> Add a new field called fence_fd that will be used by userspace to send > >> in-fences to the kernel and receive out-fences crea

Re: [Freedreno] [PATCH 2/2] drm/scheduler: Add a start_timeout_notify() backend function

2018-11-02 Thread Koenig, Christian
Am 02.11.18 um 14:25 schrieb Sharat Masetty: > > > On 11/2/2018 4:09 PM, Koenig, Christian wrote: >> Am 02.11.18 um 11:31 schrieb Sharat Masetty: >>> Add an optional backend function op which will let the scheduler >>> clients >>> know when the timeout got scheduled on the scheduler instance. This

[Bug 107141] Manual setting of pp_dpm_sclk resets after monitor off/on (rx 480)

2018-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107141 Michel Dänzer changed: What|Removed |Added CC||tempel.jul...@gmail.com --- Comment #3

[Bug 108613] amdgpu.dc=1 + xf86-video-amdgpu: changing to a GPU upscaling resolution resets pp_dpm_mclk

2018-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108613 Michel Dänzer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW

Re: [Freedreno] [PATCH] drm/msm: Optimize GPU crashstate capture read path

2018-11-02 Thread Jordan Crouse
On Fri, Nov 02, 2018 at 03:12:51PM +0530, Sharat Masetty wrote: > Thanks for the comments Jordan - > > On 11/1/2018 8:34 PM, Jordan Crouse wrote: > >On Thu, Nov 01, 2018 at 02:05:41PM +0530, Sharat Masetty wrote: > >>When the userspace tries to read the crashstate dump, the read side > >>implement

RE: [Intel-gfx] [v2 1/2] drm: Add colorspace property

2018-11-02 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Friday, November 2, 2018 5:00 PM >To: Maarten Lankhorst >Cc: Shankar, Uma ; dri-devel@lists.freedesktop.org; >intel-...@lists.freedesktop.org; Syrjala, Ville ; >Lankhorst, Maarten ; Hans Verkuil > >Sub

RE: [Intel-gfx] [v2 2/2] drm/i915: Attach colorspace property and enable modeset

2018-11-02 Thread Shankar, Uma
>-Original Message- >From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] >Sent: Friday, November 2, 2018 2:53 PM >To: Shankar, Uma ; dri-devel@lists.freedesktop.org; >intel-...@lists.freedesktop.org >Cc: Syrjala, Ville ; a...@redhat.com; Lankhorst, >Maarten > >Subject: Re:

Re: [PATCH libdrm] amdgpu/test: Add illegal register and memory access test.

2018-11-02 Thread Michel Dänzer
On 2018-10-31 7:33 p.m., Andrey Grodzovsky wrote: > Illegal access will cause CP hang followed by job timeout and > recovery kicking in. > Also, disable the suite for all APU ASICs until GPU > reset issues for them will be resolved and GPU reset recovery > will be enabled by default. > > Signed-of

Re: [Intel-gfx] [v2 1/2] drm: Add colorspace property

2018-11-02 Thread Jonas Karlman
On 2018-11-02 15:13, Shankar, Uma wrote: > >> -Original Message- >> From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >> Sent: Friday, November 2, 2018 5:00 PM >> To: Maarten Lankhorst >> Cc: Shankar, Uma ; dri-devel@lists.freedesktop.org; >> intel-...@lists.freedesktop.org; Syrja

[PATCH] drm/msm/dpu: Don't use devm for component devices

2018-11-02 Thread Jordan Crouse
Devices that are bound as components should not use devm since device managed memory is not freed when the component is unbound. In particular this is an issue if the component bind fails due to an -EPROBE_DEFER. In this case the bind would try again later and any devm managed memory allocated dur

[PATCH] drm/lease: drop EXPORT_SYMBOL

2018-11-02 Thread Daniel Vetter
Leases are entirely implemented within drm.ko, no need to even tempt drivers into doing nasty things. And if there's really a need, we can always re-export these again. Cc: Keith Packard Cc: Dave Airlie Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_lease.c | 4 1 file changed, 4 de

Re: [Freedreno] [PATCH v2] drm/msm/dpu: Correct dpu destroy and disable order

2018-11-02 Thread Jordan Crouse
On Fri, Nov 02, 2018 at 06:19:17PM +0530, Jayant Shekhar wrote: > In case of msm drm bind failure, dpu_mdss_destroy is triggered. > In this function, resources are freed and pm runtime disable is > called, which triggers dpu_mdss_disable. Now in dpu_mdss_disable, > driver tries to access a memory w

Re: [Freedreno] [PATCH] drm/msm/dpu: Don't use devm for component devices

2018-11-02 Thread Sean Paul
On Fri, Nov 02, 2018 at 08:30:08AM -0600, Jordan Crouse wrote: > Devices that are bound as components should not use devm since > device managed memory is not freed when the component is > unbound. > > In particular this is an issue if the component bind fails > due to an -EPROBE_DEFER. In this ca

Re: [PATCH 2/5] drm/virtio: add uapi for in and out explicit fences

2018-11-02 Thread Robert Foss
Hey Emil, On 2018-11-02 14:34, Emil Velikov wrote: On Thu, 1 Nov 2018 at 12:56, Robert Foss wrote: On 2018-10-31 10:38, Emil Velikov wrote: Hi Rob, On Thu, 25 Oct 2018 at 19:38, Robert Foss wrote: Add a new field called fence_fd that will be used by userspace to send in-fences to the kern

[Bug 108637] kernel 4.19.0-arch1-1-ARCH - raven ridge

2018-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108637 Bug ID: 108637 Summary: kernel 4.19.0-arch1-1-ARCH - raven ridge Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: normal

[Bug 108637] kernel 4.19.0-arch1-1-ARCH - raven ridge

2018-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108637 --- Comment #1 from bibitocarlos --- Created attachment 142343 --> https://bugs.freedesktop.org/attachment.cgi?id=142343&action=edit xorg.log -- You are receiving this mail because: You are the assignee for the bug.__

[Bug 108637] kernel 4.19.0-arch1-1-ARCH - raven ridge

2018-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108637 --- Comment #2 from bibitocarlos --- Created attachment 142344 --> https://bugs.freedesktop.org/attachment.cgi?id=142344&action=edit and i cant watch video with kodi -- You are receiving this mail because: You are the assignee for the bug.__

[Bug 108637] kernel 4.19.0-arch1-1-ARCH - raven ridge

2018-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108637 --- Comment #3 from bibitocarlos --- Created attachment 142346 --> https://bugs.freedesktop.org/attachment.cgi?id=142346&action=edit journalctl with kodi bug -- You are receiving this mail because: You are the assignee for the bug.__

Re: [PATCH 1/3] drm/lease: debug output for lease creation

2018-11-02 Thread Keith Packard
Daniel Vetter writes: > I spent a bit of time scratching heads and figuring out why the igts > don't work. Probably useful to keep this work. Acked-by: Keith Packard > /* Do not allow sub-leases */ > - if (lessor->lessor) > + if (lessor->lessor) { > + DRM_DEBUG_LEASE(

Re: [PATCH 3/3] drm/lease: look at ->universal_planes only once

2018-11-02 Thread Keith Packard
Daniel Vetter writes: > @@ -359,7 +359,8 @@ void drm_lease_revoke(struct drm_master *top) > static int validate_lease(struct drm_device *dev, > struct drm_file *lessor_priv, > int object_count, > - struct drm_mode_object **obj

Re: [PATCH] drm/lease: drop EXPORT_SYMBOL

2018-11-02 Thread Keith Packard
Daniel Vetter writes: > Leases are entirely implemented within drm.ko, no need to even tempt > drivers into doing nasty things. And if there's really a need, we can > always re-export these again. > > Cc: Keith Packard > Cc: Dave Airlie > Signed-off-by: Daniel Vetter Acked-by: Keith Packard

[PATCH 02/10] drm/msm/gpu: Allocate the correct size for the GPU memptrs

2018-11-02 Thread Jordan Crouse
Allocate the correct buffer size for the GPU memptrs. The incorrect size hasn't affected us thus far since the incorrect size was larger than the intended size and we're still stuck on page sized granularity anyway but technically correct is the best kind of correct. Signed-off-by: Jordan Crouse

[PATCH 06/10] drm/msm/gpu: Only store local command buffers in the GPU state

2018-11-02 Thread Jordan Crouse
Instead of trying to store all the tagged buffers from a hanging submit only store the command buffers that were not imported. This cuts down on the amount of data stored in the GPU state to the base minimum of useful information. The downside is that this will make it more difficult to successful

[PATCH 00/10] v2: drm/msm/gpu updates for 4.21

2018-11-02 Thread Jordan Crouse
Resend of [1] with the order rearranged to put a6xx gpu state at the end and attach an add-on patch to better manage a6xx state memory. I think everything here is good to go for 4.21 (maybe even some 4.20 fixes) but I can understand if we want to let the gpu state soak for another cycle. Sharat ha

[PATCH 01/10] drm/msm: Update generated headers

2018-11-02 Thread Jordan Crouse
Resync the a6xx generated headers from the database. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a6xx.xml.h | 54 +-- 1 file changed, 42 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx.xml.h b/drivers/gpu/drm/msm/adreno/a6xx.x

[PATCH 03/10] drm/msm: Gracefully handle failure in _msm_gem_kernel_new

2018-11-02 Thread Jordan Crouse
If any of the function calls in _msm_gem_kernel_new fail we need to make sure to dereference the GEM object with the appropriate function for the current locking state. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/msm_gem.c | 18 -- 1 file changed, 12 insertions(+), 6 del

[PATCH 04/10] drm/msm/gpu: Add per-submission statistics

2018-11-02 Thread Jordan Crouse
Add infrastructure to track statistics for GPU submissions by sampling certain perfcounters before and after a submission. To store the statistics, the per-ring memptrs region is expanded to include room for up to 64 entries - this should cover a reasonable amount of inflight submissions without w

[PATCH 09/10] drm/msm/a6xx: Add a6xx gpu state

2018-11-02 Thread Jordan Crouse
Add support for gathering and dumping the a6xx GPU state including registers, GMU registers, indexed registers, shader blocks, context clusters and debugbus. v2: Fix bugs discovered by Sharat Masetty Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/Makefile|1 + drivers/

[PATCH 08/10] drm/msm/adreno: Don't capture register values if target doesn't define them

2018-11-02 Thread Jordan Crouse
If the GPU target doesn't define a list of registers then gracefully skip capturing and/or printing them. This is used by more complex targets like 6xx that have other means of capturing register values. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 19 ++

[PATCH 05/10] drm/msm/gpu: Add trace events for tracking GPU submissions

2018-11-02 Thread Jordan Crouse
Add trace events to track the progress of a GPU submission msm_gpu_submit occurs at the beginning of the submissions, msm_gpu_submit_flush happens when the submission is put on the ringbuffer and msm_submit_flush_retired is sent when the operation is retired. To make it easier to track the operati

[PATCH 07/10] drm/msm/gpu: Move gpu_poll_timeout() to adreno_gpu.h

2018-11-02 Thread Jordan Crouse
The gpu_poll_timeout() function can be useful to multiple targets so mvoe it into adreno_gpu.h from the a5xx code. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 5 - drivers/gpu/drm/msm/adreno/adreno_gpu.h | 6 ++ 2 files changed, 6 insertions(+), 5 deletions

[PATCH 10/10] drm/msm/a6xx: Track and manage a6xx state memory

2018-11-02 Thread Jordan Crouse
The a6xx GPU state allocates a LOT of memory. Add a bit of infrastructure to track the memory allocations in the GPU structure and delete them when the state is destroyed much the same way that devm works with the device model as a whole. This protects against the developer accidentally forgetting

Re: [Intel-gfx] [v2 2/2] drm/i915: Attach colorspace property and enable modeset

2018-11-02 Thread Ville Syrjälä
On Fri, Nov 02, 2018 at 02:18:42PM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > >Sent: Friday, November 2, 2018 2:53 PM > >To: Shankar, Uma ; dri-devel@lists.freedesktop.org; > >intel-...@lists.freedesktop.org

Re: [Intel-gfx] [v2 2/2] drm/i915: Attach colorspace property and enable modeset

2018-11-02 Thread Maarten Lankhorst
Op 02-11-18 om 16:41 schreef Ville Syrjälä: > On Fri, Nov 02, 2018 at 02:18:42PM +, Shankar, Uma wrote: >> >>> -Original Message- >>> From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] >>> Sent: Friday, November 2, 2018 2:53 PM >>> To: Shankar, Uma ; dri-devel@lists.free

Re: [Intel-gfx] [v2 2/2] drm/i915: Attach colorspace property and enable modeset

2018-11-02 Thread Ville Syrjälä
On Fri, Nov 02, 2018 at 04:44:10PM +0100, Maarten Lankhorst wrote: > Op 02-11-18 om 16:41 schreef Ville Syrjälä: > > On Fri, Nov 02, 2018 at 02:18:42PM +, Shankar, Uma wrote: > >> > >>> -Original Message- > >>> From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > >>> Sen

[Bug 108577] Black X laptop screen with cursor if HDMI not plugged in, bisected

2018-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108577 --- Comment #20 from Alex Deucher --- Created attachment 142348 --> https://bugs.freedesktop.org/attachment.cgi?id=142348&action=edit possible fix 2/2 -- You are receiving this mail because: You are the assignee for the bug._

[Bug 108577] Black X laptop screen with cursor if HDMI not plugged in, bisected

2018-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108577 --- Comment #19 from Alex Deucher --- Created attachment 142347 --> https://bugs.freedesktop.org/attachment.cgi?id=142347&action=edit possible fix 1/2 Do these patches fix the issue? -- You are receiving this mail because: You are the assig

Re: [PATCH libdrm] amdgpu/test: Add illegal register and memory access test.

2018-11-02 Thread Grodzovsky, Andrey
On 11/02/2018 10:24 AM, Michel Dänzer wrote: > On 2018-10-31 7:33 p.m., Andrey Grodzovsky wrote: >> Illegal access will cause CP hang followed by job timeout and >> recovery kicking in. >> Also, disable the suite for all APU ASICs until GPU >> reset issues for them will be resolved and GPU reset

[RFC PATCH v2] android: ion: How to properly clean caches for uncached allocations

2018-11-02 Thread Liam Mark
Based on the suggestions from Laura I created a first draft for a change which will attempt to ensure that uncached mappings are only applied to ION memory who's cache lines have been cleaned. It does this by providing cached mappings (for uncached ION allocations) until the ION buffer is dma ma

RE: [RFC] drm/bridge/sii902x: Fix EDID readback

2018-11-02 Thread Fabrizio Castro
Hello Peter, Thank you for your feedback! > > The "mux-locked" implementation was the one I first tried and I discovered > > it doesn't work for me, as other traffic on the parent adapter can get in > > the > > way. What we need for this device is no other traffic on the bus during the > > "sele

Performance regression in ast drm driver

2018-11-02 Thread Jean Delvare
Hi David, The following commit: commit 7cf321d118a825c1541b43ca45294126fd474efa Author: Dave Airlie Date: Mon Oct 24 15:37:48 2016 +1000 drm/drivers: add support for using the arch wc mapping API. is causing a huge performance regression for the ast drm driver. In a text console, if I cal

[PATCH 1/2] uapi: fix linux/kfd_ioctl.h userspace compilation errors

2018-11-02 Thread Dmitry V. Levin
Consistently use types provided by via to fix the following linux/kfd_ioctl.h userspace compilation errors: /usr/include/linux/kfd_ioctl.h:250:2: error: unknown type name 'uint32_t' uint32_t reset_type; /usr/include/linux/kfd_ioctl.h:251:2: error: unknown type name 'uint32_t' uint32_t reset_

RE: [RFC] drm/bridge/sii902x: Fix EDID readback

2018-11-02 Thread Fabrizio Castro
Hello Mark, Thank you for your feedback! > Subject: Re: [RFC] drm/bridge/sii902x: Fix EDID readback > > On Wed, Oct 31, 2018 at 04:55:53PM +, Fabrizio Castro wrote: > > > Having the option of using "unlocked" flavours of reads and writes > > is what we need here, but looking at drivers/base/r

[PATCH v2] drm/msm/dpu: Correct dpu destroy and disable order

2018-11-02 Thread Jayant Shekhar
In case of msm drm bind failure, dpu_mdss_destroy is triggered. In this function, resources are freed and pm runtime disable is called, which triggers dpu_mdss_disable. Now in dpu_mdss_disable, driver tries to access a memory which is already freed. This results in kernel panic. Fix this by ensurin

Re: [RFC] drm/bridge/sii902x: Fix EDID readback

2018-11-02 Thread Peter Rosin
On 2018-11-01 12:04, Fabrizio Castro wrote: > Hello Peter, > > Thank you for your feedback! > > snip > >>> Yeah, there is some issue with locking here, and that's coming down >>> from the fact that when we call into drm_get_edid, we implicitly call >>> i2c_transfer which ultimately locks the i2c

Re: [PATCH v3 1/1] drm/panel: Add support for Olimex LCD-OLinuXino panel

2018-11-02 Thread Stefan Mavrodiev
On 7/16/18 6:08 PM, Rob Herring wrote: On Thu, Jul 12, 2018 at 11:21:53AM +0300, Stefan Mavrodiev wrote: This patch adds Olimex Ltd. LCD-OLinuXino bridge panel driver. The panel is used with different LCDs (currently from 480x272 to 1280x800). Small EEPROM chip is used for identification, which

[PATCH] drm/i915: intel_pipe_config_compare: Don't compare DSI PLL regs when adjusting

2018-11-02 Thread Hans de Goede
The GOP sometimes initializes the DSI pclk at a (slightly) different freq then the pclk which we pick. intel_pipe_config_compare() allows for this by doing a fuzzy compare on the port_clock. But the pclk difference not only results in the port_clock and base.adjusted_mode.crtc_clock clocks being a

[PATCH] drm/bridge/sii902x: Fix EDID readback

2018-11-02 Thread Fabrizio Castro
While adding SiI9022A support to the iwg23s board, it came up that when the HDMI transmitter is in pass through mode the device is not compliant with the I2C specification anymore, as it requires a far bigger tbuf, due to a delay the HDMI transmitter is adding when relaying the STOP condition on th

[PATCH] backlight/arcxcnn support newer chips in arcxcnn family and fix vendor prefix

2018-11-02 Thread Brian Dodge
Support for ArcticSand arc1 and arc3 ships is added. Some ranges and control paths are modified based on the chip id probed via i2c. Also updates vendor prefix to arctic from arc which was a mistake in the original driver submission Signed-off-by: Brian Dodge --- .../bindings/leds/backlight/arcx

RE: [RFC] drm/bridge/sii902x: Fix EDID readback

2018-11-02 Thread Fabrizio Castro
Hello Peter, Again, thank you very much for your precious comments. I'll send a patch out shortly addressing all of the comments I have received so far, including yours. Cheers, Fab > Subject: Re: [RFC] drm/bridge/sii902x: Fix EDID readback > > On 2018-11-01 18:32, Fabrizio Castro wrote: > > He

RE: [PATCH] drm/bridge/sii902x: Fix EDID readback

2018-11-02 Thread Fabrizio Castro
Hello Peter, Thank you for your feedback! > > +static int sii902x_i2c_bypass_select(struct i2c_mux_core *mux, u32 chan_id) > > +{ > > +struct sii902x *sii902x = i2c_mux_priv(mux); > > +struct device *dev = &sii902x->i2c->dev; > > +unsigned long timeout; > > +u8 status; > > +int ret; > > + > > +re

[[DPU PATCH]] drm/msm/dpu: Correct dpu destroy and disable order

2018-11-02 Thread Jayant Shekhar
In case of msm drm bind failure, dpu_mdss_destroy is triggered. In this function, resources are freed and pm runtime disable is called, which triggers dpu_mdss_disable. Now in dpu_mdss_disable, driver tries to access a memory which is already freed. This results in kernel panic. Fix this by ensurin

[PATCH] backlight/arcxcnn user proper vendor prefix in device tree bindings

2018-11-02 Thread Brian Dodge
The vendor-prefixes.txt file properly refers to ArcticSand as "arctic" while the actual backlight driver and the device tree bindings for it improperly use "arc". The bindings are also modified to support newer backlight chips in the arcxcnn family Signed-off-by: Brian Dodge --- .../bindings/led

[PATCH 2/2] uapi: fix more linux/kfd_ioctl.h userspace compilation errors

2018-11-02 Thread Dmitry V. Levin
Consistently use types provided by via to fix struct kfd_ioctl_get_queue_wave_state_args userspace compilation errors. Fixes: 5df099e8bc83f ("drm/amdkfd: Add wavefront context save state retrieval ioctl") Signed-off-by: Dmitry V. Levin --- include/uapi/linux/kfd_ioctl.h | 10 +- 1 fil

RE: [RFC] drm/bridge/sii902x: Fix EDID readback

2018-11-02 Thread Fabrizio Castro
Hello Peter, Thank you for your feedback! > Subject: Re: [RFC] drm/bridge/sii902x: Fix EDID readback snip > > > > To further detail the problem, the system is vulnerable from before the > > last write > > performed by sii902x_i2c_bypass_select to after we confirm we need the > > switch > > to

  1   2   >